Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 08.11.2023 14:28, Nicola Vetrini wrote: > On 2023-11-08 12:19, Jan Beulich wrote: >> On 08.11.2023 12:03, Nicola Vetrini wrote: >>> On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > pointer derefer

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 08.11.2023 14:33, Julien Grall wrote: > Hi Jan, > > On 08/11/2023 11:19, Jan Beulich wrote: >> On 08.11.2023 12:03, Nicola Vetrini wrote: >>> On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > poin

Re: [XEN PATCH][for-4.19 v4 1/8] xen/include: add macro ISOLATE_LOW_BIT

2023-11-08 Thread Jan Beulich
On 31.10.2023 08:43, Jan Beulich wrote: > What I would consider scope creep I > specifically didn't even ask for: I'd like this macro to be overridable > by an arch. Specifically (see my earlier naming hint) I'd like to use > x86's BMI insn BLSI in the context of "x86: allow Kconfig control over >

[linux-5.4 test] 183714: tolerable trouble: fail/pass/starved - PUSHED

2023-11-08 Thread osstest service owner
flight 183714 linux-5.4 real [real] flight 183719 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183714/ http://logs.test-lab.xenproject.org/osstest/logs/183719/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armh

Re: [PATCH for-4.18 2/3] docs/sphinx: Fix syntax issues in exclude-list.rst

2023-11-08 Thread Henry Wang
Hi, > On Nov 8, 2023, at 23:30, Luca Fancellu wrote: > >> On 8 Nov 2023, at 15:27, Andrew Cooper wrote: >> >> sphinx-build reports: >> >> docs/misra/exclude-list.rst:47: WARNING: Unexpected indentation. >> docs/misra/exclude-list.rst:50: WARNING: Inline emphasis start-string >> without end-s

Re: [PATCH for-4.18 3/3] docs/sphinx: Fix indexing

2023-11-08 Thread Henry Wang
Hi, > On Nov 8, 2023, at 23:27, Andrew Cooper wrote: > > sphinx-build reports: > > docs/designs/launch/hyperlaunch.rst: WARNING: document isn't included in any > toctree > docs/designs/launch/hyperlaunch-devicetree.rst: WARNING: document isn't > included in any toctree > docs/misc/xen-make

Re: [PATCH for-4.18 1/3] docs/sphinx: Fix syntax issues in hyperlaunch.rst

2023-11-08 Thread Henry Wang
Hi Andrew, > On Nov 8, 2023, at 23:27, Andrew Cooper wrote: > > sphinx-build reports: > > docs/designs/launch/hyperlaunch.rst:111: WARNING: Title underline too short. > docs/designs/launch/hyperlaunch.rst:203: WARNING: Unexpected indentation. > docs/designs/launch/hyperlaunch.rst:216: WARNIN

[linux-linus test] 183713: tolerable trouble: fail/pass/starved - PUSHED

2023-11-08 Thread osstest service owner
flight 183713 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183713/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183708 test-amd64-amd64-xl-qemuu-win7-amd64

[PATCH v5] acpi/processor: sanitize _OSC/_PDC capabilities for Xen dom0

2023-11-08 Thread Jason Andryuk
From: Roger Pau Monne The Processor capability bits notify ACPI of the OS capabilities, and so ACPI can adjust the return of other Processor methods taking the OS capabilities into account. When Linux is running as a Xen dom0, the hypervisor is the entity in charge of processor power management,

Re: Remaining violations of MISRA Rule 7.4

2023-11-08 Thread Andrew Cooper
On 08/11/2023 4:24 pm, Nicola Vetrini wrote: > Hi everyone, > > I was looking at leftover violations for MISRA Rule 7.4: > 'A string literal shall not be assigned to an object unless the > object's type > is "pointer to const-qualified char" ' > > You can see the referenced violations at [1] and [2

[xen-unstable test] 183712: tolerable trouble: fail/pass/starved - PUSHED

2023-11-08 Thread osstest service owner
flight 183712 xen-unstable real [real] flight 183716 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183712/ http://logs.test-lab.xenproject.org/osstest/logs/183716/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armh

Re: [XEN PATCH v2] xen/sched: address violations of MISRA C:2012 Rule 8.2

2023-11-08 Thread Federico Serafini
On 10/10/23 03:26, Henry Wang wrote: Hi, On Oct 10, 2023, at 09:25, Stefano Stabellini wrote: On Mon, 9 Oct 2023, Federico Serafini wrote: Add missing parameter names. No functional change. Signed-off-by: Federico Serafini Reviewed-by: Stefano Stabellini Release-acked-by: Henry Wang

Re: [XEN PATCH v3 2/3] docs: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 17:25, Julien Grall wrote: Hi Stefano, On 07/11/2023 20:41, Stefano Stabellini wrote: +Julien, Andrew Julien and Andrew raised concerns on this patch on the Xen Matrix channel. Please provide further details. Thanks! It looks like I was already CCed but this likely got lost wit

Re: [PATCH v4] acpi/processor: sanitize _OSC/_PDC capabilities for Xen dom0

2023-11-08 Thread Roger Pau Monné
On Wed, Nov 01, 2023 at 09:41:52AM -0400, Jason Andryuk wrote: > From: Roger Pau Monne > > The Processor capability bits notify ACPI of the OS capabilities, and > so ACPI can adjust the return of other Processor methods taking the OS > capabilities into account. > > When Linux is running as a Xe

Re: [XEN PATCH v2] xen/arm: traps: address a violation of MISRA C:2012 Rule 8.2

2023-11-08 Thread Federico Serafini
On 08/11/23 17:30, Julien Grall wrote: Hi Federico, On 08/11/2023 16:21, Federico Serafini wrote: On 08/11/23 17:04, Julien Grall wrote: Hi, On 08/11/2023 15:42, Federico Serafini wrote: Add missing parameter name "regs" and introduce function type bug_fn_t: this improves readability and hel

Re: [XEN PATCH v2] xen/arm: traps: address a violation of MISRA C:2012 Rule 8.2

2023-11-08 Thread Julien Grall
Hi Federico, On 08/11/2023 16:21, Federico Serafini wrote: On 08/11/23 17:04, Julien Grall wrote: Hi, On 08/11/2023 15:42, Federico Serafini wrote: Add missing parameter name "regs" and introduce function type bug_fn_t: this improves readability and helps to validate that the function passed

Re: [XEN PATCH v3 2/3] docs: make the docs for MISRA C:2012 Dir 4.1 visible to ECLAIR

2023-11-08 Thread Julien Grall
Hi Stefano, On 07/11/2023 20:41, Stefano Stabellini wrote: +Julien, Andrew Julien and Andrew raised concerns on this patch on the Xen Matrix channel. Please provide further details. Thanks! It looks like I was already CCed but this likely got lost with all the MISRA patches... On Matrix, t

Remaining violations of MISRA Rule 7.4

2023-11-08 Thread Nicola Vetrini
Hi everyone, I was looking at leftover violations for MISRA Rule 7.4: 'A string literal shall not be assigned to an object unless the object's type is "pointer to const-qualified char" ' You can see the referenced violations at [1] and [2]. I think the ones in x86/setup.c can be taken care of

Re: [XEN PATCH v2] xen/arm: traps: address a violation of MISRA C:2012 Rule 8.2

2023-11-08 Thread Federico Serafini
On 08/11/23 17:04, Julien Grall wrote: Hi, On 08/11/2023 15:42, Federico Serafini wrote: Add missing parameter name "regs" and introduce function type bug_fn_t: this improves readability and helps to validate that the function passed to run_in_exception_handle() has the expected prototype. No f

Re: [XEN PATCH v2] xen/arm: traps: address a violation of MISRA C:2012 Rule 8.2

2023-11-08 Thread Julien Grall
Hi, On 08/11/2023 15:42, Federico Serafini wrote: Add missing parameter name "regs" and introduce function type bug_fn_t: this improves readability and helps to validate that the function passed to run_in_exception_handle() has the expected prototype. No functional change. Suggested-by: Julien

[XEN PATCH v2] xen/arm: traps: address a violation of MISRA C:2012 Rule 8.2

2023-11-08 Thread Federico Serafini
Add missing parameter name "regs" and introduce function type bug_fn_t: this improves readability and helps to validate that the function passed to run_in_exception_handle() has the expected prototype. No functional change. Suggested-by: Julien Grall Signed-off-by: Federico Serafini --- Changes

Re: [PATCH for-4.18 2/3] docs/sphinx: Fix syntax issues in exclude-list.rst

2023-11-08 Thread Luca Fancellu
> On 8 Nov 2023, at 15:27, Andrew Cooper wrote: > > sphinx-build reports: > > docs/misra/exclude-list.rst:47: WARNING: Unexpected indentation. > docs/misra/exclude-list.rst:50: WARNING: Inline emphasis start-string > without end-string. > > Nested lists require newlines as delimiters, and

[PATCH for-4.18 3/3] docs/sphinx: Fix indexing

2023-11-08 Thread Andrew Cooper
sphinx-build reports: docs/designs/launch/hyperlaunch.rst: WARNING: document isn't included in any toctree docs/designs/launch/hyperlaunch-devicetree.rst: WARNING: document isn't included in any toctree docs/misc/xen-makefiles/makefiles.rst: WARNING: document isn't included in any toctree

[PATCH for-4.18 0/3] docs/sphinx: Fix syntax errors and warnings

2023-11-08 Thread Andrew Cooper
Given the two mandatory 4.18 fixes, this is the remainder of the work I have been threatening to do for a while. Preferrably for 4.18 too, seeing as this gets our Sphinx docs into better shape. I still want to make sphinx problems fatal in gitlab, but that will have to wait for now. Andrew Coope

[PATCH for-4.18 2/3] docs/sphinx: Fix syntax issues in exclude-list.rst

2023-11-08 Thread Andrew Cooper
sphinx-build reports: docs/misra/exclude-list.rst:47: WARNING: Unexpected indentation. docs/misra/exclude-list.rst:50: WARNING: Inline emphasis start-string without end-string. Nested lists require newlines as delimiters, and * either needs escaping, or put in a literal block. Signed-off-by

[PATCH for-4.18 1/3] docs/sphinx: Fix syntax issues in hyperlaunch.rst

2023-11-08 Thread Andrew Cooper
sphinx-build reports: docs/designs/launch/hyperlaunch.rst:111: WARNING: Title underline too short. docs/designs/launch/hyperlaunch.rst:203: WARNING: Unexpected indentation. docs/designs/launch/hyperlaunch.rst:216: WARNING: Unexpected indentation. Nested lists require newlines as delimiters.

[PATCH for-4.18] docs: Delete kconfig docs to fix licensing violation

2023-11-08 Thread Andrew Cooper
These 3 Kconfig docs were imported from Linux erroneously. They are GPL-2.0-only in Linux, but have no SPDX tag and were placed in such a way to be included by the blanket statement saying that all RST files are CC-BY-4.0. We should not be carrying a shadow copy of these docs. They aren't even w

Re: [PATCH for-4.18] docs/misra: Add missing SPDX tags

2023-11-08 Thread Henry Wang
Hi Andrew, > On Nov 8, 2023, at 22:18, Andrew Cooper wrote: > > Two files are missing SDPX tags, but are covered by the blanketing license > statement in docs/README.sources saying that RST files are CC-BY-4.0 > > Fixes: 3c911be55f1c ("docs/misra: document the C dialect and translation > toolc

[PATCH for-4.18] docs/misra: Add missing SPDX tags

2023-11-08 Thread Andrew Cooper
Two files are missing SDPX tags, but are covered by the blanketing license statement in docs/README.sources saying that RST files are CC-BY-4.0 Fixes: 3c911be55f1c ("docs/misra: document the C dialect and translation toolchain assumptions.") Fixes: 7211904e09bd ("docs/misra: add documentation ske

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 14:37, Andrew Cooper wrote: On 03/11/2023 5:58 pm, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also pro

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Andrew Cooper
On 03/11/2023 5:58 pm, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > pointer dereference at line 760 (the memcpy call) > of xen/common/domain.c. This ASSERT helps them in > detecting that such a condition is not possible > and also provides a basic sanity check. > > Sig

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Julien Grall
Hi Jan, On 08/11/2023 11:19, Jan Beulich wrote: On 08.11.2023 12:03, Nicola Vetrini wrote: On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 12:19, Jan Beulich wrote: On 08.11.2023 12:03, Nicola Vetrini wrote: On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This

Re: [PATCH v12 01/37] x86/cpufeatures: Add the cpu feature bit for WRMSRNS

2023-11-08 Thread Borislav Petkov
On Mon, Oct 02, 2023 at 11:24:22PM -0700, Xin Li wrote: > Subject: Re: [PATCH v12 01/37] x86/cpufeatures: Add the cpu feature bit for > WRMSRNS For all your text: s/cpu/CPU/g > WRMSRNS is an instruction that behaves exactly like WRM

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 08.11.2023 12:03, Nicola Vetrini wrote: > On 2023-11-08 09:24, Jan Beulich wrote: >> On 03.11.2023 18:58, Nicola Vetrini wrote: >>> Static analysis tools may detect a possible null >>> pointer dereference at line 760 (the memcpy call) >>> of xen/common/domain.c. This ASSERT helps them in >>> det

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 09:24, Jan Beulich wrote: On 03.11.2023 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also provide

Re: Failing eclair-ARM64 job

2023-11-08 Thread Nicola Vetrini
On 2023-11-08 09:17, Nicola Vetrini wrote: Hi Stefano, sorry for the late reply; see my response below. On 2023-10-31 22:47, Stefano Stabellini wrote: Hi Simone, As you might have noticed, all the eclair-ARM64 jobs have been failing recently for the upstream Xen "staging" branch: https://git

Re: [RFC PATCH 4/4] automation/eclair: add deviation for certain backwards goto

2023-11-08 Thread Nicola Vetrini
On 2023-11-07 18:35, Julien Grall wrote: On 07/11/2023 14:45, Nicola Vetrini wrote: Hi Julien, Hi, On 2023-11-07 13:44, Julien Grall wrote: +in the community." +-config=MC3R1.R15.2,reports+={deliberate, "any_area(any_loc(text(^.*goto (again|retry).*$)))"} +-doc_end +   #   # Series 20.  

Clang-format configuration discussion - pt 1

2023-11-08 Thread Luca Fancellu
Hi all, Let’s kick off the discussion about clang-format configuration, with this part 1 I would like to discuss some configurable that I feel are not controversial. You can find the serie introducing clang-format here: https://patchwork.kernel.org/project/xen-devel/cover/20231031132304.2573924-

Re: [XEN PATCH v3] xen/string: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-11-08 Thread Federico Serafini
On 08/11/23 10:18, Jan Beulich wrote: (re-adding xen-devel@) On 08.11.2023 09:43, Federico Serafini wrote: On 08/11/23 09:07, Jan Beulich wrote: On 07.11.2023 16:18, Federico Serafini wrote: Add missing parameter names and make function declarations and definitions consistent. Mismatches betw

[linux-linus test] 183708: tolerable trouble: fail/pass/starved - PUSHED

2023-11-08 Thread osstest service owner
flight 183708 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183708/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183698 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [XEN PATCH v3] xen/string: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-11-08 Thread Jan Beulich
(re-adding xen-devel@) On 08.11.2023 09:43, Federico Serafini wrote: > On 08/11/23 09:07, Jan Beulich wrote: >> On 07.11.2023 16:18, Federico Serafini wrote: >>> Add missing parameter names and make function declarations and >>> definitions consistent. >>> Mismatches between parameter names "count

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-08 Thread Jan Beulich
On 03.11.2023 18:58, Nicola Vetrini wrote: > Static analysis tools may detect a possible null > pointer dereference at line 760 (the memcpy call) > of xen/common/domain.c. This ASSERT helps them in > detecting that such a condition is not possible > and also provides a basic sanity check. I disagr

Re: Failing eclair-ARM64 job

2023-11-08 Thread Nicola Vetrini
Hi Stefano, sorry for the late reply; see my response below. On 2023-10-31 22:47, Stefano Stabellini wrote: Hi Simone, As you might have noticed, all the eclair-ARM64 jobs have been failing recently for the upstream Xen "staging" branch: https://gitlab.com/xen-project/xen/-/pipelines/10565274

Re: [XEN PATCH v3] xen/string: address violations of MISRA C:2012 Rules 8.2 and 8.3

2023-11-08 Thread Jan Beulich
On 07.11.2023 16:18, Federico Serafini wrote: > Add missing parameter names and make function declarations and > definitions consistent. > Mismatches between parameter names "count" and "n" are resolved > in favor of "n", being the same name used by the C standard. I'm afraid this wasn't done cons