[xen-unstable test] 183671: regressions - trouble: blocked/fail/pass/starved

2023-11-03 Thread osstest service owner
flight 183671 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183671/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 183667 test-amd64-amd64-x

Re: [PATCH for-4.18 2/2] golang: Fix bindings after XSA-443

2023-11-03 Thread Henry Wang
Hi Jason, > On Nov 4, 2023, at 03:45, Jason Andryuk wrote: > > The new bootloader_restrict and bootloader_user fields in the libxl idl > change the bindings. Update them. > > Fixes: 1f762642d2ca ("libxl: add support for running bootloader in restricted > mode") > Signed-off-by: Jason Andryuk

Re: [PATCH for-4.18 1/2] golang: Fixup binding for Arm FF-A

2023-11-03 Thread Henry Wang
Hi Jason, > On Nov 4, 2023, at 03:45, Jason Andryuk wrote: > > The new FF-A TEE type changed the go bindings. Update them. > > Fixes: 8abdd8d52862 ("tools: add Arm FF-A mediator") > Signed-off-by: Jason Andryuk Release-acked-by: Henry Wang Kind regards, Henry > --- > tools/golang/xenlight

[linux-linus test] 183669: tolerable trouble: fail/pass/starved - PUSHED

2023-11-03 Thread osstest service owner
flight 183669 linux-linus real [real] flight 183674 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/183669/ http://logs.test-lab.xenproject.org/osstest/logs/183674/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

[ovmf test] 183673: all pass - PUSHED

2023-11-03 Thread osstest service owner
flight 183673 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183673/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 08ac799d36332d41d1a25ff3df748672676c0947 baseline version: ovmf 0b4acb88d67520ad5cd9f

[ovmf test] 183672: all pass - PUSHED

2023-11-03 Thread osstest service owner
flight 183672 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/183672/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0b4acb88d67520ad5cd9fd8896db0a2e203eaca4 baseline version: ovmf 8da978bf68535ec9fc41f

Re: [PATCH for-4.18 0/2] golang: Binding fixes

2023-11-03 Thread Andrew Cooper
On 03/11/2023 7:45 pm, Jason Andryuk wrote: > These two patches refresh the bindings which have gone a little stale. > I used two separate patches since the XSA-443 one may want backporting. > > Jason Andryuk (2): > golang: Fixup binding for Arm FF-A > golang: Fix bindings after XSA-443 Bah -

Re: [PATCH 08/29] tools/xenlogd: add 9pfs walk request support

2023-11-03 Thread Jason Andryuk
On Wed, Nov 1, 2023 at 6:09 AM Juergen Gross wrote: > > Add the walk request of the 9pfs protocol. > > Signed-off-by: Juergen Gross > --- > tools/xenlogd/io.c | 138 > tools/xenlogd/xenlogd.h | 1 + > 2 files changed, 139 insertions(+) > > diff --g

[PATCH for-4.18 1/2] golang: Fixup binding for Arm FF-A

2023-11-03 Thread Jason Andryuk
The new FF-A TEE type changed the go bindings. Update them. Fixes: 8abdd8d52862 ("tools: add Arm FF-A mediator") Signed-off-by: Jason Andryuk --- tools/golang/xenlight/types.gen.go | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/ty

[PATCH for-4.18 0/2] golang: Binding fixes

2023-11-03 Thread Jason Andryuk
These two patches refresh the bindings which have gone a little stale. I used two separate patches since the XSA-443 one may want backporting. Jason Andryuk (2): golang: Fixup binding for Arm FF-A golang: Fix bindings after XSA-443 tools/golang/xenlight/helpers.gen.go | 9 + tools/go

[PATCH for-4.18 2/2] golang: Fix bindings after XSA-443

2023-11-03 Thread Jason Andryuk
The new bootloader_restrict and bootloader_user fields in the libxl idl change the bindings. Update them. Fixes: 1f762642d2ca ("libxl: add support for running bootloader in restricted mode") Signed-off-by: Jason Andryuk --- tools/golang/xenlight/helpers.gen.go | 9 + tools/golang/xenli

Re: [PATCH v5 2/9] iommu/arm: Add iommu_dt_xlate()

2023-11-03 Thread Stewart Hildebrand
On 10/24/23 14:39, Julien Grall wrote: > Hi Stewart, > > On 04/10/2023 15:55, Stewart Hildebrand wrote: >> From: Oleksandr Tyshchenko >> >> Move code for processing DT IOMMU specifier to a separate helper. >> This helper will be re-used for adding PCI devices by the subsequent >> patches as we wi

[libvirt test] 183668: tolerable all pass - PUSHED

2023-11-03 Thread osstest service owner
flight 183668 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/183668/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 183653 test-armhf-armhf-libvirt-raw 15 save

Re: [XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-03 Thread Nicola Vetrini
On 2023-11-03 18:58, Nicola Vetrini wrote: Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also provides a basic sanity check. Suggested-by: J

[XEN PATCH][for-4.19] xen: replace occurrences of SAF-1-safe with asmlinkage attribute

2023-11-03 Thread Nicola Vetrini
The comment-based justifications for MISRA C:2012 Rule 8.4 are replaced by the asmlinkage pseudo-attribute, for the sake of uniformity. The deviation with a comment based on the SAF framework is also mentioned as a last resort. Add missing 'xen/compiler.h' #include-s where needed. The text in doc

[XEN PATCH][for-4.19] domain: add ASSERT to help static analysis tools

2023-11-03 Thread Nicola Vetrini
Static analysis tools may detect a possible null pointer dereference at line 760 (the memcpy call) of xen/common/domain.c. This ASSERT helps them in detecting that such a condition is not possible and also provides a basic sanity check. Signed-off-by: Nicola Vetrini --- The check may be later imp

[PATCH v2 0/2] xen/arm: Split MMU code as the prepration of MPU work form Arm32

2023-11-03 Thread Ayan Kumar Halder
Hi, These are the set of patches based on top of "[PATCH v8 0/8] xen/arm: Split MMU code as the prepration of MPU work". This is the preparation work to add MPU support on Arm32. There are two more dependencies for this series :- 1. "[XEN v1 1/4] xen/arm: arm32: Move pt_enforce_wxn() so that it

[PATCH v2 2/2] xen/arm32: head Split and move MMU-specific head.S to mmu/head.S

2023-11-03 Thread Ayan Kumar Halder
The MMU specific code in head.S will not be used on MPU systems. Instead of introducing more #ifdefs which will bring complexity to the code, move MMU related code to mmu/head.S and keep common code in head.S. Two notes while moving: - As "fail" in original head.S is very simple and this name is t

[PATCH v2 1/2] xen/arm32: head: Introduce enable_{boot,secondary}_cpu_mm()

2023-11-03 Thread Ayan Kumar Halder
All the MMU related functionality have been clubbed together in enable_boot_cpu_mm() for booting primary cpu and enable_secondary_cpu_mm() for booting secondary cpus. This is done in preparation for moving the code related to MMU in MMU specific file and in order to support non MMU cpus in future.

[PATCH] xen/pt: Emulate multifunction bit in header type

2023-11-03 Thread Ross Lagerwall
The intention of the code appears to have been to unconditionally set the multifunction bit but since the emulation mask is 0x00 it has no effect. Instead, emulate the bit and set it based on the multifunction property of the PCIDevice (which can be set using QAPI). This allows making passthrough

[xen-unstable test] 183667: tolerable trouble: fail/pass/starved - PUSHED

2023-11-03 Thread osstest service owner
flight 183667 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183667/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 183658 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH v3] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Roger Pau Monné
On Fri, Nov 03, 2023 at 03:44:30PM +, Andrew Cooper wrote: > On 03/11/2023 3:34 pm, Roger Pau Monné wrote: > > On Fri, Nov 03, 2023 at 03:10:18PM +, Andrew Cooper wrote: > >> On 03/11/2023 2:45 pm, Roger Pau Monne wrote: > >>> when sending those, as multiple CPUs can be targeted with a sing

Re: [PATCH v3] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Andrew Cooper
On 03/11/2023 3:34 pm, Roger Pau Monné wrote: > On Fri, Nov 03, 2023 at 03:10:18PM +, Andrew Cooper wrote: >> On 03/11/2023 2:45 pm, Roger Pau Monne wrote: >>> when sending those, as multiple CPUs can be targeted with a single ICR >>> register >>> write. >>> >>> A simple test calling flush_tlb

Re: [PATCH v10 03/17] vpci: use per-domain PCI lock to protect vpci structure

2023-11-03 Thread Stewart Hildebrand
On 10/12/23 18:09, Volodymyr Babchuk wrote: > 6. We are removing multiple ASSERT(pcidevs_locked()) instances because > they are too strict now: they should be corrected to > ASSERT(pcidevs_locked() || rw_is_locked(&d->pci_lock)), but problem is > that mentioned instances does not have access to the

Re: [PATCH v3] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Roger Pau Monné
On Fri, Nov 03, 2023 at 04:34:17PM +0100, Roger Pau Monné wrote: > On Fri, Nov 03, 2023 at 03:10:18PM +, Andrew Cooper wrote: > > On 03/11/2023 2:45 pm, Roger Pau Monne wrote: > > > +}; > > > + > > > static int cf_check update_clusterinfo( > > > struct notifier_block *nfb, unsigned long a

Re: [PATCH v3] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Roger Pau Monné
On Fri, Nov 03, 2023 at 03:10:18PM +, Andrew Cooper wrote: > On 03/11/2023 2:45 pm, Roger Pau Monne wrote: > > The current implementation of x2APIC requires to either use Cluster Logical > > or > > I'd suggest starting with "Xen's current ..." to make it clear that this > is our logic, not a

Re: [PATCH 07/29] tools/xenlogd: add 9pfs attach request support

2023-11-03 Thread Jason Andryuk
On Wed, Nov 1, 2023 at 5:54 AM Juergen Gross wrote: > > Add the attach request of the 9pfs protocol. This introduces the "fid" > scheme of the 9pfs protocol. > > As this will be needed later, use a dedicated memory allocation > function in alloc_fid(). > > For filling the qid data take the approac

Re: [PATCH v3] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Andrew Cooper
On 03/11/2023 2:45 pm, Roger Pau Monne wrote: > The current implementation of x2APIC requires to either use Cluster Logical or I'd suggest starting with "Xen's current ..." to make it clear that this is our logic, not a property of x2APIC itself. > Physical mode for all interrupts. However the s

[XEN PATCH][for-4.19 v6] xen: Add deviations for MISRA C:2012 Rule 7.1

2023-11-03 Thread Nicola Vetrini
As specified in rules.rst, these constants can be used in the code. Signed-off-by: Nicola Vetrini --- Changes in v2: - replace some SAF deviations with configurations Changes in v3: - refine configurations and justifications Changes in v4: - updated deviation record comment. Changes in v5: - use

[PATCH v3] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Roger Pau Monne
The current implementation of x2APIC requires to either use Cluster Logical or Physical mode for all interrupts. However the selection of Physical vs Logical is not done at APIC setup, an APIC can be addressed both in Physical or Logical destination modes concurrently. Introduce a new x2APIC mode

[xen-unstable-smoke test] 183670: tolerable all pass - PUSHED

2023-11-03 Thread osstest service owner
flight 183670 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/183670/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v2] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Jan Beulich
On 03.11.2023 14:41, Roger Pau Monné wrote: > On Fri, Nov 03, 2023 at 01:51:13PM +0100, Jan Beulich wrote: >> On 03.11.2023 13:48, Roger Pau Monné wrote: >>> On Thu, Nov 02, 2023 at 02:38:09PM +0100, Jan Beulich wrote: On 31.10.2023 15:52, Roger Pau Monne wrote: > --- a/xen/arch/x86/genapi

Re: [PATCH v2] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Roger Pau Monné
On Fri, Nov 03, 2023 at 01:51:13PM +0100, Jan Beulich wrote: > On 03.11.2023 13:48, Roger Pau Monné wrote: > > On Thu, Nov 02, 2023 at 02:38:09PM +0100, Jan Beulich wrote: > >> On 31.10.2023 15:52, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/genapic/x2apic.c > >>> +++ b/xen/arch/x86/genapic/x2a

Re: [PATCH v2] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Jan Beulich
On 03.11.2023 13:48, Roger Pau Monné wrote: > On Thu, Nov 02, 2023 at 02:38:09PM +0100, Jan Beulich wrote: >> On 31.10.2023 15:52, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/genapic/x2apic.c >>> +++ b/xen/arch/x86/genapic/x2apic.c >>> @@ -180,6 +180,29 @@ static const struct genapic __initconstr

Re: [PATCH v2] x86/x2apic: introduce a mixed physical/cluster mode

2023-11-03 Thread Roger Pau Monné
On Thu, Nov 02, 2023 at 02:38:09PM +0100, Jan Beulich wrote: > On 31.10.2023 15:52, Roger Pau Monne wrote: > > --- a/xen/arch/x86/genapic/x2apic.c > > +++ b/xen/arch/x86/genapic/x2apic.c > > @@ -180,6 +180,29 @@ static const struct genapic __initconstrel > > apic_x2apic_cluster = { > > .send_

[linux-linus test] 183664: tolerable trouble: fail/pass/starved - PUSHED

2023-11-03 Thread osstest service owner
flight 183664 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183664/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183654 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH 05/29] tools/xenlogd: add 9pfs response generation support

2023-11-03 Thread Juergen Gross
On 02.11.23 19:48, Jason Andryuk wrote: On Wed, Nov 1, 2023 at 6:56 AM Juergen Gross wrote: Add support for generation a 9pfs protocol response via a format based approach. Strings are stored in a per device string buffer and they are referenced via their offset in this buffer. This allows to

Re: [PATCH 04/29] tools/xenlogd: add transport layer

2023-11-03 Thread Juergen Gross
On 02.11.23 19:30, Jason Andryuk wrote: On Wed, Nov 1, 2023 at 5:34 AM Juergen Gross wrote: Add the transport layer of 9pfs. This is basically the infrastructure to receive requests from the frontend and to send the related answers via the rings. In order to avoid unaligned accesses e.g. on A

Re: [PATCH 03/29] tools/xenlogd: connect to frontend

2023-11-03 Thread Juergen Gross
On 03.11.23 02:42, Jason Andryuk wrote: On Thu, Nov 2, 2023 at 4:23 AM Juergen Gross wrote: On 01.11.23 20:21, Jason Andryuk wrote: On Wed, Nov 1, 2023 at 5:34 AM Juergen Gross wrote: Add the code for connecting to frontends to xenlogd. Signed-off-by: Juergen Gross diff --git a/tools/

Re: [PATCH 02/29] tools: add a new xen logging daemon

2023-11-03 Thread Juergen Gross
On 02.11.23 20:15, Andrew Cooper wrote: On 02/11/2023 7:44 am, Juergen Gross wrote: On 01.11.23 19:36, Jason Andryuk wrote: On Wed, Nov 1, 2023 at 10:27 AM Juergen Gross wrote: Add "xenlogd", a new logging daemon meant to support infrastructure domains (e.g. xenstore-stubdom) to write log fi