[PATCH 7/7] xen/events: remove some info_for_irq() calls in pirq handling

2023-10-15 Thread Juergen Gross
Instead of the IRQ number user the struct irq_info pointer as parameter in the internal pirq related functions. This allows to drop some calls of info_for_irq(). Signed-off-by: Juergen Gross --- drivers/xen/events/events_base.c | 113 +++ 1 file changed, 68 insertions

[PATCH 6/7] xen/events: modify internal [un]bind interfaces

2023-10-15 Thread Juergen Gross
Modify the internal bind- and unbind-interfaces to take a struct irq_info parameter. When allocating a new IRQ pass the pointer from the allocating function further up. This will reduce the number of info_for_irq() calls and make the code more efficient. Signed-off-by: Juergen Gross --- drivers

[PATCH 4/7] xen/events: remove some simple helpers from events_base.c

2023-10-15 Thread Juergen Gross
The helper functions type_from_irq() and cpu_from_irq() are just one line functions used only internally. Open code them where needed. At the same time modify and rename get_evtchn_to_irq() to return a struct irq_info instead of the IRQ number. Signed-off-by: Juergen Gross --- drivers/xen/event

[PATCH 5/7] xen/events: drop xen_allocate_irqs_dynamic()

2023-10-15 Thread Juergen Gross
Instead of having a common function for allocating a single IRQ or a consecutive number of IRQs, split up the functionality into the callers of xen_allocate_irqs_dynamic(). This allows to handle any allocation error in xen_irq_init() gracefully instead of panicing the system. Let xen_irq_init() re

[PATCH 2/7] xen/events: remove unused functions

2023-10-15 Thread Juergen Gross
There are no users of xen_irq_from_pirq() and xen_set_irq_pending(). Remove those functions. Signed-off-by: Juergen Gross --- drivers/xen/events/events_base.c | 30 -- include/xen/events.h | 4 2 files changed, 34 deletions(-) diff --git a/drivers/

[PATCH 0/7] xen/events: do some cleanups in events_base.c

2023-10-15 Thread Juergen Gross
As a followup to the XSA-441 patch this series is doing a minor bug fix and some cleanups of events_base.c (with some minor effects outside of it). Juergen Gross (7): xen/events: fix delayed eoi list handling xen/events: remove unused functions xen/events: reduce externally visible helper fu

[PATCH 3/7] xen/events: reduce externally visible helper functions

2023-10-15 Thread Juergen Gross
get_evtchn_to_irq() has only one external user while irq_from_evtchn() provides the same functionality and is exported for a wider user base. Modify the only external user of get_evtchn_to_irq() to use irq_from_evtchn() instead and make get_evtchn_to_irq() static. evtchn_from_irq() and irq_from_vi

[PATCH 1/7] xen/events: fix delayed eoi list handling

2023-10-15 Thread Juergen Gross
When delaying eoi handling of events, the related elements are queued into the percpu lateeoi list. In case the list isn't empty, the elements should be sorted by the time when eoi handling is to happen. Unfortunately a new element will never be queued at the start of the list, even if it has a ha

Re: [PATCH v3] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2023-10-15 Thread Juergen Gross
On 18.11.22 16:49, Marek Marczykowski-Górecki wrote: Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. According to the PCIe spec, device cannot u

[linux-linus test] 183378: tolerable FAIL - PUSHED

2023-10-15 Thread osstest service owner
flight 183378 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183378/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183377 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH RESEND 2/2] x86/percpu, xen: Correct PER_CPU_VAR usage to include symbol and its addend

2023-10-15 Thread Andrew Cooper
On 15/10/2023 5:08 pm, Uros Bizjak wrote: > PER_CPU_VAR macro should be applied to a symbol and its addend. > Inconsisten Inconsistent. I did previously wonder why references were written this way... ~Andrew

[linux-linus test] 183377: tolerable FAIL - PUSHED

2023-10-15 Thread osstest service owner
flight 183377 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183377/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183376 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [PATCH RESEND 2/2] x86/percpu, xen: Correct PER_CPU_VAR usage to include symbol and its addend

2023-10-15 Thread Boris Ostrovsky
On 10/15/23 12:08 PM, Uros Bizjak wrote: PER_CPU_VAR macro should be applied to a symbol and its addend. Inconsisten usage is currently harmless, but needs to be corrected before %rip-relative addressing is introduced to PER_CPU_VAR macro. No functional changes intended. Cc: Juergen Gross C

[PATCH RESEND 1/2] x86/percpu: Correct PER_CPU_VAR usage to include symbol and its addend

2023-10-15 Thread Uros Bizjak
PER_CPU_VAR macro should be applied to a symbol and its addend. Inconsistent usage is currently harmless, but needs to be corrected before %rip-relative addressing is introduced to PER_CPU_VAR macro. No functional changes intended. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Da

[PATCH RESEND 2/2] x86/percpu, xen: Correct PER_CPU_VAR usage to include symbol and its addend

2023-10-15 Thread Uros Bizjak
PER_CPU_VAR macro should be applied to a symbol and its addend. Inconsisten usage is currently harmless, but needs to be corrected before %rip-relative addressing is introduced to PER_CPU_VAR macro. No functional changes intended. Cc: Juergen Gross Cc: Boris Ostrovsky Cc: Thomas Gleixner Cc: I

[linux-linus test] 183376: tolerable FAIL - PUSHED

2023-10-15 Thread osstest service owner
flight 183376 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/183376/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 183374 test-amd64-amd64-xl-qemuu-win7-amd64

[xen-unstable test] 183375: tolerable FAIL

2023-10-15 Thread osstest service owner
flight 183375 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/183375/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 20 guest-start/debianhvm.repeat fail pass in 183373 test-amd64-amd