[linux-linus test] 182519: regressions - trouble: broken/fail/pass

flight 182519 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182519/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-qcow2 broken test-armhf-armhf-libvirt-qcow2 5 host-i

Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle

On Fri, Aug 25, 2023 at 03:47:56PM +0200, Jan Kara wrote: > I can see the appeal of not having to introduce the new bdev_handle type > and just using struct file which unifies in-kernel and userspace block > device opens. But I can see downsides too - the last fput() happening from > task work mak

[xen-unstable test] 182517: tolerable FAIL - PUSHED

flight 182517 xen-unstable real [real] flight 182521 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182517/ http://logs.test-lab.xenproject.org/osstest/logs/182521/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [XEN PATCH v2] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

On Wed, 23 Aug 2023, Jan Beulich wrote: > On 23.08.2023 09:28, Andrew Cooper wrote: > > On 23/08/2023 8:04 am, Federico Serafini wrote: > >> Make function declarations and definitions consistent to address > >> violations of MISRA C:2012 Rule 8.3 ("All declarations of an object or > >> function sha

Re: xen-analysis ECLAIR support

On Fri, 25 Aug 2023, Nicola Vetrini wrote: > On 25/08/2023 00:24, Stefano Stabellini wrote: > > Hi Luca, > > > > We are looking into adding ECLAIR support for xen-analysis so that we > > can use the SAF-n-safe tags also with ECLAIR. > > > > One question that came up is about multi-line statements

Re: xen-analysis ECLAIR support

On Fri, 25 Aug 2023, Michal Orzel wrote: > Hi Stefano, > > On 25/08/2023 00:24, Stefano Stabellini wrote: > > > > > > Hi Luca, > > > > We are looking into adding ECLAIR support for xen-analysis so that we > > can use the SAF-n-safe tags also with ECLAIR. > > > > One question that came up is ab

[PATCH v2] docs/misra: add rules 10.1 10.2 10.3 10.4

From: Stefano Stabellini 10.1 with several caveats, described in the notes. 10.3 and 10.4 as "aspirational" guidelines, as clarified in the notes. Signed-off-by: Stefano Stabellini --- v2: - typo fix - Implicit conversions to boolean for conditionals and logical operators - make -C xen --- doc

Re: [PATCH] docs/misra: add rules 10.1 10.2 10.3 10.4

On Fri, 25 Aug 2023, Jan Beulich wrote: > On 24.08.2023 01:14, Stefano Stabellini wrote: > > --- a/docs/misra/rules.rst > > +++ b/docs/misra/rules.rst > > @@ -318,6 +318,58 @@ maintainers if you want to suggest a change. > > - An element of an object shall not be initialized more than once >

Re: [XEN PATCH] ioreq: include arch-specific ioreq header in

On Fri, 25 Aug 2023, Nicola Vetrini wrote: > The common header file for ioreq should include the arch-specific one. > This also addresses violations of MISRA C:2012 Rule 8.4 caused by the missing > inclusion of in the arm implementation file. > > Signed-off-by: Nicola Vetrini Reviewed-by: Stefa

Re: [XEN PATCH v3] arm64/vfp: address MISRA C:2012 Dir 4.3

On Fri, 25 Aug 2023, Nicola Vetrini wrote: > Directive 4.3 prescribes the following: > "Assembly language shall be encapsulated and isolated", > on the grounds of improved readability and ease of maintenance. > > A static inline function is the chosen encapsulation mechanism. > > No functional ch

[libvirt test] 182515: tolerable all pass - PUSHED

flight 182515 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182515/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182498 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [PATCH 8/9] xen/ppc: Add stub function and symbol definitions

On 8/25/23 4:10 AM, Jan Beulich wrote: > On 23.08.2023 20:39, Shawn Anastasio wrote: >> On 8/8/23 5:27 AM, Jan Beulich wrote: >>> On 03.08.2023 01:03, Shawn Anastasio wrote: +int map_pages_to_xen(unsigned long virt, + mfn_t mfn, + unsigned long

[qemu-mainline test] 182514: trouble: broken/fail/pass

flight 182514 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182514/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pairbroken test-amd64-amd64-qe

[XEN PATCH] ioreq: include arch-specific ioreq header in

The common header file for ioreq should include the arch-specific one. This also addresses violations of MISRA C:2012 Rule 8.4 caused by the missing inclusion of in the arm implementation file. Signed-off-by: Nicola Vetrini --- - The deleted includes are therefore no longer necessary, since is

[XEN PATCH v3] arm64/vfp: address MISRA C:2012 Dir 4.3

Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of maintenance. A static inline function is the chosen encapsulation mechanism. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Michal

Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle

On Fri 25-08-23 02:58:43, Al Viro wrote: > On Fri, Aug 11, 2023 at 01:04:31PM +0200, Jan Kara wrote: > > Hello, > > > > this is a v2 of the patch series which implements the idea of > > blkdev_get_by_*() > > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > > makes the

Re: [PATCH] docs/misra: add rules 10.1 10.2 10.3 10.4

On 25/08/2023 14:40, Jan Beulich wrote: On 24.08.2023 01:14, Stefano Stabellini wrote: --- a/docs/misra/rules.rst +++ b/docs/misra/rules.rst @@ -318,6 +318,58 @@ maintainers if you want to suggest a change. - An element of an object shall not be initialized more than once - +

Re: [PATCH] docs/misra: add rules 10.1 10.2 10.3 10.4

On 24.08.2023 01:14, Stefano Stabellini wrote: > --- a/docs/misra/rules.rst > +++ b/docs/misra/rules.rst > @@ -318,6 +318,58 @@ maintainers if you want to suggest a change. > - An element of an object shall not be initialized more than once > - > > + * - `Rule 10.1 >

Re: [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle

On Wed, Aug 23, 2023 at 12:48:11PM +0200, Jan Kara wrote: > Hello, > > this is a v3 of the patch series which implements the idea of > blkdev_get_by_*() > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > makes the get and put calls for bdevs more obviously matching and

[linux-linus test] 182512: regressions - FAIL

flight 182512 linux-linus real [real] flight 182518 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182512/ http://logs.test-lab.xenproject.org/osstest/logs/182518/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: [XEN PATCH] xen/pci: drop remaining uses of bool_t

On 25.08.2023 14:18, Nicola Vetrini wrote: > The remaining occurrences of the type bool_t in the header > file can be removed. This also resolves violations of > MISRA C:2012 Rule 8.3 introduced by 870d5cd9a91f > ("xen/IOMMU: Switch bool_t to bool"). > > Signed-off-by: Nicola Vetrini Acked-by: J

[XEN PATCH] xen/pci: drop remaining uses of bool_t

The remaining occurrences of the type bool_t in the header file can be removed. This also resolves violations of MISRA C:2012 Rule 8.3 introduced by 870d5cd9a91f ("xen/IOMMU: Switch bool_t to bool"). Signed-off-by: Nicola Vetrini --- xen/include/xen/pci.h | 12 ++-- 1 file changed, 6 ins

Re: [PATCH 07/29] xen/blkback: Convert to bdev_open_by_dev()

On Wed, Aug 23, 2023 at 12:48:18PM +0200, Jan Kara wrote: > Convert xen/blkback to use bdev_open_by_dev() and pass the > handle around. > > CC: xen-devel@lists.xenproject.org > Acked-by: Christoph Hellwig > Signed-off-by: Jan Kara > --- Looks good to me, Acked-by: Christian Brauner

Re: Community Manager update - August 2023

Hi everyone, Thank you for your feedback so far. - With no objections from the community - New Matrix only channels are now available to join. The reason for such a change is to improve communication and synchronization of messages which members of IRC have had issues with previously.

[xen-unstable test] 182511: tolerable FAIL - PUSHED

flight 182511 xen-unstable real [real] flight 182516 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182511/ http://logs.test-lab.xenproject.org/osstest/logs/182516/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: [PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

On Fri, Aug 25, 2023 at 09:37:58AM +0200, Erik Schilling wrote: [...] > > > > diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in > > > > b/tools/hotplug/Linux/systemd/xenstored.service.in > > > > index 261077dc92..6e48cdb0e7 100644 > > > > --- a/tools/hotplug/Linux/systemd/xenstored.s

Re: [PATCH 8/9] xen/ppc: Add stub function and symbol definitions

On 23.08.2023 20:39, Shawn Anastasio wrote: > On 8/8/23 5:27 AM, Jan Beulich wrote: >> On 03.08.2023 01:03, Shawn Anastasio wrote: >>> +int map_pages_to_xen(unsigned long virt, >>> + mfn_t mfn, >>> + unsigned long nr_mfns, >>> + unsigned i

Re: xen-analysis ECLAIR support

On 25.08.2023 10:18, Michal Orzel wrote: > Hi Stefano, > > On 25/08/2023 00:24, Stefano Stabellini wrote: >> >> >> Hi Luca, >> >> We are looking into adding ECLAIR support for xen-analysis so that we >> can use the SAF-n-safe tags also with ECLAIR. >> >> One question that came up is about multi-li

Re: [PATCH v2 1/8] x86: Fix calculation of %dr6/7 reserved bits

On 24.08.2023 18:37, Andrew Cooper wrote: > On 24/08/2023 4:25 pm, Jinoh Kang wrote: >> - Define X86_DR{6,7}_* constants in x86-defns.h instead of open-coding >> naked numbers (thanks Jan) > > Jan - stop insisting of other people things I've already rejected, > particularly on my patches. Quoti

Re: xen-analysis ECLAIR support

Hi Stefano, On 25/08/2023 00:24, Stefano Stabellini wrote: > > > Hi Luca, > > We are looking into adding ECLAIR support for xen-analysis so that we > can use the SAF-n-safe tags also with ECLAIR. > > One question that came up is about multi-line statements. For instance, > in a case like the f

Re: [XEN][PATCH v9 14/19] common/device_tree: Add rwlock for dt_host

Hi, On 25/08/2023 08:52, Vikram Garhwal wrote: Hi, On Thu, Aug 24, 2023 at 11:22:00PM -0700, Vikram Garhwal wrote: Hi Julien, On Wed, Aug 23, 2023 at 11:06:59PM +0100, Julien Grall wrote: Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Dynamic programming ops will modify the dt_host

Re: [PATCH] xen: simplify evtchn_do_upcall() call maze

On Thu, Aug 24 2023 at 17:41, Juergen Gross wrote: > There are several functions involved for performing the functionality > of evtchn_do_upcall(): > > - __xen_evtchn_do_upcall() doing the real work > - xen_hvm_evtchn_do_upcall() just being a wrapper for > __xen_evtchn_do_upcall(), exposed for ex

[XEN][PATCH v10 16/20] xen/arm: Implement device tree node removal functionalities

Introduce sysctl XEN_SYSCTL_dt_overlay to remove device-tree nodes added using device tree overlay. xl dt-overlay remove file.dtbo: Removes all the nodes in a given dtbo. First, removes IRQ permissions and MMIO accesses. Next, it finds the nodes in dt_host and delete the device node en

[XEN][PATCH v10 17/20] xen/arm: Implement device tree node addition functionalities

Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition using device tree overlay. xl dt-overlay add file.dtbo: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is

[XEN][PATCH v10 18/20] tools/libs/ctrl: Implement new xc interfaces for dt overlay

xc_dt_overlay() sends the device tree binary overlay, size of .dtbo and overlay operation type i.e. add or remove to xen. Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/include/xenctrl.h | 5 tools/libs/ctrl/Makefile.common | 1 + tools/libs/ctrl/xc_dt_overla

Re: xen-analysis ECLAIR support

On 25/08/2023 00:24, Stefano Stabellini wrote: Hi Luca, We are looking into adding ECLAIR support for xen-analysis so that we can use the SAF-n-safe tags also with ECLAIR. One question that came up is about multi-line statements. For instance, in a case like the following: diff --git a/xen/com

[XEN][PATCH v10 19/20] tools/libs/light: Implement new libxl functions for device tree overlay ops

Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/include/libxl.h | 11 + tools/libs/light/Makefile | 3 ++ tools/libs/light/libxl_dt_overlay.c | 71 + 3 files changed, 85 insertions(+) create mode 100644 tools/libs/ligh

[XEN][PATCH v10 20/20] tools/xl: Add new xl command overlay for device tree overlay support

Signed-off-by: Vikram Garhwal Reviewed-by: Anthony PERARD --- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 6 + tools/xl/xl_vmcontrol.c | 52 + 3 files changed, 59 insertions(+) diff --git a/tools/xl/xl.h b/tools/xl/xl.h index 72538d6a81

Re: [XEN][PATCH v9 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

On 25/08/2023 05:44, Vikram Garhwal wrote: Hi Julien, On Tue, Aug 22, 2023 at 08:47:10PM +0100, Julien Grall wrote: Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access to add/remove/assign/deassign. With addition

Re: [XEN][PATCH v9 05/19] xen/arm: Add CONFIG_OVERLAY_DTB

On 25/08/2023 04:17, Vikram Garhwal wrote: Hi Julien, On Tue, Aug 22, 2023 at 08:10:05PM +0100, Julien Grall wrote: Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree bin

[XEN][PATCH v10 07/20] libfdt: overlay: change overlay_get_target()

Rename overlay_get_target() to fdt_overlay_target_offset() and remove static function type. This is done to get the target path for the overlay nodes which is very useful in many cases. For example, Xen hypervisor needs it when applying overlays because Xen needs to do further processing of the ov

[XEN][PATCH v10 12/20] xen/smmu: Add remove_device callback for smmu_iommu ops

Add remove_device callback for removing the device entry from smmu-master using following steps: 1. Find if SMMU master exists for the device node. 2. Check if device is currently in use. 3. Remove the SMMU master. Signed-off-by: Vikram Garhwal --- Changes from v9: Remove iommu_dt_device_is

[XEN][PATCH v10 15/20] arm/asm/setup.h: Update struct map_range_data to add rangeset.

Add rangesets for IRQs and IOMEMs. This was done to accommodate dynamic overlay node addition/removal operations. With overlay operations, new IRQs and IOMEMs are added in dt_host and routed. While removing overlay nodes, nodes are remove from dt_host and their IRQs and IOMEMs routing is also remov

[XEN][PATCH v10 13/20] asm/smp.h: Fix circular dependency for device_tree.h and rwlock.h

Dynamic programming ops will modify the dt_host and there might be other function which are browsing the dt_host at the same time. To avoid the race conditions, we will need to add a rwlock to protect access to the dt_host. However, adding rwlock in device_tree.h causes following circular dependenc

[XEN][PATCH v10 14/20] common/device_tree: Add rwlock for dt_host

Dynamic programming ops will modify the dt_host and there might be other functions which are browsing the dt_host at the same time. To avoid the race conditions, adding rwlock for browsing the dt_host during runtime. dt_host writer will be added in the follow-up patch for device tree overlay functi

[XEN][PATCH v10 09/20] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

Rename iommu_dt_device_is_assigned() to iommu_dt_device_is_assigned_locked(). Moving spin_lock to caller was done to prevent the concurrent access to iommu_dt_device_is_assigned while doing add/remove/assign/deassign. Follow-up patches in this series introduces node add/remove feature. Signed-off

[XEN][PATCH v10 06/20] libfdt: Keep fdt functions after init for CONFIG_OVERLAY_DTB.

This is done to access fdt library function which are required for adding device tree overlay nodes for dynamic programming of nodes. Signed-off-by: Vikram Garhwal Acked-by: Julien Grall --- xen/common/libfdt/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/xen/common/libfdt/Mak

[XEN][PATCH v10 01/20] common/device_tree: handle memory allocation failure in __unflatten_device_tree()

Change __unflatten_device_tree() return type to integer so it can propagate memory allocation failure. Add panic() in dt_unflatten_host_device_tree() for memory allocation failure during boot. Fixes: fb97eb614acf ("xen/arm: Create a hierarchical device tree") Signed-off-by: Vikram Garhwal Reviewe

[XEN][PATCH v10 08/20] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

Add device_tree_find_node_by_path() to find a matching node with path for a dt_device_node. Reason behind this function: Each time overlay nodes are added using .dtbo, a new fdt(memcpy of device_tree_flattened) is created and updated with overlay nodes. This updated fdt is further unfl

[XEN][PATCH v10 11/20] xen/iommu: Introduce iommu_remove_dt_device()

Remove master device from the IOMMU. This will be helpful when removing the overlay nodes using dynamic programming during run time. Signed-off-by: Vikram Garhwal Acked-by: Jan Beulich --- Changes from v7: Add check if IOMMU is enabled. Fix indentation of fail. --- --- xen/drivers/pass

[XEN][PATCH v10 05/20] xen/arm: Add CONFIG_OVERLAY_DTB

Introduce a config option where the user can enable support for adding/removing device tree nodes using a device tree binary overlay. Update SUPPORT.md and CHANGELOG.md to state the Device Tree Overlays support for Arm. Signed-off-by: Vikram Garhwal Acked-by: Henry Wang Reviewed-by: Michal Orze

[XEN][PATCH v10 10/20] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access to add/remove/assign/deassign. With addition of dynamic programming feature(follow-up patches in this series), this function can be concurrently accessed by while making a device assign/deassign for passthrough and by dynam

[XEN][PATCH v10 04/20] common/device_tree: Export __unflatten_device_tree()

Following changes are done to __unflatten_device_tree(): 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). 2. Remove __init and static function type. The changes are done to make this function useable for dynamic node programming where new device tree overlay nodes are ad

[XEN][PATCH v10 03/20] xen/arm/device: Remove __init from function type

Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_interrupts() 3. map_range_to_domain() 4. unflatten_dt_node() 5. handle_device() 6. map_device_children() 7. map_dt_irq_to_domain() Move map_irq_to_domain() prototype f

[XEN][PATCH v10 00/20] dynamic node programming using overlay dtbo

Hi, This patch series is for introducing dynamic programming i.e. add/remove the devices during run time. Using "xl dt_overlay" a device can be added/removed with dtbo. For adding a node using dynamic programming: 1. flatten device tree overlay node will be added to a fdt 2. Updated fdt wi

[XEN][PATCH v10 02/20] common/device_tree.c: unflatten_device_tree() propagate errors

This will be useful in dynamic node programming when new dt nodes are unflattend during runtime. Invalid device tree node related errors should be propagated back to the caller. Signed-off-by: Vikram Garhwal --- Changes from v9: Replace __be64 with void. Changes from v7: Free allocated m

Re: [XEN][PATCH v9 03/19] xen/arm/device: Remove __init from function type

Hi, On 25/08/2023 01:52, Vikram Garhwal wrote: Hi Julien, On Tue, Aug 22, 2023 at 07:59:13PM +0100, Julien Grall wrote: Hi Vikram, On 19/08/2023 01:28, Vikram Garhwal wrote: Remove __init from following function to access during runtime: 1. map_irq_to_domain() 2. handle_device_int

Re: [XEN][PATCH v9 14/19] common/device_tree: Add rwlock for dt_host

Hi, On Thu, Aug 24, 2023 at 11:22:00PM -0700, Vikram Garhwal wrote: > Hi Julien, > On Wed, Aug 23, 2023 at 11:06:59PM +0100, Julien Grall wrote: > > Hi Vikram, > > > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > > Dynamic programming ops will modify the dt_host and there might be other > > >

Re: [PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

On Fri Aug 25, 2023 at 8:36 AM CEST, Leo Yan wrote: > On Fri, Aug 25, 2023 at 07:02:33AM +0200, Erik Schilling wrote: > > On Fri Aug 25, 2023 at 5:36 AM CEST, Leo Yan wrote: > > > When system booting up, the kernel module xen_gntdev.ko is loaded and > > > the device node '/dev/xen/gntdev' is create