Re: [PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

2023-08-24 Thread Leo Yan
On Fri, Aug 25, 2023 at 07:02:33AM +0200, Erik Schilling wrote: > On Fri Aug 25, 2023 at 5:36 AM CEST, Leo Yan wrote: > > When system booting up, the kernel module xen_gntdev.ko is loaded and > > the device node '/dev/xen/gntdev' is created; later the xenstored > > service in systemd launches daemo

Re: [XEN][PATCH v9 14/19] common/device_tree: Add rwlock for dt_host

2023-08-24 Thread Vikram Garhwal
Hi Julien, On Wed, Aug 23, 2023 at 11:06:59PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Dynamic programming ops will modify the dt_host and there might be other > > function which are browsing the dt_host at the same time. To avoid the > > race

Re: [XEN][PATCH v9 09/19] xen/iommu: Move spin_lock from iommu_dt_device_is_assigned to caller

2023-08-24 Thread Vikram Garhwal
Hi Julien, On Tue, Aug 22, 2023 at 08:43:27PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Rename iommu_dt_device_is_assigned() to > > iommu_dt_device_is_assigned_locked(). > > Remove static type so this can also be used by SMMU drivers to check if th

Re: [PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

2023-08-24 Thread Erik Schilling
On Fri Aug 25, 2023 at 5:36 AM CEST, Leo Yan wrote: > When system booting up, the kernel module xen_gntdev.ko is loaded and > the device node '/dev/xen/gntdev' is created; later the xenstored > service in systemd launches daemon to open this device node. > > This flow has a race condition between c

Re: [XEN][PATCH v9 10/19] xen/iommu: protect iommu_add_dt_device() with dtdevs_lock

2023-08-24 Thread Vikram Garhwal
Hi Julien, On Tue, Aug 22, 2023 at 08:47:10PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Protect iommu_add_dt_device() with dtdevs_lock to prevent concurrent access > > to add/remove/assign/deassign. > > With addition of dynamic programming feature(f

[ovmf test] 182513: all pass - PUSHED

2023-08-24 Thread osstest service owner
flight 182513 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/182513/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 819cfc6b42a68790a23509e4fcc58ceb70e1965e baseline version: ovmf 00b51e0d78a547dd78119

Re: [XEN][PATCH v9 08/19] xen/device-tree: Add device_tree_find_node_by_path() to find nodes in device tree

2023-08-24 Thread Vikram Garhwal
Hi Julien, On Tue, Aug 22, 2023 at 08:21:17PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Add device_tree_find_node_by_path() to find a matching node with path for a > > dt_device_node. > > > > Reason behind this function: > > Each time overlay

[PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

2023-08-24 Thread Leo Yan
When system booting up, the kernel module xen_gntdev.ko is loaded and the device node '/dev/xen/gntdev' is created; later the xenstored service in systemd launches daemon to open this device node. This flow has a race condition between creating the device node in the kernel module and using the de

[qemu-mainline test] 182508: tolerable FAIL - PUSHED

2023-08-24 Thread osstest service owner
flight 182508 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182508/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182422 test-armhf-armhf-libvirt-qcow2 15 s

Re: [XEN][PATCH v9 05/19] xen/arm: Add CONFIG_OVERLAY_DTB

2023-08-24 Thread Vikram Garhwal
Hi Julien, On Tue, Aug 22, 2023 at 08:10:05PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Introduce a config option where the user can enable support for > > adding/removing > > device tree nodes using a device tree binary overlay. > > > > Update SU

Re: [PATCH] xen/scsifront: shost_priv() can never return NULL

2023-08-24 Thread Martin K. Petersen
Juergen, > There is no need to check whether shost_priv() returns a non-NULL > value, as the pointer returned is just an offset to the passed in > parameter. > > While at it replace an open coded shost_priv() instance. Applied to 6.6/scsi-staging, thanks! -- Martin K. Petersen Oracle Lin

Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle

2023-08-24 Thread Al Viro
On Fri, Aug 11, 2023 at 01:04:31PM +0200, Jan Kara wrote: > Hello, > > this is a v2 of the patch series which implements the idea of > blkdev_get_by_*() > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > makes the get and put calls for bdevs more obviously matching and

Re: [XEN][PATCH v9 04/19] common/device_tree: Export __unflatten_device_tree()

2023-08-24 Thread Vikram Garhwal
Hi Julien, On Tue, Aug 22, 2023 at 08:05:18PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Following changes are done to __unflatten_device_tree(): > > 1. __unflatten_device_tree() is renamed to unflatten_device_tree(). > > 2. Remove __init a

Re: [XEN][PATCH v9 03/19] xen/arm/device: Remove __init from function type

2023-08-24 Thread Vikram Garhwal
Hi Julien, On Tue, Aug 22, 2023 at 07:59:13PM +0100, Julien Grall wrote: > Hi Vikram, > > On 19/08/2023 01:28, Vikram Garhwal wrote: > > Remove __init from following function to access during runtime: > > 1. map_irq_to_domain() > > 2. handle_device_interrupts() > > 3. map_range_to_d

Re: [ImageBuilder PATCH] uboot-script-gen: use size from arm64 Image header

2023-08-24 Thread Stefano Stabellini
On Thu, 24 Aug 2023, Stewart Hildebrand wrote: > There is a corner case where the filesizes of the xen and Linux kernel images > are not sufficient. These binaries likely contain .NOLOAD sections, which are > not accounted in the filesize. > > Check for the presence of an arm64 kernel image header

[linux-linus test] 182506: regressions - FAIL

2023-08-24 Thread osstest service owner
flight 182506 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182506/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-build fail in 182499 REGR. vs. 182424 Tests which are fai

Re: [PATCH v2] docs/misra: add rule 2.1 exceptions

2023-08-24 Thread Stefano Stabellini
On Thu, 24 Aug 2023, Julien Grall wrote: > On 24/08/2023 12:46, Julien Grall wrote: > > On 23/08/2023 23:39, Stefano Stabellini wrote: > > > --- > > >   docs/misra/rules.rst | 13 - > > >   1 file changed, 12 insertions(+), 1 deletion(-) > > > > > > diff --git a/docs/misra/rules.rst b/d

xen-analysis ECLAIR support

2023-08-24 Thread Stefano Stabellini
Hi Luca, We are looking into adding ECLAIR support for xen-analysis so that we can use the SAF-n-safe tags also with ECLAIR. One question that came up is about multi-line statements. For instance, in a case like the following: diff --git a/xen/common/inflate.c b/xen/common/inflate.c index 8fa4b9

[xen-unstable-smoke test] 182510: tolerable all pass - PUSHED

2023-08-24 Thread osstest service owner
flight 182510 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182510/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [XEN PATCH v4 2/4] xen/vpci: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Stefano Stabellini
On Thu, 24 Aug 2023, Roger Pau Monné wrote: > On Wed, Jul 26, 2023 at 01:03:37PM +0200, Simone Ballarin wrote: > > From: Gianluca Luparini > > > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > > headline states: > > "A 'u' or 'U' suffix shall be applied to all integer const

Need Ack, Re: [XEN PATCH v4 2/4] xen/vpci: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Stefano Stabellini
Please ack On Thu, 24 Aug 2023, Nicola Vetrini wrote: > On 26/07/2023 13:03, Simone Ballarin wrote: > > From: Gianluca Luparini > > > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > > headline states: > > "A 'u' or 'U' suffix shall be applied to all integer constants > > t

Re: [XEN PATCH v4 1/4] x86/vmx: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Stefano Stabellini
On Thu, 24 Aug 2023, Nicola Vetrini wrote: > On 26/07/2023 13:03, Simone Ballarin wrote: > > From: Gianluca Luparini > > > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > > headline states: > > "A 'u' or 'U' suffix shall be applied to all integer constants > > that are repr

Need Ack, Re: [XEN PATCH v4 3/4] x86/viridian: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Stefano Stabellini
Paul, Wei, can we have an ack? On Thu, 24 Aug 2023, Nicola Vetrini wrote: > On 26/07/2023 13:03, Simone Ballarin wrote: > > From: Gianluca Luparini > > > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > > headline states: > > "A 'u' or 'U' suffix shall be applied to all in

Re: [XEN PATCH 06/13] xen/mem_access: address violations of MISRA C:2012 Rule 7.3

2023-08-24 Thread Stefano Stabellini
Tamas, is it possible that you are not actually subscribed to xen-devel with your email ta...@tklengyel.com ? Sorry for top-posting I wanted to make sure Tamas saw this. On Thu, 24 Aug 2023, Jan Beulich wrote: > On 04.08.2023 02:47, Stefano Stabellini wrote: > > On Thu, 3 Aug 2023, Simone Balla

Re: [PATCH] xen: simplify evtchn_do_upcall() call maze

2023-08-24 Thread Boris Ostrovsky
On 8/24/23 11:41 AM, Juergen Gross wrote: There are several functions involved for performing the functionality of evtchn_do_upcall(): - __xen_evtchn_do_upcall() doing the real work - xen_hvm_evtchn_do_upcall() just being a wrapper for __xen_evtchn_do_upcall(), exposed for external callers

[xen-unstable test] 182502: tolerable FAIL - PUSHED

2023-08-24 Thread osstest service owner
flight 182502 xen-unstable real [real] flight 182509 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182502/ http://logs.test-lab.xenproject.org/osstest/logs/182509/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[seabios test] 182507: tolerable FAIL - PUSHED

2023-08-24 Thread osstest service owner
flight 182507 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/182507/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 182501 test-amd64-i386-xl-qemuu-win7-amd64 19 gu

[ImageBuilder PATCH] uboot-script-gen: use size from arm64 Image header

2023-08-24 Thread Stewart Hildebrand
There is a corner case where the filesizes of the xen and Linux kernel images are not sufficient. These binaries likely contain .NOLOAD sections, which are not accounted in the filesize. Check for the presence of an arm64 kernel image header, and get the effective image size from the header. Use t

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-08-24 Thread Julien Grall
On 24/08/2023 17:58, Anthony PERARD wrote: On Thu, Aug 24, 2023 at 05:46:45PM +0100, Julien Grall wrote: Hi Anthony, On 24/08/2023 17:34, Anthony PERARD wrote: On Thu, Aug 24, 2023 at 12:15:39PM +0100, Julien Grall wrote: On 18/08/2023 18:04, Anthony PERARD wrote: So, this new pci_revoke_

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-08-24 Thread Anthony PERARD
On Thu, Aug 24, 2023 at 05:46:45PM +0100, Julien Grall wrote: > Hi Anthony, > > On 24/08/2023 17:34, Anthony PERARD wrote: > > On Thu, Aug 24, 2023 at 12:15:39PM +0100, Julien Grall wrote: > > > On 18/08/2023 18:04, Anthony PERARD wrote: > > > > So, this new pci_revoke_permissions() function been

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-08-24 Thread Julien Grall
Hi Anthony, On 24/08/2023 17:34, Anthony PERARD wrote: On Thu, Aug 24, 2023 at 12:15:39PM +0100, Julien Grall wrote: On 18/08/2023 18:04, Anthony PERARD wrote: So, this new pci_revoke_permissions() function been place before do_pci_remove() will make it harder to follow what do_pci_remove() do

Re: [PATCH v2 1/8] x86: Fix calculation of %dr6/7 reserved bits

2023-08-24 Thread Andrew Cooper
On 24/08/2023 4:25 pm, Jinoh Kang wrote: > - Define X86_DR{6,7}_* constants in x86-defns.h instead of open-coding > naked numbers (thanks Jan) Jan - stop insisting of other people things I've already rejected, particularly on my patches. > diff --git a/xen/arch/x86/include/asm/debugreg.h > b/x

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-08-24 Thread Anthony PERARD
On Thu, Aug 24, 2023 at 12:15:39PM +0100, Julien Grall wrote: > On 18/08/2023 18:04, Anthony PERARD wrote: > > So, this new pci_revoke_permissions() function been place before > > do_pci_remove() will make it harder to follow what do_pci_remove() does. > > Does it need to be a separate function? Ca

[PATCH] xen: simplify evtchn_do_upcall() call maze

2023-08-24 Thread Juergen Gross
There are several functions involved for performing the functionality of evtchn_do_upcall(): - __xen_evtchn_do_upcall() doing the real work - xen_hvm_evtchn_do_upcall() just being a wrapper for __xen_evtchn_do_upcall(), exposed for external callers - xen_evtchn_do_upcall() calling __xen_evtchn_d

[PATCH v2 7/8] x86: Fix merging of new status bits into %dr6

2023-08-24 Thread Jinoh Kang
From: Andrew Cooper The current logic used to update %dr6 when injecting #DB is buggy. The architectural behaviour is to overwrite B{0..3} (rather than accumulate) and accumulate all other bits. Introduce a new merge_dr6() helper, which also takes care of handing RTM correctly. Signed-off-by:

[PATCH v2 8/8] x86/dbg: Cleanup of legacy dr6 constants

2023-08-24 Thread Jinoh Kang
From: Andrew Cooper Replace the few remaining uses with X86_DR6_* constants. Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Acked-by: Jan Beulich [ jinoh: Rebase onto staging ] Signed-off-by: Jinoh Kang --- CC: Andrew Cooper CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné v1

[PATCH v2 6/8] x86/hvm: Add comments about #DB exception behavior to {svm,vmx}_inject_event()

2023-08-24 Thread Jinoh Kang
From: Andrew Cooper Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné Extracted comments only, and then s/from emulation/from monitor/; originally "x86/hvm: RFC - PROBABLY BROKEN - Defer all debugging/monitor actions to {svm,vmx}_inject_event()" Signed-off-by: Jinoh Kang --- CC: Andr

[PATCH v2 4/8] x86/emul: Populate pending_dbg field of x86_event from {svm,vmx}_get_pending_event()

2023-08-24 Thread Jinoh Kang
Ensure that we pass the correct pending_dbg value to hvm_monitor_interrupt(). Signed-off-by: Jinoh Kang --- CC: Andrew Cooper CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Jun Nakajima CC: Kevin Tian CC: Tamas K Lengyel CC: Alexandru Isaila CC: Petre Pircalabu v1 -> v2: new patch

[PATCH v2 3/8] x86/emul: Add pending_dbg field to x86_event

2023-08-24 Thread Jinoh Kang
From: Andrew Cooper All #DB exceptions result in an update of %dr6, but this isn't captured in Xen's handling. PV guests generally work by modifying %dr6 before raising #DB, whereas HVM guests do nothing and have a single-step special case in the lowest levels of {vmx,svm}_inject_event(). All o

[PATCH v2 2/8] x86/hvm: Only populate info->cr2 for #PF in hvm_get_pending_event()

2023-08-24 Thread Jinoh Kang
Prepare for an upcoming patch that overloads the 'cr2' field for #DB. Signed-off-by: Jinoh Kang --- CC: Andrew Cooper CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Tamas K Lengyel CC: Alexandru Isaila CC: Petre Pircalabu --- xen/arch/x86/hvm/hvm.c | 9 +++-- 1 file changed, 7 in

[PATCH v2 1/8] x86: Fix calculation of %dr6/7 reserved bits

2023-08-24 Thread Jinoh Kang
From: Andrew Cooper The reserved bit calculations for %dr6 and %dr7 depend on whether the VM has the Restricted Transactional Memory feature available. Introduce adjust_dr{6,7}_rsvd() and replace the opencoded logic and constants (except for DR_STATUS_RESERVED_ONE which is (mis)used elsewhere an

[PATCH v2 0/8] Fixes to debugging facilities

2023-08-24 Thread Jinoh Kang
This is a rebased version of Andrew Cooper's debugging facilities patch: https://lore.kernel.org/xen-devel/1528120755-17455-1-git-send-email-andrew.coop...@citrix.com/ > So this started as a small fix for the vmentry failure (penultimate patch), > and has snowballed... > > I'm fairly confident tha

[GIT PULL] xen: branch for v6.6-rc1

2023-08-24 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-6.6-rc1-tag xen: branch for v6.6-rc1 It contains the following patches: - a bunch of minor cleanups - a patch adding irqfd support for virtio backends running as user daemon suppor

Re: "rcu_preempt detected stalls" with xen_free_irq involved

2023-08-24 Thread Marek Marczykowski-Górecki
On Wed, Aug 23, 2023 at 05:28:12AM +0200, Marek Marczykowski-Górecki wrote: > Hi, > > Since updating from 5.15.124 to 6.1.43, I observe rather often an issue > like in the subject. This happens on a domU with heavy vchan usage > (several connections established and released per second). > > The d

[xen-unstable-smoke test] 182504: tolerable all pass - PUSHED

2023-08-24 Thread osstest service owner
flight 182504 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182504/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH v3 4/4] xen/vpci: header: status register handler

2023-08-24 Thread Stewart Hildebrand
On 8/22/23 09:54, Jan Beulich wrote: > On 22.08.2023 03:29, Stewart Hildebrand wrote: >> Introduce a handler for the PCI status register, with ability to mask the >> capabilities bit. The status register is write-1-to-clear, so introduce >> handling >> for this type of register in vPCI. >> >> Sign

Re: [XEN PATCH v2] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-24 Thread Nicola Vetrini
On 24/08/2023 13:20, Julien Grall wrote: Hi Nicola, On 24/08/2023 12:11, Nicola Vetrini wrote: On 24/08/2023 10:01, Michal Orzel wrote: Hi Nicola, On 24/08/2023 09:37, Nicola Vetrini wrote: Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on t

Re: [PATCH] tools/oxenstored: Additional debugging commands

2023-08-24 Thread Christian Lindig
Acked-by: Christian Lindig > On 24 Aug 2023, at 13:39, Andrew Cooper wrote: > > From: Edwin Török > > These were added to aid security development, and are useful generally for > debugging. > > Signed-off-by: Edwin Török > Signed-off-by: Andrew Cooper > --- > CC: Christian Lindig > CC: E

[seabios test] 182501: tolerable FAIL - PUSHED

2023-08-24 Thread osstest service owner
flight 182501 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/182501/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 181546 test-amd64-i386-xl-qemuu-win7-amd64 19 gu

[PATCH] tools/oxenstored: Additional debugging commands

2023-08-24 Thread Andrew Cooper
From: Edwin Török These were added to aid security development, and are useful generally for debugging. Signed-off-by: Edwin Török Signed-off-by: Andrew Cooper --- CC: Christian Lindig CC: Edwin Török CC: Rob Hoes I found this hiding down the back of the patchqueue. --- tools/ocaml/xensto

Re: [XEN PATCH 07/13] xen/vpci: address violations of MISRA C:2012 Rule 7.3

2023-08-24 Thread Roger Pau Monné
On Thu, Aug 03, 2023 at 12:22:22PM +0200, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline > states: > "The lowercase character 'l' shall not be used in a literal suffix". > > Use the "L" suffix instead of the "l" suf

Re: [XEN PATCH v4 2/4] xen/vpci: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Roger Pau Monné
On Wed, Jul 26, 2023 at 01:03:37PM +0200, Simone Ballarin wrote: > From: Gianluca Luparini > > The xen sources contains violations of MISRA C:2012 Rule 7.2 whose > headline states: > "A 'u' or 'U' suffix shall be applied to all integer constants > that are represented in an unsigned type". > > A

[linux-linus test] 182499: regressions - FAIL

2023-08-24 Thread osstest service owner
flight 182499 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/182499/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 182424 test-amd64-amd64-xl

Re: [PATCH v2] docs/misra: add rule 2.1 exceptions

2023-08-24 Thread Julien Grall
On 24/08/2023 12:46, Julien Grall wrote: On 23/08/2023 23:39, Stefano Stabellini wrote: ---   docs/misra/rules.rst | 13 -   1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst index 8f0e4d3f25..4f33ed4ba6 100644 --- a/docs/misra/r

Re: [PATCH v2] docs/misra: add rule 2.1 exceptions

2023-08-24 Thread Julien Grall
On 23/08/2023 23:39, Stefano Stabellini wrote: From: Stefano Stabellini During the discussions that led to the acceptance of Rule 2.1, we decided on a few exceptions that were not properly recorded in rules.rst. Add them now. Signed-off-by: Stefano Stabellini Acked-by: Jan Beulich --- Not

[libvirt test] 182498: tolerable all pass - PUSHED

2023-08-24 Thread osstest service owner
flight 182498 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182498/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182426 test-armhf-armhf-libvirt-qcow2 15 saveres

Re: [XEN PATCH v2] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-24 Thread Julien Grall
Hi Nicola, On 24/08/2023 12:11, Nicola Vetrini wrote: On 24/08/2023 10:01, Michal Orzel wrote: Hi Nicola, On 24/08/2023 09:37, Nicola Vetrini wrote: Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and eas

Re: [PATCH v5 09/13] xen/arm: mm: Use generic variable/function names for extendability

2023-08-24 Thread Henry Wang
Hi Julienm > On Aug 24, 2023, at 18:19, Julien Grall wrote: > > Hi Henry, > > On 24/08/2023 10:46, Henry Wang wrote: >>> On Aug 22, 2023, at 02:32, Julien Grall wrote: >>> >>> Hi, >>> >>> On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng As preparation for MPU support, whic

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-08-24 Thread Julien Grall
Hi Anthony, On 18/08/2023 18:04, Anthony PERARD wrote: On Wed, Aug 09, 2023 at 11:33:05AM +0100, Julien Grall wrote: From: Julien Grall Currently, libxl will grant IOMEM, I/O port and IRQ permissions when a PCI is attached (see pci_add_dm_done()) for all domain types. However, the permissions

Re: [XEN PATCH v2] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-24 Thread Nicola Vetrini
On 24/08/2023 10:01, Michal Orzel wrote: Hi Nicola, On 24/08/2023 09:37, Nicola Vetrini wrote: Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of maintenance. A static inline function is the chose

Re: [XEN PATCH] CI: Always move the bisect build log back

2023-08-24 Thread Andrew Cooper
On 24/08/2023 11:48 am, Anthony PERARD wrote: > On Thu, Aug 24, 2023 at 10:51:20AM +0100, Andrew Cooper wrote: >> On 24/08/2023 9:52 am, Anthony PERARD wrote: >>> On Wed, Aug 23, 2023 at 07:05:56PM +0100, Andrew Cooper wrote: On 23/08/2023 4:23 pm, Anthony PERARD wrote: > On failure of "bu

Re: [XEN PATCH 06/13] xen/mem_access: address violations of MISRA C:2012 Rule 7.3

2023-08-24 Thread Jan Beulich
On 04.08.2023 02:47, Stefano Stabellini wrote: > On Thu, 3 Aug 2023, Simone Ballarin wrote: >> From: Gianluca Luparini >> >> The xen sources contain violations of MISRA C:2012 Rule 7.3 whose headline >> states: >> "The lowercase character 'l' shall not be used in a literal suffix". >> >> Use the "

Re: [XEN PATCH] CI: Always move the bisect build log back

2023-08-24 Thread Anthony PERARD
On Thu, Aug 24, 2023 at 10:51:20AM +0100, Andrew Cooper wrote: > On 24/08/2023 9:52 am, Anthony PERARD wrote: > > On Wed, Aug 23, 2023 at 07:05:56PM +0100, Andrew Cooper wrote: > >> On 23/08/2023 4:23 pm, Anthony PERARD wrote: > >>> On failure of "build"-each-commit script, the next command that mo

Re: [PATCH 1/2] tools/libs: light: Remove the variable 'domainid' do_pci_remove()

2023-08-24 Thread Julien Grall
Hi Anthony, On 18/08/2023 18:05, Anthony PERARD wrote: On Wed, Aug 09, 2023 at 11:33:04AM +0100, Julien Grall wrote: From: Julien Grall The function do_pci_remove() has two local variables 'domid' and 'domainid' containing the same value. Looking at the history, until 2cf3b50dcd8b ("libxl_pc

Re: [XEN PATCH v4 2/4] xen/vpci: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Nicola Vetrini
On 26/07/2023 13:03, Simone Ballarin wrote: From: Gianluca Luparini The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers liter

Re: [XEN PATCH v4 3/4] x86/viridian: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Nicola Vetrini
On 26/07/2023 13:03, Simone Ballarin wrote: From: Gianluca Luparini The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers liter

Re: [XEN PATCH v4 1/4] x86/vmx: address violations of MISRA C:2012 Rule 7.2

2023-08-24 Thread Nicola Vetrini
On 26/07/2023 13:03, Simone Ballarin wrote: From: Gianluca Luparini The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline states: "A 'u' or 'U' suffix shall be applied to all integer constants that are represented in an unsigned type". Add the 'U' suffix to integers liter

Re: [PATCH v5 09/13] xen/arm: mm: Use generic variable/function names for extendability

2023-08-24 Thread Julien Grall
Hi Henry, On 24/08/2023 10:46, Henry Wang wrote: On Aug 22, 2023, at 02:32, Julien Grall wrote: Hi, On 14/08/2023 05:25, Henry Wang wrote: From: Penny Zheng As preparation for MPU support, which will use some variables/functions for both MMU and MPU system, We rename the affected variable/f

Re: [PATCH] xen/arm: Handle empty grant table region in find_unallocated_memory()

2023-08-24 Thread Julien Grall
On 24/08/2023 10:17, Michal Orzel wrote: On 24/08/2023 11:10, Julien Grall wrote: On 24/08/2023 10:06, Michal Orzel wrote: When creating dom0 with grant table support disabled in Xen and no IOMMU, the following assert is triggered (debug build): "Assertion 's <= e' failed at common/rangeset.

Re: [PATCH] xen/console: Set the default log level to INFO for release builds

2023-08-24 Thread Andrew Cooper
On 24/08/2023 10:02 am, Roger Pau Monne wrote: > From: Ross Lagerwall > > Not displaying INFO messages by default on release builds is not > helpful, as messages of that level are relevant for hypervisor > operation. For example messages related to livepatches applied and > reverted are of INFO l

Re: [XEN PATCH] CI: Always move the bisect build log back

2023-08-24 Thread Andrew Cooper
On 24/08/2023 9:52 am, Anthony PERARD wrote: > On Wed, Aug 23, 2023 at 07:05:56PM +0100, Andrew Cooper wrote: >> On 23/08/2023 4:23 pm, Anthony PERARD wrote: >>> On failure of "build"-each-commit script, the next command that move >>> the log back into the build directory isn't executed. Fix that b

[xen-unstable test] 182481: regressions - FAIL

2023-08-24 Thread osstest service owner
flight 182481 xen-unstable real [real] flight 182500 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182481/ http://logs.test-lab.xenproject.org/osstest/logs/182500/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [PATCH v5 09/13] xen/arm: mm: Use generic variable/function names for extendability

2023-08-24 Thread Henry Wang
Hi Julien, > On Aug 22, 2023, at 02:32, Julien Grall wrote: > > Hi, > > On 14/08/2023 05:25, Henry Wang wrote: >> From: Penny Zheng >> As preparation for MPU support, which will use some variables/functions >> for both MMU and MPU system, We rename the affected variable/function >> to more gen

Re: [PATCH] xen/arm: Handle empty grant table region in find_unallocated_memory()

2023-08-24 Thread Michal Orzel
Hi Julien, On 24/08/2023 11:10, Julien Grall wrote: > > > Hi, > > On 24/08/2023 10:06, Michal Orzel wrote: >> When creating dom0 with grant table support disabled in Xen and no IOMMU, >> the following assert is triggered (debug build): >> "Assertion 's <= e' failed at common/rangeset.c:189" >

Re: [PATCH] xen/arm: Handle empty grant table region in find_unallocated_memory()

2023-08-24 Thread Julien Grall
Hi, On 24/08/2023 10:06, Michal Orzel wrote: When creating dom0 with grant table support disabled in Xen and no IOMMU, the following assert is triggered (debug build): "Assertion 's <= e' failed at common/rangeset.c:189" A partial stack trace would have been handy. This help the reader to und

[PATCH] xen/arm: Handle empty grant table region in find_unallocated_memory()

2023-08-24 Thread Michal Orzel
When creating dom0 with grant table support disabled in Xen and no IOMMU, the following assert is triggered (debug build): "Assertion 's <= e' failed at common/rangeset.c:189" This is because find_unallocated_memory() (used to find memory holes for extended regions) calls rangeset_remove_range() f

[PATCH] xen/console: Set the default log level to INFO for release builds

2023-08-24 Thread Roger Pau Monne
From: Ross Lagerwall Not displaying INFO messages by default on release builds is not helpful, as messages of that level are relevant for hypervisor operation. For example messages related to livepatches applied and reverted are of INFO level. Custom builds that require less verbose output can

Re: [RFC PATCH 0/3] x86/paravirt: Get rid of paravirt patching

2023-08-24 Thread Juergen Gross
PING! On 10.07.23 14:29, Juergen Gross wrote: Any comments? On 08.06.23 16:03, Juergen Gross wrote: This is a small series getting rid of paravirt patching by switching completely to alternative patching for the same functionality. The basic idea is to add the capability to switch from indire

Re: [XEN PATCH] CI: Always move the bisect build log back

2023-08-24 Thread Anthony PERARD
On Wed, Aug 23, 2023 at 07:05:56PM +0100, Andrew Cooper wrote: > On 23/08/2023 4:23 pm, Anthony PERARD wrote: > > On failure of "build"-each-commit script, the next command that move > > the log back into the build directory isn't executed. Fix that by > > using "after_script" which is always execu

Re: [XEN PATCH v2] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-24 Thread Michal Orzel
Hi Nicola, On 24/08/2023 09:37, Nicola Vetrini wrote: > > > Directive 4.3 prescribes the following: > "Assembly language shall be encapsulated and isolated", > on the grounds of improved readability and ease of maintenance. > > A static inline function is the chosen encapsulation mechanism. >

[XEN PATCH v2] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-24 Thread Nicola Vetrini
Directive 4.3 prescribes the following: "Assembly language shall be encapsulated and isolated", on the grounds of improved readability and ease of maintenance. A static inline function is the chosen encapsulation mechanism. No functional change. Signed-off-by: Nicola Vetrini --- Changes in v2:

Re: [XEN PATCH] arm64/vfp: address MISRA C:2012 Dir 4.3

2023-08-24 Thread Nicola Vetrini
On 23/08/2023 22:30, Stefano Stabellini wrote: On Wed, 23 Aug 2023, Julien Grall wrote: Hi Nicola, On 23/08/2023 17:09, Nicola Vetrini wrote: > On 23/08/2023 16:59, Julien Grall wrote: > > Hi, > > > > On 23/08/2023 15:27, Nicola Vetrini wrote: > > > Directive 4.3 prescribes the following: > > >