On 17.08.2023 22:45, Andrew Cooper wrote:
> GCC 12 objects to pointers derived from a constant:
>
> util.c: In function 'find_rsdp':
> util.c:429:16: error: array subscript 0 is outside array bounds of
> 'uint16_t[0]' {aka 'short unsigned int[]'} [-Werror=array-bounds]
> 429 | ebda_se
On 17.08.2023 23:43, Julien Grall wrote:
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -339,36 +339,36 @@ typedef uint64_t xen_callback_t;
>
> /* PSR bits (CPSR, SPSR) */
>
> -#define PSR_THUMB (1<<5)/* Thumb Mode enable */
> -#define PSR_FIQ_MA
flight 182372 xen-unstable real [real]
flight 182375 xen-unstable real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182372/
http://logs.test-lab.xenproject.org/osstest/logs/182375/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-armh
> From: Jan Beulich
> Sent: Wednesday, August 16, 2023 5:52 PM
>
> Old gcc won't cope with initializers involving unnamed struct/union
> fields.
>
> Fixes: 3e033172b025 ("x86/iommu: pass full IO-APIC RTE for remapping table
> update")
> Signed-off-by: Jan Beulich
>
Reviewed-by: Kevin Tian
Hi Julien,
> On Aug 18, 2023, at 05:43, Julien Grall wrote:
>
> From: Julien Grall
>
> The defines PSR_* are field in registers and always unsigned. So
> add 'U' to clarify.
>
> This should help with MISRA Rule 7.2.
>
> Signed-off-by: Julien Grall
Reviewed-by: Henry Wang
Tested-by: Henry
Hi Julien,
> On Aug 18, 2023, at 05:43, Julien Grall wrote:
>
> From: Julien Grall
>
> Switch to unsigned int for the return/parameters of the following
> functions:
>* REG_RANK_NR(): 'b' (number of bits) and the return is always positive.
> 'n' doesn't need to be size specific.
>
Hi Julien,
> On Aug 18, 2023, at 05:43, Julien Grall wrote:
>
> From: Julien Grall
>
> The number of virtual MMIO regions cannot be negative. So switch
> the field 'num_entries' and 'max_num_entries' to 'unsigned int'.
>
> The new type is then propagated to the caller and the vGIC
> code.
>
flight 182371 linux-linus real [real]
flight 182373 linux-linus real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/182371/
http://logs.test-lab.xenproject.org/osstest/logs/182373/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run
On Thu, 17 Aug 2023, Julien Grall wrote:
> From: Julien Grall
>
> The defines PSR_* are field in registers and always unsigned. So
> add 'U' to clarify.
>
> This should help with MISRA Rule 7.2.
>
> Signed-off-by: Julien Grall
Reviewed-by: Stefano Stabellini
> ---
> xen/include/public/arc
On Thu, 17 Aug 2023, Julien Grall wrote:
> From: Julien Grall
>
> Switch to unsigned int for the return/parameters of the following
> functions:
> * REG_RANK_NR(): 'b' (number of bits) and the return is always positive.
> 'n' doesn't need to be size specific.
> * vgic_rank_offset():
On Thu, 17 Aug 2023, Julien Grall wrote:
> From: Julien Grall
>
> The number of virtual MMIO regions cannot be negative. So switch
> the field 'num_entries' and 'max_num_entries' to 'unsigned int'.
>
> The new type is then propagated to the caller and the vGIC
> code.
>
> Signed-off-by: Julien
From: Julien Grall
The defines PSR_* are field in registers and always unsigned. So
add 'U' to clarify.
This should help with MISRA Rule 7.2.
Signed-off-by: Julien Grall
---
xen/include/public/arch-arm.h | 52 +--
1 file changed, 26 insertions(+), 26 deletions(
From: Julien Grall
Switch to unsigned int for the return/parameters of the following
functions:
* REG_RANK_NR(): 'b' (number of bits) and the return is always positive.
'n' doesn't need to be size specific.
* vgic_rank_offset(): 'b' (number of bits), 'n' (register index),
's'
From: Julien Grall
Hi all,
This is a small series to fix some of the issues found while playing
with -Wconversion and -Warith-conversion.
There are a lot more but the bulk are in
- bitmap
- cpumask
- nodemask
- bitops/atomics
- find_*
Some are not too difficult to address but other there
From: Julien Grall
The number of virtual MMIO regions cannot be negative. So switch
the field 'num_entries' and 'max_num_entries' to 'unsigned int'.
The new type is then propagated to the caller and the vGIC
code.
Signed-off-by: Julien Grall
---
xen/arch/arm/domain.c | 3 ++-
xen/ar
GCC 12 objects to pointers derived from a constant:
util.c: In function 'find_rsdp':
util.c:429:16: error: array subscript 0 is outside array bounds of
'uint16_t[0]' {aka 'short unsigned int[]'} [-Werror=array-bounds]
429 | ebda_seg = *(uint16_t *)ADDR_FROM_SEG_OFF(0x40, 0xe);
cc1:
On Thu, 17 Aug 2023, Nicola Vetrini wrote:
> The arch-specific header should be included by the
> common header , so that the latter can be included
> in the source files.
>
> This also resolves violations of MISRA C:2012 Rule 8.4 that were
> caused by declarations for
> 'vm_event_{fill_regs,set_
On Thu, 17 Aug 2023, Federico Serafini wrote:
> Add entries to the exclude-list.json for those files that need to be
> excluded from the analysis scan.
>
> Signed-off-by: Federico Serafini
Acked-by: Stefano Stabellini
> ---
> Changes in v2:
> - fixed indentation.
> ---
> docs/misra/exclude-l
On Thu, 17 Aug 2023, Federico Serafini wrote:
> Mark more files as "adopted" and configure Rule 8.3 in order to:
> - exclude violations involving the type ret_t;
> - exclude violations involving both an internal and an external file,
> thus avoiding touching adopted code.
>
> Signed-off-by: Fede
flight 182370 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182370/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
Are you saying that CONFIG_VGA implies CONFIG_VIDEO and therefore
"#ifdef CONFIG_VGA"
at line 14 of vga.h can be used instead of the #ifdefs inherited from
the original locations
to wrap all the declarations that are being moved?
Yes - see drivers/video/Kconfig.
Jan
Ok then. I guess I can
There is a batching mechanism for virtio-blk Used Buffer Notifications
that is no longer needed because the previous commit added batching to
virtio_notify_irqfd().
Note that this mechanism was rarely used in practice because it is only
enabled when EVENT_IDX is not negotiated by the driver. Moder
virtio-blk and virtio-scsi invoke virtio_irqfd_notify() to send Used
Buffer Notifications from an IOThread. This involves an eventfd
write(2) syscall. Calling this repeatedly when completing multiple I/O
requests in a row is wasteful.
Use the defer_call() API to batch together virtio_irqfd_notify(
The networking subsystem may wish to use defer_call(), so move the code
to util/ where it can be reused.
As a reminder of what defer_call() does:
This API defers a function call within a defer_call_begin()/defer_call_end()
section, allowing multiple calls to batch up. This is a performance
optimi
Prepare to move the blk_io_plug_call() API out of the block layer so
that other subsystems call use this deferred call mechanism. Rename it
to defer_call() but leave the code in block/plug.c.
The next commit will move the code out of the block layer.
Suggested-by: Ilya Maximets
Signed-off-by: St
v2:
- Rename blk_io_plug() to defer_call() and move it to util/ so the net
subsystem can use it [Ilya]
- Add defer_call_begin()/end() to thread_pool_completion_bh() to match Linux
AIO and io_uring completion batching
Replace the seldom-used virtio-blk notification BH mechanism with
blk_io_plug
On 17/08/2023 2:13 pm, Jan Beulich wrote:
> On 17.08.2023 14:58, Andrew Cooper wrote:
>> On 17/08/2023 12:47 pm, Jan Beulich wrote:
>>> Our present approach is working fully behind the compiler's back. This
>>> was found to not work with LTO. Employ ld's --wrap= option instead. Note
>>> that while
On 17.08.2023 16:52, Nicola Vetrini wrote:
> On 17/08/2023 15:28, Jan Beulich wrote:
>> On 17.08.2023 14:39, Nicola Vetrini wrote:
>>> --- a/xen/include/xen/vga.h
>>> +++ b/xen/include/xen/vga.h
>>> @@ -15,4 +15,20 @@
>>> extern struct xen_vga_console_info vga_console_info;
>>> #endif
>>>
>>> +in
On 16.08.2023 12:19, Oleksii Kurochko wrote:
> --- /dev/null
> +++ b/xen/include/public/arch-riscv.h
> @@ -0,0 +1,90 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */
> +/*
> + * Guest OS interface to RISC-V Xen.
> + * Initially based on the ARM implementation.
> + */
> +
> +#ifndef __XEN_PUBLI
On 17/08/2023 2:15 pm, Jan Beulich wrote:
> On 17.08.2023 14:58, Andrew Cooper wrote:
>> On 17/08/2023 12:47 pm, Jan Beulich wrote:
>>> Our present approach is working fully behind the compiler's back. This
>>> was found to not work with LTO. Employ ld's --wrap= option instead. Note
>>> that while
On 17/08/2023 15:28, Jan Beulich wrote:
On 17.08.2023 14:39, Nicola Vetrini wrote:
--- a/xen/include/xen/vga.h
+++ b/xen/include/xen/vga.h
@@ -15,4 +15,20 @@
extern struct xen_vga_console_info vga_console_info;
#endif
+int fill_console_start_info(struct dom0_vga_console_info *);
+
+#ifdef CON
On 17.08.23 03:47, Li Zetao wrote:
Use IS_ERR_OR_NULL() to detect an error pointer or a null pointer
open-coding to simplify the code.
Signed-off-by: Li Zetao
Reviewed-by: Juergen Gross
Juergen
OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key
OpenPGP_signature.asc
Descri
flight 182368 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182368/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182337
test-armhf-armhf-libvirt-qcow2 15 saveres
On 17.08.2023 14:39, Nicola Vetrini wrote:
> --- a/xen/include/xen/vga.h
> +++ b/xen/include/xen/vga.h
> @@ -15,4 +15,20 @@
> extern struct xen_vga_console_info vga_console_info;
> #endif
>
> +int fill_console_start_info(struct dom0_vga_console_info *);
> +
> +#ifdef CONFIG_X86
> +void vesa_earl
On 17.08.2023 14:58, Andrew Cooper wrote:
> On 17/08/2023 12:47 pm, Jan Beulich wrote:
>> Our present approach is working fully behind the compiler's back. This
>> was found to not work with LTO. Employ ld's --wrap= option instead. Note
>> that while this makes the build work at least with new enou
On 17.08.2023 14:58, Andrew Cooper wrote:
> On 17/08/2023 12:47 pm, Jan Beulich wrote:
>> Our present approach is working fully behind the compiler's back. This
>> was found to not work with LTO. Employ ld's --wrap= option instead. Note
>> that while this makes the build work at least with new enou
On 17.08.2023 14:49, Daniel P. Smith wrote:
> On 8/17/23 08:17, Jason Andryuk wrote:
>> On Wed, Aug 16, 2023 at 3:05 PM Daniel P. Smith
>> wrote:
>>>
>>> This is to complement patch 'common: move Linux-inherited fixed width type
>>> decls to common header' by removing the unnecessary include of
>>
On 17/08/2023 12:47 pm, Jan Beulich wrote:
> Our present approach is working fully behind the compiler's back. This
> was found to not work with LTO. Employ ld's --wrap= option instead. Note
> that while this makes the build work at least with new enough gcc (it
> doesn't with gcc7, for example, du
On 16.08.2023 20:50, Stewart Hildebrand wrote:
> If there are no capabilities to be exposed to the guest, a future status
> register handler likely would want to mask the PCI_STATUS_CAP_LIST bit. See
> [1]
> for a suggestion of how this might be tracked in struct vpci_header.
Can we actually get
On 8/17/23 08:17, Jason Andryuk wrote:
On Wed, Aug 16, 2023 at 3:05 PM Daniel P. Smith
wrote:
This is to complement patch 'common: move Linux-inherited fixed width type
decls to common header' by removing the unnecessary include of
'asm/byteorder.h'. In the process of removing these includes,
The files touched by this series contain function or variable definitions with
no prior declaration visible, because it's inside an header that is not included
or it's not present anywhere. This is a risk in itself, but also violates
MISRA C:2012 Rule 8.4, which states the following:
"A compatible
The function can become static since it's used only within this file.
This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence
of a declaration before the function definition.
Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X table")
Signed-off-by: Nicola Vet
The arch-specific header should be included by the
common header , so that the latter can be included
in the source files.
This also resolves violations of MISRA C:2012 Rule 8.4 that were
caused by declarations for
'vm_event_{fill_regs,set_registers,monitor_next_interrupt}'
in not being visible
The declarations for 'vesa_{init,early_init,endboot}' needed by
'xen/drivers/video/vesa.c' and 'fill_console_start_info' in 'vga.c'
are now available by moving the relative code inside 'vga.h'.
The latter is moved from 'xen/console.h' because of its close relation with vga.
This also resolves viola
On Wed, Aug 16, 2023 at 3:05 PM Daniel P. Smith
wrote:
>
> This is to complement patch 'common: move Linux-inherited fixed width type
> decls to common header' by removing the unnecessary include of
> 'asm/byteorder.h'. In the process of removing these includes, the ordering was
> corrected to com
On 16.08.2023 21:04, Daniel P. Smith wrote:
> This is to complement patch 'common: move Linux-inherited fixed width type
> decls to common header' by removing the unnecessary include of
> 'asm/byteorder.h'. In the process of removing these includes, the ordering was
> corrected to comply with curre
On 17.08.2023 12:32, Oleksii wrote:
> On Wed, 2023-08-16 at 15:39 +0200, Jan Beulich wrote:
>> Plus the question remains of it necessarily being com1: Is there no
>> way with DT to have multiple serial ports (e.g. one for the console
>> and one for a debugger)? If there indeed isn't, then unconditi
All,
we're pleased to announce the release of four bug fixing Xen versions.
Xen 4.17.2 has been available for a little while from its git repository
http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.17
(tag RELEASE-4.17.2) or from the XenProject download page
https://xenpr
Our present approach is working fully behind the compiler's back. This
was found to not work with LTO. Employ ld's --wrap= option instead. Note
that while this makes the build work at least with new enough gcc (it
doesn't with gcc7, for example, due to tool chain side issues afaict),
according to m
Hi,
On 17/08/2023 11:13, Federico Serafini wrote:
On 17/08/23 12:02, Federico Serafini wrote:
On 17/08/23 11:57, Julien Grall wrote:
Hi,
On 17/08/2023 10:55, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Sign
flight 182367 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/182367/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 182359 pass in 182367
test-amd64-i386-libvirt-qemuu-de
issue:
File "/home/xtf/xtf-runner", line 410, in interpret_selection
if not line.startswith("xen_caps"):
^^^
TypeError: startswith first arg must be bytes or a tuple of bytes, not str
Adding `universal_newlines` open stdout as text file, so line should
be a
On 17/08/23 11:42, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
docs/misra/exclude-list.json | 12
1 file changed, 12 insertions(+)
diff --git a/docs/misra/
On Wed, 2023-08-16 at 15:39 +0200, Jan Beulich wrote:
> On 11.08.2023 17:30, Oleksii Kurochko wrote:
> > @@ -1555,6 +1566,9 @@ static bool __init parse_positional(struct
> > ns16550 *uart, char **str)
> > }
> > else
> > #endif
> > + if ( strncmp(conf, "poll", 4) == 0 )
> >
On 17/08/23 12:02, Federico Serafini wrote:
On 17/08/23 11:57, Julien Grall wrote:
Hi,
On 17/08/2023 10:55, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
Changes in v2:
-
On 17/08/23 11:57, Julien Grall wrote:
Hi,
On 17/08/2023 10:55, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
Changes in v2:
- fixed indentation.
What's the difference with
Hi,
On 17/08/2023 10:55, Federico Serafini wrote:
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
Changes in v2:
- fixed indentation.
What's the difference with the other v2 you posted ~10 min ago?
Is
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
Changes in v2:
- fixed indentation.
---
docs/misra/exclude-list.json | 12
1 file changed, 12 insertions(+)
diff --git a/docs/misra/exclude-lis
Mark more files as "adopted" and configure Rule 8.3 in order to:
- exclude violations involving the type ret_t;
- exclude violations involving both an internal and an external file,
thus avoiding touching adopted code.
Signed-off-by: Federico Serafini
---
.../eclair_analysis/ECLAIR/deviations.
Add files to exclude-list.json and adapt the ECLAIR configuration to keep
track of the changes.
Federico Serafini (2):
automation/eclair: update configuration
misra: add more entires to exclude-list.json
.../eclair_analysis/ECLAIR/deviations.ecl | 29 +++
.../eclair_analy
Add entries to the exclude-list.json for those files that need to be
excluded from the analysis scan.
Signed-off-by: Federico Serafini
---
docs/misra/exclude-list.json | 12
1 file changed, 12 insertions(+)
diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json
in
On 16/08/2023 17:28, Julien Grall wrote:
On 16/08/2023 16:18, Nicola Vetrini wrote:
Hi,
Hi,
the function mentioned in the subject, defined in
'xen/arch/arm/traps.c' seems to have no
caller (either from C code or from asm code), so I think it can be
safely removed, unless
there's a reason f
Hi,
On 17/08/2023 01:31, Vikram Garhwal wrote:
On Mon, Jun 05, 2023 at 10:07:48PM +0100, Julien Grall wrote:
+{
+int rc = 0;
+struct domain *d = hardware_domain;
+domid_t domid;
+unsigned int naddr, len;
+unsigned int i, nirq;
+
+domid = dt_device_used_by(device_node);
Hi,
On 17/08/2023 00:49, Vikram Garhwal wrote:
On Tue, Jun 06, 2023 at 12:09:35PM -0700, Vikram Garhwal wrote:
Hi Julien,
Will update the commit message regarding why we need to export this for dtbo
programming.
On 6/5/23 12:04 PM, Julien Grall wrote:
Hi,
Title:
'type' is a bit confusing he
Hi,
On 17/08/2023 08:25, Jan Beulich wrote:
On 17.08.2023 09:06, Julien Grall wrote:
On 17/08/2023 07:39, Jan Beulich wrote:
On 16.08.2023 18:57, Julien Grall wrote:
On 16/08/2023 10:51, Jan Beulich wrote:
Old gcc won't cope with initializers involving unnamed struct/union
Can you specify
On 16.08.2023 20:50, Stewart Hildebrand wrote:
> The only purpose of this is to give an idea of what it might look like to
> introduce a new memory allocation in order to get rid of the casts for the
> value
> passed to vpci_read_val. If this is deemed preferable vs the casts, I will
> squash it f
On 17.08.2023 09:06, Julien Grall wrote:
> On 17/08/2023 07:39, Jan Beulich wrote:
>> On 16.08.2023 18:57, Julien Grall wrote:
>>> On 16/08/2023 10:51, Jan Beulich wrote:
Old gcc won't cope with initializers involving unnamed struct/union
>>>
>>> Can you specify the newest version of GCC that
On 17.08.2023 02:39, Vikram Garhwal wrote:
> Remove master device from the IOMMU. This will be helpful when removing the
> overlay nodes using dynamic programming during run time.
>
> Signed-off-by: Vikram Garhwal
Since formally required:
Acked-by: Jan Beulich
Jan
Hi Jan,
On 17/08/2023 07:39, Jan Beulich wrote:
On 16.08.2023 18:57, Julien Grall wrote:
On 16/08/2023 10:51, Jan Beulich wrote:
Old gcc won't cope with initializers involving unnamed struct/union
Can you specify the newest version of GCC that breaks? This would help
to reproduce your proble
On 17.08.2023 02:39, Vikram Garhwal wrote:
> --- /dev/null
> +++ b/xen/include/xen/iommu-private.h
I don't think private headers should live in include/xen/. Judging from only
the patches I was Cc-ed on, ...
> @@ -0,0 +1,28 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * xen/iommu-p
70 matches
Mail list logo
