Re: [XEN PATCH 2/2] automation/eclair: avoid unintentional ECLAIR analysis

2023-08-11 Thread Simone Ballarin
On 12/08/2023 00:04, Stefano Stabellini wrote: On Fri, 11 Aug 2023, Simone Ballarin wrote: With this patch, ECLAIR jobs will need to be manually started for "people/.*" pipelines. This avoids occupying the runner on analyzes that might not be used by developers. If developers want to analyze t

Re: [PATCH 00/22] Cleanup and splitting of xl.cfg parsing

2023-08-11 Thread Elliott Mitchell
On Thu, Aug 03, 2023 at 06:48:33PM +0100, Julien Grall wrote: > Hi, > > On 03/08/2023 18:45, Elliott Mitchell wrote: > > On Thu, Aug 03, 2023 at 05:34:31PM +0100, Julien Grall wrote: > >> > >> Not sure if this is related to the lack of answer. But I didn't receive > >> any of your patches via xen-

[xen-unstable test] 182272: tolerable FAIL - PUSHED

2023-08-11 Thread osstest service owner
flight 182272 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182272/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182260 test-amd64-amd64-xl-qemut-win7-amd64

Re: [PATCH RESEND] libxl: Make domain build xc_domain_setmaxmem() call use max_memkb

2023-08-11 Thread Kevin Alarcon Negy
Apologies if I misused the "RESEND" subject line. The xen patch guide [1] seemed to suggest using it as a way to ping. Thanks for the feedback. I realize now that my misunderstanding in how the original code should work is because of my confusion between "maxmem" the config variable vs. "xl mem-ma

[PATCH 1/3] automation: switch from Debian unstable to bookworm

2023-08-11 Thread Stefano Stabellini
From: Stefano Stabellini Debian unstable used in the Xen containers is actually bookworm. Switching to bookworm which is now stable means we are not basing our containers on a moving target anymore. Signed-off-by: Stefano Stabellini --- ...2-gcc.dockerfile => bookworm-arm64v8-arm32-gcc.dockerf

[PATCH 3/3] automation: update jobs to use Debian Bookworm instead of unstable

2023-08-11 Thread Stefano Stabellini
From: Stefano Stabellini Signed-off-by: Stefano Stabellini --- automation/gitlab-ci/build.yaml | 84 - automation/gitlab-ci/test.yaml | 24 +- 2 files changed, 54 insertions(+), 54 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/g

[PATCH 2/3] automation: update test-artifacts to use Debian Bookworm instead of unstable

2023-08-11 Thread Stefano Stabellini
From: Stefano Stabellini Signed-off-by: Stefano Stabellini --- automation/tests-artifacts/kernel/5.19-arm64v8.dockerfile | 2 +- automation/tests-artifacts/kernel/6.1.19.dockerfile | 2 +- .../qemu-system-aarch64/6.0.0-arm64v8.dockerfile| 2 +- 3 files changed,

[PATCH 0/3] automation: switch Debian unstable to Bookworm

2023-08-11 Thread Stefano Stabellini
Hi all, Debian unstable has been released as Bookworm, so let's change our containers to use Bookworm which is a stable release. Here is proof everything still works: https://gitlab.com/xen-project/people/sstabellini/xen/-/pipelines/964051324 Cheers, Stefano

[linux-5.4 test] 182270: regressions - FAIL

2023-08-11 Thread osstest service owner
flight 182270 linux-5.4 real [real] flight 182289 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182270/ http://logs.test-lab.xenproject.org/osstest/logs/182289/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

Re: [XEN PATCH 6/6] drivers/video: make declarations of defined functions available

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Nicola Vetrini wrote: > The declarations for 'vesa_{init,early_init,endboot}' needed by > 'xen/drivers/video/vesa.c' and 'fill_console_start_info' in 'vga.c' > are now available by moving the relative code inside 'vga.h' and > including "" respectively. > This also resolves vio

Re: [XEN PATCH 5/6] vpic/msix: make 'get_slot' static

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Nicola Vetrini wrote: > The function can become static since it's used only within this file. > This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence > of a declaration before the function definition. > > Signed-off-by: Nicola Vetrini > Fixes: b177892d2d0

Re: [XEN PATCH 4/6] cpufreq: add missing include of header 'pmstat.h'

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Nicola Vetrini wrote: > The missing header included by this patch provides a declaration for > 'set_px_pminfo' that is visible prior to the definition in this file. > This also resolves a violation of MISRA C:2012 Rule 8.4. > > Signed-off-by: Nicola Vetrini > Fixes: 452119c09

Re: [XEN PATCH 3/6] x86/vm_event: add missing include

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Nicola Vetrini wrote: > The missing header included by this patch provides declarations for > the functions 'vm_event_{fill_regs,set_registers,monitor_next_interrupt}' > that are defined in the source file. This also resolves violations > of MISRA C:2012 Rule 8.4. > > Signed-o

Re: [XEN PATCH 2/6] x86/setup: add missing headers

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Nicola Vetrini wrote: > The missing headers declare variables 'xen_cpuidle' and 'use_invpcid' > that are then defined inside the file. > This is undesirable and also violates MISRA C:2012 Rule 8.4. > Adding suitable "#include"s resolves the issue. > > The type of the variable

Re: [XEN PATCH 1/6] x86/hpet: make variable 'per_cpu__cpu_bc_channel' static

2023-08-11 Thread Stefano Stabellini
Adding x86 maintainers On Fri, 11 Aug 2023, Stefano Stabellini wrote: > On Fri, 11 Aug 2023, Nicola Vetrini wrote: > > The variable is only ever used inside the file where it's > > defined, therefore it can have static storage. This also > > resolves a violation of MISRA C:2012 Rule 8.4 due to the

Re: [XEN PATCH 1/6] x86/hpet: make variable 'per_cpu__cpu_bc_channel' static

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Nicola Vetrini wrote: > The variable is only ever used inside the file where it's > defined, therefore it can have static storage. This also > resolves a violation of MISRA C:2012 Rule 8.4 due to the absence > of a declaration prior to the definition. > > Signed-off-by: Nicola

Re: [XEN PATCH] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Federico Serafini wrote: > Uniform the auto-generated hypercall-decls with the corresponding > definitions to address violations of MISRA C:2012 Rule 8.3: > "All declarations of an object or function shall use the same names and > type qualifiers". > > No functional change. >

[linux-linus test] 182266: tolerable FAIL - PUSHED

2023-08-11 Thread osstest service owner
flight 182266 linux-linus real [real] flight 182285 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/182266/ http://logs.test-lab.xenproject.org/osstest/logs/182285/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-

Re: [XEN PATCH 1/2] automation: avoid pipelines on specific branches

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Simone Ballarin wrote: > This patch avoids the execution of pipelines in the > following branches: > - master > - smoke > - coverirty-tested/.* > - stable-.* > > The job-level exclusions have been removed as they are > pointless with this new workspace-level exclusion. > Ver

Re: [XEN PATCH 2/2] automation/eclair: avoid unintentional ECLAIR analysis

2023-08-11 Thread Stefano Stabellini
On Fri, 11 Aug 2023, Simone Ballarin wrote: > With this patch, ECLAIR jobs will need to be manually > started for "people/.*" pipelines. > > This avoids occupying the runner on analyzes that might > not be used by developers. > > If developers want to analyze their own repositories > they need to

Re: [PATCH 4/5] xen/arm: Move static memory build code in separate modules

2023-08-11 Thread Luca Fancellu
Hi Julien, > On 11 Aug 2023, at 19:14, Julien Grall wrote: > > Hi Luca, > > On IRC, you suggest to skip the review for the patches moving out some code. > However, I still have one remark. > > On 08/08/2023 09:00, Luca Fancellu wrote: >> Move static memory and static shared memory code in sep

Re: [XEN PATCH 10/11] xen/sched: add ASSERT_UNREACHABLE() to address MISRA C:2012 Rule 2.1

2023-08-11 Thread Julien Grall
Hi Stefano, On 08/08/2023 22:14, Stefano Stabellini wrote: On Tue, 8 Aug 2023, Julien Grall wrote: On 08/08/2023 16:53, Nicola Vetrini wrote: ... "return" alone already tells the compiler that "break" is unreachable. You don't need unreachable() for that. As said before, "break" like this simp

Re: [PATCH 1/2] xen/arm: Fix initrd placeholders generation in make_chosen_node()

2023-08-11 Thread Julien Grall
Hi Michal, On 10/08/2023 12:25, Michal Orzel wrote: When booting a dom0less domU without initial ramdisk, it was observed that Xen still creates empty linux,initrd-{start,end} properties under /chosen node. This is because in make_chosen_node(), generation of initrd placeholders (later on filled

Re: [PATCH 4/5] xen/arm: Move static memory build code in separate modules

2023-08-11 Thread Julien Grall
Hi Luca, On IRC, you suggest to skip the review for the patches moving out some code. However, I still have one remark. On 08/08/2023 09:00, Luca Fancellu wrote: Move static memory and static shared memory code in separate modules so that they are included only when the corresponding feature

Re: [PATCH v8 2/6] xen/riscv: introduce

2023-08-11 Thread Alistair Francis
On Fri, Aug 11, 2023 at 10:33 AM Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis Alistair > --- > Changes in V8: > - new patch. It was introduced instead of dummy asm/bug.h introduction. > --- > xen/arch/riscv/include/asm/bug.h | 37

Re: [PATCH v8 1/6] xen/riscv: introduce temporary printk stuff

2023-08-11 Thread Alistair Francis
On Fri, Aug 11, 2023 at 10:33 AM Oleksii Kurochko wrote: > > The patch introdcuces printk related stuff which should be deleted > after Xen common code will be available. > > Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis Alistair > --- > Changes in V8: > - only rebase was done.

[PATCH] ns16550: add support for polling mode when device tree is used

2023-08-11 Thread Oleksii Kurochko
RISC-V doesn't support interrupts for the time being, so it would be nice to have polling mode. To force poll mode it was added parsing of new 'poll' property under "com1=" If there is no interrupt property in UART node, then polling will be used. According to 4.2.2 National Semiconductor 16450/1

Re: [PATCH v3 3/5] x86: allow Kconfig control over psABI level

2023-08-11 Thread Anthony PERARD
On Wed, Jul 26, 2023 at 12:34:15PM +0200, Jan Beulich wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -118,6 +118,36 @@ config HVM > > If unsure, say Y. > > +choice > + prompt "base psABI level" > + default X86_64_BASELINE > + help > + The psABI d

[libvirt test] 182264: trouble: broken/pass

2023-08-11 Thread osstest service owner
flight 182264 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/182264/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-vhd broken test-amd64-amd64-libvirt-

Re: [PATCH -next] xen-pciback: Remove unused function declarations

2023-08-11 Thread Juergen Gross
On 08.08.23 17:09, Yue Haibing wrote: Commit a92336a1176b ("xen/pciback: Drop two backends, squash and cleanup some code.") declared but never implemented these functions. Signed-off-by: Yue Haibing Reviewed-by: Juergen Gross Juergen OpenPGP_0xB0DE9DD628BF132F.asc Description: OpenPGP

Re: [PATCH] x86/xen: Make virt_to_pfn() a static inline

2023-08-11 Thread Juergen Gross
On 10.08.23 09:27, Linus Walleij wrote: Making virt_to_pfn() a static inline taking a strongly typed (const void *) makes the contract of a passing a pointer of that type to the function explicit and exposes any misuse of the macro virt_to_pfn() acting polymorphic and accepting many types such as

[PATCH v8 4/6] xen/riscv: introduce trap_init()

2023-08-11 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Reviewed-by: Alistair Francis --- Changes in V8: - nothing changed. only rebase was done. --- Changes in V7: - #define cast_to_bug_frame(addr) ((const struct bug_frame *)(addr)). - remove unnecessary comments in trap_init() function. --- Changes in V6: - trap_i

[PATCH v8 5/6] xen/riscv: implement do_bug_frame()

2023-08-11 Thread Oleksii Kurochko
The patch introduces the temporary implementation of do_bug_frame(). When common code is merged, CONFIG_GENERIC_BUG_FRAME should be used instead. Signed-off-by: Oleksii Kurochko --- Changes in V8: - remove Pointless initializer of id. - make bug_frames[] array constant. - remove cast_to_bug

[PATCH v8 3/6] xen/riscv: introduce decode_cause() stuff

2023-08-11 Thread Oleksii Kurochko
The patch introduces stuff needed to decode a reason of an exception. Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V8: - fix typo in return string from decode_reserved_interrupt_cause - add Acked-by: Alistair Francis --- Changes in V7: - Nothing changed. Only r

[PATCH v8 2/6] xen/riscv: introduce

2023-08-11 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko --- Changes in V8: - new patch. It was introduced instead of dummy asm/bug.h introduction. --- xen/arch/riscv/include/asm/bug.h | 37 1 file changed, 37 insertions(+) create mode 100644 xen/arch/riscv/include/asm/bug.h diff --git

[PATCH v8 6/6] xen/riscv: test basic handling stuff

2023-08-11 Thread Oleksii Kurochko
Signed-off-by: Oleksii Kurochko Acked-by: Alistair Francis --- Changes in V8: - Nothing changed. Only rebase. --- Changes in V6: - Nothing changed. Only rebase. --- Changes in V6: - Nothing changed --- Changes in V5: - Nothing changed --- Changes in V4: - Add Acked-by: Alistair Francis

[PATCH v8 0/6] RISCV basic exception handling implementation

2023-08-11 Thread Oleksii Kurochko
The patch series is based on: xen/riscv: introduce identity mapping [1] which haven't been merged yet. The patch series provides a basic implementation of exception handling. It can do only basic things such as decode a cause of an exception, save/restore registers and execute "wfi" instructio

[PATCH v8 1/6] xen/riscv: introduce temporary printk stuff

2023-08-11 Thread Oleksii Kurochko
The patch introdcuces printk related stuff which should be deleted after Xen common code will be available. Signed-off-by: Oleksii Kurochko --- Changes in V8: - only rebase was done. --- Changes in V7: - only rebase was done. --- Changes in V6: - the patch was introduced in the current patch s

Re: [PATCH] build: correct gas --noexecstack check

2023-08-11 Thread Anthony PERARD
On Wed, Jul 12, 2023 at 04:23:22PM +0200, Jan Beulich wrote: > The check was missing an escape for the inner $, thus breaking things > in the unlikely event that the underlying assembler doesn't support this > option. > > Fixes: 62d22296a95d ("build: silence GNU ld warning about executable stacks"

Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h

2023-08-11 Thread Julien Grall
Hi, On 11/08/2023 15:22, Luca Fancellu wrote: On 11 Aug 2023, at 15:13, Julien Grall wrote: On 11/08/2023 14:40, Luca Fancellu wrote: On 11 Aug 2023, at 13:56, Julien Grall wrote: Hi Luca, On 08/08/2023 09:00, Luca Fancellu wrote: Add asm/domain.h that is defining the type 'enum domain_typ

Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h

2023-08-11 Thread Luca Fancellu
> On 11 Aug 2023, at 15:13, Julien Grall wrote: > > Hi Luca, > > On 11/08/2023 14:40, Luca Fancellu wrote: >>> On 11 Aug 2023, at 13:56, Julien Grall wrote: >>> >>> Hi Luca, >>> >>> On 08/08/2023 09:00, Luca Fancellu wrote: Add asm/domain.h that is defining the type 'enum domain_type',

Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h

2023-08-11 Thread Julien Grall
Hi Luca, On 11/08/2023 14:40, Luca Fancellu wrote: On 11 Aug 2023, at 13:56, Julien Grall wrote: Hi Luca, On 08/08/2023 09:00, Luca Fancellu wrote: Add asm/domain.h that is defining the type 'enum domain_type', it is needed on arm64 build where this type is used for a member of the struct

[XEN PATCH 0/2] automation: avoid unnecessary analyses

2023-08-11 Thread Simone Ballarin
This series aims to reduce the analyses performed by the ECLAIR runner by avoiding some branches already excluded by other jobs and requiring analyses on people/.* to be manually triggered. Simone Ballarin (2): automation: avoid pipelines on specific branches automation/eclair: avoid unintenti

[XEN PATCH 2/2] automation/eclair: avoid unintentional ECLAIR analysis

2023-08-11 Thread Simone Ballarin
With this patch, ECLAIR jobs will need to be manually started for "people/.*" pipelines. This avoids occupying the runner on analyzes that might not be used by developers. If developers want to analyze their own repositories they need to launch them from GitLab. Signed-off-by: Simone Ballarin -

[XEN PATCH 1/2] automation: avoid pipelines on specific branches

2023-08-11 Thread Simone Ballarin
This patch avoids the execution of pipelines in the following branches: - master - smoke - coverirty-tested/.* - stable-.* The job-level exclusions have been removed as they are pointless with this new workspace-level exclusion. Signed-off-by: Simone Ballarin --- .gitlab-ci.yml | 6 ++ 1 fi

Re: [PATCH v3 1/5] build: make cc-option properly deal with unrecognized sub-options

2023-08-11 Thread Anthony PERARD
On Wed, Jul 26, 2023 at 12:33:07PM +0200, Jan Beulich wrote: > In options like -march=, it may be only the sub-option which is > unrecognized by the compiler. In such an event the error message often > splits option and argument, typically saying something like "bad value > '' for ''. Extend the gr

Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h

2023-08-11 Thread Luca Fancellu
> On 11 Aug 2023, at 13:56, Julien Grall wrote: > > Hi Luca, > > On 08/08/2023 09:00, Luca Fancellu wrote: >> Add asm/domain.h that is defining the type 'enum domain_type', it >> is needed on arm64 build where this type is used for a member of >> the structure kernel_info. > > I read "needed"

[qemu-mainline test] 182263: tolerable FAIL - PUSHED

2023-08-11 Thread osstest service owner
flight 182263 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/182263/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182242 test-armhf-armhf-libvirt-qcow2 15 s

Re: [PATCH 2/5] xen/arm: Add asm/domain.h include to kernel.h

2023-08-11 Thread Julien Grall
Hi Luca, On 08/08/2023 09:00, Luca Fancellu wrote: Add asm/domain.h that is defining the type 'enum domain_type', it is needed on arm64 build where this type is used for a member of the structure kernel_info. I read "needed" as in it Xen build is broken. But AFAIK, this is more a latent issue

Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle

2023-08-11 Thread Christoph Hellwig
Except for a mostly cosmetic nitpick this looks good to me: Acked-by: Christoph Hellwig That's not eactly the deep review I'd like to do, but as I'm about to head out for vacation that's probably as good as it gets.

[xen-unstable-smoke test] 182273: tolerable all pass - PUSHED

2023-08-11 Thread osstest service owner
flight 182273 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/182273/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v2 0/29] block: Make blkdev_get_by_*() return handle

2023-08-11 Thread Jan Kara
Hello, this is a v2 of the patch series which implements the idea of blkdev_get_by_*() calls returning bdev_handle which is then passed to blkdev_put() [1]. This makes the get and put calls for bdevs more obviously matching and allows us to propagate context from get to put without having to modif

[PATCH 07/29] xen/blkback: Convert to bdev_open_by_dev()

2023-08-11 Thread Jan Kara
Convert xen/blkback to use bdev_open_by_dev() and pass the handle around. CC: xen-devel@lists.xenproject.org Signed-off-by: Jan Kara --- drivers/block/xen-blkback/blkback.c | 4 +-- drivers/block/xen-blkback/common.h | 4 +-- drivers/block/xen-blkback/xenbus.c | 40 +++---

Re: [PATCH 2/2] tools/light: Revoke permissions when a PCI detach for HVM domain

2023-08-11 Thread Julien Grall
Hi Jason, On 10/08/2023 21:02, Jason Andryuk wrote: On Wed, Aug 9, 2023 at 6:34 AM Julien Grall wrote: From: Julien Grall Currently, libxl will grant IOMEM, I/O port and IRQ permissions when a PCI is attached (see pci_add_dm_done()) for all domain types. However, the permissions are only re

Re: [PATCH v7 2/6] xen/riscv: introduce dummy

2023-08-11 Thread Oleksii
On Mon, 2023-08-07 at 11:01 +0200, Jan Beulich wrote: > On 03.08.2023 14:05, Oleksii Kurochko wrote: > > will be used in the patch "xen/riscv: introduce > > decode_cause() stuff" and requires > > While as it stands the description is accurate, I don't think that > later > patch has a need to inc

[xen-unstable test] 182260: tolerable FAIL - PUSHED

2023-08-11 Thread osstest service owner
flight 182260 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/182260/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 182241 test-amd64-amd64-xl-qemut-win7-amd64

[XEN PATCH 2/6] x86/setup: add missing headers

2023-08-11 Thread Nicola Vetrini
The missing headers declare variables 'xen_cpuidle' and 'use_invpcid' that are then defined inside the file. This is undesirable and also violates MISRA C:2012 Rule 8.4. Adding suitable "#include"s resolves the issue. The type of the variable 'xen_cpuidle' also changes according to s/s8/int8_t/.

[XEN PATCH 4/6] cpufreq: add missing include of header 'pmstat.h'

2023-08-11 Thread Nicola Vetrini
The missing header included by this patch provides a declaration for 'set_px_pminfo' that is visible prior to the definition in this file. This also resolves a violation of MISRA C:2012 Rule 8.4. Signed-off-by: Nicola Vetrini Fixes: 452119c09420 ("x86 and ia64: move cpufreq notify code to commone

[XEN PATCH 0/6] xen: fix missing headers and static storage duration

2023-08-11 Thread Nicola Vetrini
The files touched by this series contain function or variable definitions with no prior declaration visible, because it's inside an header that is not included or it's not present anywhere. This is a risk in itself, but also violates MISRA C:2012 Rule 8.4, which states the following: "A compatible

[XEN PATCH 5/6] vpic/msix: make 'get_slot' static

2023-08-11 Thread Nicola Vetrini
The function can become static since it's used only within this file. This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence of a declaration before the function definition. Signed-off-by: Nicola Vetrini Fixes: b177892d2d0e ("vpci/msix: handle accesses adjacent to the MSI-X ta

[XEN PATCH 6/6] drivers/video: make declarations of defined functions available

2023-08-11 Thread Nicola Vetrini
The declarations for 'vesa_{init,early_init,endboot}' needed by 'xen/drivers/video/vesa.c' and 'fill_console_start_info' in 'vga.c' are now available by moving the relative code inside 'vga.h' and including "" respectively. This also resolves violations of MISRA C:2012 Rule 8.4. Signed-off-by: Nic

[XEN PATCH 3/6] x86/vm_event: add missing include

2023-08-11 Thread Nicola Vetrini
The missing header included by this patch provides declarations for the functions 'vm_event_{fill_regs,set_registers,monitor_next_interrupt}' that are defined in the source file. This also resolves violations of MISRA C:2012 Rule 8.4. Signed-off-by: Nicola Vetrini Fixes: adc75eba8b15 ("x86/vm_eve

[XEN PATCH 1/6] x86/hpet: make variable 'per_cpu__cpu_bc_channel' static

2023-08-11 Thread Nicola Vetrini
The variable is only ever used inside the file where it's defined, therefore it can have static storage. This also resolves a violation of MISRA C:2012 Rule 8.4 due to the absence of a declaration prior to the definition. Signed-off-by: Nicola Vetrini Fixes: 3ba523ff957c ("CPUIDLE: enable MSI cap

Re: [QEMU PATCH v4 0/1] S3 support

2023-08-11 Thread Chen, Jiqian
Hi all, Please forgive me for asking. Do you have any other comments on my latest version patches about virtio-gpu S3 on Xen? Looking forward to your reply. On 2023/7/20 20:08, Jiqian Chen wrote: > v4: > > Hi all, > Thanks for Gerd Hoffmann's advice. V4 makes below changes: > * Use enum for fre

[XEN PATCH] xen/hypercalls: address violations of MISRA C:2012 Rule 8.3

2023-08-11 Thread Federico Serafini
Uniform the auto-generated hypercall-decls with the corresponding definitions to address violations of MISRA C:2012 Rule 8.3: "All declarations of an object or function shall use the same names and type qualifiers". No functional change. Signed-off-by: Federico Serafini --- xen/include/hypercal