Re: xen cache colors in ARM

2023-04-18 Thread Oleg Nikitenko
Hello Stefano, Thanks for the clarification. My company uses yocto for image generation. What kind of information do you need to consult me in this case ? Maybe modules sizes/addresses which were mentioned by @Julien Grall ? Regards, Oleg вт, 18 апр. 2023 г. в 20:44, Stefano Stabellini : > On

Re: [xen-unstable test] 180296: regressions - FAIL

2023-04-18 Thread Jan Beulich
On 18.04.2023 19:53, osstest service owner wrote: > flight 180296 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/180296/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-armhf-armhf-examine11 e

[ovmf test] 180307: all pass - PUSHED

2023-04-18 Thread osstest service owner
flight 180307 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180307/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e3d2c08322bc61e9c5b87b3c282dd2af3d52aec6 baseline version: ovmf b16284e2a0011489f6e16

Re: [PATCH v3] x86/livepatch: Fix livepatch application when CET is active

2023-04-18 Thread Jan Beulich
On 18.04.2023 19:54, Andrew Cooper wrote: > On 18/04/2023 6:30 pm, Andrew Cooper wrote: >> On 18/04/2023 12:10 pm, Andrew Cooper wrote: >>> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c >>> index 36a07ef77eae..98529215ddec 100644 >>> @@ -5879,6 +5880,75 @@ int destroy_xen_mappings(unsigned lon

Re: [PATCH v5 07/12] xen: enable Dom0 to use SVE feature

2023-04-18 Thread Jan Beulich
On 18.04.2023 14:47, Bertrand Marquis wrote: >> On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >> @@ -118,3 +121,21 @@ void sve_restore_state(struct vcpu *v) >> >> sve_load_ctx(sve_ctx_zreg_end, v->arch.vfp.fpregs, 1); >> } >> + >> +int __init sve_sanitize_vl_param(int val, unsigned int *out)

Re: [PATCH v5 00/12] SVE feature for arm guests

2023-04-18 Thread Jan Beulich
On 18.04.2023 16:25, Julien Grall wrote: > On 18/04/2023 14:13, Bertrand Marquis wrote: >> On this serie I would like to open a discussion on how to handle the vector >> size >> and the corresponding command line / configuration / device tree parameters. >> >> In general the user must either give

Re: [PATCH] x86/livepatch: enable livepatching assembly source files

2023-04-18 Thread Jan Beulich
On 18.04.2023 15:06, Roger Pau Monné wrote: > On Tue, Apr 18, 2023 at 01:00:53PM +0200, Jan Beulich wrote: >> On 18.04.2023 11:24, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/include/asm/config.h >>> +++ b/xen/arch/x86/include/asm/config.h >>> @@ -44,6 +44,20 @@ >>> /* Linkage for x86 */ >>> #i

Re: [PATCH v2 0/2] deal with GOT stuff for RISC-V

2023-04-18 Thread Jan Beulich
On 18.04.2023 14:03, Oleksii wrote: > On Mon, 2023-04-17 at 16:12 +0200, Jan Beulich wrote: >> On 16.03.2023 14:22, Oleksii Kurochko wrote: >>> Oleksii Kurochko (2): >>>   xen/riscv: add EMBEDDED_EXTRA_CFLAGS to CFLAGS >>>   xen/riscv: add explicit check that .got{.plt} is empty >>> >>>  xen/arch/r

[xen-unstable test] 180301: regressions - FAIL

2023-04-18 Thread osstest service owner
flight 180301 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180301/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-livepatch 7 xen-install fail REGR. vs. 180287 test-armhf-armhf-e

RE: [PATCH] xen/vcpu: remove vcpu_set_singleshot_timer flags field

2023-04-18 Thread Henry Wang
Hi Roger, > -Original Message- > From: Roger Pau Monne > Subject: [PATCH] xen/vcpu: remove vcpu_set_singleshot_timer flags field > > The addition of the flags field in the vcpu_set_singleshot_timer in > 505ef3ea8687 is an ABI breakage, as the size of the structure is > increased. > > Re

Re: [PATCH v2 2/3] arm/alternatives: Rename alt_instr fields which are used in common code

2023-04-18 Thread Stefano Stabellini
On Mon, 17 Apr 2023, Andrew Cooper wrote: > Alternatives auditing for livepatches is currently broken. To fix it, the > livepatch code needs to inspect more fields of alt_instr. > > Rename ARM's fields to match x86's, because: > > * ARM already exposes alt_offset under the repl name via ALT_REP

[linux-linus test] 180299: regressions - FAIL

2023-04-18 Thread osstest service owner
flight 180299 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/180299/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 180278 Tests which are fai

[xen-unstable-smoke test] 180302: tolerable all pass - PUSHED

2023-04-18 Thread osstest service owner
flight 180302 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180302/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 01/33] s390: Use _pt_s390_gaddr for gmap address tracking

2023-04-18 Thread Vishal Moola
On Tue, Apr 18, 2023 at 8:45 AM David Hildenbrand wrote: > > On 17.04.23 22:50, Vishal Moola (Oracle) wrote: > > s390 uses page->index to keep track of page tables for the guest address > > space. In an attempt to consolidate the usage of page fields in s390, > > replace _pt_pad_2 with _pt_s390_ga

Re: [patch 00/37] cpu/hotplug, x86: Reworked parallel CPU bringup

2023-04-18 Thread Paul Menzel
Dear Thomas, Am 18.04.23 um 10:40 schrieb Thomas Gleixner: On Tue, Apr 18 2023 at 08:58, Thomas Gleixner wrote: On Mon, Apr 17 2023 at 19:40, Paul Menzel wrote: Am 17.04.23 um 16:48 schrieb Thomas Gleixner: On Mon, Apr 17 2023 at 13:19, Paul Menzel wrote: Am 15.04.23 um 01:44 schrieb Thoma

Re: [PATCH v3] x86/livepatch: Fix livepatch application when CET is active

2023-04-18 Thread Andrew Cooper
On 18/04/2023 6:30 pm, Andrew Cooper wrote: > On 18/04/2023 12:10 pm, Andrew Cooper wrote: >> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c >> index 36a07ef77eae..98529215ddec 100644 >> @@ -5879,6 +5880,75 @@ int destroy_xen_mappings(unsigned long s, unsigned >> long e) >> return modify_

[xen-unstable test] 180296: regressions - FAIL

2023-04-18 Thread osstest service owner
flight 180296 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/180296/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-examine11 examine-serial/bootloader fail REGR. vs. 180287 test-armhf-armhf-e

Re: xen cache colors in ARM

2023-04-18 Thread Stefano Stabellini
On Tue, 18 Apr 2023, Oleg Nikitenko wrote: > Hi Julien, > > >> This feature has not been merged in Xen upstream yet > > > would assume that upstream + the series on the ML [1] work > > Please clarify this point. > Because the two thoughts are controversial. Hi Oleg, As Julien wrote, there is n

Re: [PATCH v3] x86/livepatch: Fix livepatch application when CET is active

2023-04-18 Thread Andrew Cooper
On 18/04/2023 12:10 pm, Andrew Cooper wrote: > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index 36a07ef77eae..98529215ddec 100644 > @@ -5879,6 +5880,75 @@ int destroy_xen_mappings(unsigned long s, unsigned > long e) > return modify_xen_mappings(s, e, _PAGE_NONE); > } > > +/* > +

Re: [PATCH v2 3/3] xen/livepatch: Fix .altinstructions safety checks

2023-04-18 Thread Ross Lagerwall
> From: Andrew Cooper > Sent: Monday, April 17, 2023 1:13 PM > To: Xen-devel > Cc: Andrew Cooper ; Konrad Rzeszutek Wilk > ; Ross Lagerwall > Subject: [PATCH v2 3/3] xen/livepatch: Fix .altinstructions safety checks >   > The prior check has && vs || mixups, making it tautologically false and

Re: [PATCH v2 1/3] xen/ELF: Fix ELF32 PRI formatters

2023-04-18 Thread Ross Lagerwall
> From: Andrew Cooper > Sent: Monday, April 17, 2023 2:47 PM > To: Jan Beulich ; Xen-devel > > Cc: Konrad Rzeszutek Wilk ; Ross Lagerwall > ; Stefano Stabellini ; > Julien Grall ; Volodymyr Babchuk > ; Bertrand Marquis ; > Roger Pau Monne ; Wei Liu > Subject: Re: [PATCH v2 1/3] xen/ELF: Fix

Re: [PATCH] xen/vcpu: remove vcpu_set_singleshot_timer flags field

2023-04-18 Thread Andrew Cooper
On 18/04/2023 5:02 pm, Roger Pau Monné wrote: > On Tue, Apr 18, 2023 at 04:54:49PM +0100, Andrew Cooper wrote: >> On 18/04/2023 4:42 pm, Roger Pau Monne wrote: >>> The addition of the flags field in the vcpu_set_singleshot_timer in >>> 505ef3ea8687 is an ABI breakage, as the size of the structure i

Re: [PATCH] xen/vcpu: remove vcpu_set_singleshot_timer flags field

2023-04-18 Thread Roger Pau Monné
On Tue, Apr 18, 2023 at 04:54:49PM +0100, Andrew Cooper wrote: > On 18/04/2023 4:42 pm, Roger Pau Monne wrote: > > The addition of the flags field in the vcpu_set_singleshot_timer in > > 505ef3ea8687 is an ABI breakage, as the size of the structure is > > increased. > > > > Remove such field additi

Re: [PATCH] xen/vcpu: remove vcpu_set_singleshot_timer flags field

2023-04-18 Thread Andrew Cooper
On 18/04/2023 4:42 pm, Roger Pau Monne wrote: > The addition of the flags field in the vcpu_set_singleshot_timer in > 505ef3ea8687 is an ABI breakage, as the size of the structure is > increased. > > Remove such field addition and drop the implementation of the > VCPU_SSHOTTMR_future flag. If a ti

Re: [PATCH 01/33] s390: Use _pt_s390_gaddr for gmap address tracking

2023-04-18 Thread David Hildenbrand
On 17.04.23 22:50, Vishal Moola (Oracle) wrote: s390 uses page->index to keep track of page tables for the guest address space. In an attempt to consolidate the usage of page fields in s390, replace _pt_pad_2 with _pt_s390_gaddr to replace page->index in gmap. This will help with the splitting o

[PATCH] xen/vcpu: remove vcpu_set_singleshot_timer flags field

2023-04-18 Thread Roger Pau Monne
The addition of the flags field in the vcpu_set_singleshot_timer in 505ef3ea8687 is an ABI breakage, as the size of the structure is increased. Remove such field addition and drop the implementation of the VCPU_SSHOTTMR_future flag. If a timer provides an expired timeout value just inject the tim

Re: [PATCH] xen/livepatch: Fix secure_payload() in non-debug builds

2023-04-18 Thread Ross Lagerwall
> From: Jan Beulich > Sent: Monday, April 17, 2023 11:41 AM > To: Andrew Cooper > Cc: Konrad Rzeszutek Wilk ; Ross Lagerwall > ; Xen-devel > Subject: Re: [PATCH] xen/livepatch: Fix secure_payload() in non-debug builds >   > On 17.04.2023 11:58, Andrew Cooper wrote: > > The ro_pages + rw_pages

Re: [PATCH v3] x86/livepatch: Fix livepatch application when CET is active

2023-04-18 Thread Ross Lagerwall
> From: Andrew Cooper > Sent: Tuesday, April 18, 2023 12:10 PM > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Jan Beulich ; Roger Pau Monne > ; Wei Liu ; Konrad Rzeszutek Wilk > ; Ross Lagerwall > Subject: [PATCH v3] x86/livepatch: Fix livepatch application when CET is > active >   >

Re: [PATCH v5 00/12] SVE feature for arm guests

2023-04-18 Thread Bertrand Marquis
Hi Luca, > On 18 Apr 2023, at 16:41, Luca Fancellu wrote: > > > >> On 18 Apr 2023, at 15:38, Bertrand Marquis wrote: >> >> Hi Julien, >> >>> On 18 Apr 2023, at 16:25, Julien Grall wrote: >>> >>> >>> >>> On 18/04/2023 14:13, Bertrand Marquis wrote: Hi Luca, >>> >>> Hi, >>> On

[PATCH v2] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes

2023-04-18 Thread Roger Pau Monne
Note in the changelog that the purpose of gnttab_max_{maptrack_,}frames command line options has been changed. Fixes: b2ea81d2b935 ('xen/grants: repurpose command line max options') Signed-off-by: Roger Pau Monné Acked-by: Henry Wang --- Changes since v1: - Introduce and move to 'Changed' secti

Re: [PATCH v5 00/12] SVE feature for arm guests

2023-04-18 Thread Luca Fancellu
> On 18 Apr 2023, at 15:38, Bertrand Marquis wrote: > > Hi Julien, > >> On 18 Apr 2023, at 16:25, Julien Grall wrote: >> >> >> >> On 18/04/2023 14:13, Bertrand Marquis wrote: >>> Hi Luca, >> >> Hi, >> >>> On this serie I would like to open a discussion on how to handle the vector >>> s

Re: [PATCH v5 00/12] SVE feature for arm guests

2023-04-18 Thread Bertrand Marquis
Hi Julien, > On 18 Apr 2023, at 16:25, Julien Grall wrote: > > > > On 18/04/2023 14:13, Bertrand Marquis wrote: >> Hi Luca, > > Hi, > >> On this serie I would like to open a discussion on how to handle the vector >> size >> and the corresponding command line / configuration / device tree pa

Re: [PATCH v5 00/12] SVE feature for arm guests

2023-04-18 Thread Julien Grall
On 18/04/2023 14:13, Bertrand Marquis wrote: Hi Luca, Hi, On this serie I would like to open a discussion on how to handle the vector size and the corresponding command line / configuration / device tree parameters. In general the user must either give a vector size it wants or has a solu

Re: [PATCH] x86/livepatch: enable livepatching assembly source files

2023-04-18 Thread Roger Pau Monné
On Tue, Apr 18, 2023 at 01:17:55PM +0100, Andrew Cooper wrote: > On 18/04/2023 10:24 am, Roger Pau Monne wrote: > > > diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S > > index 7675a59ff057..c204634910c4 100644 > > --- a/xen/arch/x86/x86_64/entry.S > > +++ b/xen/arch/x86/x86_

Re: [PATCH v7 2/5] xen/arm64: Rework the memory layout

2023-04-18 Thread Bertrand Marquis
> On 18 Apr 2023, at 15:53, Bertrand Marquis wrote: > > Hi Julien, > >> On 16 Apr 2023, at 16:32, Julien Grall wrote: >> >> From: Julien Grall >> >> Xen is currently not fully compliant with the Arm Arm because it will >> switch the TTBR with the MMU on. >> >> In order to be compliant, w

Re: [PATCH v7 3/5] xen/arm64: mm: Introduce helpers to prepare/enable/disable the identity mapping

2023-04-18 Thread Bertrand Marquis
Hi Julien, > On 16 Apr 2023, at 16:32, Julien Grall wrote: > > From: Julien Grall > > In follow-up patches we will need to have part of Xen identity mapped in > order to safely switch the TTBR. > > On some platform, the identity mapping may have to start at 0. If we always > keep the identity

Re: [PATCH v7 2/5] xen/arm64: Rework the memory layout

2023-04-18 Thread Bertrand Marquis
Hi Julien, > On 16 Apr 2023, at 16:32, Julien Grall wrote: > > From: Julien Grall > > Xen is currently not fully compliant with the Arm Arm because it will > switch the TTBR with the MMU on. > > In order to be compliant, we need to disable the MMU before > switching the TTBR. The implication

[libvirt test] 180293: tolerable all pass - PUSHED

2023-04-18 Thread osstest service owner
flight 180293 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/180293/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 180272 test-armhf-armhf-libvirt-raw 15 saveresto

Re: [PATCH] create-diff-object: handle missing padding at end of special section

2023-04-18 Thread Ross Lagerwall
> From: Roger Pau Monne > Sent: Friday, April 14, 2023 4:19 PM > To: xen-devel@lists.xenproject.org > Cc: Josh Poimboeuf ; Roger Pau Monne > ; Konrad Rzeszutek Wilk ; Ross > Lagerwall > Subject: [PATCH] create-diff-object: handle missing padding at end of special > section >   > From: Josh P

Re: [PATCH v7 1/5] xen/arm32: head: Widen the use of the temporary mapping

2023-04-18 Thread Bertrand Marquis
Hi Julien, > On 16 Apr 2023, at 16:32, Julien Grall wrote: > > From: Julien Grall > > At the moment, the temporary mapping is only used when the virtual > runtime region of Xen is clashing with the physical region. > > In follow-up patches, we will rework how secondary CPU bring-up works > an

Re: [PATCH v5 11/12] xen/arm: add sve property for dom0less domUs

2023-04-18 Thread Bertrand Marquis
Hi, > On 18 Apr 2023, at 14:55, Bertrand Marquis wrote: > > Hi Luca, > >> On 12 Apr 2023, at 11:49, Luca Fancellu wrote: >> >> Add a device tree property in the dom0less domU configuration >> to enable the guest to use SVE. >> >> Update documentation. >> >> Signed-off-by: Luca Fancellu > R

RE: [PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes

2023-04-18 Thread Henry Wang
Hi Roger, > -Original Message- > From: Roger Pau Monne > Subject: [PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option > changes > > Note in the changelog that the purpose of > gnttab_max_{maptrack_,}frames command line options has been changed. Thanks for remembering this! > >

[linux-linus test] 180292: regressions - FAIL

2023-04-18 Thread osstest service owner
flight 180292 linux-linus real [real] flight 180298 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/180292/ http://logs.test-lab.xenproject.org/osstest/logs/180298/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run

Re: [PATCH v5 00/12] SVE feature for arm guests

2023-04-18 Thread Bertrand Marquis
Hi Luca, On this serie I would like to open a discussion on how to handle the vector size and the corresponding command line / configuration / device tree parameters. In general the user must either give a vector size it wants or has a solution to just request the maximum supported size. In the

Re: [PATCH] x86/livepatch: enable livepatching assembly source files

2023-04-18 Thread Roger Pau Monné
On Tue, Apr 18, 2023 at 01:00:53PM +0200, Jan Beulich wrote: > On 18.04.2023 11:24, Roger Pau Monne wrote: > > Some of the assembly entry points cannot be safely patched until it's > > safe to use jmp, as livepatch can replace a whole block with a jmp to > > a new address, and that won't be safe un

Re: [PATCH v5 12/12] xen/changelog: Add SVE and "dom0" options to the changelog for Arm

2023-04-18 Thread Bertrand Marquis
Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: > > Arm now can use the "dom0=" Xen command line option and the support > for guests running SVE instructions is added, put entries in the > changelog. > > Signed-off-by: Luca Fancellu > --- > Changes from v4: > - No changes > Change fr

Re: [PATCH v5 11/12] xen/arm: add sve property for dom0less domUs

2023-04-18 Thread Bertrand Marquis
Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: > > Add a device tree property in the dom0less domU configuration > to enable the guest to use SVE. > > Update documentation. > > Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Changes from v4: >

Re: [PATCH] x86/livepatch: enable livepatching assembly source files

2023-04-18 Thread Andrew Cooper
On 18/04/2023 12:00 pm, Jan Beulich wrote: > On 18.04.2023 11:24, Roger Pau Monne wrote: >> Some of the assembly entry points cannot be safely patched until it's >> safe to use jmp, as livepatch can replace a whole block with a jmp to >> a new address, and that won't be safe until speculative mitig

Re: [PATCH v5 08/12] xen/physinfo: encode Arm SVE vector length in arch_capabilities

2023-04-18 Thread Bertrand Marquis
Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: > > When the arm platform supports SVE, advertise the feature in the > field arch_capabilities in struct xen_sysctl_physinfo by encoding > the SVE vector length in it. > > Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Che

[PATCH] CHANGELOG: add gnttab_max_{maptrack_,}frames option changes

2023-04-18 Thread Roger Pau Monne
Note in the changelog that the purpose of gnttab_max_{maptrack_,}frames command line options has been changed. Fixes: b2ea81d2b935 ('xen/grants: repurpose command line max options') Signed-off-by: Roger Pau Monné --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md

Re: [PATCH v5 07/12] xen: enable Dom0 to use SVE feature

2023-04-18 Thread Bertrand Marquis
Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: > > Add a command line parameter to allow Dom0 the use of SVE resources, > the command line parameter sve=, sub argument of dom0=, > controls the feature on this domain and sets the maximum SVE vector > length for Dom0. > > Add a new fun

Re: [PATCH v5 05/12] arm/sve: save/restore SVE context switch

2023-04-18 Thread Bertrand Marquis
Hi Luca, > On 12 Apr 2023, at 11:49, Luca Fancellu wrote: > > Save/restore context switch for SVE, allocate memory to contain > the Z0-31 registers whose length is maximum 2048 bits each and > FFR who can be maximum 256 bits, the allocated memory depends on > how many bits is the vector length f

Re: [PATCH] x86/livepatch: enable livepatching assembly source files

2023-04-18 Thread Andrew Cooper
On 18/04/2023 10:24 am, Roger Pau Monne wrote: > diff --git a/xen/arch/x86/x86_64/entry.S b/xen/arch/x86/x86_64/entry.S > index 7675a59ff057..c204634910c4 100644 > --- a/xen/arch/x86/x86_64/entry.S > +++ b/xen/arch/x86/x86_64/entry.S > @@ -660,7 +660,7 @@ ENTRY(early_page_fault) > > ALI

Fwd: xen cache colors in ARM

2023-04-18 Thread Oleg Nikitenko
-- Forwarded message - От: Oleg Nikitenko Date: вт, 18 апр. 2023 г. в 15:05 Subject: Re: xen cache colors in ARM To: Julien Grall Hi Julien, We are speaking differently. You have applied your own terminology. I applied on my own. So we did not catch each other. I should downlo

Re: [PATCH v2 0/2] deal with GOT stuff for RISC-V

2023-04-18 Thread Oleksii
On Mon, 2023-04-17 at 16:12 +0200, Jan Beulich wrote: > On 16.03.2023 14:22, Oleksii Kurochko wrote: > > Oleksii Kurochko (2): > >   xen/riscv: add EMBEDDED_EXTRA_CFLAGS to CFLAGS > >   xen/riscv: add explicit check that .got{.plt} is empty > > > >  xen/arch/riscv/arch.mk   |  2 ++ > >  xen/arch/r

Re: [PATCH v6] x86: detect CMOS aliasing on ports other than 0x70/0x71

2023-04-18 Thread Roger Pau Monné
On Tue, Apr 18, 2023 at 11:24:19AM +0200, Jan Beulich wrote: > ... in order to also intercept Dom0 accesses through the alias ports. > > Also stop intercepting accesses to the CMOS ports if we won't ourselves > use the CMOS RTC, because of there being none. > > Note that rtc_init() deliberately u

Re: xen cache colors in ARM

2023-04-18 Thread Julien Grall
On 18/04/2023 12:26, Oleg Nikitenko wrote: Hi Julien, Hi Oleg, This feature has not been merged in Xen upstream yet would assume that upstream + the series on the ML [1] work Please clarify this point. Because the two thoughts are controversial. It is not clear to me how what I wr

Re: xen cache colors in ARM

2023-04-18 Thread Oleg Nikitenko
Hi Julien, >> This feature has not been merged in Xen upstream yet > would assume that upstream + the series on the ML [1] work Please clarify this point. Because the two thoughts are controversial. Regards, Oleg вт, 18 апр. 2023 г. в 14:09, Julien Grall : > Hi, > > I have added back xen-deve

[PATCH v3] x86/livepatch: Fix livepatch application when CET is active

2023-04-18 Thread Andrew Cooper
Right now, trying to apply a livepatch on any system with CET shstk (AMD Zen3 or later, Intel Tiger Lake or Sapphire Rapids and later) fails as follows: (XEN) livepatch: lp: Verifying enabled expectations for all functions (XEN) common/livepatch.c:1591: livepatch: lp: timeout is 3000ns (

Re: xen cache colors in ARM

2023-04-18 Thread Julien Grall
Hi, I have added back xen-devel and the others. Please reply to all, so they can have the full conversation. On 18/04/2023 11:13, Oleg Nikitenko wrote: HW Board: Xilinx ZynqMP Where are the banks located? Where are the banks located? I did not catch this question. Could you rephrase it

Re: [PATCH] x86/livepatch: enable livepatching assembly source files

2023-04-18 Thread Jan Beulich
On 18.04.2023 11:24, Roger Pau Monne wrote: > Some of the assembly entry points cannot be safely patched until it's > safe to use jmp, as livepatch can replace a whole block with a jmp to > a new address, and that won't be safe until speculative mitigations > have been applied. Isn't the issue onl

Re: [PATCH] x86: cpu{id,}_policy_updated() can be static

2023-04-18 Thread Andrew Cooper
On 18/04/2023 11:22 am, Jan Beulich wrote: > On 18.04.2023 11:42, Roger Pau Monné wrote: >> On Tue, Apr 18, 2023 at 11:35:41AM +0200, Jan Beulich wrote: >>> The function merely needs moving earlier in the file to avoid the need >>> for a forward declaration. While moving it, also rename it followin

[PATCH] SVM: svm_get_insn_len() improvements

2023-04-18 Thread Jan Beulich
Don't let x86_decode_insn() failing go silently. Check hardware provided value (if sensible) against decoder provided one. Also use it as return value on the error path - there's no real reason to inject #GP if we have a presumably good value in hands. Check that, when no ModR/M byte is expected,

Re: [PATCH] x86: cpu{id,}_policy_updated() can be static

2023-04-18 Thread Jan Beulich
On 18.04.2023 11:42, Roger Pau Monné wrote: > On Tue, Apr 18, 2023 at 11:35:41AM +0200, Jan Beulich wrote: >> The function merely needs moving earlier in the file to avoid the need >> for a forward declaration. While moving it, also rename it following the >> recent folding of CPUID and MSR policie

Re: [PATCH] x86: fix build with old gcc after CPU policy changes

2023-04-18 Thread Andrew Cooper
On 18/04/2023 11:15 am, Jan Beulich wrote: > Old gcc won't cope with initializers involving unnamed struct/union > fields. > > Fixes: 441b1b2a50ea ("x86/emul: Switch x86_emulate_ctxt to cpu_policy") > Signed-off-by: Jan Beulich Urgh.  Acked-by: Andrew Cooper I guess, but I'd honestly far rather

[PATCH] x86: fix build with old gcc after CPU policy changes

2023-04-18 Thread Jan Beulich
Old gcc won't cope with initializers involving unnamed struct/union fields. Fixes: 441b1b2a50ea ("x86/emul: Switch x86_emulate_ctxt to cpu_policy") Signed-off-by: Jan Beulich --- a/tools/fuzz/x86_instruction_emulator/fuzz-emul.c +++ b/tools/fuzz/x86_instruction_emulator/fuzz-emul.c @@ -893,12 +8

Re: [PATCH] tests/cpu-policy: fix "run" goal

2023-04-18 Thread Roger Pau Monné
On Tue, Apr 18, 2023 at 11:38:48AM +0200, Jan Beulich wrote: > On 18.04.2023 11:30, Roger Pau Monné wrote: > > On Tue, Apr 18, 2023 at 11:01:56AM +0200, Jan Beulich wrote: > >> An earlier change converted TARGET-y to TARGETS, but failed to replace > >> all references. Convert run's dependency, but

Re: [PATCH] x86: cpu{id,}_policy_updated() can be static

2023-04-18 Thread Roger Pau Monné
On Tue, Apr 18, 2023 at 11:35:41AM +0200, Jan Beulich wrote: > The function merely needs moving earlier in the file to avoid the need > for a forward declaration. While moving it, also rename it following the > recent folding of CPUID and MSR policies. > > Signed-off-by: Jan Beulich Acked-by: Ro

Re: [PATCH] tests/cpu-policy: fix "run" goal

2023-04-18 Thread Jan Beulich
On 18.04.2023 11:30, Roger Pau Monné wrote: > On Tue, Apr 18, 2023 at 11:01:56AM +0200, Jan Beulich wrote: >> An earlier change converted TARGET-y to TARGETS, but failed to replace >> all references. Convert run's dependency, but use $< in the command to >> avoid the leading blank that += inserts.

[PATCH] x86: cpu{id,}_policy_updated() can be static

2023-04-18 Thread Jan Beulich
The function merely needs moving earlier in the file to avoid the need for a forward declaration. While moving it, also rename it following the recent folding of CPUID and MSR policies. Signed-off-by: Jan Beulich --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -288,6 +288,16 @@ void u

[xen-unstable-smoke test] 180297: tolerable all pass - PUSHED

2023-04-18 Thread osstest service owner
flight 180297 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/180297/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] tests/cpu-policy: fix "run" goal

2023-04-18 Thread Roger Pau Monné
On Tue, Apr 18, 2023 at 11:01:56AM +0200, Jan Beulich wrote: > An earlier change converted TARGET-y to TARGETS, but failed to replace > all references. Convert run's dependency, but use $< in the command to > avoid the leading blank that += inserts. > > Fixes: 6a9f5477637a ("tests/cpu-policy: Rewo

[PATCH] x86/livepatch: enable livepatching assembly source files

2023-04-18 Thread Roger Pau Monne
In order to be able to livepatch code from assembly files we need: * Proper function symbols from assembly code, including the size. * Separate sections for each function. However assembly code doesn't really have the concept of a function, and hence the code tends to chain different labels tha

[PATCH v6] x86: detect CMOS aliasing on ports other than 0x70/0x71

2023-04-18 Thread Jan Beulich
... in order to also intercept Dom0 accesses through the alias ports. Also stop intercepting accesses to the CMOS ports if we won't ourselves use the CMOS RTC, because of there being none. Note that rtc_init() deliberately uses 16 as the upper loop bound, despite probe_cmos_alias() using 8: The h

Re: [XEN][PATCH v5 14/17] xen/arm: Implement device tree node addition functionalities

2023-04-18 Thread Michal Orzel
Hi Vikram, On 11/04/2023 21:16, Vikram Garhwal wrote: > > > Update sysctl XEN_SYSCTL_dt_overlay to enable support for dtbo nodes addition > using device tree overlay. > > xl dt-overlay add file.dtbo: > Each time overlay nodes are added using .dtbo, a new fdt(memcpy of > device_tree_flat

[PATCH] tests/cpu-policy: fix "run" goal

2023-04-18 Thread Jan Beulich
An earlier change converted TARGET-y to TARGETS, but failed to replace all references. Convert run's dependency, but use $< in the command to avoid the leading blank that += inserts. Fixes: 6a9f5477637a ("tests/cpu-policy: Rework Makefile") Signed-off-by: Jan Beulich --- a/tools/tests/cpu-policy

Re: xen cache colors in ARM

2023-04-18 Thread Julien Grall
+Stefano, + Bertrand, +Carlo, On 18/04/2023 09:43, Oleg Nikitenko wrote: Hello, Hi, I tried to turn on this scheme and ran into panic. Where was I wrong ? This feature has not been merged in Xen upstream yet. So can you tell us what patches did you apply or which tree? Xen command lin

Re: [patch 00/37] cpu/hotplug, x86: Reworked parallel CPU bringup

2023-04-18 Thread Thomas Gleixner
On Tue, Apr 18 2023 at 08:58, Thomas Gleixner wrote: > On Mon, Apr 17 2023 at 19:40, Paul Menzel wrote: >> Am 17.04.23 um 16:48 schrieb Thomas Gleixner: >> >>> On Mon, Apr 17 2023 at 13:19, Paul Menzel wrote: Am 15.04.23 um 01:44 schrieb Thomas Gleixner: [0.258193] smpboot: CPU0: AMD

xen cache colors in ARM

2023-04-18 Thread Oleg Nikitenko
Hello, I tried to turn on this scheme and ran into panic. Where was I wrong ? Xen command line xen,xen-bootargs = "console=dtuart dtuart=serial0 dom0_mem=1600M dom0_max_vcpus=2 dom0_vcpus_pin bootscrub=0 vwfi=native sched=null timer_slop=0 way_szize=65536 xen_colors=0-3 dom0_colors=4-7"; Xen con

Re: [PATCH v2] x86/livepatch: Fix livepatch application when CET is active

2023-04-18 Thread Andrew Cooper
On 18/04/2023 6:58 am, Jan Beulich wrote: > On 17.04.2023 21:34, Andrew Cooper wrote: >> On 17/04/2023 3:51 pm, Jan Beulich wrote: >>> On 17.04.2023 16:41, Andrew Cooper wrote: On 17/04/2023 2:59 pm, Jan Beulich wrote: > On 17.04.2023 15:52, Andrew Cooper wrote: >> @@ -5879,6 +5880,73

[ovmf test] 180295: all pass - PUSHED

2023-04-18 Thread osstest service owner
flight 180295 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/180295/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b16284e2a0011489f6e16dfcc6af7623c3cbaf0b baseline version: ovmf 6ded9f50c3aa123fe581c