Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

On 15.03.2023 05:14, Huang Rui wrote: > On Wed, Mar 15, 2023 at 08:52:30AM +0800, Stefano Stabellini wrote: >> On Mon, 13 Mar 2023, Jan Beulich wrote: >>> On 12.03.2023 13:01, Huang Rui wrote: Xen PVH is the paravirtualized mode and takes advantage of hardware virtualization support when

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

On 15.03.2023 01:52, Stefano Stabellini wrote: > On Mon, 13 Mar 2023, Jan Beulich wrote: >> On 12.03.2023 13:01, Huang Rui wrote: >>> Xen PVH is the paravirtualized mode and takes advantage of hardware >>> virtualization support when possible. It will using the hardware IOMMU >>> support instead of

Re: [PATCH V3 0/2] qemu: vhost-user: Support Xen memory mapping quirks

On 09-03-23, 14:20, Viresh Kumar wrote: > Hello, > > This patchset tries to update the vhost-user protocol to make it support > special > memory mapping required in case of Xen hypervisor. > > The first patch is mostly cleanup and second one introduces a new xen specific > feature. > > V2->V3:

[PATCH v3 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c

This patch provides accessor functions as replacements for direct access to slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h which advises that data structures for PCIBus should not be directly accessed but instead be accessed using accessor functions in pci.h. Th

[PATCH v3 0/2] pci: slot_reserved_mask improvements

This patch series consists of two patches. The first provides accessor functions in pci.h to avoid direct access of slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h. No functional change is intended with this patch. The second patch replaces slot_reserved_mask wit

[PATCH v3 2/2] pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask

Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") uses slot_reserved_mask to reserve slot 2 for the Intel igd for the xenfv machine when the guest is configured for igd-passthru. Prior to that commit, a single 32-bit mask was sufficient to meet the needs of the only machine

[linux-linus test] 179627: regressions - trouble: fail/pass/starved

flight 179627 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179627/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 178042 test-amd64-amd64-pa

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

On Wed, Mar 15, 2023 at 08:52:30AM +0800, Stefano Stabellini wrote: > On Mon, 13 Mar 2023, Jan Beulich wrote: > > On 12.03.2023 13:01, Huang Rui wrote: > > > Xen PVH is the paravirtualized mode and takes advantage of hardware > > > virtualization support when possible. It will using the hardware IO

[xen-unstable-smoke test] 179636: tolerable trouble: pass/starved - PUSHED

flight 179636 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/179636/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

RE: [PATCH 0/7] tools: More Python 3 fixes (part 1 of N)

Hi Andrew, > -Original Message- > From: Andrew Cooper > Subject: [PATCH 0/7] tools: More Python 3 fixes (part 1 of N) > > Relatedly, and a critical/blocker for Xen 4.18. Python 3.12, which will be > released ahead of the Xen 4.18 release, is deleteing distutils (recommending > setuputil

Best way to use altp2m to support VMFUNC EPT-switching?

Hi all, I'm looking for some pointers on how Xen's altp2m system works and how it's meant to be used with Intel's VMFUNC EPT-switching for secure isolation within an HVM/PVH guest's kernelspace. Specifically, I am attempting to modify Xen to create (on request by an already-booted, cooperative

Re: [RFC PATCH 1/5] x86/xen: disable swiotlb for xen pvh

On Mon, 13 Mar 2023, Jan Beulich wrote: > On 12.03.2023 13:01, Huang Rui wrote: > > Xen PVH is the paravirtualized mode and takes advantage of hardware > > virtualization support when possible. It will using the hardware IOMMU > > support instead of xen-swiotlb, so disable swiotlb if current domain

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

On Mon, 13 Mar 2023, Christian König wrote: > Am 13.03.23 um 08:23 schrieb Christian König: > > Am 12.03.23 um 08:54 schrieb Huang Rui: > > > From: Chen Jiqian > > > > > > When dom0 is PVH and we want to passthrough gpu to guest, > > > we should allow BAR writes even through BAR is mapped. If > >

[xen-unstable test] 179621: tolerable trouble: fail/pass/starved

flight 179621 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/179621/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail in 179604 pass in 179621 test-amd64-i3

[PATCH v3 2/6] xen: pci: introduce reference counting for pdev

Prior to this change, lifetime of pci_dev objects was protected by global pcidevs_lock(). Long-term plan is to remove this log, so we need some other mechanism to ensure that those objects will not disappear under feet of code that access them. Reference counting is a good choice as it provides eas

[PATCH v3 0/6] vpci: first series in preparation for vpci on ARM

This patch set is spiritual successor of "[PATCH v2 0/4] vpci: first series in preparation for vpci on ARM". But most of the contents was reworked. Main aim of those patches is to allow vPCI MMIO handlers to work with DomUs, not only with Dom0. To do this, we need protect pdev from being removed wh

[PATCH v3 1/6] xen: add reference counter support

We can use reference counter to ease up object lifetime management. This patch adds very basic support for reference counters. refcnt should be used in the following way: 1. Protected structure should have refcnt_t field 2. This field should be initialized with refcnt_init() during object constru

[PATCH v3 6/6] xen: pci: print reference counter when dumping pci_devs

This can be handy during new reference counter approach evaluation. Signed-off-by: Volodymyr Babchuk --- v3: - Moved from another patch series --- xen/drivers/passthrough/pci.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/pa

[PATCH v3 4/6] vpci: restrict unhandled read/write operations for guests

From: Oleksandr Andrushchenko A guest would be able to read and write those registers which are not emulated and have no respective vPCI handlers, so it will be possible for it to access the hardware directly. In order to prevent a guest from reads and writes from/to the unhandled registers make

[PATCH v3 3/6] vpci: crash domain if we wasn't able to (un) map vPCI regions

In that unlikely case, when map_range() fails to do it's job, domain memory mapping will be left in inconsistent state. As there is no easy way to remove stale p2m mapping we need to crash domain, as FIXME suggests. Signed-off-by: Volodymyr Babchuk --- v3: - new patch --- xen/drivers/vpci/hea

[PATCH v3 5/6] vpci: use reference counter to protect vpci state

vPCI MMIO handlers are accessing pdevs without protecting this access with pcidevs_{lock|unlock}. This is not a problem as of now as these are only used by Dom0. But, towards vPCI is used also for guests, we need to properly protect pdev and pdev->vpci from being removed while still in use. For th

Re: [PATCH v1] xen/riscv: make calculation of stack address PC-relative

On Tue, 2023-03-14 at 17:09 +, Andrew Cooper wrote: > On 14/03/2023 4:00 pm, Oleksii Kurochko wrote: > > The patch is needed to keep all addresses PC-relative. > > > > Pseudoinstruction 'la' can be transformed to 'auipc/addi' or > > 'auipc/l{w|d}'. It depends on the .option directive: nopic an

[PATCH v5 1/4] PCI: Introduce pci_dev_for_each_resource()

From: Mika Westerberg Instead of open-coding it everywhere introduce a tiny helper that can be used to iterate over each resource of a PCI device, and convert the most obvious users into it. While at it drop doubled empty line before pdev_sort_resources(). No functional changes intended. Sugge

[PATCH v5 0/4] PCI: Add pci_dev_for_each_resource() helper and update users

Provide two new helper macros to iterate over PCI device resources and convert users. Looking at it, refactor existing pci_bus_for_each_resource() and convert users accordingly. Changelog v5: - renamed loop variable to minimize the clash (Keith) - addressed smatch warning (Dan) - addressed 0-day

[PATCH v5 4/4] pcmcia: Convert to use pci_bus_for_each_resource_p()

The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński Acked-by: Dominik Brodowski --- drivers/pcmcia/rsrc_nonstatic.c | 9 +++--

[PATCH v5 3/4] EISA: Convert to use pci_bus_for_each_resource_p()

The pci_bus_for_each_resource_p() hides the iterator loop since it may be not used otherwise. With this, we may drop that iterator variable definition. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński --- drivers/eisa/pci_eisa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 delet

[PATCH v5 2/4] PCI: Split pci_bus_for_each_resource_p() out of pci_bus_for_each_resource()

Refactor pci_bus_for_each_resource() in the same way as it's done in pci_dev_for_each_resource() case. This will allow to hide iterator inside the loop, where it's not used otherwise. No functional changes intended. Signed-off-by: Andy Shevchenko Reviewed-by: Krzysztof Wilczyński --- .clang-fo

Re: [PATCH v7 1/5] xen: introduce CONFIG_GENERIC_BUG_FRAME

On Tue, Mar 14, 2023 at 3:12 PM Oleksii wrote: > I would like to add the changes from the [PATCH] xen/cpufreq: Remove > by Jason Andryuk but I don't know how > correctly do that. I mean should I added one more Signed-off to the > patch? Hi, Oleksii, It's two trivial deletions, so I think you c

Aw: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14.03.2023 18:12, Andrew Cooper wrote: > On 14/03/2023 4:48 pm, Denis wrote: > > On 14.03.2023 16:11, Andrew Cooper wrote: > >> On 14/03/2023 2:53 pm, Denis wrote: > >>> On 14.03.2023 07:37; Jan Beulich wrote: > On 14.03.2023 02:15, Denis wrote: > > On 13.03.2023 10:36, Jan wrote >

Re: [PATCH v7 1/5] xen: introduce CONFIG_GENERIC_BUG_FRAME

On Mon, 2023-03-13 at 17:26 +0100, Jan Beulich wrote: > On 09.03.2023 14:33, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/common/bug.c > > @@ -0,0 +1,107 @@ > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +

Aw: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14.03.2023 17:59, Jan Beulich wrote: > On 14.03.2023 17:45, Denis wrote: > > On 14.03.2023 16:37, Jan Beulich wrote: > >> On 14.03.2023 15:53, Denis wrote: > >>> What tests could I do or what info should I provide to help? > >> > >> Boot plain Linux (no Xen underneath) and collect the full set o

Re: [PATCH] xen/cpufreq: Remove

On Tue, 2023-03-14 at 08:14 -0400, Jason Andryuk wrote: > On Tue, Mar 14, 2023 at 6:19 AM Jan Beulich > wrote: > > > > On 13.03.2023 18:51, Jason Andryuk wrote: > > > The header is unneeded - there are no uses of BUG() or WARN() in > > > these > > > cpufreq files.  Remove the include.  It is stil

Re: [PATCH v4 1/4] PCI: Introduce pci_dev_for_each_resource()

On Sat, Mar 11, 2023 at 04:54:32PM +0300, Dan Carpenter wrote: > 059b4a086017fb Mika Westerberg 2023-03-10 246 > unsigned long type = resource_type(r); > 999ed65ad12e37 Rene Herman 2008-07-25 247 > 059b4a086017fb Mika Westerberg 2023-03-10 @248

Re: [PATCH v4 1/4] PCI: Introduce pci_dev_for_each_resource()

On Fri, Mar 10, 2023 at 03:15:38PM -0700, Keith Busch wrote: > On Fri, Mar 10, 2023 at 07:14:13PM +0200, Andy Shevchenko wrote: ... > > +#define pci_dev_for_each_resource_p(dev, res) > > \ > > + __pci_dev_for_each_resource(dev, res, i, unsigned int) > > It looks d

[libvirt test] 179616: tolerable trouble: pass/starved - PUSHED

flight 179616 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/179616/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-amd64-amd64-libvirt-xsm 15 migrate-s

Re: [XEN PATCH v7 18/20] xen/arm: ffa: support sharing memory

Hi Bertrand, On Mon, Mar 13, 2023 at 9:49 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Feb 2023, at 16:33, Jens Wiklander wrote: > > > > Adds support for a guest to share memory with an SP using FFA_MEM_SHARE > > and FFA_MEM_RECLAIM. Only small memory regions can be shared using a > > sin

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14/03/2023 4:48 pm, Denis wrote: > On 14.03.2023 16:11, Andrew Cooper wrote: >> On 14/03/2023 2:53 pm, Denis wrote: >>> On 14.03.2023 07:37; Jan Beulich wrote: On 14.03.2023 02:15, Denis wrote: > On 13.03.2023 10:36, Jan wrote >> On 10.03.2023 21:50, Denis wrote: >>> Should I te

Re: [PATCH v1] xen/riscv: make calculation of stack address PC-relative

On 14/03/2023 4:00 pm, Oleksii Kurochko wrote: > The patch is needed to keep all addresses PC-relative. > > Pseudoinstruction 'la' can be transformed to 'auipc/addi' or > 'auipc/l{w|d}'. It depends on the .option directive: nopic and pic. > > Right now, 'la' transforms to 'auipc/l{w|d}', which in c

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 3/14/2023 10:39 AM, Mark Cave-Ayland wrote: > On 14/03/2023 14:21, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > >> On 14/03/2023 13:26, Chuck Zmudzinski wrote: > >> > >>> On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2023 at 12:43:12PM +0

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14.03.2023 17:45, Denis wrote: > On 14.03.2023 16:37, Jan Beulich wrote: >> On 14.03.2023 15:53, Denis wrote: >>> What tests could I do or what info should I provide to help? >> >> Boot plain Linux (no Xen underneath) and collect the full set of kernel >> boot messages (some distros store this a

Re: [PATCH] vpci/msix: handle accesses adjacent to the MSI-X table

On 14.03.2023 17:34, Roger Pau Monné wrote: > On Tue, Mar 14, 2023 at 04:46:19PM +0100, Jan Beulich wrote: >> On 14.03.2023 14:54, Roger Pau Monné wrote: >>> On Tue, Mar 14, 2023 at 12:56:33PM +0100, Jan Beulich wrote: On 14.03.2023 11:13, Roger Pau Monne wrote: I'm also concerned of misa

Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14.03.2023 16:11, Andrew Cooper wrote: > On 14/03/2023 2:53 pm, Denis wrote: > > On 14.03.2023 07:37; Jan Beulich wrote: > >> On 14.03.2023 02:15, Denis wrote: > >>> On 13.03.2023 10:36, Jan wrote > On 10.03.2023 21:50, Denis wrote: > > Should I test something else? > ... there was

Re: [RFC XEN PATCH 6/6] tools/libs/light: pci: translate irq to gsi

On 12.03.2023 08:54, Huang Rui wrote: > From: Chen Jiqian > > Use new xc_physdev_gsi_from_irq to get the GSI number Apart from again the "Why?", ... > --- a/tools/libs/light/libxl_pci.c > +++ b/tools/libs/light/libxl_pci.c > @@ -1486,6 +1486,7 @@ static void pci_add_dm_done(libxl__egc *egc, >

Re: [RFC XEN PATCH 5/6] tools/libs/call: add linux os call to get gsi from irq

On 12.03.2023 08:54, Huang Rui wrote: > From: Chen Jiqian > > When passthrough gpu to guest, usersapce can only get irq > instead of gsi. But it should pass gsi to guest, so that > guest can get interrupt signal. So, provide function to get > gsi. > > Signed-off-by: Chen Jiqian > Signed-off-by:

Re: [PATCH] vpci/msix: handle accesses adjacent to the MSI-X table

On Tue, Mar 14, 2023 at 04:46:19PM +0100, Jan Beulich wrote: > On 14.03.2023 14:54, Roger Pau Monné wrote: > > On Tue, Mar 14, 2023 at 12:56:33PM +0100, Jan Beulich wrote: > >> On 14.03.2023 11:13, Roger Pau Monne wrote: > >> I'm also concerned of misaligned accesses: While we can't keep the > >> g

Re: [RFC XEN PATCH 4/6] x86/pvh: PVH dom0 also need PHYSDEVOP_setup_gsi call

On 12.03.2023 08:54, Huang Rui wrote: > From: Chen Jiqian An empty description won't do here. First of all you need to address the Why? As already hinted at in the reply to the earlier patch, it looks like you're breaking the intended IRQ model for PVH. Jan

Re: [RFC XEN PATCH 3/6] x86/pvh: shouldn't check pirq flag when map pirq in PVH

On 12.03.2023 08:54, Huang Rui wrote: > From: Chen Jiqian > > PVH is also hvm type domain, but PVH hasn't X86_EMU_USE_PIRQ > flag. So, when dom0 is PVH and call PHYSDEVOP_map_pirq, it > will fail at check has_pirq(); > > Signed-off-by: Chen Jiqian > Signed-off-by: Huang Rui Please see b96b500

Re: [PATCH v1] xen/riscv: make calculation of stack address PC-relative

On Tue, Mar 14, 2023 at 06:00:41PM +0200, Oleksii Kurochko wrote: > The patch is needed to keep all addresses PC-relative. > > Pseudoinstruction 'la' can be transformed to 'auipc/addi' or > 'auipc/l{w|d}'. It depends on the .option directive: nopic and pic. > > Right now, 'la' transforms to 'auip

Re: [PATCH v1] xen/riscv: make calculation of stack address PC-relative

On 14.03.2023 17:00, Oleksii Kurochko wrote: > The patch is needed to keep all addresses PC-relative. > > Pseudoinstruction 'la' can be transformed to 'auipc/addi' or > 'auipc/l{w|d}'. It depends on the .option directive: nopic and pic. > > Right now, 'la' transforms to 'auipc/l{w|d}', I'm afrai

Re: [RFC XEN PATCH 2/6] vpci: accept BAR writes if dom0 is PVH

On 12.03.2023 08:54, Huang Rui wrote: > From: Chen Jiqian > > When dom0 is PVH and we want to passthrough gpu to guest, > we should allow BAR writes even through BAR is mapped. If > not, the value of BARs are not initialized when guest firstly > start. >From this it doesn't become clear why a GP

[PATCH v1] xen/riscv: make calculation of stack address PC-relative

The patch is needed to keep all addresses PC-relative. Pseudoinstruction 'la' can be transformed to 'auipc/addi' or 'auipc/l{w|d}'. It depends on the .option directive: nopic and pic. Right now, 'la' transforms to 'auipc/l{w|d}', which in case of cpu0_boot_stack[] will lead to the usage of _GLOBA

Re: [PATCH] vpci/msix: handle accesses adjacent to the MSI-X table

On 14.03.2023 14:54, Roger Pau Monné wrote: > On Tue, Mar 14, 2023 at 12:56:33PM +0100, Jan Beulich wrote: >> On 14.03.2023 11:13, Roger Pau Monne wrote: >>> --- a/xen/drivers/vpci/msix.c >>> +++ b/xen/drivers/vpci/msix.c >>> @@ -27,6 +27,13 @@ >>> ((addr) >= vmsix_table_addr(vpci, nr) &&

Re: [PATCH v2] xen/grants: repurpose command line max options

On Tue, Mar 14, 2023 at 03:59:22PM +0100, Jan Beulich wrote: > On 14.03.2023 15:45, Roger Pau Monne wrote: > > Slightly change the meaning of the command line > > gnttab_max_{maptrack_,}frames: do not use them as upper bounds for the > > passed values at domain creation, instead just use them as de

Re: Aw: Re: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14.03.2023 15:53, Denis wrote: > On 14.03.2023 07:37; Jan Beulich wrote: >> On 14.03.2023 02:15, Denis wrote: >>> On 13.03.2023 10:36, Jan wrote On 10.03.2023 21:50, Denis wrote: > Should I test something else? ... there was no request for any further testing here, for the mom

Re: [PATCH] xen/console: Handle true dom0less case when switching serial input

On 14.03.2023 15:27, Michal Orzel wrote: > At the moment, we direct serial input to hardware domain by default. > This does not make any sense when running in true dom0less mode, since > such domain does not exist. As a result, users wishing to write to > an emulated UART of a domU are always force

[ovmf test] 179625: all pass - PUSHED

flight 179625 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179625/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 961792c9d61f7e03e0c1b6b9f93b8b306df94bf9 baseline version: ovmf a1386bb252066262c0b66

Re: [PATCH] libxl: Fix libxl__device_pci_reset error messages

On 13.03.23 20:57, Jason Andryuk wrote: Don't use the LOG*D macros. They expect a domid, but "domain" here is the PCI domain. Hence it is inappropriate for this use. Make the write error messages uniform with LOGE. errno has the interesting information while rc is just -1. Drop printing rc a

Re: Aw: Re: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14/03/2023 2:53 pm, Denis wrote: > On 14.03.2023 07:37; Jan Beulich wrote: >> On 14.03.2023 02:15, Denis wrote: >>> On 13.03.2023 10:36, Jan wrote On 10.03.2023 21:50, Denis wrote: > Should I test something else? ... there was no request for any further testing here, for the moment

Re: [PATCH v2] xen/grants: repurpose command line max options

On 14.03.2023 15:45, Roger Pau Monne wrote: > Slightly change the meaning of the command line > gnttab_max_{maptrack_,}frames: do not use them as upper bounds for the > passed values at domain creation, instead just use them as defaults > in the absence of any provided value. > > It's not very use

Aw: Re: Re: [help] Xen 4.14.5 on Devuan 4.0 Chimaera, regression from Xen 4.0.1

On 14.03.2023 07:37; Jan Beulich wrote: > On 14.03.2023 02:15, Denis wrote: > > On 13.03.2023 10:36, Jan wrote > >> On 10.03.2023 21:50, Denis wrote: > >>> Should I test something else? > >> > >> ... there was no request for any further testing here, for the moment. > > > > ah...sorry, going by "Wo

Re: [PATCH 5/7] tools: Use -s for python shebangs

On 14/03/2023 2:15 pm, Andrew Cooper wrote: > diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile > index 29ad0513212f..04b3995cc0f6 100644 > --- a/tools/pygrub/Makefile > +++ b/tools/pygrub/Makefile > @@ -7,7 +7,7 @@ PY_LDFLAGS = $(SHLIB_LDFLAGS) $(APPEND_LDFLAGS) > INSTALL_LOG = build/ins

[PATCH v2] xen/grants: repurpose command line max options

Slightly change the meaning of the command line gnttab_max_{maptrack_,}frames: do not use them as upper bounds for the passed values at domain creation, instead just use them as defaults in the absence of any provided value. It's not very useful for the options to be used both as defaults and as c

Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c

On 14.03.23 15:33, Jan Beulich wrote: On 14.03.2023 15:27, Juergen Gross wrote: V2: - add const, use unsigned int for loop counters (Roger Pau Monné) Hmm, ... --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -1072,7 +1072,111 @@ static void end_block_io_

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 14/03/2023 14:21, Chuck Zmudzinski wrote: On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: On 14/03/2023 13:26, Chuck Zmudzinski wrote: On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: On 14/03/2023 06:33, Michael S. Tsirkin w

[qemu-mainline test] 179609: regressions - trouble: fail/pass/starved

flight 179609 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/179609/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt 14 guest-start fail REGR. vs. 179518 test-amd64-i386-l

Re: [PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c

On 14.03.2023 15:27, Juergen Gross wrote: > V2: > - add const, use unsigned int for loop counters (Roger Pau Monné) Hmm, ... > --- a/drivers/block/xen-blkback/blkback.c > +++ b/drivers/block/xen-blkback/blkback.c > @@ -1072,7 +1072,111 @@ static void end_block_io_op(struct bio *bio) > bio_p

[PATCH v2 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c

There is no need to have the functions blkif_get_x86_32_req() and blkif_get_x86_64_req() in a header file, as they are used in one place only. So move them into the using source file and drop the inline qualifier. While at it fix some style issues, and simplify the code by variable reusing and us

[PATCH v2 3/4] xen/blkback: simplify free_persistent_gnts() interface

The interface of free_persistent_gnts() can be simplified, as there is only a single caller of free_persistent_gnts() and the 2nd and 3rd parameters are easily obtainable via the ring pointer, which is passed as the first parameter anyway. Signed-off-by: Juergen Gross Acked-by: Roger Pau Monné -

[PATCH] xen/console: Handle true dom0less case when switching serial input

At the moment, we direct serial input to hardware domain by default. This does not make any sense when running in true dom0less mode, since such domain does not exist. As a result, users wishing to write to an emulated UART of a domU are always forced to execute CTRL-AAA first. The same issue is wh

[PATCH v2 2/4] xen/blkback: remove stale prototype

There is no function xen_blkif_purge_persistent(), so remove its prototype from common.h. Signed-off-by: Juergen Gross Acked-by: Roger Pau Monné --- drivers/block/xen-blkback/common.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/xen-blkback/common.h b/drivers/block/xen-blkb

[PATCH v2 1/4] xen/blkback: fix white space code style issues

Signed-off-by: Juergen Gross Acked-by: Roger Pau Monné --- drivers/block/xen-blkback/blkback.c | 2 +- drivers/block/xen-blkback/common.h | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index a

[PATCH v2 0/4] xen/blkback: some cleanups

Some small cleanup patches I had lying around for some time now. Juergen Gross (4): xen/blkback: fix white space code style issues xen/blkback: remove stale prototype xen/blkback: simplify free_persistent_gnts() interface xen/blkback: move blkif_get_x86_*_req() into blkback.c drivers/blo

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > On 14/03/2023 13:26, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > >> On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > >>> On 14/03/2023 06:33, Michael S. Tsirkin wrote: > >>> > On Tue, Mar 14,

Re: [PATCH] flask: label-pci: Allow specifying optional irq label

On Tue, Mar 14, 2023 at 10:11 AM Jan Beulich wrote: > > On 14.03.2023 14:20, Jason Andryuk wrote: > > This patch should have had v2 in the subject (it has a v2 change log). > > The next one will have v3. > > Will it? I've committed it earlier today ... Not any more! Thank you. I had not checke

[PATCH 3/7] tools: Delete trailing whitespace in python scripts

No functional change. Signed-off-by: Andrew Cooper --- CC: Wei Liu CC: Anthony PERARD CC: Marek Marczykowski-Górecki CC: Bernhard Kaindl --- tools/misc/xencov_split| 1 - tools/pygrub/src/ExtLinuxConf.py | 2 +- tools/pygrub/src/GrubConf.py | 30 ++--- tools/pygrub/s

[PATCH 6/7] tools/python: Improve unit test handling

* Add X86_{CPUID,MSR}_POLICY_FORMAT checks which were missed previously. * Drop test_suite(). It hasn't been necessary since the Py2.3 era. * Drop the __main__ logic. This can't be used without manually adjusting the include path, and `make test` knows how to do the right thing. * For `mak

[PATCH 7/7] tools/python: Drop shebangs from library files

These aren't runable scripts, so shouldn't have shebangs. Signed-off-by: Andrew Cooper --- CC: Wei Liu CC: Anthony PERARD CC: Marek Marczykowski-Górecki CC: Bernhard Kaindl --- tools/python/xen/migration/legacy.py | 1 - tools/python/xen/migration/libxc.py | 1 - tools/python/xen/migration/

[PATCH 4/7] tools/pygrub: Factor out common setup.py parts

... to mirror the tools/python side in c/s 2b8314a3c354. No functional change. Signed-off-by: Andrew Cooper --- CC: Wei Liu CC: Anthony PERARD CC: Marek Marczykowski-Górecki CC: Bernhard Kaindl --- tools/pygrub/Makefile | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff

[PATCH 2/7] tools/misc: Drop xencons

This is a python script which has it's shebang modified by be python3, but was never converted to be python3 compatible. The most recent reference I can find to this script (which isn't incidental adjustments in the makefile) is from the Xen book, fileish 561e30b80402 which says %% Alternativ

[PATCH 1/7] tools/python: Drop pylintrc

This was added in 2004 in c/s b7d4a69f0ccb5 and has never been referenced since. Given the the commit message of simply "Added .", it was quite possibly a mistake in the first place. Signed-off-by: Andrew Cooper --- CC: Wei Liu CC: Anthony PERARD CC: Marek Marczykowski-Górecki CC: Bernhard Ka

[PATCH 0/7] tools: More Python 3 fixes (part 1 of N)

Despite previous statements to the contrary, Xen still does not support Python 3. Various notes are on https://gitlab.com/xen-project/xen/-/issues/114 The following scripts are installed, and given a python3 shebang, but are not Py3 compatible: xencov_split xentrace_format xencons xenpv

[PATCH 5/7] tools: Use -s for python shebangs

This is mandated by the Fedora packaging guidelines because it is a security vulnerability otherwise in suid scripts. It's a very good idea generally, because it prevents the users local python environment interfering from system packaged scripts. Signed-off-by: Andrew Cooper --- CC: Wei Liu CC

Re: [PATCH] flask: label-pci: Allow specifying optional irq label

On 14.03.2023 14:20, Jason Andryuk wrote: > On Tue, Mar 14, 2023 at 2:42 AM Jan Beulich wrote: >> >> On 13.03.2023 22:11, dpsmith.dev wrote: >>> On 3/13/23 15:14, Jason Andryuk wrote: On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith wrote: > On 3/13/23 13:50, Jason Andryuk wrote: >>>

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 3/14/2023 9:41 AM, Mark Cave-Ayland wrote: > On 14/03/2023 13:26, Chuck Zmudzinski wrote: > > > On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > >> On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > >>> On 14/03/2023 06:33, Michael S. Tsirkin wrote: > >>> > On Tue, Mar 14,

Re: [XEN PATCH] x86/monitor: Add new monitor event to catch I/O instructions

  13.03.2023, 19:15, "Jan Beulich" :On 11.03.2023 15:50, Tamas K Lengyel wrote: On Fri, Mar 10, 2023 at 10:57 PM Dmitry Isaykin  --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4579,6 +4579,8 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) 

Re: [PATCH 0/4] xen/blkback: some cleanups

On Fri, Dec 16, 2022 at 03:58:12PM +0100, Juergen Gross wrote: > Some small cleanup patches I had lying around for some time now. > > Juergen Gross (4): > xen/blkback: fix white space code style issues > xen/blkback: remove stale prototype > xen/blkback: simplify free_persistent_gnts() inter

Re: [PATCH 4/4] xen/blkback: move blkif_get_x86_*_req() into blkback.c

On Fri, Dec 16, 2022 at 03:58:16PM +0100, Juergen Gross wrote: > There is no need to have the functions blkif_get_x86_32_req() and > blkif_get_x86_64_req() in a header file, as they are used in one place > only. > > So move them into the using source file and drop the inline qualifier. > > While

Re: [XEN PATCH] x86/monitor: Add new monitor event to catch I/O instructions

  13.03.2023, 15:33, "Andrew Cooper" :On 11/03/2023 3:57 am, Dmitry Isaykin wrote: Adds monitor support for I/O instructions. Signed-off-by: Dmitry Isaykin  Signed-off-by: Anton Belousov Thankyou for the patch.  A couple of questions.Right now, yo

Re: [PATCH] vpci/msix: handle accesses adjacent to the MSI-X table

On Tue, Mar 14, 2023 at 12:56:33PM +0100, Jan Beulich wrote: > On 14.03.2023 11:13, Roger Pau Monne wrote: > > --- a/xen/drivers/vpci/msix.c > > +++ b/xen/drivers/vpci/msix.c > > @@ -27,6 +27,13 @@ > > ((addr) >= vmsix_table_addr(vpci, nr) && \ > > (addr) < v

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 14/03/2023 13:26, Chuck Zmudzinski wrote: On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: On 14/03/2023 06:33, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: Commit 4f67543bb8c5

Re: [linux-linus test] 179607: regressions - trouble: fail/pass/starved

On 14.03.23 13:52, osstest service owner wrote: flight 179607 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179607/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 13 guest-start

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 3/14/2023 9:17 AM, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > > On 14/03/2023 06:33, Michael S. Tsirkin wrote: > > > > > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot

Re: [PATCH] flask: label-pci: Allow specifying optional irq label

On Tue, Mar 14, 2023 at 2:42 AM Jan Beulich wrote: > > On 13.03.2023 22:11, dpsmith.dev wrote: > > On 3/13/23 15:14, Jason Andryuk wrote: > >> On Mon, Mar 13, 2023 at 2:49 PM Daniel P. Smith > >> wrote: > >>> On 3/13/23 13:50, Jason Andryuk wrote: > usage(argCnt, argv); >

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On Tue, Mar 14, 2023 at 12:43:12PM +, Mark Cave-Ayland wrote: > On 14/03/2023 06:33, Michael S. Tsirkin wrote: > > > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > > > uses slot_reserved_mask t

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On Tue, Mar 14, 2023 at 08:33:02AM -0400, Chuck Zmudzinski wrote: > On 3/14/2023 2:33 AM, Michael S. Tsirkin wrote: > > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > > > uses slot_reserved_mask to

[linux-linus test] 179607: regressions - trouble: fail/pass/starved

flight 179607 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179607/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 13 guest-start fail REGR. vs. 178042 test-amd64-amd64-xl

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 14/03/2023 06:33, Michael S. Tsirkin wrote: On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the xenfv machine when the guest is configur

Re: [PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

On 3/14/2023 2:33 AM, Michael S. Tsirkin wrote: > On Tue, Mar 14, 2023 at 12:01:09AM -0400, Chuck Zmudzinski wrote: > > Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") > > uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the > > xenfv machine when the guest

Re: [PATCH 0/4] xen/blkback: some cleanups

On 09.01.23 16:05, Juergen Gross wrote: On 16.12.22 15:58, Juergen Gross wrote: Some small cleanup patches I had lying around for some time now. Juergen Gross (4):    xen/blkback: fix white space code style issues    xen/blkback: remove stale prototype    xen/blkback: simplify free_persistent_g

Re: Report in downstream Debian: mpt3sas broken with xen dom0 with update to 5.10.149 in 5.10.y.

Hi Andrew, On Tue, Mar 14, 2023 at 11:41:08AM +, Andrew Cooper wrote: On 14/03/2023 11:23 am, Juergen Gross wrote: > On 14.03.23 12:17, Joost Roeleveld wrote: >>> On Mon, Oct 24, 2022 at 05:28:05PM +, Andrew Cooper wrote: I don't know exactly how this translates to Linux internals,

  1   2   >