Re: [PATCH v3 1/4] tools: rename xen-tools/libs.h file to common-macros.h

2023-03-05 Thread Jan Beulich
On 06.03.2023 08:21, Juergen Gross wrote: > In order to better reflect the contents of the header and to make it > more appropriate to use it for different runtime environments like > programs, libraries, and firmware, rename the libs.h include file to > common-macros.h. Additionally add a comment

Re: [PATCH 15/17] xen: remove MODULE_LICENSE in non-modules

2023-03-05 Thread Juergen Gross
On 02.03.23 22:17, Nick Alcock wrote: Since commit 8b41fc4454e ("kbuild: create modules.builtin without Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations are used to identify modules. As a consequence, uses of the macro in non-modules will cause modprobe to misidentify their con

Re: [XEN PATCH backport for-4.15] tools: Drop gettext as a build dependency

2023-03-05 Thread Jan Beulich
On 03.03.2023 16:27, Andrew Cooper wrote: > On 03/03/2023 2:55 pm, Anthony PERARD wrote: >> From: Andrew Cooper >> >> It has not been a dependency since at least 4.13. Remove its mandatory check >> from ./configure. >> >> Annotate the dependency in the CI dockerfiles, and drop them from CirrusCI

Re: Backports for stable branches

2023-03-05 Thread Jan Beulich
On 03.03.2023 16:56, Andrew Cooper wrote: > Two python bugfixes which definitely qualify for backport: > > 897257ba49d0 tools/python: change 's#' size type for Python >= 3.10 > 3a59443c1d5a tools/xenmon: Fix xenmon.py for with python3.x Queued. I wasn't entirely certain about these when I saw the

[PATCH v3 4/4] tools: add offsetof() to xen-tools/common-macros.h

2023-03-05 Thread Juergen Gross
Instead of having multiple files defining offsetof(), add the definition to tools/include/xen-tools/common-macros.h. Signed-off-by: Juergen Gross --- V3: - don't modify tools/firmware/include/stddef.h (Jan Beulich) --- tools/firmware/hvmloader/util.h | 3 --- tools/include/xen-tools/comm

[PATCH v3 3/4] tools: get rid of additional min() and max() definitions

2023-03-05 Thread Juergen Gross
Defining min(), min_t(), max() and max_t() at other places than xen-tools/common-macros.h isn't needed, as the definitions in said header can be used instead. Same applies to BUILD_BUG_ON() in hvmloader. Signed-off-by: Juergen Gross --- tools/firmware/hvmloader/util.h | 8 ++-- tools/libs/

[PATCH v3 2/4] tools: add container_of() macro to xen-tools/common-macros.h

2023-03-05 Thread Juergen Gross
Instead of having 4 identical copies of the definition of a container_of() macro in different tools header files, add that macro to xen-tools/common-macros.h and use that instead. Delete the other copies of that macro. Signed-off-by: Juergen Gross --- There is a similar macro CONTAINER_OF() defi

[PATCH v3 1/4] tools: rename xen-tools/libs.h file to common-macros.h

2023-03-05 Thread Juergen Gross
In order to better reflect the contents of the header and to make it more appropriate to use it for different runtime environments like programs, libraries, and firmware, rename the libs.h include file to common-macros.h. Additionally add a comment pointing out the need to be self-contained. Sugge

[PATCH v3 0/4] tools: use xen-tools/libs.h for common definitions

2023-03-05 Thread Juergen Gross
There are some macros defined multiple times in tools. Use only a single header file for defining those macros and drop the copies. V2: - add patch 1 (Andrew Cooper) V3: - address comments Juergen Gross (4): tools: rename xen-tools/libs.h file to common-macros.h tools: add container_of() mac

Re: [PATCH v2 1/4] tools: rename xen-tools/libs.h file to common-macros.h

2023-03-05 Thread Juergen Gross
On 27.02.23 16:46, Jan Beulich wrote: On 27.02.2023 16:41, Juergen Gross wrote: --- a/tools/include/xen-tools/libs.h +++ b/tools/include/xen-tools/common-macros.h @@ -1,5 +1,13 @@ -#ifndef __XEN_TOOLS_LIBS__ -#define __XEN_TOOLS_LIBS__ +#ifndef __XEN_TOOLS_COMMON_MACROS__ +#define __XEN_TOOLS_CO

Re: [PATCH v2 4/4] tools: add offsetof() to xen-tools/common-macros.h

2023-03-05 Thread Juergen Gross
On 27.02.23 16:53, Jan Beulich wrote: On 27.02.2023 16:41, Juergen Gross wrote: --- a/tools/firmware/include/stddef.h +++ b/tools/firmware/include/stddef.h @@ -1,10 +1,10 @@ #ifndef _STDDEF_H_ #define _STDDEF_H_ +#include + typedef __SIZE_TYPE__ size_t; #define NULL ((void*)0)

Re: [PATCH 1/2] x86/cpuid: Infrastructure for leaves 7:1{ecx,edx}

2023-03-05 Thread Jan Beulich
On 03.03.2023 19:32, Andrew Cooper wrote: > On 03/03/2023 7:23 am, Jan Beulich wrote: >> On 04.01.2023 12:11, Andrew Cooper wrote: >>> --- a/xen/include/public/arch-x86/cpufeatureset.h >>> +++ b/xen/include/public/arch-x86/cpufeatureset.h >>> @@ -288,6 +288,9 @@ XEN_CPUFEATURE(NSCB, 1

Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages

2023-03-05 Thread Oleksii
On Mon, 2023-02-27 at 16:19 +0100, Jan Beulich wrote: > On 27.02.2023 16:12, Jan Beulich wrote: > > On 24.02.2023 16:06, Oleksii Kurochko wrote: > > > +static void __attribute__((section(".entry"))) > > > +_setup_initial_pagetables(pte_t *second, pte_t *first, pte_t > > > *zeroeth, > > > > Why the

Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages

2023-03-05 Thread Oleksii
On Mon, 2023-02-27 at 16:12 +0100, Jan Beulich wrote: > On 24.02.2023 16:06, Oleksii Kurochko wrote: > > --- /dev/null > > +++ b/xen/arch/riscv/include/asm/page.h > > @@ -0,0 +1,90 @@ > > +#ifndef _ASM_RISCV_PAGE_H > > +#define _ASM_RISCV_PAGE_H > > + > > +#include > > +#include > > + > > +#defin

[ovmf test] 179351: all pass - PUSHED

2023-03-05 Thread osstest service owner
flight 179351 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/179351/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fc14c809cb982f3c8cb3429604262cde0cb264a9 baseline version: ovmf f80f052277c88a67c55e1

[linux-linus test] 179310: regressions - trouble: fail/pass/starved

2023-03-05 Thread osstest service owner
flight 179310 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179310/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qe

Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages

2023-03-05 Thread Oleksii
> > > > > > > > > > > > + > > > > > +    page_addr = map_start; > > > > > +    while ( page_addr < map_end ) > > > > > > > > Looking at the loop, it looks like you are assuming that the > > > > region > > > > will > > > > never cross a boundary of a page-table (either L0, L1, L2). I > > > > am

[linux-linus test] 179269: regressions - trouble: fail/pass/starved

2023-03-05 Thread osstest service owner
flight 179269 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/179269/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 178042 test-amd64-amd64-qe

Re: [PATCH v1 1/3] xen/riscv: introduce setup_initial_pages

2023-03-05 Thread Oleksii
Hi Julien, On Mon, 2023-02-27 at 17:36 +, Julien Grall wrote: > Hi Oleksii, > > On 27/02/2023 16:52, Oleksii wrote: > > On Sat, 2023-02-25 at 17:53 +, Julien Grall wrote: > > > > +/* > > > > + * WARNING: load_addr() and linker_addr() are to be called > > > > only > > > > when the MMU is >

[xen-unstable test] 179244: tolerable trouble: fail/pass/starved

2023-03-05 Thread osstest service owner
flight 179244 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/179244/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 179148 test-amd64-i386-xl-qemuu-win7-amd64