Re: [QEMU][PATCH v5 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-01-31 Thread Paul Durrant
On 31/01/2023 22:51, Vikram Garhwal wrote: xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano St

Re: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific

2023-01-31 Thread Xenia Ragiadakou
On 2/1/23 07:07, Tian, Kevin wrote: From: Xenia Ragiadakou Sent: Tuesday, January 24, 2023 8:42 PM The variable untrusted_msi indicates whether the system is vulnerable to CVE-2011-1898 due to the absence of interrupt remapping support. Although AMD iommus with interrupt remapping disabled ar

[xen-unstable test] 176297: regressions - trouble: blocked/broken/fail/pass

2023-01-31 Thread osstest service owner
flight 176297 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176297/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken build-armhf

[xen-unstable-smoke test] 176308: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176308 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176308/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

RE: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map

2023-01-31 Thread Penny Zheng
Hi Julien, > -Original Message- > From: Julien Grall > Sent: Tuesday, January 31, 2023 5:28 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org; > Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > ayan.kumar.hal...@xilinx.com > Cc: Volodymyr Babchuk > Subject: Re: [PATCH v2 11/40]

RE: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART

2023-01-31 Thread Penny Zheng
Hi Julien > -Original Message- > From: Julien Grall > Sent: Tuesday, January 31, 2023 5:42 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified funct

RE: [PATCH v4 4/5] x86/dpci: move hvm_dpci_isairq_eoi() to generic HVM code

2023-01-31 Thread Tian, Kevin
> From: Xenia Ragiadakou > Sent: Tuesday, January 24, 2023 8:42 PM > > The function hvm_dpci_isairq_eoi() has no dependencies on VT-d driver > code > and can be moved from xen/drivers/passthrough/vtd/x86/hvm.c to > xen/drivers/passthrough/x86/hvm.c, along with the corresponding > copyrights. > >

RE: [PATCH v4 3/5] x86/iommu: call pi_update_irte through an hvm_function callback

2023-01-31 Thread Tian, Kevin
> From: Xenia Ragiadakou > Sent: Tuesday, January 24, 2023 8:42 PM > > Posted interrupt support in Xen is currently implemented only for the > Intel platforms. Instead of calling directly pi_update_irte() from the > common hvm code, add a pi_update_irte callback to the hvm_function_table. > Then,

RE: [PATCH v4 2/5] x86/iommu: make code addressing CVE-2011-1898 no VT-d specific

2023-01-31 Thread Tian, Kevin
> From: Xenia Ragiadakou > Sent: Tuesday, January 24, 2023 8:42 PM > > The variable untrusted_msi indicates whether the system is vulnerable to > CVE-2011-1898 due to the absence of interrupt remapping support. > Although AMD iommus with interrupt remapping disabled are also affected, > this case

RE: [PATCH v2] x86/shadow: make iommu_snoop usage consistent with HAP's

2023-01-31 Thread Tian, Kevin
> From: Jan Beulich > Sent: Friday, January 20, 2023 4:44 PM > > First of all the variable is meaningful only when an IOMMU is in use for > a guest. Qualify the check accordingly, like done elsewhere. Furthermore > the controlling command line option is supposed to take effect on VT-d > only. Sin

[ovmf test] 176306: all pass - PUSHED

2023-01-31 Thread osstest service owner
flight 176306 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176306/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bda715bf6d7cf565ccd4eda1f48e850ab8e2d452 baseline version: ovmf 2f2fd79fc4000a9ef8979

[xen-4.17-testing test] 176300: trouble: blocked/broken/fail/pass/starved

2023-01-31 Thread osstest service owner
flight 176300 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176300/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemuu-rhel6hvm-intel broken test-amd

[xen-unstable-smoke test] 176305: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176305 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176305/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-31 Thread Andrew Cooper
On 30/01/2023 10:44 pm, Julien Grall wrote: > Hi Jan, > > On 30/01/2023 13:50, Jan Beulich wrote: >> On 30.01.2023 12:54, Oleksii wrote: >>> Hi Jan, >>> >>> On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: On 27.01.2023 14:59, Oleksii Kurochko wrote: > --- /dev/null > +++ b/xen/ar

[PATCH v4 3/3] xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory

2023-01-31 Thread Henry Wang
Similarly as the static regions and boot modules, memory regions with EfiACPIReclaimMemory type (defined in bootinfo.acpi if CONFIG_ACPI is enabled) should also not be overlapping with memory regions in bootinfo.reserved_mem and bootinfo.modules. Therefore, this commit reuses the `meminfo_overlap_

[PATCH v4 2/3] xen/arm: Extend the memory overlap check to include bootmodules

2023-01-31 Thread Henry Wang
Similarly as the static regions defined in bootinfo.reserved_mem, the bootmodule regions defined in bootinfo.modules should also not be overlapping with memory regions in either bootinfo.reserved_mem or bootinfo.modules. Therefore, this commit introduces a helper `bootmodules_overlap_check()` and

[PATCH v4 0/3] Memory region overlap check in device tree

2023-01-31 Thread Henry Wang
As we are having more and more types of memory region defined in the device tree, it is necessary to add the overlap check of these memory regions in Xen, because such check will help user to identify the misconfiguration in the device tree at the early stage of boot time. The first patch introduc

[PATCH v4 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-31 Thread Henry Wang
As we are having more and more types of static region, and all of these static regions are defined in bootinfo.reserved_mem, it is necessary to add the overlap check of reserved memory regions in Xen, because such check will help user to identify the misconfiguration in the device tree at the early

Re: [QEMU][PATCH v5 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-01-31 Thread Stefano Stabellini
On Tue, 31 Jan 2023, Vikram Garhwal wrote: > From: Stefano Stabellini > > This patch does following: > 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in > preparation for moving most of xen-hvm code to an arch-neutral location, > move the x86-specific portion of xe

Re: [QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine

2023-01-31 Thread Stefano Stabellini
On Tue, 31 Jan 2023, Vikram Garhwal wrote: > Add a new machine xenpvh which creates a IOREQ server to register/connect with > Xen Hypervisor. > > Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a > TPM emulator and connects to swtpm running on host machine via chardev

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-31 Thread Stefano Stabellini
On Mon, 30 Jan 2023, Jan Beulich wrote: > On 30.01.2023 12:54, Oleksii wrote: > > Hi Jan, > > > > On Fri, 2023-01-27 at 15:24 +0100, Jan Beulich wrote: > >> On 27.01.2023 14:59, Oleksii Kurochko wrote: > >>> --- /dev/null > >>> +++ b/xen/arch/riscv/include/asm/processor.h > >>> @@ -0,0 +1,82 @@ >

[xen-unstable-smoke test] 176303: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176303 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176303/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Andrew Cooper
On 31/01/2023 11:17 pm, Alistair Francis wrote: > On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: >> On 31/01/2023 11:44, Alistair Francis wrote: >>> On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: >>> >> From my understanding, on RISC-V, the use of PC-relative address is >> only guaranteed

[linux-linus test] 176291: regressions - trouble: blocked/broken/fail/pass

2023-01-31 Thread osstest service owner
flight 176291 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176291/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd64-freebsd11-amd64

Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Alistair Francis
On Tue, Jan 31, 2023 at 10:03 PM Julien Grall wrote: > > > > On 31/01/2023 11:44, Alistair Francis wrote: > > On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: > >> > >> Hi Alistair, Bobby and community, > >> > >> I would like to ask your help with the following check: > >> +/* > >> + * early_*() c

[QEMU][PATCH v5 10/10] meson.build: enable xenpv machine build for ARM

2023-01-31 Thread Vikram Garhwal
Add CONFIG_XEN for aarch64 device to support build for ARM targets. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 693802adb2..13c4ad101

[QEMU][PATCH v5 09/10] hw/arm: introduce xenpvh machine

2023-01-31 Thread Vikram Garhwal
Add a new machine xenpvh which creates a IOREQ server to register/connect with Xen Hypervisor. Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a TPM emulator and connects to swtpm running on host machine via chardev socket and support TPM functionalities for a guest do

[QEMU][PATCH v5 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets

2023-01-31 Thread Vikram Garhwal
From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 6d3b665629..693802adb2 100644 --- a/meson.build +++

[QEMU][PATCH v5 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-01-31 Thread Vikram Garhwal
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function xen_do_ioreq_

[QEMU][PATCH v5 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-01-31 Thread Vikram Garhwal
From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move han

[QEMU][PATCH v5 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-01-31 Thread Vikram Garhwal
Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/xen/xen-hvm-common.c b/hw/xen/xen-hvm-common.c index 5e3c7b073f

[QEMU][PATCH v5 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-01-31 Thread Vikram Garhwal
From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization. Signed-off-by

[QEMU][PATCH v5 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2023-01-31 Thread Vikram Garhwal
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated XenIOS

[QEMU][PATCH v5 02/10] hw/i386/xen: rearrange xen_hvm_init_pc

2023-01-31 Thread Vikram Garhwal
In preparation to moving most of xen-hvm code to an arch-neutral location, move non IOREQ references to: - xen_get_vmport_regs_pfn - xen_suspend_notifier - xen_wakeup_notifier - xen_ram_init towards the end of the xen_hvm_init_pc() function. This is done to keep the common ioreq functions in one

[QEMU][PATCH v5 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-01-31 Thread Vikram Garhwal
xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini --- hw/i386/meson.build

[QEMU][PATCH v5 00/10] Introduce xenpvh machine for arm architecture

2023-01-31 Thread Vikram Garhwal
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi, This series add xenpvh machine for aarch64. Motivation behind creating xenpvh machine with IOREQ and TPM was to enable each guest on Xen aarch64 to have it's own unique and emulated TPM. This series does

[xen-unstable-smoke test] 176302: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176302 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176302/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit

2023-01-31 Thread Julien Grall
Hi Jan, On 31/01/2023 09:11, Jan Beulich wrote: On 30.01.2023 20:27, Julien Grall wrote: Hi Jan, On 23/12/2022 11:31, Julien Grall wrote: On 20/12/2022 15:30, Jan Beulich wrote: On 16.12.2022 12:48, Julien Grall wrote: From: Hongyan Xia This avoids the assumption that boot pages are in th

Re: [PATCH] xen/common: rwlock: Constify the parameter of _rw_is{,_write}_locked()

2023-01-31 Thread Julien Grall
Hi Jan, On 31/01/2023 09:34, Jan Beulich wrote: On 30.01.2023 19:28, Julien Grall wrote: From: Julien Grall The lock is not meant to be modified by _rw_is{,_write}_locked(). So constify it. This is helpful to be able to assert if the lock is taken when the underlying structure is const. Sig

[PATCH 6/7] tools/ocaml/xc: Don't reference Abstract_Tag objects with the GC lock released

2023-01-31 Thread Andrew Cooper
The intf->{addr,len} references in the xc_map_foreign_range() call are unsafe. >From the manual: https://ocaml.org/manual/intfc.html#ss:parallel-execution-long-running-c-code "After caml_release_runtime_system() was called and until caml_acquire_runtime_system() is called, the C code must not a

[PATCH 7/7] tools/ocaml/xc: Don't reference Custom objects with the GC lock released

2023-01-31 Thread Andrew Cooper
From: Edwin Török The modification to the _H() macro for Ocaml 5 support introduced a subtle bug. From the manual: https://ocaml.org/manual/intfc.html#ss:parallel-execution-long-running-c-code "After caml_release_runtime_system() was called and until caml_acquire_runtime_system() is called,

[PATCH 4/7] tools/ocaml/evtchn: Misc cleanup

2023-01-31 Thread Andrew Cooper
* Remove local integers when all we're returning is Val_int() of another variable. The CAMLlocal*() can't be optimised automatically, as it's registered with the GC. * Rename "virq_type" to "virq" and "_port" to "port". * In stub_eventchn_pending(), rename 'port' to 'rc', to be consistent

[PATCH 1/7] tools/ocaml/libs: Don't declare stubs as taking void

2023-01-31 Thread Andrew Cooper
From: Edwin Török There is no such thing as an Ocaml function (C stub or otherwise) taking no parameters. In the absence of any other parameters, unit is still passed. This doesn't explode with any ABI we care about, but would malfunction for an ABI environment such as stdcall. Fixes: c3afd398

[PATCH 3/7] tools/ocaml/evtchn: Don't reference Custom objects with the GC lock released

2023-01-31 Thread Andrew Cooper
From: Edwin Török The modification to the _H() macro for Ocaml 5 support introduced a subtle bug. From the manual: https://ocaml.org/manual/intfc.html#ss:parallel-execution-long-running-c-code "After caml_release_runtime_system() was called and until caml_acquire_runtime_system() is called,

[PATCH 0/7] tools/ocaml: Memory corruption fixes in bindings

2023-01-31 Thread Andrew Cooper
It turns out there have been some latent memory corruption bugs and other errors in the bindings since they were first introduced. These were discovered after realising that we'd introduced other memory corruption bugs as part of the Ocaml 5 fixes, and in the case of the evtchn bindings, backporte

[PATCH 5/7] tools/ocaml/xc: Fix binding for xc_domain_assign_device()

2023-01-31 Thread Andrew Cooper
From: Edwin Török The patch adding this binding was plain broken, and unreviewed. It modified the C stub to add a 4th parameter without an equivalent adjustment in the Ocaml side of the bindings. In 64bit builds, this causes us to dereference whatever dead value is in %rcx when trying to interp

[PATCH 2/7] tools/ocaml/libs: Allocate the correct amount of memory for Abstract_tag

2023-01-31 Thread Andrew Cooper
caml_alloc() takes units of Wsize (word size), not bytes. As a consequence, we're allocating 4 or 8 times too much memory. Ocaml has a helper, Wsize_bsize(), but it truncates cases which aren't an exact multiple. Use a BUILD_BUG_ON() to cover the potential for truncation, as there's no rounding-

[xen-unstable-smoke test] 176301: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176301 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176301/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages

2023-01-31 Thread Julien Grall
Hi, On 31/01/2023 15:13, Michal Orzel wrote: At the moment, Xen does not support booting gzip compressed uImages. This is because we are trying to decompress the kernel before probing the u-boot header. This leads to a failure as the header always appears at the top of the image (and therefore o

Re: [PATCH 1/2] xen/arm: Move kernel_uimage_probe definition after kernel_decompress

2023-01-31 Thread Julien Grall
Hi Michal, On 31/01/2023 15:13, Michal Orzel wrote: In a follow-up patch, we will be calling kernel_decompress function from within kernel_uimage_probe to support booting compressed images with u-boot header. Therefore, move the kernel_uimage_probe definition after kernel_decompress so that the

Re: [XEN PATCH v2 0/3] Configure qemu upstream correctly by default for igd-passthru

2023-01-31 Thread Chuck Zmudzinski
On 1/29/23 7:38 PM, Chuck Zmudzinski wrote: > On 1/25/23 6:19 PM, Chuck Zmudzinski wrote: >> On 1/25/2023 6:37 AM, Anthony PERARD wrote: >>> On Tue, Jan 10, 2023 at 02:32:01AM -0500, Chuck Zmudzinski wrote: >>> > I call attention to the commit message of the first patch which points >>> > out that

Re: [PATCH 1/2] xen/arm: Move kernel_uimage_probe definition after kernel_decompress

2023-01-31 Thread Ayan Kumar Halder
On 31/01/2023 15:13, Michal Orzel wrote: In a follow-up patch, we will be calling kernel_decompress function from within kernel_uimage_probe to support booting compressed images with u-boot header. Therefore, move the kernel_uimage_probe definition after kernel_decompress so that the latter is

Re: [PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages

2023-01-31 Thread Ayan Kumar Halder
On 31/01/2023 15:13, Michal Orzel wrote: At the moment, Xen does not support booting gzip compressed uImages. This is because we are trying to decompress the kernel before probing the u-boot header. This leads to a failure as the header always appears at the top of the image (and therefore obsc

[ovmf test] 176299: all pass - PUSHED

2023-01-31 Thread osstest service owner
flight 176299 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/176299/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2f2fd79fc4000a9ef89792677e85c99224e5a035 baseline version: ovmf 35091031329e741b25ed6

[libvirt test] 176289: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176289 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176289/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd64-libvirt-

[xen-unstable-smoke test] 176298: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176298 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176298/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

[xen-4.17-testing test] 176295: trouble: blocked/broken/fail/pass/starved

2023-01-31 Thread osstest service owner
flight 176295 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176295/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm broken test-

Re: [XEN PATCH] .gitignore: Only ignore hidden dependency files

2023-01-31 Thread Jan Beulich
On 31.01.2023 16:42, Anthony PERARD wrote: > The current pattern also ignores directories suffixed with ".d", like: > tools/hotplug/*/rc.d > tools/hotplug/*/init.d > > Avoid this by only ignoring "hidden" files, for which name starts with > a dot. > > Signed-off-by: Anthony PERARD Acked

Re: [RFC PATCH v3 03/10] tools/xl: Add pcid daemon to xl

2023-01-31 Thread Anthony PERARD
On Sun, Jan 15, 2023 at 01:31:04PM +0200, Dmytro Semenets wrote: > diff --git a/tools/include/pcid.h b/tools/include/pcid.h > new file mode 100644 > index 00..6506b18d25 > --- /dev/null > +++ b/tools/include/pcid.h Please, rename it "xen-pcid.h". We should try to use our own namespace to a

Re: [RFC PATCH v3 00/10] PCID server

2023-01-31 Thread Anthony PERARD
On Sun, Jan 15, 2023 at 01:31:01PM +0200, Dmytro Semenets wrote: > PCID server used if domain has passthrough PCI controller and we wants > assign some device to other domain. > pcid server should be launched in domain owns the PCI controller and process > request from other domains. > pcid server

Re: [XEN v2 04/11] xen/arm: Typecast the DT values into paddr_t

2023-01-31 Thread Julien Grall
Hi Ayan, On 31/01/2023 10:51, Ayan Kumar Halder wrote: On 20/01/2023 10:16, Julien Grall wrote: Last comment, maybe we could add fdt_get_mem_rsv_paddr to setup.h instead of introducing xen/arch/arm/include/asm/device_tree.h, given that we already have device tree definitions there (device_tree_

[XEN PATCH] .gitignore: Only ignore hidden dependency files

2023-01-31 Thread Anthony PERARD
The current pattern also ignores directories suffixed with ".d", like: tools/hotplug/*/rc.d tools/hotplug/*/init.d Avoid this by only ignoring "hidden" files, for which name starts with a dot. Signed-off-by: Anthony PERARD --- .gitignore | 4 ++-- 1 file changed, 2 insertions(+), 2 dele

[PATCH 2/2] xen/arm: Add support for booting gzip compressed uImages

2023-01-31 Thread Michal Orzel
At the moment, Xen does not support booting gzip compressed uImages. This is because we are trying to decompress the kernel before probing the u-boot header. This leads to a failure as the header always appears at the top of the image (and therefore obscuring the gzip header). Move the call to ker

[PATCH 0/2] xen/arm: Support compressed uImages

2023-01-31 Thread Michal Orzel
This series adds support for booting gzip compressed images with u-boot header. Currently Xen does not support such images because we are trying to decompress the kernel before probing uImage header. The problem can be solved using 2 different approaches: 1) Split uImage probing into 2 stages. The

[PATCH 1/2] xen/arm: Move kernel_uimage_probe definition after kernel_decompress

2023-01-31 Thread Michal Orzel
In a follow-up patch, we will be calling kernel_decompress function from within kernel_uimage_probe to support booting compressed images with u-boot header. Therefore, move the kernel_uimage_probe definition after kernel_decompress so that the latter is visible to the former. No functional change

[xen-unstable-smoke test] 176296: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176296 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176296/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd

[xen-unstable test] 176284: regressions - trouble: blocked/broken/fail/pass

2023-01-31 Thread osstest service owner
flight 176284 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176284/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow broken test-amd64-i386-xl-qemuu-ovmf-

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-31 Thread Julien Grall
On 31/01/2023 12:24, Oleksii wrote: Hi Julien, Hi Oleksii, On Mon, 2023-01-30 at 22:11 +, Julien Grall wrote: Hi, On 30/01/2023 11:40, Oleksii wrote: On Fri, 2023-01-27 at 14:54 +, Julien Grall wrote: Hi Oleksii, On 27/01/2023 13:59, Oleksii Kurochko wrote: +static inline voi

Re: [PATCH v8 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Oleksii
Hi Julien, On Tue, 2023-01-31 at 11:42 +, Julien Grall wrote: > Hi Oleksii, > > On 31/01/2023 11:17, Oleksii Kurochko wrote: > > Because printk() relies on a serial driver (like the ns16550 > > driver) > > and drivers require working virtual memory (ioremap()) there is not > > print functiona

Re: [PATCH v2 12/14] xen/riscv: introduce an implementation of macros from

2023-01-31 Thread Oleksii
On Mon, 2023-01-30 at 22:28 +, Julien Grall wrote: > Hi Oleksii, > > On 30/01/2023 11:35, Oleksii wrote: > > Hi Julien, > > On Fri, 2023-01-27 at 16:02 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > > On 27/01/2023 13:59, Oleksii Kurochko wrote: > > > > The patch introduces macros: BU

Re: [PATCH v1 01/14] xen/riscv: add _zicsr to CFLAGS

2023-01-31 Thread Oleksii
On Tue, 2023-01-31 at 21:49 +1000, Alistair Francis wrote: > On Mon, Jan 23, 2023 at 8:43 PM Oleksii > wrote: > > > > On Fri, 2023-01-20 at 15:29 +, Andrew Cooper wrote: > > > On 20/01/2023 2:59 pm, Oleksii Kurochko wrote: > > > > Work with some registers requires csr command which is part of

Re: [PATCH v2 07/14] xen/riscv: introduce exception context

2023-01-31 Thread Oleksii
Hi Julien, On Mon, 2023-01-30 at 22:11 +, Julien Grall wrote: > Hi, > > On 30/01/2023 11:40, Oleksii wrote: > > On Fri, 2023-01-27 at 14:54 +, Julien Grall wrote: > > > Hi Oleksii, > > > > > > On 27/01/2023 13:59, Oleksii Kurochko wrote: > > > > +static inline void wfi(void) > > > > +{ >

Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Julien Grall
On 31/01/2023 11:44, Alistair Francis wrote: On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: Hi Alistair, Bobby and community, I would like to ask your help with the following check: +/* + * early_*() can be called from head.S with MMU-off. + * + * The following requiremets should be honou

Re: [PATCH v1 01/14] xen/riscv: add _zicsr to CFLAGS

2023-01-31 Thread Alistair Francis
On Mon, Jan 23, 2023 at 8:43 PM Oleksii wrote: > > On Fri, 2023-01-20 at 15:29 +, Andrew Cooper wrote: > > On 20/01/2023 2:59 pm, Oleksii Kurochko wrote: > > > Work with some registers requires csr command which is part of > > > Zicsr. > > > > > > Signed-off-by: Oleksii Kurochko > > > --- > >

[xen-unstable-smoke test] 176294: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176294 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176294/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

Re: [PATCH v7 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Alistair Francis
On Sat, Jan 28, 2023 at 12:15 AM Oleksii wrote: > > Hi Alistair, Bobby and community, > > I would like to ask your help with the following check: > +/* > + * early_*() can be called from head.S with MMU-off. > + * > + * The following requiremets should be honoured for early_*() to > + * work corre

Re: [PATCH v8 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Julien Grall
Hi Oleksii, On 31/01/2023 11:17, Oleksii Kurochko wrote: Because printk() relies on a serial driver (like the ns16550 driver) and drivers require working virtual memory (ioremap()) there is not print functionality early in Xen boot. The patch introduces the basic stuff of early_printk functiona

Re: [PATCH v7 2/2] automation: add RISC-V smoke test

2023-01-31 Thread Oleksii
On Fri, 2023-01-27 at 10:14 -0800, Stefano Stabellini wrote: > On Fri, 27 Jan 2023, Oleksii Kurochko wrote: > > Add check if there is a message 'Hello from C env' presents > > in log file to be sure that stack is set and C part of early printk > > is working. > > > > Signed-off-by: Oleksii Kurochk

[PATCH v8 1/2] xen/riscv: introduce early_printk basic stuff

2023-01-31 Thread Oleksii Kurochko
Because printk() relies on a serial driver (like the ns16550 driver) and drivers require working virtual memory (ioremap()) there is not print functionality early in Xen boot. The patch introduces the basic stuff of early_printk functionality which will be enough to print 'hello from C environment

[PATCH v8 0/2] Basic early_printk and smoke test implementation

2023-01-31 Thread Oleksii Kurochko
The patch series introduces the following: - the minimal set of headers and changes inside them. - SBI (RISC-V Supervisor Binary Interface) things necessary for basic early_printk implementation. - things needed to set up the stack. - early_printk() function to print only strings. - RISC-V smoke

[PATCH v8 2/2] automation: update RISC-V smoke test

2023-01-31 Thread Oleksii Kurochko
Add check if there is a message 'Hello from C env' presents in log file to be sure that stack is set and C part of early printk is working. Signed-off-by: Oleksii Kurochko Acked-by: Stefano Stabellini Reviewed-by: Alistair Francis --- Changes in V8: - Set "needs: archlinux-current-gcc-riscv64-

[xen-4.17-testing test] 176290: trouble: blocked/broken/fail/pass/starved

2023-01-31 Thread osstest service owner
flight 176290 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176290/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair broken test-amd64-i386-

Re: [XEN v2 04/11] xen/arm: Typecast the DT values into paddr_t

2023-01-31 Thread Ayan Kumar Halder
On 20/01/2023 10:16, Julien Grall wrote: Hi, Hi Julien/Stefano, I am answering to multiple e-mails at the same time. On 19/01/2023 23:34, Stefano Stabellini wrote: On Thu, 19 Jan 2023, Stefano Stabellini wrote: On Tue, 17 Jan 2023, Ayan Kumar Halder wrote: In future, we wish to support 3

[xen-unstable-smoke test] 176293: trouble: blocked/broken/pass

2023-01-31 Thread osstest service owner
flight 176293 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/176293/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd

Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-31 Thread Julien Grall
On 31/01/2023 09:30, Henry Wang wrote: Hi Julien, -Original Message- From: Julien Grall Subject: Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem I will fix this patch and #2 in v4. I am happy to deal with it on commit if you want. Including adding

Re: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART

2023-01-31 Thread Julien Grall
Hi Penny, On 31/01/2023 05:38, Penny Zheng wrote: -Original Message- From: Julien Grall Sent: Monday, January 30, 2023 6:00 PM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Wei Chen ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk Subject: Re: [PATCH v2 13/40] xen/mpu

Re: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map

2023-01-31 Thread Julien Grall
On 31/01/2023 04:11, Penny Zheng wrote: Hi Julien -Original Message- From: Julien Grall Sent: Monday, January 30, 2023 5:40 PM To: Penny Zheng ; xen-devel@lists.xenproject.org Cc: Wei Chen ; Stefano Stabellini ; Bertrand Marquis ; Volodymyr Babchuk Subject: Re: [PATCH v2 11/40] xen

Re: [PATCH] xen/common: rwlock: Constify the parameter of _rw_is{,_write}_locked()

2023-01-31 Thread Jan Beulich
On 30.01.2023 19:28, Julien Grall wrote: > From: Julien Grall > > The lock is not meant to be modified by _rw_is{,_write}_locked(). So > constify it. > > This is helpful to be able to assert if the lock is taken when the > underlying structure is const. > > Signed-off-by: Julien Grall Reviewe

RE: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-31 Thread Henry Wang
Hi Julien, > -Original Message- > From: Julien Grall > Subject: Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for > bootinfo.reserved_mem > > I will fix this patch and #2 in v4. > > I am happy to deal with it on commit if you want. Including adding the comment for both patches? T

Re: [PATCH v5 2/5] xen/arm64: Rework the memory layout

2023-01-31 Thread Michal Orzel
Hi Julien, On 30/01/2023 19:36, Julien Grall wrote: > > > On 30/01/2023 09:08, Michal Orzel wrote: >> Hi Julien, > > Hi Michal, > >> On 27/01/2023 20:55, Julien Grall wrote: >>> >>> >>> From: Julien Grall >>> >>> Xen is currently not fully compliant with the Arm Arm because it will >>> switch

Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-31 Thread Julien Grall
On 31/01/2023 02:25, Henry Wang wrote: Hi Julien, -Original Message- From: Julien Grall Subject: Re: [PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem Hi Henry, +{ +paddr_t bank_start = INVALID_PADDR, bank_end = 0; +paddr_t region_end = region_sta

Re: [PATCH v2 01/14] xen/riscv: add _zicsr to CFLAGS

2023-01-31 Thread Jan Beulich
On 31.01.2023 01:21, Alistair Francis wrote: > On Sat, Jan 28, 2023 at 12:00 AM Oleksii Kurochko > wrote: >> >> Work with some registers requires csr command which is part of >> Zicsr. >> >> Signed-off-by: Oleksii Kurochko > > Reviewed-by: Alistair Francis There is an open aspect Andrew has po

Re: [PATCH 05/22] x86/srat: vmap the pages for acpi_slit

2023-01-31 Thread Jan Beulich
On 30.01.2023 20:27, Julien Grall wrote: > Hi Jan, > > On 23/12/2022 11:31, Julien Grall wrote: >> On 20/12/2022 15:30, Jan Beulich wrote: >>> On 16.12.2022 12:48, Julien Grall wrote: From: Hongyan Xia This avoids the assumption that boot pages are in the direct map. Sign

Re: [PATCH] x86: idle domains don't have a domain-page mapcache

2023-01-31 Thread Jan Beulich
On 30.01.2023 20:00, Julien Grall wrote: > On 05/01/2023 11:09, Jan Beulich wrote: >> --- a/xen/arch/x86/domain_page.c >> +++ b/xen/arch/x86/domain_page.c >> @@ -28,8 +28,11 @@ static inline struct vcpu *mapcache_curr >> /* >>* When current isn't properly set up yet, this is equivalen

Re: [PATCH v4] xen/x86: public: add TSC defines for cpuid leaf 4

2023-01-31 Thread Jan Beulich
On 30.01.2023 18:44, Krister Johansen wrote: > Cpuid leaf 4 contains information about how the state of the tsc, its > mode, and some additional information. A commit that is queued for > linux would like to use this to determine whether the tsc mode has been > set to 'no emulation' in order to ma