Re: [PATCH] xen/public: move xenstore related doc into 9pfs.h

2023-01-29 Thread Jan Beulich
On 30.01.2023 08:46, Juergen Gross wrote: > On 30.01.23 08:36, Jan Beulich wrote: >> On 30.01.2023 07:37, Juergen Gross wrote: >>> The Xenstore related documentation is currently to be found in >>> docs/misc/9pfs.pandoc, instead of the related header file >>> xen/include/public/io/9pfs.h like for m

Re: [PATCH] xen/public: move xenstore related doc into 9pfs.h

2023-01-29 Thread Juergen Gross
On 30.01.23 08:36, Jan Beulich wrote: On 30.01.2023 07:37, Juergen Gross wrote: The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a

Re: [PATCH] xen/public: move xenstore related doc into 9pfs.h

2023-01-29 Thread Jan Beulich
On 30.01.2023 07:37, Juergen Gross wrote: > The Xenstore related documentation is currently to be found in > docs/misc/9pfs.pandoc, instead of the related header file > xen/include/public/io/9pfs.h like for most other paravirtualized > device protocols. > > There is a comment in the header pointin

Re: [PATCH] Add more rules to docs/misra/rules.rst

2023-01-29 Thread Jan Beulich
On 27.01.2023 19:33, Stefano Stabellini wrote: > On Fri, 27 Jan 2023, Jan Beulich wrote: >> On 26.01.2023 19:54, Stefano Stabellini wrote: >> Looking back at the sheet, it says "rule already followed by >> the community in most cases" which I assume was based on there being >> only very few violati

[PATCH] xen/public: move xenstore related doc into 9pfs.h

2023-01-29 Thread Juergen Gross
The Xenstore related documentation is currently to be found in docs/misc/9pfs.pandoc, instead of the related header file xen/include/public/io/9pfs.h like for most other paravirtualized device protocols. There is a comment in the header pointing at the document, but the given file name is wrong. A

RE: [PATCH v2 13/40] xen/mpu: introduce unified function setup_early_uart to map early UART

2023-01-29 Thread Penny Zheng
Hi, Julien > -Original Message- > From: Julien Grall > Sent: Sunday, January 29, 2023 3:43 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v2 13/40] xen/mpu: introduce unified funct

Re: [PATCH] tools/xenstored: hashtable: Constify the parameters of hashfn/eqfn

2023-01-29 Thread Juergen Gross
On 27.01.23 19:55, Julien Grall wrote: From: Julien Grall The parameters of hashfn/eqfn should never be modified. So constify them and propagate the const to the users. Take the opportunity to solve some coding style issues around the code modified. Signed-off-by: Julien Grall Reviewed-by:

RE: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU memory region map

2023-01-29 Thread Penny Zheng
> -Original Message- > From: Julien Grall > Sent: Sunday, January 29, 2023 3:37 PM > To: Penny Zheng ; xen-devel@lists.xenproject.org > Cc: Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v2 11/40] xen/mpu: build up start-of-day Xen MPU > mem

[xen-unstable test] 176273: trouble: blocked/broken/fail/pass/starved

2023-01-29 Thread osstest service owner
flight 176273 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176273/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-i386-prev

Re: Ping: [PATCH] Argo: don't obtain excess page references

2023-01-29 Thread Christopher Clark
On Mon, Nov 21, 2022 at 4:41 AM Jan Beulich wrote: > On 11.10.2022 11:28, Jan Beulich wrote: > > find_ring_mfn() already holds a page reference when trying to obtain a > > writable type reference. We shouldn't make assumptions on the general > > reference count limit being effectively "infinity".

[PATCH v2 4/4] xen/arm: Clean-up in p2m_init() and p2m_final_teardown()

2023-01-29 Thread Henry Wang
With the change in previous patch, the initial 16 pages in the P2M pool is not necessary anymore. Drop them for code simplification. Also the call to p2m_teardown() from arch_domain_destroy() is not necessary anymore since the movement of the P2M allocation out of arch_domain_create(). Drop the co

[PATCH v2 3/4] xen/arm: Defer GICv2 CPU interface mapping until the first access

2023-01-29 Thread Henry Wang
Currently, the mapping of the GICv2 CPU interface is created in arch_domain_create(). This causes some troubles in populating and freeing of the domain P2M pages pool. For example, a default 16 P2M pages are required in p2m_init() to cope with the P2M mapping of 8KB GICv2 CPU interface area, and th

[PATCH v2 2/4] xen/arm: Rename vgic_cpu_base and vgic_dist_base for new vGIC

2023-01-29 Thread Henry Wang
In the follow-up patch from this series, the GICv2 CPU interface mapping will be deferred until the first access in the stage-2 data abort trap handling code. Since the data abort trap handling code is common for the current and the new vGIC implementation, it is necessary to unify the variable nam

[PATCH v2 1/4] xen/arm: Reduce redundant clear root pages when teardown p2m

2023-01-29 Thread Henry Wang
Currently, p2m for a domain will be teardown from two paths: (1) The normal path when a domain is destroyed. (2) The arch_domain_destroy() in the failure path of domain creation. When tearing down p2m from (1), the part to clear and clean the root is only needed to do once rather than for every ca

[PATCH v2 0/4] P2M improvements for Arm

2023-01-29 Thread Henry Wang
There are some clean-up/improvement work that can be done in the Arm P2M code triggered by [1] and [2]. These were found at the 4.17 code freeze period so the issues were not fixed at that time. Therefore do the follow-ups here. Patch#1 addresses one comment in [1]. It was sent earlier and reviewe

[PATCH v3 3/3] xen/arm: Extend the memory overlap check to include EfiACPIReclaimMemory

2023-01-29 Thread Henry Wang
Similarly as the static regions and boot modules, memory regions with EfiACPIReclaimMemory type (defined in bootinfo.acpi if CONFIG_ACPI is enabled) should also not be overlapping with memory regions in bootinfo.reserved_mem and bootinfo.modules. Therefore, this commit reuses the `meminfo_overlap_

[PATCH v3 2/3] xen/arm: Extend the memory overlap check to include bootmodules

2023-01-29 Thread Henry Wang
Similarly as the static regions defined in bootinfo.reserved_mem, the bootmodule regions defined in bootinfo.modules should also not be overlapping with memory regions in either bootinfo.reserved_mem or bootinfo.modules. Therefore, this commit introduces a helper `bootmodules_overlap_check()` and

[PATCH v3 0/3] Memory region overlap check in device tree

2023-01-29 Thread Henry Wang
As we are having more and more types of memory region defined in the device tree, it is necessary to add the overlap check of these memory regions in Xen, because such check will help user to identify the misconfiguration in the device tree at the early stage of boot time. The first patch introduc

[PATCH v3 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2023-01-29 Thread Henry Wang
As we are having more and more types of static region, and all of these static regions are defined in bootinfo.reserved_mem, it is necessary to add the overlap check of reserved memory regions in Xen, because such check will help user to identify the misconfiguration in the device tree at the early

[xen-4.17-testing test] 176272: trouble: blocked/broken/fail/pass/starved

2023-01-29 Thread osstest service owner
flight 176272 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176272/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-pair broken test-amd64-i386-

Re: [XEN PATCH v2 0/3] Configure qemu upstream correctly by default for igd-passthru

2023-01-29 Thread Chuck Zmudzinski
On 1/25/23 6:19 PM, Chuck Zmudzinski wrote: > On 1/25/2023 6:37 AM, Anthony PERARD wrote: >> On Tue, Jan 10, 2023 at 02:32:01AM -0500, Chuck Zmudzinski wrote: >> > I call attention to the commit message of the first patch which points >> > out that using the "pc" machine and adding the xen platform

[linux-linus test] 176271: trouble: blocked/broken/fail/pass/starved

2023-01-29 Thread osstest service owner
flight 176271 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176271/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken test-amd64-amd64-libv

Re: [PATCH] Mini-OS: remove stale subdirs from Makefile

2023-01-29 Thread Samuel Thibault
Juergen Gross, le ven. 27 janv. 2023 08:32:44 +0100, a ecrit: > The SUBDIRS make variable has some stale entries, remove them. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Ma

Re: [PATCH] Mini-OS: move xenbus test code into test.c

2023-01-29 Thread Samuel Thibault
Juergen Gross, le ven. 27 janv. 2023 08:33:46 +0100, a ecrit: > The test code in xenbus.c can easily be moved into test.c. > > Signed-off-by: Juergen Gross Reviewed-by: Samuel Thibault > --- > test.c | 108 +++- > xenbus.c | 113 --

[libvirt test] 176269: trouble: blocked/broken/fail/pass

2023-01-29 Thread osstest service owner
flight 176269 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/176269/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf

[xen-unstable test] 176268: regressions - trouble: blocked/broken/fail/pass/starved

2023-01-29 Thread osstest service owner
flight 176268 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/176268/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-pair broken test-amd64-i386-xl-qemuu-ovmf-amd64

[xen-4.17-testing test] 176270: trouble: blocked/broken/fail/pass/starved

2023-01-29 Thread osstest service owner
flight 176270 xen-4.17-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/176270/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-ws16-amd64 broken test-amd6

[linux-linus test] 176267: trouble: blocked/broken/fail/pass/starved

2023-01-29 Thread osstest service owner
flight 176267 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/176267/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf broken build-armhf