[xen-unstable-smoke test] 175133: tolerable all pass - PUSHED

2022-12-09 Thread osstest service owner
flight 175133 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175133/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[linux-5.4 test] 175128: tolerable FAIL - PUSHED

2022-12-09 Thread osstest service owner
flight 175128 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/175128/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 175106 pass in 175128 test-armhf-armhf-xl-rtds 14 gue

[xen-unstable test] 175126: regressions - FAIL

2022-12-09 Thread osstest service owner
flight 175126 xen-unstable real [real] flight 175134 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175126/ http://logs.test-lab.xenproject.org/osstest/logs/175134/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

RE: [PATCH 1/3] xen/arm: Add memory overlap check for bootinfo.reserved_mem

2022-12-09 Thread Henry Wang
Hi both, I was lurking around to see how the discussion would go. Thanks for the discussions/inputs in this thread :) > -Original Message- > From: Stefano Stabellini > Subject: Re: [PATCH 1/3] xen/arm: Add memory overlap check for > bootinfo.reserved_mem > > > It cannot be a single stat

[xen-unstable-smoke test] 175131: tolerable all pass - PUSHED

2022-12-09 Thread osstest service owner
flight 175131 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175131/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[linux-linus test] 175116: regressions - FAIL

2022-12-09 Thread osstest service owner
flight 175116 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/175116/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-12-09 Thread Julien Grall
Hi Andrew, On 09/12/2022 22:18, Andrew Cooper wrote: On 09/12/2022 18:51, Julien Grall wrote: That said, moving the creation side of things doesn't change the teardown requirements.  When I get time to respin the fault_ttl series, Gitlab CI will be able to demonstrate the bug I keep on telling y

Re: MISRA C Rule 20.7 disambiguation

2022-12-09 Thread Stefano Stabellini
On Fri, 9 Dec 2022, Jan Beulich wrote: > On 09.12.2022 01:45, Stefano Stabellini wrote: > > This patch is to start a discussion in regard to rule 20.7 and its > > interpretation. During the last MISRA C call we discussed that "our"> > > interpretation of the rule means that the following two cases

[PATCH v2] xen/arm: efi-boot misra rule 4.1 fix

2022-12-09 Thread Stefano Stabellini
We have 3 violations of MISRA C Rule 4.1 ("Octal and hexadecimal escape sequences shall be terminated") in xen/arch/arm/efi/efi-boot.h. Fix them and take the opportunity to declare them as static const __initconst and improve the style. Signed-off-by: Stefano Stabellini --- Changes in v2: - add s

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-12-09 Thread Andrew Cooper
On 09/12/2022 18:51, Julien Grall wrote: > Hi Henry, > > On 08/12/2022 03:06, Henry Wang wrote: >> I am trying to work on the follow-up improvements about the Arm P2M >> code, >> and while trying to address the comment below, I noticed there was an >> unfinished >> discussion between me and Julien

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-12-09 Thread Stefano Stabellini
On Fri, 9 Dec 2022, Julien Grall wrote: > Hi Henry, > > On 08/12/2022 03:06, Henry Wang wrote: > > I am trying to work on the follow-up improvements about the Arm P2M code, > > and while trying to address the comment below, I noticed there was an > > unfinished > > discussion between me and Julien

Re: [PATCH 5/5] x86/tboot: actually wipe contexts

2022-12-09 Thread Andrew Cooper
On 06/12/2022 13:57, Jan Beulich wrote: > Especially with our use of __builtin_memset() to implement memset() the > compiler is free to eliminate instances when it can prove that the > affected object is dead. Introduce a small helper function accompanying > the memset() with a construct forcing th

Re: [PATCH 4/5] x86/tboot: correct IOMMU (VT-d) interaction

2022-12-09 Thread Andrew Cooper
On 06/12/2022 13:56, Jan Beulich wrote: > First of all using is_idle_domain() on the subject domain in the body of > for_each_domain() is pointless. Replace that conditional by one checking > that a domain actually has IOMMU support enabled for it, and that we're > actually on a VT-d system (both a

Re: [PATCH 3/5] x86/mm: PGC_shadowed_pt is used by shadow code only

2022-12-09 Thread Andrew Cooper
On 06/12/2022 13:54, Jan Beulich wrote: > By defining the constant to zero when !SHADOW_PAGING we give compilers > the chance to eliminate a little more dead code elsewhere in the tree. > Plus, as a minor benefit, the general reference count can be one bit > wider. (To simplify things, have PGC_sha

[xen-unstable-smoke test] 175130: tolerable all pass - PUSHED

2022-12-09 Thread osstest service owner
flight 175130 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/175130/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v2-ish] x86/boot: Relocate Xen using memcpy() directly

2022-12-09 Thread Andrew Cooper
We can relocate Xen by reading out of the virtual mapping that we're executing on, and write directly into the directmap. In fact, this removes one dependency on Xen being "at 0" (the XEN_IMG_OFFSET passed as src) for relocation to occur. This removes all the temporary pagetable handling under th

Re: [PATCH 1/3] x86/boot: Drop pte_update_limit from physical relocation logic

2022-12-09 Thread Andrew Cooper
On 10/12/2021 07:17, Jan Beulich wrote: > On 09.12.2021 18:34, Andrew Cooper wrote: >> On 07/12/2021 11:37, Jan Beulich wrote: >>> On 07.12.2021 11:53, Andrew Cooper wrote: --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1230,7 +1230,6 @@ void __init noreturn __start_xen(un

Re: [PATCH 5/5] x86/tboot: actually wipe contexts

2022-12-09 Thread Jason Andryuk
On Tue, Dec 6, 2022 at 8:57 AM Jan Beulich wrote: > > Especially with our use of __builtin_memset() to implement memset() the > compiler is free to eliminate instances when it can prove that the > affected object is dead. Introduce a small helper function accompanying > the memset() with a constru

Re: [PATCH 4/5] x86/tboot: correct IOMMU (VT-d) interaction

2022-12-09 Thread Jason Andryuk
On Tue, Dec 6, 2022 at 8:57 AM Jan Beulich wrote: > > First of all using is_idle_domain() on the subject domain in the body of > for_each_domain() is pointless. Replace that conditional by one checking > that a domain actually has IOMMU support enabled for it, and that we're > actually on a VT-d s

Re: [PATCH 1/5] x86/tboot: drop failed attempt to hash shadow page tables

2022-12-09 Thread Jason Andryuk
On Tue, Dec 6, 2022 at 8:58 AM Jan Beulich wrote: > > On 06.12.2022 14:53, Jan Beulich wrote: > > While plausible to do what was intended based on the name of the flag > > (PGC_page_table), that name was misleading and is going to be changed. > > It marks page tables pages _having_ a shadow, not s

Re: [PATCH linux-next] x86/xen/time: prefer tsc as clocksource when it is invariant

2022-12-09 Thread Boris Ostrovsky
On 12/8/22 11:36 AM, Krister Johansen wrote: + /* +* As Dom0 is never moved, no penalty on using TSC there. +* +* If the guest has invariant tsc, then set xen_clocksource rating +* below that of the tsc so that the system prefers tsc instead. This +

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-09 Thread Julien Grall
Hi Ayan, On 09/12/2022 19:10, Ayan Kumar Halder wrote: zImage and Image are image protocols, uImage is not. It is just a legacy u-boot header (no requirements \wrt booting,memory,registers, etc.). It can be added on top of anything (even vmlinux or a text file). So I guess this is why Xen state

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-09 Thread Ayan Kumar Halder
Hi Michal, On 09/12/2022 08:53, Michal Orzel wrote: On 08/12/2022 19:42, Ayan Kumar Halder wrote: On 08/12/2022 16:53, Julien Grall wrote: Hi, Hi, On 08/12/2022 15:24, Michal Orzel wrote: On 08/12/2022 14:51, Julien Grall wrote: Caution: This message originated from an External Source. Use

Re: [PATCH v2] xen/arm: p2m: Populate pages for GICv2 mapping in arch_domain_create()

2022-12-09 Thread Julien Grall
Hi Henry, On 08/12/2022 03:06, Henry Wang wrote: I am trying to work on the follow-up improvements about the Arm P2M code, and while trying to address the comment below, I noticed there was an unfinished discussion between me and Julien which I would like to continue and here opinions from all o

Linux 6.0.8 generates L1TF-vulnerable PTE if Xen's PAT is modified

2022-12-09 Thread Demi Marie Obenour
If Xen is patched to use the same PAT Linux does, it appears to break L1TF mitigations in PV Linux 6.0.8. Linux 5.15.81 works fine. The symptom is that Linux fails to boot, with Xen complaining about an L1TF-vulnerable PTE with shadow paging disabled. Details are at https://github.com/QubesOS/qu

Re: [PATCH] xen/arm: efi-boot misra rule 4.1 fix

2022-12-09 Thread Julien Grall
Hi, On 09/12/2022 09:04, Jan Beulich wrote: On 09.12.2022 01:41, Stefano Stabellini wrote: We have 3 violations of MISRA C Rule 4.1 ("Octal and hexadecimal escape sequences shall be terminated") in xen/arch/arm/efi/efi-boot.h. Fix them. Signed-off-by: Stefano Stabellini While I certainly ag

Re: [PATCH v2] xen/arm: Do not route NS phys timer IRQ to Xen

2022-12-09 Thread Julien Grall
Hi Michal, On 24/11/2022 18:57, Julien Grall wrote: On 28/10/2022 14:49, Michal Orzel wrote: At the moment, we route NS phys timer IRQ to Xen even though it does not make use of this timer. Xen uses hypervisor timer for itself and the physical timer is fully emulated, hence there is nothing tha

[libvirt test] 175113: tolerable FAIL - PUSHED

2022-12-09 Thread osstest service owner
flight 175113 libvirt real [real] flight 175129 libvirt real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175113/ http://logs.test-lab.xenproject.org/osstest/logs/175129/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-li

Re: [XEN][RFC PATCH v4 16/16] tools/xl: Add new xl command overlay for device tree overlay support

2022-12-09 Thread Anthony PERARD
On Tue, Dec 06, 2022 at 10:18:15PM -0800, Vikram Garhwal wrote: > diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c > index 35182ca196..868364c58d 100644 > --- a/tools/xl/xl_cmdtable.c > +++ b/tools/xl/xl_cmdtable.c > @@ -630,6 +630,12 @@ const struct cmd_spec cmd_table[] = { >"I

Re: [XEN][RFC PATCH v4 15/16] tools/libs/light: Implement new libxl functions for device tree overlay ops

2022-12-09 Thread Anthony PERARD
On Tue, Dec 06, 2022 at 10:18:14PM -0800, Vikram Garhwal wrote: > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index 2321a648a5..82fc7ce6b9 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -245,6 +245,11 @@ > */ > #define LIBXL_HAVE_DEVICETREE_PASSTHROUGH 1

Re: Xen Security Advisory 424 v1 (CVE-2022-42328,CVE-2022-42329) - Guests can trigger deadlock in Linux netback driver

2022-12-09 Thread Ross Lagerwall
On Thu, Dec 8, 2022 at 4:13 PM Juergen Gross wrote: > > On 08.12.22 16:59, Pratyush Yadav wrote: > > > > Hi, > > > > I noticed one interesting thing about this patch but I'm not familiar > > enough with the driver to say for sure what the right thing is. > > > > On Tue, Dec 06 2022, Xen.org securi

Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-09 Thread Demi Marie Obenour
On Fri, Dec 09, 2022 at 02:54:15PM +, Henry Wang wrote: > Hi, > > > -Original Message- > > From: Demi Marie Obenour > > Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT > > > > On Fri, Dec 09, 2022 at 07:37:53AM +, Henry Wang wrote: > > > Hi Julien, > > > > > > > -Or

[linux-5.4 test] 175106: regressions - FAIL

2022-12-09 Thread osstest service owner
flight 175106 linux-5.4 real [real] flight 175127 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175106/ http://logs.test-lab.xenproject.org/osstest/logs/175127/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: t

Re: [XEN][RFC PATCH v4 14/16] tools/libs/ctrl: Implement new xc interfaces for dt overlay

2022-12-09 Thread Anthony PERARD
On Tue, Dec 06, 2022 at 10:18:13PM -0800, Vikram Garhwal wrote: > diff --git a/tools/include/xenctrl.h b/tools/include/xenctrl.h > index 0c8b4c3aa7..a71bc0bb1d 100644 > --- a/tools/include/xenctrl.h > +++ b/tools/include/xenctrl.h > @@ -2633,6 +2633,9 @@ int xc_livepatch_replace(xc_interface *xch,

[ovmf test] 175124: all pass - PUSHED

2022-12-09 Thread osstest service owner
flight 175124 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175124/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1ef86f12014c19e7bd6b2f008e868c61b5c71878 baseline version: ovmf 127e2c531556b968a51e8

[xen-unstable test] 175104: tolerable FAIL - PUSHED

2022-12-09 Thread osstest service owner
flight 175104 xen-unstable real [real] flight 175125 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/175104/ http://logs.test-lab.xenproject.org/osstest/logs/175125/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

RE: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-09 Thread Henry Wang
Hi, > -Original Message- > From: Demi Marie Obenour > Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT > > On Fri, Dec 09, 2022 at 07:37:53AM +, Henry Wang wrote: > > Hi Julien, > > > > > -Original Message- > > > From: Julien Grall > > > Subject: Re: [PATCH v3] Use

Re: [PATCH V7 3/3] docs: Add documentation for generic virtio devices

2022-12-09 Thread Anthony PERARD
On Wed, Dec 07, 2022 at 12:50:44PM +0530, Viresh Kumar wrote: > +=item B > + > +Specifies the Virtio devices to be provided to the guest. > + > +Each B is a comma-separated list of C > +settings from the following list: We should probably say something about allowing a comma in the VALUE for "type

[PATCH v2] Input: xen-kbdfront - drop keys to shrink modalias

2022-12-09 Thread Jason Andryuk
xen kbdfront registers itself as being able to deliver *any* key since it doesn't know what keys the backend may produce. Unfortunately, the generated modalias gets too large and uevent creation fails with -ENOMEM. This can lead to gdm not using the keyboard since there is no seat associated [1]

Re: [PATCH V7 1/3] libxl: Add support for generic virtio device

2022-12-09 Thread Anthony PERARD
On Fri, Dec 09, 2022 at 05:43:54AM +0530, Viresh Kumar wrote: > On 08-12-22, 18:06, Anthony PERARD wrote: > > Nit: Something like: > > const char check[] = "virtio,device"; > > const size_t checkl = sizeof(check) - 1; > > ... strncmp(tmp, check, checkl)... > > (or just strncmp(tmp,

Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-12-09 Thread Anthony PERARD
Sorry, I've replied to the wrong version, but those comment apply to V7. Cheers, -- Anthony PERARD

Re: [PATCH V6 2/3] xl: Add support to parse generic virtio device

2022-12-09 Thread Anthony PERARD
On Tue, Nov 08, 2022 at 04:53:59PM +0530, Viresh Kumar wrote: > diff --git a/tools/ocaml/libs/xl/genwrap.py b/tools/ocaml/libs/xl/genwrap.py > index 7bf26bdcd831..b188104299b1 100644 > --- a/tools/ocaml/libs/xl/genwrap.py > +++ b/tools/ocaml/libs/xl/genwrap.py > @@ -36,6 +36,7 @@ DEVICE_LIST =

Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT

2022-12-09 Thread Demi Marie Obenour
On Fri, Dec 09, 2022 at 07:37:53AM +, Henry Wang wrote: > Hi Julien, > > > -Original Message- > > From: Julien Grall > > Subject: Re: [PATCH v3] Use EfiACPIReclaimMemory for ESRT > > > > Hi, > > > > >>> Signed-off-by: Demi Marie Obenour > > >> > > >> Acked-by: Jan Beulich > > >> >

Re: [PATCH v8 3/3] ASoC: SOF: Fix deadlock when shutdown a frozen userspace

2022-12-09 Thread Kai Vehmanen
Hi, On Thu, 1 Dec 2022, Ricardo Ribalda wrote: > On Thu, 1 Dec 2022 at 14:22, 'Oliver Neukum' via Chromeos Kdump > wrote: > > > > On 01.12.22 14:03, Ricardo Ribalda wrote: > > > This patchset does not modify this behaviour. It simply fixes the > > > stall for kexec(). > > > > > > The patch tha

[ovmf test] 175119: all pass - PUSHED

2022-12-09 Thread osstest service owner
flight 175119 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/175119/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 127e2c531556b968a51e8e2191d6e4580281856a baseline version: ovmf 54d81d06fc165fcb8eb83

Re: [PATCH] x86/SVM: restrict hardware SSBD update upon guest VIRT_SPEC_CTRL write

2022-12-09 Thread Andrew Cooper
On 09/12/2022 09:59, Roger Pau Monné wrote: > On Thu, Dec 08, 2022 at 12:24:54PM +0100, Jan Beulich wrote: >> core_set_legacy_ssbd() counts the number of times SSBD is being enabled >> via LS_CFG on a core. This assumes that calls there only occur if the >> state actually changes. While svm_ctxt_sw

Re: [PATCH 1/3] acpi/processor: fix evaluating _PDC method when running as Xen dom0

2022-12-09 Thread Roger Pau Monné
On Fri, Dec 02, 2022 at 06:06:26PM +0100, Rafael J. Wysocki wrote: > On Fri, Dec 2, 2022 at 5:37 PM Roger Pau Monné wrote: > > > > On Fri, Dec 02, 2022 at 08:17:56AM -0800, Dave Hansen wrote: > > > On 12/2/22 04:24, Roger Pau Monné wrote: > > > > On the implementation side, is the proposed approac

Re: [PATCH] x86/SVM: restrict hardware SSBD update upon guest VIRT_SPEC_CTRL write

2022-12-09 Thread Jan Beulich
On 09.12.2022 10:59, Roger Pau Monné wrote: > On Thu, Dec 08, 2022 at 12:24:54PM +0100, Jan Beulich wrote: >> --- a/xen/arch/x86/msr.c >> +++ b/xen/arch/x86/msr.c >> @@ -699,12 +699,16 @@ int guest_wrmsr(struct vcpu *v, uint32_t >> } >> else > > I think you could turn this into a

Re: [PATCH] x86/SVM: restrict hardware SSBD update upon guest VIRT_SPEC_CTRL write

2022-12-09 Thread Roger Pau Monné
On Thu, Dec 08, 2022 at 12:24:54PM +0100, Jan Beulich wrote: > core_set_legacy_ssbd() counts the number of times SSBD is being enabled > via LS_CFG on a core. This assumes that calls there only occur if the > state actually changes. While svm_ctxt_switch_{to,from}() conform to > this, guest_wrmsr()

[xen-4.16-testing test] 175099: tolerable FAIL - PUSHED

2022-12-09 Thread osstest service owner
flight 175099 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/175099/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 175067 test-amd64-amd64-xl-qemuu-win7-a

Re: [PATCH] xen/arm: efi-boot misra rule 4.1 fix

2022-12-09 Thread Luca Fancellu
> On 9 Dec 2022, at 00:41, Stefano Stabellini wrote: > > We have 3 violations of MISRA C Rule 4.1 ("Octal and hexadecimal escape > sequences shall be terminated") in xen/arch/arm/efi/efi-boot.h. Fix > them. > > Signed-off-by: Stefano Stabellini Hi Stefano, I’ve checked also with coverity an

Re: [PATCH] drivers/xen/hypervisor: Expose Xen SIF flags to userspace

2022-12-09 Thread Juergen Gross
On 02.12.22 19:22, Per Bilse wrote: /proc/xen is a legacy pseudo filesystem which predates Xen support getting merged into Linux. It has largely been replaced with more normal locations for data (/sys/hypervisor/ for info, /dev/xen/ for user devices). We want to compile xenfs support out of the

Re: [PATCH] xen/arm: efi-boot misra rule 4.1 fix

2022-12-09 Thread Jan Beulich
On 09.12.2022 01:41, Stefano Stabellini wrote: > We have 3 violations of MISRA C Rule 4.1 ("Octal and hexadecimal escape > sequences shall be terminated") in xen/arch/arm/efi/efi-boot.h. Fix > them. > > Signed-off-by: Stefano Stabellini While I certainly agree, I wonder if you don't want to corr

Re: MISRA C Rule 20.7 disambiguation

2022-12-09 Thread Jan Beulich
On 09.12.2022 01:45, Stefano Stabellini wrote: > This patch is to start a discussion in regard to rule 20.7 and its > interpretation. During the last MISRA C call we discussed that "our"> > interpretation of the rule means that the following two cases don't need > extra parenthesis: > > #define M

Re: [XEN v1] xen/Arm: Probe the entry point address of an uImage correctly

2022-12-09 Thread Michal Orzel
On 08/12/2022 19:42, Ayan Kumar Halder wrote: > > On 08/12/2022 16:53, Julien Grall wrote: >> Hi, > Hi, >> >> On 08/12/2022 15:24, Michal Orzel wrote: >>> On 08/12/2022 14:51, Julien Grall wrote: Caution: This message originated from an External Source. Use proper caution when opening