Re:

2022-11-17 Thread Michal Orzel
Hi Jimaei, On 18/11/2022 03:00, Jiamei Xie wrote: > > > Date: Thu, 17 Nov 2022 11:07:12 +0800 > Subject: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore > > When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", > Linux SBSA PL011 driver will access PL011 DMACR register

Re: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common

2022-11-17 Thread Jan Beulich
On 18.11.2022 08:23, Wei Chen wrote: >>> -static int __init nodes_cover_memory(void) >>> -{ >>> - unsigned int i; >>> - >>> - for (i = 0; ; i++) { >>> - } >>> - } while (found && start < end); >>> - >>> - if (start < end) { >>> - p

Re: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore

2022-11-17 Thread Michal Orzel
Hi Jiamei, On 18/11/2022 03:18, Jiamei Xie wrote: > > > Hi > > Sorry there is no subject in the last email. So add in this one. I would consider re-pushing this patch(although please wait for some comments). The reason being, a patch without a subject is not picked by patchwork/b4 or other to

Re: [PATCH v2] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-17 Thread Jan Beulich
On 18.11.2022 03:35, Marek Marczykowski-Górecki wrote: > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > According to the PCIe spec, device

RE: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common

2022-11-17 Thread Wei Chen
Hi Jan, > -Original Message- > > to reuse the functions names in common code, we have rename them > > to neutral names as well. > > > > PXM is an ACPI specific item, we can't use it in common code > > directly. As an alternative, we extend the parameters of > > numa_update_node_memblks. Th

Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table

2022-11-17 Thread Jan Beulich
On 17.11.2022 18:31, Marek Marczykowski-Górecki wrote: > On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: >> On 14.11.2022 20:21, Marek Marczykowski-Górecki wrote: >>> --- a/xen/arch/x86/msi.c >>> +++ b/xen/arch/x86/msi.c >>> @@ -961,6 +961,21 @@ static int msix_capability_init(struct p

[qemu-mainline test] 174807: tolerable FAIL - PUSHED

2022-11-17 Thread osstest service owner
flight 174807 qemu-mainline real [real] flight 174810 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/174807/ http://logs.test-lab.xenproject.org/osstest/logs/174810/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-ar

[PATCH v2] xen-pciback: Consider INTx disabled when MSI/MSI-X is enabled

2022-11-17 Thread Marek Marczykowski-Górecki
Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. According to the PCIe spec, device cannot use INTx when MSI/MSI-X is enabled. Change the logic to

RE: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore

2022-11-17 Thread Jiamei Xie
Hi Sorry there is no subject in the last email. So add in this one. Best wishes Jiamei Xie > -Original Message- > From: Jiamei Xie > Sent: Friday, November 18, 2022 10:00 AM > To: xen-devel@lists.xenproject.org > Cc: Jiamei Xie ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis

[no subject]

2022-11-17 Thread Jiamei Xie
Date: Thu, 17 Nov 2022 11:07:12 +0800 Subject: [PATCH] xen/arm: vpl011: Make access to DMACR write-ignore When the guest kernel enables DMA engine with "CONFIG_DMA_ENGINE=y", Linux SBSA PL011 driver will access PL011 DMACR register in some functions. As chapter "B Generic UART" in "ARM Server Base

[xen-unstable-smoke test] 174806: tolerable all pass - PUSHED

2022-11-17 Thread osstest service owner
flight 174806 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/174806/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[linux-linus test] 174804: regressions - FAIL

2022-11-17 Thread osstest service owner
flight 174804 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174804/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

Re: [RFC] docs/misra: List files in Xen originated from external sources

2022-11-17 Thread Stefano Stabellini
On Thu, 17 Nov 2022, Jan Beulich wrote: > On 17.11.2022 11:39, Michal Orzel wrote: > > On 17/11/2022 11:03, Jan Beulich wrote: > >> On 16.11.2022 10:20, Michal Orzel wrote: > >>> --- /dev/null > >>> +++ b/docs/misra/external-files.txt > >>> @@ -0,0 +1,70 @@ > >>> +External files in Xen > >>> +=

Re: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support

2022-11-17 Thread Andrew Cooper
On 15/11/2022 16:12, Roger Pau Monne wrote: > On Tue, Nov 15, 2022 at 12:35:39AM +, Andrew Cooper wrote: >> I was really hoping to avoid this, but its now too late in the 4.17 freeze >> and >> we still don't have working fixes. > The fix I proposed still has some comments that have been unansw

Re: [RFC v2 04/12] xen/arm32: head: Remove restriction where to load Xen

2022-11-17 Thread Julien Grall
Hi Luca, On 25/10/2022 12:56, Luca Fancellu wrote: On 22 Oct 2022, at 16:04, Julien Grall wrote: From: Julien Grall At the moment, bootloaders can load Xen anywhere in memory but the region 2MB - 4MB. While I am not aware of any issue, we have no way to tell the bootloader to avoid that r

Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table

2022-11-17 Thread Marek Marczykowski-Górecki
On Thu, Nov 17, 2022 at 05:34:36PM +0100, Jan Beulich wrote: > On 14.11.2022 20:21, Marek Marczykowski-Górecki wrote: > > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > > on the same page as MSI-X table. Device model (especially one in > > stubdomain) cannot really handle

Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen

2022-11-17 Thread Jason Andryuk
On Wed, Nov 16, 2022 at 10:34 PM Marek Marczykowski-Górecki wrote: > > On Wed, Nov 16, 2022 at 10:40:02PM +0100, Marek Marczykowski-Górecki wrote: > > On Wed, Nov 16, 2022 at 02:15:22PM -0500, Jason Andryuk wrote: > > > On Mon, Nov 14, 2022 at 2:21 PM Marek Marczykowski-Górecki > > > wrote: > > >

Re: [PATCH 2/2] x86/msi: Allow writes to registers on the same page as MSI-X table

2022-11-17 Thread Jan Beulich
On 14.11.2022 20:21, Marek Marczykowski-Górecki wrote: > Some devices (notably Intel Wifi 6 AX210 card) keep auxiliary registers > on the same page as MSI-X table. Device model (especially one in > stubdomain) cannot really handle those, as direct writes to that page is > refused (page is on mmio_r

Re: [PATCH 2/4] tools/tests: Unit test for paging mempool size

2022-11-17 Thread Andrew Cooper
On 17/11/2022 10:39, Jan Beulich wrote: > On 17.11.2022 02:08, Andrew Cooper wrote: >> Exercise some basic functionality of the new >> xc_{get,set}_paging_mempool_size() hypercalls. >> >> This passes on x86, but fails currently on ARM. ARM will be fixed up in >> future patches. >> >> This is part

[PATCH 2/2] automation: Remove installation of packages from test scripts

2022-11-17 Thread Michal Orzel
Now, when these packages are already installed in the respective containers, we can remove them from the test scripts. Signed-off-by: Michal Orzel --- automation/scripts/qemu-alpine-x86_64.sh| 4 automation/scripts/qemu-smoke-dom0-arm32.sh | 8 automation/scripts/qemu-s

[PATCH 0/2] CI improvements

2022-11-17 Thread Michal Orzel
This patch series moves the installation of packages at runtime from the test scripts into the respective containers. This series is based on the CI next branch: https://gitlab.com/xen-project/people/sstabellini/xen/-/tree/next Michal Orzel (2): automation: Install packages required by tests in

[PATCH 1/2] automation: Install packages required by tests in containers

2022-11-17 Thread Michal Orzel
Installation of additional packages from the test scripts when running the tests has some drawbacks. It is slower than cloning containers and can fail due to some network issues (apparently it often happens on x86 rackspace). This patch is adding the packages required by the tests to be installed w

Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size

2022-11-17 Thread Andrew Cooper
On 17/11/2022 10:18, Jan Beulich wrote: > On 17.11.2022 02:08, Andrew Cooper wrote: >> The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: >> >> * All set_allocation() flavours have an overflow-before-widen bug when >>calculating "sc->mb << (20 - PAGE_SHIFT)". >> * All flavo

Re: [PATCH v8 5/6] xen/x86: move NUMA process nodes nodes code from x86 to common

2022-11-17 Thread Jan Beulich
On 14.11.2022 07:34, Wei Chen wrote: > x86 has implemented a set of codes to process NUMA nodes. These > codes will parse NUMA memory and processor information from > ACPI SRAT table. But except some ACPI specific codes, most > of the process code like memory blocks validation, node memory > range

[linux-linus test] 174799: regressions - FAIL

2022-11-17 Thread osstest service owner
flight 174799 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/174799/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-examine 8 reboot fail REGR. vs. 173462 test-arm64-arm64-xl

Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread Marek Marczykowski-Górecki
On Thu, Nov 17, 2022 at 02:33:16PM +0100, Jan Beulich wrote: > On 17.11.2022 14:13, Marek Marczykowski-Górecki wrote: > > On Thu, Nov 17, 2022 at 12:54:51PM +, David Vrabel wrote: > >> On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: > >>> Linux enables MSI-X before disabling INTx, but ke

Re: [PATCH 2/4] tools/tests: Unit test for paging mempool size

2022-11-17 Thread Anthony PERARD
On Thu, Nov 17, 2022 at 01:08:02AM +, Andrew Cooper wrote: > Exercise some basic functionality of the new > xc_{get,set}_paging_mempool_size() hypercalls. > > This passes on x86, but fails currently on ARM. ARM will be fixed up in > future patches. > > This is part of XSA-409 / CVE-2022-3374

Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size

2022-11-17 Thread Anthony PERARD
On Thu, Nov 17, 2022 at 01:08:01AM +, Andrew Cooper wrote: > The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: > > * All set_allocation() flavours have an overflow-before-widen bug when >calculating "sc->mb << (20 - PAGE_SHIFT)". > * All flavours have a granularity of

Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls

2022-11-17 Thread Anthony PERARD
On Thu, Nov 17, 2022 at 01:08:03AM +, Andrew Cooper wrote: > diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c > index 2abaab439c4f..f8f7b7e81837 100644 > --- a/tools/libs/light/libxl_dom.c > +++ b/tools/libs/light/libxl_dom.c > @@ -1448,6 +1448,25 @@ int libxl_userdata_u

Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread Jan Beulich
On 17.11.2022 12:41, Marek Marczykowski-Górecki wrote: > --- a/drivers/xen/xen-pciback/conf_space.c > +++ b/drivers/xen/xen-pciback/conf_space.c > @@ -313,7 +313,7 @@ int xen_pcibk_get_interrupt_type(struct pci_dev *dev) > &val); > if (err) >

Re: [XEN v3 04/12] xen/Arm: vGICv3: Adapt emulation of GICR_TYPER for AArch32

2022-11-17 Thread Michal Orzel
Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > > > Refer ARM DDI 0487I.a ID081822, G8-9650, G8.2.113 > Aff3 does not exist on AArch32. > Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106 > Aff3 does not exist on Armv7 (ie arm32). > > Thus, access to aff3 have been contained with

Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread Jan Beulich
On 17.11.2022 13:28, Andrew Cooper wrote: > On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: >> Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until >> the table is filled. Then it disables INTx just before clearing MASKALL >> bit. Currently this approach is rejected by xen

Re: [XEN v3 02/12] xen/Arm: GICv3: Adapt access to VMPIDR register for AArch32

2022-11-17 Thread Michal Orzel
Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > Refer ARM DDI 0487I.a ID081822, G8-9817, G8.2.169 > Affinity level 3 is not present in AArch32. > Also, refer ARM DDI 0406C.d ID040418, B4-1644, B4.1.106, > Affinity level 3 is not present in Armv7 (ie arm32). > Thus, any access to affinity

Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread Jan Beulich
On 17.11.2022 14:13, Marek Marczykowski-Górecki wrote: > On Thu, Nov 17, 2022 at 12:54:51PM +, David Vrabel wrote: >> On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: >>> Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until >>> the table is filled. Then it disables INTx

Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread Marek Marczykowski-Górecki
On Thu, Nov 17, 2022 at 12:54:51PM +, David Vrabel wrote: > On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: > > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > > the table is filled. Then it disables INTx just before clearing MASKALL > > bit. Currently this appr

Re: [XEN v3 03/12] xen/Arm: vreg: Support vreg_reg64_* helpers on AArch32

2022-11-17 Thread Michal Orzel
Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > In some situations (e.g. GICR_TYPER), the hypervior may need to emulate > 64bit registers in AArch32 mode. In such situations, the hypervisor may > need to read/modify the lower or upper 32 bits of the 64 bit register. > > In AArch32, 'unsi

Re: [XEN v3 01/12] xen/Arm: vGICv3: Sysreg emulation is applicable for AArch64 only

2022-11-17 Thread Michal Orzel
Hi Ayan, On 11/11/2022 15:17, Ayan Kumar Halder wrote: > Sysreg emulation is 64-bit specific, so guard the calls to > vgic_v3_emulate_sysreg() as well as the function itself with > "#ifdef CONFIG_ARM_64". > > Signed-off-by: Ayan Kumar Halder Reviewed-by: Michal Orzel ~Michal

Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread David Vrabel
On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. Allow setting PCI_MSIX_FLAGS_ENABLE while

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Michal Orzel
On 17/11/2022 10:53, Michal Orzel wrote: > > > Hi Julien, > > On 17/11/2022 10:29, Julien Grall wrote: >> >> >> On 17/11/2022 08:34, Michal Orzel wrote: >>> Hi Julien, >>> >>> On 16/11/2022 19:37, Julien Grall wrote: Hi Michal, On 16/11/2022 18:05, Michal Orzel wrote:

Re: [PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread Andrew Cooper
On 17/11/2022 11:41, Marek Marczykowski-Górecki wrote: > Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until > the table is filled. Then it disables INTx just before clearing MASKALL > bit. Currently this approach is rejected by xen-pciback. > Allow setting PCI_MSIX_FLAGS_ENABLE

[PATCH] xen-pciback: Consider MSI-X enabled only when MASKALL bit is cleared

2022-11-17 Thread Marek Marczykowski-Górecki
Linux enables MSI-X before disabling INTx, but keeps MSI-X masked until the table is filled. Then it disables INTx just before clearing MASKALL bit. Currently this approach is rejected by xen-pciback. Allow setting PCI_MSIX_FLAGS_ENABLE while INTx is still enabled as long as PCI_MSIX_FLAGS_MASKALL

Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0

2022-11-17 Thread Andrew Cooper
On 17/11/2022 09:27, Jan Beulich wrote: > On 16.11.2022 17:42, Roger Pau Monne wrote: >> Currently Xen will passthrough any Local APIC NMI Structure found in >> the native ACPI MADT table to a PVH dom0. This is wrong because PVH >> doesn't have access to the physical local APIC, and instead gets a

Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen

2022-11-17 Thread Marek Marczykowski-Górecki
On Thu, Nov 17, 2022 at 09:04:40AM +0100, Jan Beulich wrote: > On 17.11.2022 04:34, Marek Marczykowski-Górecki wrote: > > Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't > > disabled at this point yet. And apparently I was testing this with > > permissive=1... > > > > Linu

Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0

2022-11-17 Thread Jan Beulich
On 17.11.2022 11:23, Roger Pau Monné wrote: > On Thu, Nov 17, 2022 at 10:27:41AM +0100, Jan Beulich wrote: >> On 16.11.2022 17:42, Roger Pau Monne wrote: >>> Currently Xen will passthrough any Local APIC NMI Structure found in >>> the native ACPI MADT table to a PVH dom0. This is wrong because PVH

Xen 4.15.4 released

2022-11-17 Thread Jan Beulich
All, we're pleased to announce the release of Xen 4.15.4. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.15 (tag RELEASE-4.15.4) or from the XenProject download page https://xenproject.org/downloads/xen-project-archiv

Re: [RFC] docs/misra: List files in Xen originated from external sources

2022-11-17 Thread Jan Beulich
On 17.11.2022 11:39, Michal Orzel wrote: > On 17/11/2022 11:03, Jan Beulich wrote: >> On 16.11.2022 10:20, Michal Orzel wrote: >>> --- /dev/null >>> +++ b/docs/misra/external-files.txt >>> @@ -0,0 +1,70 @@ >>> +External files in Xen >>> += >>> + >>> +The following table lists fi

Re: [PATCH 2/4] tools/tests: Unit test for paging mempool size

2022-11-17 Thread Jan Beulich
On 17.11.2022 02:08, Andrew Cooper wrote: > Exercise some basic functionality of the new > xc_{get,set}_paging_mempool_size() hypercalls. > > This passes on x86, but fails currently on ARM. ARM will be fixed up in > future patches. > > This is part of XSA-409 / CVE-2022-33747. > > Signed-off-by

Re: [RFC] docs/misra: List files in Xen originated from external sources

2022-11-17 Thread Michal Orzel
Hi Jan, Thanks for looking at it. On 17/11/2022 11:03, Jan Beulich wrote: > > > On 16.11.2022 10:20, Michal Orzel wrote: >> --- /dev/null >> +++ b/docs/misra/external-files.txt >> @@ -0,0 +1,70 @@ >> +External files in Xen >> += >> + >> +The following table lists files prese

Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0

2022-11-17 Thread Roger Pau Monné
On Thu, Nov 17, 2022 at 10:27:41AM +0100, Jan Beulich wrote: > On 16.11.2022 17:42, Roger Pau Monne wrote: > > Currently Xen will passthrough any Local APIC NMI Structure found in > > the native ACPI MADT table to a PVH dom0. This is wrong because PVH > > doesn't have access to the physical local

[libvirt test] 174798: tolerable all pass - PUSHED

2022-11-17 Thread osstest service owner
flight 174798 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/174798/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-checkfail like 174787 test-armhf-armhf-libvirt-raw 15 saveresto

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Bertrand Marquis
Hi Julien, > On 17 Nov 2022, at 10:11, Julien Grall wrote: > > Hi, > > On 17/11/2022 09:53, Michal Orzel wrote: >> On 17/11/2022 10:29, Julien Grall wrote: >>> >>> >>> On 17/11/2022 08:34, Michal Orzel wrote: Hi Julien, On 16/11/2022 19:37, Julien Grall wrote: > > >>

Re: [PATCH 1/4] xen: Introduce non-broken hypercalls for the paging mempool size

2022-11-17 Thread Jan Beulich
On 17.11.2022 02:08, Andrew Cooper wrote: > The existing XEN_DOMCTL_SHADOW_OP_{GET,SET}_ALLOCATION have problems: > > * All set_allocation() flavours have an overflow-before-widen bug when >calculating "sc->mb << (20 - PAGE_SHIFT)". > * All flavours have a granularity of 1M. This was tolera

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Julien Grall
Hi, On 17/11/2022 09:53, Michal Orzel wrote: On 17/11/2022 10:29, Julien Grall wrote: On 17/11/2022 08:34, Michal Orzel wrote: Hi Julien, On 16/11/2022 19:37, Julien Grall wrote: Hi Michal, On 16/11/2022 18:05, Michal Orzel wrote: On 16/11/2022 16:56, Julien Grall wrote: On 16/11/20

[xen-unstable test] 174797: tolerable FAIL - PUSHED

2022-11-17 Thread osstest service owner
flight 174797 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/174797/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 174791 test-amd64-i386-xl-qemuu-win7-amd64

Re: [RFC] docs/misra: List files in Xen originated from external sources

2022-11-17 Thread Jan Beulich
On 16.11.2022 10:20, Michal Orzel wrote: > --- /dev/null > +++ b/docs/misra/external-files.txt > @@ -0,0 +1,70 @@ > +External files in Xen > += > + > +The following table lists files present in the Xen codebase that originated > +from external sources e.g. Linux kernel. The purp

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Michal Orzel
Hi Julien, On 17/11/2022 10:29, Julien Grall wrote: > > > On 17/11/2022 08:34, Michal Orzel wrote: >> Hi Julien, >> >> On 16/11/2022 19:37, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 16/11/2022 18:05, Michal Orzel wrote: On 16/11/2022 16:56, Julien Grall wrote: > > >

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Julien Grall
On 17/11/2022 09:44, Bertrand Marquis wrote: Hi, On 17 Nov 2022, at 09:29, Julien Grall wrote: On 17/11/2022 08:34, Michal Orzel wrote: Hi Julien, On 16/11/2022 19:37, Julien Grall wrote: Hi Michal, On 16/11/2022 18:05, Michal Orzel wrote: On 16/11/2022 16:56, Julien Grall wrote:

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Bertrand Marquis
Hi, > On 17 Nov 2022, at 09:29, Julien Grall wrote: > > > > On 17/11/2022 08:34, Michal Orzel wrote: >> Hi Julien, >> On 16/11/2022 19:37, Julien Grall wrote: >>> >>> >>> Hi Michal, >>> >>> On 16/11/2022 18:05, Michal Orzel wrote: On 16/11/2022 16:56, Julien Grall wrote: > >

[PATCH v4 1/3] automation: Create Yocto docker images

2022-11-17 Thread Bertrand Marquis
Add containers suitable to run yocto kirkstone build based on ubuntu 22.04. It contains all packages required by Yocto and a checkout of the layers required to build Xen with Yocto. Add a generic docker image template to be used to automatically generate docker files for different configurations:

[PATCH v4 3/3] automation: Add CI test jobs for Yocto

2022-11-17 Thread Bertrand Marquis
From: Michal Orzel Populate test jobs for Yocto based tests using the provided containers. Due to the size restrictions, it is currently not possible to split the build and run tasks, therefore everything is done in a single step. Test jobs for the supported Yocto targets are generic to avoid th

[PATCH v4 2/3] automation: Add a clean rule for containers

2022-11-17 Thread Bertrand Marquis
Add make clean support to remove the containers from the local docker registry: - make clean: remove all images - clean-yocto/kirkstone-qemuarm: remove yocto kirkstone for qemuarm image Signed-off-by: Bertrand Marquis --- Changes in v4: - also generate clean rule for CONTAINERS_EXTRA Changes in v

[PATCH v4 0/3] Yocto Gitlab CI

2022-11-17 Thread Bertrand Marquis
This patch series is a first attempt to check if we could use Yocto in gitlab ci to build and run xen on qemu for arm, arm64 and x86. The first patch is introducing a container template from which container files can be generated for all combinations we want to support (qemu arm, arm64 and x86 tar

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Julien Grall
On 17/11/2022 08:34, Michal Orzel wrote: Hi Julien, On 16/11/2022 19:37, Julien Grall wrote: Hi Michal, On 16/11/2022 18:05, Michal Orzel wrote: On 16/11/2022 16:56, Julien Grall wrote: On 16/11/2022 14:45, Michal Orzel wrote: Hi Julien, Hi Michal, and use it in the pl011-debug

Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0

2022-11-17 Thread Jan Beulich
On 16.11.2022 17:42, Roger Pau Monne wrote: > Currently Xen will passthrough any Local APIC NMI Structure found in > the native ACPI MADT table to a PVH dom0. This is wrong because PVH > doesn't have access to the physical local APIC, and instead gets an > emulated local APIC by Xen, that doesn't

Re: [PATCH v2] x86/irq: do not release irq until all cleanup is done

2022-11-17 Thread Jan Beulich
On 16.11.2022 13:21, Roger Pau Monne wrote: > Current code in _clear_irq_vector() will mark the irq as unused before > doing the cleanup required when move_in_progress is true. > > This can lead to races in create_irq() if the function picks an irq > desc that's been marked as unused but has move_

Re: [PATCH] xen/arm: debug-pl011.inc: Use macros instead of hardcoded values

2022-11-17 Thread Michal Orzel
Hi Julien, On 16/11/2022 19:37, Julien Grall wrote: > > > Hi Michal, > > On 16/11/2022 18:05, Michal Orzel wrote: >> On 16/11/2022 16:56, Julien Grall wrote: >>> >>> >>> On 16/11/2022 14:45, Michal Orzel wrote: Hi Julien, >>> >>> Hi Michal, >>> > >> and use it in the pl011-debug fi

Re: [PATCH for-4.17] x86/hvm: Revert per-domain APIC acceleration support

2022-11-17 Thread Jan Beulich
On 16.11.2022 19:14, Andrew Cooper wrote: > On 15/11/2022 08:49, Jan Beulich wrote: >> On 15.11.2022 01:35, Andrew Cooper wrote: >>> I was really hoping to avoid this, but its now too late in the 4.17 freeze >>> and >>> we still don't have working fixes. >>> >>> The in-Xen calculations for assista

Re: [PATCH 3/4] xen/arm, libxl: Revert XEN_DOMCTL_shadow_op; use p2m mempool hypercalls

2022-11-17 Thread Jan Beulich
On 17.11.2022 00:41, Andrew Cooper wrote: > On 16/11/2022 08:30, Jan Beulich wrote: >> On 16.11.2022 03:00, Stefano Stabellini wrote: >>> On Wed, 16 Nov 2022, Andrew Cooper wrote: On 16/11/2022 01:37, Stefano Stabellini wrote: > On Wed, 26 Oct 2022, Andrew Cooper wrote: >> This reverts

Re: [PATCH 2/2] Do not access /dev/mem in MSI-X PCI passthrough on Xen

2022-11-17 Thread Jan Beulich
On 17.11.2022 04:34, Marek Marczykowski-Górecki wrote: > Ok, I found what is wrong. Enabling MSI-X is refused, because INTx isn't > disabled at this point yet. And apparently I was testing this with > permissive=1... > > Linux does this: > https://github.com/torvalds/linux/blob/master/drivers/pci/