Re: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static

2022-07-25 Thread Jan Beulich
On 26.07.2022 04:57, Penny Zheng wrote: >> -Original Message- >> From: Jan Beulich >> Sent: Monday, July 25, 2022 11:36 PM >> >> On 20.07.2022 07:46, Penny Zheng wrote: >>> Today when a domain unpopulates the memory on runtime, they will >>> always hand the memory back to the heap allocato

[libvirt test] 171860: regressions - FAIL

2022-07-25 Thread osstest service owner
flight 171860 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171860/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH] x86/pv: Inject #GP for implicit grant unmaps

2022-07-25 Thread Jan Beulich
On 25.07.2022 19:50, Andrew Cooper wrote: > This is a debug behaviour to identify buggy kernels. Crashing the domain is > the most unhelpful thing to do, because it discards the relevant context. > > Instead, inject #GP[0] like other permission errors in x86. In particular, > this lets the kerne

Re: [PATCH v3] livepatch: create-diff-object: Check that the section has a secsym

2022-07-25 Thread Jan Beulich
On 25.07.2022 19:13, Sarah Newman wrote: > A STT_SECTION symbol is not needed if if it is not used as a relocation > target. Therefore, a section, in this case a debug section, may not have > a secsym associated with it. > > Signed-off-by: Bill Wendling Hmm - this wasn't here before. Does this t

Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-25 Thread Jan Beulich
On 26.07.2022 02:33, Stefano Stabellini wrote: > On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: >> On 7/25/22 09:32, Jan Beulich wrote: >>> On 24.07.2022 19:20, Xenia Ragiadakou wrote: On 7/7/22 10:55, Jan Beulich wrote: > On 07.07.2022 09:27, Xenia Ragiadakou wrote: >> On 7/6/22 11:51,

Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE

2022-07-25 Thread Michel Lespinasse
On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > Xeons") wrecked intel_idle in two ways: > > - must not have tracing in idle functions > - must return with IRQs disabled > > Additionally, it added a branch for n

Re: [PATCH v3 00/10] Add Xue - console over USB 3 Debug Capability

2022-07-25 Thread Jan Beulich
On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > This is integration of https://github.com/connojd/xue into mainline Xen. > This patch series includes several patches that I made in the process, some > are > very loosely related. > > The driver developed by Connor supports console via USB

Re: [PATCH v4 2/2] xen/arm: add FF-A mediator

2022-07-25 Thread Jens Wiklander
Hi Julien, On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote: > > Hi Jens, > > I haven't checked whether the FFA driver is complaint with the spec. I > mainly checked whether the code makes sense from Xen PoV. > > This is a fairly long patch to review. So I will split my review in > multiple sess

Re: [PATCH] page-alloc: fix initialization of cross-node regions

2022-07-25 Thread Jan Beulich
On 25.07.2022 20:54, Andrew Cooper wrote: > On 25/07/2022 14:10, Jan Beulich wrote: >> Quite obviously to determine the split condition successive pages' >> attributes need to be evaluated, not always those of the initial page. >> >> Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() i

[PATCH v3 10/10] driver/char: add RX support to the XHCI driver

2022-07-25 Thread Marek Marczykowski-Górecki
Add another work ring buffer for received data, and point IN TRB at it. Ensure there is always at least one pending IN TRB, so the controller has a way to send incoming data to the driver. Note that both "success" and "short packet" completion codes are okay - in fact it will be "short packet" most

[PATCH v3 09/10] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC

2022-07-25 Thread Marek Marczykowski-Górecki
That's possible, because the capability was designed specifically to allow separate driver handle it, in parallel to unmodified xhci driver (separate set of registers, pretending the port is "disconnected" for the main xhci driver etc). It works with Linux dom0, although requires an awful hack - re

[PATCH v3 08/10] drivers/char: mark DMA buffers as reserved for the XHCI

2022-07-25 Thread Marek Marczykowski-Górecki
The important part is to include those buffers in IOMMU page table relevant for the USB controller. Otherwise, DbC will stop working as soon as IOMMU is enabled, regardless of to which domain device assigned (be it xen or dom0). If the device is passed through to dom0 or other domain (see later pat

[PATCH v3 07/10] IOMMU/AMD: wire common device reserved memory API

2022-07-25 Thread Marek Marczykowski-Górecki
Register common device reserved memory similar to how ivmd= parameter is handled. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - use variable initializer - use pfn_to_paddr() --- xen/drivers/passthrough/amd/iommu_acpi.c | 21 + 1 file changed, 21 insertions(

[PATCH v3 06/10] IOMMU/VT-d: wire common device reserved memory API

2022-07-25 Thread Marek Marczykowski-Górecki
Re-use rmrr= parameter handling code to handle common device reserved memory. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR --- xen/drivers/passthrough/vtd/dmar.c | 201 +- 1 file change

[PATCH v3 05/10] IOMMU: add common API for device reserved memory

2022-07-25 Thread Marek Marczykowski-Górecki
Add API similar to rmrr= and ivmd= arguments, but in a common code. This will allow drivers to register reserved memory regardless of the IOMMU vendor. The direct reason for this API is xhci-dbc console driver (aka xue), that needs to use DMA. But future change may unify command line arguments for

[PATCH v3 03/10] drivers/char: add support for selecting specific xhci

2022-07-25 Thread Marek Marczykowski-Górecki
Handle parameters similar to dbgp=ehci. Implement this by not resettting dbc->sbdf again in dbc_init_xhc(), but using a value found there if non-zero. Additionally, add xue->xhc_num to select n-th controller. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich --- Changes in v3:

[PATCH v3 04/10] console: support multiple serial console simultaneously

2022-07-25 Thread Marek Marczykowski-Górecki
Previously only one serial console was supported at the same time. Using console=com1,dbgp,vga silently ignored all but last serial console (in this case: only dbgp and vga were active). Fix this by storing not a single sercon_handle, but an array of them, up to MAX_SERCONS entries. The value of M

[PATCH v3 02/10] drivers/char: reset XHCI ports when initializing dbc

2022-07-25 Thread Marek Marczykowski-Górecki
Reset ports, to force host system to re-enumerate devices. Otheriwse it will require the cable to be re-plugged, or will wait in the "configuring" state indefinitely. Trick and code copied from Linux: drivers/usb/early/xhci-dbc.c:xdbc_start()->xdbc_reset_debug_port() Signed-off-by: Marek Marczyko

[PATCH v3 00/10] Add Xue - console over USB 3 Debug Capability

2022-07-25 Thread Marek Marczykowski-Górecki
This is integration of https://github.com/connojd/xue into mainline Xen. This patch series includes several patches that I made in the process, some are very loosely related. The driver developed by Connor supports console via USB3 debug capability. The capability is designed to operate mostly ind

[PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger

2022-07-25 Thread Marek Marczykowski-Górecki
From: Connor Davis [Connor] Xue is a cross-platform USB 3 debugger that drives the Debug Capability (DbC) of xHCI-compliant host controllers. This patch implements the operations needed for xue to initialize the host controller's DbC and communicate with it. It also implements a struct uart_drive

RE: [PATCH v9 2/8] xen: do not free reserved memory into heap

2022-07-25 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Monday, July 25, 2022 11:30 PM > To: Penny Zheng > Cc: Wei Chen ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis > ; Volodymyr Babchuk > ; Andrew Cooper > ; George Dunlap ; > Wei Liu ; xen-devel@lists.xenproject.org > Subjec

RE: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static

2022-07-25 Thread Penny Zheng
Hi Jan > -Original Message- > From: Jan Beulich > Sent: Monday, July 25, 2022 11:36 PM > To: Penny Zheng > Cc: Wei Chen ; Andrew Cooper > ; George Dunlap ; > Julien Grall ; Stefano Stabellini ; > Wei Liu ; xen-devel@lists.xenproject.org > Subject: Re: [PATCH v9 6/8] xen/arm: unpopulate m

[ovmf test] 171858: all pass - PUSHED

2022-07-25 Thread osstest service owner
flight 171858 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171858/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7f1c89f16790fc2fa8bc88330dc896941b9b40bb baseline version: ovmf a47241f1337c2ce78179b

Re: Licensing issues

2022-07-25 Thread Stefano Stabellini
On Fri, 22 Jul 2022, Andrew Cooper wrote: > I'm also intending to start using SDPX identifiers to save on all the > boilerplate.  They're already used elsewhere. I just wanted to add that adding/using SPDX is important and came up quite a few times in Linux Foundation discussions recently [1]. Lin

Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-25 Thread Stefano Stabellini
On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: > On 7/25/22 09:32, Jan Beulich wrote: > > On 24.07.2022 19:20, Xenia Ragiadakou wrote: > > > On 7/7/22 10:55, Jan Beulich wrote: > > > > On 07.07.2022 09:27, Xenia Ragiadakou wrote: > > > > > On 7/6/22 11:51, Jan Beulich wrote: > > > > > > On 06.07.2022

[xen-unstable test] 171856: tolerable FAIL - PUSHED

2022-07-25 Thread osstest service owner
flight 171856 xen-unstable real [real] flight 171857 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171856/ http://logs.test-lab.xenproject.org/osstest/logs/171857/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

Re: Enable audio virtualization in Xen

2022-07-25 Thread Christopher Clark
On Mon, Jul 25, 2022 at 4:45 AM SHARMA, JYOTIRMOY wrote: > > [AMD Official Use Only - General] > > > Hi all, Hi Jyotirmoy, I have add the xen-users list to CC since this thread may be useful to that forum. > I am using ubuntu as dom 0 and also dom U (HVM). I want to play audio from > “dom U” U

Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-25 Thread Boris Ostrovsky
On 7/25/22 6:03 AM, Jane Malalane wrote: On 18/07/2022 14:59, Boris Ostrovsky wrote: On 7/18/22 4:56 AM, Andrew Cooper wrote: On 15/07/2022 14:10, Boris Ostrovsky wrote: On 7/15/22 5:50 AM, Andrew Cooper wrote: On 15/07/2022 09:18, Jane Malalane wrote: On 14/07/2022 00:27, Boris Ostrovsky

Re: [PATCH] page-alloc: fix initialization of cross-node regions

2022-07-25 Thread Andrew Cooper
On 25/07/2022 14:10, Jan Beulich wrote: > Quite obviously to determine the split condition successive pages' > attributes need to be evaluated, not always those of the initial page. > > Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in heap init") > Signed-off-by: Jan Beulich > --

[ovmf test] 171855: all pass - PUSHED

2022-07-25 Thread osstest service owner
flight 171855 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171855/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a47241f1337c2ce78179b7db939faebd7828d8d0 baseline version: ovmf 8a5782d704cfeb78aafde

[PATCH] x86/pv: Inject #GP for implicit grant unmaps

2022-07-25 Thread Andrew Cooper
This is a debug behaviour to identify buggy kernels. Crashing the domain is the most unhelpful thing to do, because it discards the relevant context. Instead, inject #GP[0] like other permission errors in x86. In particular, this lets the kernel provide a backtrace that's actually helpful to a d

[IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel

2022-07-25 Thread Smith, Jackson
Hi Stefano, My colleague Jason Lei and I would like to submit a patch to imagebuilder. It seems that generating a .fit with a true dom0less configuration fails because an extraneous comma is included in the its file. We believe this change resolves the issue. Thanks, Jackson -- >8 -- Remove

[PATCH v3] livepatch: create-diff-object: Check that the section has a secsym

2022-07-25 Thread Sarah Newman
A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it. Signed-off-by: Bill Wendling Origin: https://github.com/dynup/kpatch.git ba3defa06073 Signed-off-by: Sarah Newman Reviewed

[xen-unstable-smoke test] 171854: tolerable all pass - PUSHED

2022-07-25 Thread osstest service owner
flight 171854 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171854/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] page-alloc: fix initialization of cross-node regions

2022-07-25 Thread Jan Beulich
On 25.07.2022 18:05, Julien Grall wrote: > (Sorry for the formatting) No issues seen. > On Mon, 25 Jul 2022, 14:10 Jan Beulich, wrote: > >> Quite obviously to determine the split condition successive pages' >> attributes need to be evaluated, not always those of the initial page. >> >> Fixes: 7

Re: Random crash during guest start on x86

2022-07-25 Thread Jan Beulich
On 25.07.2022 17:51, Bertrand Marquis wrote: > On our CI we have randomly a crash during guest boot on x86. Afaict of a PV guest. > We are running on qemu x86_64 using Xen staging. Which may introduce unusual timing. An issue never hit on actual hardware _may_ (but doesn't have to be) one in qem

Re: [PATCH] page-alloc: fix initialization of cross-node regions

2022-07-25 Thread Julien Grall
Hi Jan, (Sorry for the formatting) On Mon, 25 Jul 2022, 14:10 Jan Beulich, wrote: > Quite obviously to determine the split condition successive pages' > attributes need to be evaluated, not always those of the initial page. > > Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in

Re: Random crash during guest start on x86

2022-07-25 Thread Andrew Cooper
On 25/07/2022 16:51, Bertrand Marquis wrote: > Hi, > > On our CI we have randomly a crash during guest boot on x86. > > We are running on qemu x86_64 using Xen staging. > The crash is happening randomly (something like 1 out of 20 times). > > This is always happening on the first guest we start, we

Random crash during guest start on x86

2022-07-25 Thread Bertrand Marquis
Hi, On our CI we have randomly a crash during guest boot on x86. We are running on qemu x86_64 using Xen staging. The crash is happening randomly (something like 1 out of 20 times). This is always happening on the first guest we start, we never got it after first guest was successfully started.

Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and...

2022-07-25 Thread Jan Beulich
On 20.07.2022 20:44, Julien Grall wrote: > From: Julien Grall > > move it to Kconfig. > > The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide > helpers to map/unmap a domain page. Rename it to the define to > CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not re

Re: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap

2022-07-25 Thread Jan Beulich
On 20.07.2022 07:46, Penny Zheng wrote: > When a static domain populates memory through populate_physmap at runtime, > it shall retrieve reserved pages from resv_page_list to make sure that > guest RAM is still restricted in statically configured memory regions. > This commit also introduces a new

Re: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static

2022-07-25 Thread Jan Beulich
On 20.07.2022 07:46, Penny Zheng wrote: > Today when a domain unpopulates the memory on runtime, they will always > hand the memory back to the heap allocator. And it will be a problem if domain > is static. > > Pages as guest RAM for static domain shall be reserved to only this domain > and not b

Re: [PATCH v9 2/8] xen: do not free reserved memory into heap

2022-07-25 Thread Jan Beulich
On 20.07.2022 07:46, Penny Zheng wrote: > Pages used as guest RAM for static domain, shall be reserved to this > domain only. > So in case reserved pages being used for other purpose, users > shall not free them back to heap, even when last ref gets dropped. > > This commit introduces a new helper

Re: [PATCH] common/memory: Fix ifdefs for ptdom_max_order

2022-07-25 Thread Jan Beulich
On 25.07.2022 16:44, Luca Fancellu wrote: > In common/memory.c the ifdef code surrounding ptdom_max_order is > using HAS_PASSTHROUGH instead of CONFIG_HAS_PASSTHROUGH, fix the > problem using the correct macro. > > Fixes: e0d44c1f9461 ("build: convert HAS_PASSTHROUGH use to Kconfig") > Signed-off-

[PATCH] arm/domain: fix comment for arch_set_info_guest

2022-07-25 Thread Luca Fancellu
The function arch_set_info_guest is not reached anymore through VCPUOP_initialise on arm, update the comment. Signed-off-by: Luca Fancellu --- xen/arch/arm/domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2f8ea

[PATCH] common/memory: Fix ifdefs for ptdom_max_order

2022-07-25 Thread Luca Fancellu
In common/memory.c the ifdef code surrounding ptdom_max_order is using HAS_PASSTHROUGH instead of CONFIG_HAS_PASSTHROUGH, fix the problem using the correct macro. Fixes: e0d44c1f9461 ("build: convert HAS_PASSTHROUGH use to Kconfig") Signed-off-by: Luca Fancellu --- xen/common/memory.c | 6 +++---

[PATCH] page-alloc: fix initialization of cross-node regions

2022-07-25 Thread Jan Beulich
Quite obviously to determine the split condition successive pages' attributes need to be evaluated, not always those of the initial page. Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in heap init") Signed-off-by: Jan Beulich --- Part of the problem was already introduced in 24a

Re: [PATCH] include: correct re-building conditions around hypercall-defs.h

2022-07-25 Thread Jan Beulich
On 25.07.2022 14:24, Anthony PERARD wrote: > On Mon, Jul 25, 2022 at 02:08:04PM +0200, Jan Beulich wrote: >> For a .cmd file to be picked up, the respective target needs to be >> listed in $(targets). This wasn't the case for hypercall-defs.i, leading >> to permanent re-building even on an entirely

Re: [PATCH] x86: limit issuing of IBPB during context switch

2022-07-25 Thread Jan Beulich
On 25.07.2022 14:15, Andrew Cooper wrote: > On 25/07/2022 13:09, Jan Beulich wrote: >> When the outgoing vCPU had IBPB issued upon entering Xen there's no >> need for a 2nd barrier during context switch. >> >> Signed-off-by: Jan Beulich > > That's already accounted for by opt_ibpb_ctxt_switch con

Re: [PATCH] include: correct re-building conditions around hypercall-defs.h

2022-07-25 Thread Anthony PERARD
On Mon, Jul 25, 2022 at 02:08:04PM +0200, Jan Beulich wrote: > For a .cmd file to be picked up, the respective target needs to be > listed in $(targets). This wasn't the case for hypercall-defs.i, leading > to permanent re-building even on an entirely unchanged tree (because of > the command appare

Re: [PATCH] x86: limit issuing of IBPB during context switch

2022-07-25 Thread Andrew Cooper
On 25/07/2022 13:09, Jan Beulich wrote: > When the outgoing vCPU had IBPB issued upon entering Xen there's no > need for a 2nd barrier during context switch. > > Signed-off-by: Jan Beulich That's already accounted for by opt_ibpb_ctxt_switch conditionally being not set. ~Andrew

[PATCH] x86: limit issuing of IBPB during context switch

2022-07-25 Thread Jan Beulich
When the outgoing vCPU had IBPB issued upon entering Xen there's no need for a 2nd barrier during context switch. Signed-off-by: Jan Beulich --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2098,7 +2098,8 @@ void context_switch(struct vcpu *prev, s ctxt_switch_levelling(nex

[PATCH] include: correct re-building conditions around hypercall-defs.h

2022-07-25 Thread Jan Beulich
For a .cmd file to be picked up, the respective target needs to be listed in $(targets). This wasn't the case for hypercall-defs.i, leading to permanent re-building even on an entirely unchanged tree (because of the command apparently having changed). Fixes: eca1f00d0227 ("xen: generate hypercall

Enable audio virtualization in Xen

2022-07-25 Thread SHARMA, JYOTIRMOY
[AMD Official Use Only - General] Hi all, I am using ubuntu as dom 0 and also dom U (HVM). I want to play audio from "dom U" Ubuntu. I am new to Xen/virtualization in general. >From various reading I understood that I need to take following approach: 1. Use Xen front end ALSA driver in dom

Re: [PATCH] Arm32: restore proper name of .dtb section start symbol

2022-07-25 Thread Bertrand Marquis
Hi Jan, > On 25 Jul 2022, at 11:12, Jan Beulich wrote: > > This addresses a build failure when CONFIG_DTB_FILE evaluates to a non- > empty string. > > Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the > physical address of a symbol") > Signed-off-by: Jan Beulich Reviewed-

[PATCH] Arm32: restore proper name of .dtb section start symbol

2022-07-25 Thread Jan Beulich
This addresses a build failure when CONFIG_DTB_FILE evaluates to a non- empty string. Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the physical address of a symbol") Signed-off-by: Jan Beulich --- Of course this really would be a prime candidate for avoiding the use of link

Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-25 Thread Andrew Cooper
On 18/07/2022 14:59, Boris Ostrovsky wrote: > > On 7/18/22 4:56 AM, Andrew Cooper wrote: >> On 15/07/2022 14:10, Boris Ostrovsky wrote: >>> On 7/15/22 5:50 AM, Andrew Cooper wrote: On 15/07/2022 09:18, Jane Malalane wrote: > On 14/07/2022 00:27, Boris Ostrovsky wrote: >>>     xen_h

Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector

2022-07-25 Thread Jane Malalane
On 18/07/2022 14:59, Boris Ostrovsky wrote: > > On 7/18/22 4:56 AM, Andrew Cooper wrote: >> On 15/07/2022 14:10, Boris Ostrovsky wrote: >>> On 7/15/22 5:50 AM, Andrew Cooper wrote: On 15/07/2022 09:18, Jane Malalane wrote: > On 14/07/2022 00:27, Boris Ostrovsky wrote: >>>     xen_

[xen-unstable test] 171848: tolerable FAIL

2022-07-25 Thread osstest service owner
flight 171848 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171848/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail pass in 171823 test-amd64-i386-libvirt

Re: [PATCH] xen/hypfs: check the return value of snprintf to avoid leaking stack accidently

2022-07-25 Thread Jan Beulich
On 25.07.2022 10:22, Xenia Ragiadakou wrote: > > On 7/25/22 11:00, Jan Beulich wrote: >> On 24.07.2022 19:31, Xenia Ragiadakou wrote: >>> The function snprintf() returns the number of characters that would have >>> been >>> written in the buffer if the buffer size had been sufficiently large, >>>

Re: [PATCH] xen/hypfs: check the return value of snprintf to avoid leaking stack accidently

2022-07-25 Thread Xenia Ragiadakou
On 7/25/22 11:00, Jan Beulich wrote: On 24.07.2022 19:31, Xenia Ragiadakou wrote: The function snprintf() returns the number of characters that would have been written in the buffer if the buffer size had been sufficiently large, not counting the terminating null character. Hence, the value re

Re: [PATCH v2] livepatch: create-diff-object: Check that the section has a secsym

2022-07-25 Thread Jan Beulich
On 25.07.2022 05:20, Sarah Newman wrote: > A STT_SECTION symbol is not needed if if it is not used as a relocation > target. Therefore, a section, in this case a debug section, may not have > a secsym associated with it. > > Origin: https://github.com/dynup/kpatch.git ba3defa06073 > Signed-off-by:

Re: [PATCH] xen/hypfs: check the return value of snprintf to avoid leaking stack accidently

2022-07-25 Thread Jan Beulich
On 24.07.2022 19:31, Xenia Ragiadakou wrote: > The function snprintf() returns the number of characters that would have been > written in the buffer if the buffer size had been sufficiently large, > not counting the terminating null character. > Hence, the value returned is not guaranteed to be sma

Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation

2022-07-25 Thread Xenia Ragiadakou
On 7/25/22 09:32, Jan Beulich wrote: On 24.07.2022 19:20, Xenia Ragiadakou wrote: On 7/7/22 10:55, Jan Beulich wrote: On 07.07.2022 09:27, Xenia Ragiadakou wrote: On 7/6/22 11:51, Jan Beulich wrote: On 06.07.2022 10:43, Xenia Ragiadakou wrote: On 7/6/22 10:10, Jan Beulich wrote: On 05.07.

Re: [PATCH v1 05/18] x86: refactor xen cmdline into general framework

2022-07-25 Thread Jan Beulich
On 22.07.2022 15:12, Daniel P. Smith wrote: > On 7/19/22 09:26, Jan Beulich wrote: >> On 06.07.2022 23:04, Daniel P. Smith wrote: >>> --- a/xen/include/xen/bootinfo.h >>> +++ b/xen/include/xen/bootinfo.h >>> @@ -53,6 +53,17 @@ struct __packed boot_info { >>> >>> extern struct boot_info *boot_inf

Re: [PATCH v1 02/18] introduction of generalized boot info

2022-07-25 Thread Jan Beulich
On 22.07.2022 18:01, Daniel P. Smith wrote: > On 7/21/22 12:00, Jan Beulich wrote: >> On 21.07.2022 16:28, Daniel P. Smith wrote: >>> On 7/19/22 09:11, Jan Beulich wrote: On 06.07.2022 23:04, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/arch/x86/include/asm/bootinfo.h > @@ -0