Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Jan Beulich
On 26.05.2022 21:57, Stefano Stabellini wrote: > On Thu, 26 May 2022, Bertrand Marquis wrote: >>> On 26 May 2022, at 11:15, Jan Beulich wrote: >>> On 26.05.2022 11:54, Bertrand Marquis wrote: > On 26 May 2022, at 10:43, Jan Beulich wrote: > On 26.05.2022 03:02, Stefano Stabellini wrote: >

[linux-linus test] 170750: regressions - FAIL

2022-05-26 Thread osstest service owner
flight 170750 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170750/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-do

[qemu-mainline test] 170749: tolerable FAIL - PUSHED

2022-05-26 Thread osstest service owner
flight 170749 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/170749/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail like 170741 test-amd64-amd64-xl-qemuu-win7-amd6

[xen-unstable test] 170747: tolerable FAIL

2022-05-26 Thread osstest service owner
flight 170747 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170747/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-pair 10 xen-install/src_host fail in 170740 pass in 170747 test-amd64-i386-libvirt

Re: [PATCH v4 4/8] xen/arm: introduce put_page_nr and get_page_nr

2022-05-26 Thread Stefano Stabellini
On Tue, 17 May 2022, Penny Zheng wrote: > Later, we need to add the right amount of references, which should be > the number of borrower domains, to the owner domain. Since we only have > get_page() to increment the page reference by 1, a loop is needed per > page, which is inefficient and time-con

Re: [PATCH v4 5/8] xen/arm: Add additional reference to owner domain when the owner is allocated

2022-05-26 Thread Stefano Stabellini
On Tue, 17 May 2022, Penny Zheng wrote: > Borrower domain will fail to get a page ref using the owner domain > during allocation, when the owner is created after borrower. > > So here, we decide to get and add the right amount of reference, which > is the number of borrowers, when the owner is all

Re: [PATCH 2/2] docs/misra: add Rule 5.1

2022-05-26 Thread Stefano Stabellini
On Thu, 26 May 2022, Jan Beulich wrote: > On 26.05.2022 03:18, Stefano Stabellini wrote: > > On Wed, 25 May 2022, Jan Beulich wrote: > >> On 25.05.2022 02:35, Stefano Stabellini wrote: > >>> From: Stefano Stabellini > >>> > >>> Add Rule 5.1, with the additional note that the character limit for Xe

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Stefano Stabellini
On Thu, 26 May 2022, Jan Beulich wrote: > On 26.05.2022 03:12, Stefano Stabellini wrote: > > On Wed, 25 May 2022, Jan Beulich wrote: > >> On 25.05.2022 02:35, Stefano Stabellini wrote: > >>> --- /dev/null > >>> +++ b/docs/misra/rules.rst > >>> @@ -0,0 +1,65 @@ > >>> += > >>> +MI

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Stefano Stabellini
On Thu, 26 May 2022, Bertrand Marquis wrote: > > On 26 May 2022, at 11:15, Jan Beulich wrote: > > On 26.05.2022 11:54, Bertrand Marquis wrote: > >>> On 26 May 2022, at 10:43, Jan Beulich wrote: > >>> On 26.05.2022 03:02, Stefano Stabellini wrote: > On Wed, 25 May 2022, Julien Grall wrote: >

Re: [EXT] Xen MISRA C meeting

2022-05-26 Thread Stefano Stabellini
Here you go: https://cryptpad.fr/sheet/#/2/sheet/view/D+wMnbxNO7Acp1NbXEFrJtcQoOJxpuxZMTXXl+w31og/ On Thu, 26 May 2022, Naresh Bhat wrote: > Hi All, > > Can someone please share the "MISRA C Rules For Xen" read-only excel sheet > link? > > Thanks and Regards > -Naresh Bhat > > __

[linux-linus test] 170745: regressions - FAIL

2022-05-26 Thread osstest service owner
flight 170745 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/170745/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-dom0pvh-xl-amd 14 guest-start fail REGR. vs. 170714 test-amd64-amd64-do

Re: [PATCH 16/16] xen/arm: mm: Re-implement setup_frame_table_mappings() with map_pages_to_xen()

2022-05-26 Thread Luca Fancellu
> On 20 May 2022, at 13:09, Julien Grall wrote: > > From: Julien Grall > > Now that map_pages_to_xen() has been extended to support 2MB mappings, > we can replace the create_mappings() call by map_pages_to_xen() call. > > This has the advantage to remove the differences between 32-bit and >

Re: [PATCH 14/16] xen/arm64: mm: Add memory to the boot allocator first

2022-05-26 Thread Luca Fancellu
> On 20 May 2022, at 13:09, Julien Grall wrote: > > From: Julien Grall > > Currently, memory is added to the boot allocator after the xenheap > mappings are done. This will break if the first mapping is more than > 512GB of RAM. > > In addition to that, a follow-up patch will rework setup_xe

Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-05-26 Thread Andrew Cooper
On 26/05/2022 16:31, Jan Beulich wrote: > On 27.04.2022 16:04, Andrew Cooper wrote: >> mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for >> speculative defence. Avoid calling it redundantly, and just store the result >> of the first call. > Since it took quite some time

Re: [PATCH 24/30] panic: Refactor the panic path

2022-05-26 Thread Guilherme G. Piccoli
Hey folks, first of all thanks a lot for the reviews / opinions about this. I imagined that such change would be polemic, and I see I was right heh I'll try to "mix" all the relevant opinions in a single email, since they happened in different responses and even different mail threads. I've loop

Re: [PATCH 10/16] xen/arm: add Persistent Map (PMAP) infrastructure

2022-05-26 Thread Luca Fancellu
> On 20 May 2022, at 13:09, Julien Grall wrote: > > From: Wei Liu > > The basic idea is like Persistent Kernel Map (PKMAP) in Linux. We > pre-populate all the relevant page tables before the system is fully > set up. > > We will need it on Arm in order to rework the arm64 version of > xenhea

[qemu-mainline test] 170741: tolerable FAIL - PUSHED

2022-05-26 Thread osstest service owner
flight 170741 qemu-mainline real [real] flight 170748 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/170741/ http://logs.test-lab.xenproject.org/osstest/logs/170748/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-am

Re: [PATCH] x86/mm: Remove unnecessary mfn_valid() call from get_page_from_l1e()

2022-05-26 Thread Jan Beulich
On 27.04.2022 16:04, Andrew Cooper wrote: > mfn_valid() is not a trivially simple, and contains an evaluate_nospec() for > speculative defence. Avoid calling it redundantly, and just store the result > of the first call. Since it took quite some time for this to actually be committed, I did notic

Re: [PATCH 03/16] xen/arm: mm: Avoid flushing the TLBs when mapping are inserted

2022-05-26 Thread Luca Fancellu
> On 20 May 2022, at 13:09, Julien Grall wrote: > > From: Julien Grall > > Currently, the function xen_pt_update() will flush the TLBs even when > the mappings are inserted. This is a bit wasteful because we don't > allow mapping replacement. Even if we were, the flush would need to > happen

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Bertrand Marquis
Hi Jan, > On 26 May 2022, at 11:15, Jan Beulich wrote: > > On 26.05.2022 11:54, Bertrand Marquis wrote: >> Hi Jan, >> >>> On 26 May 2022, at 10:43, Jan Beulich wrote: >>> >>> On 26.05.2022 03:02, Stefano Stabellini wrote: On Wed, 25 May 2022, Julien Grall wrote: > On 25/05/2022 01:35

[ovmf test] 170746: all pass - PUSHED

2022-05-26 Thread osstest service owner
flight 170746 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/170746/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 16779ede2d366bfc6b702e817356ccf43425bcc8 baseline version: ovmf 07c0c2eb0a5970db614eb

[xen-unstable test] 170740: tolerable FAIL - PUSHED

2022-05-26 Thread osstest service owner
flight 170740 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/170740/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-pair 10 xen-install/src_host fail like 170726 test-armhf-armhf-libvirt 16 save

[libvirt test] 170744: regressions - FAIL

2022-05-26 Thread osstest service owner
flight 170744 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/170744/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[PATCH v2 1/3] x86/vmx: implement Bus Lock detection

2022-05-26 Thread Roger Pau Monne
Add support for enabling Bus Lock Detection on Intel systems. Such detection works by triggering a vmexit, which ought to be enough of a pause to prevent a guest from abusing of the Bus Lock. Add an extra Xen perf counter to track the number of Bus Locks detected. This is done because Bus Locks c

[PATCH v2 3/3] x86/vmx: implement Notify VM Exit

2022-05-26 Thread Roger Pau Monne
Under certain conditions guests can get the CPU stuck in an unbounded loop without the possibility of an interrupt window to occur on instruction boundary. This was the case with the scenarios described in XSA-156. Make use of the Notify VM Exit mechanism, that will trigger a VM Exit if no interr

[PATCH v2 0/3] x86/vmx: implement Bus Lock and VM Notify

2022-05-26 Thread Roger Pau Monne
Hello, Following series implements support for bus lock and notify VM exit. Patches are not really dependent, but I've developed them together by virtue of both features being in Intel Instructions Set Extensions PR Chapter 9. Thanks, Roger. Roger Pau Monne (3): x86/vmx: implement Bus Lock de

[PATCH v2 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI

2022-05-26 Thread Roger Pau Monne
Introduce a small helper to OR VMX_INTR_SHADOW_NMI in GUEST_INTERRUPTIBILITY_INFO in order to help dealing with the NMI unblocked by IRET case. Replace the existing usage in handling EXIT_REASON_EXCEPTION_NMI and also add such handling to EPT violations and page-modification log-full events. Repo

Re: [EXT] Xen MISRA C meeting

2022-05-26 Thread Naresh Bhat
Hi All, Can someone please share the "MISRA C Rules For Xen" read-only excel sheet link? Thanks and Regards -Naresh Bhat From: Xen-devel on behalf of Stefano Stabellini Sent: 26 April 2022 08:04 To: jbeul...@suse.com ; andrew.coop...@citrix.com ; jul...@xen.or

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Jan Beulich
On 26.05.2022 11:54, Bertrand Marquis wrote: > Hi Jan, > >> On 26 May 2022, at 10:43, Jan Beulich wrote: >> >> On 26.05.2022 03:02, Stefano Stabellini wrote: >>> On Wed, 25 May 2022, Julien Grall wrote: On 25/05/2022 01:35, Stefano Stabellini wrote: > +- Rule: Dir 4.7 > + - Severity:

Re: [PATCH 2/2] docs/misra: add Rule 5.1

2022-05-26 Thread Bertrand Marquis
> On 26 May 2022, at 10:40, Jan Beulich wrote: > > On 26.05.2022 03:18, Stefano Stabellini wrote: >> On Wed, 25 May 2022, Jan Beulich wrote: >>> On 25.05.2022 02:35, Stefano Stabellini wrote: From: Stefano Stabellini Add Rule 5.1, with the additional note that the character lim

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Bertrand Marquis
Hi Jan, > On 26 May 2022, at 10:43, Jan Beulich wrote: > > On 26.05.2022 03:02, Stefano Stabellini wrote: >> On Wed, 25 May 2022, Julien Grall wrote: >>> On 25/05/2022 01:35, Stefano Stabellini wrote: +- Rule: Dir 4.7 + - Severity: Required + - Summary: If a function returns error

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Jan Beulich
On 26.05.2022 03:02, Stefano Stabellini wrote: > On Wed, 25 May 2022, Julien Grall wrote: >> On 25/05/2022 01:35, Stefano Stabellini wrote: >>> +- Rule: Dir 4.7 >>> + - Severity: Required >>> + - Summary: If a function returns error information then that error >>> information shall be tested >>

Re: [PATCH 2/2] docs/misra: add Rule 5.1

2022-05-26 Thread Jan Beulich
On 26.05.2022 03:18, Stefano Stabellini wrote: > On Wed, 25 May 2022, Jan Beulich wrote: >> On 25.05.2022 02:35, Stefano Stabellini wrote: >>> From: Stefano Stabellini >>> >>> Add Rule 5.1, with the additional note that the character limit for Xen >>> is 63 characters. >>> >>> The max length ident

Re: [PATCH 1/2] docs/misra: introduce rules.rst

2022-05-26 Thread Jan Beulich
On 26.05.2022 03:12, Stefano Stabellini wrote: > On Wed, 25 May 2022, Jan Beulich wrote: >> On 25.05.2022 02:35, Stefano Stabellini wrote: >>> --- /dev/null >>> +++ b/docs/misra/rules.rst >>> @@ -0,0 +1,65 @@ >>> += >>> +MISRA C rules for Xen >>> += >>> + >>>

Re: [PATCH] xen/arm: Allow setting the number of CPUs to activate at runtime

2022-05-26 Thread Michal Orzel
Hi Julien, Gentle ping asking to reply to my previous mail. On 24.05.2022 08:34, Michal Orzel wrote: > Hi Julien, > > On 23.05.2022 22:00, Julien Grall wrote: >> >> >> On 23/05/2022 11:21, Michal Orzel wrote: >>> Hi Julien, >> >> Hi Michal, >> >>> >>> On 23.05.2022 12:05, Julien Grall wrote: >>>

[PATCH] tools/libxl: optimize domain creation skipping domain cpupool move

2022-05-26 Thread Luca Fancellu
Commit 92ea9c54fc81 ("arm/dom0less: assign dom0less guests to cpupools") introduced a way to start a domain directly on a certain cpupool, adding a "cpupool_id" member to struct xen_domctl_createdomain. This was done to be able to start dom0less guests in different pools than cpupool0, but the too