RE: [PATCH v2 5/6] xen/arm: unpopulate memory when domain is static

2022-04-24 Thread Penny Zheng
Hi jan > -Original Message- > From: Jan Beulich > Sent: Tuesday, April 19, 2022 5:11 PM > To: Penny Zheng > Cc: Wei Chen ; Stefano Stabellini > ; Julien Grall ; Bertrand Marquis > ; Volodymyr Babchuk > ; Andrew Cooper > ; George Dunlap ; > Wei Liu ; xen-devel@lists.xenproject.org > Subje

Re: [PATCH] xen/efi: boot fix duplicated index, offset calculate operation in the copy_mapping loop

2022-04-24 Thread Jan Beulich
On 24.04.2022 16:44, Paran Lee wrote: > It doesn't seem necessary to do that > duplicated calculation of mfn to addr and l4 table index > in the copy_mapping loop. > > Signed-off-by: Paran Lee Oh, one more thing: Please submit patches _To_ the list, with maintainers on _Cc_ (not the other way ar

Re: [PATCH] xen/efi: boot fix duplicated index, offset calculate operation in the copy_mapping loop

2022-04-24 Thread Jan Beulich
On 24.04.2022 16:44, Paran Lee wrote: > It doesn't seem necessary to do that > duplicated calculation of mfn to addr and l4 table index > in the copy_mapping loop. I'm not convinced this is an improvement. If the compiler sees fit, it can CSE things like this, but it may see reasons not to (regist

[ovmf test] 169698: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169698 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169698/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169697: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169697 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169697/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169695: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169695 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169695/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[linux-linus test] 169686: tolerable FAIL - PUSHED

2022-04-24 Thread osstest service owner
flight 169686 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/169686/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10fail like 169664 test-amd64-amd64-xl-qemut-win7-amd64

[ovmf test] 169693: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169693 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169693/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169692: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169692 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169692/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169691: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169691 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169691/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169690: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169690 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169690/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169689: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169689 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169689/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169688: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169688 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169687: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169687 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169687/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169685: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169685 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169685/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169684: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169684 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169684/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access under Xen

2022-04-24 Thread Boris Ostrovsky
On 4/24/22 12:53 PM, Oleksandr wrote: On 23.04.22 19:40, Christoph Hellwig wrote: + +#ifdef CONFIG_ARCH_HAS_RESTRICTED_VIRTIO_MEMORY_ACCESS +int arch_has_restricted_virtio_memory_access(void) +{ +    return (xen_has_restricted_virtio_memory_access() || +    cc_platform_has(CC_AT

[ovmf test] 169683: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169683 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169683/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH V1 3/6] xen/virtio: Add option to restrict memory access under Xen

2022-04-24 Thread Oleksandr
On 23.04.22 19:40, Christoph Hellwig wrote: Hello Christoph Please split this into one patch that creates grant-dma-ops, and another that sets up the virtio restricted access helpers. Sounds reasonable, will do: 1. grant-dma-ops.c with config XEN_GRANT_DMA_OPS 2. arch_has_restricted_vir

Re: [PATCH] xen/device_tree: silence ambiguous integer casting warning error

2022-04-24 Thread Julien Grall
Hi, On 19/04/2022 16:46, Paran Lee wrote: GCC with "-g -Wall -Wextra" option throws warning message as below: s/warning/error/ error: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Werror=sign-compare] Can you post the full log? Silence the warn

Re: [PATCH] xen/arm: p2m_set_entry duplicate calculation.

2022-04-24 Thread Julien Grall
Hi, On 21/04/2022 16:17, Paran Lee wrote: It doesn't seem necessary to do that calculation of order shift again. I think we need to weight that against increasing the number of local variables that do pretty much the same. This is pretty much done to a matter of taste here. IMHO, the origin

[ovmf test] 169682: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169682 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169682/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

Re: [PATCH V1 6/6] arm/xen: Assign xen-grant DMA ops for xen-grant DMA devices

2022-04-24 Thread Oleksandr
On 23.04.22 19:42, Christoph Hellwig wrote: Hello Christoph On Fri, Apr 22, 2022 at 07:51:03PM +0300, Oleksandr Tyshchenko wrote: static inline void xen_setup_dma_ops(struct device *dev) { #ifdef CONFIG_XEN - if (xen_swiotlb_detect()) + if (arch_has_restricted_virtio_memory

Re: [PATCH v3] page_alloc: assert IRQs are enabled in heap alloc/free

2022-04-24 Thread Julien Grall
Hi David, On 22/04/2022 16:36, David Vrabel wrote: From: David Vrabel Heap pages can only be safely allocated and freed with interuupts typo: s/interuupts/interrupts/ enabled as they may require a TLB flush which will send IPIs. We don't have such requirements on Arm. Given this is commo

Re: [PATCH] xen/arm: fdt fix duplicated ternary operator, shift operations

2022-04-24 Thread Julien Grall
Hi, On 22/04/2022 19:52, Paran Lee wrote: It doesn't seem necessary to do duplicate ternary operation and calculation of order shift using fdt32_to_cpu macro. Signed-off-by: Paran Lee --- xen/arch/arm/bootfdt.c | 12 ++-- xen/common/libfdt/fdt.c | 10 +- 2 files changed, 1

[ovmf test] 169681: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169681 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169681/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[PATCH] xen/efi: boot fix duplicated index, offset calculate operation in the copy_mapping loop

2022-04-24 Thread Paran Lee
It doesn't seem necessary to do that duplicated calculation of mfn to addr and l4 table index in the copy_mapping loop. Signed-off-by: Paran Lee --- xen/common/efi/boot.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c ind

[ovmf test] 169680: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169680 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169680/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169679: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169679 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169679/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169678: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169678 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169678/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169677: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169677 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169677/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169676: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169676 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169676/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169675: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169675 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169675/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169674: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169674 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169674/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[libvirt test] 169669: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169669 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/169669/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[xen-unstable test] 169666: tolerable FAIL

2022-04-24 Thread osstest service owner
flight 169666 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/169666/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-arndale 8 xen-boot fail in 169635 pass in 169666 test-amd64-amd64-dom0pvh-xl-inte

[ovmf test] 169673: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169673 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169673/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169672: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169672 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169672/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[ovmf test] 169670: regressions - FAIL

2022-04-24 Thread osstest service owner
flight 169670 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/169670/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 168254 build-amd64-xsm

[linux-linus test] 169664: tolerable FAIL - PUSHED

2022-04-24 Thread osstest service owner
flight 169664 linux-linus real [real] flight 169671 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/169664/ http://logs.test-lab.xenproject.org/osstest/logs/169671/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-