[xen-unstable test] 166062: tolerable FAIL - PUSHED

2021-11-05 Thread osstest service owner
flight 166062 xen-unstable real [real] flight 166068 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/166062/ http://logs.test-lab.xenproject.org/osstest/logs/166068/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd6

[ovmf test] 166063: all pass - PUSHED

2021-11-05 Thread osstest service owner
flight 166063 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/166063/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4050c873b51f59cb6fcd7665029f931e727e0e4f baseline version: ovmf b258f12889c09555e99c9

RE: static-mem preventing dom0 from booting

2021-11-05 Thread Stefano Stabellini
+ Julien, Ian and others On Fri, 5 Nov 2021, Stefano Stabellini wrote: > On Fri, 5 Nov 2021, Stefano Stabellini wrote: > > The scenario is extremely simple; you can see the full device tree > > configuration in the attachment to my previous email. > > > > - dom0 > > - dom0less domU with static-me

RE: static-mem preventing dom0 from booting

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Stefano Stabellini wrote: > The scenario is extremely simple; you can see the full device tree > configuration in the attachment to my previous email. > > - dom0 > - dom0less domU with static-mem > > That's it! So basically it is just a normal dom0 + dom0less domU > configurat

[qemu-mainline test] 166052: tolerable FAIL - PUSHED

2021-11-05 Thread osstest service owner
flight 166052 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/166052/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 166044 test-armhf-armhf-libvirt 16 sav

[linux-linus test] 166051: regressions - FAIL

2021-11-05 Thread osstest service owner
flight 166051 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/166051/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 165976 test-amd64-amd64-xl

[XEN][PATCH v3 0/1] Update libfdt to v1.6.1

2021-11-05 Thread Vikram Garhwal
This update is done to support device tree overlays functionality. This is taken from David Gibson's DTC git: github.com/dgibson/dtc. Change log: v2 -> v3: Include version.lds changes. v1 -> v2: Correct the compilation issue due to incorrect lib.h path. Regards, Vikram Vikram Garhwal (1

Re: Arm EFI boot issue for Dom0 module listed inside subnode of chosen

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Julien Grall wrote: > Hi Stefano, > > On 03/11/2021 21:57, Stefano Stabellini wrote: > > On Wed, 3 Nov 2021, Julien Grall wrote: > > > On 02/11/2021 23:36, Stefano Stabellini wrote: > > > > On Tue, 2 Nov 2021, Luca Fancellu wrote: > > > > > Hi all, > > > > > > > > > > We recen

Re: [PATCH v2 1/1] xen: delay xen_hvm_init_time_ops() if kdump is boot on vcpu>=32

2021-11-05 Thread Boris Ostrovsky
On 11/4/21 1:59 PM, Dongli Zhang wrote: Hi Boris, On 11/1/21 10:34 AM, Boris Ostrovsky wrote: On 10/27/21 9:25 PM, Dongli Zhang wrote: The sched_clock() can be used very early since commit 857baa87b642 ("sched/clock: Enable sched clock early"). In addition, with commit 38669ba205d1 ("x86/xen

Re: [XEN][PATCH 2/2] xen: libfdt: Changes to make libfdt v1.6.1 compatible with Xen

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Vikram Garhwal wrote: > A few minor changes are done to make it compatible with Xen: > fdt_overlay.c: overlay_fixup_phandle() > > Replace strtoul() with simple_strtoul() as strtoul() is not available > in > Xen lib and included lib.h. > > Change ch

[xen-unstable-smoke test] 166055: tolerable all pass - PUSHED

2021-11-05 Thread osstest service owner
flight 166055 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/166055/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[XEN][PATCH 0/2] Changes for libfdt v.1.6.1

2021-11-05 Thread Vikram Garhwal
This patch series is NOT INTENDED for commit. Instead this is just a helper patch series to highlight the changes made to ported DTC 1.6.1. Hopefully, it will save time while reviewing "[XEN][PATCH v2 1/1] Update libfdt to v1.6.1" series. [Patch 1/2] is just copy of DTC v1.6.1. [Patch 2/2] contai

[XEN][PATCH 2/2] xen: libfdt: Changes to make libfdt v1.6.1 compatible with Xen

2021-11-05 Thread Vikram Garhwal
A few minor changes are done to make it compatible with Xen: fdt_overlay.c: overlay_fixup_phandle() Replace strtoul() with simple_strtoul() as strtoul() is not available in Xen lib and included lib.h. Change char *endptr to const char *endptr. libfdt_env.h:

Re: Arm EFI boot issue for Dom0 module listed inside subnode of chosen

2021-11-05 Thread Julien Grall
Hi Stefano, On 03/11/2021 21:57, Stefano Stabellini wrote: On Wed, 3 Nov 2021, Julien Grall wrote: On 02/11/2021 23:36, Stefano Stabellini wrote: On Tue, 2 Nov 2021, Luca Fancellu wrote: Hi all, We recently discovered that there is a way to list Dom0 modules that is not supported by the EFI

Re: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Bertrand Marquis wrote: > Hi Stefano, > > > On 4 Nov 2021, at 22:48, Stefano Stabellini wrote: > > > > On Wed, 3 Nov 2021, Vikram Garhwal wrote: > >> Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc. > >> This update is done to support device tree ove

Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Ian Jackson wrote: > Stefano Stabellini writes ("Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on > arm64"): > > I had a question for Jan, but in reply to the previous version of the > > patch so you might have missed it: > > > > https://lore.kernel.org/all/alpine.DEB.2.22.394.2

Re: [PATCH v2] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-05 Thread Julien Grall
(+ Ian) On 05/11/2021 15:44, Stefano Stabellini wrote: Signed-off-by: Stefano Stabellini Acked-by: Julien Grall @Ian, do we need a release-acked-by for this? Cheers, diff --git a/MAINTAINERS b/MAINTAINERS index 9be4ad653a..4956db1011 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -232,6

Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Ian Jackson
Stefano Stabellini writes ("Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64"): > I had a question for Jan, but in reply to the previous version of the > patch so you might have missed it: > > https://lore.kernel.org/all/alpine.DEB.2.22.394.2111050825240.284830@ubuntu-linux-20-04-desktop/ Ah

Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Ian Jackson wrote: > Bertrand Marquis writes ("Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on > arm64"): > > > Signed-off-by: Luca Fancellu > > > Release-Acked-by: Ian Jackson > > > Reviewed-by: Jan Beulich > > > > Reviewed-by: Bertrand Marquis > > Thanks all, pushed. He

Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Ian Jackson
Bertrand Marquis writes ("Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64"): > > Signed-off-by: Luca Fancellu > > Release-Acked-by: Ian Jackson > > Reviewed-by: Jan Beulich > > Reviewed-by: Bertrand Marquis Thanks all, pushed. Ian.

Re: [PATCH v2] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-05 Thread Bertrand Marquis
Hi Stefano > On 5 Nov 2021, at 15:44, Stefano Stabellini wrote: > > Signed-off-by: Stefano Stabellini Acked-by: Bertrand Marquis Cheers Bertrand > > diff --git a/MAINTAINERS b/MAINTAINERS > index 9be4ad653a..4956db1011 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -232,6 +232,7 @@ AR

Re: [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing

2021-11-05 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing"): > > 4.16: While investigating the issue addressed by the referenced commit, > > a variant of that problem was identified when firmware pre-enables > > x2APIC mode. Whether

[PATCH v2] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-05 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini diff --git a/MAINTAINERS b/MAINTAINERS index 9be4ad653a..4956db1011 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -232,6 +232,7 @@ ARM (W/ VIRTUALISATION EXTENSIONS) ARCHITECTURE M: Stefano Stabellini M: Julien Grall R: Volodymyr Babchuk +R:

RE: static-mem preventing dom0 from booting

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Penny Zheng wrote: > > -Original Message- > > From: Penny Zheng > > Sent: Friday, November 5, 2021 11:23 AM > > To: Stefano Stabellini > > Cc: xen-devel@lists.xenproject.org; Wei Chen > > Subject: RE: static-mem preventing dom0 from booting > > > > Hi Stefano > > > >

Re: [PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing

2021-11-05 Thread Roger Pau Monné
On Fri, Nov 05, 2021 at 01:32:18PM +0100, Jan Beulich wrote: > While commit 46c4061cd2bf ("x86/IOMMU: mark IOMMU / intremap not in use > when ACPI tables are missing") deals with apic_x2apic_probe() as called > from x2apic_bsp_setup(), the check_x2apic_preenabled() path is similarly > affected: The

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Stefano Stabellini
On Fri, 5 Nov 2021, Jan Beulich wrote: > On 04.11.2021 22:50, Stefano Stabellini wrote: > > On Thu, 4 Nov 2021, Luca Fancellu wrote: > >>> On 4 Nov 2021, at 21:35, Stefano Stabellini > >>> wrote: > >>> On Thu, 4 Nov 2021, Luca Fancellu wrote: > > On 4 Nov 2021, at 20:56, Stefano Stabellini

Re: [PATCH 2/2] x86/mm: nuke PAGE_KERNEL_IO

2021-11-05 Thread Lucas De Marchi
Hi, gentle ping on this. Is it something that could go through the tip tree? thanks Lucas De Marchi On Thu, Oct 21, 2021 at 11:15:11AM -0700, Lucas De Marchi wrote: PAGE_KERNEL_IO is only defined for x86 and nowadays is the same as PAGE_KERNEL. It was different for some time, OR'ing a `_PAGE_IO

Re: xen 4.11.4 incorrect (~3x) cpu frequency reported

2021-11-05 Thread James Dingwall
Hi Jan, On Fri, Nov 05, 2021 at 01:50:04PM +0100, Jan Beulich wrote: > On 26.07.2021 14:33, James Dingwall wrote: > > Hi Jan, > > > > Thank you for taking the time to reply. > > > > On Wed, Jul 21, 2021 at 12:59:11PM +0200, Jan Beulich wrote: > >> On 21.07.2021 11:29, James Dingwall wrote: > >>>

[xen-unstable test] 166049: tolerable FAIL - PUSHED

2021-11-05 Thread osstest service owner
flight 166049 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/166049/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 166043 test-armhf-armhf-libvirt 16 save

Re: [XEN][PATCH v2 1/1] Update libfdt to v1.6.1

2021-11-05 Thread Bertrand Marquis
Hi Stefano, > On 4 Nov 2021, at 22:48, Stefano Stabellini wrote: > > On Wed, 3 Nov 2021, Vikram Garhwal wrote: >> Update libfdt to v1.6.1 of libfdt taken from git://github.com/dgibson/dtc. >> This update is done to support device tree overlays. >> >> A few minor changes are done to make it comp

Re: [PATCH 4/5] xen/xsm: Improve fallback handling in xsm_fixup_ops()

2021-11-05 Thread Daniel P. Smith
On 11/5/21 9:55 AM, Andrew Cooper wrote: The current xsm_fixup_ops() is just shy of a full page when compiled, and very fragile to NULL function pointer errors. Address both of these issues with a minor piece of structure (ab)use. Introduce dummy_ops, and fixup the provided xsm_ops pointer by tr

Re: [PATCH 3/5] xen/xsm: Drop xsm_hvm_control() hook

2021-11-05 Thread Daniel P. Smith
On 11/5/21 9:55 AM, Andrew Cooper wrote: The final caller was dropped by c/s 58cbc034dc62 "dm_op: convert HVMOP_inject_trap and HVMOP_inject_msi" Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf CC: Daniel Smith Reviewed-by: Daniel P. Smith

Re: [PATCH v2 00/15] xen: drop hypercall function tables

2021-11-05 Thread Andrew Cooper
On 01/11/2021 15:20, Juergen Gross wrote: > In order to avoid indirect function calls on the hypercall path as > much as possible this series is removing the hypercall function tables > and is replacing the hypercall handler calls via the function array > by automatically generated call macros. > >

Re: [PATCH 2/5] xen/xsm: Complete altcall conversion of xsm interface

2021-11-05 Thread Daniel P. Smith
On 11/5/21 9:55 AM, Andrew Cooper wrote: With alternative_call() capable of handling compound types, the three remaining hooks can be optimised at boot time too. Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf CC: Daniel Smith I'm on the fence as to whether to declare this as fixing "xs

Re: [PATCH 1/5] x86/altcall: allow compound types to be passed

2021-11-05 Thread Daniel P. Smith
On 11/5/21 9:55 AM, Andrew Cooper wrote: From: Jan Beulich Replace the conditional operator in ALT_CALL_ARG(), which was intended to limit usable types to scalar ones, by a size check. Some restriction here is necessary to make sure we don't violate the ABI's calling conventions, but limiting

Re: [PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Bertrand Marquis
Hi Luca, > On 5 Nov 2021, at 13:07, Luca Fancellu wrote: > > The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 > ("arm/efi: Use dom0less configuration when using EFI boot") is > introducing a problem to boot Xen using Grub2 on ARM machine using EDK2. > > Despite UEFI specif

Re: [PATCH 2/5] xen/xsm: Complete altcall conversion of xsm interface

2021-11-05 Thread Jan Beulich
On 05.11.2021 14:55, Andrew Cooper wrote: > With alternative_call() capable of handling compound types, the three > remaining hooks can be optimised at boot time too. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich

[PATCH 1/5] x86/altcall: allow compound types to be passed

2021-11-05 Thread Andrew Cooper
From: Jan Beulich Replace the conditional operator in ALT_CALL_ARG(), which was intended to limit usable types to scalar ones, by a size check. Some restriction here is necessary to make sure we don't violate the ABI's calling conventions, but limiting to scalar types was both too restrictive (di

[PATCH 2/5] xen/xsm: Complete altcall conversion of xsm interface

2021-11-05 Thread Andrew Cooper
With alternative_call() capable of handling compound types, the three remaining hooks can be optimised at boot time too. Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf CC: Daniel Smith I'm on the fence as to whether to declare this as fixing "xsm: convert xsm_ops hook calls to alternativ

[PATCH 3/5] xen/xsm: Drop xsm_hvm_control() hook

2021-11-05 Thread Andrew Cooper
The final caller was dropped by c/s 58cbc034dc62 "dm_op: convert HVMOP_inject_trap and HVMOP_inject_msi" Signed-off-by: Andrew Cooper --- CC: Daniel De Graaf CC: Daniel Smith --- xen/include/xsm/dummy.h | 7 --- xen/include/xsm/xsm.h | 7 --- xen/xsm/dummy.c | 1 - xen/xsm/fl

[PATCH 0/5] XSM: cleanups

2021-11-05 Thread Andrew Cooper
Various XSM cleanups from observations based on Daniel's previous cleanup series. Andrew Cooper (4): xen/xsm: Complete altcall conversion of xsm interface xen/xsm: Drop xsm_hvm_control() hook xen/xsm: Improve fallback handling in xsm_fixup_ops() xen/xsm: Address hypercall ABI problems Jan

[PATCH 5/5] xen/xsm: Address hypercall ABI problems

2021-11-05 Thread Andrew Cooper
Currently, __HYPERVISOR_xsm_op enters xsm_ops.do_{xsm,compat}_op() which means that if any other XSM module registers a handler, we'll break the hypercall ABI totally by having the behaviour depend on the selected XSM module. There are 2 options: 1) Rename __HYPERVISOR_xsm_op to __HYPERVISOR_flas

[PATCH 4/5] xen/xsm: Improve fallback handling in xsm_fixup_ops()

2021-11-05 Thread Andrew Cooper
The current xsm_fixup_ops() is just shy of a full page when compiled, and very fragile to NULL function pointer errors. Address both of these issues with a minor piece of structure (ab)use. Introduce dummy_ops, and fixup the provided xsm_ops pointer by treating both as an array of unsigned longs.

[libvirt test] 166050: regressions - FAIL

2021-11-05 Thread osstest service owner
flight 166050 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/166050/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

[PATCH-4.16 v4] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Luca Fancellu
The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 ("arm/efi: Use dom0less configuration when using EFI boot") is introducing a problem to boot Xen using Grub2 on ARM machine using EDK2. Despite UEFI specification, EDK2+Grub2 is returning a NULL DeviceHandle inside the interfac

Re: [PATCH-4.16 v3] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Luca Fancellu
> On 5 Nov 2021, at 12:20, Jan Beulich wrote: > > On 05.11.2021 12:21, Luca Fancellu wrote: >> --- a/xen/common/efi/boot.c >> +++ b/xen/common/efi/boot.c >> @@ -121,6 +121,8 @@ static char *get_value(const struct file *cfg, const >> char *section, >> static char *split_string(char *s); >> sta

Re: xen 4.11.4 incorrect (~3x) cpu frequency reported

2021-11-05 Thread Jan Beulich
On 26.07.2021 14:33, James Dingwall wrote: > Hi Jan, > > Thank you for taking the time to reply. > > On Wed, Jul 21, 2021 at 12:59:11PM +0200, Jan Beulich wrote: >> On 21.07.2021 11:29, James Dingwall wrote: >>> We have a system which intermittently starts up and reports an incorrect >>> cpu fre

Re: Error around cc-option on AArch64

2021-11-05 Thread Jan Beulich
On 07.09.2021 15:03, Penny Zheng wrote: > Hi Julien and Stefano > > I found that the "cc-option/cc-option-add" is not working for "-march=xxx" > option on a few very common aarch64 compilers. > Here is what I got when trying to compile XEN on r82 platform. > ``` > diff --git a/xen/arch/arm/arch.m

[PATCH v2 6/6] x86/ACPI: drop dead interpreter-related code

2021-11-05 Thread Jan Beulich
CONFIG_ACPI_INTERPRETER does not get defined anywhere, the enclosed code wouldn't build, and the default-to-phys logic works differently anyway (see genapic/bigsmp.c:probe_bigsmp()). Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/boot.c @@ -477,16

[PATCH v2 5/6] x86/APIC: rename cmdline_apic

2021-11-05 Thread Jan Beulich
The name hasn't been appropriate for a long time: It covers not only command line overrides, but also x2APIC pre-enabled state. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/genapic/probe.c +++ b/xen/arch/x86/genapic/probe.c @@ -24,7 +24,7 @@ static const struct genapic *const __ini

[PATCH v2 4/6] x86/APIC: drop probe_default()

2021-11-05 Thread Jan Beulich
The function does nothing but return success. Simply treat absence of a probe hook to mean just this. This then eliminates the (purely theoretical at this point) risk of trying to call through apic_x2apic_{cluster,phys}'s respective NULL pointers. While doing this also eliminate generic_apic_probe

[PATCH v2 3/6] x86/APIC: drop {acpi_madt,mps}_oem_check() hooks

2021-11-05 Thread Jan Beulich
The hook functions have been empty for a very long time, if not (according to git history) forever. Ditch them alongside the then empty mach_mpparse.h instances and the then unused APICFUNC() macro. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/acpi/boot.c +++ b/xen/arch/x86/acpi/bo

[PATCH v2 2/6] x86/APIC: drop clustered_apic_check() hook

2021-11-05 Thread Jan Beulich
The hook functions have been empty forever (x2APIC) or issuing merely a printk() for a long time (xAPIC). Since that printk() is (a) generally useful (i.e. also in the x2APIC case) and (b) would better only be issued once the final APIC driver to use was determined, move (and generalize) it into co

[PATCH v2 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing

2021-11-05 Thread Jan Beulich
While commit 46c4061cd2bf ("x86/IOMMU: mark IOMMU / intremap not in use when ACPI tables are missing") deals with apic_x2apic_probe() as called from x2apic_bsp_setup(), the check_x2apic_preenabled() path is similarly affected: The call needs to occur after acpi_iommu_init(), such that iommu_intrema

[PATCH v2 0/6] x86: ACPI / APIC / IOMMU interaction

2021-11-05 Thread Jan Beulich
While reworking patch 1 (the only one here that I consider a candidate for 4.16; see there) I stumbled over quite a few things that have long been ripe for cleaning up. Hence the tail of 5 further patches ... 1: x2APIC: defer probe until after IOMMU ACPI table parsing 2: APIC: drop clustered_apic_

Re: [PATCH-4.16 v3] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Jan Beulich
On 05.11.2021 12:21, Luca Fancellu wrote: > --- a/xen/common/efi/boot.c > +++ b/xen/common/efi/boot.c > @@ -121,6 +121,8 @@ static char *get_value(const struct file *cfg, const char > *section, > static char *split_string(char *s); > static CHAR16 *s2w(union string *str); > static char *w2s(con

Re: [PATCH v2] xen/balloon: rename alloc/free_xenballooned_pages

2021-11-05 Thread Boris Ostrovsky
On 11/2/21 5:22 AM, Juergen Gross wrote: alloc_xenballooned_pages() and free_xenballooned_pages() are used as direct replacements of xen_alloc_unpopulated_pages() and xen_free_unpopulated_pages() in case CONFIG_XEN_UNPOPULATED_ALLOC isn't defined. Guard both functions with !CONFIG_XEN_UNPOPULA

Re: [PATCH v4] xen/balloon: add late_initcall_sync() for initial ballooning done

2021-11-05 Thread Boris Ostrovsky
On 11/2/21 5:19 AM, Juergen Gross wrote: When running as PVH or HVM guest with actual memory < max memory the hypervisor is using "populate on demand" in order to allow the guest to balloon down from its maximum memory size. For this to work correctly the guest must not touch more memory pages

[PATCH-4.16 v3] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Luca Fancellu
The code introduced by commit a1743fc3a9fe9b68c265c45264dddf214fd9b882 ("arm/efi: Use dom0less configuration when using EFI boot") is introducing a problem to boot Xen using Grub2 on ARM machine using EDK2. Despite UEFI specification, EDK2+Grub2 is returning a NULL DeviceHandle inside the interfac

Re: [PATCH] MAINTAINERS: add Bertrand to the ARM reviewers

2021-11-05 Thread Bertrand Marquis
Hi Julien, > On 4 Nov 2021, at 22:59, Julien Grall wrote: > > Hi Stefano, > > On 04/11/2021 21:00, Stefano Stabellini wrote: >> Acked-by: Bertrand Marquis > > I am not sure where the Acked-by is coming from. Can Bertrand confirm on the > ML that the is happy to be a reviewer? I can confirm

Re: [PATCH v6 6/7] xen/arm: process pending vPCI map/unmap operations

2021-11-05 Thread Jan Beulich
On 05.11.2021 07:33, Oleksandr Andrushchenko wrote: > --- a/xen/arch/x86/hvm/hvm.c > +++ b/xen/arch/x86/hvm/hvm.c > @@ -546,6 +546,12 @@ void hvm_do_resume(struct vcpu *v) > > pt_restore_timer(v); > > +if ( has_vpci(v->domain) && vpci_process_pending(v) ) > +{ > +raise_soft

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Jan Beulich
On 04.11.2021 22:50, Stefano Stabellini wrote: > On Thu, 4 Nov 2021, Luca Fancellu wrote: >>> On 4 Nov 2021, at 21:35, Stefano Stabellini wrote: >>> On Thu, 4 Nov 2021, Luca Fancellu wrote: > On 4 Nov 2021, at 20:56, Stefano Stabellini > wrote: > @@ -851,10 +853,14 @@ static int __in

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Jan Beulich
On 04.11.2021 22:43, Luca Fancellu wrote: > > >> On 4 Nov 2021, at 21:35, Stefano Stabellini wrote: >> >> On Thu, 4 Nov 2021, Luca Fancellu wrote: On 4 Nov 2021, at 20:56, Stefano Stabellini wrote: On Thu, 4 Nov 2021, Jan Beulich wrote: > On 04.11.2021 15:12, Luca Fancellu wr

Re: [PATCH-4.16 v2] xen/efi: Fix Grub2 boot on arm64

2021-11-05 Thread Jan Beulich
On 04.11.2021 21:56, Stefano Stabellini wrote: > On Thu, 4 Nov 2021, Jan Beulich wrote: >> On 04.11.2021 15:12, Luca Fancellu wrote: >>> --- a/xen/common/efi/boot.c >>> +++ b/xen/common/efi/boot.c >>> @@ -449,6 +449,15 @@ static EFI_FILE_HANDLE __init >>> get_parent_handle(EFI_LOADED_IMAGE *loaded