flight 165531 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165531/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf f10a112f08f3fb4a92c3d22f069f6066a12db3be
baseline version:
ovmf 7e43d3e08611ac4c4bc41
flight 165524 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165524/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass
in 165515
Tests which did not suc
flight 165521 xen-4.15-testing real [real]
flight 165532 xen-4.15-testing real-retest [real]
http://logs.test-lab.xenproject.org/osstest/logs/165521/
http://logs.test-lab.xenproject.org/osstest/logs/165532/
Failures :-/ but no regressions.
Tests which are failing intermittently (not blocking):
t
flight 165530 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165530/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Reviewed-by: Geert Uytterhoeven
Acked-by: Geert Uytterhoeven
Signed-off-by: Luis Chamberlain
---
arch/m68k/emu/nfblock.c | 9 +++--
1 file changed, 7 insertio
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
This driver doesn't do any unwinding with blk_cleanup_disk()
even on errors after add_disk() and so we follow that
tradition.
Acked-by: Coly Li
Signed-off-by: Luis
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Acked-by: Jack Wang
Signed-off-by: Luis Chamberlain
---
drivers/block/rnbd/rnbd-clt.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --g
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Acked-by: Miquel Raynal
Signed-off-by: Luis Chamberlain
---
drivers/mtd/mtd_blkdevs.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/driv
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
Just put the cdrom kref and have the unwinding be done by
sr_kref_release().
Reviewed-by: Christoph Hellwig
Signed-off-by: Luis Chamberlain
---
drivers/scsi/sr.c
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
There are two calls to dm_setup_md_queue() which can fail then,
one on dm_early_create() and we can easily see that the error path
there calls dm_destroy in the error
We never checked for errors on device_add_disk() as this function
returned void. Now that this is fixed, use the shiny new error
handling. The function xlvbd_alloc_gendisk() typically does the
unwinding on error on allocating the disk and creating the tag,
but since all that error handling was stuf
Jens,
I had last split up patches into 7 groups, but at this point now
most changes are merged except a few more drivers. Instead of creating
a new patch set for each of the 7 groups I'm creating 3 new groups of
patches now:
* This set, for which we already have an Acked-by or Reviewed-by tag,
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
ubd_disk_register() never returned an error, so just fix
that now and let the caller handle the error condition.
Reviewed-by: Gabriel Krisman Bertazi
Signed-off-by:
We never checked for errors on add_disk() as this function
returned void. Now that this is fixed, use the shiny new
error handling.
As with the error handling for device_add() we follow the same
logic and just put the device so that cleanup is done via the
scsi_disk_release().
Reviewed-by: Christ
This patch broke gitlab-ci:
https://gitlab.com/xen-project/people/sstabellini/xen/-/jobs/1684530258
In file included from guest_4.c:2:
./multi.c:2159:9: error: unused variable 'r' [-Werror,-Wunused-variable]
int r;
^
1 error generated.
make[5]: *** [/builds/xen-project/people/sstabell
flight 165520 xen-4.14-testing real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165520/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 165386
test-armhf-armhf-libvirt-qcow2 1
flight 165523 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165523/
Perfect :-)
All tests in this flight passed as required
version targeted for testing:
ovmf 7e43d3e08611ac4c4bc41c46470052d4118168eb
baseline version:
ovmf 785cfd33053f506d4a1c1
On 10/15/21 10:33 AM, Juergen Gross wrote:
Commit b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license
identifier to files with no license") was meant to do a tree-wide
cleanup for files without any license information by adding a SPDX
GPL-2.0 line to them.
Unfortunately this was applied
On Fri, 15 Oct 2021, Julien Grall wrote:
> On 15/10/2021 18:33, Bertrand Marquis wrote:
> > > On 15 Oct 2021, at 18:25, Julien Grall wrote:
> > >
> > > Hi Bertrand,
> > >
> > > On 15/10/2021 17:51, Bertrand Marquis wrote:
> > > > diff --git a/xen/drivers/passthrough/pci.c
> > > > b/xen/drivers/p
On 15/10/2021 18:33, Bertrand Marquis wrote:
Hi Julien,
Hi Bertrand,
On 15 Oct 2021, at 18:25, Julien Grall wrote:
Hi Bertrand,
On 15/10/2021 17:51, Bertrand Marquis wrote:
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 3aa8c3175f..35e0190796 100644
flight 165527 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165527/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
Hi Julien,
> On 15 Oct 2021, at 18:25, Julien Grall wrote:
>
> Hi Bertrand,
>
> On 15/10/2021 17:51, Bertrand Marquis wrote:
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>> index 3aa8c3175f..35e0190796 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/d
Hi Bertrand,
On 15/10/2021 17:51, Bertrand Marquis wrote:
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 3aa8c3175f..35e0190796 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -756,6 +756,19 @@ int pci_add_device(u16 seg, u8 bus
On Thu, Oct 14, 2021 at 12:19:06PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > When doing an out-of-tree build, and thus setting VPATH,
> > GNU Make 0.81 on Ubuntu Trusty complains about Circular dependency of
> > include/Makefile and include/xlat.lst and drop them. T
On Thu, Oct 14, 2021 at 12:14:29PM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > This implement out-of-tree support, there's two ways to create an
> > out-of-tree build tree (after that, `make` in that new directory
> > works):
> > make O=build
> > mkdir build;
On Fri, Oct 15, 2021 at 7:46 PM Bjorn Helgaas wrote:
> On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote:
...
> so compared to Uwe's v6, I restored that section to the original code.
> My goal here was to make the patch as simple and easy to review as
> possible.
Thanks for elabor
From: Rahul Singh
libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device assigned to guest.
A new area has been reserved in the arm gue
From: Michal Orzel
... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.
This change will be needed to get access from
libxl__prepare_dtb to "num_pcidevs" field of
libxl_domain_config to check whether to create
a vPCI DT node or not.
Signed-off-by: Mic
From: Michal Orzel
... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.
We need to pass the whole libxl_domain_config
structure as this will be needed later on to modify
the libxl__prepare_dtb function to also take
libxl_domain_config.
Signed-off-by:
PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
Use ECAM/ecam instead of MCFG in common code and in new functions added
in common vpci code by this patch.
Move vpci_access_allowed from arch/x86/hvm/io.c to drivers/vpci/vpci.c.
Create vpci_ecam_{read,write} in drivers/vpci/vp
From: Rahul Singh
The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via the hyper call
“PHYSDEVOP_pci_device_add”, VPCI handler for the config space
access is added to the Xen to emulate the PCI devices config space.
A MMIO trap handler for the PCI E
Hello All,
This serie is a follow up on Rahul serie where we included various fixes
required after review on the mailing list and a new patch to move some
of the x86 ecam related code to the common vpci code.
Most of the patches of the original serie have been merged and this
serie includes only
On Wed, Oct 13, 2021 at 04:23:09PM +0300, Andy Shevchenko wrote:
> On Wed, Oct 13, 2021 at 06:33:56AM -0500, Bjorn Helgaas wrote:
> > On Wed, Oct 13, 2021 at 12:26:42PM +0300, Andy Shevchenko wrote:
> > > On Wed, Oct 13, 2021 at 2:33 AM Bjorn Helgaas wrote:
> > > > On Mon, Oct 04, 2021 at 02:59:24
On Thu, Oct 14, 2021 at 11:44:00AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > This will allow "clean" to work from an out-of-tree build when
> > it will be available.
> >
> > Some of the file been removed in current "clean" target aren't added
> > to $(clean-files)
On Thu, Oct 14, 2021 at 11:33:16AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > After folowing patches, the recipe doesn't work anymore.
> > - build: build everything from the root dir, use obj=$subdir
> > - build: introduce if_changed_deps
>
> That was some 2
On Thu, Oct 14, 2021 at 10:51:44AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > --- a/xen/arch/arm/efi/Makefile
> > +++ b/xen/arch/arm/efi/Makefile
> > @@ -1,4 +1,10 @@
> > CFLAGS-y += -fshort-wchar
> > +CFLAGS-y += -I$(srctree)/common/efi
>
> Perhaps another opportu
On Thu, Oct 14, 2021 at 10:32:05AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > --- a/xen/arch/x86/boot/Makefile
> > +++ b/xen/arch/x86/boot/Makefile
> > @@ -1,23 +1,51 @@
> > obj-bin-y += head.o
> > +head-objs := cmdline.S reloc.S
> >
> > -DEFS_H_DEPS = $(BASEDIR)/
Hi,
> On 15 Oct 2021, at 14:59, Bertrand Marquis wrote:
>
> From: Rahul Singh
>
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the Xen to
Julien Grall writes ("Re: [PATCH v7 5/5] arm/libxl: Emulated PCI device tree
node in libxl"):
> On 15/10/2021 14:59, Bertrand Marquis wrote:
> > Signed-off-by: Rahul Singh
> > Signed-off-by: Michal Orzel
>
> I believe you need to add your signed-off-by here as you sent the new
> version on xen
flight 165518 linux-linus real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165518/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
test-armhf-armhf-xl-rtds18 guest-start/debian.repeat fail REGR. vs. 165510
Tests which did not succeed,
Hi Julien,
> On 15 Oct 2021, at 16:18, Julien Grall wrote:
>
> Hi Bertrand,
>
> On 15/10/2021 16:06, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 15:30, Roger Pau Monné wrote:
>>>
>>> On Fri, Oct 15, 2021 at 02:59:19PM +0100, Bertrand Marquis wrote:
From: Rahul Singh
The ex
Hi,
> On 15 Oct 2021, at 16:20, Stefano Stabellini wrote:
>
> On Fri, 15 Oct 2021, Bertrand Marquis wrote:
>> Hi,
>>
>>> On 15 Oct 2021, at 16:10, Julien Grall wrote:
>>>
>>> Hi Bertrand,
>>>
>>> On 15/10/2021 14:59, Bertrand Marquis wrote:
diff --git a/xen/drivers/passthrough/pci.c b/x
On Fri, 15 Oct 2021, Bertrand Marquis wrote:
> Hi,
>
> > On 15 Oct 2021, at 16:10, Julien Grall wrote:
> >
> > Hi Bertrand,
> >
> > On 15/10/2021 14:59, Bertrand Marquis wrote:
> >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> >> index 3aa8c3175f..082892c8a2 1006
Hi Bertrand,
On 15/10/2021 16:06, Bertrand Marquis wrote:
On 15 Oct 2021, at 15:30, Roger Pau Monné wrote:
On Fri, Oct 15, 2021 at 02:59:19PM +0100, Bertrand Marquis wrote:
From: Rahul Singh
The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via
Hi,
> On 15 Oct 2021, at 16:10, Julien Grall wrote:
>
> Hi Bertrand,
>
> On 15/10/2021 14:59, Bertrand Marquis wrote:
>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>> index 3aa8c3175f..082892c8a2 100644
>> --- a/xen/drivers/passthrough/pci.c
>> +++ b/xen/drivers/
Hi Bertrand,
On 15/10/2021 14:59, Bertrand Marquis wrote:
diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
index 3aa8c3175f..082892c8a2 100644
--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus
Hi,
> On 15 Oct 2021, at 15:17, Roger Pau Monné wrote:
>
> On Fri, Oct 15, 2021 at 02:59:18PM +0100, Bertrand Marquis wrote:
>> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
>> Use ECAM/ecam instead of MCFG in common code and in new functions added
>> in common vpci code
On 15.10.21 15:16, Ian Jackson wrote:
Kevin Stefanov writes ("[PATCH v2] tools/tests: Make E2BIG non-fatal to xenstore
unit test"):
Xenstore's unit test fails on read and write of big numbers if
quota-maxsize is set to a lower number than those test cases use.
Output a special warning instead
Hi Roger,
> On 15 Oct 2021, at 15:30, Roger Pau Monné wrote:
>
> On Fri, Oct 15, 2021 at 02:59:19PM +0100, Bertrand Marquis wrote:
>> From: Rahul Singh
>>
>> The existing VPCI support available for X86 is adapted for Arm.
>> When the device is added to XEN via the hyper call
>> “PHYSDEVOP_pci_
Hi Julien,
> On 15 Oct 2021, at 15:52, Julien Grall wrote:
>
> Hi Bertrand,
>
> On 15/10/2021 14:59, Bertrand Marquis wrote:
>> From: Rahul Singh
>> libxl will create an emulated PCI device tree node in the device tree to
>> enable the guest OS to discover the virtual PCI during guest boot.
>>
Hi Bertrand,
On 15/10/2021 14:59, Bertrand Marquis wrote:
From: Rahul Singh
libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device as
Commit b24413180f5600 ("License cleanup: add SPDX GPL-2.0 license
identifier to files with no license") was meant to do a tree-wide
cleanup for files without any license information by adding a SPDX
GPL-2.0 line to them.
Unfortunately this was applied even to several Xen-related headers
which have
On Fri, Oct 15, 2021 at 03:00:21PM +0100, Luca Fancellu wrote:
>
>
> > On 15 Oct 2021, at 14:47, Roger Pau Monné wrote:
> >
> > On Fri, Oct 15, 2021 at 10:48:41AM +, Bertrand Marquis wrote:
> >> Hi Jan,
> >>
> >>> On 15 Oct 2021, at 11:41, Jan Beulich wrote:
> >>>
> >>> On 15.10.2021 12:
On Fri, Oct 15, 2021 at 02:59:19PM +0100, Bertrand Marquis wrote:
> From: Rahul Singh
>
> The existing VPCI support available for X86 is adapted for Arm.
> When the device is added to XEN via the hyper call
> “PHYSDEVOP_pci_device_add”, VPCI handler for the config space
> access is added to the X
Bertrand Marquis writes ("[PATCH v7 5/5] arm/libxl: Emulated PCI device tree
node in libxl"):
> From: Rahul Singh
>
> libxl will create an emulated PCI device tree node in the device tree to
> enable the guest OS to discover the virtual PCI during guest boot.
> Emulated PCI device tree node will
On 15.10.21 15:57, Jan Beulich wrote:
On 15.10.2021 14:51, Juergen Gross wrote:
When running as pv-shim the hypercall is modified today in order to
replace the functions for __HYPERVISOR_event_channel_op and
__HYPERVISOR_grant_table_op hypercalls.
Change this to call the related functions from
Bertrand Marquis writes ("[PATCH v7 3/5] tools/libxl: Modify
libxl__arch_domain_init_hw_description..."):
> From: Michal Orzel
>
> ... to take a second argument of type libxl_domain_config*
> rather than libxl_domain_build_info*.
>
> We need to pass the whole libxl_domain_config
> structure as
Bertrand Marquis writes ("[PATCH v7 4/5] tools/libxl_arm: Modify
libxl__prepare_dtb..."):
> From: Michal Orzel
>
> ... to take a second argument of type libxl_domain_config*
> rather than libxl_domain_build_info*.
>
> This change will be needed to get access from
> libxl__prepare_dtb to "num_pc
On Fri, Oct 15, 2021 at 02:59:18PM +0100, Bertrand Marquis wrote:
> PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
> Use ECAM/ecam instead of MCFG in common code and in new functions added
> in common vpci code by this patch.
>
> Move vpci_access_allowed from arch/x86/hvm/io
> On 15 Oct 2021, at 14:47, Roger Pau Monné wrote:
>
> On Fri, Oct 15, 2021 at 10:48:41AM +, Bertrand Marquis wrote:
>> Hi Jan,
>>
>>> On 15 Oct 2021, at 11:41, Jan Beulich wrote:
>>>
>>> On 15.10.2021 12:33, Bertrand Marquis wrote:
> On 15 Oct 2021, at 11:24, Jan Beulich wrote:
>>
From: Michal Orzel
... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.
This change will be needed to get access from
libxl__prepare_dtb to "num_pcidevs" field of
libxl_domain_config to check whether to create
a vPCI DT node or not.
Signed-off-by: Mic
From: Michal Orzel
... to take a second argument of type libxl_domain_config*
rather than libxl_domain_build_info*.
We need to pass the whole libxl_domain_config
structure as this will be needed later on to modify
the libxl__prepare_dtb function to also take
libxl_domain_config.
Signed-off-by:
From: Rahul Singh
libxl will create an emulated PCI device tree node in the device tree to
enable the guest OS to discover the virtual PCI during guest boot.
Emulated PCI device tree node will only be created when there is any
device assigned to guest.
A new area has been reserved in the arm gue
From: Rahul Singh
The existing VPCI support available for X86 is adapted for Arm.
When the device is added to XEN via the hyper call
“PHYSDEVOP_pci_device_add”, VPCI handler for the config space
access is added to the Xen to emulate the PCI devices config space.
A MMIO trap handler for the PCI E
PCI standard is using ECAM and not MCFG which is coming from ACPI[1].
Use ECAM/ecam instead of MCFG in common code and in new functions added
in common vpci code by this patch.
Move vpci_access_allowed from arch/x86/hvm/io.c to drivers/vpci/vpci.c.
Create vpci_ecam_{read,write} in drivers/vpci/vp
Hello All,
This serie is a follow up on Rahul serie where we included various fixes
required after review on the mailing list and a new patch to move some
of the x86 ecam related code to the common vpci code.
Most of the patches of the original serie have been merged and this
serie includes only
On 15.10.2021 14:51, Juergen Gross wrote:
> When running as pv-shim the hypercall is modified today in order to
> replace the functions for __HYPERVISOR_event_channel_op and
> __HYPERVISOR_grant_table_op hypercalls.
>
> Change this to call the related functions from the normal handlers
> instead w
On 15.10.21 10:52, Juergen Gross wrote:
On 15.10.21 10:14, Greg KH wrote:
On Fri, Oct 15, 2021 at 10:07:35AM +0200, Juergen Gross wrote:
On 13.10.21 14:01, Greg KH wrote:
On Wed, Oct 13, 2021 at 09:52:05AM +0200, Juergen Gross wrote:
Add the definition of pvUSB protocol used between the pvUSB
flight 165522 xen-unstable-smoke real [real]
http://logs.test-lab.xenproject.org/osstest/logs/165522/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass
test-arm64-arm64-xl-xsm 1
On Fri, Oct 15, 2021 at 10:48:41AM +, Bertrand Marquis wrote:
> Hi Jan,
>
> > On 15 Oct 2021, at 11:41, Jan Beulich wrote:
> >
> > On 15.10.2021 12:33, Bertrand Marquis wrote:
> >>> On 15 Oct 2021, at 11:24, Jan Beulich wrote:
> >>> On 15.10.2021 11:52, Bertrand Marquis wrote:
> > On 15
Kevin Stefanov writes ("[PATCH v2] tools/tests: Make E2BIG non-fatal to
xenstore unit test"):
> Xenstore's unit test fails on read and write of big numbers if
> quota-maxsize is set to a lower number than those test cases use.
>
> Output a special warning instead of a failure message in such case
Hi Jan,
> On 15 Oct 2021, at 14:00, Jan Beulich wrote:
>
> On 15.10.2021 14:28, Bertrand Marquis wrote:
>>> On 15 Oct 2021, at 13:18, Jan Beulich wrote:
>>> On 15.10.2021 14:13, Bertrand Marquis wrote:
> On 15 Oct 2021, at 12:35, Roger Pau Monné wrote:
> On Fri, Oct 15, 2021 at 12:18:5
On 15.10.2021 14:28, Bertrand Marquis wrote:
>> On 15 Oct 2021, at 13:18, Jan Beulich wrote:
>> On 15.10.2021 14:13, Bertrand Marquis wrote:
On 15 Oct 2021, at 12:35, Roger Pau Monné wrote:
On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote:
> On 15.10.2021 12:14, Ian Jacks
The HVM hypercall handler is missing incrementing the per hypercall
counters. Add that.
The counters for PV are handled wrong, as they are not using
perf_incra() with the number of the hypercall as index, but are
incrementing the total number of hypercalls only. Fix that.
Signed-off-by: Juergen G
Instead of using a function table use the generated switch statement
macros for calling the appropriate hypercall handlers.
This makes the calls of the handlers type safe.
For deprecated hypercalls define stub functions.
Signed-off-by: Juergen Gross
---
xen/arch/arm/traps.c | 119 ++---
Instead of repeating similar data multiple times use a single source
file and a generator script for producing prototypes and call sequences
of the hypercalls.
As the script already knows the number of parameters used add generating
a macro for populating an array with the number of parameters per
Remove the hypercall handler's prototypes in the related header files
and use the generated ones instead.
Some handlers having been static before need to be made globally
visible.
Signed-off-by: Juergen Gross
---
xen/arch/x86/hvm/hypercall.c| 6 +-
xen/include/asm-x86/hypercall.h | 133 --
Instead of using a function table use the generated switch statement
macros for calling the appropriate hypercall handlers.
This is beneficial to performance and avoids speculation issues.
With calling the handlers using the correct number of parameters now
it is possible to do the parameter regi
Instead of including asm/hypercall.h always use xen/hypercall.h.
Additionally include xen/hypercall.h from all sources containing a
hypercall handler.
This prepares for generating the handlers' prototypes at build time.
Add a guard in asm/hypercall.h to catch direct inclusion.
Signed-off-by: Jue
Today the *_op_compat hypercalls call the modern handler functions by
using the entries from the hypercall table. This is resulting in a
not needed indirect function call which can be avoided by using the
correct handler function directly. This is basically a revert of
commit 1252e282311734 ("86/pv
Today most hypercall handlers have a return type of long, while the
compat ones return an int. There are a few exceptions from that rule,
however.
Get rid of the exceptions by letting compat handlers always return int
and others always return long.
For the compat hvm case use eax instead of rax f
Today Arm is using another entry point for the vcpu_op hypercall as
x86, as some of the common sub-ops are not supported on Arm. The Arm
specific handler filetrs out the not supported sub-ops and then calls
the common handler. This leads to the weird call hierarchy:
do_arm_vcpu_op()
do_vcpu_
When running as pv-shim the hypercall is modified today in order to
replace the functions for __HYPERVISOR_event_channel_op and
__HYPERVISOR_grant_table_op hypercalls.
Change this to call the related functions from the normal handlers
instead when running as shim. The performance implications are
In order to avoid indirect function calls on the hypercall path as
much as possible this series is removing the hypercall function tables
and is replacing the hypercall handler calls via the function array
by automatically generated switch statements.
Another by-product of generating the switch st
Today there is no hypercall with more than 5 parameters, while the ABI
allows up to 6 parameters. Especially for the X86 32-bit case using
6 parameters would require to run without frame pointer, which isn't
very fortunate. Note that for Arm the limit is 5 parameters already.
So limit the maximum
hvm_memory_op() should take an unsigned long as cmd, like
do_memory_op().
As hvm_memory_op() is basically just calling do_memory_op() (or
compat_memory_op()) passing through the parameters the cmd parameter
should have no smaller size than that of the called functions.
Signed-off-by: Juergen Gros
Hi Jan,
> On 15 Oct 2021, at 13:18, Jan Beulich wrote:
>
> On 15.10.2021 14:13, Bertrand Marquis wrote:
>> Hi Roger,
>>
>>> On 15 Oct 2021, at 12:35, Roger Pau Monné wrote:
>>>
>>> On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote:
On 15.10.2021 12:14, Ian Jackson wrote:
>
On 15.10.2021 14:14, Kevin Stefanov wrote:
> --- a/tools/tests/xenstore/test-xenstore.c
> +++ b/tools/tests/xenstore/test-xenstore.c
> @@ -110,8 +110,17 @@ static int call_test(struct test *tst, int iters, bool
> no_clock)
> break;
> }
>
> +/* Make E2BIG non-fatal to the te
On 15.10.2021 14:13, Bertrand Marquis wrote:
> Hi Roger,
>
>> On 15 Oct 2021, at 12:35, Roger Pau Monné wrote:
>>
>> On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote:
>>> On 15.10.2021 12:14, Ian Jackson wrote:
Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the exist
Xenstore's unit test fails on read and write of big numbers if
quota-maxsize is set to a lower number than those test cases use.
Output a special warning instead of a failure message in such cases
and make the error non-fatal to the unit test.
Signed-off-by: Kevin Stefanov
---
CC: Ian Jackson
C
Julien Grall writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree
node in libxl [and 1 more messages]"):
> Long term, I would expect a similar check to be necessary to set the
> vCPI flag at the domain creation. So it would be best to introduce an
> internal field 'vpci' to avoid dupl
Hi Roger,
> On 15 Oct 2021, at 12:35, Roger Pau Monné wrote:
>
> On Fri, Oct 15, 2021 at 12:18:59PM +0200, Jan Beulich wrote:
>> On 15.10.2021 12:14, Ian Jackson wrote:
>>> Bertrand Marquis writes ("Re: [PATCH v6 2/3] xen/arm: Enable the existing
>>> x86 virtual PCI support for ARM."):
> On
Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree
node in libxl [and 1 more messages]"):
> On 15.10.2021 13:46, Ian Jackson wrote:
> > Maybe something like
> >
> > // NB, on ARM, libxl__arch_blah directly examines num_pcidevs to
> > // decide whether to enable vpci,
Hi Michal,
On 15/10/2021 12:53, Michal Orzel wrote:
On 15.10.2021 13:46, Ian Jackson wrote:
Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree node in
libxl [and 1 more messages]"):
On 15.10.2021 12:02, Ian Jackson wrote:
Can you leave a comment somewhere (near wh
On 22.09.2021 10:21, Roger Pau Monne wrote:
> Allow setting max_grant_version to 0 in order to disable grant table
> usage by a domain. This prevents allocating the grant-table structure
> inside of Xen and requires guards to be added in several functions in
> order to prevent dereferencing the str
On 15.10.2021 13:46, Ian Jackson wrote:
> Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree
> node in libxl [and 1 more messages]"):
>> On 15.10.2021 12:02, Ian Jackson wrote:
>>> Can you leave a comment somewhere (near where c_info.passthrough is
>>> set) pointing to
On 22.09.2021 11:19, Julien Grall wrote:
> On 22/09/2021 13:21, Roger Pau Monne wrote:
>> --- a/docs/man/xl.cfg.5.pod.in
>> +++ b/docs/man/xl.cfg.5.pod.in
>> @@ -583,8 +583,8 @@ L.
>> =item B
>>
>> Specify the maximum grant table version the domain is allowed to use.
>> Current
>> -supporte
On 22.09.2021 10:21, Roger Pau Monne wrote:
> @@ -1917,11 +1918,27 @@ active_alloc_failed:
> }
>
> int grant_table_init(struct domain *d, int max_grant_frames,
> - int max_maptrack_frames)
> + int max_maptrack_frames, unsigned int options)
> {
> str
On 22.09.2021 10:21, Roger Pau Monne wrote:
> @@ -1965,6 +1969,8 @@ int grant_table_init(struct domain *d, int
> max_grant_frames,
> gt->max_grant_frames = max_grant_frames;
> gt->max_maptrack_frames = max_maptrack_frames;
> gt->max_grant_version = max_grant_version;
> +gt->allo
Michal Orzel writes ("Re: [PATCH v6 3/3] arm/libxl: Emulated PCI device tree
node in libxl [and 1 more messages]"):
> On 15.10.2021 12:02, Ian Jackson wrote:
> > Can you leave a comment somewhere (near where c_info.passthrough is
> > set) pointing to this use of num_pcidevs ? That might save some
1 - 100 of 160 matches
Mail list logo
