[xen-4.15-testing test] 163727: tolerable FAIL - PUSHED

2021-07-16 Thread osstest service owner
flight 163727 xen-4.15-testing real [real] flight 163757 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163727/ http://logs.test-lab.xenproject.org/osstest/logs/163757/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): t

[ovmf test] 163729: regressions - FAIL

2021-07-16 Thread osstest service owner
flight 163729 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163729/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[qemu-mainline bisection] complete test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow

2021-07-16 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: q

[PATCH v4 3/3] arm,smmu: add support for generic DT bindings. Implement add_device and dt_xlate.

2021-07-16 Thread Stefano Stabellini
From: Brian Woods For the legacy path, arm_smmu_dt_add_device_legacy is called by register_smmu_master scanning mmu-masters (a fwspec entry is also created.) For the generic path, arm_smmu_dt_add_device_generic gets called instead. Then, arm_smmu_dt_add_device_generic calls arm_smmu_dt_add_device

[PATCH 2/3] arm,smmu: restructure code in preparation to new bindings support

2021-07-16 Thread Stefano Stabellini
From: Brian Woods Restructure some of the code and add supporting functions for adding generic device tree (DT) binding support. This will allow for using current Linux device trees with just modifying the chosen field to enable Xen. Signed-off-by: Brian Woods Signed-off-by: Stefano Stabellini

[PATCH v4 1/3] arm,smmu: switch to using iommu_fwspec functions

2021-07-16 Thread Stefano Stabellini
From: Brian Woods Modify the smmu driver so that it uses the iommu_fwspec helper functions. This means both ARM IOMMU drivers will both use the iommu_fwspec helper functions, making enabling generic device tree bindings in the SMMU driver much cleaner. Signed-off-by: Brian Woods Signed-off-by:

[PATCH v4 0/3] Generic SMMU Bindings

2021-07-16 Thread Stefano Stabellini
Hi all, This series introduces support for the generic SMMU bindings to xen/drivers/passthrough/arm/smmu.c. Cheers, Stefano Brian Woods (3): arm,smmu: switch to using iommu_fwspec functions arm,smmu: restructure code in preparation to new bindings support arm,smmu: add suppor

Re: [PATCH RESEND v3 3/3] arm,smmu: add support for generic DT bindings. Implement add_device and dt_xlate.

2021-07-16 Thread Stefano Stabellini
On Wed, 28 Apr 2021, Julien Grall wrote: > On 13/04/2021 18:59, Stefano Stabellini wrote: > > From: Brian Woods > > > > Now that all arm iommu drivers support generic bindings we can remove > > the workaround from iommu_add_dt_device(). > > Well, it was just added in a different place in patch #

Re: [PATCH RESEND v3 1/3] arm,smmu: switch to using iommu_fwspec functions

2021-07-16 Thread Stefano Stabellini
On Wed, 28 Apr 2021, Julien Grall wrote: > Hi Stefano, > > On 13/04/2021 18:59, Stefano Stabellini wrote: > > From: Brian Woods > > > > Modify the smmu driver so that it uses the iommu_fwspec helper > > functions. This means both ARM IOMMU drivers will both use the > > iommu_fwspec helper funct

[libvirt test] 163728: regressions - FAIL

2021-07-16 Thread osstest service owner
flight 163728 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163728/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

[xen-4.14-testing test] 163726: tolerable FAIL - PUSHED

2021-07-16 Thread osstest service owner
flight 163726 xen-4.14-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/163726/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 163709 Tests which did not suc

Re: [PATCH v2] SUPPORT.md: add Dom0less as Supported

2021-07-16 Thread Stefano Stabellini
On Thu, 15 Jul 2021, Julien Grall wrote: > Hi Stefano, > > On 15/07/2021 00:48, Stefano Stabellini wrote: > > Add Dom0less to SUPPORT.md to clarify its support status. The feature is > > mature enough and small enough to make it security supported. > > I would suggest to explain the restriction i

Re: preparations for 4.15.1 and 4.13.4

2021-07-16 Thread Stefano Stabellini
On Fri, 16 Jul 2021, Julien Grall wrote: > On 15/07/2021 08:58, Jan Beulich wrote: > > All, > > Hi Jan & Stefano, > > > > the releases are due in a couple of weeks time (and 4.14.3 is > > supposed to follow another few weeks later). Please point out backports > > you find missing from the respec

Re: Suggested changes to the admission policy of the vulnerability pre-disclosure list

2021-07-16 Thread Charles-H. Schulz
Jan Beulich @ 2021-07-16 17:21 CEST: > On 16.07.2021 15:13, Charles-H. Schulz wrote: >> Jan Beulich @ 2021-07-16 09:52 CEST: >>> On 15.07.2021 23:23, Charles-H. Schulz wrote: Hello, I /we /Vates would like to suggest some changes to the policy regarding the enrollment to the

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

2021-07-16 Thread Costin Lupu
On 7/13/21 6:20 PM, Juergen Gross wrote: > On 13.07.21 17:15, Julien Grall wrote: >> Hi Juergen, >> >> On 13/07/2021 16:09, Juergen Gross wrote: >>> On 13.07.21 16:38, Julien Grall wrote: Hi Juergen, On 13/07/2021 15:23, Juergen Gross wrote: > On 13.07.21 16:19, Julien Grall wrot

Re: [RFC PATCH 3/4] xen/arm: Sanitize cpuinfo ID registers fields

2021-07-16 Thread Bertrand Marquis
Hi Julien […] >> >> + >> +if ( old_reg != new_reg ) >> +printk(XENLOG_DEBUG "SANITY DIF: %s 0x%"PRIx64" -> 0x%"PRIx64"\n", >> + reg_name, old_reg, new_reg); >> +if ( old_reg != *cur_reg ) >> +printk(XENLOG_DEBUG "SANITY FIX: %s 0x%"PRIx64" -> 0x%"PRIx64"\n",

[linux-linus test] 163723: regressions - FAIL

2021-07-16 Thread osstest service owner
flight 163723 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163723/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Anthony PERARD
On Fri, Jul 16, 2021 at 04:26:39PM +0100, George Dunlap wrote: > What this patch does is to make it so that if someone explicitly sets > CONFIG_XSM_FLASK_POLICY=y, but doesn’t have checkpolicy, the build system > will silently disable the policy behind their backs without telling them? FYI, sile

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Anthony PERARD
On Fri, Jul 16, 2021 at 02:15:28PM +0100, Andrew Cooper wrote: > On 15/07/2021 07:25, Jan Beulich wrote: > > On 14.07.2021 18:17, Anthony PERARD wrote: > >> --- a/xen/common/Kconfig > >> +++ b/xen/common/Kconfig > >> @@ -25,6 +25,9 @@ config GRANT_TABLE > >> config HAS_ALTERNATIVE > >>bool > >

Re: [PATCH v1 16/16] dma-mapping: Disallow .map_sg operations from returning zero on error

2021-07-16 Thread Logan Gunthorpe
On 2021-07-16 12:33 a.m., Christoph Hellwig wrote: > On Thu, Jul 15, 2021 at 10:45:44AM -0600, Logan Gunthorpe wrote: >> @@ -194,6 +194,8 @@ static int __dma_map_sg_attrs(struct device *dev, struct >> scatterlist *sg, >> else >> ents = ops->map_sg(dev, sg, nents, dir, attrs);

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Andrew Cooper
On 16/07/2021 16:26, George Dunlap wrote: > >> On Jul 14, 2021, at 5:17 PM, Anthony PERARD >> wrote: >> >> This will help prevent the CI loop from having build failures when >> `checkpolicy` isn't available, when doing "randconfig" jobs. > Hang on, just to clarify what’s going on here. > > ‘randc

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Anthony PERARD
On Fri, Jul 16, 2021 at 04:26:39PM +0100, George Dunlap wrote: > > > > On Jul 14, 2021, at 5:17 PM, Anthony PERARD > > wrote: > > > > This will help prevent the CI loop from having build failures when > > `checkpolicy` isn't available, when doing "randconfig" jobs. > > Hang on, just to clarif

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Juergen Gross
On 16.07.21 17:26, George Dunlap wrote: On Jul 14, 2021, at 5:17 PM, Anthony PERARD wrote: This will help prevent the CI loop from having build failures when `checkpolicy` isn't available, when doing "randconfig" jobs. Hang on, just to clarify what’s going on here. ‘randconfig’ is setting

Re: [PATCH v2] dma-mapping: use vmalloc_to_page for vmalloc addresses

2021-07-16 Thread Stefano Stabellini
On Fri, 16 Jul 2021, Roman Skakun wrote: > > Technically this looks good. But given that exposing a helper > > that does either vmalloc_to_page or virt_to_page is one of the > > never ending MM discussions I don't want to get into that discussion > > and just keep it local in the DMA code. > > > >

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread George Dunlap
> On Jul 14, 2021, at 5:17 PM, Anthony PERARD wrote: > > This will help prevent the CI loop from having build failures when > `checkpolicy` isn't available, when doing "randconfig" jobs. Hang on, just to clarify what’s going on here. ‘randconfig’ is setting CONFIG_XSM_FLASK_POLICY in the .con

Re: Suggested changes to the admission policy of the vulnerability pre-disclosure list

2021-07-16 Thread Jan Beulich
On 16.07.2021 15:13, Charles-H. Schulz wrote: > Jan Beulich @ 2021-07-16 09:52 CEST: >> On 15.07.2021 23:23, Charles-H. Schulz wrote: >>> Hello, >>> >>> I /we /Vates would like to suggest some changes to the policy regarding the >>> enrollment to the pre-disclosure mailing list of the Xen Security

Re: [PATCH v2 08/10] xsm: remove xsm_default_t from hook definitions

2021-07-16 Thread Jan Beulich
On 16.07.2021 16:15, Andrew Cooper wrote: > On 16/07/2021 08:23, Jan Beulich wrote: >> On 12.07.2021 22:32, Daniel P. Smith wrote: >>> The passing of an xsm_default_t at each of the xsm hook call sites >>> served different functions depending on whether XSM was enabled or not. >>> When XSM was not

Re: [PATCH v1] automation: collect log files in subdirectories

2021-07-16 Thread Olaf Hering
Am Fri, 16 Jul 2021 15:28:43 +0100 schrieb Anthony PERARD : > Actually, it's possible to delete the repo. > Navigate to the repo you want to delete ( > https://gitlab.com/xen-project/people/olafhering ) > then in the sidebar/menu (hopefully on the left) there is "Setting". This entry exists else

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Jan Beulich
On 16.07.2021 15:15, Andrew Cooper wrote: > On 15/07/2021 07:25, Jan Beulich wrote: >> On 14.07.2021 18:17, Anthony PERARD wrote: >>> --- a/xen/common/Kconfig >>> +++ b/xen/common/Kconfig >>> @@ -25,6 +25,9 @@ config GRANT_TABLE >>> config HAS_ALTERNATIVE >>> bool >>> >>> +config HAS_CHECKPO

Re: [PATCH v1] automation: collect log files in subdirectories

2021-07-16 Thread Anthony PERARD
On Wed, Jul 14, 2021 at 09:31:04AM +0200, Olaf Hering wrote: > Am Thu, 8 Jul 2021 12:43:41 +0100 > schrieb Andrew Cooper : > > > As for testing, get an account on Gitlab.  I'll add you to xen-project, > > after which pushes to your local fork of Xen here will use the > > project-wide runner config

Re: [PATCH v2 08/10] xsm: remove xsm_default_t from hook definitions

2021-07-16 Thread Andrew Cooper
On 16/07/2021 08:23, Jan Beulich wrote: > On 12.07.2021 22:32, Daniel P. Smith wrote: >> The passing of an xsm_default_t at each of the xsm hook call sites >> served different functions depending on whether XSM was enabled or not. >> When XSM was not enabled it attempted to function as a link-time

[qemu-mainline test] 163719: regressions - FAIL

2021-07-16 Thread osstest service owner
flight 163719 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163719/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 13 guest-startfail REGR. vs. 163321 test-amd64-amd64-

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Andrew Cooper
On 15/07/2021 07:25, Jan Beulich wrote: > On 14.07.2021 18:17, Anthony PERARD wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -25,6 +25,9 @@ config GRANT_TABLE >> config HAS_ALTERNATIVE >> bool >> >> +config HAS_CHECKPOLICY >> +def_bool $(success,$(CHECKPOLICY) -h 2

Re: Suggested changes to the admission policy of the vulnerability pre-disclosure list

2021-07-16 Thread Charles-H. Schulz
Hello, Jan Beulich @ 2021-07-16 09:52 CEST: > On 15.07.2021 23:23, Charles-H. Schulz wrote: >> Hello, >> >> I /we /Vates would like to suggest some changes to the policy regarding the >> enrollment to the pre-disclosure mailing list of the Xen Security Team. >> >> We have had some talks with th

Re: [PATCH v2 01/13] libxl/x86: check return value of SHADOW_OP_SET_ALLOCATION domctl

2021-07-16 Thread Anthony PERARD
On Mon, Jul 05, 2021 at 05:11:31PM +0200, Jan Beulich wrote: > The hypervisor may not have enough memory to satisfy the request. While > there, make the unit of the value clear by renaming the local variable. > > Requested-by: Andrew Cooper > Signed-off-by: Jan Beulich > Reviewed-by: Andrew Coop

Re: [XEN PATCH v2] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Andrew Cooper
On 16/07/2021 13:38, Anthony PERARD wrote: > This will help prevent the CI loop from having build failures when > `checkpolicy` isn't available, when doing "randconfig" jobs. > > Also, move the check out of Config.mk and into xen/ build system. > Nothing in tools/ is using that information as it's

Re: [PATCH v2] dma-mapping: use vmalloc_to_page for vmalloc addresses

2021-07-16 Thread Roman Skakun
> Technically this looks good. But given that exposing a helper > that does either vmalloc_to_page or virt_to_page is one of the > never ending MM discussions I don't want to get into that discussion > and just keep it local in the DMA code. > > Are you fine with me applying this version? Looks g

[XEN PATCH v2] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Anthony PERARD
This will help prevent the CI loop from having build failures when `checkpolicy` isn't available, when doing "randconfig" jobs. Also, move the check out of Config.mk and into xen/ build system. Nothing in tools/ is using that information as it's done by ./configure. Signed-off-by: Anthony PERARD

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

2021-07-16 Thread Anthony PERARD
On Thu, Jul 15, 2021 at 08:25:31AM +0200, Jan Beulich wrote: > On 14.07.2021 18:17, Anthony PERARD wrote: > > --- a/xen/common/Kconfig > > +++ b/xen/common/Kconfig > > @@ -25,6 +25,9 @@ config GRANT_TABLE > > config HAS_ALTERNATIVE > > bool > > > > +config HAS_CHECKPOLICY > > + def_bool $(

Re: [PATCH v1 16/16] dma-mapping: Disallow .map_sg operations from returning zero on error

2021-07-16 Thread Robin Murphy
On 2021-07-16 07:33, Christoph Hellwig wrote: On Thu, Jul 15, 2021 at 10:45:44AM -0600, Logan Gunthorpe wrote: @@ -194,6 +194,8 @@ static int __dma_map_sg_attrs(struct device *dev, struct scatterlist *sg, else ents = ops->map_sg(dev, sg, nents, dir, attrs); + WARN_ON_

Re: [PATCH v1 14/16] x86/amd_gart: return error code from gart_map_sg()

2021-07-16 Thread Robin Murphy
On 2021-07-16 07:32, Christoph Hellwig wrote: On Thu, Jul 15, 2021 at 10:45:42AM -0600, Logan Gunthorpe wrote: @@ -458,7 +460,7 @@ static int gart_map_sg(struct device *dev, struct scatterlist *sg, int nents, iommu_full(dev, pages << PAGE_SHIFT, dir); for_each_sg(sg, s, nents, i

[xen-unstable test] 163714: regressions - FAIL

2021-07-16 Thread osstest service owner
flight 163714 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163714/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-nested-amd 16 xen-boot/l1 fail REGR. vs. 163458 Tests which are fa

Re: [PATCH v2] dma-mapping: use vmalloc_to_page for vmalloc addresses

2021-07-16 Thread Christoph Hellwig
Technically this looks good. But given that exposing a helper that does either vmalloc_to_page or virt_to_page is one of the never ending MM discussions I don't want to get into that discussion and just keep it local in the DMA code. Are you fine with me applying this version? --- >From 40ac971e

[PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

2021-07-16 Thread Zhu Lingshan
From: Like Xu For "struct perf_guest_info_callbacks", the two fields "is_in_guest" and "is_user_mode" are replaced with a new multiplexed member named "state", and the "get_guest_ip" field will be renamed to "get_ip". For arm64, xen and kvm/x86, the application of DEFINE_STATIC_CALL_RET0 could m

[PATCH v2] dma-mapping: use vmalloc_to_page for vmalloc addresses

2021-07-16 Thread Roman Skakun
From: Roman Skakun This commit is dedicated to fix incorrect conversion from cpu_addr to page address in cases when we get virtual address which allocated in the vmalloc range. As the result, virt_to_page() cannot convert this address properly and return incorrect page address. Need to detect su

Re: [PATCH v1 10/16] s390/pci: return error code from s390_dma_map_sg()

2021-07-16 Thread Niklas Schnelle
On Thu, 2021-07-15 at 10:45 -0600, Logan Gunthorpe wrote: > From: Martin Oliveira > > The .map_sg() op now expects an error code instead of zero on failure. > > So propagate the error from __s390_dma_map_sg() up. > > Signed-off-by: Martin Oliveira > Signed-off-by: Logan Gunthorpe > Cc: Niklas

Re: Suggested changes to the admission policy of the vulnerability pre-disclosure list

2021-07-16 Thread Jan Beulich
On 15.07.2021 23:23, Charles-H. Schulz wrote: > Hello, > > I /we /Vates would like to suggest some changes to the policy regarding the > enrollment to the pre-disclosure mailing list of the Xen Security Team. > > We have had some talks with the French national CERT who has a need to be the > reci

Re: [PATCH v2 13/13] SUPPORT.md: write down restriction of 32-bit tool stacks

2021-07-16 Thread Julien Grall
Hi Jan, On 15/07/2021 12:36, Jan Beulich wrote: On 15.07.2021 11:05, Julien Grall wrote: On 15/07/2021 07:38, Jan Beulich wrote: On 14.07.2021 20:16, Julien Grall wrote: On 05/07/2021 16:18, Jan Beulich wrote: Let's try to avoid giving the impression that 32-bit tool stacks are as capable as

Re: preparations for 4.15.1 and 4.13.4

2021-07-16 Thread Julien Grall
On 15/07/2021 08:58, Jan Beulich wrote: All, Hi Jan & Stefano, the releases are due in a couple of weeks time (and 4.14.3 is supposed to follow another few weeks later). Please point out backports you find missing from the respective staging branches, but which you consider relevant. Please

Re: [PATCH v2 08/10] xsm: remove xsm_default_t from hook definitions

2021-07-16 Thread Jan Beulich
On 12.07.2021 22:32, Daniel P. Smith wrote: > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -30,53 +30,53 @@ static inline void xsm_security_domaininfo (struct domain > *d, > alternative_vcall(xsm_ops.security_domaininfo, d, info); > } > > -static inline int xsm_domain_cre

Re: [PATCH v2 09/10] xsm: expand the function related macros in dummy.h

2021-07-16 Thread Jan Beulich
On 12.07.2021 22:32, Daniel P. Smith wrote: > With the elimination of switching how dummy.h gets included, the function > declaration macros are no longer necessary. This commit expands them out to > the > only value for which they will ever be set. This results in function > declaration lengths c

Re: [PATCH v2 2/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG

2021-07-16 Thread Julien Grall
Hi, On 15/07/2021 16:18, Jan Beulich wrote: On 14.07.2021 22:37, Bobby Eshleman wrote: --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -16,6 +16,7 @@ * GNU General Public License for more details. */ +#include I don't think this is needed here; instead I think ... @@ -41,

Re: [PATCH v2 08/10] xsm: remove xsm_default_t from hook definitions

2021-07-16 Thread Jan Beulich
On 12.07.2021 22:32, Daniel P. Smith wrote: > The passing of an xsm_default_t at each of the xsm hook call sites > served different functions depending on whether XSM was enabled or not. > When XSM was not enabled it attempted to function as a link-time check > that declared default action at the c

Re: [PATCH v2 07/10] xsm: drop generic event channel labeling

2021-07-16 Thread Jan Beulich
On 12.07.2021 22:32, Daniel P. Smith wrote: > The generic event channel labeling has not been used by any XSM module since > its introduction. This commit removes the capability leaving FLASK labeling > field always present. In the future if a new XSM module needs to have its own > channel label, t