Re: [PATCH 1/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG

On 14.07.2021 23:03, Bob Eshleman wrote: > On 7/14/21 2:34 AM, Jan Beulich wrote: >>> +static inline bool debugger_trap_fatal( >>> +unsigned int vector, const struct cpu_user_regs *regs) >> >> I'm afraid the concept of a vector may not be arch-independent. >> > > The only way I can imagine it

Re: [PATCH v2 13/13] SUPPORT.md: write down restriction of 32-bit tool stacks

On 14.07.2021 20:16, Julien Grall wrote: > On 05/07/2021 16:18, Jan Beulich wrote: >> Let's try to avoid giving the impression that 32-bit tool stacks are as >> capable as 64-bit ones. > > Would you be able to provide a few examples of the known issues in the > commit message? This would be helpf

Re: [PATCH v2 1/4] arm/traps: remove debugger_trap_fatal() calls

On 14.07.2021 22:37, Bobby Eshleman wrote: > ARM doesn't actually use debugger_trap_* anything, and is stubbed out. > > Simply remove the calls. This also renders TRAP_invalid_op unused in > any common code, so remove that definition too. This part of the description is now stale; I guess if no o

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

On 14.07.2021 18:17, Anthony PERARD wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -25,6 +25,9 @@ config GRANT_TABLE > config HAS_ALTERNATIVE > bool > > +config HAS_CHECKPOLICY > + def_bool $(success,$(CHECKPOLICY) -h 2>&1 | grep -q xen) > + This is no different fro

[PATCH V3 09/10] xen/arm: check "xen,static-mem" property during domain construction

This commit checks "xen,static-mem" device tree property in /domUx node, to determine whether domain is on Static Allocation, when constructing domain during boot-up. Right now, the implementation of allocate_static_memory is missing, and will be introduced later. It just BUG() out at the moment.

[PATCH V3 10/10] xen/arm: introduce allocate_static_memory

This commit introduces allocate_static_memory to allocate static memory as guest RAM for Domain on Static Allocation. It uses acquire_domstatic_pages to acquire pre-configured static memory for this domain, and uses guest_physmap_add_page to set up P2M table. These pre-defined static memory banks

[linux-linus test] 163688: regressions - FAIL

flight 163688 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163688/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[PATCH V3 07/10] xen: re-define assign_pages and introduce assign_page

In order to deal with the trouble of count-to-order conversion when page number is not in a power-of-two, this commit re-define assign_pages for nr pages and assign_page for original page with a single order. Backporting confusion could be helped by altering the order of assign_pages parameters, s

[PATCH V3 06/10] xen/arm: introduce PGC_reserved

This patch introduces a new page flag PGC_reserved in order to differentiate pages of static memory from those allocated from heap. Mark pages of static memory PGC_reserved when initializing them. Signed-off-by: Penny Zheng --- v3 change: - introduce PGC_reserved when it is firstly used. --- xe

[PATCH V3 08/10] xen/arm: introduce acquire_staticmem_pages and acquire_domstatic_pages

acquire_staticmem_pages aims to acquire nr_mfns contiguous pages of static memory. And it is the equivalent of alloc_heap_pages for static memory. Here only covers acquiring pre-configured static memory. For each page, it shall check if the page is reserved(PGC_reserved) and free. It shall also do

[PATCH V3 05/10] xen/arm: static memory initialization

This patch introduces static memory initialization, during system boot up. The new function init_staticmem_pages is responsible for static memory initialization. Helper free_staticmem_pages is the equivalent of free_heap_pages, to free nr_mfns pages of static memory. This commit also introduces

[PATCH V3 03/10] xen/arm: handle static memory in dt_unreserved_regions

static memory regions overlap with memory nodes. The overlapping memory is reserved-memory and should be handled accordingly: dt_unreserved_regions should skip these regions the same way they are already skipping mem-reserved regions. Signed-off-by: Penny Zheng --- v3 changes: - extract common co

[PATCH V3 04/10] xen: introduce mark_page_free

This commit defines a new helper mark_page_free to extract common code, like following the same cache/TLB coherency policy, between free_heap_pages and the new function free_staticmem_pages, which will be introduced later. Signed-off-by: Penny Zheng --- v3 changes: - rename from "free_page" to "m

[PATCH V3 02/10] xen/arm: introduce new helper device_tree_get_meminfo

A few functions iterate over the device tree property to get memory info, like "reg" or "xen,static-mem", so this commit creates a new helper device_tree_get_meminfo to extract the common codes. Signed-off-by: Penny Zheng --- xen/arch/arm/bootfdt.c | 104 +

[PATCH V3 00/10] Domain on Static Allocation

Static Allocation refers to system or sub-system(domains) for which memory areas are pre-defined by configuration using physical address ranges. Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the beginning, shall never go to heap allocator or boot allocator for any use. Do

[PATCH V3 01/10] xen/arm: introduce domain on Static Allocation

Static Allocation refers to system or sub-system(domains) for which memory areas are pre-defined by configuration using physical address ranges. Those pre-defined memory, -- Static Memory, as parts of RAM reserved in the beginning, shall never go to heap allocator or boot allocator for any use. Do

[linux-5.4 test] 163684: tolerable FAIL - PUSHED

flight 163684 linux-5.4 real [real] flight 163699 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163684/ http://logs.test-lab.xenproject.org/osstest/logs/163699/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd6

[PATCH v2] SUPPORT.md: add Dom0less as Supported

Add Dom0less to SUPPORT.md to clarify its support status. The feature is mature enough and small enough to make it security supported. Signed-off-by: Stefano Stabellini --- Changes in v2: - clarify memory scrubbing --- SUPPORT.md | 9 + 1 file changed, 9 insertions(+) diff --git a/SUPPO

Re: [PATCH] SUPPORT.md: add Dom0less as Supported

On Wed, 14 Jul 2021, Julien Grall wrote: > Hi Stefano, > > On 14/07/2021 20:28, Stefano Stabellini wrote: > > On Wed, 14 Jul 2021, Julien Grall wrote: > > > Hi Stefano, > > > > > > On 14/07/2021 01:39, Stefano Stabellini wrote: > > > > Add Dom0less to SUPPORT.md to clarify its support status. The

Re: [PATCH 1/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG

On 7/14/21 2:34 AM, Jan Beulich wrote: > > ... we strive to have new insertions be sorted alphabetically. When > the existing section to insert into isn't suitably sorted yet, what > I normally do is try to find a place where at least the immediately > adjacent neighbors then fit the sorting goal.

[PATCH v2 4/4] x86/debug: move domain_pause_for_debugger to debugger.c

The function domain_pause_for_debugger() is conditionally compiled if CONFIG_CRASH_DEBUG=y. Instead of placing an extra #ifdef inside domain.c, this commit moves domain_pause_for_debugger() into x86/debugger.c which is only built by Kbuild given CONFIG_CRASH_DEBUG=y. Signed-off-by: Bobby Eshleman

[PATCH v2 2/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG

Previously Xen required all architectures implement the debugger_trap_* functions whether or not it actually needs them. This commit makes debugger_trap* functions resolve to arch-specific function definitions if CONFIG_CRASH_DEBUG=y, but resolves to a set of common no-op stubs if !CONFIG_CRASH_DE

[PATCH v2 3/4] x86/debug: move debugger_trap_entry into debugger.c not inlined

The function debugger_trap_entry() is somewhat large for an inlined function. This commit moves debugger_trap_entry() into debugger.c and makes it not inlined. Signed-off-by: Bobby Eshleman --- Changes in v2: - Move obj-$(CONFIG_CRASH_DEBUG) += debugger.o to be in alphabetical order - Constif

[PATCH v2 1/4] arm/traps: remove debugger_trap_fatal() calls

ARM doesn't actually use debugger_trap_* anything, and is stubbed out. Simply remove the calls. This also renders TRAP_invalid_op unused in any common code, so remove that definition too. Signed-off-by: Bobby Eshleman --- xen/arch/arm/traps.c | 6 -- 1 file changed, 6 deletions(-) diff --g

[PATCH v2 0/4] Remove unconditional arch dependency on asm/debugger.h

Currently, any architecture wishing to use common/ is likely to be required to implement the functions found in "asm/debugger.h". Some architectures, however, do not have an actual use for these functions and so are forced to implement stubs. This patch does the following: * Supplies common stubs

Re: [PATCH] SUPPORT.md: add Dom0less as Supported

Hi Stefano, On 14/07/2021 20:28, Stefano Stabellini wrote: On Wed, 14 Jul 2021, Julien Grall wrote: Hi Stefano, On 14/07/2021 01:39, Stefano Stabellini wrote: Add Dom0less to SUPPORT.md to clarify its support status. The feature is mature enough and small enough to make it security supported.

Re: [PATCH] SUPPORT.md: add Dom0less as Supported

On Wed, 14 Jul 2021, Julien Grall wrote: > Hi Stefano, > > On 14/07/2021 01:39, Stefano Stabellini wrote: > > Add Dom0less to SUPPORT.md to clarify its support status. The feature is > > mature enough and small enough to make it security supported. > > > > Signed-off-by: Stefano Stabellini > >

[qemu-mainline test] 163677: regressions - FAIL

flight 163677 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163677/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 163321 test-amd64-amd64

Re: [PATCH v2 13/13] SUPPORT.md: write down restriction of 32-bit tool stacks

Hi Jan, On 05/07/2021 16:18, Jan Beulich wrote: Let's try to avoid giving the impression that 32-bit tool stacks are as capable as 64-bit ones. Would you be able to provide a few examples of the known issues in the commit message? This would be helpful for anyone to understand why we decided

Re: [PATCH] SUPPORT.md: add Dom0less as Supported

Hi Stefano, On 14/07/2021 01:39, Stefano Stabellini wrote: Add Dom0less to SUPPORT.md to clarify its support status. The feature is mature enough and small enough to make it security supported. Signed-off-by: Stefano Stabellini diff --git a/SUPPORT.md b/SUPPORT.md index 317392d8f3..c777f3da72

Re: [PATCH v2] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission

Hi Igor, On 13/07/2021 02:31, Igor Druzhinin wrote: Current unit8_t for pirq argument in this interface is too restrictive causing failures on modern hardware with lots of GSIs. That extends down to XEN_DOMCTL_irq_permission ABI structure where it needs to be fixed up as well. Internal Xen stru

Re: [PATCH RFCv2 02/15] xen/arm: lpae: Use the generic helpers to defined the Xen PT helpers

Hi Stefano, On 13/07/2021 21:53, Stefano Stabellini wrote: On Sat, 3 Jul 2021, Julien Grall wrote: Hi Stefano, Sorry for the late answer. On 13/05/2021 23:44, Stefano Stabellini wrote: On Wed, 12 May 2021, Julien Grall wrote: Hi Stefano, On 12/05/2021 22:30, Stefano Stabellini wrote: On W

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

On 14/07/2021 17:17, Anthony PERARD wrote: > This will help prevent the CI loop from having build failures when > `checkpolicy` isn't available, when doing "randconfig" jobs. > > Signed-off-by: Anthony PERARD Thankyou for doing this. Acked-by: Andrew Cooper

[xen-unstable test] 163671: regressions - FAIL

flight 163671 xen-unstable real [real] flight 163685 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163671/ http://logs.test-lab.xenproject.org/osstest/logs/163685/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

Re: [XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

On Wed, Jul 14, 2021 at 12:23 PM Anthony PERARD wrote: > > This will help prevent the CI loop from having build failures when > `checkpolicy` isn't available, when doing "randconfig" jobs. > > Signed-off-by: Anthony PERARD Reviewed-by: Jason Andryuk

[ovmf test] 163676: regressions - FAIL

flight 163676 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163676/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[qemu-mainline bisection] complete test-amd64-i386-freebsd10-amd64

branch xen-unstable xenbranch xen-unstable job test-amd64-i386-freebsd10-amd64 testid guest-start Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.or

[linux-linus test] 163673: regressions - FAIL

flight 163673 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163673/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[XEN PATCH] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available

This will help prevent the CI loop from having build failures when `checkpolicy` isn't available, when doing "randconfig" jobs. Signed-off-by: Anthony PERARD --- Config.mk | 6 -- xen/Makefile | 2 ++ xen/common/Kconfig | 7 +-- 3 files changed, 7 insertions(+), 8 deletion

Re: [PATCH v2 03/10] xsm: remove the ability to disable flask

On 12.07.2021 22:32, Daniel P. Smith wrote: > The flask XSM module provided the ability to switch from flask back to > the dummy XSM module during runtime. With this removal the only way to > switch between XSM modules is at boot time. > > Signed-off-by: Daniel P. Smith Can you please add a stat

Re: [PATCH v2 02/10] xsm: refactor xsm_ops handling

On 13.07.2021 01:39, Andrew Cooper wrote: > On 12/07/2021 21:32, Daniel P. Smith wrote: >> diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h >> index ad3cddbf7d..a8805f514b 100644 >> --- a/xen/include/xsm/xsm.h >> +++ b/xen/include/xsm/xsm.h >> @@ -747,16 +747,14 @@ extern int xsm_dt_polic

Re: [PATCH v2 01/10] xen: Implement xen/alternative-call.h for use in common code

On 12.07.2021 22:32, Daniel P. Smith wrote: > --- a/xen/arch/x86/Kconfig > +++ b/xen/arch/x86/Kconfig > @@ -9,6 +9,7 @@ config X86 > select ARCH_SUPPORTS_INT128 > select CORE_PARKING > select HAS_ALTERNATIVE > + select ALTERNATIVE_CALL > select HAS_COMPAT > select

[libvirt test] 163669: regressions - FAIL

flight 163669 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163669/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH v4 5/5] bus: Make remove callback return void

On Tue, Jul 13, 2021 at 09:35:22PM +0200, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also re

[xen-unstable-coverity test] 163679: all pass - PUSHED

flight 163679 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/163679/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 3a98c1a4cec1a302beaddf944ded240b61173f87 baseline version: xen 6de3

Re: [PATCH 4/4] x86/debug: move domain_pause_for_debugger to debugger.c

On 13.07.2021 03:59, Bobby Eshleman wrote: > The function domain_pause_for_debugger() is conditionally compiled if > CONFIG_CRASH_DEBUG=y. Instead of placing an extra #ifdef inside > domain.c, this commit moves domain_pause_for_debugger() into > x86/debugger.c which is only built by Kbuild given C

Re: [PATCH 3/4] x86/debug: move debugger_trap_entry into debugger.c not inlined

On 13.07.2021 03:59, Bobby Eshleman wrote: > The function debugger_trap_entry() is rather large for an inlined > function. Well, yes, perhaps. > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -32,6 +32,7 @@ obj-y += emul-i8254.o > obj-y += extable.o > obj-y += flushtlb.o > obj-

Re: [PATCH 1/4] build: use common stubs for debugger_trap_* functions if !CONFIG_CRASH_DEBUG

On 13.07.2021 03:59, Bobby Eshleman wrote: > --- a/xen/arch/x86/gdbstub.c > +++ b/xen/arch/x86/gdbstub.c > @@ -18,7 +18,9 @@ > * You should have received a copy of the GNU General Public License > * along with this program; If not, see . > */ > -#include > +#inc

[qemu-mainline test] 163663: regressions - FAIL

flight 163663 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163663/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 163321 test-amd64-amd64

Re: [PATCH] stubdom: foreignmemory: Fix build after 0dbb4be739c5

On 14/07/2021 07:11, Jan Beulich wrote: On 13.07.2021 18:33, Julien Grall wrote: Hi, On 13/07/2021 17:27, Jan Beulich wrote: On 13.07.2021 18:15, Julien Grall wrote: On 13/07/2021 16:52, Jan Beulich wrote: On 13.07.2021 16:33, Julien Grall wrote: On 13/07/2021 15:23, Jan Beulich wrote:

Re: [PATCH v4 5/5] bus: Make remove callback return void

On Tue, Jul 13, 2021 at 9:35 PM Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void

[ovmf test] 163668: regressions - FAIL

flight 163668 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163668/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

Re: [PATCH v1] automation: collect log files in subdirectories

Am Thu, 8 Jul 2021 12:43:41 +0100 schrieb Andrew Cooper : > As for testing, get an account on Gitlab.  I'll add you to xen-project, > after which pushes to your local fork of Xen here will use the > project-wide runner configuration, rather than using the Gitlab's pool > of public workers (which a