[ovmf test] 163505: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163505 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163505/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[linux-linus test] 163482: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163482 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163482/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[xen-unstable-smoke test] 163503: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163503 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163503/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 163474 Tests which

[xen-unstable test] 163478: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163478 xen-unstable real [real] flight 163502 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/163478/ http://logs.test-lab.xenproject.org/osstest/logs/163502/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be r

[ovmf test] 163484: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163484 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163484/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

Re: [PATCH v2 0/3] xen: harden blkfront against malicious backends

2021-07-09 Thread Marek Marczykowski-Górecki
On Thu, Jul 08, 2021 at 04:39:58PM +0200, Juergen Gross wrote: > On 08.07.21 16:22, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 08, 2021 at 02:43:42PM +0200, Juergen Gross wrote: > > > Xen backends of para-virtualized devices can live in dom0 kernel, dom0 > > > user land, or in a driver domain. Th

[xen-unstable-smoke test] 163489: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163489 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163489/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 163474 Tests which

Re: [XEN PATCH v6 31/31] build,riscv: tell the build system about riscv64/head.S

2021-07-09 Thread Connor Davis
On 7/1/21 8:10 AM, Anthony PERARD wrote: This allows to `make arch/riscv/riscv64/head.o`. Example of rune on a fresh copy of the repository: make XEN_TARGET_ARCH=riscv64 CROSS_COMPILE=riscv64-linux-gnu- KBUILD_DEFCONFIG=tiny64_defconfig arch/riscv/riscv64/head.o Signed-off-by: Anthony

[xen-unstable-smoke bisection] complete build-amd64

2021-07-09 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree

[xen-unstable-smoke test] 163480: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163480 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163480/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 163474 Tests which

[qemu-mainline test] 163464: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163464 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163464/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 13 guest-startfail REGR. vs. 163321 test-amd64-amd64-

[ovmf test] 163475: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163475 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163475/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[linux-linus test] 163461: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163461 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163461/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: gitlab merge request -> list patchbomb workflows

2021-07-09 Thread Ian Jackson
Julien Grall writes ("Re: gitlab merge request -> list patchbomb workflows"): > I have recently started to use b4 [1] to fetch patches and collect tags > from the mailing list. I am wondering if the tools could be extended to > also allow a quick look through of the review "state" of each patch?

Re: gitlab merge request -> list patchbomb workflows

2021-07-09 Thread Julien Grall
Hi Ian, On 09/07/2021 16:48, Ian Jackson wrote: At Xen Summit we had another discussion about patch submission and review workflows. We agreed that it would be a nice idea to conduct another experiment with gitlab MRs. The previous experiment yielded negative results, but we think we might be

gitlab merge request -> list patchbomb workflows

2021-07-09 Thread Ian Jackson
At Xen Summit we had another discussion about patch submission and review workflows. We agreed that it would be a nice idea to conduct another experiment with gitlab MRs. The previous experiment yielded negative results, but we think we might be able to do better. The shape of the experiment was

Re: [PATCH] tools/misc/xen-vmtrace: handle more signals and install by default

2021-07-09 Thread Andrew Cooper
On 07/05/2021 16:28, Tamas K Lengyel wrote: > Signed-off-by: Tamas K Lengyel Acked-by: Andrew Cooper

Re: [PATCH v2] xen/arm64: Remove READ/WRITE_SYSREG32 helper macros

2021-07-09 Thread Julien Grall
Hi Michal, On 09/07/2021 13:40, Michal Orzel wrote: AArch64 system registers are 64bit whereas AArch32 ones are 32bit or 64bit. MSR/MRS are expecting 64bit values thus we should get rid of helpers READ/WRITE_SYSREG32 in favour of using READ/WRITE_SYSREG. The last place in code making use of REA

[xen-unstable-smoke test] 163474: tolerable all pass - PUSHED

2021-07-09 Thread osstest service owner
flight 163474 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163474/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[xen-unstable test] 163458: tolerable FAIL - PUSHED

2021-07-09 Thread osstest service owner
flight 163458 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163458/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 163436 test-amd64-amd64-qemuu-nested-amd 20

Re: [PATCH v2] xen/arm64: Remove READ/WRITE_SYSREG32 helper macros

2021-07-09 Thread Bertrand Marquis
Hi Michal, > On 9 Jul 2021, at 13:40, Michal Orzel wrote: > > AArch64 system registers are 64bit whereas AArch32 ones > are 32bit or 64bit. MSR/MRS are expecting 64bit values thus > we should get rid of helpers READ/WRITE_SYSREG32 > in favour of using READ/WRITE_SYSREG. > > The last place in co

Re: [PATCH v4 0/5] Fix redefinition errors for toolstack libs

2021-07-09 Thread Julien Grall
Hi, On 09/07/2021 15:58, Julien Grall wrote: Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote: For replication I used gcc 10.3 on an Alpine system. In order to replicate the redefinition error for PAGE_SIZE one should install the 'fortify-headers' package which will change the chain of inclu

Re: [PATCH v4 0/5] Fix redefinition errors for toolstack libs

2021-07-09 Thread Julien Grall
Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote: For replication I used gcc 10.3 on an Alpine system. In order to replicate the redefinition error for PAGE_SIZE one should install the 'fortify-headers' package which will change the chain of included headers by indirectly including /usr/include

[libvirt test] 163466: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163466 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163466/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

[PATCH v1 2/2] automation: provide pciutils in opensuse packages

2021-07-09 Thread Olaf Hering
qemu-xen-traditional may make use of pciutils-devel, for PCI passthrough. Signed-off-by: Olaf Hering --- automation/build/suse/opensuse-leap.dockerfile | 1 + automation/build/suse/opensuse-tumbleweed.dockerfile | 1 + 2 files changed, 2 insertions(+) diff --git a/automation/build/suse/op

[PATCH v1 1/2] automation: provide SDL and SDL2 in opensuse images

2021-07-09 Thread Olaf Hering
qemu-xen-traditional may make use of SDL, qemu-xen may make use of SDL2. Use pkgconfig() as resolvable instead of a rpm name, the latter may change. Signed-off-by: Olaf Hering --- automation/build/suse/opensuse-leap.dockerfile | 3 ++- automation/build/suse/opensuse-tumbleweed.dockerfile |

[PATCH v1] automation: add meson and ninja to tumbleweed container

2021-07-09 Thread Olaf Hering
qemu uses meson as for configuration, and requires ninja for building. Signed-off-by: Olaf Hering --- automation/build/suse/opensuse-tumbleweed.dockerfile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/automation/build/suse/opensuse-tumbleweed.dockerfile b/automation/build/suse/opensuse-

Re: [PATCH v2 3/3] xen/blkfront: don't trust the backend response data blindly

2021-07-09 Thread Juergen Gross
On 09.07.21 11:42, Roger Pau Monné wrote: On Thu, Jul 08, 2021 at 02:43:45PM +0200, Juergen Gross wrote: Today blkfront will trust the backend to send only sane response data. In order to avoid privilege escalations or crashes in case of malicious backends verify the data to be within expected l

Re: [PATCH v2 2/3] xen/blkfront: don't take local copy of a request from the ring page

2021-07-09 Thread Juergen Gross
On 09.07.21 10:55, Roger Pau Monné wrote: On Thu, Jul 08, 2021 at 02:43:44PM +0200, Juergen Gross wrote: In order to avoid a malicious backend being able to influence the local copy of a request build the request locally first and then copy it to the ring page instead of doing it the other way r

[qemu-mainline bisection] complete test-amd64-i386-qemuu-rhel6hvm-amd

2021-07-09 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemuu-rhel6hvm-amd testid redhat-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.

[ovmf test] 163460: regressions - FAIL

2021-07-09 Thread osstest service owner
flight 163460 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163460/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[PATCH v2] xen/arm64: Remove READ/WRITE_SYSREG32 helper macros

2021-07-09 Thread Michal Orzel
AArch64 system registers are 64bit whereas AArch32 ones are 32bit or 64bit. MSR/MRS are expecting 64bit values thus we should get rid of helpers READ/WRITE_SYSREG32 in favour of using READ/WRITE_SYSREG. The last place in code making use of READ/WRITE_SYSREG32 on arm64 is in TVM_REG macro defining

Re: [PATCH v2 1/2] tools/xenstore: set oom score for xenstore daemon on Linux

2021-07-09 Thread Juergen Gross
On 08.07.21 19:40, Julien Grall wrote: Hi Juergen, On 08/06/2021 06:58, Juergen Gross wrote: Xenstored is absolutely mandatory for a Xen host and it can't be restarted, so being killed by OOM-killer in case of memory shortage is to be avoided. Set /proc/$pid/oom_score_adj (if available) to -50

Re: [PATCH v1] automation: document how to refresh a container

2021-07-09 Thread Andrew Cooper
On 09/07/2021 13:23, Olaf Hering wrote: > Am Fri, 9 Jul 2021 13:02:54 +0100 > schrieb Andrew Cooper : > >> Do we need the ls here?  That sounds a little like debugging. > Maybe not, it may show a long list of unrelated stuff. > It is just to verify a fresh container exists, as you said, just for >

Re: [PATCH v1] automation: document how to refresh a container

2021-07-09 Thread Olaf Hering
Am Fri, 9 Jul 2021 13:02:54 +0100 schrieb Andrew Cooper : > Do we need the ls here?  That sounds a little like debugging. Maybe not, it may show a long list of unrelated stuff. It is just to verify a fresh container exists, as you said, just for debugging. Olaf pgpahhJuyjXXo.pgp Description: D

xenstat-exporter: [Was Re: fix vbd rd_sects stat]

2021-07-09 Thread Andrew Cooper
On 09/07/2021 12:37, Richard Kojedzinszky wrote: > Dear Andrew, > > Many thanks. > > Meanwhile I would like to promote our xenstat-exporter, which we use > for monitoring our vps instances. > > https://github.com/euronetzrt/xenstat-exporter > > We've spotted the bug during browsing the metrics. He

Re: [PATCH v1] automation: document how to refresh a container

2021-07-09 Thread Andrew Cooper
On 08/07/2021 15:56, Olaf Hering wrote: > The Tumbleweed container should be updated often. > Describe the neccessary steps how to refresh and test it before > pushing the new image to gitlab. > > Signed-off-by: Olaf Hering > --- > automation/build/README.md | 13 + > 1 file changed,

Re: [PATCH v1] automation: avoid globbering the docker run args

2021-07-09 Thread Andrew Cooper
On 08/07/2021 15:56, Olaf Hering wrote: > containerize bash -c './configure && make' fails due to shell expansion. > > Collect all arguments for the script and pass them verbatim to the > docker run command. > > Signed-off-by: Olaf Hering Acked-by: Andrew Cooper

Re: [Kvmtool] Some thoughts on using kvmtool Virtio for Xen

2021-07-09 Thread Andre Przywara
On Tue, 15 Jun 2021 07:12:08 +0100 Wei Chen wrote: Hi Wei, > I have some thoughts of using kvmtool Virtio implementation > for Xen. I copied my markdown file to this email. If you have > time, could you please help me review it? > > Any feedback is welcome! > > # Some thoughts on using kvmtool

Re: fix vbd rd_sects stat

2021-07-09 Thread Richard Kojedzinszky
Dear Andrew, Many thanks. Meanwhile I would like to promote our xenstat-exporter, which we use for monitoring our vps instances. https://github.com/euronetzrt/xenstat-exporter We've spotted the bug during browsing the metrics. Regards, Richard 2021-07-09 13:30 időpontban Andrew Cooper ezt

Re: [PATCH v2] tools: ipxe: update for fixing build with GCC11

2021-07-09 Thread Andrew Cooper
On 16/06/2021 14:14, Olaf Hering wrote: > Use a snapshot which includes commit > f3f568e382a5f19824b3bfc6081cde39eee661e8 ("[crypto] Add > memory output constraints for big-integer inline assembly"), > which fixes build with gcc11. > > Signed-off-by: Olaf Hering Acked-by: Andrew Cooper and commi

Re: fix vbd rd_sects stat

2021-07-09 Thread Andrew Cooper
On 09/07/2021 10:32, Richard Kojedzinszky wrote: > Then please add signed-by headers. :) Ok.   I have fixed up and committed the patch. https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=89d57f291e37b4769ab26db919eba46548f2e13e This will want queueing for backporting ~Andrew

Re: [PATCH v2 3/3] xen/blkfront: don't trust the backend response data blindly

2021-07-09 Thread kernel test robot
Hi Juergen, I love your patch! Perhaps something to improve: [auto build test WARNING on xen-tip/linux-next] [also build test WARNING on next-20210708] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in ht

[xen-unstable-smoke test] 163468: tolerable all pass - PUSHED

2021-07-09 Thread osstest service owner
flight 163468 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163468/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [PATCH v2 3/3] xen/blkfront: don't trust the backend response data blindly

2021-07-09 Thread Roger Pau Monné
On Thu, Jul 08, 2021 at 02:43:45PM +0200, Juergen Gross wrote: > Today blkfront will trust the backend to send only sane response data. > In order to avoid privilege escalations or crashes in case of malicious > backends verify the data to be within expected limits. Especially make > sure that the

Re: [PATCH v20210701 07/40] tools: create libxensaverestore

2021-07-09 Thread Julien Grall
Hi Olaf, On 01/07/2021 10:56, Olaf Hering wrote: Move all save/restore related code from libxenguest.so into a separate library libxensaverestore.so. The only consumer is libxl-save-helper. There is no need to have the moved code mapped all the time in binaries where libxenguest.so is used. Acc

Re: [PATCH v20210701 07/40] tools: create libxensaverestore

2021-07-09 Thread Olaf Hering
Am Fri, 9 Jul 2021 10:31:53 +0100 schrieb Julien Grall : > Were they resolved? I think so, yes. Olaf pgpzyBiz0fdoc.pgp Description: Digitale Signatur von OpenPGP

Re: fix vbd rd_sects stat

2021-07-09 Thread Richard Kojedzinszky
Then please add signed-by headers. :) Thanks 2021. július 9. 10:59:54 CEST, Andrew Cooper írta: >On 09/07/2021 09:09, Richard Kojedzinszky wrote: > >Thankyou for the patch.  That is quite an embarrassing bug. > >However, for copyright reasons, we require all submissions to contain a >Signed-off

Re: [PATCH v20210701 07/40] tools: create libxensaverestore

2021-07-09 Thread Julien Grall
Hi Olaf, On 09/07/2021 10:20, Olaf Hering wrote: Am Thu, 1 Jul 2021 11:56:02 +0200 schrieb Olaf Hering : Move all save/restore related code This is now 6 months old. What is blocking approval? There is already an ack from Wei which should be sufficient for the tools part. But looking

Re: [PATCH v20210701 07/40] tools: create libxensaverestore

2021-07-09 Thread Olaf Hering
Am Thu, 1 Jul 2021 11:56:02 +0200 schrieb Olaf Hering : > Move all save/restore related code This is now 6 months old. What is blocking approval? Olaf pgpeunYVbmhgb.pgp Description: Digitale Signatur von OpenPGP

Re: Xen/ARM API issue (page size)

2021-07-09 Thread Julien Grall
Hi Elliott, On 08/07/2021 23:05, Elliott Mitchell wrote: On Thu, Jul 08, 2021 at 05:06:42PM +0100, Julien Grall wrote: On 08/07/2021 02:05, Andrew Cooper wrote: On 08/07/2021 01:32, Elliott Mitchell wrote: Hopefully I'm not about to show the limits of my knowledge... Quite a few values passe

Re: [PATCH v4 4/5] tools/libs/gnttab: Fix PAGE_SIZE redefinition error

2021-07-09 Thread Julien Grall
On 09/07/2021 09:59, Costin Lupu wrote: Hi Julien, Hi Costin, On 7/8/21 8:33 PM, Julien Grall wrote: Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote: If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h header) then gcc will trigger a redefinition error becaus

Re: fix vbd rd_sects stat

2021-07-09 Thread Andrew Cooper
On 09/07/2021 09:09, Richard Kojedzinszky wrote: Thankyou for the patch.  That is quite an embarrassing bug. However, for copyright reasons, we require all submissions to contain a Signed-off-by line, as per the Developer's Certificate of Origin, https://wiki.xenproject.org/wiki/Submitting_Xen_Pr

Re: [PATCH v4 4/5] tools/libs/gnttab: Fix PAGE_SIZE redefinition error

2021-07-09 Thread Costin Lupu
Hi Julien, On 7/8/21 8:33 PM, Julien Grall wrote: > Hi Costin, > > On 08/06/2021 13:35, Costin Lupu wrote: >> If PAGE_SIZE is already defined in the system (e.g. in >> /usr/include/limits.h >> header) then gcc will trigger a redefinition error because of -Werror. >> This >> patch replaces usage o

Re: [PATCH v2 2/3] xen/blkfront: don't take local copy of a request from the ring page

2021-07-09 Thread Roger Pau Monné
On Thu, Jul 08, 2021 at 02:43:44PM +0200, Juergen Gross wrote: > In order to avoid a malicious backend being able to influence the local > copy of a request build the request locally first and then copy it to > the ring page instead of doing it the other way round as today. > > Signed-off-by: Juer

[linux-5.4 test] 163450: tolerable FAIL - PUSHED

2021-07-09 Thread osstest service owner
flight 163450 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/163450/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 163198 test-amd64-amd64-xl-qemut-win7-amd64 19

Re: [PATCH v2 1/3] xen/blkfront: read response from backend only once

2021-07-09 Thread Roger Pau Monné
On Thu, Jul 08, 2021 at 02:43:43PM +0200, Juergen Gross wrote: > In order to avoid problems in case the backend is modifying a response > on the ring page while the frontend has already seen it, just read the > response into a local buffer in one go and then operate on that buffer > only. > > Sign

Re: [PATCH] cirrus-ci: Fix FreeBSD build following QEMU update

2021-07-09 Thread Roger Pau Monné
On Thu, Jul 08, 2021 at 02:02:32PM +0100, Andrew Cooper wrote: > QEMU requires ninja and bash to build now. > > Signed-off-by: Andrew Cooper Acked-by: Roger Pau Monné Thanks!

fix vbd rd_sects stat

2021-07-09 Thread Richard Kojedzinszky
From d09d27e40cfbdd2dbf5aefaa40a4f46ccb268056 Mon Sep 17 00:00:00 2001 Message-Id: From: Richard Kojedzinszky Date: Fri, 9 Jul 2021 10:06:45 +0200 Subject: [PATCH] xenstat_linux.c: fix populating vbd.rd_sect --- tools/libs/stat/xenstat_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(