Re: [PATCH v1] compiler.h: define CONFIG_GCC_VERSION

On 18.06.2021 18:42, Olaf Hering wrote: > --- a/xen/include/xen/compiler.h > +++ b/xen/include/xen/compiler.h > @@ -99,6 +99,13 @@ > __asm__ ("" : "=r"(__ptr) : "0"(ptr)); \ > (typeof(ptr)) (__ptr + (off)); }) > > +#ifndef CONFIG_GCC_VERSION > +# ifdef __GNUC__ > +# define CONFIG_

Re: [PATCH v4 0/2] Introducing Hyperlaunch capability design (formerly: DomB mode of dom0less)

On 14.05.2021 05:40, Christopher Clark wrote: > We are submitting for inclusion in the Xen documentation: > > - the Hyperlaunch design document, and > - the Hyperlaunch device tree design document > > to describe a new method for launching the Xen hypervisor. > > The Hyperlaunch feature builds u

[qemu-mainline test] 163444: regressions - FAIL

flight 163444 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163444/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 13 guest-startfail REGR. vs. 163321 test-amd64-amd64-

[linux-linus test] 163439: regressions - FAIL

flight 163439 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163439/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

[ovmf test] 163441: regressions - FAIL

flight 163441 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163441/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[xen-unstable test] 163436: tolerable FAIL - PUSHED

flight 163436 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163436/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stopfail like 163386 test-armhf-armhf-libvirt 16 save

Re: Xen/ARM API issue (page size)

On Thu, Jul 08, 2021 at 05:06:42PM +0100, Julien Grall wrote: > On 08/07/2021 02:05, Andrew Cooper wrote: > > On 08/07/2021 01:32, Elliott Mitchell wrote: > >> Hopefully I'm not about to show the limits of my knowledge... > >> > >> Quite a few values passed to Xen via hypercalls include a page numb

[qemu-mainline bisection] complete test-amd64-amd64-qemuu-freebsd12-amd64

branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-freebsd12-amd64 testid guest-start Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits

Re: Backport of commit 3de218ff39b9e3f0d4

On Mon, Jul 05, 2021 at 01:58:09PM +0200, Juergen Gross wrote: > Hi Greg, > > the attached patch is a backport of upstream commit 3de218ff39b9e3f0d4 > for Linux 5.10 and older (I've checked it to apply down to 4.4). Now applied, thanks. greg k-h

Re: [PATCH v2 1/2] tools/xenstore: set oom score for xenstore daemon on Linux

Hi Juergen, On 08/06/2021 06:58, Juergen Gross wrote: Xenstored is absolutely mandatory for a Xen host and it can't be restarted, so being killed by OOM-killer in case of memory shortage is to be avoided. Set /proc/$pid/oom_score_adj (if available) to -500 in order to allow xenstored to use lar

[linux-5.4 test] 163428: regressions - FAIL

flight 163428 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/163428/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-libvirt-xsm broken in 163402 test-amd64-i386-libvirt-qemuu-deb

Re: [PATCH v4 4/5] tools/libs/gnttab: Fix PAGE_SIZE redefinition error

Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote: If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h header) then gcc will trigger a redefinition error because of -Werror. This patch replaces usage of PAGE_* macros with XC_PAGE_* macros in order to avoid confusion betw

Re: [PATCH v4 3/5] tools/libs/foreignmemory: Fix PAGE_SIZE redefinition error

Hi Costin, On 08/06/2021 13:35, Costin Lupu wrote: If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h header) then gcc will trigger a redefinition error because of -Werror. This patch replaces usage of PAGE_* macros with XC_PAGE_* macros in order to avoid confusion betw

Re: [PATCH v15 06/12] swiotlb: Use is_swiotlb_force_bounce for swiotlb data bouncing

On Tue, Jul 06, 2021 at 12:14:16PM -0700, Nathan Chancellor wrote: > On 7/6/2021 10:06 AM, Will Deacon wrote: > > On Tue, Jul 06, 2021 at 04:39:11PM +0100, Robin Murphy wrote: > > > On 2021-07-06 15:05, Christoph Hellwig wrote: > > > > On Tue, Jul 06, 2021 at 03:01:04PM +0100, Robin Murphy wrote: >

Re: [PULL 36/40] vl: switch -M parsing to keyval

On Tue, Jul 6, 2021 at 6:43 AM Paolo Bonzini wrote: > > Switch from QemuOpts to keyval. This enables the introduction > of non-scalar machine properties, and JSON syntax in the future. > > For JSON syntax to be supported right now, we would have to > consider what would happen if string-based dic

Re: Xen/ARM API issue (page size)

Hi, I will answer the two e-mails at the same time as my answer will be similar :). On 08/07/2021 02:05, Andrew Cooper wrote: On 08/07/2021 01:32, Elliott Mitchell wrote: Hopefully I'm not about to show the limits of my knowledge... Quite a few values passed to Xen via hypercalls include a

[xen-unstable-smoke test] 163445: tolerable all pass - PUSHED

flight 163445 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/163445/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile

Am Thu, 8 Jul 2021 15:44:34 +0100 schrieb Andrew Cooper : > Please include it in a series of any/all changes to the tumbleweed > container, so we can commit all patches around the same time that we > update the live containers. I sent out two individual other patches for automation, but nothing s

[PATCH v1] automation: avoid globbering the docker run args

containerize bash -c './configure && make' fails due to shell expansion. Collect all arguments for the script and pass them verbatim to the docker run command. Signed-off-by: Olaf Hering --- automation/scripts/containerize | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v1] automation: document how to refresh a container

The Tumbleweed container should be updated often. Describe the neccessary steps how to refresh and test it before pushing the new image to gitlab. Signed-off-by: Olaf Hering --- automation/build/README.md | 13 + 1 file changed, 13 insertions(+) I did not actually run the "PUSH" com

Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile

On 08/07/2021 15:33, Olaf Hering wrote: > Am Thu, 8 Jul 2021 15:30:09 +0100 > schrieb Andrew Cooper : > >> Have you rebuilt with this change in place, or shall I do that after >> committing? > The current image has the latest snapshot 20210706, so today it has no effect. > > I'm testing this new bu

Re: [RFC PATCH V4 01/12] x86/HV: Initialize shared memory boundary in the Isolation VM.

Hi Olaf: On 7/8/2021 3:34 PM, Olaf Hering wrote: On Wed, Jul 07, Tianyu Lan wrote: +++ b/include/asm-generic/mshyperv.h @@ -34,8 +34,18 @@ struct ms_hyperv_info { void __percpu **ghcb_base; It would be cool if the cover letter states which commit id this series is based on. Th

Re: [PATCH v2 0/3] xen: harden blkfront against malicious backends

On 08.07.21 16:22, Konrad Rzeszutek Wilk wrote: On Thu, Jul 08, 2021 at 02:43:42PM +0200, Juergen Gross wrote: Xen backends of para-virtualized devices can live in dom0 kernel, dom0 user land, or in a driver domain. This means that a backend might reside in a less trusted environment than the Xe

Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile

Am Thu, 8 Jul 2021 15:30:09 +0100 schrieb Andrew Cooper : > Have you rebuilt with this change in place, or shall I do that after > committing? The current image has the latest snapshot 20210706, so today it has no effect. I'm testing this new build and will update the README before pushing an up

Re: [PATCH v1] automation: use zypper dup in tumbleweed dockerfile

On 08/07/2021 14:57, Olaf Hering wrote: > The 'dup' command aligns the installed packages with the packages > found in the enabled repositories, taking the repository priorities > into account. Using this command is generally a safe thing to do. > > In the context of Tumbleweed using 'dup' is essen

Re: [PATCH v2 0/3] xen: harden blkfront against malicious backends

On Thu, Jul 08, 2021 at 02:43:42PM +0200, Juergen Gross wrote: > Xen backends of para-virtualized devices can live in dom0 kernel, dom0 > user land, or in a driver domain. This means that a backend might > reside in a less trusted environment than the Xen core components, so > a backend should not

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

Am Thu, 8 Jul 2021 13:51:49 +0100 schrieb Andrew Cooper : > That said, the tumbleweed containers were rebuilt far more recently than > that, so something is wonky... After playing with 'automation/scripts/containerize', docker image ls shows: registry.gitlab.com/xen-project/xen/suse opensuse-tu

[PATCH v1] automation: use zypper dup in tumbleweed dockerfile

The 'dup' command aligns the installed packages with the packages found in the enabled repositories, taking the repository priorities into account. Using this command is generally a safe thing to do. In the context of Tumbleweed using 'dup' is essential, because package versions might be downgrade

Re: [Resend RFC PATCH V4 13/13] x86/HV: Not set memory decrypted/encrypted during kexec alloc/free page in IVM

Hi Dave: Thanks for your review. On 7/8/2021 12:14 AM, Dave Hansen wrote: On 7/7/21 8:46 AM, Tianyu Lan wrote: @@ -598,7 +599,7 @@ void arch_kexec_unprotect_crashkres(void) */ int arch_kexec_post_alloc_pages(void *vaddr, unsigned int pages, gfp_t gfp) { - if (sev_active()) +

Re: [RFC PATCH 08/10] xsm-silo: convert silo over to domain roles

On 14.05.2021 22:54, Daniel P. Smith wrote: > --- a/xen/xsm/silo.c > +++ b/xen/xsm/silo.c > @@ -17,9 +17,11 @@ > * You should have received a copy of the GNU General Public License along > with > * this program; If not, see . > */ > -#define XSM_NO_WRAPPERS > -#

Re: [PATCH v2 3/3] xen/blkfront: don't trust the backend response data blindly

On 08.07.21 15:11, Jan Beulich wrote: On 08.07.2021 14:43, Juergen Gross wrote: Today blkfront will trust the backend to send only sane response data. In order to avoid privilege escalations or crashes in case of malicious backends verify the data to be within expected limits. Especially make su

Re: [PATCH v2 3/3] xen/blkfront: don't trust the backend response data blindly

On 08.07.2021 14:43, Juergen Gross wrote: > Today blkfront will trust the backend to send only sane response data. > In order to avoid privilege escalations or crashes in case of malicious > backends verify the data to be within expected limits. Especially make > sure that the response always refer

[PATCH] cirrus-ci: Fix FreeBSD build following QEMU update

QEMU requires ninja and bash to build now. Signed-off-by: Andrew Cooper --- CC: Anthony PERARD CC: Doug Goldstein CC: Wei Liu CC: Roger Pau Monné https://cirrus-ci.com/build/4782098465685504 is run with the build fixed --- .cirrus.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [PATCH] x86/PV: address odd UB in I/O emulation

On 08.07.2021 13:15, Andrew Cooper wrote: > On 08/07/2021 08:21, Jan Beulich wrote: >> Compilers are certainly right in detecting UB here, given that fully >> parenthesized (to express precedence) the original offending expression >> was (((stub_va + p) - ctxt->io_emul_stub) + 5), which in fact exh

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

On 08/07/2021 13:23, Olaf Hering wrote: > Am Thu, 8 Jul 2021 02:32:24 +0200 > schrieb Olaf Hering : > >> At least for Tumbleweed it is useful information. > CPE_NAME="cpe:/o:opensuse:tumbleweed:20190730" > > Two years old for a rolling release. > > Is there any documentation how to refresh the used

Re: [PATCH v2 4/4] bus: Make remove callback return void

On Tue, 6 Jul 2021 at 17:53, Uwe Kleine-König wrote: > > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void f

[PATCH v2 1/3] xen/blkfront: read response from backend only once

In order to avoid problems in case the backend is modifying a response on the ring page while the frontend has already seen it, just read the response into a local buffer in one go and then operate on that buffer only. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- drivers/block/xen-

[PATCH v2 2/3] xen/blkfront: don't take local copy of a request from the ring page

In order to avoid a malicious backend being able to influence the local copy of a request build the request locally first and then copy it to the ring page instead of doing it the other way round as today. Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich --- V2: - init variable to avoid pot

[PATCH v2 3/3] xen/blkfront: don't trust the backend response data blindly

Today blkfront will trust the backend to send only sane response data. In order to avoid privilege escalations or crashes in case of malicious backends verify the data to be within expected limits. Especially make sure that the response always references an outstanding request. Introduce a new sta

[PATCH v2 0/3] xen: harden blkfront against malicious backends

Xen backends of para-virtualized devices can live in dom0 kernel, dom0 user land, or in a driver domain. This means that a backend might reside in a less trusted environment than the Xen core components, so a backend should not be able to do harm to a Xen guest (it can still mess up I/O data, but i

[qemu-mainline test] 163420: regressions - FAIL

flight 163420 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/163420/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 13 guest-startfail REGR. vs. 163321 test-amd64-amd64-

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

Am Thu, 8 Jul 2021 02:32:24 +0200 schrieb Olaf Hering : > At least for Tumbleweed it is useful information. CPE_NAME="cpe:/o:opensuse:tumbleweed:20190730" Two years old for a rolling release. Is there any documentation how to refresh the used containers? I think for Tumbleweed this should be d

Re: [XEN PATCH v6 03/31] build: use if_changed on built_in.o

On 01/07/2021 15:09, Anthony PERARD wrote: > diff --git a/xen/Rules.mk b/xen/Rules.mk > index f778058f80a6..6a0cdfde2eed 100644 > --- a/xen/Rules.mk > +++ b/xen/Rules.mk > @@ -147,17 +147,22 @@ include $(BASEDIR)/arch/$(TARGET_ARCH)/Rules.mk > c_flags += $(CFLAGS-y) > a_flags += $(CFLAGS-y) $(AFL

Re: [PATCH] drm/xen: Implement mmap as GEM object function

ping for review Am 24.06.21 um 11:53 schrieb Thomas Zimmermann: Moving the driver-specific mmap code into a GEM object function allows for using DRM helpers for various mmap callbacks. The respective xen functions are being removed. The file_operations structure fops is now being created by the

Re: [PATCH v1] automation: collect log files in subdirectories

Am Thu, 8 Jul 2021 12:43:41 +0100 schrieb Andrew Cooper : > https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/333797480 > is a pipeline running with this patch in place. Thanks, apparently the logs are in place now. My github/gitlab username is 'olafhering'. Olaf pgpAXVCBvDr8I.pgp

Re: [PATCH v1] automation: collect log files in subdirectories

On 08/07/2021 07:54, Olaf Hering wrote: > The current single *.log pattern collects just config.log, which > usually contains little useful information. > Collect also log files in subdirectories, tools/config.log usually > contains information about configure failures. > > Signed-off-by: Olaf Heri

Re: [PATCH v1] automation: dump contents of /etc/os-release

On 08/07/2021 07:29, Olaf Hering wrote: > To aid debugging build failures, dump /etc/os-release during build. > This helps with rolling releases such as Tumbleweed to understand the > state of the build container. > > Signed-off-by: Olaf Hering Acked-by: Andrew Cooper

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

On Thu, Jul 08, 2021 at 12:23:38PM +0100, Andrew Cooper wrote: > I'd go with simply: > > "ninja is now required to build the latest version of QEMU, and not all > distros have a suitable version.  Skip the QEMU build when ninja is not > available". > > Can fix on commit if you're happy with this.

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

On 08/07/2021 11:52, Anthony PERARD wrote: > On Wed, Jul 07, 2021 at 06:46:03PM +0100, Andrew Cooper wrote: >> On 07/07/2021 17:40, Anthony PERARD wrote: >>> ninja is now required to build the latest version of QEMU, some >>> container still don't have ninja and attempting to add it breaks the >>>

Re: [PATCH] x86/PV: address odd UB in I/O emulation

On 08/07/2021 08:21, Jan Beulich wrote: > Compilers are certainly right in detecting UB here, given that fully > parenthesized (to express precedence) the original offending expression > was (((stub_va + p) - ctxt->io_emul_stub) + 5), which in fact exhibits > two overflows in pointer calculations.

RE: [PATCH 6/9] xen/arm: introduce alloc_staticmem_pages and alloc_domstatic_pages

Hi Jan > -Original Message- > From: Jan Beulich > Sent: Thursday, July 8, 2021 6:06 PM > To: Penny Zheng > Cc: Bertrand Marquis ; xen- > de...@lists.xenproject.org; sstabell...@kernel.org; Julien Grall > ; Wei Chen > Subject: Re: [PATCH 6/9] xen/arm: introduce alloc_staticmem_pages and

Re: [XEN PATCH 2/2] automation: Check if ninja is available before building QEMU

On Wed, Jul 07, 2021 at 06:46:03PM +0100, Andrew Cooper wrote: > On 07/07/2021 17:40, Anthony PERARD wrote: > > ninja is now required to build the latest version of QEMU, some > > container still don't have ninja and attempting to add it breaks the > > build for different reasons, so QEMU will be s

[ovmf test] 163426: regressions - FAIL

flight 163426 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/163426/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 162359 test-amd64-amd64-xl-qemuu

[libvirt test] 163431: regressions - FAIL

flight 163431 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/163431/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-libvirt

Re: [PATCH 6/9] xen/arm: introduce alloc_staticmem_pages and alloc_domstatic_pages

On 08.07.2021 11:09, Penny Zheng wrote: > Hi Jan > >> -Original Message- >> From: Jan Beulich >> Sent: Tuesday, July 6, 2021 2:54 PM >> To: Penny Zheng >> Cc: Bertrand Marquis ; Wei Chen >> ; xen-devel@lists.xenproject.org; >> sstabell...@kernel.org; Julien Grall >> Subject: Re: [PATCH

[linux-linus test] 163418: regressions - trouble: broken/fail/pass

flight 163418 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/163418/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-coresched-amd64-xl broken test-amd64-i386-xl-xsm7 xen-insta

RE: [PATCH 6/9] xen/arm: introduce alloc_staticmem_pages and alloc_domstatic_pages

Hi Jan > -Original Message- > From: Jan Beulich > Sent: Tuesday, July 6, 2021 2:54 PM > To: Penny Zheng > Cc: Bertrand Marquis ; Wei Chen > ; xen-devel@lists.xenproject.org; > sstabell...@kernel.org; Julien Grall > Subject: Re: [PATCH 6/9] xen/arm: introduce alloc_staticmem_pages and >

Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks

On 7/2/2021 7:22 PM, Peter Zijlstra wrote: On Tue, Jun 22, 2021 at 05:42:49PM +0800, Zhu Lingshan wrote: diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c index 8f71dd72ef95..c71af4cfba9b 100644 --- a/arch/x86/events/core.c +++ b/arch/x86/events/core.c @@ -90,6 +90,27 @@ DEFINE_STA

[xen-unstable test] 163416: trouble: broken/fail/pass

flight 163416 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/163416/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsmbroken test-amd6

Re: [RFC PATCH V4 01/12] x86/HV: Initialize shared memory boundary in the Isolation VM.

On Wed, Jul 07, Tianyu Lan wrote: > +++ b/include/asm-generic/mshyperv.h > @@ -34,8 +34,18 @@ struct ms_hyperv_info { > void __percpu **ghcb_base; It would be cool if the cover letter states which commit id this series is based on. Thanks, Olaf

[PATCH] x86/PV: address odd UB in I/O emulation

Compilers are certainly right in detecting UB here, given that fully parenthesized (to express precedence) the original offending expression was (((stub_va + p) - ctxt->io_emul_stub) + 5), which in fact exhibits two overflows in pointer calculations. We really want to calculate (p - ctxt->io_emul_s