info

2021-03-26 Thread Enza Cannizzo
Hi, I'm using xen project v 4.13.0 and I have to cross compile it for arm 64. I tried the complete compiling process with success but when I try to cross compile it returns errors in the tools compiling process. I also tried to cross compile only the hypervisor and it's ok: > ./configure > make d

[PATCH] xen/pciback: Fix incorrect type warnings

2021-03-26 Thread Muhammad Usama Anjum
Correct enum pci_channel_io_normal should be used instead of putting integer value 1. Fix following smatch warnings: drivers/xen/xen-pciback/pci_stub.c:805:40: warning: incorrect type in argument 2 (different base types) drivers/xen/xen-pciback/pci_stub.c:805:40:expected restricted pci_chann

[xen-4.12-testing test] 160432: regressions - FAIL

2021-03-26 Thread osstest service owner
flight 160432 xen-4.12-testing real [real] flight 160463 xen-4.12-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/160432/ http://logs.test-lab.xenproject.org/osstest/logs/160463/ Regressions :-( Tests which did not succeed and are blocking, including tests which could

[PATCH v2] x86/vpt: Do not take pt_migrate rwlock in some cases

2021-03-26 Thread Boris Ostrovsky
Commit 8e76aef72820 ("x86/vpt: fix race when migrating timers between vCPUs") addressed XSA-336 by introducing a per-domain rwlock that was intended to protect periodic timer during VCPU migration. Since such migration is an infrequent event no performance impact was expected. Unfortunately this t

[xen-unstable-smoke test] 160454: tolerable all pass - PUSHED

2021-03-26 Thread osstest service owner
flight 160454 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160454/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[ovmf test] 160425: all pass - PUSHED

2021-03-26 Thread osstest service owner
flight 160425 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/160425/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 4bf2a5b045ebf8b5e90d9210ad5190699bddb592 baseline version: ovmf f037af6ecbc3b55042c99

[libvirt test] 160434: regressions - FAIL

2021-03-26 Thread osstest service owner
flight 160434 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/160434/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-armhf-libvirt

[qemu-upstream-4.15-testing baseline test] 160423: tolerable FAIL

2021-03-26 Thread osstest service owner
"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 160423 qemu-upstream-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160423/ Fa

[xen-4.15-testing test] 160422: tolerable FAIL - PUSHED

2021-03-26 Thread osstest service owner
flight 160422 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/160422/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 160394 test-amd64-amd64-xl-qemut-win7-a

[xen-unstable-smoke test] 160449: tolerable all pass - PUSHED

2021-03-26 Thread osstest service owner
flight 160449 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160449/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

[PATCH v2 2/3] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Andrew Cooper
From: Jan Beulich Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC static PIT clock gating") was reported to cause boot failures on certain AMD Ryzen systems. Refine the fix to do nothing in the default case, and only attempt to configure legacy replacement mode if IRQ0 i

[PATCH for-4.15 v2 0/3] x86/hpet: Try to unbreak Ryzen 1800X systems

2021-03-26 Thread Andrew Cooper
This is a refinement of Jan's "[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally" to try and make Xen do the helpful thing on boot, rather than requiring a non-default command line option to boot in the first place. Andrew Cooper (2): x86/hpet: Factor hpet_enable_legac

[PATCH v2 1/3] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup()

2021-03-26 Thread Andrew Cooper
... in preparation to introduce a second caller. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret For 4.15. Pre-req for trying to unbreak AM

[PATCH v2 3/3] x86/hpet: Restore old configuration if Legacy Replacement mode doesn't help

2021-03-26 Thread Andrew Cooper
If Legacy Replacement mode doesn't help in check_timer(), restore the old configuration before falling back to other workarounds. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson CC: Marek Marczykowski-Górecki CC: Frédéric Pierret v2: * New.

Re: [GIT PULL] xen: branch for v5.12-rc5

2021-03-26 Thread pr-tracker-bot
The pull request you sent on Fri, 26 Mar 2021 16:20:41 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > for-linus-5.12b-rc5-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6c20f6df61ee7b8b562143504cf3e89ae802de87 Thank you! -- Deet-doot-dot,

Re: [PATCH-for-4.15 v3] tools/libs/store: tidy up libxenstore interface

2021-03-26 Thread Julien Grall
Hi Juergen, On 24/03/2021 12:39, Juergen Gross wrote: xenstore_lib.h is in need to be tidied up a little bit: - the definition of struct xs_tdb_record_hdr shouldn't be here - some symbols are not namespaced correctly - the layout of a structure with an enum inside it depends on the implement

x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > Andrew Cooper writes ("[PATCH v1.1 2/2] x86/hpet: Don't enable legacy > replacement mode unconditionally"): > > In addition, introduce a "hpet" command line option so this heuristic > > c

Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-26 Thread Roger Pau Monné
On Wed, Mar 24, 2021 at 11:34:32AM +0100, Jan Beulich wrote: > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out what the actual issue there > is, skip this

Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally"): > Thanks, but with Andrew's pending objection I don't feel like > committing it. I understand. > > I have to say that this > > > >-if ( hpet_rate ) > >+if ( hpet_rate || !hpe

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Andrew Cooper
On 26/03/2021 16:48, Jan Beulich wrote: > On 26.03.2021 17:32, Andrew Cooper wrote: >> On 26/03/2021 09:51, Jan Beulich wrote: >>> On 25.03.2021 18:21, Andrew Cooper wrote: @@ -1922,14 +1924,38 @@ static void __init check_timer(void) vector, apic1, pin1, apic2, pin2); >

Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-26 Thread Jan Beulich
On 26.03.2021 17:43, Ian Jackson wrote: > Jan Beulich writes ("[PATCH][4.15] x86/HPET: don't enable legacy replacement > mode unconditionally"): >> Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC >> static PIT clock gating") was reported to cause boot failures on certain >

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Jan Beulich
On 26.03.2021 17:32, Andrew Cooper wrote: > On 26/03/2021 09:51, Jan Beulich wrote: >> On 25.03.2021 18:21, Andrew Cooper wrote: >>> @@ -1922,14 +1924,38 @@ static void __init check_timer(void) >>> vector, apic1, pin1, apic2, pin2); >>> >>> if (pin1 != -1) { >>> +bool hpe

Re: [PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("[PATCH][4.15] x86/HPET: don't enable legacy replacement mode unconditionally"): > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen systems. Until we can figure out wh

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Andrew Cooper
On 26/03/2021 09:51, Jan Beulich wrote: > On 25.03.2021 18:21, Andrew Cooper wrote: >> --- a/docs/misc/xen-command-line.pandoc >> +++ b/docs/misc/xen-command-line.pandoc >> @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for more >> information. >> When the hmp-unsafe option is

[xen-unstable-smoke test] 160445: tolerable all pass - PUSHED

2021-03-26 Thread osstest service owner
flight 160445 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/160445/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH 1/2] tools: Drop gettext as a build dependency

2021-03-26 Thread Andrew Cooper
On 26/03/2021 14:11, Ian Jackson wrote: > Andrew Cooper writes ("[PATCH 1/2] tools: Drop gettext as a build > dependency"): >> It has not been a dependency since at least 4.13. Remove its mandatory check >> from ./configure. >> >> Annotate the dependency in the CI dockerfiles which are used for 4

[qemu-mainline test] 160418: regressions - FAIL

2021-03-26 Thread osstest service owner
flight 160418 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/160418/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-qemuu-freebsd11-amd64 16 guest-saverestore fail REGR. vs. 152631 test-amd64-am

[GIT PULL] xen: branch for v5.12-rc5

2021-03-26 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.12b-rc5-tag xen: branch for v5.12-rc5 It contains a small series with a more elegant fix of a problem which was originally fixed in rc2. Thanks. Juergen arch/x86/include/asm/xen

Re: [PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("[PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()""): > From: Andrew Cooper > > In hindsight, this was a poor move. Some of these MSRs require probing for, > cause unhelpful spew into xl dmesg, or cause spew from unit tests exp

[PATCH for-4.15 v1.1 1/3] Revert "x86/msr: drop compatibility #GP handling in guest_{rd,wr}msr()"

2021-03-26 Thread Jan Beulich
From: Andrew Cooper In hindsight, this was a poor move. Some of these MSRs require probing for, cause unhelpful spew into xl dmesg, or cause spew from unit tests explicitly checking behaviour. This restores behaviour close to that of Xen 4.14, meaning in particular that for all of the MSRs gett

Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking

2021-03-26 Thread Andrew Cooper
On 18/03/2021 21:36, Tamas K Lengyel wrote: > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. > Some > toolstack relies on the XENMEM_maximum_gpfn value to establish the maximum > addressable physical memory in the VM and for forks that have not yet been > unpaused that

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Tamas K Lengyel
On Fri, Mar 26, 2021 at 10:23 AM Marek Marczykowski-Górecki wrote: > > On Fri, Mar 26, 2021 at 01:15:42PM +, Ian Jackson wrote: > > Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy > > replacement mode unconditionally"): > > > The problem from my perspective is that

[ANNOUNCE] Xen 4.15 release update

2021-03-26 Thread Ian Jackson
I think all outstanding blockers have been addressed (although, not necessarily in an ideal way), or will be today. Please commit *all code changes* with a release ack *by the end of today*. I intend to cut a final RC on Monday (29th of March). I hope to release very soon after Easter (late in t

Re: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages]

2021-03-26 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages]"): > Andrew Cooper writes ("[PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351"): > > This is slightly complicated. Patches 1 and 2 rearrange the code to look > > and > > behave more like 4.14, and patch

Re: [PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351 [and 1 more messages]

2021-03-26 Thread Ian Jackson
Andrew Cooper writes ("[PATCH for-4.15 0/3] x86/msr: Fixes for XSA-351"): > This is slightly complicated. Patches 1 and 2 rearrange the code to look and > behave more like 4.14, and patch 3 fixes a Solaris (and turbostat) bug in a > manner which can be backported to all security trees. As far as

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Marek Marczykowski-Górecki
On Fri, Mar 26, 2021 at 01:15:42PM +, Ian Jackson wrote: > Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy > replacement mode unconditionally"): > > The problem from my perspective is that the end-users have no way to > > determine when that boot option is needing t

Re: [PATCH v2 4/7] OvmfPkg/IndustryStandard: Introduce PageTable.h

2021-03-26 Thread Tom Lendacky
On 3/25/21 10:47 AM, Anthony PERARD wrote: > We are going to use the page table structure in yet another place, > collect the types and macro that can be used from another module > rather that making yet another copy. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490 > Signed-off-by: An

Re: [PATCH 1/2] tools: Drop gettext as a build dependency

2021-03-26 Thread Ian Jackson
Andrew Cooper writes ("[PATCH 1/2] tools: Drop gettext as a build dependency"): > It has not been a dependency since at least 4.13. Remove its mandatory check > from ./configure. > > Annotate the dependency in the CI dockerfiles which are used for 4.14 or > older. Drop the dependency from Alpine

Re: [PATCH 2/2] CI: Add zstd/etc libraries to build environments

2021-03-26 Thread Ian Jackson
Andrew Cooper writes ("[PATCH 2/2] CI: Add zstd/etc libraries to build environments"): > zstd compression support is new in 4.15, but isn't currently tested anywhere > in CI. > > bzip2/zlib was missing in some cases, so add those as well. Release-Acked-by: Ian Jackson

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > TBH delaying the release for this specific problem should be seriously > considered imo. In principle I'm in favor of (3) of the above, if there > weren't the downsides I did mention in pr

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Jan Beulich
On 26.03.2021 14:43, Marek Marczykowski-Górecki wrote: > On Fri, Mar 26, 2021 at 02:30:09PM +0100, Jan Beulich wrote: >> On 26.03.2021 13:29, Ian Jackson wrote: >>> I wrote: I'm sorry, but I think it is too late for 4.15 to do this. I prefer Jan's patch which I have alread release-acked.

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Frédéric Pierret
Hi, I confirm your patch makes my Ryzen 7 1800X platform working again! To double check that I've not messed up with xen.gz on my /boot, adding hpet=legacy-replacement makes my computer reboot as the original issue. I hope this will hit stable release! Thank you for that! Best, Frédéric Le 3

[PATCH 1/2] tools: Drop gettext as a build dependency

2021-03-26 Thread Andrew Cooper
It has not been a dependency since at least 4.13. Remove its mandatory check from ./configure. Annotate the dependency in the CI dockerfiles which are used for 4.14 or older. Drop the dependency from Alpine and Ubuntu Focal which are new containers in 4.15, as well as dropping from CirrusCI and

[PATCH 2/2] CI: Add zstd/etc libraries to build environments

2021-03-26 Thread Andrew Cooper
zstd compression support is new in 4.15, but isn't currently tested anywhere in CI. bzip2/zlib was missing in some cases, so add those as well. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Doug Goldstein For 4.15. Add build time testing for a currently untested feature.

[PATCH for-4.15 0/2] CI adjustments

2021-03-26 Thread Andrew Cooper
Adjustements to CI infrastructure for changes in build dependencies. Andrew Cooper (2): tools: Drop gettext as a build dependency CI: Add zstd/etc libraries to build environments .cirrus.yml| 2 +- .travis.yml|

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Marek Marczykowski-Górecki
On Fri, Mar 26, 2021 at 02:30:09PM +0100, Jan Beulich wrote: > On 26.03.2021 13:29, Ian Jackson wrote: > > I wrote: > >> I'm sorry, but I think it is too late for 4.15 to do this. I prefer > >> Jan's patch which I have alread release-acked. > >> > >> Can someone qualified please provide a maintain

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Jan Beulich
On 26.03.2021 14:15, Ian Jackson wrote: > Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy > replacement mode unconditionally"): >> The problem from my perspective is that the end-users have no way to >> determine when that boot option is needing to be set. Having an >>

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > I guess I don't see the serial console aspect here: This sort of > boot issue can be seen on the normal screen as well. It occurs > neither too early nor too late to be visible. We could a

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Jan Beulich
On 26.03.2021 14:03, Tamas K Lengyel wrote: > On Fri, Mar 26, 2021 at 8:30 AM Ian Jackson wrote: >> >> I wrote: >>> I'm sorry, but I think it is too late for 4.15 to do this. I prefer >>> Jan's patch which I have alread release-acked. >>> >>> Can someone qualified please provide a maintainer revi

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Jan Beulich
On 26.03.2021 13:29, Ian Jackson wrote: > I wrote: >> I'm sorry, but I think it is too late for 4.15 to do this. I prefer >> Jan's patch which I have alread release-acked. >> >> Can someone qualified please provide a maintainer review for this, >> ideally today ? > > I asked Andrew on IRC: > > 1

Re: [PATCH][4.15] Performance regression due to XSA-336

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH][4.15] Performance regression due to XSA-336"): > On 26.03.2021 12:53, Ian Jackson wrote: > > This amounts to a request to consider a release ack for "x86/vpt: > > Replace per-guest pt_migrate lock with per pt lock". > > Or, as already suggested by Roger, perhaps so

Re: [PATCH][4.15] Performance regression due to XSA-336

2021-03-26 Thread Jan Beulich
On 26.03.2021 12:53, Ian Jackson wrote: > Jan Beulich writes ("Re: [PATCH][4.15] Performance regression due to > XSA-336"): >> While the change is more intrusive than one would like at this point, an >> up-to-40% regression imo makes this at least a change to be considered >> for 4.15. I will admi

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
Tamas K Lengyel writes ("Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > The problem from my perspective is that the end-users have no way to > determine when that boot option is needing to be set. Having an > installation step of "check if things explode w

Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction

2021-03-26 Thread Bertrand Marquis
Hi, > On 26 Mar 2021, at 11:56, Julien Grall wrote: > > > > On 26/03/2021 11:13, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 20 Mar 2021, at 13:13, Julien Grall wrote: >>> >>> (+ Security) >>> >>> >>> On 17/03/2021 14:56, Bertrand Marquis wrote: Hi Julien, >>> >

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Tamas K Lengyel
On Fri, Mar 26, 2021 at 8:30 AM Ian Jackson wrote: > > I wrote: > > I'm sorry, but I think it is too late for 4.15 to do this. I prefer > > Jan's patch which I have alread release-acked. > > > > Can someone qualified please provide a maintainer review for this, > > ideally today ? > > I asked And

Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking

2021-03-26 Thread Ian Jackson
Tamas K Lengyel writes ("Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking"): > On Fri, Mar 26, 2021 at 7:37 AM Ian Jackson wrote: > > Release-Acked-by: Ian Jackson > > > > *Provided that it is committed today* I'm not sure how likely that is. > > T

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
I wrote: > I'm sorry, but I think it is too late for 4.15 to do this. I prefer > Jan's patch which I have alread release-acked. > > Can someone qualified please provide a maintainer review for this, > ideally today ? I asked Andrew on IRC: 12:08 andyhhp__: Are you prepared to maintainer-ack Ja

Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking

2021-03-26 Thread Tamas K Lengyel
On Fri, Mar 26, 2021 at 7:37 AM Ian Jackson wrote: > > Tamas K Lengyel writes ("Re: [PATCH for-4.15] x86/mem_sharing: copy parent > VM's hostp2m's max_mapped_pfn during forking"): > > On Thu, Mar 18, 2021 at 5:36 PM Tamas K Lengyel > > wrote: > > > > > > When creating a VM fork copy the parent

Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME

2021-03-26 Thread Julien Grall
Hi Ian, On 26/03/2021 12:05, Ian Jackson wrote: Julien Grall writes ("[PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME"): From: Julien Grall Commit 13dd372834a4 removed the documentation for XS_RESUME, however this command is still implemented (at

Re: [PATCH for-4.15?] docs/design: Update xenstore-migration.md

2021-03-26 Thread Julien Grall
Hi Ian, On 26/03/2021 12:06, Ian Jackson wrote: Julien Grall writes ("[PATCH for-4.15?] docs/design: Update xenstore-migration.md"): From: Julien Grall It is not very clear the shared page adddress is not contained in the connection record. Additionally, it is misleading to say the grant wil

Re: [PATCH for-4.15?] docs/design: Update xenstore-migration.md

2021-03-26 Thread Ian Jackson
Julien Grall writes ("[PATCH for-4.15?] docs/design: Update xenstore-migration.md"): > From: Julien Grall > > It is not very clear the shared page adddress is not contained in the > connection record. Additionally, it is misleading to say the grant > will always point to the share paged as a dom

Re: [PATCH] tools/libfsimage: Bump SONAME to 4.16

2021-03-26 Thread Ian Jackson
Andrew Cooper writes ("[PATCH] tools/libfsimage: Bump SONAME to 4.16"): > Fixes: a04509d34d ("Branching: Update version files etc. for newly unstable") > Signed-off-by: Andrew Cooper Release-Acked-by: Ian Jackson Acked-by: Ian Jackson

Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME

2021-03-26 Thread Ian Jackson
Julien Grall writes ("[PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME"): > From: Julien Grall > > Commit 13dd372834a4 removed the documentation for XS_RESUME, however > this command is still implemented (at least in C Xenstored) and used by > libxl wh

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Ian Jackson
Andrew Cooper writes ("[PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally"): > From: Jan Beulich > > Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC > static PIT clock gating") was reported to cause boot failures on certain > AMD Ryzen system

Re: [PATCH for-4.15] changelog: note MSR access change

2021-03-26 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH for-4.15] changelog: note MSR access change"): > The change to deny all accesses to MSRs indexes not explicitly handled > prevents leaking unwanted data into guests. Release-Acked-by: Ian Jackson

Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction

2021-03-26 Thread Julien Grall
On 26/03/2021 11:13, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 20 Mar 2021, at 13:13, Julien Grall wrote: (+ Security) On 17/03/2021 14:56, Bertrand Marquis wrote: Hi Julien, Hi Bertrand, On 13 Mar 2021, at 16:06, Julien Grall wrote: From: Julien Grall Some CPUs can s

Re: [PATCH][4.15] Performance regression due to XSA-336

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH][4.15] Performance regression due to XSA-336"): > While the change is more intrusive than one would like at this point, an > up-to-40% regression imo makes this at least a change to be considered > for 4.15. I will admit though that before next week I won't get aroun

[linux-linus test] 160410: regressions - FAIL

2021-03-26 Thread osstest service owner
flight 160410 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/160410/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-xl-

Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable

2021-03-26 Thread Ian Jackson
Ian Jackson writes ("Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable"): > Jan Beulich writes ("Re: [PATCH 1/2] Branching: Update version files etc. for > newly unstable"): > > I suppose you didn't mean to leave "-rc" in there? > > You are right. I will fix it in a moment

Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable

2021-03-26 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH 1/2] Branching: Update version files etc. for newly unstable"): > I suppose you didn't mean to leave "-rc" in there? You are right. I will fix it in a moment. Ian.

Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking

2021-03-26 Thread Ian Jackson
Tamas K Lengyel writes ("Re: [PATCH for-4.15] x86/mem_sharing: copy parent VM's hostp2m's max_mapped_pfn during forking"): > On Thu, Mar 18, 2021 at 5:36 PM Tamas K Lengyel > wrote: > > > > When creating a VM fork copy the parent VM's hostp2m max_mapped_pfn value. > > Some > > toolstack relies

Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface

2021-03-26 Thread Ian Jackson
Jürgen Groß writes ("Re: [PATCH-for-4.15] tools/libs/store: cleanup libxenstore interface"): > On 24.03.21 12:30, Ian Jackson wrote: > > If you're keen to change this for 4.15, please feel free to show me > > what the patch looks like. But I would be inclined to postpone this. > > Minimal varian

Re: [PATCH for-next v2 2/2] xen/arm64: Place a speculation barrier following an ret instruction

2021-03-26 Thread Bertrand Marquis
Hi Julien, (sorry for the delay) > On 20 Mar 2021, at 13:13, Julien Grall wrote: > > (+ Security) > > > On 17/03/2021 14:56, Bertrand Marquis wrote: >> Hi Julien, > > Hi Bertrand, > >>> On 13 Mar 2021, at 16:06, Julien Grall wrote: >>> >>> From: Julien Grall >>> >>> Some CPUs can specul

[qemu-mainline bisection] complete test-amd64-amd64-qemuu-freebsd12-amd64

2021-03-26 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-qemuu-freebsd12-amd64 testid guest-saverestore Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://x

Re: [PATCH 1/2] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup()

2021-03-26 Thread Jan Beulich
On 26.03.2021 11:53, Andrew Cooper wrote: > On 26/03/2021 09:59, Jan Beulich wrote: >> On 25.03.2021 17:52, Andrew Cooper wrote: >>> +bool __init hpet_enable_legacy_replacement_mode(void) >>> +{ >>> +unsigned int id, cfg, c0_cfg, ticks, count; >>> + >>> +if ( !hpet_rate || >> I think you ne

Re: [PATCH 1/2] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup()

2021-03-26 Thread Andrew Cooper
On 26/03/2021 09:59, Jan Beulich wrote: > On 25.03.2021 17:52, Andrew Cooper wrote: >> ... in preparation to introduce a second caller. >> >> No functional change. >> >> Signed-off-by: Andrew Cooper > Generally > Reviewed-by: Jan Beulich Thanks, > but I think there's one small code change neede

Re: [PATCH 1/2] x86/hpet: Factor hpet_enable_legacy_replacement_mode() out of hpet_setup()

2021-03-26 Thread Jan Beulich
On 25.03.2021 17:52, Andrew Cooper wrote: > ... in preparation to introduce a second caller. > > No functional change. > > Signed-off-by: Andrew Cooper Generally Reviewed-by: Jan Beulich but I think there's one small code change needed plus I have two nits (and I expect that this change wouldn

Re: [PATCH v1.1 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally

2021-03-26 Thread Jan Beulich
On 25.03.2021 18:21, Andrew Cooper wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1274,9 +1274,42 @@ supported. See docs/misc/arm/big.LITTLE.txt for more > information. > When the hmp-unsafe option is disabled (default), CPUs that are not > ident

Re: [PATCH for-4.15] changelog: note MSR access change

2021-03-26 Thread Jan Beulich
On 25.03.2021 17:20, Roger Pau Monne wrote: > The change to deny all accesses to MSRs indexes not explicitly handled > prevents leaking unwanted data into guests. > > Signed-off-by: Roger Pau Monné In case it matters: Acked-by: Jan Beulich Jan

Re: [PATCH] tools/xenstored: Remove unnecessary define XC_WANT_COMPAT_MAP_FOREIGN_API

2021-03-26 Thread Jürgen Groß
On 25.03.21 12:42, Julien Grall wrote: From: Julien Grall The last use of the compat foreign API was dropped in commit 38eeb3864de4 "tools/xenstored: Drop mapping of the ring via foreign map". Therefore, we don't need to define XC_WANT_COMPAT_MAP_FOREIGN_API. Signed-off-by: Julien Grall Re

Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME

2021-03-26 Thread Jürgen Groß
On 25.03.21 19:06, Julien Grall wrote: From: Julien Grall Commit 13dd372834a4 removed the documentation for XS_RESUME, however this command is still implemented (at least in C Xenstored) and used by libxl when resuming a domain. So re-instate the documentation for the XS_RESUME. Take the oppor

Re: [PATCH for-4.15?] docs/design: Update xenstore-migration.md

2021-03-26 Thread Jürgen Groß
On 25.03.21 12:12, Julien Grall wrote: From: Julien Grall It is not very clear the shared page adddress is not contained in the connection record. Additionally, it is misleading to say the grant will always point to the share paged as a domain is free to revoke the permission. The restore code

Re: [PATCH 2/6] CHANGELOG.md: Add named PCI devices

2021-03-26 Thread Paul Durrant
On 24/03/2021 16:44, George Dunlap wrote: Signed-off-by: George Dunlap --- CC: Ian Jackson CC: Paul Durrant Reviewed-by: Paul Durrant --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f03e85bd7..8c89212f14 100644 --- a/CHANGELOG.md

Re: [PATCH for-4.15?] docs/misc: xenstored: Re-instate and tweak the documentation for XS_RESUME

2021-03-26 Thread Paul Durrant
On 25/03/2021 18:06, Julien Grall wrote: From: Julien Grall Commit 13dd372834a4 removed the documentation for XS_RESUME, however this command is still implemented (at least in C Xenstored) and used by libxl when resuming a domain. So re-instate the documentation for the XS_RESUME. Take the opp