[PATCH] irq: simplify condition in irq_matrix_reserve()

2021-02-10 Thread Juergen Gross
The if condition in irq_matrix_reserve() can be much simpler. While at it fix a typo in the comment. Signed-off-by: Juergen Gross --- kernel/irq/matrix.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/kernel/irq/matrix.c b/kernel/irq/matrix.c index 651a4ad6d711..1f02a5

Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall

2021-02-10 Thread Jürgen Groß
On 10.02.21 18:06, Julien Grall wrote: From: Julien Grall After Commit 3499ba8198cad ("xen: Fix event channel callback via INTX/GSI"), xenbus_probe() will be called too early on Arm. This will recent to a guest hang during boot. If there hang wasn't there, we would have ended up to call xenbus

[xen-4.12-testing test] 159201: regressions - trouble: blocked/broken/fail/pass

2021-02-10 Thread osstest service owner
flight 159201 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/159201/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt broken test-amd64-amd64-amd64-pvgrub

[linux-5.4 test] 159200: regressions - FAIL

2021-02-10 Thread osstest service owner
flight 159200 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/159200/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 158387 test-arm64-arm64-xl

Re: [RFC PATCH v2] docs/design: boot domain device tree design

2021-02-10 Thread Stefano Stabellini
On Tue, 2 Feb 2021, Daniel P. Smith wrote: > This is a Request For Comments on the adoption of Device Tree as the > format for the Launch Control Module as described in the previously > posted DomB RFC. > > For RFC purposes, a rendered of this file can be found here: > ihttps://drive.google.com/fi

Stable library ABI compatibility checking

2021-02-10 Thread Andrew Cooper
Hello, Last things first, some examples: http://xenbits.xen.org/people/andrewcoop/abi/libxenevtchn-1.1_to_1.2.html http://xenbits.xen.org/people/andrewcoop/abi/libxenforeignmemory-1.3_to_1.4.html These are an ABI compatibility report between RELEASE-4.14.0 and staging. They're performed with ab

[PATCH] xen: Replace lkml.org links with lore

2021-02-10 Thread Kees Cook
As started by commit 05a5f51ca566 ("Documentation: Replace lkml.org links with lore"), replace lkml.org links with lore to better use a single source that's more likely to stay available long-term. Signed-off-by: Kees Cook --- drivers/xen/xen-acpi-processor.c | 3 ++- 1 file changed, 2 insertion

[xen-unstable-smoke test] 159220: tolerable all pass - PUSHED

2021-02-10 Thread osstest service owner
flight 159220 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159220/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall

2021-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2021, Woodhouse, David wrote: > On Wed, 2021-02-10 at 17:06 +, Julien Grall wrote: > > From: Julien Grall > > > > After Commit 3499ba8198cad ("xen: Fix event channel callback via > > INTX/GSI"), xenbus_probe() will be called too early on Arm. This will > > recent to a guest han

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread Stefano Stabellini
On Wed, 10 Feb 2021, Rahul Singh wrote: > > On 9 Feb 2021, at 8:36 pm, Stefano Stabellini > > wrote: > > On Tue, 9 Feb 2021, Rahul Singh wrote: > >>> On 8 Feb 2021, at 6:49 pm, Stefano Stabellini > >>> wrote: > >>> > >>> Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. > >>> The offe

Re: [PATCH] x86emul: fix SYSENTER/SYSCALL switching into 64-bit mode

2021-02-10 Thread Andrew Cooper
On 10/02/2021 14:18, Jan Beulich wrote: > On 10.02.2021 15:02, Andrew Cooper wrote: >> On 10/02/2021 13:54, Jan Beulich wrote: >>> Just like considered in the post-description >>> remark, we could drop the conditional part from sysexit's >>> setting of _regs.r(ip), and _then_ we would indeed need a

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread Julien Grall
On 10/02/2021 18:08, Rahul Singh wrote: Hello Julien, On 10 Feb 2021, at 5:34 pm, Julien Grall wrote: Hi, On 10/02/2021 15:06, Rahul Singh wrote: On 9 Feb 2021, at 8:36 pm, Stefano Stabellini wrote: On Tue, 9 Feb 2021, Rahul Singh wrote: On 8 Feb 2021, at 6:49 pm, Stefano Stabellini

[xen-unstable-smoke bisection] complete build-amd64

2021-02-10 Thread osstest service owner
branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64 testid xen-build Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread Rahul Singh
Hello Julien, > On 10 Feb 2021, at 5:34 pm, Julien Grall wrote: > > Hi, > > On 10/02/2021 15:06, Rahul Singh wrote: >>> On 9 Feb 2021, at 8:36 pm, Stefano Stabellini >>> wrote: >>> >>> On Tue, 9 Feb 2021, Rahul Singh wrote: > On 8 Feb 2021, at 6:49 pm, Stefano Stabellini > wrote: >

Re: [PATCH] arm/xen: Don't probe xenbus as part of an early initcall

2021-02-10 Thread Woodhouse, David
On Wed, 2021-02-10 at 17:06 +, Julien Grall wrote: > From: Julien Grall > > After Commit 3499ba8198cad ("xen: Fix event channel callback via > INTX/GSI"), xenbus_probe() will be called too early on Arm. This will > recent to a guest hang during boot. > > If there hang wasn't there, we would

[OSSTEST PATCH 2/3] production-config: Update d-i version to older Debian snapshot

2021-02-10 Thread Ian Jackson
Signed-off-by: Ian Jackson --- production-config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production-config b/production-config index d89257e5..81582ec0 100644 --- a/production-config +++ b/production-config @@ -91,7 +91,7 @@ TftpNetbootGroup osstest TftpDiVersion_whee

[OSSTEST PATCH 1/3] production-config: Rewind buster armhf snapshot to 2021-01-124

2021-02-10 Thread Ian Jackson
It seems that CC: Julien Grall CC: Stefano Stabellini Signed-off-by: Ian Jackson --- production-config | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/production-config b/production-config index f783af3c..d89257e5 100644 --- a/production-config +++ b/production-config

[OSSTEST PATCH 3/3] Disable updates for ssapshot.debian.org

2021-02-10 Thread Ian Jackson
security updates are a separate apt source. The point of using snapshot is to avoid pulling in uncontrolled updates, so we need to disable security updates. The non-security SUITE-updates are disabled by this too. But everything is on fire and I don't want another iteration while I figure out th

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread Julien Grall
Hi, On 10/02/2021 15:06, Rahul Singh wrote: On 9 Feb 2021, at 8:36 pm, Stefano Stabellini wrote: On Tue, 9 Feb 2021, Rahul Singh wrote: On 8 Feb 2021, at 6:49 pm, Stefano Stabellini wrote: Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. The offending chunk is: #define gnttab_nee

Re: [PATCH] VMX: use a single, global APIC access page

2021-02-10 Thread Jan Beulich
On 10.02.2021 18:00, Andrew Cooper wrote: > On 10/02/2021 16:48, Jan Beulich wrote: >> The address of this page is used by the CPU only to recognize when to >> instead access the virtual APIC page instead. No accesses would ever go >> to this page. It only needs to be present in the (CPU) page tabl

[PATCH] arm/xen: Don't probe xenbus as part of an early initcall

2021-02-10 Thread Julien Grall
From: Julien Grall After Commit 3499ba8198cad ("xen: Fix event channel callback via INTX/GSI"), xenbus_probe() will be called too early on Arm. This will recent to a guest hang during boot. If there hang wasn't there, we would have ended up to call xenbus_probe() twice (the second time is in xen

Re: [PATCH] VMX: use a single, global APIC access page

2021-02-10 Thread Jan Beulich
On 10.02.2021 18:00, Andrew Cooper wrote: > On 10/02/2021 16:48, Jan Beulich wrote: >> The address of this page is used by the CPU only to recognize when to >> instead access the virtual APIC page instead. No accesses would ever go >> to this page. It only needs to be present in the (CPU) page tabl

Re: [PATCH] VMX: use a single, global APIC access page

2021-02-10 Thread Andrew Cooper
On 10/02/2021 16:48, Jan Beulich wrote: > The address of this page is used by the CPU only to recognize when to > instead access the virtual APIC page instead. No accesses would ever go > to this page. It only needs to be present in the (CPU) page tables so > that address translation will produce i

Re: [PATCH 04/17] x86/PV: harden guest memory accesses against speculative abuse

2021-02-10 Thread Jan Beulich
On 09.02.2021 17:26, Roger Pau Monné wrote: > On Thu, Jan 14, 2021 at 04:04:57PM +0100, Jan Beulich wrote: >> --- a/xen/arch/x86/usercopy.c >> +++ b/xen/arch/x86/usercopy.c >> @@ -10,12 +10,19 @@ >> #include >> #include >> >> -unsigned __copy_to_user_ll(void __user *to, const void *from, unsi

[PATCH] VMX: use a single, global APIC access page

2021-02-10 Thread Jan Beulich
The address of this page is used by the CPU only to recognize when to instead access the virtual APIC page instead. No accesses would ever go to this page. It only needs to be present in the (CPU) page tables so that address translation will produce its address as result for respective accesses. B

Re: [for-4.15][PATCH v2 4/5] xen/iommu: x86: Don't leak the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 10.02.2021 16:04, Julien Grall wrote: > On 10/02/2021 14:32, Jan Beulich wrote: >> On 09.02.2021 16:28, Julien Grall wrote: >>> From: Julien Grall >>> >>> The new IOMMU page-tables allocator will release the pages when >>> relinquish the domain resources. However, this is not sufficient when >>

[ANNOUNCE] Xen 4.15 - hard codefreeze slip by one week

2021-02-10 Thread Ian Jackson
Hello. Unfortunately we are having difficulty with osstest due to a combination of an ill-timed Debian update and Linux kernel regressions which got into the upstream stable trees and thence into Debian. I have been working to try to resolve this situation. That has taken time I should have been

Re: [for-4.15][PATCH v2 3/5] xen/iommu: iommu_map: Don't crash the domain if it is dying

2021-02-10 Thread Jan Beulich
On 10.02.2021 15:58, Julien Grall wrote: > Hi Jan, > > On 10/02/2021 14:14, Jan Beulich wrote: >> On 09.02.2021 22:14, Julien Grall wrote: >>> On Tue, 9 Feb 2021 at 20:28, Paul Durrant wrote: > From: Julien Grall > Sent: 09 February 2021 15:28 > > It is a bit pointless to crash a

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 10.02.2021 16:24, Roger Pau Monné wrote: > On Wed, Feb 10, 2021 at 02:12:38PM +0100, Jan Beulich wrote: >> On 10.02.2021 12:54, Roger Pau Monné wrote: >>> On Wed, Feb 10, 2021 at 11:48:40AM +, Julien Grall wrote: It feels wrong to me to setup a per-domain mapping when initializing the >

[xen-unstable-smoke test] 159210: regressions - trouble: blocked/fail

2021-02-10 Thread osstest service owner
flight 159210 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159210/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 159191 build-arm64-

[PATCH] x86/pci: Create PCI/MSI irqdomain after x86_init.pci.arch_init()

2021-02-10 Thread Thomas Gleixner
Invoking x86_init.irqs.create_pci_msi_domain() before x86_init.pci.arch_init() breaks XEN PV. The XEN_PV specific pci.arch_init() function overrides the default create_pci_msi_domain() which is obviously too late. As a consequence the XEN PV PCI/MSI allocation goes through the native path which

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Roger Pau Monné
On Wed, Feb 10, 2021 at 02:12:38PM +0100, Jan Beulich wrote: > On 10.02.2021 12:54, Roger Pau Monné wrote: > > On Wed, Feb 10, 2021 at 11:48:40AM +, Julien Grall wrote: > >> It feels wrong to me to setup a per-domain mapping when initializing the > >> first vCPU. > >> > >> But, I was under the

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread Rahul Singh
Hello Stefano, > On 9 Feb 2021, at 8:36 pm, Stefano Stabellini wrote: > > On Tue, 9 Feb 2021, Rahul Singh wrote: >>> On 8 Feb 2021, at 6:49 pm, Stefano Stabellini >>> wrote: >>> >>> Commit 91d4eca7add broke gnttab_need_iommu_mapping on ARM. >>> The offending chunk is: >>> >>> #define gnttab_

Re: [for-4.15][PATCH v2 4/5] xen/iommu: x86: Don't leak the IOMMU page-tables

2021-02-10 Thread Julien Grall
On 10/02/2021 14:32, Jan Beulich wrote: On 09.02.2021 16:28, Julien Grall wrote: From: Julien Grall The new IOMMU page-tables allocator will release the pages when relinquish the domain resources. However, this is not sufficient when the domain is dying because nothing prevents page-table t

Re: [for-4.15][PATCH v2 3/5] xen/iommu: iommu_map: Don't crash the domain if it is dying

2021-02-10 Thread Julien Grall
Hi Jan, On 10/02/2021 14:14, Jan Beulich wrote: On 09.02.2021 22:14, Julien Grall wrote: On Tue, 9 Feb 2021 at 20:28, Paul Durrant wrote: From: Julien Grall Sent: 09 February 2021 15:28 It is a bit pointless to crash a domain that is already dying. This will become more an annoyance with a

Re: [PATCH v2] xen: workaround missing device_type property in pci/pcie nodes

2021-02-10 Thread Bertrand Marquis
Hi Stefano, > On 9 Feb 2021, at 19:53, Stefano Stabellini wrote: > > PCI buses differ from default buses in a few important ways, so it is > important to detect them properly. Normally, PCI buses are expected to > have the following property: > >device_type = "pci" > > In reality, it is no

Re: [for-4.15][PATCH v2 4/5] xen/iommu: x86: Don't leak the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 09.02.2021 16:28, Julien Grall wrote: > @@ -303,9 +317,29 @@ struct page_info *iommu_alloc_pgtable(struct domain *d) > unmap_domain_page(p); > > spin_lock(&hd->arch.pgtables.lock); > -page_list_add(pg, &hd->arch.pgtables.list); > +/* > + * The IOMMU page-tables are freed

Re: [for-4.15][PATCH v2 5/5] xen/iommu: x86: Clear the root page-table before freeing the page-tables

2021-02-10 Thread Jan Beulich
On 09.02.2021 16:28, Julien Grall wrote: > From: Julien Grall > > The new per-domain IOMMU page-table allocator will now free the > page-tables when domain's resources are relinquished. However, the root > page-table (i.e. hd->arch.pg_maddr) will not be cleared. > > Xen may access the IOMMU page

Re: [for-4.15][PATCH v2 4/5] xen/iommu: x86: Don't leak the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 09.02.2021 16:28, Julien Grall wrote: > From: Julien Grall > > The new IOMMU page-tables allocator will release the pages when > relinquish the domain resources. However, this is not sufficient when > the domain is dying because nothing prevents page-table to be allocated. > > iommu_alloc_pgt

[PATCH] x86/pci: Create PCI/MSI irqdomain after x86_init.pci.arch_init()

2021-02-10 Thread Thomas Gleixner
Invoking x86_init.irqs.create_pci_msi_domain() before x86_init.pci.arch_init() breaks XEN PV. The XEN_PV specific pci.arch_init() function overrides the default create_pci_msi_domain() which is obviously too late. As a consequence the XEN PV PCI/MSI allocation goes through the native path which r

Re: [PATCH] x86emul: fix SYSENTER/SYSCALL switching into 64-bit mode

2021-02-10 Thread Jan Beulich
On 10.02.2021 15:02, Andrew Cooper wrote: > On 10/02/2021 13:54, Jan Beulich wrote: >> On 10.02.2021 13:28, Andrew Cooper wrote: >>> On 10/02/2021 09:57, Jan Beulich wrote: When invoked by compat mode, mode_64bit() will be false at the start of emulation. The logic after complete_insn, ho

Re: [for-4.15][PATCH v2 3/5] xen/iommu: iommu_map: Don't crash the domain if it is dying

2021-02-10 Thread Jan Beulich
On 09.02.2021 22:14, Julien Grall wrote: > On Tue, 9 Feb 2021 at 20:28, Paul Durrant wrote: >>> From: Julien Grall >>> Sent: 09 February 2021 15:28 >>> >>> It is a bit pointless to crash a domain that is already dying. This will >>> become more an annoyance with a follow-up change where page-tabl

Re: [PATCH] drm/gem: Move drm_gem_fb_prepare_fb() to GEM atomic helpers

2021-02-10 Thread Thomas Zimmermann
Hi Am 10.02.21 um 14:10 schrieb Daniel Vetter: On Tue, Feb 09, 2021 at 11:29:13AM +0100, Thomas Zimmermann wrote: The function drm_gem_fb_prepare_fb() is a helper for atomic modesetting, but currently located next to framebuffer helpers. Move it to GEM atomic helpers, rename it slightly and ado

Re: [PATCH] x86emul: fix SYSENTER/SYSCALL switching into 64-bit mode

2021-02-10 Thread Andrew Cooper
On 10/02/2021 13:54, Jan Beulich wrote: > On 10.02.2021 13:28, Andrew Cooper wrote: >> On 10/02/2021 09:57, Jan Beulich wrote: >>> When invoked by compat mode, mode_64bit() will be false at the start of >>> emulation. The logic after complete_insn, however, needs to consider the >>> mode switched i

Re: [PATCH] x86emul: fix SYSENTER/SYSCALL switching into 64-bit mode

2021-02-10 Thread Jan Beulich
On 10.02.2021 13:28, Andrew Cooper wrote: > On 10/02/2021 09:57, Jan Beulich wrote: >> When invoked by compat mode, mode_64bit() will be false at the start of >> emulation. The logic after complete_insn, however, needs to consider the >> mode switched into, in particular to avoid truncating RIP. >>

[PATCH for-4.15] tools/libxl: Document where the magic MAC numbers come from

2021-02-10 Thread Andrew Cooper
Matches the comment in the xl-network-configuration manpage. Signed-off-by: Andrew Cooper --- CC: Ian Jackson CC: Wei Liu CC: Anthony PERARD --- tools/libs/light/libxl_nic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libs/light/libxl_nic.c b/tools/libs/light/libxl_nic.c index 1

[xen-unstable-smoke test] 159206: regressions - trouble: blocked/fail

2021-02-10 Thread osstest service owner
flight 159206 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/159206/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 159191 build-arm64-

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 10.02.2021 12:54, Roger Pau Monné wrote: > On Wed, Feb 10, 2021 at 11:48:40AM +, Julien Grall wrote: >> It feels wrong to me to setup a per-domain mapping when initializing the >> first vCPU. >> >> But, I was under the impression that there is plan to remove >> XEN_DOMCTL_max_vcpus. So it wo

Re: [PATCH] drm/gem: Move drm_gem_fb_prepare_fb() to GEM atomic helpers

2021-02-10 Thread Daniel Vetter
On Tue, Feb 09, 2021 at 11:29:13AM +0100, Thomas Zimmermann wrote: > The function drm_gem_fb_prepare_fb() is a helper for atomic modesetting, > but currently located next to framebuffer helpers. Move it to GEM atomic > helpers, rename it slightly and adopt the drivers. Same for the rsp > simple-pip

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 10.02.2021 12:48, Julien Grall wrote: > > > On 10/02/2021 11:45, Jan Beulich wrote: >> On 10.02.2021 12:40, Julien Grall wrote: >>> On 10/02/2021 11:38, Jan Beulich wrote: On 10.02.2021 12:34, Roger Pau Monné wrote: > On Wed, Feb 10, 2021 at 12:10:09PM +0100, Jan Beulich wrote: >>

Re: [PATCH for-4.15] x86/ucode: Fix microcode payload size for Fam19 processors

2021-02-10 Thread Andrew Cooper
On 10/02/2021 08:37, Jan Beulich wrote: > On 09.02.2021 18:39, Andrew Cooper wrote: >> On 09/02/2021 17:17, Ian Jackson wrote: >>> Jan Beulich writes ("Re: [PATCH for-4.15] x86/ucode: Fix microcode payload >>> size for Fam19 processors"): On 09.02.2021 16:33, Andrew Cooper wrote: > The or

Re: [PATCH for-4.15] x86/ucode/amd: Fix OoB read in cpu_request_microcode()

2021-02-10 Thread Andrew Cooper
On 10/02/2021 11:00, Jan Beulich wrote: > On 10.02.2021 00:40, Andrew Cooper wrote: >> verify_patch_size() is a maximum size check, and doesn't have a minimum >> bound. >> >> If the microcode container encodes a blob with a length less than 64 bytes, >> the subsequent calls to microcode_fits()/com

Re: [PATCH] x86emul: fix SYSENTER/SYSCALL switching into 64-bit mode

2021-02-10 Thread Andrew Cooper
On 10/02/2021 09:57, Jan Beulich wrote: > When invoked by compat mode, mode_64bit() will be false at the start of > emulation. The logic after complete_insn, however, needs to consider the > mode switched into, in particular to avoid truncating RIP. > > Inspired by / paralleling and extending Linux

Re: [PATCH for-4.15] x86/ucode/amd: Handle length sanity check failures more gracefully

2021-02-10 Thread Andrew Cooper
On 10/02/2021 10:55, Jan Beulich wrote: > On 09.02.2021 22:49, Andrew Cooper wrote: >> Currently, a failure of verify_patch_size() causes an early abort of the >> microcode blob loop, which in turn causes a second go around the main >> container loop, ultimately failing the UCODE_MAGIC check. >> >>

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Roger Pau Monné
On Wed, Feb 10, 2021 at 11:48:40AM +, Julien Grall wrote: > > > On 10/02/2021 11:45, Jan Beulich wrote: > > On 10.02.2021 12:40, Julien Grall wrote: > > > On 10/02/2021 11:38, Jan Beulich wrote: > > > > On 10.02.2021 12:34, Roger Pau Monné wrote: > > > > > On Wed, Feb 10, 2021 at 12:10:09PM +

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Julien Grall
On 10/02/2021 11:45, Jan Beulich wrote: On 10.02.2021 12:40, Julien Grall wrote: On 10/02/2021 11:38, Jan Beulich wrote: On 10.02.2021 12:34, Roger Pau Monné wrote: On Wed, Feb 10, 2021 at 12:10:09PM +0100, Jan Beulich wrote: On 10.02.2021 09:29, Roger Pau Monné wrote: I get the feeling t

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 10.02.2021 12:40, Julien Grall wrote: > On 10/02/2021 11:38, Jan Beulich wrote: >> On 10.02.2021 12:34, Roger Pau Monné wrote: >>> On Wed, Feb 10, 2021 at 12:10:09PM +0100, Jan Beulich wrote: On 10.02.2021 09:29, Roger Pau Monné wrote: > I get the feeling this is just papering over an e

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Julien Grall
On 10/02/2021 11:38, Jan Beulich wrote: On 10.02.2021 12:34, Roger Pau Monné wrote: On Wed, Feb 10, 2021 at 12:10:09PM +0100, Jan Beulich wrote: On 10.02.2021 09:29, Roger Pau Monné wrote: I get the feeling this is just papering over an existing issue instead of actually fixing it: IOMMU pa

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 10.02.2021 12:34, Roger Pau Monné wrote: > On Wed, Feb 10, 2021 at 12:10:09PM +0100, Jan Beulich wrote: >> On 10.02.2021 09:29, Roger Pau Monné wrote: >>> I get the feeling this is just papering over an existing issue instead >>> of actually fixing it: IOMMU page tables need to be properly freed

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Roger Pau Monné
On Wed, Feb 10, 2021 at 12:10:09PM +0100, Jan Beulich wrote: > On 10.02.2021 09:29, Roger Pau Monné wrote: > > On Tue, Feb 09, 2021 at 03:28:12PM +, Julien Grall wrote: > >> From: Julien Grall > >> > >> Currently, the IOMMU page-tables will be populated early in the domain > >> creation if the

[xen-4.11-testing test] 159194: trouble: pass/preparing/queued

2021-02-10 Thread osstest service owner
flight 159194 xen-4.11-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/159194/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm queued test-

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 09.02.2021 16:28, Julien Grall wrote: > From: Julien Grall > > Currently, the IOMMU page-tables will be populated early in the domain > creation if the hardware is able to virtualize the local APIC. However, > the IOMMU page tables will not be freed during early failure and will > result to a

[qemu-mainline test] 159176: regressions - trouble: fail/pass/preparing

2021-02-10 Thread osstest service owner
flight 159176 qemu-mainline running [real] http://logs.test-lab.xenproject.org/osstest/logs/159176/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-vhd 12 debian-di-installfail REGR. vs. 152631 test-armhf-arm

[libvirt test] 159195: regressions - trouble: blocked/fail/pass/preparing/queued/starved

2021-02-10 Thread osstest service owner
flight 159195 libvirt running [real] http://logs.test-lab.xenproject.org/osstest/logs/159195/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-arm64-libvirt

[xen-unstable test] 159156: regressions - trouble: broken/fail/pass/preparing/running

2021-02-10 Thread osstest service owner
flight 159156 xen-unstable running [real] http://logs.test-lab.xenproject.org/osstest/logs/159156/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 broken test-amd64-amd64-xl-qemut-debi

[xen-4.12-testing test] 159187: regressions - trouble: fail/pass/preparing/queued

2021-02-10 Thread osstest service owner
flight 159187 xen-4.12-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/159187/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 broken in 159052 test-amd64-amd64-pair

[linux-5.4 test] 159166: regressions - trouble: fail/pass/preparing/running

2021-02-10 Thread osstest service owner
flight 159166 linux-5.4 running [real] http://logs.test-lab.xenproject.org/osstest/logs/159166/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 14 guest-start fail REGR. vs. 158387 test-arm64-arm64-x

[linux-linus test] 159181: regressions - trouble: fail/pass/preparing/queued/running

2021-02-10 Thread osstest service owner
flight 159181 linux-linus running [real] http://logs.test-lab.xenproject.org/osstest/logs/159181/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit1 10 host-ping-check-xen fail REGR. vs. 152332 test-arm64-arm64

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Jan Beulich
On 10.02.2021 09:29, Roger Pau Monné wrote: > On Tue, Feb 09, 2021 at 03:28:12PM +, Julien Grall wrote: >> From: Julien Grall >> >> Currently, the IOMMU page-tables will be populated early in the domain >> creation if the hardware is able to virtualize the local APIC. However, >> the IOMMU pag

Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping

2021-02-10 Thread George Dunlap
> On Feb 9, 2021, at 5:31 PM, Stefano Stabellini wrote: > > On Tue, 9 Feb 2021, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH v2] xen/arm: fix gnttab_need_iommu_mapping"): >>> On 08.02.2021 21:24, Stefano Stabellini wrote: >> ... For these cases, I would just follow a simple rule o

Re: [PATCH for-4.15] x86/ucode/amd: Fix OoB read in cpu_request_microcode()

2021-02-10 Thread Jan Beulich
On 10.02.2021 00:40, Andrew Cooper wrote: > verify_patch_size() is a maximum size check, and doesn't have a minimum bound. > > If the microcode container encodes a blob with a length less than 64 bytes, > the subsequent calls to microcode_fits()/compare_header() may read off the end > of the buffe

Re: [PATCH for-4.15] x86/ucode/amd: Handle length sanity check failures more gracefully

2021-02-10 Thread Jan Beulich
On 09.02.2021 22:49, Andrew Cooper wrote: > Currently, a failure of verify_patch_size() causes an early abort of the > microcode blob loop, which in turn causes a second go around the main > container loop, ultimately failing the UCODE_MAGIC check. > > First, check for errors after the blob loop.

[PATCH] x86emul: fix SYSENTER/SYSCALL switching into 64-bit mode

2021-02-10 Thread Jan Beulich
When invoked by compat mode, mode_64bit() will be false at the start of emulation. The logic after complete_insn, however, needs to consider the mode switched into, in particular to avoid truncating RIP. Inspired by / paralleling and extending Linux commit 943dea8af21b ("KVM: x86: Update emulator

[xen-unstable-coverity test] 159197: all pass - PUSHED

2021-02-10 Thread osstest service owner
flight 159197 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/159197/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 687121f8a0e7c1ea1c4fa3d056637e5819342f14 baseline version: xen 5e7a

Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate

2021-02-10 Thread Olaf Hering
Am Wed, 10 Feb 2021 10:06:06 +0100 schrieb Olaf Hering : > -if ( ctx->save.debug && ctx->stream_type != XC_STREAM_PLAIN ) > +if ( ctx->save.debug ) This will do the verification, and finds many errors: 2021-02-10 02:37:03 MST [2149] xc: error: verify pfn 0xfda9 failed (type 0): Internal

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Julien Grall
On 10/02/2021 08:50, Julien Grall wrote: Hi Roger, On 10/02/2021 08:29, Roger Pau Monné wrote: On Tue, Feb 09, 2021 at 03:28:12PM +, Julien Grall wrote: From: Julien Grall Currently, the IOMMU page-tables will be populated early in the domain creation if the hardware is able to virtualiz

[PATCH] x86/irq: simplify loop in unmap_domain_pirq

2021-02-10 Thread Roger Pau Monne
The for loop in unmap_domain_pirq is unnecessary complicated, with several places where the index is incremented, and also different exit conditions spread between the loop body. Simplify it by looping over each possible PIRQ using the for loop syntax, and remove all possible in-loop exit points.

Re: [PATCH v20210209 4/4] xl: disable --debug option for xl migrate

2021-02-10 Thread Olaf Hering
Am Tue, 9 Feb 2021 17:12:28 + schrieb Ian Jackson : > It seems to me that something is definitely a bug here but I want to > understand from Andy what the best thing to do is. I'm hesitant to > release-ack removing this at this stage. > > Wouldn't it be better to just fix the docs like in yo

Re: [PATCH V4 24/24] [RFC] libxl: Add support for virtio-disk configuration

2021-02-10 Thread Oleksandr
On 20.01.21 19:05, Julien Grall wrote: Hi Oleksandr, Hi Julien Sorry for the late response. On 18/01/2021 08:32, Oleksandr wrote: On 16.01.21 00:01, Julien Grall wrote: Hi Oleksandr, Hi Julien On 12/01/2021 21:52, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko This

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Julien Grall
Hi Roger, On 10/02/2021 08:29, Roger Pau Monné wrote: On Tue, Feb 09, 2021 at 03:28:12PM +, Julien Grall wrote: From: Julien Grall Currently, the IOMMU page-tables will be populated early in the domain creation if the hardware is able to virtualize the local APIC. However, the IOMMU page

Re: [PATCH for-4.15] x86/ucode: Fix microcode payload size for Fam19 processors

2021-02-10 Thread Jan Beulich
On 09.02.2021 18:39, Andrew Cooper wrote: > On 09/02/2021 17:17, Ian Jackson wrote: >> Jan Beulich writes ("Re: [PATCH for-4.15] x86/ucode: Fix microcode payload >> size for Fam19 processors"): >>> On 09.02.2021 16:33, Andrew Cooper wrote: The original limit provided wasn't accurate. Blobs a

Re: [for-4.15][PATCH v2 1/5] xen/x86: p2m: Don't map the special pages in the IOMMU page-tables

2021-02-10 Thread Roger Pau Monné
On Tue, Feb 09, 2021 at 03:28:12PM +, Julien Grall wrote: > From: Julien Grall > > Currently, the IOMMU page-tables will be populated early in the domain > creation if the hardware is able to virtualize the local APIC. However, > the IOMMU page tables will not be freed during early failure an