[linux-linus test] 157442: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157442 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157442/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qem

[ovmf test] 157449: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157449 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157449/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

[libvirt test] 157453: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157453 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/157453/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-i386-libvirt

[qemu-mainline test] 157438: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157438 qemu-mainline real [real] flight 157454 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/157438/ http://logs.test-lab.xenproject.org/osstest/logs/157454/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be

Re: [PATCH v3 1/5] gitlab-ci: Document 'build-tcg-disabled' is a KVM X86 job

2020-12-11 Thread Willian Rampazzo
On Mon, Dec 7, 2020 at 10:15 AM Philippe Mathieu-Daudé wrote: > > Document what this job cover (build X86 targets with > KVM being the single accelerator available). > > Reviewed-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > --- > .gitlab-ci.yml | 5 + > 1 file changed, 5 insert

Re: [PATCH v3 1/5] gitlab-ci: Document 'build-tcg-disabled' is a KVM X86 job

2020-12-11 Thread Wainer dos Santos Moschetta
Hi, On 12/7/20 10:14 AM, Philippe Mathieu-Daudé wrote: Document what this job cover (build X86 targets with KVM being the single accelerator available). Reviewed-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- .gitlab-ci.yml | 5 + 1 file changed, 5 insertions(+) Reviewed-b

[xen-unstable test] 157433: tolerable FAIL - PUSHED

2020-12-11 Thread osstest service owner
flight 157433 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/157433/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stopfail like 157365 test-amd64-amd64-xl-qemuu-win7-amd64

Re: [patch 15/30] pinctrl: nomadik: Use irq_has_action()

2020-12-11 Thread Linus Walleij
On Thu, Dec 10, 2020 at 8:42 PM Thomas Gleixner wrote: > Let the core code do the fiddling with irq_desc. > > Signed-off-by: Thomas Gleixner > Cc: Linus Walleij > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-g...@vger.kernel.org Reviewed-by: Linus Walleij I suppose you will funnel th

[ovmf test] 157437: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157437 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157437/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

[ovmf bisection] complete test-amd64-amd64-xl-qemuu-ovmf-amd64

2020-12-11 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-amd64-xl-qemuu-ovmf-amd64 testid debian-hvm-install Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf https://github.com/tianocore/edk2.git Tree: qemu git://xen

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Thomas Gleixner
Andrew, On Fri, Dec 11 2020 at 22:21, Andrew Cooper wrote: > On 11/12/2020 21:27, Thomas Gleixner wrote: >> It's not any different from the hardware example at least not as far as >> I understood the code. > > Xen's event channels do have a couple of quirks. Why am I not surprised? > Binding an

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Andrew Cooper
On 11/12/2020 21:27, Thomas Gleixner wrote: > On Fri, Dec 11 2020 at 09:29, boris ostrovsky wrote: > >> On 12/11/20 7:37 AM, Thomas Gleixner wrote: >>> On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote: On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: > On 12/10/20 2:26 PM, Thomas Gleixn

[PATCH v4 30/32] qdev: Rename qdev_get_prop_ptr() to object_field_prop_ptr()

2020-12-11 Thread Eduardo Habkost
The function will be moved to common QOM code, as it is not specific to TYPE_DEVICE anymore. Reviewed-by: Stefan Berger Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Rename to object_field_prop_ptr() instead of object_static_prop_ptr() --- Cc: Stefan Berger Cc: Stefano Stabellini Cc:

Re: [patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 22:08, Thomas Gleixner wrote: > On Fri, Dec 11 2020 at 19:53, Andy Shevchenko wrote: > >> On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote: >>> >>> irq_set_lockdep_class() is used from modules and requires irq_to_desc() to >>> be exported. Move it into the core code w

[PATCH v4 23/32] qdev: Move dev->realized check to qdev_property_set()

2020-12-11 Thread Eduardo Habkost
Every single qdev property setter function manually checks dev->realized. We can just check dev->realized inside qdev_property_set() instead. The check is being added as a separate function (qdev_prop_allow_set()) because it will become a callback later. Reviewed-by: Stefan Berger Signed-off-by

RE: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-11 Thread David Laight
From: Thomas Gleixner > Sent: 11 December 2020 21:11 > > On Fri, Dec 11 2020 at 14:19, David Laight wrote: > > From: Thomas Gleixner > >> You can't catch that. If this really becomes an issue you need a > >> sequence counter around it. > > > > Or just two copies of the high word. > > Provided the

[PATCH v4 09/32] qdev: Make qdev_get_prop_ptr() get Object* arg

2020-12-11 Thread Eduardo Habkost
Make the code more generic and not specific to TYPE_DEVICE. Reviewed-by: Marc-André Lureau Reviewed-by: Cornelia Huck #s390 parts Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Fix build error with CONFIG_XEN I took the liberty of keeping the Reviewed-by line from Marc-André as the

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 09:29, boris ostrovsky wrote: > On 12/11/20 7:37 AM, Thomas Gleixner wrote: >> On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote: >>> On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: > Change the implementation so that t

RE: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 14:19, David Laight wrote: > From: Thomas Gleixner >> You can't catch that. If this really becomes an issue you need a >> sequence counter around it. > > Or just two copies of the high word. > Provided the accesses are sequenced: > writer: > load high:low > add sm

Re: [patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 19:53, Andy Shevchenko wrote: > On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote: >> >> irq_set_lockdep_class() is used from modules and requires irq_to_desc() to >> be exported. Move it into the core code which lifts another requirement for >> the export. > > ... > >

Re: [PATCH v3 06/13] virtiofsd: replace _Static_assert with QEMU_BUILD_BUG_ON

2020-12-11 Thread Dr. David Alan Gilbert
* marcandre.lur...@redhat.com (marcandre.lur...@redhat.com) wrote: > From: Marc-André Lureau > > This allows to get rid of a check for older GCC version (which was a bit > bogus too since it was falling back on c++ version..) > > Signed-off-by: Marc-André Lureau Yes I think that's OK; this i

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

2020-12-11 Thread Rahul Singh
Hello Stefano, Thanks for reviewing the code. > On 11 Dec 2020, at 1:28 am, Stefano Stabellini wrote: > > On Thu, 10 Dec 2020, Rahul Singh wrote: >> Add support for ARM architected SMMUv3 implementation. It is based on >> the Linux SMMUv3 driver. >> >> Driver is currently supported as Tech Pre

Re: [PATCH V3 21/23] xen/arm: Add mapcache invalidation handling

2020-12-11 Thread Julien Grall
On 11/12/2020 19:07, Stefano Stabellini wrote: On Fri, 11 Dec 2020, Oleksandr wrote: On 11.12.20 03:28, Stefano Stabellini wrote: On Thu, 10 Dec 2020, Julien Grall wrote: On 10/12/2020 02:30, Stefano Stabellini wrote: On Mon, 30 Nov 2020, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshch

Re: [PATCH V3 21/23] xen/arm: Add mapcache invalidation handling

2020-12-11 Thread Julien Grall
Hi Stefano, On 11/12/2020 01:28, Stefano Stabellini wrote: Signed-off-by: Oleksandr Tyshchenko CC: Julien Grall --- Please note, this is a split/cleanup/hardening of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Changes V1 -> V2: - new patch, some changes were

Re: [PATCH V3 21/23] xen/arm: Add mapcache invalidation handling

2020-12-11 Thread Stefano Stabellini
On Fri, 11 Dec 2020, Oleksandr wrote: > On 11.12.20 03:28, Stefano Stabellini wrote: > > On Thu, 10 Dec 2020, Julien Grall wrote: > > > On 10/12/2020 02:30, Stefano Stabellini wrote: > > > > On Mon, 30 Nov 2020, Oleksandr Tyshchenko wrote: > > > > > From: Oleksandr Tyshchenko > > > > > > > > > >

[linux-5.4 test] 157431: tolerable FAIL - PUSHED

2020-12-11 Thread osstest service owner
flight 157431 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/157431/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stopfail like 157303 test-amd64-i386-xl-qemut-win7-amd64 19

Re: [PATCH v3 4/7] xen/arm: Add handler for ID registers on arm64

2020-12-11 Thread Stefano Stabellini
On Fri, 11 Dec 2020, Bertrand Marquis wrote: > Hi Stefano, > > > On 10 Dec 2020, at 22:29, Stefano Stabellini wrote: > > > > On Thu, 10 Dec 2020, Bertrand Marquis wrote: > >> Hi Stefano, > >> > >>> On 9 Dec 2020, at 19:38, Stefano Stabellini > >>> wrote: > >>> > >>> On Wed, 9 Dec 2020, Bertr

Re: [patch 16/30] mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc

2020-12-11 Thread Andy Shevchenko
On Thu, Dec 10, 2020 at 9:57 PM Thomas Gleixner wrote: > > First of all drivers have absolutely no business to dig into the internals > of an irq descriptor. That's core code and subject to change. All of this > information is readily available to /proc/interrupts in a safe and race > free way. >

Re: [patch 09/30] ARM: smp: Use irq_desc_kstat_cpu() in show_ipi_list()

2020-12-11 Thread Marc Zyngier
On Thu, 10 Dec 2020 19:25:45 +, Thomas Gleixner wrote: > > The irq descriptor is already there, no need to look it up again. > > Signed-off-by: Thomas Gleixner > Cc: Marc Zyngier > Cc: Russell King > Cc: linux-arm-ker...@lists.infradead.org > --- > arch/arm/kernel/smp.c |2 +- > 1 fi

Re: [patch 10/30] arm64/smp: Use irq_desc_kstat_cpu() in arch_show_interrupts()

2020-12-11 Thread Marc Zyngier
On Thu, 10 Dec 2020 19:25:46 +, Thomas Gleixner wrote: > > The irq descriptor is already there, no need to look it up again. > > Signed-off-by: Thomas Gleixner > Cc: Mark Rutland > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: linux-arm-ker...@lists.infradead.org > ---

Re: [patch 03/30] genirq: Move irq_set_lockdep_class() to core

2020-12-11 Thread Andy Shevchenko
On Thu, Dec 10, 2020 at 10:14 PM Thomas Gleixner wrote: > > irq_set_lockdep_class() is used from modules and requires irq_to_desc() to > be exported. Move it into the core code which lifts another requirement for > the export. ... > + if (IS_ENABLED(CONFIG_LOCKDEP)) > + __irq

[linux-linus test] 157414: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157414 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157414/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qem

Re: [PATCH v3 4/7] xen/arm: Add handler for ID registers on arm64

2020-12-11 Thread Bertrand Marquis
Hi Stefano, > On 10 Dec 2020, at 22:29, Stefano Stabellini wrote: > > On Thu, 10 Dec 2020, Bertrand Marquis wrote: >> Hi Stefano, >> >>> On 9 Dec 2020, at 19:38, Stefano Stabellini wrote: >>> >>> On Wed, 9 Dec 2020, Bertrand Marquis wrote: Add vsysreg emulation for registers trapped when

Re: [PATCH v3 2/8] lib: collect library files in an archive

2020-12-11 Thread Anthony PERARD
On Fri, Dec 11, 2020 at 11:00:19AM +0100, Jan Beulich wrote: > On 10.12.2020 15:47, Anthony PERARD wrote: > > On Mon, Nov 23, 2020 at 04:21:19PM +0100, Jan Beulich wrote: > >> --- a/xen/Rules.mk > >> +++ b/xen/Rules.mk > >> @@ -60,7 +64,14 @@ include Makefile > >> # > >> -

[qemu-mainline test] 157411: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157411 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/157411/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-buildfail REGR. vs. 152631 build-amd64-xsm

[ovmf test] 157416: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157416 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157416/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread boris . ostrovsky
On 12/11/20 7:37 AM, Thomas Gleixner wrote: > On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote: >> On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: >>> On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interru

Re: [PATCH v3 0/8] xen/arm: Add support for SMMUv3 driver

2020-12-11 Thread Julien Grall
Hi Rahul, On 10/12/2020 16:56, Rahul Singh wrote: This patch series is v3 of the work to add support for the SMMUv3 driver. Approach taken is to first merge the Linux copy of the SMMUv3 driver (tag v5.8.18) and then modify the driver to build on XEN. MSI and PCI ATS functionality are not suppo

Re: [PATCH v3 7/8] xen/arm: Add support for SMMUv3 driver

2020-12-11 Thread Julien Grall
Hi Rahul, On 10/12/2020 16:57, Rahul Singh wrote: struct arm_smmu_strtab_cfg { @@ -613,8 +847,13 @@ struct arm_smmu_device { u64 padding; }; - /* IOMMU core code handle */ - struct iommu_device iommu; + /* Need to keep a l

RE: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-11 Thread David Laight
From: Thomas Gleixner > Sent: 11 December 2020 12:58 .. > > After my failed hasty sketch from last night I had a different one which > > was kind of heuristics based (re-reading the upper dword and retrying if > > it changed on 32-bit). > > The problem is that there will be two seperate modificati

[PATCH] Revert "x86/mm: drop guest_get_eff_l1e()"

2020-12-11 Thread Andrew Cooper
This reverts commit 9ff9705647646aa937b5f5c1426a64c69a62b3bd. The change is only correct in the original context of XSA-286, where Xen's use of the linear pagetables were dropped. However, performance problems interfered with that plan, and XSA-286 was fixed differently. This broke Xen's lazy fa

Re: [PATCH v3 8/8] xen/arm: smmuv3: Remove linux compatibility functions.

2020-12-11 Thread Julien Grall
Hi Rahul, On 10/12/2020 16:57, Rahul Singh wrote: Replace all Linux compatible device tree handling function with the XEN functions. Right, but they were introduced in the previous patch. I dislike the idea to add code for removing afterwards (in some cases you actually do the renaming direc

Re: dom0 PV looping on search_pre_exception_table()

2020-12-11 Thread Andrew Cooper
On 11/12/2020 11:15, Manuel Bouyer wrote: > On Fri, Dec 11, 2020 at 09:58:54AM +0100, Jan Beulich wrote: >> Could you please revert 9ff970564764 ("x86/mm: drop guest_get_eff_l1e()")? >> I think there was a thinko there in that the change can't be split from >> the bigger one which was part of the o

Re: [PATCH v3 6/8] xen/arm: Remove Linux specific code that is not usable in XEN

2020-12-11 Thread Bertrand Marquis
Hi, > On 10 Dec 2020, at 16:57, Rahul Singh wrote: > > Remove code that is related to below functionality : > 1. struct io_pgtable_ops > 2. struct io_pgtable_cfg > 3. struct iommu_flush_ops, > 4. struct iommu_ops > 5. module_param_named, MODULE_PARM_DESC, module_platform_driver, >MODULE_* >

Re: [PATCH v3 8/8] xen/arm: smmuv3: Remove linux compatibility functions.

2020-12-11 Thread Bertrand Marquis
Hi Rahul, > On 10 Dec 2020, at 16:57, Rahul Singh wrote: > > Replace all Linux compatible device tree handling function with the XEN > functions. > > Replace all Linux ktime function with the XEN time functions. > > Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Cheers Bertrand >

Re: [PATCH v3 5/8] xen/device-tree: Add dt_property_match_string helper

2020-12-11 Thread Bertrand Marquis
Hi, > On 10 Dec 2020, at 16:57, Rahul Singh wrote: > > Import the Linux helper of_property_match_string. This function searches > a string list property and returns the index of a specific string value. > > Signed-off-by: Rahul Singh Reviewed-by: Bertrand Marquis Thanks Bertrand > --- > Cha

[xen-unstable-smoke test] 157421: tolerable all pass - PUSHED

2020-12-11 Thread osstest service owner
flight 157421 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/157421/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 10:13, Tvrtko Ursulin wrote: > On 10/12/2020 19:25, Thomas Gleixner wrote: >> >> Aside of that the count is per interrupt line and therefore takes >> interrupts from other devices into account which share the interrupt line >> and are not handled by the graphics driver. >>

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 13:10, Jürgen Groß wrote: > On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: >> >> On 12/10/20 2:26 PM, Thomas Gleixner wrote: >>> All event channel setups bind the interrupt on CPU0 or the target CPU for >>> percpu interrupts and overwrite the affinity mask with the cor

Re: [PATCH v2 3/3] net: checksum: Introduce fine control over checksum type

2020-12-11 Thread Cédric Le Goater
On 12/11/20 10:35 AM, Bin Meng wrote: > From: Bin Meng > > At present net_checksum_calculate() blindly calculates all types of > checksums (IP, TCP, UDP). Some NICs may have a per type setting in > their BDs to control what checksum should be offloaded. To support > such hardware behavior, introd

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Jürgen Groß
On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite the affinity mask with the corresponding cpumask. That does not make sense. The XEN impleme

[XEN PATCH v1 1/1] Invalidate cache for cpus affinitized to the domain

2020-12-11 Thread Harsha Shamsundara Havanur
A HVM domain flushes cache on all the cpus using `flush_all` macro which uses cpu_online_map, during i) creation of a new domain ii) when device-model op is performed iii) when domain is destructed. This triggers IPI on all the cpus, thus affecting other domains that are pinned to different pcpus.

Re: [PATCH V3 21/23] xen/arm: Add mapcache invalidation handling

2020-12-11 Thread Oleksandr
On 11.12.20 03:28, Stefano Stabellini wrote: Hi Julien, Stefano On Thu, 10 Dec 2020, Julien Grall wrote: On 10/12/2020 02:30, Stefano Stabellini wrote: On Mon, 30 Nov 2020, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko We need to send mapcache invalidation request to qemu/demu e

[libvirt test] 157404: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157404 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/157404/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-libvirt 6 libvirt-buildfail REGR. vs. 151777 build-amd64-xsm

Re: dom0 PV looping on search_pre_exception_table()

2020-12-11 Thread Manuel Bouyer
On Fri, Dec 11, 2020 at 09:58:54AM +0100, Jan Beulich wrote: > Could you please revert 9ff970564764 ("x86/mm: drop guest_get_eff_l1e()")? > I think there was a thinko there in that the change can't be split from > the bigger one which was part of the originally planned set for XSA-286. > We mustn't

Re: [PATCH v3 4/5] evtchn: convert domain event lock to an r/w one

2020-12-11 Thread Julien Grall
Hi Jan, On 11/12/2020 10:32, Jan Beulich wrote: On 09.12.2020 12:54, Julien Grall wrote: On 23/11/2020 13:29, Jan Beulich wrote: @@ -620,7 +620,7 @@ int evtchn_close(struct domain *d1, int long rc = 0; again: -spin_lock(&d1->event_lock); +write_lock(&d1->event

Re: [PATCH v3] xen: add support for automatic debug key actions in case of crash

2020-12-11 Thread Jürgen Groß
On 11.12.20 11:49, Julien Grall wrote: On 11/12/2020 10:38, Jürgen Groß wrote: On 11.12.20 11:22, Julien Grall wrote: Hi, On 11/12/2020 07:24, Jan Beulich wrote: On 11.12.2020 08:02, Jürgen Groß wrote: On 10.12.20 21:51, Julien Grall wrote: Hi Jan, On 09/12/2020 14:29, Jan Beulich wrote:

Re: [PATCH v3] xen: add support for automatic debug key actions in case of crash

2020-12-11 Thread Julien Grall
On 11/12/2020 10:38, Jürgen Groß wrote: On 11.12.20 11:22, Julien Grall wrote: Hi, On 11/12/2020 07:24, Jan Beulich wrote: On 11.12.2020 08:02, Jürgen Groß wrote: On 10.12.20 21:51, Julien Grall wrote: Hi Jan, On 09/12/2020 14:29, Jan Beulich wrote: On 09.12.2020 13:11, Julien Grall wro

Re: [PATCH v3 4/8] xen/arm: Remove support for Stage-1 translation on SMMUv3.

2020-12-11 Thread Rahul Singh
Hello Stefano, > On 11 Dec 2020, at 1:28 am, Stefano Stabellini wrote: > > On Thu, 10 Dec 2020, Rahul Singh wrote: >> @@ -2087,29 +1693,8 @@ static int arm_smmu_domain_finalise(struct >> iommu_domain *domain, >> } >> >> /* Restrict the stage to what we can actually support */ >> -

Re: dom0 PV looping on search_pre_exception_table()

2020-12-11 Thread Manuel Bouyer
On Thu, Dec 10, 2020 at 09:01:12PM +, Andrew Cooper wrote: > I've repro'd the problem. > > When I modify Xen to explicitly demand-map the LDT in the MMUEXT_SET_LDT > hypercall, everything works fine. > > Specifically, this delta: > > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index

Re: [PATCH v3] xen: add support for automatic debug key actions in case of crash

2020-12-11 Thread Jan Beulich
On 11.12.2020 11:22, Julien Grall wrote: > Hi, > > On 11/12/2020 07:24, Jan Beulich wrote: >> On 11.12.2020 08:02, Jürgen Groß wrote: >>> On 10.12.20 21:51, Julien Grall wrote: Hi Jan, On 09/12/2020 14:29, Jan Beulich wrote: > On 09.12.2020 13:11, Julien Grall wrote: >> On 2

Re: [PATCH v3] xen: add support for automatic debug key actions in case of crash

2020-12-11 Thread Jürgen Groß
On 11.12.20 11:22, Julien Grall wrote: Hi, On 11/12/2020 07:24, Jan Beulich wrote: On 11.12.2020 08:02, Jürgen Groß wrote: On 10.12.20 21:51, Julien Grall wrote: Hi Jan, On 09/12/2020 14:29, Jan Beulich wrote: On 09.12.2020 13:11, Julien Grall wrote: On 26/11/2020 11:20, Jan Beulich wrote:

Re: [PATCH v3 4/5] evtchn: convert domain event lock to an r/w one

2020-12-11 Thread Jan Beulich
On 09.12.2020 12:54, Julien Grall wrote: > On 23/11/2020 13:29, Jan Beulich wrote: >> @@ -620,7 +620,7 @@ int evtchn_close(struct domain *d1, int >> long rc = 0; >> >>again: >> -spin_lock(&d1->event_lock); >> +write_lock(&d1->event_lock); >> >> if ( !port_is_

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Jürgen Groß
On 11.12.20 11:13, Thomas Gleixner wrote: On Fri, Dec 11 2020 at 07:17, Jürgen Groß wrote: On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: On 12/10/20 2:26 PM, Thomas Gleixner wrote: All event channel setups bind the interrupt on CPU0 or the target CPU for percpu interrupts and overwrite

Re: [PATCH v3] xen: add support for automatic debug key actions in case of crash

2020-12-11 Thread Julien Grall
Hi, On 11/12/2020 07:24, Jan Beulich wrote: On 11.12.2020 08:02, Jürgen Groß wrote: On 10.12.20 21:51, Julien Grall wrote: Hi Jan, On 09/12/2020 14:29, Jan Beulich wrote: On 09.12.2020 13:11, Julien Grall wrote: On 26/11/2020 11:20, Jan Beulich wrote: On 26.11.2020 09:03, Juergen Gross wro

Re: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-11 Thread Tvrtko Ursulin
On 10/12/2020 19:25, Thomas Gleixner wrote: Driver code has no business with the internals of the irq descriptor. Aside of that the count is per interrupt line and therefore takes interrupts from other devices into account which share the interrupt line and are not handled by the graphics driv

Re: [patch 27/30] xen/events: Only force affinity mask for percpu interrupts

2020-12-11 Thread Thomas Gleixner
On Fri, Dec 11 2020 at 07:17, Jürgen Groß wrote: > On 11.12.20 00:20, boris.ostrov...@oracle.com wrote: >> >> On 12/10/20 2:26 PM, Thomas Gleixner wrote: >>> All event channel setups bind the interrupt on CPU0 or the target CPU for >>> percpu interrupts and overwrite the affinity mask with the cor

Re: [patch 16/30] mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc

2020-12-11 Thread Lee Jones
On Thu, 10 Dec 2020, Thomas Gleixner wrote: > First of all drivers have absolutely no business to dig into the internals > of an irq descriptor. That's core code and subject to change. All of this > information is readily available to /proc/interrupts in a safe and race > free way. > > Remove the

Re: [PATCH v3 2/8] lib: collect library files in an archive

2020-12-11 Thread Jan Beulich
On 10.12.2020 15:47, Anthony PERARD wrote: > On Mon, Nov 23, 2020 at 04:21:19PM +0100, Jan Beulich wrote: >> --- a/xen/Rules.mk >> +++ b/xen/Rules.mk >> @@ -60,7 +64,14 @@ include Makefile >> # >> --- >> >> quiet_cmd_ld =

[xen-unstable test] 157398: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157398 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/157398/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-xsm 6 xen-buildfail REGR. vs. 157365 build-i386

Re: [patch 14/30] drm/i915/pmu: Replace open coded kstat_irqs() copy

2020-12-11 Thread Jani Nikula
On Thu, 10 Dec 2020, Thomas Gleixner wrote: > Driver code has no business with the internals of the irq descriptor. > > Aside of that the count is per interrupt line and therefore takes > interrupts from other devices into account which share the interrupt line > and are not handled by the graphic

Re: [Intel-gfx] [patch 13/30] drm/i915/lpe_audio: Remove pointless irq_to_desc() usage

2020-12-11 Thread Jani Nikula
On Thu, 10 Dec 2020, Ville Syrjälä wrote: > On Thu, Dec 10, 2020 at 08:25:49PM +0100, Thomas Gleixner wrote: >> Nothing uses the result and nothing should ever use it in driver code. >> >> Signed-off-by: Thomas Gleixner >> Cc: Jani Nikula >> Cc: Joonas Lahtinen >> Cc: Rodrigo Vivi >> Cc: Davi

Re: [PATCH] x86/HVM: refine when to send mapcache invalidation request to qemu

2020-12-11 Thread Jan Beulich
On 10.12.2020 16:55, Hongyan Xia wrote: > On Thu, 2020-12-10 at 14:37 +0100, Jan Beulich wrote: >> On 10.12.2020 14:09, Hongyan Xia wrote: >>> On Mon, 2020-09-28 at 12:44 +0200, Jan Beulich wrote: Plus finally there's no point sending the request for the local domain when the domain

[PATCH v2 3/3] net: checksum: Introduce fine control over checksum type

2020-12-11 Thread Bin Meng
From: Bin Meng At present net_checksum_calculate() blindly calculates all types of checksums (IP, TCP, UDP). Some NICs may have a per type setting in their BDs to control what checksum should be offloaded. To support such hardware behavior, introduce a 'csum_flag' parameter to the net_checksum_ca

Re: dom0 PV looping on search_pre_exception_table()

2020-12-11 Thread Jan Beulich
On 10.12.2020 10:51, Manuel Bouyer wrote: > On Wed, Dec 09, 2020 at 07:08:41PM +, Andrew Cooper wrote: >> Oh of course - we don't follow the exit-to-guest path on the way out here. >> >> As a gross hack to check that we've at least diagnosed the issue >> appropriately, could you modify NetBSD t

[GIT PULL] xen: branch for v5.10-rc8

2020-12-11 Thread Juergen Gross
Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.10c-rc8-tag xen: branch for v5.10-rc8 It contains a short series fixing a regression introduced in 5.9 for running as Xen dom0 on a system with NVMe backed storage. Thanks. Juerge

[ovmf test] 157412: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157412 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/157412/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 12 debian-hvm-install fail REGR. vs. 157345 test-amd64-amd64-xl-qemuu

Re: [patch 16/30] mfd: ab8500-debugfs: Remove the racy fiddling with irq_desc

2020-12-11 Thread Linus Walleij
On Thu, Dec 10, 2020 at 8:42 PM Thomas Gleixner wrote: > First of all drivers have absolutely no business to dig into the internals > of an irq descriptor. That's core code and subject to change. All of this > information is readily available to /proc/interrupts in a safe and race > free way. > >

[linux-linus test] 157395: regressions - FAIL

2020-12-11 Thread osstest service owner
flight 157395 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/157395/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ws16-amd64 7 xen-install fail REGR. vs. 152332 test-amd64-i386-qem