Re: [Xen-devel] [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-10-15 Thread Oleksandr Andrushchenko
On 10/16/19 8:11 AM, Jürgen Groß wrote: > On 15.10.19 20:12, Jason Gunthorpe wrote: >> From: Jason Gunthorpe >> >> DMA_SHARED_BUFFER can not be enabled by the user (it represents a >> library >> set in the kernel). The kconfig convention is to use select for such >> symbols so they are turned on

Re: [Xen-devel] [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-10-15 Thread Jürgen Groß
On 15.10.19 20:12, Jason Gunthorpe wrote: From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a kconfig that needs them

Re: [Xen-devel] [PATCH 22/34] xen: Use CONFIG_PREEMPTION

2019-10-15 Thread Jürgen Groß
On 15.10.19 21:18, Sebastian Andrzej Siewior wrote: From: Thomas Gleixner CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by CONFIG_PREEMPT_RT. Both PREEMPT and PREEMPT_RT require the same functionality which today depends on CONFIG_PREEMPT. Switch the preempt anand xen-ops code over to us

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-15 Thread Jürgen Groß
On 15.10.19 20:18, Julien Grall wrote: virt_to_maddr() is using the hardware page-table walk instructions to translate a virtual address to physical address. The function should only be called on virtual address mapped. _end points past the end of Xen binary and may not be mapped when the binary

Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()

2019-10-15 Thread Jürgen Groß
On 15.10.19 18:45, Julien Grall wrote: Hi Juergen, Gentle ping. Cheers, On 10/10/19 3:43 PM, Julien Grall wrote: Hi, Hmm, it looks like I forgot this patch before the freeze. Juergen, are you happy with this to go in Xen 4.13? Cheers, On 15/08/2019 18:29, Julien Grall wrote: dtb_load()

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-15 Thread Chao Gao
On Tue, Oct 15, 2019 at 06:59:37PM +0200, Sander Eikelenboom wrote: >On 14/10/2019 17:03, Chao Gao wrote: >> On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >>> On 01/10/2019 12:35, Anthony PERARD wrote: Rewrite of the commit message: Before the problematic commit

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-15 Thread Stefano Stabellini
On Tue, 15 Oct 2019, Julien Grall wrote: > On 15/10/2019 21:38, Stefano Stabellini wrote: > > On Tue, 15 Oct 2019, Julien Grall wrote: > >> Hi, > >> > >> On 15/10/2019 20:28, Stefano Stabellini wrote: > >>> On Tue, 15 Oct 2019, Julien Grall wrote: > virt_to_maddr() is using the hardware page-t

Re: [Xen-devel] [PATCH 00/32] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-15 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191015162705.28087-1-phi...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 00/32] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Type: series Message-id: 20191015

Re: [Xen-devel] [PATCH 0/2] xen/netback: bug fix and cleanup

2019-10-15 Thread David Miller
From: Juergen Gross Date: Mon, 14 Oct 2019 11:09:08 +0200 > One bugfix (patch 1) I stumbled over while doing a cleanup (patch 2) > of the xen-netback init/deinit code. Please do not mix cleanups and genuine bug fixes. Submit the bug fix targetting the 'net' GIT tree, and once that eventually ge

Re: [Xen-devel] [PATCH v3 2/2] xen/efi: optionally call SetVirtualAddressMap()

2019-10-15 Thread Andrew Cooper
On 12/10/2019 23:11, Marek Marczykowski-Górecki wrote: > Some UEFI implementations are not happy about running in 1:1 addressing, > but really virtual address space. Specifically, some access > EfiBootServices{Code,Data}, or even totally unmapped areas. Example > crash of GetVariable() call on Thin

Re: [Xen-devel] [BUG] Invalid guest state in Xen master, dom0 linux-5.3.6, domU windows 10

2019-10-15 Thread Andrew Cooper
On 15/10/2019 22:35, Håkon Alstadheim wrote: > Got this just now, as my windows domU died: > > (XEN) [2019-10-15 21:23:44] d7v0 vmentry failure (reason 0x8021): > Invalid guest state (0) > (XEN) [2019-10-15 21:23:44] * VMCS Area ** > (XEN) [2019-10-15 21:23:44] *** Guest

[Xen-devel] [BUG] Invalid guest state in Xen master, dom0 linux-5.3.6, domU windows 10

2019-10-15 Thread Håkon Alstadheim
Got this just now, as my windows domU died: (XEN) [2019-10-15 21:23:44] d7v0 vmentry failure (reason 0x8021): Invalid guest state (0) (XEN) [2019-10-15 21:23:44] * VMCS Area ** (XEN) [2019-10-15 21:23:44] *** Guest State *** (XEN) [2019-10-15 21:23:44] CR0: actual=0x

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-15 Thread Julien Grall
On 15/10/2019 21:38, Stefano Stabellini wrote: > On Tue, 15 Oct 2019, Julien Grall wrote: >> Hi, >> >> On 15/10/2019 20:28, Stefano Stabellini wrote: >>> On Tue, 15 Oct 2019, Julien Grall wrote: virt_to_maddr() is using the hardware page-table walk instructions to translate a virtual ad

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-15 Thread Stefano Stabellini
On Tue, 15 Oct 2019, Julien Grall wrote: > Hi, > > On 15/10/2019 20:28, Stefano Stabellini wrote: > > On Tue, 15 Oct 2019, Julien Grall wrote: > >> virt_to_maddr() is using the hardware page-table walk instructions to > >> translate a virtual address to physical address. The function should > >> o

[Xen-devel] [linux-linus test] 142757: regressions - FAIL

2019-10-15 Thread osstest service owner
flight 142757 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/142757/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-examine 8 reboot fail REGR. vs. 133580 test-amd64-i386-xl-

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-15 Thread Julien Grall
Hi, On 15/10/2019 20:28, Stefano Stabellini wrote: > On Tue, 15 Oct 2019, Julien Grall wrote: >> virt_to_maddr() is using the hardware page-table walk instructions to >> translate a virtual address to physical address. The function should >> only be called on virtual address mapped. >> >> _end poi

Re: [Xen-devel] [PATCH for-4.13 v3] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-15 Thread Stefano Stabellini
On Tue, 15 Oct 2019, Julien Grall wrote: > The current implementations of xen_{map, unmap}_table() expect > {map, unmap}_domain_page() to be usable. Those helpers are used to > map/unmap page tables while update Xen page-tables. > > Since commit 022387ee1a "xen/arm: mm: Don't open-code Xen PT upda

Re: [Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-15 Thread Stefano Stabellini
On Tue, 15 Oct 2019, Julien Grall wrote: > virt_to_maddr() is using the hardware page-table walk instructions to > translate a virtual address to physical address. The function should > only be called on virtual address mapped. > > _end points past the end of Xen binary and may not be mapped when

[Xen-devel] [PATCH 22/34] xen: Use CONFIG_PREEMPTION

2019-10-15 Thread Sebastian Andrzej Siewior
From: Thomas Gleixner CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by CONFIG_PREEMPT_RT. Both PREEMPT and PREEMPT_RT require the same functionality which today depends on CONFIG_PREEMPT. Switch the preempt anand xen-ops code over to use CONFIG_PREEMPTION. Cc: Boris Ostrovsky Cc: Juergen

[Xen-devel] [PATCH for-4.13 v3] xen/arm: mm: Allow generic xen page-tables helpers to be called early

2019-10-15 Thread Julien Grall
The current implementations of xen_{map, unmap}_table() expect {map, unmap}_domain_page() to be usable. Those helpers are used to map/unmap page tables while update Xen page-tables. Since commit 022387ee1a "xen/arm: mm: Don't open-code Xen PT update in {set, clear}_fixmap()", setup_fixmap() will m

[Xen-devel] [ovmf test] 142765: all pass - PUSHED

2019-10-15 Thread osstest service owner
flight 142765 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/142765/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf cd70b1a71d30d0fff4c549a309682fdf127aaae6 baseline version: ovmf 410c4d00d9f7e369d1ce1

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-15 Thread Sander Eikelenboom
On 15/10/2019 18:59, Sander Eikelenboom wrote: > On 14/10/2019 17:03, Chao Gao wrote: >> On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >>> On 01/10/2019 12:35, Anthony PERARD wrote: Rewrite of the commit message: Before the problematic commit, libxl used to igno

[Xen-devel] [PATCH for-4.13] xen/arm: Don't use _end in is_xen_fixed_mfn()

2019-10-15 Thread Julien Grall
virt_to_maddr() is using the hardware page-table walk instructions to translate a virtual address to physical address. The function should only be called on virtual address mapped. _end points past the end of Xen binary and may not be mapped when the binary size is page-aligned. This means virt_to

[Xen-devel] [PATCH hmm 09/15] xen/gntdev: use mmu_range_notifier_insert

2019-10-15 Thread Jason Gunthorpe
From: Jason Gunthorpe gntdev simply wants to monitor a specific VMA for any notifier events, this can be done straightforwardly using mmu_range_notifier_insert() over the VMA's VA range. The notifier should be attached until the original VMA is destroyed. It is unclear if any of this is even sa

[Xen-devel] [PATCH hmm 08/15] xen/gntdev: Use select for DMA_SHARED_BUFFER

2019-10-15 Thread Jason Gunthorpe
From: Jason Gunthorpe DMA_SHARED_BUFFER can not be enabled by the user (it represents a library set in the kernel). The kconfig convention is to use select for such symbols so they are turned on implicitly when the user enables a kconfig that needs them. Otherwise the XEN_GNTDEV_DMABUF kconfig i

[Xen-devel] [libvirt test] 142761: regressions - FAIL

2019-10-15 Thread osstest service owner
flight 142761 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/142761/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-qcow2 15 guest-start/debian.repeat fail REGR. vs. 142644 Tests which did not

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-15 Thread Sander Eikelenboom
On 14/10/2019 17:03, Chao Gao wrote: > On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >> On 01/10/2019 12:35, Anthony PERARD wrote: >>> Rewrite of the commit message: >>> >>> Before the problematic commit, libxl used to ignore error when >>> destroying (force == true) a passthr

Re: [Xen-devel] [PATCH for-4.13 v2 2/2] docs: Replace all instance of ARM by Arm

2019-10-15 Thread Julien Grall
On 10/15/19 5:47 PM, Stefano Stabellini wrote: I am OK switching to "Arm", however I would do it post-4.13: this is not the kind of thing we should worry about it now I think. ok, I will move to my next queue. Cheers, On Tue, 15 Oct 2019, Julien Grall wrote: Hi, Gentle, ping. I don't th

Re: [Xen-devel] [PATCH for-4.13 v2 2/2] docs: Replace all instance of ARM by Arm

2019-10-15 Thread Stefano Stabellini
I am OK switching to "Arm", however I would do it post-4.13: this is not the kind of thing we should worry about it now I think. On Tue, 15 Oct 2019, Julien Grall wrote: > Hi, > > Gentle, ping. I don't think there are any conclusion here. > > Should we stick to ARM or move to Arm? > > Cheers, >

Re: [Xen-devel] [PATCH v2] xen/arm: domain_build: Print the correct domain in dtb_load()

2019-10-15 Thread Julien Grall
Hi Juergen, Gentle ping. Cheers, On 10/10/19 3:43 PM, Julien Grall wrote: Hi, Hmm, it looks like I forgot this patch before the freeze. Juergen, are you happy with this to go in Xen 4.13? Cheers, On 15/08/2019 18:29, Julien Grall wrote: dtb_load() can be called by other domain than dom0.

Re: [Xen-devel] [PATCH for-4.13 v2 2/2] docs: Replace all instance of ARM by Arm

2019-10-15 Thread Julien Grall
Hi, Gentle, ping. I don't think there are any conclusion here. Should we stick to ARM or move to Arm? Cheers, On 10/3/19 5:02 PM, Julien Grall wrote: Hi, On 03/10/2019 16:55, Volodymyr Babchuk wrote: Julien Grall writes: Hi Stefano, On 10/2/19 2:05 AM, Stefano Stabellini wrote: On Tue,

Re: [Xen-devel] [RESEND][PATCH for-4.13] xen/arm: mm: Clear boot pagetables before bringing-up each secondary CPU

2019-10-15 Thread Julien Grall
Hi, I actually forgot to CC Juergen. No wonder why I had no answer :(. Cheers, On 10/10/19 3:51 PM, Julien Grall wrote: +Juergen On 03/10/2019 02:22, Stefano Stabellini wrote: On Sat, 21 Sep 2019, Julien Grall wrote: At the moment, boot pagetables are only cleared once at boot. This means w

[Xen-devel] [PATCH 32/32] hw/pci-host/i440fx: Remove the last PIIX3 traces

2019-10-15 Thread Philippe Mathieu-Daudé
The PIIX3 is not tied to the i440FX and can even be used without it. Move its creation to the machine code (pc_piix.c). We have now removed the last trace of southbridge code in the i440FX northbridge. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c| 8 +++- hw/pci-ho

[Xen-devel] [PATCH 29/32] hw/pci-host/piix: Fix code style issues

2019-10-15 Thread Philippe Mathieu-Daudé
We will move this code, fix its style first. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 0b5da5bc94..61f91ff561 100644 --- a/hw/pci-host/piix.c +++ b/hw/pci-h

[Xen-devel] [PATCH 31/32] hw/pci-host: Rename incorrectly named 'piix' as 'i440fx'

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé We moved all the PIIX3 southbridge code out of hw/pci-host/piix.c, it now only contains i440FX northbridge code. Rename it to match the chipset modelled. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- hw/i386/Kconfig

[Xen-devel] [PATCH 30/32] hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Move all the PIIX3 functions to a new file: hw/isa/piix3.c. Signed-off-by: Philippe Mathieu-Daudé --- Checkpatch warning: ERROR: spaces required around that '*' (ctx:VxV) #312: FILE: hw/isa/piix3.c:248: +.subsections = (const VMStateDescription*[]) {

[Xen-devel] [PATCH 27/32] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers

2019-10-15 Thread Philippe Mathieu-Daudé
The IRQ Route Control registers definitions belong to the PIIX chipset. We were only defining the 'A' register. Define the other B, C and D registers, and use them. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/xen/xen-hvm.c | 5 +++-- hw/mips/gt64xxx_pci.c | 4 ++-- hw/pci-h

[Xen-devel] [PATCH 28/32] hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The hw/pci-host/piix.c contains a mix of PIIX3 and i440FX chipsets functions. To be able to split it, we need to export some declarations first. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/acpi/pcihp.c | 2 +- hw/

[Xen-devel] [PATCH 26/32] hw/pci-host/piix: Move RCR_IOPORT register definition

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The RCR_IOPORT register belongs to the PIIX chipset. Move the definition to "piix.h". Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c| 1 + include/hw/i386/pc.h | 6 -- include/hw/southbridge/piix.h | 6 ++ 3 files changed,

[Xen-devel] [PATCH 25/32] hw/pci-host/piix: Extract piix3_create()

2019-10-15 Thread Philippe Mathieu-Daudé
Extract the PIIX3 creation code from the i440fx_init() function. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/piix.c | 51 -- 1 file changed, 31 insertions(+), 20 deletions(-) diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c index 2f4cbcb

[Xen-devel] [PATCH 23/32] hw/i386/pc: Extract pc_i8259_create()

2019-10-15 Thread Philippe Mathieu-Daudé
The i8259 creation code is common to all PC machines, extract the common code. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 19 +++ hw/i386/pc_piix.c| 13 + hw/i386/pc_q35.c | 14 +- include/hw/i386/pc.h | 1 + 4 files changed,

[Xen-devel] [PATCH 24/32] hw/i386/pc: Remove kvm_i386.h include

2019-10-15 Thread Philippe Mathieu-Daudé
By extracting pc_gsi_create() and pc_i8259_create() we removed the access to "kvm_i386.h" from the machine code. We can now remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 1 - hw/i386/pc_q35.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/

[Xen-devel] [PATCH 22/32] hw/i386/pc: Move gsi_state creation code

2019-10-15 Thread Philippe Mathieu-Daudé
The block code related to IRQ start few lines later. Move the comment and the pc_gsi_create() call where we start to use the IRQs. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_q35.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q3

[Xen-devel] [PATCH 20/32] hw/i386/pc: Extract pc_gsi_create()

2019-10-15 Thread Philippe Mathieu-Daudé
The GSI creation code is common to all PC machines, extract the common code. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 15 +++ hw/i386/pc_piix.c| 9 + hw/i386/pc_q35.c | 9 + include/hw/i386/pc.h | 2 ++ 4 files changed, 19 insertions

[Xen-devel] [PATCH 21/32] hw/i386/pc: Reduce gsi_handler scope

2019-10-15 Thread Philippe Mathieu-Daudé
pc_gsi_create() is the single function that uses gsi_handler. Make it a static variable. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 2 +- include/hw/i386/pc.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index a7597c6c44.

[Xen-devel] [PATCH 19/32] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Now that we properly refactored the piix4_create() function, let's move it to hw/isa/piix4.c where it belongs, so it can be reused on other places. Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c| 30 ++ hw/mips/

[Xen-devel] [PATCH 18/32] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create()

2019-10-15 Thread Philippe Mathieu-Daudé
The Malta board instantiate a PIIX4 chipset doing various calls. Refactor all those related calls into a single function: piix4_create(). Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 47 +++- 1 file changed, 29 insertions(+), 18 deletio

[Xen-devel] [PATCH 17/32] hw/mips/mips_malta: Create IDE hard drive array dynamically

2019-10-15 Thread Philippe Mathieu-Daudé
In the next commit we'll refactor the PIIX4 code out of mips_malta_init(). As a preliminary step, add the 'ide_drives' variable and create the drive array dynamically. Signed-off-by: Philippe Mathieu-Daudé --- hw/mips/mips_malta.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) dif

[Xen-devel] [PATCH 16/32] piix4: add a mc146818rtc controller as specified in datasheet

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Remove mc146818rtc instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-13-hpous...@reactos.org> [PMD: rebased, set RTC base_year to 2000] Signed-o

[Xen-devel] [PATCH 15/32] piix4: add a i8254 pit controller as specified in datasheet

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau Remove i8254 instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-10-hpous...@reactos.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c

[Xen-devel] [PATCH 14/32] piix4: add a i8257 dma controller as specified in datasheet

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau Remove i8257 instanciated in malta board, to not have it twice. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-9-hpous...@reactos.org> [PMD: rebased] Signed-off-by: Philippe Mathieu-Daudé --- hw/i

Re: [Xen-devel] [PATCH 01/32] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers

2019-10-15 Thread Philippe Mathieu-Daudé
I forgot to Cc David and Daniel for this one. On 10/15/19 6:26 PM, Philippe Mathieu-Daudé wrote: These devices implemented their load_state_old() handler 10 years ago, previous to QEMU v0.12. Since commit cc425b5ddf removed the pc-0.10 and pc-0.11 machines, we can drop this code. Note: the mips

[Xen-devel] [PATCH 13/32] piix4: convert reset function to QOM

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20180106153730.30313-15-hpous...@reactos.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/isa/piix4.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Xen-devel] [PATCH 12/32] piix4: rename PIIX4 object to piix4-isa

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau Other piix4 parts are already named piix4-ide and piix4-usb-uhci. Reviewed-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-15-hpous...@reactos.org> [PMD: rebased] Signed-o

[Xen-devel] [PATCH 11/32] Revert "irq: introduce qemu_irq_proxy()"

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé This function isn't used anymore. This reverts commit 22ec3283efba9ba0792790da786d6776d83f2a92. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/irq.c| 14 -- include/hw/irq.h | 5 - 2 files changed, 19 deletions(-) diff --git a/hw/core/irq.

[Xen-devel] [PATCH 09/32] piix4: add Reset Control Register

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau The RCR I/O port (0xcf9) is used to generate a hard reset or a soft reset. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-7-hpous...@reactos.org> [PMD: rebased, updated includes] Signed-off-by: Phil

[Xen-devel] [PATCH 10/32] piix4: add a i8259 interrupt controller as specified in datasheet

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 gpio out. Remove i8259 instanciated in malta board, to not have it twice. We can also remove the now unused piix4_init() function. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé

[Xen-devel] [PATCH 08/32] piix4: rename some variables in realize function

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau PIIX4 structure is now 's' PCI device is now 'pci_dev' DeviceState is now 'dev' Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-6-hpous...@reactos.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/

[Xen-devel] [PATCH 04/32] mc146818rtc: Move RTC_ISA_IRQ definition

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The ISA default number for the RTC devices is not related to its registers neither. Move this definition to "hw/timer/mc146818rtc.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/timer/mc146818rtc.h | 2 ++ include/hw/timer/mc146818rtc_regs.h | 2 -- t

[Xen-devel] [PATCH 05/32] mc146818rtc: Include "mc146818rtc_regs.h" directly in mc146818rtc.c

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Devices/boards wanting to use the MC146818 RTC don't need the knowledge its internal registers. Move the "mc146818rtc_regs.h" inclusion to mc146818rtc.c where it is required. We can not move this file from include/hw/timer/ to hw/timer/ for local inclusion because th

[Xen-devel] [PATCH 07/32] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets

2019-10-15 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The PIIX4 Southbridge is not used by the PC machine, but by the Malta board (MIPS). Add a new section to keep it covered. Suggested-by: Michael S. Tsirkin Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 ++- 1 file changed, 6 insertions(+), 1 deletio

[Xen-devel] [PATCH 06/32] mc146818rtc: always register rtc to rtc list

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau We are not required anymore to use rtc_init() function. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-5-hpous...@reactos.org> [PMD: rebased, fix OBJECT() value] Signed-off-by: Philippe Mathieu-Daud

[Xen-devel] [PATCH 02/32] hw/i386/pc: Move kvm_i8259_init() declaration to sysemu/kvm.h

2019-10-15 Thread Philippe Mathieu-Daudé
Move the KVM-related call to "sysemu/kvm.h". Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/pc.h | 1 - include/sysemu/kvm.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 6df4f4b6fb..09e74e7764 100644 --- a/includ

[Xen-devel] [PATCH 03/32] mc146818rtc: move structure to header file

2019-10-15 Thread Philippe Mathieu-Daudé
From: Hervé Poussineau We are now able to embed a timer in another object. Acked-by: Michael S. Tsirkin Acked-by: Paolo Bonzini Signed-off-by: Hervé Poussineau Message-Id: <20171216090228.28505-4-hpous...@reactos.org> Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/mc146818rtc.c

[Xen-devel] [PATCH 01/32] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers

2019-10-15 Thread Philippe Mathieu-Daudé
These devices implemented their load_state_old() handler 10 years ago, previous to QEMU v0.12. Since commit cc425b5ddf removed the pc-0.10 and pc-0.11 machines, we can drop this code. Note: the mips_r4k machine started to use the i8254 device just after QEMU v0.5.0, but the MIPS machine types are

[Xen-devel] [PATCH 00/32] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge

2019-10-15 Thread Philippe Mathieu-Daudé
Hi, This series is a rework of "piix4: cleanup and improvements" [1] from Hervé, and my "remove i386/pc dependency: PIIX cleanup" [2]. Still trying to remove the strong X86/PC dependency 2 years later, one step at a time. Here we split the PIIX3 southbridge from i440FX northbridge. The i440FX nor

Re: [Xen-devel] [PATCH v2] xen/arm: platform: fix Raspberry Pi compatible string

2019-10-15 Thread Stewart Hildebrand
On Tuesday, October 15, 2019 7:02 AM, Julien Grall wrote: >Hi, Hi! > >On 10/9/19 5:59 PM, Stewart Hildebrand wrote: >> However, even with Xen looking for bcm2838, you wouldn't be able to >> grab one of those releases and boot without running into other issues. >> You'd still need a couple of addi

[Xen-devel] Xen-unstable 4.13.0-rc0 problem starting guest while trying to passthrough multiple pci devices

2019-10-15 Thread Sander Eikelenboom
Hi Anthony, While testing xen-unstable 4.13.0-rc0 I ran in to the following issue: When passing through all 8 functions of a pci(e) device I can't start the guest anymore, note that the trouble only starts at 0:9:0.3, not at 0:9:0.0: libxl: error: libxl_qmp.c:1270:qmp_ev_connect: Domain

Re: [Xen-devel] [PATCH] xen/arm: remove special dom0 case in dump_hyp_walk

2019-10-15 Thread Julien Grall
Hi Stefano, On 10/15/19 4:51 PM, Stefano Stabellini wrote: On Tue, 15 Oct 2019, Julien Grall wrote: Hi Stefano, On 10/15/19 4:49 AM, Stefano Stabellini wrote: There is no need to have a special dom0 case to convert the pgtable virtual address into a physical address. The virt_to_maddr functio

Re: [Xen-devel] [PATCH] xen/arm: remove special dom0 case in dump_hyp_walk

2019-10-15 Thread Stefano Stabellini
On Tue, 15 Oct 2019, Julien Grall wrote: > Hi Stefano, > > On 10/15/19 4:49 AM, Stefano Stabellini wrote: > > There is no need to have a special dom0 case to convert the pgtable > > virtual address into a physical address. The virt_to_maddr function can > > work both in the dom0 case and the domU

Re: [Xen-devel] [PATCH] xen/arm: remove special dom0 case in dump_hyp_walk

2019-10-15 Thread Stefano Stabellini
On Tue, 15 Oct 2019, Jürgen Groß wrote: > On 15.10.19 05:49, Stefano Stabellini wrote: > > There is no need to have a special dom0 case to convert the pgtable > > virtual address into a physical address. The virt_to_maddr function can > > work both in the dom0 case and the domU case. > > > > This

[Xen-devel] [PATCH v3 4/4] iommu: translate IO-APIC pins when enabling interrupt remapping

2019-10-15 Thread Roger Pau Monne
On Intel hardware there's currently no translation of already enabled IO-APIC pins when interrupt remapping is enabled on the IOMMU, hence introduce a logic similar to the one used in x2apic_bsp_setup in order to save and mask all IO-APIC pins, and then translate and restore them after interrupt re

[Xen-devel] [PATCH v3 2/4] x2APIC: simplify resume

2019-10-15 Thread Roger Pau Monne
There's no need to save and restore the IO-APIC entries, the entries prior to suspension have already been saved by ioapic_suspend, and will be restored by ioapic_resume. Note that at the point where resume_x2apic gets called the IO-APIC has not yet resumed, and hence all entries should be masked.

[Xen-devel] [PATCH v3 3/4] x2APIC: translate IO-APIC entries when enabling the IOMMU

2019-10-15 Thread Roger Pau Monne
When interrupt remapping is enabled as part of enabling x2APIC the IO-APIC entries also need to be translated to the new format and added to the interrupt remapping table. This prevents IOMMU interrupt remapping faults when booting on hardware that has unmasked IO-APIC pins. Reported-by: Andrew C

[Xen-devel] [PATCH v3 0/4] iommu: fixes for interrupt remapping enabling

2019-10-15 Thread Roger Pau Monne
Hello, The following series contain fixes for issues found when enabling interrupt remapping and the IO-APIC already has unmasked pins. While I'm not aware of any system malfunctioning (apart from reporting IOMMU interrupt remapping faults) I think it would be nice to have those in 4.13. The seri

[Xen-devel] [PATCH v3 1/4] iommu/amd: support all delivery modes with x2APIC

2019-10-15 Thread Roger Pau Monne
Current AMD IOMMU code will attempt to create remapping entries for all IO-APIC pins, regardless of the delivery mode. AMD IOMMU implementation doesn't support remapping entries for IO-APIC pins with delivery mode set to SMI, MNI, INIT or ExtINT, instead those entries are not translated provided th

Re: [Xen-devel] [PATCH v1 2/2] libxl: add removing XS backend path for PV devices on domain destroy

2019-10-15 Thread Roger Pau Monné
On Fri, Oct 11, 2019 at 04:55:32PM +0100, Ian Jackson wrote: > Roger Pau Monne writes ("Re: [PATCH v1 2/2] libxl: add removing XS backend > path for PV devices on domain destroy"): > > When this code was added (devd) those where the only backends handled > > by libxl. VDISPL, VSND, VINPUT didn't e

[Xen-devel] [qemu-mainline test] 142751: regressions - FAIL

2019-10-15 Thread osstest service owner
flight 142751 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/142751/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 10 debian-hvm-install fail REGR. vs. 140282 test-amd64-i38

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-qemut-rhel6hvm-amd

2019-10-15 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-qemut-rhel6hvm-amd testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git

[Xen-devel] [xen-unstable test] 142750: tolerable FAIL - PUSHED

2019-10-15 Thread osstest service owner
flight 142750 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/142750/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 16 guest-start/debian.repeatfail like 142683 test-amd64-amd64-xl-rtds 18 gues

Re: [Xen-devel] [PATCH v3 0/2] Optionally call EFI SetVirtualAddressMap()

2019-10-15 Thread Jason Andryuk
On Sat, Oct 12, 2019 at 6:11 PM Marek Marczykowski-Górecki wrote: > > Workaround buggy UEFI accessing boot services memory after ExitBootServices(). > Patches discussed here: > https://lists.xenproject.org/archives/html/xen-devel/2019-08/msg00701.html > > In addition to the tests below, I've teste

Re: [Xen-devel] [RFC] Documentation formats, licenses and file system structure

2019-10-15 Thread Lars Kurth
Hi Rich, > On 15 Oct 2019, at 02:58, Rich Persaud wrote: > >> On Oct 11, 2019, at 07:11, Lars Kurth wrote: >> >> On 11/10/2019, 02:24, "Stefano Stabellini" wrote: >> >>>On Thu, 10 Oct 2019, Lars Kurth wrote: >>> >>> @Stefano: as you and I believe Brian will be spending time on improvin

Re: [Xen-devel] [PATCH] arm/gic: Make sense of assertions

2019-10-15 Thread Andrii Anisov
Hello, On 15.10.19 14:08, Julien Grall wrote: To be honest, those ASSERTIONs are pointless. I'd prefer to drop them. -- Sincerely, Andrii Anisov. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinf

Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: Overhaul passthrough setting logic

2019-10-15 Thread Wei Liu
On Mon, Oct 14, 2019 at 05:59:26PM +0100, Anthony PERARD wrote: > On Mon, Oct 14, 2019 at 05:09:24PM +0100, Ian Jackson wrote: > > Paul Durrant writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v2 9/9] libxl/xl: > > Overhaul passthrough setting logic"): > > > On Fri, 11 Oct 2019 at 17:34, Ian Jackson

Re: [Xen-devel] [PATCH] arm/gic: Make sense of assertions

2019-10-15 Thread Julien Grall
Hi, On 10/15/19 11:01 AM, Andrii Anisov wrote: From: Andrii Anisov ARM Compiler complains about assertion conditions being always true, because sgi is of enum type what has all its values under 16. In order to preserve those asserts, specify the available SGI number right in the enum and use i

Re: [Xen-devel] [PATCH v2] xen/arm: platform: fix Raspberry Pi compatible string

2019-10-15 Thread Julien Grall
Hi, On 10/9/19 5:59 PM, Stewart Hildebrand wrote: On Wednesday, October 9, 2019 11:30 AM, Julien Grall wrote: On 04/10/2019 01:47, Stewart Hildebrand wrote: Both upstream [1] and downstream [2] Linux kernels use "brcm,bcm2711" as the compatible string for Raspberry Pi 4. Add this string to o

Re: [Xen-devel] [PATCH] xen/arm: remove special dom0 case in dump_hyp_walk

2019-10-15 Thread Julien Grall
Hi Stefano, On 10/15/19 4:49 AM, Stefano Stabellini wrote: There is no need to have a special dom0 case to convert the pgtable virtual address into a physical address. The virt_to_maddr function can work both in the dom0 case and the domU case. This is more than a cleanup: when Xen is loaded at

Re: [Xen-devel] [XEN PATCH for-4.13 v3 05/10] libxl: Move shadow_memkb and iommu_memkb defaulting into libxl

2019-10-15 Thread Anthony PERARD
On Mon, Oct 14, 2019 at 06:00:23PM +0100, Ian Jackson wrote: > Anthony PERARD writes ("Re: [Xen-devel] [XEN PATCH for-4.13 v3 05/10] libxl: > Move shadow_memkb and iommu_memkb defaulting into libxl"): > > So maybe libxl__domain_build_info_setdefault() should also set a value > > to iommu_memkb as

[Xen-devel] [PATCH] arm/gic: Make sense of assertions

2019-10-15 Thread Andrii Anisov
From: Andrii Anisov ARM Compiler complains about assertion conditions being always true, because sgi is of enum type what has all its values under 16. In order to preserve those asserts, specify the available SGI number right in the enum and use it for the assertions. This also eliminates nasty h

[Xen-devel] [linux-next test] 142738: tolerable FAIL

2019-10-15 Thread osstest service owner
flight 142738 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/142738/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-examine 8 reboot fail like 142709 test-amd64-i386-libvirt-pair 10 xen-bo