[Xen-devel] [xen-4.8-testing test] 135480: regressions - FAIL

2019-05-03 Thread osstest service owner
flight 135480 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/135480/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-xtf-amd64-amd64-1 70 xtf/test-hvm64-xsa-278 fail REGR. vs. 130965 build-amd64-pre

[Xen-devel] [xen-4.10-testing test] 135478: tolerable FAIL - PUSHED

2019-05-03 Thread osstest service owner
flight 135478 xen-4.10-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/135478/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail like 134997 test-amd64-amd64-qemuu-nested-am

[Xen-devel] [xen-4.12-testing test] 135476: regressions - FAIL

2019-05-03 Thread osstest service owner
flight 135476 xen-4.12-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/135476/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail REGR. vs. 133989 Tests which di

[Xen-devel] [linux-4.9 test] 135473: regressions - FAIL

2019-05-03 Thread osstest service owner
flight 135473 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/135473/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 17 guest-localmigrate/x10 fail in 135429 REGR. vs. 134015 Tests which are

[Xen-devel] [PATCH 2/3] xen: actually skip the first MAX_ORDER bits in pfn_pdx_hole_setup

2019-05-03 Thread Stefano Stabellini
pfn_pdx_hole_setup is meant to skip the first MAX_ORDER bits, but actually it only skips the first MAX_ORDER-1 bits. The issue was probably introduced by bdb5439c3f, when changing to loop to start from MAX_ORDER-1 an adjustment by 1 was needed in the call to find_next_bit() but not done. Fix the i

[Xen-devel] [PATCH 3/3] xen/arm: fix mask calculation in init_pdx

2019-05-03 Thread Stefano Stabellini
The mask calculation in init_pdx is wrong when the first bank starts at address 0x0. The reason is that pdx_init_mask will do '0 - 1' causing an underflow. As a result, the mask becomes 0x which is the biggest possible mask and ends up causing a significant memory waste in the frame

[Xen-devel] [PATCH 1/3] xen/arm: fix nr_pdxs calculation

2019-05-03 Thread Stefano Stabellini
pfn_to_pdx expects an address, not a size, as a parameter. It expects the end address, and the masks calculations compensate for any holes between start and end. Pass the end address to pfn_to_pdx. Also remove from the result pfn_to_pdx(start_address) because we know that we don't need to cover any

[Xen-devel] [PATCH 0/3] PDX fixes

2019-05-03 Thread Stefano Stabellini
Hi all, This series is a small collection of PDX fixes. They are technically independent but discovered together trying to understand the memory waste caused by the frametable allocation on Xilinx ZynqMP. Cheers, Stefano The following changes since commit dc497635d93f6672f82727ad97a55205177be2

[Xen-devel] [linux-4.14 test] 135470: regressions - FAIL

2019-05-03 Thread osstest service owner
flight 135470 linux-4.14 real [real] http://logs.test-lab.xenproject.org/osstest/logs/135470/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail REGR. vs. 133923 Tests which did not

[Xen-devel] [linux-4.4 test] 135468: regressions - FAIL

2019-05-03 Thread osstest service owner
flight 135468 linux-4.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/135468/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow217 guest-localmigrate/x10 fail REGR. vs. 133468 test-amd64-amd64-qemu

Re: [Xen-devel] [PATCH] xen/arm: skip first page when RAM starts at 0x0

2019-05-03 Thread Stefano Stabellini
On Fri, 3 May 2019, Jan Beulich wrote: > >>> On 03.05.19 at 00:25, wrote: > > All right. Looking at the comment in pfn_pdx_hole_setup, it seems that > > it is intending to skip the first MAX_ORDER bits, but actually it is > > skipping the first MAX_ORDER-1 bits, if my calculations are correct. > >

[Xen-devel] [PATCH v2] sched/credit: avoid priority boost for capped domains when unpark

2019-05-03 Thread Eslam Elnikety
When unpausing a capped domain, the scheduler currently clears the CSCHED_FLAG_VCPU_PARKED flag before vcpu_wake(). This, in turn, causes the vcpu_wake to set CSCHED_PRI_TS_BOOST, resulting in an unfair credit boost. The comment around the changed lines already states that clearing the flag should

Re: [Xen-devel] [PATCH] sched/credit: avoid priority boost for capped domains when unpark

2019-05-03 Thread Elnikety, Eslam
On 3. May 2019, at 20:56, Lars Kurth mailto:lars.kurth@gmail.com>> wrote: On 3 May 2019, at 10:48, Dario Faggioli mailto:dfaggi...@suse.com>> wrote: On Fri, 2019-05-03 at 15:38 +, Eslam Elnikety wrote: When unpausing a capped domain, the scheduler currently clears the CSCHED_FLAG_VCP

Re: [Xen-devel] [PATCH] sched/credit: avoid priority boost for capped domains when unpark

2019-05-03 Thread Lars Kurth
> On 3 May 2019, at 10:48, Dario Faggioli wrote: > > On Fri, 2019-05-03 at 15:38 +, Eslam Elnikety wrote: >> When unpausing a capped domain, the scheduler currently clears the >> CSCHED_FLAG_VCPU_PARKED flag before vcpu_wake(). This, in turn, >> causes the >> vcpu_wake to set CSCHED_PRI_TS_

Re: [Xen-devel] [PATCH 16/20] xen/arm: mm: Protect Xen page-table update with a spinlock

2019-05-03 Thread Julien Grall
On 03/05/2019 16:59, Andrii Anisov wrote: Hello Julien, Hi, On 22.04.19 19:49, Julien Grall wrote: The function create_xen_entries may be concurrently called. So we need to protect with a spinlock to avoid corruption the page-tables. The question from me is why didn't we step into this

Re: [Xen-devel] [PATCH 15/20] xen/arm: mm: Use the shorter version __aligned(PAGE_SIZE) to align page-tables

2019-05-03 Thread Julien Grall
On 03/05/2019 16:58, Andrii Anisov wrote: On 22.04.19 19:49, Julien Grall wrote: We currently use the very long version __attribute__((__aligned(4096))) to align page-tables. Thankfully there is a shorter version to make IMO it is better to change `version` to `macro`. In order to specify

[Xen-devel] [OSSTEST PATCH 05/11] mg-repro-setup: Break out compute_adjusts

2019-05-03 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- mg-repro-setup | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/mg-repro-setup b/mg-repro-setup index c8bcad33..10ab65a8 100755 --- a/mg-repro-setup +++ b/mg-repro-setup @@ -54,7 +54,6 @@ set -e -o posi

[Xen-devel] [PATCH] xen/arm: Black list everything with a PPI

2019-05-03 Thread Amit Singh Tomar
XEN should not forward PPIs to Dom0 as it only support SPIs. One of solution to this problem is to skip any device that uses PPI source completely while building domain itself. This patch goes through all the interrupt sources of device and skip it if one of interrupt source is PPI. It fixes XEN b

[Xen-devel] [OSSTEST PATCH 06/11] mg-repro-setup: Move logging setup to later

2019-05-03 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- mg-repro-setup | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mg-repro-setup b/mg-repro-setup index 10ab65a8..b41bf478 100755 --- a/mg-repro-setup +++ b/mg-repro-setup @@ -115,6 +115,13 @@ compute_adjusts ()

[Xen-devel] [OSSTEST PATCH 08/11] mg-repro-setup: Move flight creation up before task creation

2019-05-03 Thread Ian Jackson
No significant functional change. Signed-off-by: Ian Jackson --- mg-repro-setup | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mg-repro-setup b/mg-repro-setup index d63e29b6..2e1d3b88 100755 --- a/mg-repro-setup +++ b/mg-repro-setup @@ -167,6 +167,9 @@ while [ $# -ne 0

[Xen-devel] [OSSTEST PATCH 03/11] cs-adjust-flight: Use db_prepare and honour -D -D for sql dumps

2019-05-03 Thread Ian Jackson
This makes debugging it easier. No functional change with zero or one occurrences of -D. Signed-off-by: Ian Jackson --- cs-adjust-flight | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/cs-adjust-flight b/cs-adjust-flight index badabeff..cc1684b4

[Xen-devel] [OSSTEST PATCH 01/11] mg-execute-flight: Save an mro in tmp/

2019-05-03 Thread Ian Jackson
This may be useful for some things. For example, it will be used in just a moment. Signed-off-by: Ian Jackson --- mg-execute-flight | 1 + 1 file changed, 1 insertion(+) diff --git a/mg-execute-flight b/mg-execute-flight index b3cdf431..391f4810 100755 --- a/mg-execute-flight +++ b/mg-execute-

[Xen-devel] [OSSTEST PATCH 10/11] mg-repro-setup: Detect options (-...) in wrong place

2019-05-03 Thread Ian Jackson
Without this they tend to be interpreted as HOSTSPECs leading to lossage. Signed-off-by: Ian Jackson --- v2: New patch --- mg-repro-setup | 4 1 file changed, 4 insertions(+) diff --git a/mg-repro-setup b/mg-repro-setup index 7f075f4e..dc6c5cbb 100755 --- a/mg-repro-setup +++ b/mg-repro-se

[Xen-devel] [OSSTEST PATCH 02/11] cs-adjust-flight: Break out copy_jobs_*

2019-05-03 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- cs-adjust-flight | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/cs-adjust-flight b/cs-adjust-flight index ee1d917c..badabeff 100755 --- a/cs-adjust-flight +++ b/cs-adjust-flight @@ -194,10 +194,8 @@ s

Re: [Xen-devel] [PATCH 13/20] xen/arm32: mm: Avoid to zero and clean cache for CPU0 domheap

2019-05-03 Thread Julien Grall
On 03/05/2019 16:57, Andrii Anisov wrote: Hello Julien, Hi, On 22.04.19 19:49, Julien Grall wrote: The page-table walker is configured to use the same shareability and cacheability as the access performed when updating the page-tables. This means cleaning the cache for CPU0 domheap is unn

[Xen-devel] [OSSTEST PATCH 09/11] mg-repro-flight: Provide --rebuild to make variant build jobs too

2019-05-03 Thread Ian Jackson
This allows a single command to repro a particular job with a variety of different source code. The implementation technique is: - run the build job in a separate flight, so that it can run with a separate task which gives its host up after the build - do much of the heavy lifting of runva

[Xen-devel] [OSSTEST PATCH 11/11] mg-allocate: Don't try allocating the same resource for two specs

2019-05-03 Thread Ian Jackson
This is obviously wrong. In fact it does not work (we bomb out in the allocation). Signed-off-by: Ian Jackson --- v2: New patch --- mg-allocate | 10 ++ 1 file changed, 10 insertions(+) diff --git a/mg-allocate b/mg-allocate index 087b14b0..b5dc185e 100755 --- a/mg-allocate +++ b/mg-al

[Xen-devel] [OSSTEST PATCH 04/11] mg-repro-setup: Improve a doc message slightly

2019-05-03 Thread Ian Jackson
Signed-off-by: Ian Jackson --- mg-repro-setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-repro-setup b/mg-repro-setup index 6ed4d85e..c8bcad33 100755 --- a/mg-repro-setup +++ b/mg-repro-setup @@ -33,7 +33,7 @@ usage () { cat < is \`host') OPTIONs - -t est

[Xen-devel] [OSSTEST PATCH 00/11] mg-repro-flight: Provide --rebuild to make variant build jobs too

2019-05-03 Thread Ian Jackson
It is annoying that mg-repro-flight cannot run a build for you too. Fix this. This is on xenbits in https://xenbits.xen.org/git-http/people/iwj/osstest.git xenbits.xen.org:/home/iwj/ext/osstest.git etc. as the branch wip.repro-flight-builds.v2 This version seems to actually work. Ian Jacks

[Xen-devel] [OSSTEST PATCH 07/11] mg-repro-setup: Allow arguments to badusage

2019-05-03 Thread Ian Jackson
No functional change with existing call sites. Signed-off-by: Ian Jackson --- mg-repro-setup | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-repro-setup b/mg-repro-setup index b41bf478..d63e29b6 100755 --- a/mg-repro-setup +++ b/mg-repro-setup @@ -46,7 +46,7 @@ END }

Re: [Xen-devel] [PATCH] xen/arm: Black list everything with a PPI

2019-05-03 Thread Amit Tomer
Sorry Just sent the wrong patch , Please ignore this. On Fri, May 3, 2019 at 10:13 PM Amit Singh Tomar wrote: > > XEN should not forward PPIs to Dom0 as it only support SPIs. > One of solution to this problem is to skip any device that > uses PPI source completely while building domain itself. >

Re: [Xen-devel] [PATCH] sched/credit: avoid priority boost for capped domains when unpark

2019-05-03 Thread Dario Faggioli
On Fri, 2019-05-03 at 15:38 +, Eslam Elnikety wrote: > When unpausing a capped domain, the scheduler currently clears the > CSCHED_FLAG_VCPU_PARKED flag before vcpu_wake(). This, in turn, > causes the > vcpu_wake to set CSCHED_PRI_TS_BOOST, resulting in an unfair credit > boost. The > comment a

[Xen-devel] [PATCH] xen/arm: Black list everything with a PPI

2019-05-03 Thread Amit Singh Tomar
XEN should not forward PPIs to Dom0 as it only support SPIs. One of solution to this problem is to skip any device that uses PPI source completely while building domain itself. This patch goes through all the interrupt sources of device and skip it if one of interrupt source is PPI. It fixes XEN b

Re: [Xen-devel] [PATCH 4/9] x86/IRQ: desc->affinity should strictly represent the requested value

2019-05-03 Thread Roger Pau Monné
On Mon, Apr 29, 2019 at 05:24:39AM -0600, Jan Beulich wrote: > desc->arch.cpu_mask reflects the actual set of target CPUs. Don't ever > fiddle with desc->affinity itself, except to store caller requested > values. > > This renders both set_native_irq_info() uses (which weren't using proper > locki

Re: [Xen-devel] [PATCH 12/20] xen/arm32: head: Always zero r3 before update a page-table entry

2019-05-03 Thread Julien Grall
On 03/05/2019 16:57, Andrii Anisov wrote: Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The boot code is using r2 and r3 to hold the page-table entry value. While r2 is always updated before storing the value, this is not always the case for r3. Thankfully today, r3 will always be zer

Re: [Xen-devel] [PATCH 06/20] xen/arm: Remove parameter cpuid from start_xen

2019-05-03 Thread Andrii Anisov
On 03.05.19 19:17, Julien Grall wrote: I can offer to reshuffle the patches so this one is before #5, but not merge them. Good option. I like it. -- Sincerely, Andrii Anisov. ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists

Re: [Xen-devel] [PATCH 04/20] xen/arm: Rework HSCTLR_BASE

2019-05-03 Thread Andrii Anisov
On 03.05.19 19:10, Julien Grall wrote: I don't understand what is your "second". Does it mean you are happy with the idea of the patch but we should agree on the naming first? Yes, I'm ok with the change. Actually I like the part with HSCTLR_CLEAR as a compilation time guard. But naming shou

Re: [Xen-devel] [PATCH 06/20] xen/arm: Remove parameter cpuid from start_xen

2019-05-03 Thread Julien Grall
Hi, On 03/05/2019 16:56, Andrii Anisov wrote: On 22.04.19 19:49, Julien Grall wrote: The parameter cpuid is not used by start_xen. So remove it. Signed-off-by: Julien Grall ---   xen/arch/arm/arm32/head.S | 1 -   xen/arch/arm/arm64/head.S | 1 -   xen/arch/arm/setup.c  | 3 +--   3 files ch

Re: [Xen-devel] [PATCH 05/20] xen/arm: Rework secondary_start prototype

2019-05-03 Thread Julien Grall
On 03/05/2019 16:56, Andrii Anisov wrote: Hello Julien, On 22.04.19 19:49, Julien Grall wrote: None of the parameters of secondary_start are actually used. So turn secondary_start to a function with no parameters. Also modify the assembly code to avoid setting-up the registers before calling

Re: [Xen-devel] [PATCH 03/20] xen/arm: processor: Use _BITUL instead of _AC(1, U) in SCTLR_ defines

2019-05-03 Thread Andrii Anisov
On 03.05.19 19:09, Julien Grall wrote: I don't understand what is your "second". Does it mean you are happy with the idea of the patch but we should agree on the naming first? Yes, right you are. Sorry for the mess. -- Sincerely, Andrii Anisov. _

Re: [Xen-devel] [PATCH 04/20] xen/arm: Rework HSCTLR_BASE

2019-05-03 Thread Julien Grall
Hi, On 03/05/2019 16:56, Andrii Anisov wrote: On 22.04.19 19:49, Julien Grall wrote:   /* HCR Hyp Configuration Register */   #define HCR_RW  (_AC(1,UL)<<31) /* Register Width, ARM64 only */ Resolution of the dispute with Jan about [PATCH 01/20] is required first. I don't understan

Re: [Xen-devel] [PATCH 03/20] xen/arm: processor: Use _BITUL instead of _AC(1, U) in SCTLR_ defines

2019-05-03 Thread Julien Grall
On 03/05/2019 16:56, Andrii Anisov wrote: Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The newly introduced macro _BITUL makes the code more readable. Signed-off-by: Julien Grall ---   xen/include/asm-arm/processor.h | 18 +-   1 file changed, 9 insertions(+), 9 delet

Re: [Xen-devel] [PATCH 17/20] xen/arm: mm: Initialize page-tables earlier

2019-05-03 Thread Andrii Anisov
On 22.04.19 19:49, Julien Grall wrote: Since commit f60658c6ae "xen/arm: Stop relocating Xen", the function setup_page_tables() does not require any information from the FDT. So the initialization of the page-tables can be done much earlier in the boot process. The earliest setup_page_tables()

Re: [Xen-devel] [PATCH 15/20] xen/arm: mm: Use the shorter version __aligned(PAGE_SIZE) to align page-tables

2019-05-03 Thread Andrii Anisov
On 22.04.19 19:49, Julien Grall wrote: We currently use the very long version __attribute__((__aligned(4096))) to align page-tables. Thankfully there is a shorter version to make IMO it is better to change `version` to `macro`. In order to specify it is not a compiler specific but specific t

Re: [Xen-devel] [PATCH 19/20] xen/arm: Pair call to set_fixmap with call to clear_fixmap in copy_from_paddr

2019-05-03 Thread Andrii Anisov
On 22.04.19 19:49, Julien Grall wrote: At the moment, set_fixmap may replace a valid entry without following the break-before-make sequence. This may result to TLB conflict abort. Rather than dealing with Break-Before-Make in set_fixmap, every call to set_fixmap is paired with a call to clear_

Re: [Xen-devel] [PATCH 18/20] xen/arm: mm: Check start is always before end in {destroy, modify}_xen_mappings

2019-05-03 Thread Andrii Anisov
On 22.04.19 19:49, Julien Grall wrote: The two helpers {destroy, modify}_xen_mappings don't check that the start is always before the end. This should never happen but if it happens, it will result to unexpected behavior. Catch such issues earlier on by adding an ASSERT in destroy_xen_mappings

Re: [Xen-devel] [PATCH 16/20] xen/arm: mm: Protect Xen page-table update with a spinlock

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The function create_xen_entries may be concurrently called. So we need to protect with a spinlock to avoid corruption the page-tables. The question from me is why didn't we step into this issue before? Signed-off-by: Julien Grall --- x

Re: [Xen-devel] [PATCH 11/20] xen/arm32: head: Don't set MAIR0 and MAIR1

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The co-processor registers MAIR0 and MAIR1 are managed by EL1. So there are no need to initialize them during Xen boot. Signed-off-by: Julien Grall Reviewed-by: Andrii Anisov -- Sincerely, Andrii Anisov. ___

Re: [Xen-devel] [PATCH 14/20] xen/arm32: mm: Avoid cleaning the cache for secondary CPUs page-tables

2019-05-03 Thread Andrii Anisov
On 22.04.19 19:49, Julien Grall wrote: The page-table walker is configured to use the same shareability and cacheability as the access performed when updating the page-tables. This means cleaning the cache for secondary CPUs runtime page-tables is unnecessary. Signed-off-by: Julien Grall Re

Re: [Xen-devel] [PATCH 12/20] xen/arm32: head: Always zero r3 before update a page-table entry

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The boot code is using r2 and r3 to hold the page-table entry value. While r2 is always updated before storing the value, this is not always the case for r3. Thankfully today, r3 will always be zero when we care. But this is difficult to trac

Re: [Xen-devel] [PATCH 10/20] xen/arm32: head: Correctly report the HW CPU ID

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR. So remove the zeroing and

Re: [Xen-devel] [PATCH 13/20] xen/arm32: mm: Avoid to zero and clean cache for CPU0 domheap

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The page-table walker is configured to use the same shareability and cacheability as the access performed when updating the page-tables. This means cleaning the cache for CPU0 domheap is unnecessary. Furthermore, CPU0 page-tables are part of

Re: [Xen-devel] [PATCH 07/20] xen/arm64: head: Remove unnecessary comment

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: So far, we don't init specific core initialization at boot. So remove the comment. Signed-off-by: Julien Grall Reviewed-by: Andrii Anisov -- Sincerely, Andrii Anisov. ___ Xen-devel mailing lis

Re: [Xen-devel] [PATCH 08/20] xen/arm64: head: Move earlyprintk messages in .rodata.str

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: At the moment, the earlyprintk messages are interleaved with the instructions. This makes more difficult to read the objdump output. Introduce a new macro to add a string in .rodata.str and use it for all the earlyprintk messages. Signed-off

Re: [Xen-devel] [PATCH 09/20] xen/arm64: head: Correctly report the HW CPU ID

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR_EL1. So remove the zeroing

Re: [Xen-devel] [PATCH 06/20] xen/arm: Remove parameter cpuid from start_xen

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The parameter cpuid is not used by start_xen. So remove it. Signed-off-by: Julien Grall --- xen/arch/arm/arm32/head.S | 1 - xen/arch/arm/arm64/head.S | 1 - xen/arch/arm/setup.c | 3 +-- 3 files changed, 1 insertion(+), 4 deletion

Re: [Xen-devel] [PATCH 02/20] xen/arm: Rename SCTLR_* defines and remove unused one

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The SCTLR_* are currently used for SCTLR/HSCTLR (arm32) and SCTLR_EL1/SCTLR_EL2 (arm64). The naming scheme is actually quite confusing because they may only be defined for an archicture (or even an exception level). So it is not easy for the

Re: [Xen-devel] [PATCH 04/20] xen/arm: Rework HSCTLR_BASE

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The current value of HSCTLR_BASE for Arm64 is pretty wrong. It would actually turn on SCTLR_EL2.nAA (bit 6) on hardware implementing ARMv8.4-LSE. Furthermore, the documentation of what is cleared/set in SCTLR_EL2 is also not correct and looks

Re: [Xen-devel] [PATCH 03/20] xen/arm: processor: Use _BITUL instead of _AC(1, U) in SCTLR_ defines

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: The newly introduced macro _BITUL makes the code more readable. Signed-off-by: Julien Grall --- xen/include/asm-arm/processor.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/xen/include/asm-arm/pro

Re: [Xen-devel] [PATCH 05/20] xen/arm: Rework secondary_start prototype

2019-05-03 Thread Andrii Anisov
Hello Julien, On 22.04.19 19:49, Julien Grall wrote: None of the parameters of secondary_start are actually used. So turn secondary_start to a function with no parameters. Also modify the assembly code to avoid setting-up the registers before calling secondary_start. What is not really mandat

Re: [Xen-devel] [PATCH 3/9] x86/IRQ: improve dump_irqs()

2019-05-03 Thread Roger Pau Monné
On Mon, Apr 29, 2019 at 05:23:49AM -0600, Jan Beulich wrote: > Don't log a stray trailing comma. Shorten a few fields. > > Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné > -for ( i = 0; i < action->nr_guests; i++ ) > +for ( i = 0; i < action->nr_guests; ) >

[Xen-devel] [PATCH] sched/credit: avoid priority boost for capped domains when unpark

2019-05-03 Thread Eslam Elnikety
When unpausing a capped domain, the scheduler currently clears the CSCHED_FLAG_VCPU_PARKED flag before vcpu_wake(). This, in turn, causes the vcpu_wake to set CSCHED_PRI_TS_BOOST, resulting in an unfair credit boost. The comment around the changed lines already states that clearing the flag should

Re: [Xen-devel] [PATCH v2] libxl: fix migration of PV and PVH domUs with and without qemu

2019-05-03 Thread Roger Pau Monné
On Fri, May 03, 2019 at 04:11:32PM +0200, Olaf Hering wrote: > Am Fri, 3 May 2019 13:04:11 +0200 > schrieb Roger Pau Monné : > > > Wouldn't it be easier to leave libxl__need_xenpv_qemu alone and just > > use the contents of the migration stream to decide whether to launch a > > QEMU for the PV bac

Re: [Xen-devel] [PATCH v4 2/4] x86/mem_sharing: copy a page_lock version to be internal to memshr

2019-05-03 Thread Tamas K Lengyel
On Fri, May 3, 2019 at 8:35 AM George Dunlap wrote: > > On 5/3/19 2:57 PM, Jan Beulich wrote: > On 03.05.19 at 15:43, wrote: > >> On Fri, May 3, 2019 at 2:27 AM Jan Beulich wrote: > >>> > >> On 03.05.19 at 00:13, wrote: > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x

Re: [Xen-devel] [PATCH 2/9] x86/IRQ: deal with move cleanup count state in fixup_irqs()

2019-05-03 Thread Roger Pau Monné
On Mon, Apr 29, 2019 at 05:23:20AM -0600, Jan Beulich wrote: > The cleanup IPI may get sent immediately before a CPU gets removed from > the online map. In such a case the IPI would get handled on the CPU > being offlined no earlier than in the interrupts disabled window after > fixup_irqs()' main

[Xen-devel] [PATCH] xen-blkfront: switch kcalloc to kvcalloc for large array allocation

2019-05-03 Thread Roger Pau Monne
There's no reason to request physically contiguous memory for those allocations. Reported-by: Ian Jackson Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Konrad Rzeszutek Wilk Cc: Jens Axboe Cc: xen-devel@lists.xenproject.org Cc: linux-bl.

Re: [Xen-devel] [PATCH v4 2/4] x86/mem_sharing: copy a page_lock version to be internal to memshr

2019-05-03 Thread George Dunlap
On 5/3/19 2:57 PM, Jan Beulich wrote: On 03.05.19 at 15:43, wrote: >> On Fri, May 3, 2019 at 2:27 AM Jan Beulich wrote: >>> >> On 03.05.19 at 00:13, wrote: --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -112,13 +112,48 @@ static inline void pag

Re: [Xen-devel] Xen GCC coverage ARM64 testing - Unexpected Trap: Data Abort

2019-05-03 Thread Wei Liu
On Fri, May 03, 2019 at 03:16:52PM +0100, Julien Grall wrote: > > > diff --git a/xen/common/libfdt/Makefile b/xen/common/libfdt/Makefile > > > index d81f54b6b8..c075bbf546 100644 > > > --- a/xen/common/libfdt/Makefile > > > +++ b/xen/common/libfdt/Makefile > > > @@ -3,6 +3,7 @@ include Makefile.lib

Re: [Xen-devel] Xen GCC coverage ARM64 testing - Unexpected Trap: Data Abort

2019-05-03 Thread Julien Grall
Hi, On 03/05/2019 14:41, Wei Liu wrote: On Fri, May 03, 2019 at 02:35:08PM +0100, Julien Grall wrote: Hi Wei, On 5/3/19 12:08 PM, Wei Liu wrote: On Thu, May 02, 2019 at 09:43:17PM +0100, Julien Grall wrote: (+ Wei) On 5/2/19 5:55 PM, Viktor Mitin wrote: Hi Julien, Hi, Please find trace

Re: [Xen-devel] [PATCH v4 1/4] x86/mem_sharing: reorder when pages are unlocked and released

2019-05-03 Thread Tamas K Lengyel
On Fri, May 3, 2019 at 7:56 AM Jan Beulich wrote: > > >>> On 03.05.19 at 15:48, wrote: > > On Fri, May 3, 2019 at 2:12 AM Jan Beulich wrote: > >> > >> >>> On 03.05.19 at 00:13, wrote: > >> > @@ -1002,7 +989,10 @@ static int share_pages(struct domain *sd, gfn_t > >> > sgfn, shr_handle_t sh, > >

Re: [Xen-devel] [PATCH v2] libxl: fix migration of PV and PVH domUs with and without qemu

2019-05-03 Thread Olaf Hering
Am Fri, 3 May 2019 13:04:11 +0200 schrieb Roger Pau Monné : > Wouldn't it be easier to leave libxl__need_xenpv_qemu alone and just > use the contents of the migration stream to decide whether to launch a > QEMU for the PV backends or not? ie: just parsing the domain config on > the migration strea

Re: [Xen-devel] [PATCH v1b 1/9] x86/IRQ: deal with move-in-progress state in fixup_irqs()

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 11:19, wrote: > On Mon, Apr 29, 2019 at 09:40:14AM -0600, Jan Beulich wrote: >> --- unstable.orig/xen/arch/x86/irq.c >> +++ unstable/xen/arch/x86/irq.c >> @@ -242,6 +242,20 @@ void destroy_irq(unsigned int irq) >> xfree(action); >> } >> >> +static void release_old_vec(s

[Xen-devel] [xen-4.7-testing test] 135472: regressions - FAIL

2019-05-03 Thread osstest service owner
flight 135472 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/135472/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-prev 6 xen-buildfail REGR. vs. 133596 build-amd64-xsm

Re: [Xen-devel] [PATCH v4 2/4] x86/mem_sharing: copy a page_lock version to be internal to memshr

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 15:43, wrote: > On Fri, May 3, 2019 at 2:27 AM Jan Beulich wrote: >> >> >>> On 03.05.19 at 00:13, wrote: >> > --- a/xen/arch/x86/mm/mem_sharing.c >> > +++ b/xen/arch/x86/mm/mem_sharing.c >> > @@ -112,13 +112,48 @@ static inline void page_sharing_dispose(struct >> > page_info

Re: [Xen-devel] [PATCH v4 1/4] x86/mem_sharing: reorder when pages are unlocked and released

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 15:48, wrote: > On Fri, May 3, 2019 at 2:12 AM Jan Beulich wrote: >> >> >>> On 03.05.19 at 00:13, wrote: >> > @@ -1002,7 +989,10 @@ static int share_pages(struct domain *sd, gfn_t >> > sgfn, shr_handle_t sh, >> > /* Free the client page */ >> > if(test_and_clear_bit

Re: [Xen-devel] [PATCH v4 1/4] x86/mem_sharing: reorder when pages are unlocked and released

2019-05-03 Thread Tamas K Lengyel
On Fri, May 3, 2019 at 2:12 AM Jan Beulich wrote: > > >>> On 03.05.19 at 00:13, wrote: > > @@ -1002,7 +989,10 @@ static int share_pages(struct domain *sd, gfn_t sgfn, > > shr_handle_t sh, > > /* Free the client page */ > > if(test_and_clear_bit(_PGC_allocated, &cpage->count_info)) > >

Re: [Xen-devel] [PATCH v4 4/4] x86/mem_sharing: compile mem_sharing subsystem only when kconfig is enabled

2019-05-03 Thread Tamas K Lengyel
On Fri, May 3, 2019 at 2:18 AM Jan Beulich wrote: > > >>> On 03.05.19 at 00:13, wrote: > > --- a/xen/arch/x86/mm.c > > +++ b/xen/arch/x86/mm.c > > @@ -368,7 +368,9 @@ void __init arch_init_memory(void) > > > > efi_init_memory(); > > > > +#ifdef CONFIG_MEM_SHARING > > mem_sharing_init();

Re: [Xen-devel] [PATCH v4 2/4] x86/mem_sharing: copy a page_lock version to be internal to memshr

2019-05-03 Thread Tamas K Lengyel
On Fri, May 3, 2019 at 2:27 AM Jan Beulich wrote: > > >>> On 03.05.19 at 00:13, wrote: > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -112,13 +112,48 @@ static inline void page_sharing_dispose(struct > > page_info *page) > > > > #endif /* MEM_SHARING_AUDI

Re: [Xen-devel] Xen GCC coverage ARM64 testing - Unexpected Trap: Data Abort

2019-05-03 Thread Wei Liu
On Fri, May 03, 2019 at 02:35:08PM +0100, Julien Grall wrote: > Hi Wei, > > On 5/3/19 12:08 PM, Wei Liu wrote: > > On Thu, May 02, 2019 at 09:43:17PM +0100, Julien Grall wrote: > > > (+ Wei) > > > > > > On 5/2/19 5:55 PM, Viktor Mitin wrote: > > > > Hi Julien, > > > > > > Hi, > > > > > > > Plea

Re: [Xen-devel] Xen GCC coverage ARM64 testing - Unexpected Trap: Data Abort

2019-05-03 Thread Julien Grall
Hi Wei, On 5/3/19 12:08 PM, Wei Liu wrote: On Thu, May 02, 2019 at 09:43:17PM +0100, Julien Grall wrote: (+ Wei) On 5/2/19 5:55 PM, Viktor Mitin wrote: Hi Julien, Hi, Please find trace log below: root@h3ulcb:~# xencov reset (XEN) Data Abort Trap. Syndrome=0x7 (XEN) Walking Hypervisor VA

Re: [Xen-devel] [PATCH] mm/pgtable: Drop pgtable_t variable from pte_fn_t functions

2019-05-03 Thread Matthew Wilcox
On Thu, May 02, 2019 at 04:14:57PM +0200, Martin Schwidefsky wrote: > On Thu, 2 May 2019 06:46:23 -0700 > Matthew Wilcox wrote: > > > On Thu, May 02, 2019 at 06:48:46PM +0530, Anshuman Khandual wrote: > > > Drop the pgtable_t variable from all implementation for pte_fn_t as none > > > of > > > t

[Xen-devel] Improve build system for offline environments

2019-05-03 Thread Mathieu Tarral
Hi, As stated by the documentation: "_Xen Project downloads various dependencies at build time_" This makes Xen a difficult project to work with in an offline environment. Thanks to the IRC channel, I heard of the command `make subtree-force-update-all` (We could document this option in the wiki

Re: [Xen-devel] [Intel-gfx] [PATCH] dma-buf: add struct dma_buf_attach_info v2

2019-05-03 Thread Koenig, Christian
Am 03.05.19 um 14:09 schrieb Daniel Vetter: > [CAUTION: External Email] > > On Fri, May 03, 2019 at 02:05:47PM +0200, Christian König wrote: >> Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin: >>> On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote: Add a structure for

Re: [Xen-devel] [Intel-gfx] [PATCH] dma-buf: add struct dma_buf_attach_info v2

2019-05-03 Thread Daniel Vetter
On Fri, May 03, 2019 at 02:05:47PM +0200, Christian König wrote: > Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin: > > On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote: > > > Add a structure for the parameters of dma_buf_attach, this makes it much > > > easier > > > to

Re: [Xen-devel] [PATCH] dma-buf: add struct dma_buf_attach_info v2

2019-05-03 Thread Christian König
Am 30.04.19 um 19:31 schrieb Russell King - ARM Linux admin: On Tue, Apr 30, 2019 at 01:10:02PM +0200, Christian König wrote: Add a structure for the parameters of dma_buf_attach, this makes it much easier to add new parameters later on. I don't understand this reasoning. What are the "new par

Re: [Xen-devel] [PATCH v2] libxl: fix migration of PV and PVH domUs with and without qemu

2019-05-03 Thread Roger Pau Monné
On Fri, May 03, 2019 at 11:42:51AM +0200, Olaf Hering wrote: > If a domU has a qemu-xen instance attached, it is required to call qemus > "xen-save-devices-state" method. Without it, the receiving side of a PV or > PVH migration may be unable to lock the image: > > xen be: qdisk-51712: xen be: qdi

Re: [Xen-devel] Xen GCC coverage ARM64 testing - Unexpected Trap: Data Abort

2019-05-03 Thread Wei Liu
On Thu, May 02, 2019 at 09:43:17PM +0100, Julien Grall wrote: > (+ Wei) > > On 5/2/19 5:55 PM, Viktor Mitin wrote: > > Hi Julien, > > Hi, > > > Please find trace log below: > > > > root@h3ulcb:~# xencov reset > > (XEN) Data Abort Trap. Syndrome=0x7 > > (XEN) Walking Hypervisor VA 0x361700 on CP

Re: [Xen-devel] [PATCH] tools/Makefile: Fix build of QEMU, remove --source-path

2019-05-03 Thread Ian Jackson
Adding Stefano for archaelogical reasons. Anthony PERARD writes ("[PATCH] tools/Makefile: Fix build of QEMU, remove --source-path"): > Following QEMU's commit 79d77bcd36 (configure: Remove --source-path > option), Xen's build system fails to build qemu-xen. The --source-path > option gives redund

[Xen-devel] [PATCH v2] libxl: fix migration of PV and PVH domUs with and without qemu

2019-05-03 Thread Olaf Hering
If a domU has a qemu-xen instance attached, it is required to call qemus "xen-save-devices-state" method. Without it, the receiving side of a PV or PVH migration may be unable to lock the image: xen be: qdisk-51712: xen be: qdisk-51712: error: Failed to get "write" lock error: Failed to get "write

Re: [Xen-devel] [PATCH v1b 1/9] x86/IRQ: deal with move-in-progress state in fixup_irqs()

2019-05-03 Thread Roger Pau Monné
On Mon, Apr 29, 2019 at 09:40:14AM -0600, Jan Beulich wrote: > The flag being set may prevent affinity changes, as these often imply > assignment of a new vector. When there's no possible destination left > for the IRQ, the clearing of the flag needs to happen right from > fixup_irqs(). > > Additi

Re: [Xen-devel] [PATCH v4 2/4] x86/mem_sharing: copy a page_lock version to be internal to memshr

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 00:13, wrote: > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -112,13 +112,48 @@ static inline void page_sharing_dispose(struct > page_info *page) > > #endif /* MEM_SHARING_AUDIT */ > > -static inline int mem_sharing_page_lock(struct page_i

Re: [Xen-devel] [PATCH v3] x86/vm_event: add gdtr_base to the vm_event structure

2019-05-03 Thread Razvan Cojocaru
On 5/3/19 11:09 AM, Jan Beulich wrote: On 03.05.19 at 00:54, wrote: Receiving this register is useful for introspecting 32-bit Windows when the event being trapped happened while in ring3. Signed-off-by: Tamas K Lengyel Cc: Razvan Cojocaru Cc: Tamas K Lengyel Cc: Jan Beulich Cc: Andrew Coo

Re: [Xen-devel] [PATCH v4 4/4] x86/mem_sharing: compile mem_sharing subsystem only when kconfig is enabled

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 00:13, wrote: > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -368,7 +368,9 @@ void __init arch_init_memory(void) > > efi_init_memory(); > > +#ifdef CONFIG_MEM_SHARING > mem_sharing_init(); > +#endif While for domctl code and alike using #ifdef may indeed

Re: [Xen-devel] [PATCH v4 1/4] x86/mem_sharing: reorder when pages are unlocked and released

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 00:13, wrote: > @@ -1002,7 +989,10 @@ static int share_pages(struct domain *sd, gfn_t sgfn, > shr_handle_t sh, > /* Free the client page */ > if(test_and_clear_bit(_PGC_allocated, &cpage->count_info)) > put_page(cpage); > -put_page(cpage); > + > +BUG_

Re: [Xen-devel] [PATCH v3] x86/vm_event: add gdtr_base to the vm_event structure

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 00:54, wrote: > Receiving this register is useful for introspecting 32-bit Windows when the > event being trapped happened while in ring3. > > Signed-off-by: Tamas K Lengyel > Cc: Razvan Cojocaru > Cc: Tamas K Lengyel > Cc: Jan Beulich > Cc: Andrew Cooper > Cc: Wei Liu >

[Xen-devel] [qemu-upstream-4.10-testing bisection] complete build-amd64-xsm

2019-05-03 Thread osstest service owner
branch xen-4.10-testing xenbranch xen-4.10-testing job build-amd64-xsm testid xen-build Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and

Re: [Xen-devel] [PATCH v1] x86/mm: Make change_type_range return error

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 09:53, wrote: > On 25.04.2019 15:54, Jan Beulich wrote: >> It is an issue anyway that a change is >> made without saying why the new behavior preferable over >> the current one. > > So is there a way to continue with this? Why not - I've not said I'm against, I've just asked f

Re: [Xen-devel] [PATCH v1] x86/mm: Make change_type_range return error

2019-05-03 Thread Alexandru Stefan ISAILA
On 25.04.2019 15:54, Jan Beulich wrote: On 24.04.19 at 16:46, wrote: >> On Wed, Apr 24, 2019 at 02:27:32PM +, Alexandru Stefan ISAILA wrote: >>> @@ -1053,15 +1053,11 @@ static void change_type_range(struct p2m_domain >>> *p2m, >>>* This should be revisited later, but for now po

Re: [Xen-devel] [PATCH] xen/arm: skip first page when RAM starts at 0x0

2019-05-03 Thread Jan Beulich
>>> On 03.05.19 at 00:25, wrote: > All right. Looking at the comment in pfn_pdx_hole_setup, it seems that > it is intending to skip the first MAX_ORDER bits, but actually it is > skipping the first MAX_ORDER-1 bits, if my calculations are correct. > > MAX_ORDER is 18 on ARM which correspond to 1G