[Xen-devel] [linux-4.19 baseline test] 129313: tolerable FAIL

2018-11-02 Thread osstest service owner
"Old" tested version had not actually been tested; therefore in this flight we test it, rather than a new candidate. The baseline, if any, is the most recent actually tested revision. flight 129313 linux-4.19 real [real] http://logs.test-lab.xenproject.org/osstest/logs/129313/ Failures :-/ but n

[Xen-devel] [linux-linus test] 129304: regressions - FAIL

2018-11-02 Thread osstest service owner
flight 129304 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/129304/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-boot fail REGR. vs. 125898 test-amd64-

[Xen-devel] [PATCH v6 22/26] xen: support console_switching between Dom0 and DomUs on ARM

2018-11-02 Thread Stefano Stabellini
Today Ctrl-AAA is used to switch between Xen and Dom0. Extend the mechanism to allow for switching between Xen, Dom0, and any of the initial DomU created from Xen alongside Dom0 out of information provided via device tree. Rename xen_rx to console_rx to match the new behavior. Clarify existing co

[Xen-devel] [PATCH v6 07/26] xen/arm: don't add duplicate boot modules, introduce domU flag

2018-11-02 Thread Stefano Stabellini
Don't add duplicate boot modules (same kind and same start address), they are freed later, we don't want to introduce double-free errors. Introduce a domU flag in struct bootmodule and struct bootcmdline. Set it for kernels and ramdisks of "xen,domain" nodes to avoid getting confused in kernel_pro

[Xen-devel] [PATCH v6 25/26] xen/arm: move kernel.h to asm-arm/

2018-11-02 Thread Stefano Stabellini
It will be #included by a file in a xen/arch/arm subdirectory. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/domain_build.c | 2 +- xen/arch/arm/kernel.c| 3 +- xen/arch/arm/kernel.h| 86 xen/include/

[Xen-devel] [PATCH v6 20/26] xen/arm: introduce a union in vpl011

2018-11-02 Thread Stefano Stabellini
Introduce a union in struct vpl011 to contain the console ring members. A later patch will add another member of the union for the case where the backend is in Xen. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v4: - name union "backend" Changes in v3: - rename ring fi

[Xen-devel] [PATCH v6 12/26] xen/arm: introduce allocate_memory

2018-11-02 Thread Stefano Stabellini
Introduce an allocate_memory function able to allocate memory for DomUs and map it at the right guest addresses, according to the guest memory map: GUEST_RAM0_BASE and GUEST_RAM1_BASE. This is under #if 0 as not used for now. Signed-off-by: Julien Grall Signed-off-by: Stefano Stabellini --- Cha

[Xen-devel] [PATCH v6 23/26] xen/arm: Allow vpl011 to be used by DomU

2018-11-02 Thread Stefano Stabellini
Make vpl011 being able to be used without a userspace component in Dom0. In that case, output is printed to the Xen serial and input is received from the Xen serial one character at a time. Call domain_vpl011_init during construct_domU if vpl011 is enabled. Introduce a new ring struct with only t

[Xen-devel] [PATCH v6 15/26] xen/arm: introduce create_domUs

2018-11-02 Thread Stefano Stabellini
Call a new function, "create_domUs", from setup_xen to start DomU VMs. Introduce support for the "xen,domain" compatible node on device tree. Create new DomU VMs based on the information found on device tree under "xen,domain". Call construct_domU for each domain. Introduce a simple global variab

[Xen-devel] [PATCH v6 18/26] xen/arm: make set_interrupt_ppi able to handle non-PPI

2018-11-02 Thread Stefano Stabellini
also rename it to set_interrupt. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/domain_build.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index aee92d

[Xen-devel] [PATCH v6 26/26] xen/arm: split domain_build.c

2018-11-02 Thread Stefano Stabellini
domain_build.c is too large. Move all the ACPI specific device tree generating functions from domain_build.c to acpi/domain_build.c. Signed-off-by: Stefano Stabellini --- Changes in v6: - fix license Changes in v4: - rename acpi_dt_build to domain_build.c - add copyright header - remove usele

[Xen-devel] [PATCH v6 04/26] xen/arm: increase MAX_MODULES

2018-11-02 Thread Stefano Stabellini
Xen boot modules need to account not just for Dom0 but also for a few potential DomUs, each of them coming with their own kernel and initrd. Increase MAX_MODULES to 32 to allow for more DomUs. Signed-off-by: Stefano Stabellini Reviewed-by: Doug Goldstein --- xen/include/asm-arm/setup.h | 2 +-

[Xen-devel] [PATCH v6 24/26] xen/vpl011: buffer out chars when the backend is xen

2018-11-02 Thread Stefano Stabellini
To avoid mixing the output of different domains on the console, buffer the output chars and print line by line. Unless the domain has input from the serial, in which case we want to print char by char for a smooth user experience. The size of SBSA_UART_OUT_BUF_SIZE is arbitrary, choose the same si

[Xen-devel] [PATCH v6 06/26] xen/arm: introduce bootcmdlines

2018-11-02 Thread Stefano Stabellini
Introduce a new array to store the cmdline of each boot module. It is separate from struct bootmodules. Remove the cmdline field from struct boot_module. This way, kernels and initrds with the same address in memory can share struct bootmodule (important because we want them to be free'd only once)

[Xen-devel] [PATCH v6 17/26] xen/arm: generate a simple device tree for domUs

2018-11-02 Thread Stefano Stabellini
Introduce functions to generate a basic domU device tree, similar to the existing functions in tools/libxl/libxl_arm.c. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v5: - use d->arch.vgic.version Changes in v4: - code style - two separate functions for gicv2 and gicv3

[Xen-devel] [PATCH v6 21/26] xen/arm: refactor vpl011_data_avail

2018-11-02 Thread Stefano Stabellini
Move the code to calculate in_fifo_level and out_fifo_level out of vpl011_data_avail, to the caller. This change will make it possible to reuse vpl011_data_avail with different ring structures in a later patch. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - remove

[Xen-devel] [PATCH v6 02/26] xen/arm: extend device tree based multiboot protocol

2018-11-02 Thread Stefano Stabellini
Extend the existing device tree based multiboot protocol to include information regarding multiple domains to boot. Signed-off-by: Stefano Stabellini --- Changes in v4: - memory is 64bit Changes in v3: - remove "xen,initial-domain" for now - make vpl011 an empty property - memory in KBs Change

[Xen-devel] [PATCH v6 08/26] xen/arm: probe domU kernels and initrds

2018-11-02 Thread Stefano Stabellini
Find addresses, sizes on device tree from kernel_probe. Find the cmdline from the bootcmdlines array. Introduce a new boot_module_find_by_addr_and_kind function to match not just on boot module kind, but also by address so that we can support multiple domains. Introduce a boot_cmdline_find_by_nam

[Xen-devel] [PATCH v6 05/26] xen/arm: check for multiboot nodes only under /chosen

2018-11-02 Thread Stefano Stabellini
Make sure to only look for multiboot compatible nodes only under /chosen, not under any other paths (depth <= 3). Signed-off-by: Stefano Stabellini --- Changes in v6: - do not proceed if fdt_get_path returns error != -FDT_ERR_NOSPACE - remove sizeof, use hardcoded value Changes in v5: - add pa

[Xen-devel] [PATCH v6 19/26] xen/arm: generate vpl011 node on device tree for domU

2018-11-02 Thread Stefano Stabellini
Introduce vpl011 support to guests started from Xen: it provides a simple way to print output from a guest, as most guests come with a pl011 driver. It is also able to provide a working console with interrupt support. The UART exposed to the guest is a SBSA compatible UART and not a PL011. SBSA UA

[Xen-devel] [PATCH v6 03/26] xen/arm: document dom0less

2018-11-02 Thread Stefano Stabellini
Add a new document to provide information on how to use dom0less related features and their current limitations. Signed-off-by: Stefano Stabellini --- Changes in v5: - convert to markdown - move to docs/features - add entry to docs/INDEX Changes in v4: - rename to .txt - improve wording Change

[Xen-devel] [PATCH v6 14/26] xen/arm: move unregister_init_virtual_region to init_done

2018-11-02 Thread Stefano Stabellini
Move unregister_init_virtual_region to init_done. Follow the same path as x86. It is also useful to move it later so that create_domUs can be called before that in following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- xen/arch/arm/setup.c | 6 +++--- 1 file changed,

[Xen-devel] [PATCH v6 10/26] xen/arm: rename get_11_allocation_size to get_allocation_size

2018-11-02 Thread Stefano Stabellini
No functional changes. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - no change in print messages - do not remove BUG_ON Changes in v2: - new patch --- xen/arch/arm/domain_build.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/

[Xen-devel] [PATCH v6 01/26] xen: allow console_io hypercalls from certain DomUs

2018-11-02 Thread Stefano Stabellini
Introduce an is_console option to allow certain classes of domUs to use the Xen console. Specifically, it will be used to give console access to all domUs started from Xen from information on device tree. Signed-off-by: Stefano Stabellini Acked-by: Daniel De Graaf CC: andrew.coop...@citrix.com C

[Xen-devel] [PATCH v6 16/26] xen/arm: implement construct_domU

2018-11-02 Thread Stefano Stabellini
Similar to construct_dom0, construct_domU creates a barebone DomU guest. The device tree node passed as argument is compatible "xen,domain", see docs/misc/arm/device-tree/booting.txt. Remove #if 0 from allocate_memory as this patch will start using it. Signed-off-by: Stefano Stabellini Acked-by

[Xen-devel] [PATCH v6 11/26] xen/arm: rename allocate_memory to allocate_memory_11

2018-11-02 Thread Stefano Stabellini
allocate_memory only deals with directly mapped memory. Rename it to allocate_memory_11. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - add patch --- xen/arch/arm/domain_build.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm

[Xen-devel] [PATCH v6 00/25] dom0less step1: boot multiple domains from device tree

2018-11-02 Thread Stefano Stabellini
Hi all, This is first step toward "dom0less" as discussed in the various certifications related threads and discussions. The goal of this series is to enable Xen to boot multiple domains in parallel, in addition to dom0, out of information found on device tree. The device tree based boot protoco

[Xen-devel] [qemu-mainline test] 129305: tolerable FAIL - PUSHED

2018-11-02 Thread osstest service owner
flight 129305 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/129305/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stopfail like 129266 test-armhf-armhf-libvirt 14 sav

[Xen-devel] [PATCH v6 09/26] xen/arm: add start to struct bootcmdline

2018-11-02 Thread Stefano Stabellini
Add a new start address field to struct bootcmdline to easily match a cmdline to the corresponding bootmodule. This is useful for debugging (not actually needed for functionalities today, but could be.) Instead of printing the index in the cmdline array, print the start address of the correspondin

[Xen-devel] [PATCH v6 13/26] xen/arm: refactor construct_dom0

2018-11-02 Thread Stefano Stabellini
Move generic initializations out of construct_dom0 so that they can be reused. Rename prepare_dtb to prepare_dtb_hwdom to avoid confusion. No functional changes in this patch. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v5: - rename __construct_domain to construct_

Re: [Xen-devel] [RFC 14/16] xen/arm: p2m: Extend p2m_get_entry to return the value of bit[0] (valid bit)

2018-11-02 Thread Stefano Stabellini
On Mon, 8 Oct 2018, Julien Grall wrote: > With the recent changes, a P2M entry may be populated but may as not > valid. In some situation, it would be useful to know whether the entry > has been marked available to guest in order to perform a specific > action. So extend p2m_get_entry to return the

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Stefano Stabellini
On Fri, 2 Nov 2018, Julien Grall wrote: > On 02/11/2018 17:56, Stefano Stabellini wrote: > > On Fri, 2 Nov 2018, Ian Jackson wrote: > > > Ie the biggest work here of all kinds is is glue. Adding more > > > entities to the problem will increase rather than reduce the amount of > > > glue code that

Re: [Xen-devel] [RFC 13/16] xen/arm: p2m: Allow to flush cache on any RAM region

2018-11-02 Thread Stefano Stabellini
On Mon, 8 Oct 2018, Julien Grall wrote: > Currently, we only allow to flush cache on region mapped as p2m_ram_{rw,ro}. ^ regions > There are no real problem to flush cache on any RAM region such as grants ^ problems in cache flushing

Re: [Xen-devel] [RFC 12/16] xen/arm: Rework p2m_cache_flush to take a range [begin, end)

2018-11-02 Thread Stefano Stabellini
On Mon, 8 Oct 2018, Julien Grall wrote: > The function will be easier to re-use in a follow-up patch if you have > only the begin and end. > > At the same time, rename the function to reflect the change in the > prototype. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini > ---

Re: [Xen-devel] [RFC 09/16] xen/arm: p2m: Introduce a function to resolve translation fault

2018-11-02 Thread Stefano Stabellini
On Mon, 8 Oct 2018, Julien Grall wrote: > Currently a Stage-2 translation fault could happen: > 1) MMIO emulation > 2) When the page-tables is been updated using Break-Before-Make ^ have > 3) Page not mapped > > A follow-up patch will re-purpose the valid

[Xen-devel] [ovmf baseline-only test] 75561: tolerable FAIL

2018-11-02 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 75561 ovmf real [real] http://osstest.xensource.com/osstest/logs/75561/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: build-amd64-libvirt 6 libvirt-buildfail like 75558 test

Re: [Xen-devel] [RFC 07/16] xen/arm: p2m: Introduce p2m_is_valid and use it

2018-11-02 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > Hi, > > On 30/10/2018 00:21, Stefano Stabellini wrote: > > On Mon, 8 Oct 2018, Julien Grall wrote: > > > The LPAE format allows to store information in an entry even with the > > > valid bit unset. In a follow-up patch, we will take advantage of this > >

Re: [Xen-devel] [PATCH v5 11/25] xen/arm: introduce allocate_memory

2018-11-02 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > Hi, > > On 23/10/2018 03:02, Stefano Stabellini wrote: > > Introduce an allocate_memory function able to allocate memory for DomUs > > and map it at the right guest addresses, according to the guest memory > > map: GUEST_RAM0_BASE and GUEST_RAM1_BASE. > >

Re: [Xen-devel] [PATCH v5 11/25] xen/arm: introduce allocate_memory

2018-11-02 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > Hi Stefano, > > More comments on it :). > > On 10/23/18 3:02 AM, Stefano Stabellini wrote: > > Introduce an allocate_memory function able to allocate memory for DomUs > > and map it at the right guest addresses, according to the guest memory > > map: GUE

Re: [Xen-devel] [PATCH v5 08/25] xen/arm: probe domU kernels and initrds

2018-11-02 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > Hi Stefano, > > On 23/10/2018 03:02, Stefano Stabellini wrote: > > Find addresses, sizes on device tree from kernel_probe. > > Find the cmdline from the bootcmdlines array. > > > > Introduce a new boot_module_find_by_addr_and_kind function to match not >

[Xen-devel] [xtf test] 129339: all pass - PUSHED

2018-11-02 Thread osstest service owner
flight 129339 xtf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129339/ Perfect :-) All tests in this flight passed as required version targeted for testing: xtf c4e81dd692465c728c55a8586e388e241555ff27 baseline version: xtf 5870a695a03af605b5bde5

Re: [Xen-devel] [PATCH v5 07/25] xen/arm: don't add duplicate boot modules, introduce domU flag

2018-11-02 Thread Stefano Stabellini
On Tue, 30 Oct 2018, Julien Grall wrote: > Hi Stefano, > > On 23/10/2018 03:02, Stefano Stabellini wrote: > > Don't add duplicate boot modules (same kind and same start address), > > they are freed later, we don't want to introduce double-free errors. > > > > Introduce a domU flag in struct bootm

[Xen-devel] [PATCH] automation: build some customised configs

2018-11-02 Thread Wei Liu
Introduce a new directory to put in configs we care about. Modify build script to build with those configs. While we only introduce x86 configs initially, provision for non-x86 configs. Signed-off-by: Wei Liu --- Cc: Jan Beulich Jan, feel free to put configs here. --- automation/configs/x86/h

Re: [Xen-devel] [PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV

2018-11-02 Thread Andrew Cooper
On 02/11/18 19:28, Wei Liu wrote: > This function is used by PV code only. This issue is discovered by > clang build. Indeed.  It is only used by two PV hypercalls. > > Signed-off-by: Wei Liu > --- > xen/arch/x86/mm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/

[Xen-devel] [PATCH] x86: put vcpumask_to_pcpumask under CONFIG_PV

2018-11-02 Thread Wei Liu
This function is used by PV code only. This issue is discovered by clang build. Signed-off-by: Wei Liu --- xen/arch/x86/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index f96678f46d..01ec6aa2bf 100644 --- a/xen/arch/x86/mm.c +++ b

[Xen-devel] [ovmf test] 129328: all pass - PUSHED

2018-11-02 Thread osstest service owner
flight 129328 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/129328/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 93f98985826a6eba30584e9b2ada754b3da17990 baseline version: ovmf c4f4984c69ab1057a5d29

Re: [Xen-devel] [PATCH v2 2/2] x86: deal with firmware setting bogus TSC_ADJUST values

2018-11-02 Thread Andrew Cooper
On 02/11/18 16:40, Jan Beulich wrote: > The system Intel have handed me for AVX512 emulator work ("Gigabyte > Technology Co., Ltd. X299 AORUS Gaming 3 Pro/X299 AORUS Gaming 3 > Pro-CF, BIOS F3 12/28/2017") would not come up under Xen - it hung in > the middle of Dom0 PCI initialization. As it turne

Re: [Xen-devel] [PATCH v2 1/2] x86/TSC: don't allow deadline timer to be used with unfixed errata

2018-11-02 Thread Andrew Cooper
On 02/11/18 16:40, Jan Beulich wrote: > In preparation of writes to the TSC_ADJUST MSR, avoid the bad > interaction of writes to it and the TSC_DEADLINE one. Presumably the > original Linux commit bd9240a18e ("x86/apic: Add TSC_DEADLINE quirk due > to errata") refers to e.g. KBW092. (Of course this

Re: [Xen-devel] [PATCH] flask/policy: allow dom0 to use PHYSDEVOP_pci_mmcfg_reserved

2018-11-02 Thread Andrew Cooper
On 02/11/18 17:46, Daniel De Graaf wrote: > Reported-by: Andrew Cooper > Signed-off-by: Daniel De Graaf Acked-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 3/3] x86emul: consolidate CR4 handling

2018-11-02 Thread Andrew Cooper
On 02/11/18 16:46, Jan Beulich wrote: > Now that there's an almost unconditional CR4 read right at the beginning > of x86_emulate(), centralize its reading there and use result and value > everywhere else without further invoking the hook. > > Subsequently we may want to consider having the callers

Re: [Xen-devel] [PATCH 2/3] x86emul: raise #GP(0) in VME mode for POPF with TF set in new value

2018-11-02 Thread Andrew Cooper
On 02/11/18 16:45, Jan Beulich wrote: > This is a check explicitly listed by the instruction page in the SDM. > > Signed-off-by: Jan Beulich Hmm - looking at the listing, I think we've got an IOPL mismatch.  This behaviour, as well as the VIP adjustment in context, only apply at IOPL < 3. ~Andre

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Julien Grall
On 02/11/2018 17:56, Stefano Stabellini wrote: On Fri, 2 Nov 2018, Ian Jackson wrote: Ie the biggest work here of all kinds is is glue. Adding more entities to the problem will increase rather than reduce the amount of glue code that needs to be written. Basically, you are saying that even

Re: [Xen-devel] [PATCH] x86/vcpu: Remove struct vcpu allocation restriction for !CONFIG_SHADOW_PAGING

2018-11-02 Thread Wei Liu
On Fri, Nov 02, 2018 at 05:54:00PM +, Andrew Cooper wrote: > There is no need for struct vcpu to live below the 4G boundary if shadow > paging is compiled out. > > Signed-off-by: Andrew Cooper Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-d

Re: [Xen-devel] [PATCH 1/3] x86emul: VME and PVI modes require a #GP(0) check first thing

2018-11-02 Thread Andrew Cooper
On 02/11/18 16:45, Jan Beulich wrote: > As explicitly spelled out by the SDM, EFLAGS.VIF and EFLAGS.VIP both set > at the start of an instruction trigger #GP(0) independent of actual > instruction. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___

[Xen-devel] x86 Community Call: Nov 14 - 15:00 - 16:00 UTC - Call for Agenda Items

2018-11-02 Thread Lars Kurth
Hi all, It’s time again for the x86 community call: for the agenda see https://docs.google.com/document/d/1RxW-iwcFFuKzNjjEqLEtiwFVHgAUlk35c0EtTkRE1k4/edit# Please propose new agenda items by next Friday (feel free to just add them to the document or reply to this mail) I listed open Actions

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Stefano Stabellini
On Fri, 2 Nov 2018, Ian Jackson wrote: > > > If the Debian cross compilers are OK, then I think the necessary > > > changes to osstest are: > ... > > I thought that we could have provided a deb repository with alternative > > kernels for OSSTests to use. We would have scripts to generate those deb

[Xen-devel] [PATCH] x86/vcpu: Remove struct vcpu allocation restriction for !CONFIG_SHADOW_PAGING

2018-11-02 Thread Andrew Cooper
There is no need for struct vcpu to live below the 4G boundary if shadow paging is compiled out. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: George Dunlap CC: Tim Deegan --- xen/arch/x86/domain.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xen

Re: [Xen-devel] [RFC PATCH v2 13/17] xenconsoled: add support for up to 3 secondary consoles [and 1 more messages]

2018-11-02 Thread Ian Jackson
Marek Marczykowski-Górecki writes ("Re: [RFC PATCH v2 13/17] xenconsoled: add support for up to 3 secondary consoles"): > On Thu, Nov 01, 2018 at 05:31:18PM +, Ian Jackson wrote: > > I'm confused. I thought we already had support for multiple PV > > consoles. Is the problem that the backend

[Xen-devel] [PATCH] flask/policy: allow dom0 to use PHYSDEVOP_pci_mmcfg_reserved

2018-11-02 Thread Daniel De Graaf
Reported-by: Andrew Cooper Signed-off-by: Daniel De Graaf --- tools/flask/policy/modules/dom0.te | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/flask/policy/modules/dom0.te b/tools/flask/policy/modules/dom0.te index dfdcdcd128..a0566671d6 100644 --- a/tools/flask/policy/modules/do

[Xen-devel] [xen-unstable-smoke test] 129330: tolerable all pass - PUSHED

2018-11-02 Thread osstest service owner
flight 129330 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129330/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[Xen-devel] [PATCH 3/8] tools/libvchan: init_xs_srv: Simplify error handling (1)

2018-11-02 Thread Ian Jackson
* Use xs_close instead of the deprecated xs_daemon_close. * Initialise xs to NULL.That means xs_close can now be called in all cases. Move it to the fail clause. * free(domid_str) is already safe in all cases since domid_str is initialised to NULL. Move it to the fail clause. No overal

[Xen-devel] [PATCH 8/8] tools/libvchan: libxenvchan_client_init: use ENOENT for no server

2018-11-02 Thread Ian Jackson
* Promise that we will set errno to ENOENT if the server is not yet set up. * Arrange that all ENOENT returns other than from the read of ring-ref are turned into EIO, logging when we do so. Signed-off-by: Ian Jackson --- tools/libvchan/init.c| 11 ++- tools/libvchan/libxenvc

[Xen-devel] [PATCH 2/8] tools/xenstore: Document that xs_close(0) is OK.

2018-11-02 Thread Ian Jackson
Signed-off-by: Ian Jackson --- tools/xenstore/include/xenstore.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/xenstore/include/xenstore.h b/tools/xenstore/include/xenstore.h index 064b62c455..889dc23863 100644 --- a/tools/xenstore/include/xenstore.h +++ b/tools/xenst

[Xen-devel] [PATCH 4/8] tools/libvchan: init_xs_srv: Simplify error handling (2)

2018-11-02 Thread Ian Jackson
* Abolish fail_xs_open which is now exactly the same as fail. * Change all gotos to refer to fail instead. No functional change. Signed-off-by: Ian Jackson --- tools/libvchan/init.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/tools/libvchan/init.c b/tools/

[Xen-devel] [PATCH 5/8] tools/libvchan: init_xs_srv: Turn xs retry from goto into for (; ; )

2018-11-02 Thread Ian Jackson
No functional change. Signed-off-by: Ian Jackson --- tools/libvchan/init.c | 50 ++ 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/tools/libvchan/init.c b/tools/libvchan/init.c index f099765a38..d987acd338 100644 --- a/tools/libvch

[Xen-devel] [PATCH 7/8] tools/libvchan: libxenvchan_*_init: Promise an errno

2018-11-02 Thread Ian Jackson
Thse functiosn do in fact leave errno set. We are going to want to use this. Signed-off-by: Ian Jackson --- tools/libvchan/libxenvchan.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libvchan/libxenvchan.h b/tools/libvchan/libxenvchan.h index d6010b145d..e4ccca1f

[Xen-devel] [PATCH 6/8] tools/libvchan: Add xentoollog to direct dependencies

2018-11-02 Thread Ian Jackson
We are going to add a call to xtl_log. Signed-off-by: Ian Jackson --- tools/libvchan/Makefile | 6 +++--- tools/libvchan/xenvchan.pc.in | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libvchan/Makefile b/tools/libvchan/Makefile index de9b44978f..c236a0f9e6 1006

[Xen-devel] [PATCH 1/8] tools/libvchan: Initialise xs_transaction_t to XBT_NULL, not NULL

2018-11-02 Thread Ian Jackson
This is an integer type, not a pointer. Signed-off-by: Ian Jackson --- tools/libvchan/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libvchan/init.c b/tools/libvchan/init.c index ba5a6eb29e..180833dc2f 100644 --- a/tools/libvchan/init.c +++ b/tools/libvchan/init

[Xen-devel] [PATCH 0/8] libvchan: Minor improvements

2018-11-02 Thread Ian Jackson
Mostly internal tidying, but also an API promise about what ENOENT means from libxenvchan_client_init. Ian Jackson (8): tools/libvchan: Initialise xs_transaction_t to XBT_NULL, not NULL tools/xenstore: Document that xs_close(0) is OK. tools/libvchan: init_xs_srv: Simplify error handling (1)

[Xen-devel] [distros-debian-jessie test] 75562: tolerable FAIL

2018-11-02 Thread Platform Team regression test user
flight 75562 distros-debian-jessie real [real] http://osstest.xensource.com/osstest/logs/75562/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-i386-jessie-netboot-pvgrub 19 guest-start/debian.repeat fail blocked in 75509 test-armhf-armhf-arm

Re: [Xen-devel] [RFC PATCH v2 00/17] Add support for qemu-xen runnning in a Linux-based stubdomain.

2018-11-02 Thread Ian Jackson
Marek Marczykowski-Górecki writes ("Re: [RFC PATCH v2 00/17] Add support for qemu-xen runnning in a Linux-based stubdomain."): > Doing it in this order would be susceptible to a race condition - > server appearing after libxenvchan_client_init check, but before libxl > register the watch. I see t

[Xen-devel] [PATCH 3/3] x86emul: consolidate CR4 handling

2018-11-02 Thread Jan Beulich
Now that there's an almost unconditional CR4 read right at the beginning of x86_emulate(), centralize its reading there and use result and value everywhere else without further invoking the hook. Subsequently we may want to consider having the callers provide whichever value they deem appropriate

[Xen-devel] [PATCH 2/3] x86emul: raise #GP(0) in VME mode for POPF with TF set in new value

2018-11-02 Thread Jan Beulich
This is a check explicitly listed by the instruction page in the SDM. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -4049,6 +4049,7 @@ x86_emulate( dst.val = (uint16_t)dst.val | (_regs.eflags & 0xu);

[Xen-devel] [PATCH 1/3] x86emul: VME and PVI modes require a #GP(0) check first thing

2018-11-02 Thread Jan Beulich
As explicitly spelled out by the SDM, EFLAGS.VIF and EFLAGS.VIP both set at the start of an instruction trigger #GP(0) independent of actual instruction. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -3247,6 +3247,11 @@ x8

[Xen-devel] [PATCH 0/3] x86emul: VME/PVI mode fixes

2018-11-02 Thread Jan Beulich
1: VME and PVI modes require a #GP(0) check first thing 2: raise #GP(0) in VME mode for POPF with TF set in new value 3: consolidate CR4 handling Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listin

[Xen-devel] [PATCH v2 2/2] x86: deal with firmware setting bogus TSC_ADJUST values

2018-11-02 Thread Jan Beulich
The system Intel have handed me for AVX512 emulator work ("Gigabyte Technology Co., Ltd. X299 AORUS Gaming 3 Pro/X299 AORUS Gaming 3 Pro-CF, BIOS F3 12/28/2017") would not come up under Xen - it hung in the middle of Dom0 PCI initialization. As it turned out, Xen's time management did not work beca

[Xen-devel] [PATCH v2 1/2] x86/TSC: don't allow deadline timer to be used with unfixed errata

2018-11-02 Thread Jan Beulich
In preparation of writes to the TSC_ADJUST MSR, avoid the bad interaction of writes to it and the TSC_DEADLINE one. Presumably the original Linux commit bd9240a18e ("x86/apic: Add TSC_DEADLINE quirk due to errata") refers to e.g. KBW092. (Of course this is an issue also without us writing the TSC_A

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Ian Jackson
Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]"): > On 02/11/2018 15:44, Ian Jackson wrote: > > We have more x86 capacity and are deploying some dedicated build > > hosts. But cross-compilation is more comple

[Xen-devel] [PATCH v2 0/2] x86: deal with firmware setting bogus TSC_ADJUST values

2018-11-02 Thread Jan Beulich
1: x86/TSC: don't allow deadline timer to be used with unfixed errata 2: x86: deal with firmware setting bogus TSC_ADJUST values v2: New patch 1, only cosmetic changes to patch 2. Jan ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages]

2018-11-02 Thread Stefano Stabellini
On Fri, 2 Nov 2018, Lars Kurth wrote: > I thought that we could have provided a deb repository with alternative > kernels for OSSTests to use. We would have scripts to generate those deb > packages from the Xen ARM Linux tree in a repository on xenbits, but we > wouldn't necessarily

Re: [Xen-devel] [PATCH v3] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM

2018-11-02 Thread Juergen Gross
On 01/11/2018 00:11, Stefano Stabellini wrote: > From: Stefano Stabellini > > xen_create_contiguous_region has now only an implementation if > CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but > we do have an implementation of xen_create_contiguous_region which is > require

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Julien Grall
Hi, On 02/11/2018 15:44, Ian Jackson wrote: Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]"): On 02/11/2018 15:05, Ian Jackson wrote: I guess that's probably tolerable. We'd have to think about whether w

[Xen-devel] [PATCH v3 7/7] x86: update help string for CONFIG_HVM

2018-11-02 Thread Wei Liu
Update text. Change "guest" to "domain" where appropriate because "guest" doesn't include Domain 0. Signed-off-by: Wei Liu --- v3: update text v2: new --- xen/arch/x86/Kconfig | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfi

[Xen-devel] [PATCH v3 1/7] x86: make traps.c build with !CONFIG_PV

2018-11-02 Thread Wei Liu
Provide a stub for pv_inject_event, put code that accesses PV fields and GDT / LDT fault handling code under CONFIG_PV. Signed-off-by: Wei Liu --- v3: 1. don't skip updating dr_masks in activate_debugregs. 2. remove ASSERT_UNREACHABLE in fixup_page_fault. v2: reduce the amount of ifdefs --- xen

[Xen-devel] [PATCH v3 3/7] x86: make PV hypercall entry points work with !CONFIG_PV

2018-11-02 Thread Wei Liu
We want Xen to crash if we hit these paths when PV is disabled. For syscall, we provide stubs for {l,c}star_enter which end up calling panic. For sysenter, we initialise CS to 0 so that #GP can be raised. Signed-off-by: Wei Liu --- v3: rewrite --- xen/arch/x86/hvm/vmx/vmcs.c | 5 +++-- xen/ar

[Xen-devel] [PATCH v3 5/7] x86: make entry point code build when !CONFIG_PV

2018-11-02 Thread Wei Liu
Skip building x86_64/compat/entry.S and put CONFIG_PV in x86_64/entry.S. Signed-off-by: Wei Liu --- v3: 1. make CR4_PV32_RESTORE expand to nothing when !PV 2. use unconditional jmp and add assertions v2: new --- xen/arch/x86/x86_64/Makefile| 2 +- xen/arch/x86/x86_64/entry.S | 39 +

[Xen-devel] [PATCH v3 4/7] x86: rearrange x86_64/entry.S

2018-11-02 Thread Wei Liu
Split the file into two halves. The first half pertains to PV guest code while the second half is mostly used by the hypervisor itself to handle interrupts and exceptions. No functional change intended. Signed-off-by: Wei Liu --- v3: remove self_ipi_restore_all_guest v2: new, requested by Andrew

[Xen-devel] [PATCH v3 0/7] Make CONFIG_PV work on x86

2018-11-02 Thread Wei Liu
Hi all This series makes CONFIG_PV work. Booting a hypervisor with PVH Dom0 works. Due to an issue in Xen implementation, XTF tests cause hypervisor to crash (seen on staging as well). But with a local patch to work around the issue, all XTF HVM tests passed. See v1 cover letter for more inform

[Xen-devel] [PATCH v3 6/7] x86: expose CONFIG_PV

2018-11-02 Thread Wei Liu
Signed-off-by: Wei Liu Reviewed-by: Andrew Cooper --- v3: update text v2: guest -> domain --- xen/arch/x86/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 548cbf9..37af728 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/K

[Xen-devel] [PATCH v3 2/7] x86/domctl: rework XEN_DOMCTL_{set, get}_address_size

2018-11-02 Thread Wei Liu
Going through toolstack code, they are used for PV guests only. Tighten their access to PV only. Return -EOPNOTSUPP if they are called on HVM guests. Rewrite the code in a pattern that makes DCE work. Signed-off-by: Wei Liu --- v3: rewritten --- xen/arch/x86/domctl.c | 32 ++

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Ian Jackson
Julien Grall writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]"): > On 02/11/2018 15:05, Ian Jackson wrote: > > I guess that's probably tolerable. We'd have to think about whether > > we should snapshot them, or install them

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Julien Grall
Hi, On 02/11/2018 15:05, Ian Jackson wrote: Stefano Stabellini writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages]"): Thank you for the detailed answer and the willingness to see osstest changed in this respect. Sure. It's not fixed in stone,

Re: [Xen-devel] [PATCH v8 6/8] docs: documentation about static shared memory regions

2018-11-02 Thread Ian Jackson
George Dunlap writes ("Re: [PATCH v8 6/8] docs: documentation about static shared memory regions"): > > On Oct 31, 2018, at 3:35 PM, Stefano Stabellini > > wrote: > > On Wed, 31 Oct 2018, Ian Jackson wrote: > >> But we need to know what the new terminology should be. Is `owner' > >> and `borrow

Re: [Xen-devel] [PATCH] xen/grant-table: Fix incorrect gnttab_dma_free_pages() pr_debug message

2018-11-02 Thread Juergen Gross
On 02/11/2018 15:04, Liam Merwick wrote: > If a call to xenmem_reservation_increase() in gnttab_dma_free_pages() > fails it triggers a message "Failed to decrease reservation..." which > should be "Failed to increase reservation..." > > Fixes: 9bdc7304f536 ('xen/grant-table: Allow allocating buffe

Re: [Xen-devel] [PATCH v3] devicetree, xen: add xen, shared-memory binding

2018-11-02 Thread Julien Grall
Hi Ian, On 02/11/2018 15:30, Ian Jackson wrote: Julien Grall writes ("Re: [PATCH v3] devicetree,xen: add xen,shared-memory binding"): On 11/1/18 8:40 PM, Stefano Stabellini wrote: From the DT binding point of view, it would be fine. Conceptually it would also be fine. However, I doubt that

Re: [Xen-devel] [PATCH v3] devicetree, xen: add xen, shared-memory binding

2018-11-02 Thread Ian Jackson
Julien Grall writes ("Re: [PATCH v3] devicetree,xen: add xen,shared-memory binding"): > On 11/1/18 8:40 PM, Stefano Stabellini wrote: > > From the DT binding point of view, it would be fine. Conceptually it > > would also be fine. However, I doubt that the current libxl > > implementation would w

Re: [Xen-devel] [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages] [and 2 more messages]

2018-11-02 Thread Ian Jackson
Stefano Stabellini writes ("Re: [OSSTEST PATCH] README.hardware-acquisition [and 1 more messages] [and 2 more messages]"): > Thank you for the detailed answer and the willingness to see osstest > changed in this respect. Sure. It's not fixed in stone, and a variety of approachs will fit into it

Re: [Xen-devel] [PATCH v2 11/16] x86: don't set sysenter_entry in vmcs when !CONFIG_PV

2018-11-02 Thread Wei Liu
On Fri, Nov 02, 2018 at 08:32:11AM -0600, Jan Beulich wrote: > >>> On 02.11.18 at 15:05, wrote: > > On Fri, Oct 19, 2018 at 03:28:37PM +0100, Wei Liu wrote: > >> The symbol will not be available when PV is disabled. > >> > >> Signed-off-by: Wei Liu > > > > In light of the discussion of the prev

Re: [Xen-devel] [PATCH v2 11/16] x86: don't set sysenter_entry in vmcs when !CONFIG_PV

2018-11-02 Thread Jan Beulich
>>> On 02.11.18 at 15:05, wrote: > On Fri, Oct 19, 2018 at 03:28:37PM +0100, Wei Liu wrote: >> The symbol will not be available when PV is disabled. >> >> Signed-off-by: Wei Liu > > In light of the discussion of the previous patch, a stub for > sysenter_entry will be provided, so this patch can

[Xen-devel] [xen-unstable-smoke test] 129322: regressions - FAIL

2018-11-02 Thread osstest service owner
flight 129322 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/129322/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 6 xen-install fail REGR. vs. 129286 Tests which

  1   2   >