Re: [Xen-devel] [PATCH v3 0/9] xen: dma-buf support for grant device

2018-06-13 Thread Oleksandr Andrushchenko
Hi, Boris! It seems that I have resolved all the issues now which were mainly cleanup and code movement and 5 of 9 patches already have r-b's. Do you, as the primary reviewer of the series, think I can push (hopefully) the final version of the patches? Just in case you want to look at v4 it is at

Re: [Xen-devel] [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-13 Thread Oleksandr Andrushchenko
On 06/14/2018 01:03 AM, Boris Ostrovsky wrote: On 06/13/2018 05:04 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 06:14 AM, Boris Ostrovsky wrote: On 06/12/2018 09:42 AM, Oleksandr Andrushchenko wrote:   int gntdev_dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 fd)   { -    retu

Re: [Xen-devel] How to deal with hypercalls returning -EFAULT

2018-06-13 Thread Juergen Gross
On 13/06/18 18:06, Ian Jackson wrote: > Juergen Gross writes ("How to deal with hypercalls returning -EFAULT"): >> 3. Modify the interface to the privcmd driver to pass information about >>used buffers to the kernel in order to lock them there. Either add a >>new interface for hypercall buf

Re: [Xen-devel] How to deal with hypercalls returning -EFAULT

2018-06-13 Thread Juergen Gross
On 13/06/18 18:25, Andrew Cooper wrote: > On 13/06/18 16:27, Juergen Gross wrote: >> Currently the release of Xen 4.11 is blocked due to a sporadic failure >> of the OSSTEST guest-saverestore[.2]. During that test a hypercall >> issued by libxc via the Linux privcmd driver returns -EFAULT in spite

Re: [Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-13 Thread Oleksandr Andrushchenko
On 06/14/2018 01:19 AM, Boris Ostrovsky wrote: On 06/13/2018 07:57 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 05:58 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: + +static struct gntdev_dmabuf * +dmabuf_exp_wait_obj_get_by_fd(struct gntdev_dmabuf_priv

[Xen-devel] [xen-4.8-testing test] 124158: regressions - trouble: broken/fail/pass

2018-06-13 Thread osstest service owner
flight 124158 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/124158/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-credit2 broken build-armhf-xsm

[Xen-devel] Is there a faster way to restore Virtual machine status in Xen?

2018-06-13 Thread Chenjia (C)
Dear XEN expert: We meet some problem in our project: In our previous project, we use KVM, and we do some job like this: We create KVM snapshot by “virsh snapshot-create $DomainName $SnapshotXml”, then do following job: While(1) { Run “virsh snapshot-revert $DomainName $Snapshot --r

[Xen-devel] [ovmf test] 124162: regressions - FAIL

2018-06-13 Thread osstest service owner
flight 124162 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/124162/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 124058 version targeted for testi

[Xen-devel] [xen-unstable-smoke test] 124182: tolerable all pass - PUSHED

2018-06-13 Thread osstest service owner
flight 124182 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/124182/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-arm64-arm64-xl-xsm 1

Re: [Xen-devel] [RFC PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation

2018-06-13 Thread Anchal Agarwal
Hi Roger, To answer your question, due to the lack of mentioned commit (commit 12ea729645ac ("xen/blkback: unmap all persistent grants when frontend gets disconnected") in the older dom0 kernels(<3.2),resume from hibernation can fail on guest side. In the absence of the commit, Persistant Grants ar

Re: [Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-13 Thread Boris Ostrovsky
On 06/13/2018 07:57 AM, Oleksandr Andrushchenko wrote: > On 06/13/2018 05:58 AM, Boris Ostrovsky wrote: >> >> >> On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: >>> >>> + >>> +static struct gntdev_dmabuf * >>> +dmabuf_exp_wait_obj_get_by_fd(struct gntdev_dmabuf_priv *priv, int fd) >> >> >> T

[Xen-devel] [PATCH RFC 07/15] xen/arm: increase MAX_MODULES

2018-06-13 Thread Stefano Stabellini
Xen boot modules need to account not just for Dom0 but also for a few potential DomUs, each of them coming with their own kernel and initrd. Increase MAX_MODULES to 32 to allow for more DomUs. Signed-off-by: Stefano Stabellini --- xen/include/asm-arm/setup.h | 2 +- 1 file changed, 1 insertion(+

[Xen-devel] [PATCH RFC 06/15] xen/arm: add BOOTMOD_DOMU_KERNEL/RAMDISK

2018-06-13 Thread Stefano Stabellini
Introduce bootmod types for domU kernels and initrds. Signed-off-by: Stefano Stabellini --- xen/arch/arm/bootfdt.c | 4 xen/arch/arm/setup.c| 2 ++ xen/include/asm-arm/setup.h | 2 ++ 3 files changed, 8 insertions(+) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-13 Thread Manuel Bouyer
On Wed, Jun 13, 2018 at 03:59:19AM -0600, Jan Beulich wrote: > >>> On 13.06.18 at 10:57, wrote: > > On Wed, Jun 13, 2018 at 02:07:29AM -0600, Jan Beulich wrote: > >> > >> (XEN) Assertion '!page->linear_pt_count' failed at mm.c:596 > >> > >> In fact, there's no assertion with that expression anyw

[Xen-devel] [PATCH RFC 15/15] xen: support console_switching between Dom0 and DomUs on ARM

2018-06-13 Thread Stefano Stabellini
Today Ctrl-AAA is used to switch between Xen and Dom0. Extend the mechanism to allow for switching between Xen, Dom0, and any of the initial DomU created from Xen alongside Dom0 out of information provided via device tree. Signed-off-by: Stefano Stabellini CC: andrew.coop...@citrix.com CC: george

[Xen-devel] [PATCH RFC 12/15] xen/arm: generate vpl011 node on device tree for domU

2018-06-13 Thread Stefano Stabellini
Introduce vpl011 support to guests started from Xen: it provides a simple way to print output from a guest, as most guests come with a pl011 driver. It is also able to provide a working console with interrupt support. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 70 +++

[Xen-devel] [PATCH RFC 13/15] xen/arm: Allow vpl011 to be used by DomU

2018-06-13 Thread Stefano Stabellini
Make vpl011 being able to be used without a userspace component in Dom0. In that case, output is printed to the Xen serial and input is received from the Xen serial one character at a time. Call domain_vpl011_init during construct_domU. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_

[Xen-devel] [PATCH RFC 10/15] xen/arm: introduce construct_domU

2018-06-13 Thread Stefano Stabellini
Similar to construct_dom0, construct_domU creates a barebone DomU guest. Default to 1 max vcpu and 64MB of memory if not specified otherwise. The device tree node passed as argument is compatible "xen,domU", see docs/misc/arm/device-tree/booting.txt. Allocate all vcpus on cpu0 initially. Signed-

[Xen-devel] [PATCH RFC 11/15] xen/arm: generate a simple device tree for domUs

2018-06-13 Thread Stefano Stabellini
Introduce functions to generate a basic domU device tree, similar to the existing functions in tools/libxl/libxl_arm.c. Rename existing prepare_dtb to prepare_dtb_dom0 to avoid confusion. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 195 +++

[Xen-devel] [PATCH RFC 01/15] xen: allow console_io hypercalls from DomUs on ARM

2018-06-13 Thread Stefano Stabellini
This is very useful when starting multiple domains from Xen without xenstore access. It will allow them to print out to the Xen console. Signed-off-by: Stefano Stabellini CC: andrew.coop...@citrix.com CC: george.dun...@eu.citrix.com CC: ian.jack...@eu.citrix.com CC: jbeul...@suse.com CC: konrad.w

[Xen-devel] [PATCH RFC 14/15] xen/arm: call construct_domU from start_xen and start DomU VMs

2018-06-13 Thread Stefano Stabellini
Introduce support for the "xen,domU" compatible node on device tree. Create new DomU VMs based on the information found on device tree under "xen,domU". Introduce a simple global variable named max_init_domid to keep track of the initial allocated domids. Move the discard_initial_modules after Do

[Xen-devel] [PATCH RFC 03/15] xen/arm: extend device tree based multiboot protocol

2018-06-13 Thread Stefano Stabellini
Extend the existing device tree based multiboot protocol to include information regarding other domUs to boot. Signed-off-by: Stefano Stabellini --- docs/misc/arm/device-tree/booting.txt | 102 ++ 1 file changed, 102 insertions(+) diff --git a/docs/misc/arm/devic

[Xen-devel] [PATCH RFC 08/15] xen/arm: probe domU kernels and initrds

2018-06-13 Thread Stefano Stabellini
Find addresses and sizes on device tree. Introduce a new boot_module_find_by_addr_and_kind function to match not just on boot module kind, but also by address so that we can support multiple domUs. Signed-off-by: Stefano Stabellini --- xen/arch/arm/kernel.c | 54 +++

[Xen-devel] [PATCH RFC 02/15] xen/arm: move a few guest related #defines to public/arch-arm.h

2018-06-13 Thread Stefano Stabellini
Move a few constants defined by libxl_arm.c to xen/include/public/arch-arm.h, so that they are together with the other guest related #defines such as GUEST_GICD_BASE and GUEST_VPL011_SPI. Also, this way they can be reused by hypervisor code. Signed-off-by: Stefano Stabellini CC: wei.l...@citrix.c

[Xen-devel] [PATCH RFC 04/15] xen/arm: do not pass dt_host to make_memory_node and make_hypervisor_node

2018-06-13 Thread Stefano Stabellini
In order to make make_memory_node and make_hypervisor_node more reusable, do not pass them dt_host. As they only use it to calculate addrcells and sizecells, pass addrcells and sizecells directly. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 20 ++-- xen/

[Xen-devel] [PATCH RFC 09/15] xen/arm: refactor construct_dom0

2018-06-13 Thread Stefano Stabellini
Move generic initializations out of construct_dom0 so that they can be reused. No functional changes in this patch. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 124 1 file changed, 67 insertions(+), 57 deletions(-) diff --git

[Xen-devel] [PATCH RFC 05/15] xen/arm: rename acpi_make_chosen_node to make_chosen_node

2018-06-13 Thread Stefano Stabellini
acpi_make_chosen_node is actually generic and can be reused. Rename it to make_chosen_node and make it available to non-ACPI builds. Signed-off-by: Stefano Stabellini --- xen/arch/arm/domain_build.c | 84 ++--- 1 file changed, 42 insertions(+), 42 deletion

[Xen-devel] [PATCH RFC 00/15] dom0less step1: boot multiple domains from device tree

2018-06-13 Thread Stefano Stabellini
Hi all, This is first step toward "dom0less" as discussed in the various certifications related threads and discussions. The goal of this series is to enable Xen to boot multiple domains in parallel, in addition to dom0, out of information found on device tree. The device tree based boot protoco

Re: [Xen-devel] [PATCH v3 9/9] xen/gntdev: Implement dma-buf import functionality

2018-06-13 Thread Boris Ostrovsky
On 06/13/2018 05:04 AM, Oleksandr Andrushchenko wrote: > On 06/13/2018 06:14 AM, Boris Ostrovsky wrote: >> >> >> On 06/12/2018 09:42 AM, Oleksandr Andrushchenko wrote: >> >>>   int gntdev_dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 >>> fd) >>>   { >>> -    return -EINVAL; >>> +    struc

[Xen-devel] [PATCH v6 08/13] arm: add ALL, QEMU, Rcar3 and MPSoC configs

2018-06-13 Thread Stefano Stabellini
Add a "Platform Support" choice with four kconfig options: QEMU, RCAR3, MPSOC and ALL. They enable the required options for their hardware platform. ALL enables all available platforms and it's the default. It doesn't automatically select any of the related drivers, otherwise they cannot be disable

[Xen-devel] [PATCH v6 05/13] make it possible to enable/disable UART drivers

2018-06-13 Thread Stefano Stabellini
All the UART drivers are silent options. Add one line descriptions so that can be de/selected via menuconfig. Add an x86 dependency to HAS_EHCI: EHCI PCI has not been used on ARM. In fact, it depends on PCI, and moreover we have drivers for several embedded UARTs for various ARM boards. NS16550 r

[Xen-devel] [PATCH v6 07/13] arm: add a tiny kconfig configuration

2018-06-13 Thread Stefano Stabellini
Add a tiny kconfig configuration. Enabled NULL and Credit schedulers. It only carries non-default options (use make menuconfig or make olddefconfig to produce a complete .config file). Signed-off-by: Stefano Stabellini --- --- xen/arch/arm/configs/tiny64.conf | 43 ++

[Xen-devel] [PATCH v6 02/13] arm: make it possible to disable HAS_GICV3

2018-06-13 Thread Stefano Stabellini
Today it is a silent option. This patch adds a one line description and makes it optional. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall CC: george.dun...@eu.citrix.com CC: ian.jack...@eu.citrix.com CC: jbeul...@suse.com CC: andrew.coop...@citrix.com --- Changes in v3: - remove any c

[Xen-devel] [PATCH v6 03/13] arm: rename HAS_GICV3 to GICV3

2018-06-13 Thread Stefano Stabellini
HAS_GICV3 has become selectable by the user. To mark the change, rename the option from HAS_GICV3 to GICV3. Suggested-by: Julien Grall Signed-off-by: Stefano Stabellini Acked-by: Julien Grall --- Changes in v3: - no changes Changes in v2: - patch added --- xen/arch/arm/Kconfig | 4 ++--

[Xen-devel] [PATCH v6 13/13] xen: clarify the security-support status of Kconfig options on ARM

2018-06-13 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini CC: george.dun...@eu.citrix.com CC: ian.jack...@eu.citrix.com CC: jbeul...@suse.com CC: andrew.coop...@citrix.com --- SUPPORT.md | 10 ++ 1 file changed, 10 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index c5ec849..f37a3e6 100644 --- a/SUPPORT.md

[Xen-devel] [PATCH v6 12/13] xen: specify support for EXPERT and DEBUG Kconfig options

2018-06-13 Thread Stefano Stabellini
Add a clear statement about them, reflecting the current security support status of Kconfig options (no changes to current policies). Signed-off-by: Stefano Stabellini CC: george.dun...@eu.citrix.com CC: ian.jack...@eu.citrix.com CC: jbeul...@suse.com CC: andrew.coop...@citrix.com --- SUPPORT.md

[Xen-devel] [PATCH v6 09/13] xen: add per-platform defaults for NR_CPUS

2018-06-13 Thread Stefano Stabellini
Add specific per-platform defaults for NR_CPUS. Note that the order of the defaults matter: they need to go first, otherwise the generic defaults will be applied. This is done so that Xen builds customized for a specific hardware platform can have the right NR_CPUS number. Signed-off-by: Stefano

[Xen-devel] [PATCH v6 11/13] xen: support the Null scheduler

2018-06-13 Thread Stefano Stabellini
The Null scheduler has been in the tree long enough to be marked supported. Signed-off-by: Stefano Stabellini CC: george.dun...@eu.citrix.com CC: ian.jack...@eu.citrix.com CC: jbeul...@suse.com CC: andrew.coop...@citrix.com CC: dfaggi...@suse.com --- SUPPORT.md | 2 +- xen/common/Kconfig

[Xen-devel] [PATCH v6 06/13] arm: make it possible to disable the SMMU driver

2018-06-13 Thread Stefano Stabellini
Introduce a Kconfig option for the ARM SMMUv1 and SMMUv2 driver. Signed-off-by: Stefano Stabellini Acked-by: Julien Grall Acked-by: Jan Beulich CC: jbeul...@suse.com --- Changes in v3: - rename SMMUv2 to ARM_SMMU - improve help message - use if ARM Changes in v2: - rename HAS_SMMUv2 to SMMUv2

[Xen-devel] [PATCH v6 04/13] Make MEM_ACCESS configurable

2018-06-13 Thread Stefano Stabellini
Select MEM_ACCESS_ALWAYS_ON on x86 to mark that MEM_ACCESS is not configurable on x86. Avoid selecting it on ARM. Rename HAS_MEM_ACCESS to MEM_ACCESS everywhere. Add a prompt and a description to MEM_ACCESS in xen/common/Kconfig. The result is that the user-visible option is MEM_ACCESS, and it is

[Xen-devel] [PATCH v6 01/13] arm: remove the ARM HDLCD driver

2018-06-13 Thread Stefano Stabellini
The ARM HDLCD driver is unused. The device itself can only be found on Virtual Express boards that are for early development only. Remove the driver. Also remove vexpress_syscfg, now unused, and "select VIDEO" that is not useful anymore. Suggested-by: Julien Grall Signed-off-by: Stefano Stabelli

[Xen-devel] [PATCH v6 0/13] arm: more kconfig configurability and small default configs

2018-06-13 Thread Stefano Stabellini
Hi all, This patch series is the first step toward building a small certifiable Xen hypervisor for ARM boards. The series makes a few changes to allow disabling more kconfig options: most of them already exist but cannot be disabled. It also introduces a reference kconfig for Renesas RCar (due to

[Xen-devel] [PATCH v6 10/13] xen: add cloc target

2018-06-13 Thread Stefano Stabellini
Add a Xen build target to count the lines of code of the source files built. Uses `cloc' to do the job. With Xen on ARM taking off in embedded, IoT, and automotive, we are seeing more and more uses of Xen in constrained environments. Users and system integrators want the smallest Xen and Dom0 conf

Re: [Xen-devel] [PATCH v5 0/10] arm: more kconfig configurability and small default configs

2018-06-13 Thread Stefano Stabellini
On Tue, 12 Jun 2018, Julien Grall wrote: > > diff --git a/SUPPORT.md b/SUPPORT.md > > index 264b23f..e70f35c 100644 > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -16,6 +16,18 @@ for the definitions of the support status levels etc. > > # Feature Support > > +## Kconfig > > + > > +On x86, K

[Xen-devel] Xen Security Advisory 267 (CVE-2018-3665) - Speculative register leakage from lazy FPU context switching

2018-06-13 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Xen Security Advisory CVE-2018-3665 / XSA-267 version 3 Speculative register leakage from lazy FPU context switching UPDATES IN VERSION 3 Public release. ISSUE DESCRIPTION ==

Re: [Xen-devel] [PATCH 00/11] Add support for Hygon's Dhyana Family 18h processor

2018-06-13 Thread Borislav Petkov
On Sat, Jun 09, 2018 at 09:20:10PM +0800, Pu Wen wrote: > As a new x86 CPU Vendor, Chengdu Haiguang IC Design Co., Ltd (Hygon) > is a Joint Venture between AMD and Haiguang Information Technology Co., > Ltd., and aims at providing high performance x86 processor for China > server market. > > The f

Re: [Xen-devel] [PATCH v5 0/10] arm: more kconfig configurability and small default configs

2018-06-13 Thread Stefano Stabellini
On Wed, 13 Jun 2018, Jan Beulich wrote: > >>> On 12.06.18 at 21:53, wrote: > > On Tue, 12 Jun 2018, Jan Beulich wrote: > >> >> >> As a consequence of these changes, some options will become > >> >> >> user-visible > >> >> >> and not dependent on CONFIG_EXPERT. It does not mean that Xen Project >

[Xen-devel] [qemu-mainline test] 124152: regressions - FAIL

2018-06-13 Thread osstest service owner
flight 124152 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/124152/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 124093 test-amd64-i386-x

Re: [Xen-devel] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

2018-06-13 Thread Richard Henderson
On 06/13/2018 02:13 AM, Eric Blake wrote: > Or spell it UINT64_C(1) if you don't want a cast. Not unsigned is what I want most. r~ ___ Xen-devel mailing list Xen-devel@lists.xenproject.org https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [libvirt test] 124159: regressions - FAIL

2018-06-13 Thread osstest service owner
flight 124159 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/124159/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-buildfail REGR. vs. 123814 build-i386-libvirt

Re: [Xen-devel] [RFC PATCH 01/12] xen/manage: keep track of the on-going suspend mode

2018-06-13 Thread Balbir Singh
On Wed, Jun 13, 2018 at 6:56 AM, Anchal Agarwal wrote: > From: Munehisa Kamata > > To differentiate between Xen suspend, PM suspend and PM hibernation, > keep track of the on-going suspend mode by mainly using a new PM > notifier. Since Xen suspend doesn't have corresponding PM event, its > main

Re: [Xen-devel] [RFC PATCH 02/12] xen/manage: introduce helper function to know the on-going suspend mode

2018-06-13 Thread Balbir Singh
On Wed, Jun 13, 2018 at 6:56 AM, Anchal Agarwal wrote: > From: Munehisa Kamata > > Introduce simple functions which help to know the on-going suspend mode > so that other Xen-related code can behave differently according to the > current suspend mode. I'd squash this patch with the previous, the

[Xen-devel] [linux-linus test] 124151: regressions - FAIL

2018-06-13 Thread osstest service owner
flight 124151 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/124151/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-examine 8 reboot fail REGR. vs. 123554 test-armhf-armhf-xl

Re: [Xen-devel] How to deal with hypercalls returning -EFAULT

2018-06-13 Thread Andrew Cooper
On 13/06/18 16:27, Juergen Gross wrote: > Currently the release of Xen 4.11 is blocked due to a sporadic failure > of the OSSTEST guest-saverestore[.2]. During that test a hypercall > issued by libxc via the Linux privcmd driver returns -EFAULT in spite > of all hypercall buffers locked in memory v

Re: [Xen-devel] How to deal with hypercalls returning -EFAULT

2018-06-13 Thread Ian Jackson
Juergen Gross writes ("How to deal with hypercalls returning -EFAULT"): > 3. Modify the interface to the privcmd driver to pass information about >used buffers to the kernel in order to lock them there. Either add a >new interface for hypercall buffer management or add the list of >buff

Re: [Xen-devel] uapi header dependencies?

2018-06-13 Thread Jan Beulich
>>> On 13.06.18 at 17:03, wrote: > On 13/06/18 15:31, Jan Beulich wrote: >> Jürgen, Boris, >> >> aren't headers in uapi/ directories supposed to be self contained? > > Hmm, there are many uapi headers including stuff from outside uapi. > I guess it is okay to include headers which are accessible

[Xen-devel] How to deal with hypercalls returning -EFAULT

2018-06-13 Thread Juergen Gross
Currently the release of Xen 4.11 is blocked due to a sporadic failure of the OSSTEST guest-saverestore[.2]. During that test a hypercall issued by libxc via the Linux privcmd driver returns -EFAULT in spite of all hypercall buffers locked in memory via mlock() (or similar flags specified in a mmap

Re: [Xen-devel] uapi header dependencies?

2018-06-13 Thread Juergen Gross
On 13/06/18 15:31, Jan Beulich wrote: > Jürgen, Boris, > > aren't headers in uapi/ directories supposed to be self contained? Hmm, there are many uapi headers including stuff from outside uapi. I guess it is okay to include headers which are accessible in the kernel _and_ under /usr/include or to

Re: [Xen-devel] [OSSTEST PATCH] cr-daily-branch, cr-publish-flight-logs: Tolerate failure to push harness

2018-06-13 Thread Roger Pau Monné
On Wed, Jun 13, 2018 at 02:51:56PM +0100, Ian Jackson wrote: > Provide cr-publish-flight-logs --push-harness-try, which attempts the > push but doesn't mind if it fails. > > If we are not --real, tolerate failure to publish the flight logs. > > Also, honour OSSTEST_PUSH_HARNESS which might contai

[Xen-devel] [osstest] add FreeBSD flight

2018-06-13 Thread Roger Pau Monné
Hello, I've run a test flight of my FreeBSD osstest series today, the flight shows all green: http://logs.test-lab.xenproject.org/osstest/logs/124163/ The series can be found at: git://xenbits.xen.org/people/royger/osstest.git freebsd_v18 AFAICT it's fully Acked. I've rebased it on top of curr

[Xen-devel] [OSSTEST PATCH] cr-daily-branch, cr-publish-flight-logs: Tolerate failure to push harness

2018-06-13 Thread Ian Jackson
Provide cr-publish-flight-logs --push-harness-try, which attempts the push but doesn't mind if it fails. If we are not --real, tolerate failure to publish the flight logs. Also, honour OSSTEST_PUSH_HARNESS which might contain '' or --push-harness or --push-harness-try. CC: Roger Pau Monné Signe

[Xen-devel] uapi header dependencies?

2018-06-13 Thread Jan Beulich
Jürgen, Boris, aren't headers in uapi/ directories supposed to be self contained? The addition done by David in fbc872c38c clearly isn't, as there's no domid_t anywhere in other uapi/ headers afaict. No idea how to reasonably adjust this; I'd in particular dislike using __u16 there, but perhaps th

[Xen-devel] [OSSTEST PATCH 03/17] cs-bisection-step: Refactor $subjobs calculations a bit

2018-06-13 Thread Ian Jackson
Parse the runvar name earlier, adding job and orgflight members to the row hashes we got from the db. This slightly unifies the call to preparejob, but more relevantly, makes the effective job and flight information available earlier. That will be useful in a moment. No functional change. Signe

[Xen-devel] [OSSTEST PATCH 14/17] dm restrict audit: install newer chiark-scripts for fishdescriptor

2018-06-13 Thread Ian Jackson
fishdescriptor is not in stretch or earlier. It will be in buster, and we expect that a suitable version will be available in stretch-backports soon. For jessie, use DebianExtraPackages to install the .deb from buster (which is directly installable on jessie). Deployment note: I have already cop

[Xen-devel] [OSSTEST PATCH 15/17] dm restrict audit: Provide auditing script

2018-06-13 Thread Ian Jackson
ts-depriv-audit-qemu knows how to create a domain paused, and audit its fds. It uses * osstest-depriv-fd-collector, an on-test-host helper script * fishdescriptor, a new utility program in chiark-scripts * depriv-fd-checker, a new test program in xen.git Signed-off-by: Ian Jackson --- ove

[Xen-devel] [OSSTEST PATCH 13/17] toolstack: Provide guest_unpause

2018-06-13 Thread Ian Jackson
Only for xl (and xm) for now. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 7 +++ Osstest/Toolstack/xl.pm | 8 2 files changed, 15 insertions(+) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 2e0e892..0c57dd7 100644 --- a/Osstest/TestSupport.pm +++ b

[Xen-devel] [OSSTEST PATCH 10/17] make-flight: Add a single test with restricted dm

2018-06-13 Thread Ian Jackson
As of this commit, this test is only functional: we don't do any auditing yet. Right now save/restore migration is broken with restricted dm, so disable that test with the recipe flag. See sg-run-job: Allow flight to specify recipe flag to disable migr tests Run this only on recent enough Xen:

[Xen-devel] [OSSTEST PATCH 07/17] sg-run-job: Allow flight to specify recipe flag to disable migr tests

2018-06-13 Thread Ian Jackson
We want this because there is no sensible way to probe whether a restricted qemu can cope with save/restore or migration. So we will want to disable it in flight construction (depending on Xen version, eventually). Signed-off-by: Ian Jackson --- sg-run-job | 3 +++ 1 file changed, 3 insertions(

[Xen-devel] [OSSTEST PATCH 02/17] cs-bisection-step: Improve a message

2018-06-13 Thread Ian Jackson
Signed-off-by: Ian Jackson --- cs-bisection-step | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cs-bisection-step b/cs-bisection-step index 0be8bd0..0d0e08f 100755 --- a/cs-bisection-step +++ b/cs-bisection-step @@ -1208,7 +1208,7 @@ END if ($cache_option and $cacheok an

[Xen-devel] [OSSTEST PATCH 11/17] ts-xen-install: Honour DebianExtraPackages_

2018-06-13 Thread Ian Jackson
This allows us to specify some packages to install regardless of firmware and architecture. Signed-off-by: Ian Jackson --- README | 1 + ts-xen-install | 3 +++ 2 files changed, 4 insertions(+) diff --git a/README b/README index 2dfd4de..e938f64 100644 --- a/README +++ b/README @@ -537,

[Xen-devel] [OSSTEST PATCH 17/17] dm restrict audit: Document future plans

2018-06-13 Thread Ian Jackson
Signed-off-by: Ian Jackson --- ts-depriv-audit-qemu | 16 1 file changed, 16 insertions(+) diff --git a/ts-depriv-audit-qemu b/ts-depriv-audit-qemu index 2405b69..81bd5c0 100755 --- a/ts-depriv-audit-qemu +++ b/ts-depriv-audit-qemu @@ -56,6 +56,9 @@ END /usr/local/lib/x

[Xen-devel] [OSSTEST PATCH 04/17] cs-bisection-step: Handle build job chains

2018-06-13 Thread Ian Jackson
cs-bisection-step assumes that every job it will need to create has a unique name. Indeed, in general, it is probably not reasonable to expect it to work if that is not the case. build-amd64-freebsd needs a previous build-amd64-freebsd. Currently cs-bisection-step confuses itself into writing a

[Xen-devel] [OSSTEST PATCH 06/17] sg-run-job: Provide new recipe-flag facility

2018-06-13 Thread Ian Jackson
Individual recipes can now honour modifications requested by setting runvars like recipe_. No callers yet so no functional change. Signed-off-by: Ian Jackson --- sg-run-job | 7 +++ 1 file changed, 7 insertions(+) diff --git a/sg-run-job b/sg-run-job index 0a3f688..1355876 100755 --- a/sg-

[Xen-devel] [OSSTEST PATCH 01/17] db_retry: Honour new OSSTEST_DB_ALWAYS_ABORT variable

2018-06-13 Thread Ian Jackson
This is useful for debugging. Signed-off-by: Ian Jackson --- Osstest.pm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Osstest.pm b/Osstest.pm index 2263786..3377ea3 100644 --- a/Osstest.pm +++ b/Osstest.pm @@ -330,6 +330,8 @@ sub db_retry ($$$;$$) { last if $db_retry_stop

[Xen-devel] [OSSTEST PATCH 00/12] Run dm_restrict=1 tests, and audit the qemu

2018-06-13 Thread Ian Jackson
From: Ian Jackson This series adds tests with the xl/libxl dm_restrict=1 feature enabled (to tests of Xen 4.10 and later). Save/restore and migration is disabled in this tests for now, as that is broken in xen.git. This series also adds auditing of the deprivileged qemu's file descriptors. Tha

[Xen-devel] [OSSTEST PATCH 16/17] dm restrict audit: Run ts-depriv-audit-qemu

2018-06-13 Thread Ian Jackson
Add the new steps to jobs where the `recipe_dmrestrict' runvars is set, and set that flag on the relevant job. We introduce the new recipe-flag proc in sg-run-job to make this more convenient. Signed-off-by: Ian Jackson --- make-flight | 1 + sg-run-job | 8 2 files changed, 9 inserti

[Xen-devel] [OSSTEST PATCH 08/17] ts-xen-install: Create xen-qemuuser-range-base

2018-06-13 Thread Ian Jackson
It is fine to do in all jobs. libxl will only use this if we ask it to. We do need to check whether the user exists already, since adduser does not seem to have a mode which exits zero in that case. Signed-off-by: Ian Jackson --- ts-xen-install | 3 +++ 1 file changed, 3 insertions(+) diff --

[Xen-devel] [OSSTEST PATCH 12/17] toolstack: Provide guest_create_paused

2018-06-13 Thread Ian Jackson
Only for xl (and xm) for now. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 9 - Osstest/Toolstack/xl.pm | 14 +- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index c843902..2e0e892 100644 --- a/Os

[Xen-devel] [OSSTEST PATCH 05/17] cs-bisection-step: Do explicitly set runvar for suppressed recursion

2018-06-13 Thread Ian Jackson
When we detect that we are considering a job which is identically named to one earlier in the dependency chain, it could happen that the final referencing runvar in the job at which we break the cycle is actually to an unqualified job name. (This cannot happen unless the cycle has more than 2 jobs

[Xen-devel] [OSSTEST PATCH 09/17] more_prepareguest_hvm: Honour guest runvar dmrestrict

2018-06-13 Thread Ian Jackson
Currently nothing sets this. Signed-off-by: Ian Jackson --- Osstest/TestSupport.pm | 4 1 file changed, 4 insertions(+) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index d8ed02d..c843902 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -2066,6 +2066,10 @

Re: [Xen-devel] [PATCH] xen: don't use privcmd_call() from xen_mc_flush()

2018-06-13 Thread Jan Beulich
>>> On 13.06.18 at 13:12, wrote: > On 13/06/18 12:20, Jan Beulich wrote: > On 13.06.18 at 12:05, wrote: >> On 13.06.18 at 11:58, wrote: Using privcmd_call() for a singleton multicall seems to be wrong, as privcmd_call() is using stac()/clac() to enable hypervisor access to

Re: [Xen-devel] [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt"

2018-06-13 Thread Ian Jackson
Jiri Denemark writes ("Re: [libvirt] Likely build race, "/usr/bin/ld: cannot find -lvirt""): > On Tue, Jun 12, 2018 at 07:57:40 -0500, Eric Blake wrote: > > Can you add that line directly into Makefile.am, or does doing that > > cause automake to complain and/or omit its normal rules because it

Re: [Xen-devel] [xen-4.8-testing test] 124100: regressions - FAIL

2018-06-13 Thread Jan Beulich
>>> On 13.06.18 at 13:18, wrote: > Jan asked me to investigate why we weren't getting a push on Xen 4.8. > I investigated the failures in this osstest report. > > I think we have a combination of: > > * Flaky armhf hardware > > * A real Xen-related heisenbug bug (but which is not a regression

[Xen-devel] [xen-unstable test] 124140: regressions - FAIL

2018-06-13 Thread osstest service owner
flight 124140 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/124140/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt6 libvirt-buildfail REGR. vs. 124090 Regressions which

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Oleksandr Andrushchenko
On 06/13/2018 03:03 PM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:02 PM, Boris Ostrovsky wrote: On 06/13/2018 02:26 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko

Re: [Xen-devel] [Qemu-devel] [PATCH v4 11/40] hw/xen: Use the IEC binary prefix definitions

2018-06-13 Thread Eric Blake
On 06/12/2018 04:10 PM, Richard Henderson wrote: So there's tradeoffs either way, and you at least need to document in your commit messages what auditing you have done that any type changes introduced by your changes are safe. I'm more concerned about unnecessary or unintended signed vs unsigne

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Oleksandr Andrushchenko
On 06/13/2018 03:02 PM, Boris Ostrovsky wrote: On 06/13/2018 02:26 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include

Re: [Xen-devel] [PATCH v3 3/9] xen/balloon: Share common memory reservation routines

2018-06-13 Thread Boris Ostrovsky
On 06/13/2018 02:26 AM, Oleksandr Andrushchenko wrote: On 06/13/2018 03:47 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko diff --git a/include/xen/mem-reservation.h b/include/xen/mem-reservation.h new file mode 100644 ind

Re: [Xen-devel] [PATCH v3 8/9] xen/gntdev: Implement dma-buf export functionality

2018-06-13 Thread Oleksandr Andrushchenko
On 06/13/2018 05:58 AM, Boris Ostrovsky wrote: On 06/12/2018 09:41 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko 1. Create a dma-buf from grant references provided by the foreign     domain. By default dma-buf is backed by system memory pages, but     by providing GNTDEV_D

[Xen-devel] [linux-4.9 test] 124113: regressions - FAIL

2018-06-13 Thread osstest service owner
flight 124113 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/124113/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-debianhvm-amd64 7 xen-bootfail REGR. vs. 122969 test-amd64-amd64-xl-s

[Xen-devel] [PATCH v3 9/9] x86/vmx: Don't leak EFER.NXE into guest context

2018-06-13 Thread Andrew Cooper
Intel hardware only uses 4 bits in MSR_EFER. Changes to LME and LMA are handled automatically via the VMENTRY_CTLS.IA32E_MODE bit. SCE is handled by ad-hoc logic in context_switch(), vmx_restore_guest_msrs() and vmx_update_guest_efer(), and works by altering the host SCE value to match the settin

Re: [Xen-devel] [xen-4.8-testing test] 124100: regressions - FAIL

2018-06-13 Thread Ian Jackson
Jan asked me to investigate why we weren't getting a push on Xen 4.8. I investigated the failures in this osstest report. I think we have a combination of: * Flaky armhf hardware * A real Xen-related heisenbug bug (but which is not a regression) (the EFAULT libxc/linux bug; CC to Juergen)

Re: [Xen-devel] [PATCH] xen: don't use privcmd_call() from xen_mc_flush()

2018-06-13 Thread Juergen Gross
On 13/06/18 12:20, Jan Beulich wrote: On 13.06.18 at 12:05, wrote: > On 13.06.18 at 11:58, wrote: >>> Using privcmd_call() for a singleton multicall seems to be wrong, as >>> privcmd_call() is using stac()/clac() to enable hypervisor access to >>> Linux user space. >>> >>> Add a new xen_

Re: [Xen-devel] [PATCH v2 5/9] x86/vmx: Improvements to LBR MSR handling

2018-06-13 Thread Andrew Cooper
On 13/06/18 07:30, Jan Beulich wrote: On 12.06.18 at 18:33, wrote: >> On 12/06/18 10:00, Jan Beulich wrote: >> On 12.06.18 at 10:51, wrote: On 12/06/2018 09:15, Jan Beulich wrote: On 08.06.18 at 20:48, wrote: >> @@ -3106,14 +3104,13 @@ static int vmx_msr_write_intercep

Re: [Xen-devel] [PATCH] xen: don't use privcmd_call() from xen_mc_flush()

2018-06-13 Thread Jan Beulich
>>> On 13.06.18 at 12:05, wrote: On 13.06.18 at 11:58, wrote: >> Using privcmd_call() for a singleton multicall seems to be wrong, as >> privcmd_call() is using stac()/clac() to enable hypervisor access to >> Linux user space. >> >> Add a new xen_single_call() function to be use for that pu

Re: [Xen-devel] [PATCH v2 9/9] x86/vmx: Don't leak EFER.NXE into guest context

2018-06-13 Thread Andrew Cooper
On 12/06/18 09:54, Jan Beulich wrote: On 08.06.18 at 20:48, wrote: >> @@ -1646,22 +1637,71 @@ static void vmx_update_guest_cr(struct vcpu *v, >> unsigned int cr, >> >> static void vmx_update_guest_efer(struct vcpu *v) >> { >> -unsigned long vm_entry_value; >> +unsigned long entry

[Xen-devel] [xen-unstable-coverity test] 124166: all pass - PUSHED

2018-06-13 Thread osstest service owner
flight 124166 xen-unstable-coverity real [real] http://logs.test-lab.xenproject.org/osstest/logs/124166/ Perfect :-) All tests in this flight passed as required version targeted for testing: xen 41339ecb5f18ca7ec7b0c914c952a0e1715ae511 baseline version: xen 1153

Re: [Xen-devel] [PATCH] scsi: xen-scsifront: add error handling for xenbus_printf

2018-06-13 Thread Finn Thain
On Tue, 12 Jun 2018, Zhouyang Jia wrote: > When xenbus_printf fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling xenbus_printf. > > Signed-off-by: Zhouyang Jia > --- > drivers/scsi/xen-scsifront.c | 31 ++

Re: [Xen-devel] 4.11.0 RC1 panic

2018-06-13 Thread Manuel Bouyer
On Wed, Jun 13, 2018 at 03:59:19AM -0600, Jan Beulich wrote: > >>> On 13.06.18 at 10:57, wrote: > > On Wed, Jun 13, 2018 at 02:07:29AM -0600, Jan Beulich wrote: > >> > >> (XEN) Assertion '!page->linear_pt_count' failed at mm.c:596 > >> > >> In fact, there's no assertion with that expression anyw

Re: [Xen-devel] [PATCH] xen: don't use privcmd_call() from xen_mc_flush()

2018-06-13 Thread Jan Beulich
>>> On 13.06.18 at 11:58, wrote: > Using privcmd_call() for a singleton multicall seems to be wrong, as > privcmd_call() is using stac()/clac() to enable hypervisor access to > Linux user space. > > Add a new xen_single_call() function to be use for that purpose. > > Reported-by: Jan Beulich >

  1   2   >