Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 21:48, wrote: > You are right. We need to define a new struct for internal usage, for > example: > > struct xen_processor_performance_internal { > uint32_t flags; /* flag for Px sub info type */ > uint32_t platform_limit; /* Platform limitation on freq usage */ >

[Xen-devel] [RFC Patch v4 8/8] x86/hvm: bump the maximum number of vcpus to 512

2017-12-05 Thread Chao Gao
Signed-off-by: Chao Gao --- xen/include/public/hvm/hvm_info_table.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/public/hvm/hvm_info_table.h b/xen/include/public/hvm/hvm_info_table.h index 08c252e..6833a4c 100644 --- a/xen/include/public/hvm/hvm_info_table.h ++

[Xen-devel] [RFC Patch v4 6/8] hvmload: Add x2apic entry support in the MADT and SRAT build

2017-12-05 Thread Chao Gao
From: Lan Tianyu This patch contains the following changes: 1. add x2apic entry support for ACPI MADT table according to ACPI spec 5.2.12.12 Processor Local x2APIC Structure. 2. add x2apic entry support for ACPI SRAT table according to ACPI spec 5.2.16.3 Processor Local x2APIC Affinity Structur

[Xen-devel] [RFC Patch v4 4/8] hvmloader: boot cpu through broadcast

2017-12-05 Thread Chao Gao
Intel SDM Extended XAPIC (X2APIC) -> "Initialization by System Software" has the following description: "The ACPI interfaces for the x2APIC are described in Section 5.2, “ACPI System Description Tables,” of the Advanced Configuration and Power Interface Specification, Revision 4.0a (http://www.acp

[Xen-devel] [RFC Patch v4 5/8] Tool/ACPI: DSDT extension to support more vcpus

2017-12-05 Thread Chao Gao
From: Lan Tianyu This patch is to change DSDT table for processor object to support 4096 vcpus accroding to ACPI spec 8.4 Declaring Processors. This patch contains the two changes: 1. Declare processors whose local APIC is declared as a x2apic via the ASL Device statement 2. Bump up the size

[Xen-devel] [RFC Patch v4 1/8] ioreq: remove most 'buf' parameter from static functions

2017-12-05 Thread Chao Gao
It is a preparation to support multiple IOREQ pages. No functional change. Signed-off-by: Chao Gao --- v4: -new --- xen/arch/x86/hvm/ioreq.c | 48 +++- 1 file changed, 23 insertions(+), 25 deletions(-) diff --git a/xen/arch/x86/hvm/ioreq.c b/xen/arch

[Xen-devel] [RFC Patch v4 2/8] ioreq: bump the number of IOREQ page to 4 pages

2017-12-05 Thread Chao Gao
One 4K-byte page at most contains 128 'ioreq_t'. In order to remove the vcpu number constraint imposed by one IOREQ page, bump the number of IOREQ page to 4 pages. With this patch, multiple pages can be used as IOREQ page. Basically, this patch extends 'ioreq' field in struct hvm_ioreq_server to a

[Xen-devel] [RFC Patch v4 7/8] x86/hvm: bump the number of pages of shadow memory

2017-12-05 Thread Chao Gao
Each vcpu of hvm guest consumes at least one shadow page. Currently, only 256 (for hap case) pages are pre-allocated as shadow memory at beginning. It would run out if guest has more than 256 vcpus and guest creation fails. Bump the number of shadow pages to 2 * HVM_MAX_VCPUS for hap case and 8 * H

[Xen-devel] [RFC Patch v4 3/8] xl/acpi: unify the computation of lapic_id

2017-12-05 Thread Chao Gao
There were two places where the lapic_id is computed, one in hvmloader and one in libacpi. Unify them by defining LAPIC_ID in a header file and incluing it in both places. To address compilation issue and make libacpi.h self-contained, include stdint.h in libacpi.h. Signed-off-by: Chao Gao --- v

[Xen-devel] [RFC Patch v4 0/8] Extend resources to support more vcpus in single VM

2017-12-05 Thread Chao Gao
This series is based on Paul Durrant's "x86: guest resource mapping" (https://lists.xenproject.org/archives/html/xen-devel/2017-11/msg01735.html) and "add vIOMMU support with irq remapping function of virtual VT-d" (https://lists.xenproject.org/archives/html/xen-devel/2017-11/msg01063.html).

[Xen-devel] [PATCH XTF] build with -Os

2017-12-05 Thread Jan Beulich
This helps limit the number of function instances created, commonly allowing the exact same code to be used in dual non-FEP/FEP tests. This is particularly helpful when certain exceptions are expected to be raised: We prefer for results to not differ between the two halves of such tests, while depe

Re: [Xen-devel] Ping#3: [PATCH v3] x86/HVM: don't #GP/#SS on wrapping virt->linear translations

2017-12-05 Thread Jan Beulich
>>> On 04.12.17 at 17:39, wrote: > On 04/12/17 10:16, Jan Beulich wrote: > On 25.08.17 at 16:59, wrote: >> On 10.08.17 at 09:19, wrote: >>> On 10.07.17 at 12:39, wrote: > Real hardware wraps silently in most cases, so we should behave the > same. Also split real and VM86 mod

[Xen-devel] [PATCH] xen-netback: Fix logging message with spurious period after newline

2017-12-05 Thread Joe Perches
Using a period after a newline causes bad output. Signed-off-by: Joe Perches --- drivers/net/xen-netback/interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c index d6dff347f896..78ebe494fef0 100

[Xen-devel] [qemu-mainline test] 116868: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116868 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/116868/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 116683 Tests whic

[Xen-devel] [linux-linus bisection] complete test-amd64-i386-xl-raw

2017-12-05 Thread osstest service owner
branch xen-unstable xenbranch xen-unstable job test-amd64-i386-xl-raw testid xen-boot Tree: linux git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree

[Xen-devel] [xen-unstable baseline-only test] 72519: regressions - FAIL

2017-12-05 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 72519 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/72519/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 15 guest-start/deb

Re: [Xen-devel] [PATCH for-next 10/16] xen/arm: domain_build: Use copy_to_guest_phys_flush_dcache in dtb_load

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The function dtb_load is dealing with IPA but uses gvirt_to_maddr to do > the translation. This is currently working fine because the stage-1 MMU > is disabled. > > Rather than relying on such assumption, use the new > copy_to_guest_phys_flush_dcache. Thi

Re: [Xen-devel] [PATCH for-next 09/16] xen/arm: domain_build: Rework initrd_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The function initrd_load is dealing with IPA but uses gvirt_to_maddr to > do the translation. This is currently working fine because the stage-1 MMU > is disabled. > > Furthermore, the function is implementing its own copy to guest resulting > in code dup

Re: [Xen-devel] [PATCH for-next 08/16] xen/arm: kernel: Rework kernel_zimage_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Stefano Stabellini wrote: > On Thu, 23 Nov 2017, Julien Grall wrote: > > The function kernel_zimage is dealing with IPA but uses gvirt_to_maddr to > > do the translation. This is currently working fine because the stage-1 MMU > > is disabled. > > > > Furthermore, the function i

Re: [Xen-devel] [PATCH for-next 08/16] xen/arm: kernel: Rework kernel_zimage_load to use the generic copy helper

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The function kernel_zimage is dealing with IPA but uses gvirt_to_maddr to > do the translation. This is currently working fine because the stage-1 MMU > is disabled. > > Furthermore, the function is implementing its own copy to guest resulting > in code d

Re: [Xen-devel] [PATCH for-next 07/16] xen/arm: Introduce copy_to_guest_phys_flush_dcache

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > Hi Andrew, > > On 23/11/17 18:49, Andrew Cooper wrote: > > On 23/11/17 18:32, Julien Grall wrote: > > > This new function will be used in a follow-up patch to copy data to the > > > guest > > > using the IPA (aka guest physical address) and then clean the

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Stefano Stabellini wrote: > On Thu, 23 Nov 2017, Julien Grall wrote: > > The only differences between copy_to_guest and access_guest_memory_by_ipa > > are: > > - The latter does not support copying data crossing page boundary > > - The former is copying from/to guest VA

Re: [Xen-devel] [PATCH for-next 06/16] xen/arm: Extend copy_to_guest to support copying from/to guest physical address

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The only differences between copy_to_guest and access_guest_memory_by_ipa are: > - The latter does not support copying data crossing page boundary > - The former is copying from/to guest VA whilst the latter from > guest PA > > copy_to_guest c

[Xen-devel] [linux-4.9 test] 116861: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116861 linux-4.9 real [real] http://logs.test-lab.xenproject.org/osstest/logs/116861/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 16 guest-localmigrate/x10 fail REGR. vs. 116754 test-amd64-amd

Re: [Xen-devel] [PATCH for-next 05/16] xen/arm: guest_copy: Extend the prototype to pass the vCPU

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > Currently, guest_copy assumes the copy will only be done for the current > vCPU. A follow-up patch will require to use a different vCPU. > > So extend the prototype to pass the vCPU. > > Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini >

Re: [Xen-devel] [PATCH for-next 04/16] xen/arm: Extend copy_to_guest to support zeroing guest VA and use it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The function copy_to_guest can easily be extended to support zeroing > guest VA. To avoid using a new bit, it is considered that a NULL buffer > (i.e buf == NULL) means the guest memory will be zeroed. > > Lastly, reimplement raw_clear_guest using copy_to

Re: [Xen-devel] [PATCH for-next 03/16] xen/arm: Extend copy_to_guest to support copying from guest VA and use it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > The only differences between copy_to_guest (formerly called > raw_copy_to_guest_helper) and raw_copy_from_guest is: > - The direction of the memcpy > - The permission use for translating the address > > Extend copy_to_guest to support copying from

Re: [Xen-devel] [PATCH for-next 02/16] xen/arm: raw_copy_to_guest_helper: Rework the prototype and rename it

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > All the helpers within arch/arm/guestcopy.c are doing the same things: > copy data from/to the guest. > > At the moment, the logic is duplicated in each helpers making more > difficult to implement new variant. > > The first step for the consolidation is

Re: [Xen-devel] [PATCH for-next 01/16] xen/arm: raw_copy_to_guest_helper: Rename flush_dcache to flags

2017-12-05 Thread Stefano Stabellini
On Thu, 23 Nov 2017, Julien Grall wrote: > In a follow-up patch, it will be necessary to pass more flags to the > function. > > Rename flush_dcache to flags and introduce a define to tell whether the > cache needs to be flushed after the copy. > > Signed-off-by: Julien Grall Reviewed-by: Stefan

[Xen-devel] [xen-unstable test] 116857: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116857 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/116857/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-win7-amd64 10 windows-install fail REGR. vs. 116744 Tests which are fa

[Xen-devel] [linux-3.18 test] 116862: regressions - trouble: blocked/broken/fail/pass

2017-12-05 Thread osstest service owner
flight 116862 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/116862/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-xsm broken build-armhf-xsm 5 host-build-

Re: [Xen-devel] [RFC v3 4/4] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-12-05 Thread Goel, Sameer
On 12/5/2017 7:17 AM, Julien Grall wrote: > Hello, > > On 05/12/17 03:59, Sameer Goel wrote: >> This driver follows an approach similar to smmu driver. The intent here >> is to reuse as much Linux code as possible. >> - Glue code has been introduced in headers to bridge the API calls. >> - Calle

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Julien Grall
On 05/12/2017 22:35, Stefano Stabellini wrote: On Tue, 5 Dec 2017, Julien Grall wrote: Hi all, Even though it is an Arm failure, I have CCed x86 folks to get feedback on the approach. I have a WIP branch I could share if that interest people. Few months ago, we noticed an heisenbug on jobs r

Re: [Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi all, > > Even though it is an Arm failure, I have CCed x86 folks to get feedback on the > approach. I have a WIP branch I could share if that interest people. > > Few months ago, we noticed an heisenbug on jobs run by osstest on the > cubietrucks (see

Re: [Xen-devel] [RFC PATCH 00/31] CPUFreq on ARM

2017-12-05 Thread Stefano Stabellini
Hi Oleksandr, I just wanted to tell you that the patch series is very well organized and the patches very nicely split. Thank you! - Stefano On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Hi, all. > > The purpose of this RFC patch series is to add CPUFreq s

Re: [Xen-devel] [RFC PATCH 29/31] xen/arm: Introduce CPUFreq Interface component

2017-12-05 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch adds an interface component which performs following steps: > 1. Initialize everything needed SCPI based CPUFreq driver to be functional >(SCPI Message protocol, mailbox to communicate with SCP, etc).

Re: [Xen-devel] [RFC PATCH 22/31] xen/arm: Add Xen changes to SCPI protocol

2017-12-05 Thread Julien Grall
On 05/12/2017 21:20, Stefano Stabellini wrote: On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: From: Oleksandr Tyshchenko Modify the direct ported SCPI Message Protocol driver to be functional inside Xen. As SCPI Message protocol driver expects mailbox to be registed, find and initialize ma

Re: [Xen-devel] [RFC PATCH 27/31] cpufreq: hack: perf->states isn't a real guest handle on ARM

2017-12-05 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch is just a temp solution to highlight a problem which > should be resolved in a proper way. > > set_px_pminfo() is intended to be called from platform hypercall > where "perf" argument was entirely filled

Re: [Xen-devel] [RFC PATCH 22/31] xen/arm: Add Xen changes to SCPI protocol

2017-12-05 Thread Stefano Stabellini
On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Modify the direct ported SCPI Message Protocol driver to be > functional inside Xen. > > As SCPI Message protocol driver expects mailbox to be registed, > find and initialize mailbox before probing it. > > Include

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Oleksandr Tyshchenko wrote: > Hi Stefano > > On Tue, Dec 5, 2017 at 12:46 AM, Stefano Stabellini > wrote: > > On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: > >> Hi, Stefano > >> > >> On Sat, Dec 2, 2017 at 3:37 AM, Stefano Stabellini > >> wrote: > >> > On Thu, 9 Nov 2017, O

Re: [Xen-devel] [RFC PATCH 06/31] cpufreq: make cpufreq driver more generalizable

2017-12-05 Thread Oleksandr Tyshchenko
Hi Stefano On Tue, Dec 5, 2017 at 12:46 AM, Stefano Stabellini wrote: > On Mon, 4 Dec 2017, Oleksandr Tyshchenko wrote: >> Hi, Stefano >> >> On Sat, Dec 2, 2017 at 3:37 AM, Stefano Stabellini >> wrote: >> > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: >> >> From: Oleksandr Dmytryshyn >> >> >

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Oleksandr Tyshchenko wrote: > >> Another question is second_max_freq. As I understand, it is highest > >> non-turbo frequency calculated by framework to limit target frequency > >> when > >> turbo mode "is disabled". And Xen assumes that second_max_freq is > >> always P1 if turb

[Xen-devel] [xen-unstable-smoke test] 116877: tolerable all pass - PUSHED

2017-12-05 Thread osstest service owner
flight 116877 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/116877/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 13 migrate-support-checkfail never pass test-armhf-armhf-xl 1

[Xen-devel] [OSSTEST PATCH] Revert "make-flight etc.: drop arm64"

2017-12-05 Thread Ian Jackson
We have the laxtons back and they seem to be working. This reverts commit 329ef52c9866b2a8608a598836b7d5813de1e979. Signed-off-by: Ian Jackson --- make-flight | 2 +- make-hosts-flight | 2 +- mfi-common| 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/mak

Re: [Xen-devel] [OSSTEST PATCH] Revert "make-flight etc.: drop arm64"

2017-12-05 Thread Julien Grall
On 05/12/17 18:59, Ian Jackson wrote: We have the laxtons back and they seem to be working. Finally! This reverts commit 329ef52c9866b2a8608a598836b7d5813de1e979. > Signed-off-by: Ian Jackson FWIW: Acked-by: Julien Grall Cheers, --- make-flight | 2 +- make-hosts-flight |

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Julien Grall
Hi Ian, On 05/12/17 18:41, Ian Jackson wrote: Stefano Stabellini writes ("Re: [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree"): On Tue, 5 Dec 2017, Julien Grall wrote: Acked-by: Julien Grall Acked-by: Stefano Stabellini Thanks. This queued for my next osstest

Re: [Xen-devel] [PATCH 1/2] gnttab: correct GNTTABOP_cache_flush empty batch handling

2017-12-05 Thread Stefano Stabellini
On Mon, 4 Dec 2017, Jan Beulich wrote: > >>> On 01.12.17 at 22:38, wrote: > > On Thu, 30 Nov 2017, Jan Beulich wrote: > >> Jann validly points out that with a caller bogusly requesting a zero- > >> element batch with non-zero high command bits (the ones used for > >> continuation encoding), the as

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Ian Jackson
Stefano Stabellini writes ("Re: [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree"): > On Tue, 5 Dec 2017, Julien Grall wrote: > > Acked-by: Julien Grall > > Acked-by: Stefano Stabellini Thanks. This queued for my next osstest push, which I expect to do some time tomor

[Xen-devel] [RFC] xen/arm: Handling cache maintenance instructions by set/way

2017-12-05 Thread Julien Grall
Hi all, Even though it is an Arm failure, I have CCed x86 folks to get feedback on the approach. I have a WIP branch I could share if that interest people. Few months ago, we noticed an heisenbug on jobs run by osstest on the cubietrucks (see [1]). From the log, we figured out that the guest

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Julien Grall wrote: > Hi Ian, > > On 05/12/17 18:28, Ian Jackson wrote: > > This drops the dependency on Stefano's personal git tree. > > The osstest output branch remains unmoved. > > > > CC: Stefano Stabellini > > CC: Julien Grall > > Signed-off-by: Ian Jackson > > Acked

Re: [Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Julien Grall
Hi Ian, On 05/12/17 18:28, Ian Jackson wrote: This drops the dependency on Stefano's personal git tree. The osstest output branch remains unmoved. CC: Stefano Stabellini CC: Julien Grall Signed-off-by: Ian Jackson Acked-by: Julien Grall Cheers, --- ap-common | 4 ++-- 1 file changed

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Dan Carpenter wrote: > bedata->ref can't be less than zero because it's unsigned. This affects > certain error paths in probe. We first set ->ref = -1 and then we set > it to a valid value later. > > Fixes: 219681909913 ("xen/pvcalls: connect to the backend") > Signed-off-by:

[Xen-devel] [OSSTEST PATCH] linux-arm-xen: Get from shared arm/linux.git xenbits tree

2017-12-05 Thread Ian Jackson
This drops the dependency on Stefano's personal git tree. The osstest output branch remains unmoved. CC: Stefano Stabellini CC: Julien Grall Signed-off-by: Ian Jackson --- ap-common | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ap-common b/ap-common index bc7c03c..457

Re: [Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Dan Carpenter wrote: > Smatch complains that "len" is uninitialized if xenbus_read() fails so > let's add some error handling. > > Signed-off-by: Dan Carpenter Reviewed-by: Stefano Stabellini > diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c > index

[Xen-devel] [seabios test] 116858: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116858 seabios real [real] http://logs.test-lab.xenproject.org/osstest/logs/116858/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ws16-amd64 17 guest-stop fail REGR. vs. 115539 Tests which did not suc

Re: [Xen-devel] linux-arm-xen branch, commit access, etc.

2017-12-05 Thread Julien Grall
Hi Ian, On 05/12/17 17:42, Ian Jackson wrote: Stefano Stabellini writes ("Re: [Xen-devel] linux-arm-xen branch, commit access, etc."): let's create a /arm/linux.git tree on xenbits where both Julien and I can push. The idea is that we'll try to use vanilla kernel releases but we'll keep it aro

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Ian Jackson
Roger Pau Monné writes ("Re: [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets"): > On Tue, Dec 05, 2017 at 03:09:47PM +, Ian Jackson wrote: > > Is that why you're not just updating osstest to expect the new > > behaviour ? > > Yes, I think it's more sensible to r

Re: [Xen-devel] linux-arm-xen branch, commit access, etc.

2017-12-05 Thread Ian Jackson
Stefano Stabellini writes ("Re: [Xen-devel] linux-arm-xen branch, commit access, etc."): > let's create a /arm/linux.git tree on xenbits where both Julien and I > can push. The idea is that we'll try to use vanilla kernel releases but > we'll keep it around just in case we'll need special patches

Re: [Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 17:19 > To: Paul Durrant > Cc: Julien Grall ; Andrew Cooper > ; xen-devel de...@lists.xenproject.org> > Subject: RE: [PATCH] x86/HVM: don't retain emulated insn cache when > exiting back to guest

[Xen-devel] [OSSTEST PATCH] sg-report-host-history: make link to host examination results

2017-12-05 Thread Ian Jackson
Signed-off-by: Ian Jackson --- sg-report-host-history | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sg-report-host-history b/sg-report-host-history index e86e03b..19a86ab 100755 --- a/sg-report-host-history +++ b/sg-report-host-history @@ -149,6 +149,8 @@ sub reporthost ($) { $title=

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Stefano Stabellini
On Tue, 5 Dec 2017, Volodymyr Babchuk wrote: > Hi Stefano, > > On Mon, Dec 04, 2017 at 06:30:13PM -0800, Stefano Stabellini wrote: > > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > > > From: Volodymyr Babchuk > > > > > > Existing SMC wrapper call_smc() allows only 4 parameters and > > > retu

Re: [Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 17:44, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 05 December 2017 16:14 >> --- a/xen/arch/x86/hvm/emulate.c >> +++ b/xen/arch/x86/hvm/emulate.c >> @@ -2109,20 +2109,22 @@ static int _hvm_emulate_one(struct hvm_e >> >> vio->mmio_retry = 0; >> >> -

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Oleksandr Tyshchenko
On Tue, Dec 5, 2017 at 7:08 PM, Volodymyr Babchuk wrote: > Hi Julien, Hi Julien, Volodymyr. > > On 05.12.17 16:58, Julien Grall wrote: >> >> Hi Oleksandr, >> >> On 09/11/17 17:10, Oleksandr Tyshchenko wrote: >>> >>> From: Volodymyr Babchuk >>> >>> Existing SMC wrapper call_smc() allows only 4 pa

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Julien Grall
On 05/12/17 17:08, Volodymyr Babchuk wrote: Hi Julien, On 05.12.17 16:58, Julien Grall wrote: Hi Oleksandr, On 09/11/17 17:10, Oleksandr Tyshchenko wrote: From: Volodymyr Babchuk Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existi

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Volodymyr Babchuk
Hi Julien, On 05.12.17 16:58, Julien Grall wrote: Hi Oleksandr, On 09/11/17 17:10, Oleksandr Tyshchenko wrote: From: Volodymyr Babchuk Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existing use in PSCI code, but TEE mediator will need

Re: [Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 16:14 > To: xen-devel > Cc: Julien Grall ; Andrew Cooper > ; Paul Durrant > Subject: [PATCH] x86/HVM: don't retain emulated insn cache when exiting > back to guest > > vio->mmio_retry is being se

[Xen-devel] [linux-linus test] 116840: regressions - FAIL

2017-12-05 Thread osstest service owner
flight 116840 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/116840/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 7 xen-boot fail REGR. vs. 115643 test-amd64-am

Re: [Xen-devel] [RFC PATCH v4] xen: credit2: provide custom option to create runqueue

2017-12-05 Thread Praveen Kumar
On Tue, Sep 5, 2017 at 11:26 PM, Dario Faggioli wrote: > On Fri, 2017-06-09 at 18:41 +0200, Dario Faggioli wrote: >> Hey Praveen, >> > Hey, hello again! > >> Here we are, sorry for the delay. >> > So, about this patch... I haven't seen a new version (or did I perhaps > miss it?). > > I'm asking be

Re: [Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Juergen Gross
On 05/12/17 15:38, Dan Carpenter wrote: > Smatch complains that "len" is uninitialized if xenbus_read() fails so > let's add some error handling. > > Signed-off-by: Dan Carpenter Reviewed-by: Juergen Gross Juergen ___ Xen-devel mailing list Xen-dev

Re: [Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Juergen Gross
On 05/12/17 15:38, Dan Carpenter wrote: > bedata->ref can't be less than zero because it's unsigned. This affects > certain error paths in probe. We first set ->ref = -1 and then we set > it to a valid value later. > > Fixes: 219681909913 ("xen/pvcalls: connect to the backend") > Signed-off-by:

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Roger Pau Monné
On Tue, Dec 05, 2017 at 03:09:47PM +, Ian Jackson wrote: > Roger Pau Monne writes ("[PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ > with FreeBSD release targets"): > > Due to a recent FreeBSD change the default output directory of the release > > targets is changed to the object directory

Re: [Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-05 Thread Juergen Gross
On 05/12/17 16:23, Julien Grall wrote: > Hi Juergen, > > On 04/12/17 15:49, Juergen Gross wrote: >> On 21/11/17 12:06, Juergen Gross wrote: >>> The "special pages" for PVH guests include the frames for console and >>> Xenstore ring buffers. Those have to be marked as "Reserved" in the >>> guest's

Re: [Xen-devel] [PATCH v6 00/16] xen: common: rbtree: ported updates from Linux tree

2017-12-05 Thread Praveen Kumar
Hi All, Can you please provide your comments over the changes shared. Thanks in advance. Regards, ~Praveen. On Tue, Nov 21, 2017 at 8:49 PM, Praveen Kumar wrote: > Hi All, > > The patch imports the changes and updates of the rbtree implementaiton > from Linux tree. But since, the only current

[Xen-devel] [PATCH] x86/HVM: don't retain emulated insn cache when exiting back to guest

2017-12-05 Thread Jan Beulich
vio->mmio_retry is being set when a repeated string insn is being split up. In that case we'll exit to the guest, expecting immediate re-entry. Interruptions, however, may be serviced by the guest before re-entry from the repeated string insn. Any emulation needed in the course of handling the inte

Re: [Xen-devel] [RFC] WIP: optee: add OP-TEE mediator

2017-12-05 Thread Stuart Yoder
There are limit on pCPUs, though. But this is not a problem, because XEN scheduler will decide which guest will access OP-TEE right now. OP-TEE don't have own scheduler at all, by the way. It is scheduled by normal world. Do you mind to give a bit more explanation here? Do you plan to add know

[Xen-devel] [OSSTEST PATCH] README.dev: Say how to do a commissioning flight for a new architecture

2017-12-05 Thread Ian Jackson
Signed-off-by: Ian Jackson --- README.dev | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.dev b/README.dev index dc0dafd..37e2953 100644 --- a/README.dev +++ b/README.dev @@ -132,6 +132,13 @@ If that works, a more thorough test: This should show no regressions. (Or, at least,

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Andrew Cooper
On 05/12/17 15:31, Jan Beulich wrote: On 05.12.17 at 16:05, wrote: >> Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions >> - >> FAIL"): >>> This is a blue screen, recurring, and has first been reported in flight >>> 116779, i.e. was likely introduced in the batch

Re: [Xen-devel] linux-arm-xen branch, commit access, etc.

2017-12-05 Thread Julien Grall
Hi, Ping? This is going to be very helpful for bringing up osstest on Thunder-X. Cheers, On 02/11/17 13:34, Julien Grall wrote: Hi, On 23/10/17 22:33, Stefano Stabellini wrote: On Fri, 20 Oct 2017, Julien Grall wrote:    Julien, do you think we need to keep a special linux tree around f

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]"): > Oh, that's pretty unfortunate. I think we'll then need a custom flight > tied to the box that this failure occurred on, to have a way to tell > whether the fix I'm about to prepare has ac

[Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-05 Thread Ian Jackson
Julien Grall writes ("[for-4.10] Re: [Xen-devel] [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH"): > I would recommend to tag your patch is 4.10 to help reviewers prioritize > review on your patch. I have done it now. Thanks. Looking at the thread, I would have liked

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Volodymyr Babchuk
Hi Stefano, On Mon, Dec 04, 2017 at 06:30:13PM -0800, Stefano Stabellini wrote: > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: > > From: Volodymyr Babchuk > > > > Existing SMC wrapper call_smc() allows only 4 parameters and > > returns only one value. This is enough for existing > > use in PS

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 16:05, wrote: > Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions > - > FAIL"): >> This is a blue screen, recurring, and has first been reported in flight >> 116779, i.e. was likely introduced in the batch ending in commit >> 4cd0fad645. Among those

Re: [Xen-devel] [RFC PATCH 04/31] cpufreq: make turbo settings to be configurable

2017-12-05 Thread Oleksandr Tyshchenko
On Mon, Dec 4, 2017 at 1:58 PM, Andre Przywara wrote: > Hi, Hi Andre > > > >> And the most important question is how to recognize in Xen on ARM >> (using SCPI protocol) which frequencies are turbo-frequencies >> actually? I couldn't find any information regarding that in protocol >> descript

[Xen-devel] [for-4.10] Re: [PATCH v2] tools/libxl: mark special pages as reserved in e820 map for PVH

2017-12-05 Thread Julien Grall
Hi Juergen, On 04/12/17 15:49, Juergen Gross wrote: On 21/11/17 12:06, Juergen Gross wrote: The "special pages" for PVH guests include the frames for console and Xenstore ring buffers. Those have to be marked as "Reserved" in the guest's E820 map, as otherwise conflicts might arise later e.g. w

Re: [Xen-devel] [PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets

2017-12-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v17 19/19] osstest: use -DWITHOUT_AUTO_OBJ with FreeBSD release targets"): > Due to a recent FreeBSD change the default output directory of the release > targets is changed to the object directory instead of the source > directory. Use WITHOUT_AUTO_OBJ to restore pr

Re: [Xen-devel] [PATCH v17 17/19] osstest: remove the loader timeout from the install image

2017-12-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v17 17/19] osstest: remove the loader timeout from the install image"): > When the FreeBSD installer is booted on the godello{0/1} boxes it > receives spurious key strokes. This doesn't happen so far when booted > from disk, or with any other boxes. > > In order to

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL [and 1 more messages]

2017-12-05 Thread Ian Jackson
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL"): > This is a blue screen, recurring, and has first been reported in flight > 116779, i.e. was likely introduced in the batch ending in commit > 4cd0fad645. Among those the most likely candidates appear to be > th

Re: [Xen-devel] [PATCH v17 18/19] osstest: expand the list of tested disk controllers

2017-12-05 Thread Ian Jackson
Roger Pau Monne writes ("[PATCH v17 18/19] osstest: expand the list of tested disk controllers"): > The Mass osstest instance has a more diverse list of hardware disk > controllers, so expand the list in order to include all the possible > disk drivers. Acked-by: Ian Jackson On the same basis a

Re: [Xen-devel] [RFC PATCH 16/31] arm: add SMC wrapper that is compatible with SMCCC

2017-12-05 Thread Julien Grall
Hi Oleksandr, On 09/11/17 17:10, Oleksandr Tyshchenko wrote: From: Volodymyr Babchuk Existing SMC wrapper call_smc() allows only 4 parameters and returns only one value. This is enough for existing use in PSCI code, but TEE mediator will need a call that is fully compatible with ARM SMCCC. Thi

Re: [Xen-devel] [xen-unstable test] 116832: regressions - FAIL

2017-12-05 Thread Ian Jackson
osstest service owner writes ("[xen-unstable test] 116832: regressions - FAIL"): > flight 116832 xen-unstable real [real] > http://logs.test-lab.xenproject.org/osstest/logs/116832/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > t

[Xen-devel] [PATCH 2/2] xen/pvcalls: Fix a check in pvcalls_front_remove()

2017-12-05 Thread Dan Carpenter
bedata->ref can't be less than zero because it's unsigned. This affects certain error paths in probe. We first set ->ref = -1 and then we set it to a valid value later. Fixes: 219681909913 ("xen/pvcalls: connect to the backend") Signed-off-by: Dan Carpenter diff --git a/drivers/xen/pvcalls-fro

[Xen-devel] [PATCH] xen/pvcalls: check for xenbus_read() errors

2017-12-05 Thread Dan Carpenter
Smatch complains that "len" is uninitialized if xenbus_read() fails so let's add some error handling. Signed-off-by: Dan Carpenter diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index 40caa92bff33..afa3f1b5d807 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pv

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 14:32 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org > Subject: RE: [PATCH v2] x86/hvm: fix interaction between internal and > external emulation > > >>> On 05.12.17 at 15:00, wrote: > >

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 15:11, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf >> Of Paul Durrant >> Sent: 05 December 2017 14:00 >> To: 'Jan Beulich' >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: 05 December 2017 13:53 >> > >>> On 28.11.17 at 15:05,

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Jan Beulich
>>> On 05.12.17 at 15:00, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: 05 December 2017 13:53 >> >>> On 28.11.17 at 15:05, wrote: >> rc = x86_emulate(&hvmemul_ctxt->ctxt, ops); >> >> if ( rc != X86EMUL_RETRY ) >> { >> vio->mmio_cache_count = 0; >> v

Re: [Xen-devel] [RFC PATCH 09/31] xen/device-tree: Add dt_property_for_each_string macros

2017-12-05 Thread Oleksandr Tyshchenko
Hi, Stefano On Tue, Dec 5, 2017 at 1:24 AM, Stefano Stabellini wrote: > On Thu, 9 Nov 2017, Oleksandr Tyshchenko wrote: >> From: Oleksandr Tyshchenko >> >> This is a port from Linux. > > When you port stuff from Linux you have to retain the original > copyright. Please add the original Signed-of

Re: [Xen-devel] [RFC v3 4/4] xen/iommu: smmu-v3: Add Xen specific code to enable the ported driver

2017-12-05 Thread Julien Grall
Hello, On 05/12/17 03:59, Sameer Goel wrote: This driver follows an approach similar to smmu driver. The intent here is to reuse as much Linux code as possible. - Glue code has been introduced in headers to bridge the API calls. - Called Linux functions from the Xen IOMMU function calls. - Xen m

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Paul Durrant > Sent: 05 December 2017 14:00 > To: 'Jan Beulich' > Cc: xen-devel@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between > internal and e

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 05 December 2017 13:53 > To: Paul Durrant > Cc: xen-devel@lists.xenproject.org > Subject: Re: [PATCH v2] x86/hvm: fix interaction between internal and > external emulation > > >>> On 28.11.17 at 15:05, wrote: > >

Re: [Xen-devel] [PATCH v2] x86/hvm: fix interaction between internal and external emulation

2017-12-05 Thread Jan Beulich
>>> On 28.11.17 at 15:05, wrote: > --- a/xen/arch/x86/hvm/io.c > +++ b/xen/arch/x86/hvm/io.c > @@ -88,7 +88,7 @@ bool hvm_emulate_one_insn(hvm_emulate_validate_t *validate, > const char *descr) > > rc = hvm_emulate_one(&ctxt); > > -if ( hvm_vcpu_io_need_completion(vio) || vio->mmio_r

  1   2   >