[Xen-devel] [RFC] x86/boot: Don't use BDA value if it's suspiciously small

2016-08-26 Thread Sylvain Munaut
If we have an multiboot value and the value we got from the BDA seems too small, use the safe one Signed-off-by: Sylvain Munaut --- I need this when using linux-as-a-bootloader (i.e. kexec into Xen) because the BDA is just zero at that point (not entirely sure why tbh). This is the simplest

[Xen-devel] IOMMU initialization failure when using linux-as-bootloader

2016-08-26 Thread Sylvain Munaut
2ZvPx If you need more info, please ask, I can test or post more details if needed. Cheers, Sylvain Munaut (XEN) Xen version 4.7.0 (whate...@dev.office.whatever-company.com) (gcc (Debian 4.9.2-10) 4.9.2) debug=n Fri Aug 26 09:07:38 UTC 2016 (XEN) Latest ChangeSet: (XEN) Bootloader: kex

Re: [Xen-devel] [RFC] x86/boot: Don't use BDA value if it's suspiciously small

2016-08-26 Thread Sylvain Munaut
Hi, On Fri, Aug 26, 2016 at 3:06 PM, Jan Beulich wrote: On 26.08.16 at 11:09, wrote: >> --- a/xen/arch/x86/boot/head.S >> +++ b/xen/arch/x86/boot/head.S >> @@ -108,6 +108,8 @@ __start: >> shl $10-4,%edx >> cmp %eax,%edx /* compare with BDA value */ >>

Re: [Xen-devel] [RFC] x86/boot: Don't use BDA value if it's suspiciously small

2016-08-26 Thread Sylvain Munaut
print_err("No low memory available") (in pseudo code, didn't really want to code it in assembly if it's not acceptable :p) If that looks ok, I can write and test a patch implementing that. Cheers, Sylvain Munaut _

Re: [Xen-devel] [RFC] x86/boot: Don't use BDA value if it's suspiciously small

2016-08-26 Thread Sylvain Munaut
> I'm not sure. I'd like to see the current logic altered as little as > possible, and what you suggest above is more than that minimum. Then, that would be more like the very first patch I posted but just change the 0x1000 low limit to 0x4000. > So another question: Can you > detect whether we

Re: [Xen-devel] [RFC] x86/boot: Don't use BDA value if it's suspiciously small

2016-08-26 Thread Sylvain Munaut
On Fri, Aug 26, 2016 at 5:10 PM, Jan Beulich wrote: On 26.08.16 at 16:53, wrote: >>> I'm not sure. I'd like to see the current logic altered as little as >>> possible, and what you suggest above is more than that minimum. >> >> Then, that would be more like the very first patch I posted but

Re: [Xen-devel] IOMMU initialization failure when using linux-as-bootloader

2016-08-27 Thread Sylvain Munaut
ected (atm I'm just testing if dom0 boots properly). And if things turn OK and you think this is a proper fix for the issue and safe to apply, I can send the patch properly to the list. Cheers, Sylvain Munaut - diff --git a/xen/drivers/passthrough/vtd/iommu.c b/xen/drivers/passthrough

Re: [Xen-devel] IOMMU initialization failure when using linux-as-bootloader

2016-08-29 Thread Sylvain Munaut
Hi Jan, > I think this is reasonable, despite it certainly being unexpected for > the BIOS to turn such on when not putting the system into x2APIC > mode. It seems that linux doesn't use x2APIC because the BIOS explicitly "opts out" of it : "DMAR-IR: x2apic is disabled because BIOS sets x2apic

[Xen-devel] Xen, EFI and kexec

2016-11-09 Thread Sylvain Munaut
the physical address mode, but is that usable after the first linux setup the virtual mode). Is there anything else I overlooked that will be an issue ? Is this a use case worth supporting ? (Obviously I think so, but I'm biased :p) And if I'm looking at it the wrong way, what way should

Re: [Xen-devel] [PATCH] xenbus: don't BUG() on user mode induced condition

2016-08-21 Thread Sylvain Munaut
= 0x1905000 rt_sigaction(SIGPIPE, {SIG_IGN, [], SA_RESTORER, 0x7fe4dd98e0e0}, {SIG_DFL, [], 0}, 8) = 0 write(3, "\1\0\0\0\0\0\0\0\0\0\0\0\2\0\0\0", 16) = 16 write(3, "/\0", 2) = -1 ESRCH (No such process) So either what xenstore

Re: [Xen-devel] [PATCH] xenbus: don't BUG() on user mode induced condition

2016-08-21 Thread Sylvain Munaut
Hi, >> I'm trying to find out why just doing "xenstore-ls" doesn't work on my >> 4.4.20 kernel and when stracing it, I see it doing : > > That looks like the same brokeness I reported earlier: > https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg02496.html > Luckily I'm not alone with

Re: [Xen-devel] [PATCH] xenbus: don't BUG() on user mode induced condition

2016-08-22 Thread Sylvain Munaut
Hi Jan, > See https://patchwork.kernel.org/patch/9281193/. Thanks for the pointer ! I had checked the kernel git tree for a potential fix, but didn't think of patchwork. Cheers, Sylvain Munaut ___ Xen-devel mailing list Xen-devel@lists

[Xen-devel] mkelf32 incorrectly filling out the program headers for NOTE

2016-08-24 Thread Sylvain Munaut
he file image and to the same thing, so they should match. The correct one is the one of the .note and the incorrect value of the program header one causes kexec to parse the header wrongly and just plain crash. (granted it should be more robust and not segfault, but still) Cheers, Sylvain

Re: [Xen-devel] mkelf32 incorrectly filling out the program headers for NOTE

2016-08-24 Thread Sylvain Munaut
Hi Jan, > Indeed, patch in the works. But why did you not provide a patch > yourself, considering that you've done all the diagnosis? I read the code of that tool this morning and couldn't really understand how "offset" was computed. I was seeing : offset = in64_phdr.p_offset; then a bit late

[Xen-devel] [PATCH 3/5] hotplug/linux: Improve iptables logic

2017-01-24 Thread Sylvain Munaut
s-bridged udp spt:68 dpt:67 ACCEPT all 0.0.0.0/0 0.0.0.0/0 PHYSDEV match --physdev-out vif86.0 --physdev-is-bridged ACCEPT all 192.168.0.254 0.0.0.0/0 PHYSDEV match --physdev-in vif86.0 --physdev-is-bridged ACCEPT all 192.168.0.141 0.0.0.0/0 PHYSDEV match --physdev-in vif86.0

[Xen-devel] [PATCH 2/5] hotplug/linux: Properly match input/output interfaces for non-bridge mode

2017-01-24 Thread Sylvain Munaut
The "-m physdev --physdev-is-bridged --physdev-XXX" condition only works for ports of a bridge and won't match anything in the other cases. Signed-off-by: Sylvain Munaut --- tools/hotplug/Linux/vif-bridge | 2 +- tools/hotplug/Linux/vif-common.sh | 14 -- tool

[Xen-devel] [PATCH 5/5] hotplug/linux: Add IPv6 support to vif-route

2017-01-24 Thread Sylvain Munaut
Signed-off-by: Sylvain Munaut --- docs/man/xl-network-configuration.markdown.5 | 9 tools/hotplug/Linux/vif-common.sh| 33 tools/hotplug/Linux/vif-route| 20 - tools/libxl/libxl_nic.c | 5

[Xen-devel] [PATCH 1/5] hotplug/linux: Use the '-w' wait flag when calling iptables

2017-01-24 Thread Sylvain Munaut
s are using the xtable lock. Signed-off-by: Sylvain Munaut --- tools/hotplug/Linux/vif-common.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/hotplug/Linux/vif-common.sh b/tools/hotplug/Linux/vif-common.sh index 6e8d584..33e5408 100644 --- a/tools/hotplug/Linux/vif-

[Xen-devel] [PATCH 4/5] hotplug/linux: Add IPv6 support to the iptables logic

2017-01-24 Thread Sylvain Munaut
lfe80::216:3eff:fed0:da2d/128 ::/0 PHYSDEV match --physdev-in vif95.0 --physdev-is-bridged ACCEPT all::/0 ::/0 PHYSDEV match --physdev-out vif95.0 --physdev-is-bridged Signed-off-by: Sylvain Munaut --- docs/man/xl-network-configuration.ma

[Xen-devel] [PATCH 0/5] Various improvements for the VIF linux hotplug scripts

2017-01-24 Thread Sylvain Munaut
Ian Campbell at the time. They were held up because of some discussion and I eventually lost track of them. I removed the parts that were not settled from the patch, made some other improvements and took into account all the comments that were raised back then. Cheers, Sylvain Munaut

Re: [Xen-devel] [PATCH 5/5] hotplug/linux: Add IPv6 support to vif-route

2017-01-24 Thread Sylvain Munaut
ilar to 'proxy_arp' except you need to manually specify which address you want it to proxy and on which interface. Cheers, Sylvain Munaut ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 3/5] hotplug/linux: Improve iptables logic

2017-01-24 Thread Sylvain Munaut
Hi, > AFIACT the duplicate entries are simply because > >> - iptables "$c" FORWARD -w $dev_in_match "$dev" \ >> -"$@" -j ACCEPT 2>/dev/null && >> - iptables "$c" FORWARD -w $dev_out_match "$dev" \ >> --j ACCEPT 2>/dev/null > > this second line, which does not contain "$@", is invoked onc

Re: [Xen-devel] [PATCH 3/5] hotplug/linux: Improve iptables logic

2017-01-26 Thread Sylvain Munaut
e customization. I'd have to see how it works with v6 and user customization but I'm not going to implement the v6 and redo all the testing purely to see if it's at best equivalent in my eyes. Cheers, Sylvain Munaut ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel