Re: [Xen-devel] [PATCH 6/6] AMD-PVH: enable pvh if requirements met

2015-06-24 Thread Mukesh Rathor
On Wed, 24 Jun 2015 16:26:44 -0400 Elena Ufimtseva wrote: > On Wed, Jun 24, 2015 at 07:24:18PM +0100, Andrew Cooper wrote: > > On 24/06/15 08:49, Jan Beulich wrote: > > On 24.06.15 at 04:34, wrote: > > >> On 06/23/2015 08:30 AM, Jan Beulich wrote: > > >> On 22.06.15 at 18:37, wrote: >

Re: [Xen-devel] Removing the PVH assert in arch/x86/hvm/io.c:87

2014-12-04 Thread Mukesh Rathor
On Thu, 4 Dec 2014 17:35:59 +0100 Roger Pau Monné wrote: > Hello, > > I've just stumbled upon this assert while testing PVH on different > hardware. It was added in 7c4870 as a safe belt, but it turns out INS > and OUTS go through handle_mmio. So using this instructions from a PVH > guest basica

Re: [Xen-devel] [PATCH] VMX: don't allow PVH to reach handle_pio() or handle_mmio()

2014-12-05 Thread Mukesh Rathor
On Fri, 05 Dec 2014 14:06:53 + "Jan Beulich" wrote: > PVH guests are not supposed to access I/O ports they weren't given > access to (there's nothing to handle emulation of such accesses). > > Reported-by: Roger Pau Monné > Signed-off-by: Jan Beulich > --- > Note: Only compile tested so far

Re: [Xen-devel] [PATCH v2] VMX: don't allow PVH to reach handle_mmio()

2014-12-08 Thread Mukesh Rathor
gp_fault, 0); > } > else > Good idea, and if needed: Acked-by: Mukesh Rathor thanks Mukesh ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [V0 PATCH 2/6] AMD-PVH: cpuid intercept

2014-12-12 Thread Mukesh Rathor
Call pv_cpuid for pvh cpuid intercept. Note, we modify svm_vmexit_do_cpuid instead of the intercept switch because the guest eip needs to be adjusted for pvh also. Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/svm.c | 24 ++-- 1 file changed, 14 insertions(+), 10

[Xen-devel] [V0 PATCH 4/6] AMD-PVH: Do not get/set vlapic TPR

2014-12-12 Thread Mukesh Rathor
PVH doesn't use apic emulation hence vlapic->regs ptr is not set for it. Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/svm.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm

[Xen-devel] [V0 PATCH 6/6] AMD-PVH: enable pvh if requirements met

2014-12-12 Thread Mukesh Rathor
Finally, enable pvh if the cpu supports NPT and svm decode. Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/svm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 4bb4ff2..8b27a76 100644 --- a/xen/arch/x86/hvm/svm/svm.c

[Xen-devel] [V0 PATCH 1/6] AMD-PVH: construct vmcb changes

2014-12-12 Thread Mukesh Rathor
PVH guest starts in Long 64bit paging mode. This patch modifies construct_vmcb for that. Signed-off-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/vmcb.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/svm/vmcb.c b/xen/arch/x86/hvm/svm/vmcb.c

[Xen-devel] [V0 PATCH 5/6] AMD-PVH: Support TSC_MODE_NEVER_EMULATE for PVH

2014-12-12 Thread Mukesh Rathor
On AMD, MSR_AMD64_TSC_RATIO must be set for rdtsc instruction in guest to properly read the cpu tsc. To that end, set tsc_khz in struct domain. Signed-off-by: Mukesh Rathor --- xen/arch/x86/time.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/time.c b/xen/arch/x86/time.c

[Xen-devel] [V0 PATCH 3/6] AMD-PVH: call hvm_emulate_one instead of handle_mmio

2014-12-12 Thread Mukesh Rathor
-by: Mukesh Rathor --- xen/arch/x86/hvm/svm/svm.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c index 4ff4a96..dac16f4 100644 --- a/xen/arch/x86/hvm/svm/svm.c +++ b/xen/arch/x86/hvm/svm/svm.c

[Xen-devel] [AMD PVH]: Partial/domU xen patches...

2014-12-12 Thread Mukesh Rathor
Hi Elena/Boris: Actually, I forgot I had already made and tested AMD SVM and other changes for domU support, please find the patches. So the only thing remaining for AMD would be iommu support and SVM vmexit for CR reads and writes which currently calls handle_mmio (which patch #3 attempted, bu

Re: [Xen-devel] [PATCH xen-4.6] xen: Remove CONFIG_X86_SUPERVISOR_MODE_KERNEL as x86_32 builds are unsupported

2015-01-05 Thread Mukesh Rathor
On Mon, 5 Jan 2015 15:35:27 + Andrew Cooper wrote: > On 05/01/15 15:16, Ian Campbell wrote: > > On Fri, 2015-01-02 at 19:12 +, Andrew Cooper wrote: > >> supervisor_mode_kernel was an x86_32-only feature which permitted > >> a PV dom0 to run in ring 0, but at the expense of not being able