Re: [Xen-devel] [libvirt] [PATCH] libxl: support dom0

2015-07-08 Thread Michal Privoznik
On 07.07.2015 01:27, Jim Fehlig wrote: > On 07/06/2015 03:46 PM, Jim Fehlig wrote: >> In Xen, dom0 is really just another domain that supports ballooning, >> adding/removing devices, changing vcpu configuration, etc. This patch >> adds support to the libxl driver for managing dom0. Note that the >>

Re: [Xen-devel] [libvirt] [PATCH 0/4] xenconfig: fix SPICE parsing/formatting

2015-05-18 Thread Michal Privoznik
On 09.05.2015 00:00, Jim Fehlig wrote: > This series fixes several bugs related to SPICE parsing and formatting > code in xenconfig. The bugs are mostly due to misinterpretation of the > Xen documenation, which I failed to notice when reviewing the initial > submission. > > Jim Fehlig (4): > xe

Re: [Xen-devel] [libvirt] [PATCH 3/4] libxl: support SPICE graphics for HVM domains

2015-05-28 Thread Michal Privoznik
On 09.05.2015 00:31, Jim Fehlig wrote: > Signed-off-by: Jim Fehlig > --- > src/libxl/libxl_conf.c | 72 > +- > 1 file changed, 66 insertions(+), 6 deletions(-) > > diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c > index 8552c77..5bb04

Re: [Xen-devel] [libvirt] [PATCH 0/4] libxl: support SPICE graphics

2015-05-28 Thread Michal Privoznik
On 09.05.2015 00:31, Jim Fehlig wrote: > This series provides support for SPICE graphics in the libxl driver. > The first patch is mostly code movement. The second patch is a trivial > name change of a structure member. Patch3 populates the > libxl_domain_build_info struct with SPICE info. SPICE

Re: [Xen-devel] [libvirt] [PATCH 3/4] libxl: support SPICE graphics for HVM domains

2015-05-28 Thread Michal Privoznik
On 28.05.2015 17:45, Jim Fehlig wrote: > > >> On May 28, 2015, at 4:07 AM, Michal Privoznik wrote: >> >>> On 09.05.2015 00:31, Jim Fehlig wrote: >>> Signed-off-by: Jim Fehlig >>> --- >>> src/libxl/libxl_conf.c | 72 >>> ++

Re: [Xen-devel] [libvirt] [PATCH v2 5/7] virNetDevMacVLanTapSetup: Allow enabling of IFF_MULTI_QUEUE

2015-12-14 Thread Michal Privoznik
On 14.12.2015 11:23, Ian Campbell wrote: > Hello, > > On Thu, 2015-12-10 at 08:38 +0100, Michal Privoznik wrote: >> Like we are doing for TUN/TAP devices, we should do the same for >> macvtaps. Although, it's not as critical as in that case, we >> should do it f

Re: [Xen-devel] [libvirt] [PATCH V2] Xen: support maxvcpus in xm and xl config

2015-12-18 Thread Michal Privoznik
On 15.12.2015 23:20, Jim Fehlig wrote: > From: Ian Campbell > > xend prior to 4.0 understands vcpus as maxvcpus and vcpu_avail > as a bit map of which cpus are online (default is all). > > xend from 4.0 onwards understands maxvcpus as maxvcpus and > vcpus as the number which are online (from 0..

Re: [Xen-devel] [libvirt] [PATCH 1/2] xenconfig: support parsing and formatting vif bandwidth

2016-01-07 Thread Michal Privoznik
On 29.12.2015 02:09, Jim Fehlig wrote: > Both xm and xl config have long supported specifying vif rate > limiting, e.g. > > vif = [ 'mac=00:16:3E:74:3d:76,bridge=br0,rate=10MB/s' ] > > Add support for mapping rate to and from in the xenconfig > parser and formatter. rate is mapped to the require

Re: [Xen-devel] [libvirt] [PATCH 2/2] libxl: support vif outgoing bandwidth QoS

2016-01-08 Thread Michal Privoznik
On 08.01.2016 06:11, Jim Fehlig wrote: > On 01/07/2016 07:48 AM, Michal Privoznik wrote: >> On 29.12.2015 02:09, Jim Fehlig wrote: >>> The libxl_device_nic structure supports specifying an outgoing rate >>> limit based on a time interval and bytes allowed per interv

Re: [Xen-devel] [libvirt] [PATCH V2 0/3] Xen: Support vif outging bandwidth QoS

2016-01-08 Thread Michal Privoznik
On 05.01.2016 02:08, Jim Fehlig wrote: > Happy New Year! > > This small series adds support for specifying vif outgoing rate limits > in Xen. The first patch adds support for converting rate limits between > sexpr config and domXML. The second patch does the same for xl/xm config. > The third patc

Re: [Xen-devel] [libvirt] [PATCH 00/10] libxl: switch driver to use a single libxl_ctx

2015-03-20 Thread Michal Privoznik
On 18.02.2015 04:56, Jim Fehlig wrote: > This series is a follow up to > > https://www.redhat.com/archives/libvir-list/2015-February/msg00024.html > > It goes a step further and changes the libxl driver to use one, > driver-wide libxl_ctx. Currently the libxl driver has one driver-wide > ctx for

Re: [Xen-devel] [libvirt] [PATCH LIBVIRT] libxl: don't end job for ephemeal domain on start failure

2015-09-11 Thread Michal Privoznik
On 10.09.2015 17:45, Ian Campbell wrote: > commit 4b53d0d4ac9c "libxl: don't remove persistent domain on start > failure" cleans up the vm object and sets it to NULL if the vm is not > persistent, however at end job vm (now NULL) is dereferenced via the call to > libxlDomainObjEndJob. Avoid this by

Re: [Xen-devel] [libvirt] [PATCH] libxl: report correct errno from virNetSocketNewConnectTCP on migration

2015-09-03 Thread Michal Privoznik
On 03.09.2015 12:14, Ian Campbell wrote: > saved_errno is never written to in this function after it is > initialised and it is only used to log the failure from > virNetSocketNewConnectTCP masking the real errno from that function. > > Drop saved_errno and use errno itself. > > Signed-off-by: Ia

Re: [Xen-devel] [libvirt] [PATCH V2] libxl: don't overwrite error from virNetSocketNewConnectTCP()

2015-09-04 Thread Michal Privoznik
On 03.09.2015 22:55, John Ferlan wrote: > > > On 09/03/2015 01:40 PM, Jim Fehlig wrote: >> Remove redundant error reporting in libxlDomainMigrationPerform(). >> virNetSocketNewConnectTCP() is perfectly capable of reporting >> sensible errors. >> >> Signed-off-by: Jim Fehlig >> --- >> >> V2: >> A

Re: [Xen-devel] [libvirt] [PATCH V3 1/3] libxl: Move job acquisition in libxlDomainStart to callers

2015-04-09 Thread Michal Privoznik
On 04.04.2015 00:49, Jim Fehlig wrote: > Let callers of libxlDomainStart decide when it is appropriate to > acquire a job on the associated virDomainObj. > > Signed-off-by: Jim Fehlig > --- > > Job handling in the migration code is currently broken/incomplete, > so fixing it is deferred to a fol

Re: [Xen-devel] [libvirt] [PATCH V3 0/3] libxl: domain destroy fixes

2015-04-09 Thread Michal Privoznik
On 04.04.2015 00:49, Jim Fehlig wrote: > V3 of a small series to fix issues wrt domain destroy > > V1: > https://www.redhat.com/archives/libvir-list/2015-March/msg01337.html > > V2: > https://www.redhat.com/archives/libvir-list/2015-April/msg00072.html > > In this version, patch 3 is changed a b

Re: [Xen-devel] [libvirt] [PATCH] libxl: support soundhw for hvm domains

2015-05-05 Thread Michal Privoznik
On 04.05.2015 22:35, Jim Fehlig wrote: > The xend driver and the parsing/formating code in src/xenconfig > have long supported soundhw. Add support in the libxl driver too. > > Signed-off-by: Jim Fehlig > --- > > This patch continues the tradition of silently ignoring unsupported > config in th