Re: [Xen-devel] [PATCH 21/44] powerpc: implement ->mapping_error

2017-06-14 Thread Michael Ellerman
arch/powerpc/platforms/ps3/system-bus.c:static const struct dma_map_ops ps3_ioc0_dma_ops = { All of which look like they definitely can fail, but return 0 on error and don't implement ->mapping_error. So I guess I'm acking this and adding a TODO to fix up the NPU code at least, the p

Re: [Xen-devel] [PATCH 08/29] drivers, md: convert mddev.active from atomic_t to refcount_t

2017-03-14 Thread Michael Ellerman
Elena Reshetova writes: > refcount_t type and corresponding API should be > used instead of atomic_t when the variable is used as > a reference counter. This allows to avoid accidental > refcounter overflows that might lead to use-after-free > situations. > > Signed-off-by: Elena Reshetova > Sig

Re: [Xen-devel] [GIT PULL] xen: features and fixes for 4.5-rc0

2016-01-13 Thread Michael Ellerman
On Tue, 2016-01-12 at 14:56 +, David Vrabel wrote: > On 11/01/16 23:01, Stephen Rothwell wrote: > > Hi David, > > > > On Mon, 11 Jan 2016 11:32:01 + David Vrabel wrote: > > > > > > Please git pull the following tag: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git

Re: [Xen-devel] [PATCH 1/8] ppc/kvm: Replace ACCESS_ONCE with READ_ONCE

2015-01-15 Thread Michael Ellerman
On Thu, 2015-01-15 at 09:58 +0100, Christian Borntraeger wrote: > ACCESS_ONCE does not work reliably on non-scalar types. For > example gcc 4.6 and 4.7 might remove the volatile tag for such > accesses during the SRA (scalar replacement of aggregates) step > (https://gcc.gnu.org/bugzilla/show_bug.c