Re: [Xen-devel] HiKey 960 (ARM 64) rcu_preempt detected stalls

2017-11-16 Thread Konrad Rzeszutek Wilk
.snip.. > [0.00] Booting Linux on physical CPU 0x0 > > [0.00] Linux version 4.13.0-linaro-hikey960+ (mc@xenpro3) (gcc > version 7.1.1 20170510 (Linaro GCC 7.1-2017.05)) #1 SMP PREEMPT Wed Sep 13 > 10:16:12 EDT 2017 What branch is this? And what git repo ? _

Re: [Xen-devel] [PATCH v2 for-next 4/9] gcov: introduce hooks for the sysctl

2017-11-16 Thread Konrad Rzeszutek Wilk
On Thu, Nov 09, 2017 at 11:13:44AM +, Roger Pau Monne wrote: > So that other implementations of the sysctl can be added. > > Signed-off-by: Roger Pau Monné > --- > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Konrad Rz

Re: [Xen-devel] [PATCH v2 for-next 6/9] kconfig/gcov: rename to coverage

2017-11-16 Thread Konrad Rzeszutek Wilk
gt; Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Konrad Rzeszutek Wilk > Cc: Stefano Stabellini > Cc: Tim Deegan > Cc: Wei Liu > --- > Changes since v1: > - Use a choice in kconfig to select code coverage technology. > - C

Re: [Xen-devel] [PATCH v2 for-next 5/9] coverage: introduce generic file

2017-11-16 Thread Konrad Rzeszutek Wilk
ap > Cc: Ian Jackson > Cc: Jan Beulich > Cc: Konrad Rzeszutek Wilk Reviewed-by: Konrad Rzeszutek Wilk > Cc: Stefano Stabellini > Cc: Tim Deegan > Cc: Wei Liu > --- > Changes since v1: > - Use private coverage.h header. > - Sort alphabetically the obj-y

Re: [Xen-devel] [PATCH v2 for-next 3/9] gcov: rename sysctl and functions

2017-11-16 Thread Konrad Rzeszutek Wilk
ap > Cc: Jan Beulich > Cc: Konrad Rzeszutek Wilk Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 for-next 2/9] gcov: rename folder and header to coverage

2017-11-16 Thread Konrad Rzeszutek Wilk
On Thu, Nov 09, 2017 at 11:13:42AM +, Roger Pau Monne wrote: > Preparatory change before adding llvm profiling support. > No functional change. > > Signed-off-by: Roger Pau Monné > --- > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Ian Jackson > Cc: Jan Beulich

Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-07-18 Thread Konrad Rzeszutek Wilk
On Tue, Jul 18, 2017 at 02:38:14PM +0100, Wei Liu wrote: > On Fri, Jul 07, 2017 at 10:00:01AM -0400, Konrad Rzeszutek Wilk wrote: > > > > > > 1. PV PCI passthrough is done via pciback, which means the physical > > >device is assigned to the driver do

Re: [Xen-devel] [PATCH] kbdif: Define "feature-raw-pointer" and "request-raw-pointer"

2017-07-18 Thread Konrad Rzeszutek Wilk
he range [0, 0x7fff]. This request is > > > only applicable if "request-abs-pointer" is also set. Frontends > > > should set this value before setting Connected. > > > > > > Signed-off-by: Owen Smith > > > > Reviewed-by: Stefano Stabellini

Re: [Xen-devel] [PATCH] xen-blkfront: fix mq start/stop race

2017-07-19 Thread Konrad Rzeszutek Wilk
On Wed, Jul 19, 2017 at 03:51:48PM +0800, Junxiao Bi wrote: > Hi Konrad, > > On 07/19/2017 03:37 PM, Roger Pau Monné wrote: > > On Wed, Jul 19, 2017 at 09:19:49AM +0800, Junxiao Bi wrote: > >> Hi Roger, > >> > >> On 06/23/2017 08:57 PM, Roger Pau Monné wrote: > >>> On Thu, Jun 22, 2017 at 09:36:52

Re: [Xen-devel] [PATCH] docs: fix superpage default value

2017-07-21 Thread Konrad Rzeszutek Wilk
2:35:56PM +0100, Wei Liu wrote: > > > > > The code says it defaults to false. > > > > > > > > > > Signed-off-by: Wei Liu > > > > > --- > > > > > Cc: Andrew Cooper > > > > > Cc: George Dunlap > > > &g

Re: [Xen-devel] [PATCH] docs: fix superpage default value

2017-07-21 Thread Konrad Rzeszutek Wilk
On Fri, Jul 21, 2017 at 05:51:02PM +0100, Wei Liu wrote: > On Fri, Jul 21, 2017 at 12:44:18PM -0400, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 20, 2017 at 01:57:17PM +0100, Wei Liu wrote: > > > On Thu, Jul 20, 2017 at 12:49:37PM +0100, Andrew Cooper wrote: > > > &

Re: [Xen-devel] [PATCH v1 3/3] xen/livepatch/ARM32: Don't crash on livepatches loaded with wrong alignment.

2017-07-24 Thread Konrad Rzeszutek Wilk
On Mon, Jul 24, 2017 at 11:34:26AM +0100, Julien Grall wrote: > Hi, > > On 12/07/17 07:07, Jan Beulich wrote: > > > > > Konrad Rzeszutek Wilk 07/11/17 10:34 PM >>> > > > On Tue, Jul 11, 2017 at 02:06:09PM -0600, Jan Beulich wrote: > > &

[Xen-devel] [GIT PULL] (xen) stable/for-jens-4.13

2017-07-25 Thread Konrad Rzeszutek Wilk
Hi Jens, Please git pull in your branch "for-linus" the following branch which is based on 765e40b675a9566459ddcb8358ad16f3b8344bbe "blk-mq: map queues to all present CPUs": git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-jens-4.13 It has two bug-fixes for the xen-blkfr

[Xen-devel] [PATCH] xen:arm earlyprintk configuration for Hikey 960 boards

2017-07-26 Thread Konrad Rzeszutek Wilk
ubaa64.efi \ --format=arm64-efi \ --prefix="/boot/grub" \ $GRUB_MODULES And grub.config: search.fs_label rootfs root set prefix=($root)/boot/grub configfile $prefix/grub.cfg Signed-off-by: Konrad Rzeszutek Wilk --- docs/misc/arm/early-printk.txt

Re: [Xen-devel] [PATCH v2 1/3] x86: nuke PV superpage option and code

2017-07-26 Thread Konrad Rzeszutek Wilk
though, seeing as this was an Oracle > feature originally (even though we were given permission to rip it out). Acked-by: Konrad Rzeszutek Wilk for all this code. RIP PV superpage. > > ~Andrew ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2 2/5] livepatch: Include sizes when an mismatch occurs

2017-07-26 Thread Konrad Rzeszutek Wilk
From: Konrad Rzeszutek Wilk If the .bug.frames.X or .livepatch.funcs sizes are different than what the hypervisor expects - we fail the payload. To help in diagnosing this include the expected and the payload sizes. Also make it more natural by having "Multiples" in the warning. Sig

[Xen-devel] [PATCH v2 4/5] alternative/x86/arm32: Align altinstructions (and altinstr_replacement) sections.

2017-07-26 Thread Konrad Rzeszutek Wilk
: Before=822563, After=822563, chg +0.00% Signed-off-by: Konrad Rzeszutek Wilk --- v2: First version --- xen/include/asm-arm/alternative.h | 4 xen/include/asm-x86/alternative.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/xen/include/asm-arm/alternative.h b/xen/include/asm-arm/alte

[Xen-devel] [PATCH v2] Livepatch fixes for v4.10 (v2).

2017-07-26 Thread Konrad Rzeszutek Wilk
LEASE-4.9.0 they would crash thanks to alignment errors). Thanks. Konrad Rzeszutek Wilk (4): livepatch: Tighten alignment checks. livepatch: Include sizes when an mismatch occurs xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment. alter

[Xen-devel] [PATCH v2 5/5] livepatch: Declare live patching as a supported feature

2017-07-26 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall See docs/features/livepatch.pandoc for the details. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk -- v2: - Moved it into a feature document. - Clarified a few bits and pieces based on feedback. v3: - default X86 --- docs/features/livepatch.pandoc

[Xen-devel] [PATCH v2 1/5] livepatch: Tighten alignment checks.

2017-07-26 Thread Konrad Rzeszutek Wilk
From: Konrad Rzeszutek Wilk The ELF specification mentions nothing about the sh_size being modulo the sh_addralign. Only that sh_addr MUST be aligned on sh_addralign if sh_addralign is not zero or one. We on loading did not take this in-to account so this patch adds a check on the ELF file as

[Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

2017-07-26 Thread Konrad Rzeszutek Wilk
xes the .livepatch.depends alignment) Signed-off-by: Konrad Rzeszutek Wilk --- v1: Initial patch v2: Redo the commit to include the commits which fix the alignment issues. Also mention the need in the docs --- docs/misc/livepatch.markdown | 6 +- xen/arch/arm/arm32/livepatch.c | 15 +

Re: [Xen-devel] [PATCH] xen:arm earlyprintk configuration for Hikey 960 boards

2017-07-26 Thread Konrad Rzeszutek Wilk
On Wed, Jul 26, 2017 at 05:59:15PM +0100, Julien Grall wrote: > Hi Konrad, > > On 26/07/17 17:54, Konrad Rzeszutek Wilk wrote: > > Introduce an earlyprintk configuration of Hikey 960 boards. ..snip.. > > Would it be possible to update the wiki page on the hikey [1] with

Re: [Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

2017-07-31 Thread Konrad Rzeszutek Wilk
On Mon, Jul 31, 2017 at 07:55:34AM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 07/26/17 9:50 PM >>> > >--- a/docs/misc/livepatch.markdown > >+++ b/docs/misc/livepatch.markdown > >@@ -279,6 +279,10 @@ It may also have some architecture-specific se

Re: [Xen-devel] [PATCH] xen:arm earlyprintk configuration for Hikey 960 boards

2017-07-31 Thread Konrad Rzeszutek Wilk
On Thu, Jul 27, 2017 at 10:52:40AM +0100, Julien Grall wrote: > Hi Konrad, > > On 27/07/17 02:18, Konrad Rzeszutek Wilk wrote: > > On Wed, Jul 26, 2017 at 05:59:15PM +0100, Julien Grall wrote: > > > Hi Konrad, > > > > > > On 26/07/17 17:54, Konrad

Re: [Xen-devel] DESIGN v2: CPUID part 3

2017-07-31 Thread Konrad Rzeszutek Wilk
On Wed, Jul 05, 2017 at 02:22:00PM +0100, Joao Martins wrote: > On 07/05/2017 12:16 PM, Andrew Cooper wrote: > > On 05/07/17 10:46, Joao Martins wrote: > >> Hey Andrew, > >> > >> On 07/04/2017 03:55 PM, Andrew Cooper wrote: > >>> Presented herewith is the a plan for the final part of CPUID work, wh

[Xen-devel] Is:livepatch-build-tools.git declare it supported? Was:Re: [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-08-05 Thread Konrad Rzeszutek Wilk
On Thu, Aug 03, 2017 at 06:21:30PM +0100, George Dunlap wrote: > On 08/03/2017 06:20 PM, George Dunlap wrote: > > On 07/03/2017 03:53 PM, Ross Lagerwall wrote: > >> On 06/30/2017 02:42 PM, George Dunlap wrote: > >>> On 06/28/2017 05:18 PM, Ross Lagerwall wrote: > On 06/27/2017 10:17 AM, George

Re: [Xen-devel] [Bug] 4.12 kernel dom0 always reboot on xen 4.9 efi

2017-08-10 Thread Konrad Rzeszutek Wilk
On Thu, Aug 10, 2017 at 11:09:20AM +, Zhang, Xiong Y wrote: > On my SKL/KBL machine, upstream 4.12 kernel dom0 couldn't boot up using > xen.efi which is xen 4.9 > > > (1) Upstream 4.11 kernel doesn't have such issue. > > (2) Upstream 4.12 kernel on my native uefi machine could boot

Re: [Xen-devel] blkback shutdown problem ? (Re: [linux-4.9 test] 110513: regressions - FAIL)

2017-06-19 Thread Konrad Rzeszutek Wilk
On Mon, Jun 19, 2017 at 03:27:01PM +0100, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("Re: blkback shutdown problem ? (Re: [linux-4.9 > test] 110513: regressions - FAIL)"): > > On Mon, Jun 19, 2017 at 12:27:33PM +0100, Roger Pau Monné wrote: > > > This has al

Re: [Xen-devel] [PATCH for-4.9] xen/test/Makefile: Fix clean target, broken by pattern rule

2017-06-19 Thread Konrad Rzeszutek Wilk
ean); and dist, > src-tarball-*, etc. (which are converted to install by an earlier > Makefile). > > Reported-by: Andrew Cooper > Signed-off-by: Ian Jackson Acked-by: Konrad Rzeszutek Wilk > --- > xen/test/Makefile | 7 ++- > 1 file changed, 6 insertions(+), 1

Re: [Xen-devel] [PATCH v2 08/16] xen/arm: livepatch: Redefine virt_to_mfn to support typesafe

2017-06-19 Thread Konrad Rzeszutek Wilk
tch.c to handle typesafe MFN. > > Signed-off-by: Julien Grall > Reviewed-by: Stefano Stabellini Acked-by: Konrad Rzeszutek Wilk > --- > > Cc: Ross Lagerwall > Cc: Konrad Rzeszutek Wilk > > Changes in v2: > - Add Stefano's reviewed-by >

Re: [Xen-devel] [PATCH 1/2] xen/livepatch: Clean up arch relocation handling

2017-06-19 Thread Konrad Rzeszutek Wilk
> elf->nsym check as > >> way to make sure we won't dereference the dest (b/c the symbol > >> may be outside the bounds). > > But symndx isn't being used here. > > Indeed. r->r_offset (and therefore dest) has no direct bearin

Re: [Xen-devel] [PATCH 2/2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-19 Thread Konrad Rzeszutek Wilk
ly there > aren't that many use cases for it. OK. In that case: Acked-by: Konrad Rzeszutek Wilk Andrew, Do you think it would be possible to generate an test-case for this in arch/test/livepatch? > > Jan > ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.9] xen/test/Makefile: Fix clean target, broken by pattern rule

2017-06-19 Thread Konrad Rzeszutek Wilk
ean); and dist, > src-tarball-*, etc. (which are converted to install by an earlier > Makefile). > > Reported-by: Andrew Cooper > Signed-off-by: Ian Jackson And Tested-by: Konrad Rzeszutek Wilk > --- > xen/test/Makefile | 7 ++- > 1 file changed, 6 insertions(+), 1

[Xen-devel] [PATCH v1 1/3] livepatch: Add local and global symbol resolution.

2017-06-19 Thread Konrad Rzeszutek Wilk
27;static' on functions and data variables is the right one. Signed-off-by: Konrad Rzeszutek Wilk --- xen/common/livepatch.c | 21 ++--- xen/include/xen/livepatch.h | 3 ++- xen/include/xen/livepatch_elf.h | 7 +++ 3 files changed, 23 insertions(+), 8 delet

[Xen-devel] [PATCH v1 2/3] livepatch: Add xen_local_symbols test-case

2017-06-19 Thread Konrad Rzeszutek Wilk
.. Signed-off-by: Konrad Rzeszutek Wilk --- xen/test/livepatch/Makefile| 10 ++- xen/test/livepatch/xen_local_symbols.c | 52 ++ 2 files changed, 61 insertions(+), 1 deletion(-) create mode 100644 xen/test/livepatch/xen_local_symbols.c diff --git

[Xen-devel] [PATCH v1 OSSTEST 3/3] ts-livepatch: Expand testcase to include global/local symbols

2017-06-19 Thread Konrad Rzeszutek Wilk
testing. The test is to verify that the local symbols of payloads are ignored during loading. See Xen's patch "livepatch: Add local and global symbol resolution." Signed-off-by: Konrad Rzeszutek Wilk --- ts-livepatch-run | 26 -- 1 file changed, 24 i

[Xen-devel] [PATCH] Livepatch: Support local/global symbols.

2017-06-19 Thread Konrad Rzeszutek Wilk
deletions(-) Konrad Rzeszutek Wilk (2): livepatch: Add local and global symbol resolution. livepatch: Add xen_local_symbols test-case ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14

2017-06-20 Thread Konrad Rzeszutek Wilk
Hey Jens, Please git pull the following branch: git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git stable/for-jens-4.12 which has security and memory leak fixes in xen block driver. Thank you. Jan Beulich (1): xen-blkback: don't leak stack data via response ring Juergen Gross

Re: [Xen-devel] [PATCH 2/2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-20 Thread Konrad Rzeszutek Wilk
On Tue, Jun 20, 2017 at 01:15:18AM -0600, Jan Beulich wrote: > >>> On 20.06.17 at 01:05, wrote: > > On 19/06/2017 19:30, Konrad Rzeszutek Wilk wrote: > >> On Wed, Jun 14, 2017 at 12:49:21PM -0600, Jan Beulich wrote: > >>>>>> Andrew Cooper 06/14/1

Re: [Xen-devel] [PATCH 1/2] xen/livepatch: Clean up arch relocation handling

2017-06-20 Thread Konrad Rzeszutek Wilk
On Tue, Jun 20, 2017 at 01:56:28AM -0600, Jan Beulich wrote: > >>> On 20.06.17 at 09:39, wrote: > > On 20/06/2017 08:36, Jan Beulich wrote: > > On 19.06.17 at 20:18, wrote: > >>> On Wed, Jun 14, 2017 at 07:28:39PM +0100, Andrew Cooper wrote: > Having said that, there is no sanity check t

Re: [Xen-devel] [GIT PULL] (xen) stable/for-jens-3.14

2017-06-20 Thread Konrad Rzeszutek Wilk
On Tue, Jun 20, 2017 at 07:11:01AM -0600, Jens Axboe wrote: > On 06/20/2017 06:13 AM, Konrad Rzeszutek Wilk wrote: > > Hey Jens, > > > > Please git pull the following branch: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git > >

Re: [Xen-devel] [PATCH v1 1/3] livepatch: Add local and global symbol resolution.

2017-06-20 Thread Konrad Rzeszutek Wilk
On Tue, Jun 20, 2017 at 01:51:41AM -0600, Jan Beulich wrote: > >>> On 20.06.17 at 04:47, wrote: > > This way we can load livepatches with symbol names that > > are the same as long as they are local ('static'). > > > > The use case here is to replace an existing livepatch > > with a newer one - a

Re: [Xen-devel] Fwd: VM Live Migration with Local Storage

2017-06-20 Thread Konrad Rzeszutek Wilk
On Sun, Jun 11, 2017 at 08:16:04PM -0700, Bruno Alvisio wrote: > Hello, > > I think it would be beneficial to add local disk migration feature for > ‘blkback' backend since it is one of the mostly used backends. I would like > to start a discussion about the design of the machinery needed to achie

Re: [Xen-devel] [PATCH for-4.9 v2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-21 Thread Konrad Rzeszutek Wilk
elocation > with -EOPNOTSUPP. > > Additionally, perform a safety check on elf->sym[symndx].sym before > derefencing it, to avoid tripping over a NULL pointer when calculating val. > > Signed-off-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Wilk Tested-by: Konrad Rzeszutek

[Xen-devel] Is [PATCH for-4.9] Was:Re: [PATCH 1/2] xen/livepatch: Clean up arch relocation handling

2017-06-21 Thread Konrad Rzeszutek Wilk
r > --- > CC: Konrad Rzeszutek Wilk > CC: Ross Lagerwall > CC: Jan Beulich > CC: Stefano Stabellini > CC: Julien Grall > > The purpose of this patch is simply to make the following patch easier to > review. Jan Acked it and Reviewed-by: Konrad Rzeszutek Wilk and Tes

Re: [Xen-devel] live migration of HVM domUs with more than 32vcpus fails

2017-06-22 Thread Konrad Rzeszutek Wilk
On Thu, Jun 22, 2017 at 03:57:52PM +0200, Olaf Hering wrote: > It seems that live migration of HVM domUs with more than 32 vcpus causes > a hang of the domU on the remote side. Both ping and 'xl console' show no > reaction. > This happens also with kernel-4.12. Is this a known bug? Ankur had some

Re: [Xen-devel] [PATCH for-4.9 v2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-22 Thread Konrad Rzeszutek Wilk
On Wed, Jun 21, 2017 at 09:26:15PM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 21, 2017 at 07:13:36PM +0100, Andrew Cooper wrote: > > A symndx of STN_UNDEF is special, and means a symbol value of 0. While > > legitimate in the ELF standard, its existance in a livepatch

Re: [Xen-devel] [PATCH v2] VT-d: fix VF of RC integrated endpoint matched to wrong VT-d unit

2017-06-22 Thread Konrad Rzeszutek Wilk
On Thu, Jun 22, 2017 at 09:31:50AM -0600, Jan Beulich wrote: > >>> On 22.06.17 at 16:21, wrote: > > On Thu, Jun 22, 2017 at 03:26:04AM -0600, Jan Beulich wrote: > > On 21.06.17 at 12:47, wrote: > >>> The problem is a VF of RC integrated PF (e.g. PF's BDF is 00:02.0), > >>> we would wrongly us

Re: [Xen-devel] [PATCH for-4.9 v2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-22 Thread Konrad Rzeszutek Wilk
On Thu, Jun 22, 2017 at 11:27:50AM -0400, Konrad Rzeszutek Wilk wrote: > On Wed, Jun 21, 2017 at 09:26:15PM -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, Jun 21, 2017 at 07:13:36PM +0100, Andrew Cooper wrote: > > > A symndx of STN_UNDEF is special, and means a symbol

Re: [Xen-devel] [PATCH for-4.9 v2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-22 Thread Konrad Rzeszutek Wilk
On Thu, Jun 22, 2017 at 12:10:46PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Jun 22, 2017 at 11:27:50AM -0400, Konrad Rzeszutek Wilk wrote: > > On Wed, Jun 21, 2017 at 09:26:15PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Wed, Jun 21, 2017 at 07:13:36PM +0100, Andrew Coope

Re: [Xen-devel] [PATCH for-4.9 v2] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-22 Thread Konrad Rzeszutek Wilk
On Thu, Jun 22, 2017 at 12:33:57PM -0400, Konrad Rzeszutek Wilk wrote: > On Thu, Jun 22, 2017 at 12:10:46PM -0400, Konrad Rzeszutek Wilk wrote: > > On Thu, Jun 22, 2017 at 11:27:50AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Wed, Jun 21, 2017 at 09:26:15PM -0400, Konrad Rz

Re: [Xen-devel] Travis build failing because "tools/xen-detect: try sysfs node for obtaining guest type" ?

2017-06-22 Thread Konrad Rzeszutek Wilk
On Thu, Jun 22, 2017 at 07:31:53PM +0200, Dario Faggioli wrote: > Hey, > > Am I the only one for which Travis seems to be unhappy of this: Nope. I saw it too ,but then figured there was some patch from Olaf for this?. > > I/home/travis/build/fdario/xen/tools/misc/../../tools/include > xen

Re: [Xen-devel] [PATCH] xen: Replace ASSERT(0) with ASSERT_UNREACHABLE()

2017-06-22 Thread Konrad Rzeszutek Wilk
On Wed, Jun 21, 2017 at 01:40:45PM +0100, Andrew Cooper wrote: > No functional change, but the result is more informative both in the code and > error messages if the assertions do get hit. > > Signed-off-by: Andrew Cooper > --- > CC: Jan Beulich > CC: Konrad Rzeszutek Wi

Re: [Xen-devel] [PATCH for-4.9 v3 2/3] xen/livepatch: Use zeroed memory allocations for arrays

2017-06-22 Thread Konrad Rzeszutek Wilk
; --- > CC: Konrad Rzeszutek Wilk Reviewed-by: Konrad Rzeszutek Wilk Tested-by: Konrad Rzeszutek Wilk [x86 and ARM32] > CC: Ross Lagerwall > > * new in v3 > --- > xen/common/livepatch.c | 4 ++-- > xen/common/livepatch_elf.c | 4 ++-- > 2 files changed, 4 insertion

Re: [Xen-devel] [PATCH for-4.9 v3 3/3] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-22 Thread Konrad Rzeszutek Wilk
elocation > with -EOPNOTSUPP. > > Additionally, fix an off-by-one error while range checking symndx, and perform > a safety check on elf->sym[symndx].sym before derefencing it, to avoid > tripping over a NULL pointer when calculating val. > > Signed-off-by: Andrew Cooper

Re: [Xen-devel] [PATCH RFC] Live migration for VMs with QEMU backed local storage

2017-06-23 Thread Konrad Rzeszutek Wilk
On Fri, Jun 23, 2017 at 03:31:16AM -0400, Bruno Alvisio wrote: > This patch is the first attempt on adding live migration of instances with > local > storage to Xen. This patch just handles very restricted case of fully > virtualized HVMs. The code uses the "drive-mirror" capability provided by >

Re: [Xen-devel] [PATCH for-4.9 v3 3/3] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-23 Thread Konrad Rzeszutek Wilk
On Fri, Jun 23, 2017 at 02:45:22PM +0100, Andrew Cooper wrote: > On 23/06/17 14:43, Julien Grall wrote: > > Hi, > > > > On 23/06/17 14:33, Andrew Cooper wrote: > >> On 23/06/17 14:32, Julien Grall wrote: > >>> Hi Andrew, > >>> > >>> I am a bit confused, the title says "PATCH for-4.9 v3 3/3". I have

Re: [Xen-devel] [PATCH for-4.9 v3 3/3] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-23 Thread Konrad Rzeszutek Wilk
On Fri, Jun 23, 2017 at 03:36:51PM +0100, Julien Grall wrote: > > > On 23/06/17 15:35, Konrad Rzeszutek Wilk wrote: > > On Fri, Jun 23, 2017 at 02:45:22PM +0100, Andrew Cooper wrote: > > > On 23/06/17 14:43, Julien Grall wrote: > > > > Hi, > > > >

Re: [Xen-devel] [PATCH for-4.9 v3 3/3] xen/livepatch: Don't crash on encountering STN_UNDEF relocations

2017-06-25 Thread Konrad Rzeszutek Wilk
On Sat, Jun 24, 2017 at 06:28:16PM +0100, Julien Grall wrote: > Hi Konrad, > > On 06/23/2017 03:46 PM, Konrad Rzeszutek Wilk wrote: > > On Fri, Jun 23, 2017 at 03:36:51PM +0100, Julien Grall wrote: > > > > > > > > > On 23/06/17 15:35, Konrad Rzeszutek W

Re: [Xen-devel] [PATCH] common/vm_event: Initialize vm_event lists on domain creation

2017-06-26 Thread Konrad Rzeszutek Wilk
On June 26, 2017 5:48:17 AM EDT, Razvan Cojocaru wrote: >Pending livepatch code wants to check if the vm_event wait queues >are active, and this is made harder by the fact that they were Hmm, it wants to? Is there an missing patch that hasn't been posted for this? If you mean to post this _bef

Re: [Xen-devel] [PATCH] x86/mm: Fix infinite loop in get_spage_pages()

2017-06-26 Thread Konrad Rzeszutek Wilk
On June 26, 2017 7:59:02 AM EDT, Andrew Cooper wrote: >c/s 2b8eb37 switched int i to being unsigned, but the undo logic on >failure >relied in i being signed. As i being unsigned in still preforable, >adjust the >undo logic to work with an unsigned i. > >Coverity-ID: 1413017 >Signed-off-by: Andr

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-26 Thread Konrad Rzeszutek Wilk
On Mon, Jun 26, 2017 at 07:29:22PM +0100, Julien Grall wrote: > Hi, > > On 06/26/2017 04:36 PM, Ross Lagerwall wrote: > > Xen Live Patching has been available as tech preview feature since Xen > > 4.7 and has now had a couple of releases to stabilize. Xen Live patching > > has been used by multipl

Re: [Xen-devel] [PATCH 1/4] xen/tmem: Switch to using bool

2017-06-28 Thread Konrad Rzeszutek Wilk
ewed-by: Konrad Rzeszutek Wilk > --- > CC: Konrad Rzeszutek Wilk > --- > xen/common/tmem.c | 39 --- > xen/common/tmem_control.c | 16 > xen/common/tmem_xen.c | 12 ++-- > xen/include/xen/tmem_xen.h | 24

Re: [Xen-devel] [PATCH] xen/x86: Don't BUG on CPU0 offlining

2017-06-28 Thread Konrad Rzeszutek Wilk
On Mon, Jun 26, 2017 at 06:39:30PM +0200, Vitaly Kuznetsov wrote: > CONFIG_BOOTPARAM_HOTPLUG_CPU0 allows to offline CPU0 but Xen HVM guests > BUG() in xen_teardown_timer(). Remove the BUG_ON(), this is probably a > leftover from ancient times when CPU0 hotplug was impossible, it works > just fine f

Re: [Xen-devel] [PATCH for-4.9] livepatch: Declare live patching as a supported feature

2017-06-28 Thread Konrad Rzeszutek Wilk
. snip.. > > Now all of the customers that have applied those patches are vulnerable. > > > > Do you: > > > > 1. Tell the reporter to post it publicly to xen-devel immediately, since > > livepatch tools are not security supported -- thus "zero-day"-ing all > > your customers (as well as anyone el

Re: [Xen-devel] [PATCH for-4.9 v2] livepatch: Declare live patching as a supported feature

2017-06-28 Thread Konrad Rzeszutek Wilk
On Wed, Jun 28, 2017 at 05:13:44PM +0100, Ross Lagerwall wrote: > See docs/features/livepatch.pandoc for the details. > > Signed-off-by: Ross Lagerwall Reviewed-by: Konrad Rzeszutek Wilk Thank you for the writeup! ___ Xen-devel mailing

Re: [Xen-devel] [PATCH 2/2] tools: utility to dump guest grant table info

2017-06-30 Thread Konrad Rzeszutek Wilk
On Fri, Jun 30, 2017 at 03:21:31PM +0800, Dongli Zhang wrote: > As both xen-netfront and xen-blkfront support multi-queue, they would > consume a lot of grant table references when there are many paravirtual > devices and vcpus assigned to guest. Guest domU might panic or hang due to > grant alloca

Re: [Xen-devel] [PATCH 1/6] xen: Add support for hiding and unhiding pcie passthrough devices

2017-07-05 Thread Konrad Rzeszutek Wilk
> > > --- a/xen/include/public/domctl.h > > > +++ b/xen/include/public/domctl.h > > > @@ -1222,6 +1222,9 @@ struct xen_domctl { > > > #define XEN_DOMCTL_gdbsx_pausevcpu 1001 > > > #define XEN_DOMCTL_gdbsx_unpausevcpu 1002 > > > #define XEN_DOMCTL_gdbsx_domstatus

Re: [Xen-devel] Criteria / validation proposal: drop Xen

2017-07-06 Thread Konrad Rzeszutek Wilk
On Thu, Jul 06, 2017 at 11:59:01AM -0700, Adam Williamson wrote: > Hi, folks! A while ago, Xen virtualization functionality was added to > the criteria and the validation test case set, on the understanding > that Oracle would provide testing for it (and help fix bugs as they > arose). > > For the

Re: [Xen-devel] Criteria / validation proposal: drop Xen

2017-07-06 Thread Konrad Rzeszutek Wilk
Posting from gmail, so hopefully it doesn't send it as HTML.. On Thu, Jul 6, 2017 at 3:45 PM, Adam Williamson wrote: > On Thu, 2017-07-06 at 15:13 -0400, Konrad Rzeszutek Wilk wrote: >> On Thu, Jul 06, 2017 at 11:59:01AM -0700, Adam Williamson wrote: >> > Hi,

Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-07-07 Thread Konrad Rzeszutek Wilk
On Fri, Jul 07, 2017 at 11:56:43AM +0100, Wei Liu wrote: > On Wed, Jul 05, 2017 at 02:52:41PM -0500, Venu Busireddy wrote: > > > [...] > > > > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c > > > > index 89c2b25..10a48a9 100644 > > > > --- a/tools/xl/xl_vmcontrol.c > > > > +++ b/too

Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-07-07 Thread Konrad Rzeszutek Wilk
On Tue, Mar 28, 2017 at 05:30:24PM +0200, Juergen Gross wrote: > On 28/03/17 16:27, Boris Ostrovsky wrote: > > On 03/28/2017 04:08 AM, Jan Beulich wrote: > > On 28.03.17 at 03:57, wrote: > >>> I think there is indeed a disconnect between target memory (provided by > >>> the toolstack) and cur

Re: [Xen-devel] API to query NUMA node of mfn

2017-07-10 Thread Konrad Rzeszutek Wilk
GM map to see the NUMA nodes locality. Attaching them here.. > > Jan > > > ___ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel >From a5e039801c989df29b704a4a5256715321906535 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date:

Re: [Xen-devel] API to query NUMA node of mfn

2017-07-10 Thread Konrad Rzeszutek Wilk
On Mon, Jul 10, 2017 at 03:35:33PM +0200, Olaf Hering wrote: > On Mon, Jul 10, Konrad Rzeszutek Wilk wrote: > > > Soo I wrote some code for exactly this for Xen 4.4.4 , along with > > creation of a PGM map to see the NUMA nodes locality. > > Are you planning to prepare

[Xen-devel] [PATCH] Livepatch ARM32 fixes thanks to cross-compiler.

2017-07-11 Thread Konrad Rzeszutek Wilk
| 7 ++ xen/include/xen/elfstructs.h | 2 ++ xen/include/xen/livepatch.h| 1 + 7 files changed, 88 insertions(+), 7 deletions(-) Konrad Rzeszutek Wilk (3): xen/livepatch: Tighten alignment checks. livepatch: Include sizes when an mismatch occurs xen/livepatch/ARM32

[Xen-devel] [PATCH v1 2/3] livepatch: Include sizes when an mismatch occurs

2017-07-11 Thread Konrad Rzeszutek Wilk
If the .bug.frames.X or .livepatch.funcs sizes are different than what the hypervisor expects - we fail the payload. To help in diagnosing this include the expected and the payload sizes. Signed-off-by: Konrad Rzeszutek Wilk --- xen/common/livepatch.c | 9 + 1 file changed, 5 insertions

[Xen-devel] [PATCH v1 1/3] xen/livepatch: Tighten alignment checks.

2017-07-11 Thread Konrad Rzeszutek Wilk
parsed, and then when we copy the payload contents in memory - and check the aligmnent needs there. Signed-off-by: Konrad Rzeszutek Wilk --- xen/common/livepatch.c | 9 + xen/common/livepatch_elf.c | 7 +++ xen/include/xen/elfstructs.h | 2 ++ 3 files changed, 18 insertions

[Xen-devel] [PATCH v1 3/3] xen/livepatch/ARM32: Don't crash on livepatches loaded with wrong alignment.

2017-07-11 Thread Konrad Rzeszutek Wilk
properly! Furthermore we also observe that the alignment is not correct for other sections (when cross compiling) as such we add the check in various other places which allows us to get. livepatch: xen_bye_world: .livepatch.depends alignment is wrong! instead of a crash. Signed-off-by: Konrad

Re: [Xen-devel] [PATCH 1/6] xen-blkfront: avoid to use start/stop queue

2017-07-11 Thread Konrad Rzeszutek Wilk
ongestion control patches. > > Cc: Konrad Rzeszutek Wilk > Cc: "Roger Pau Monné" > Cc: Boris Ostrovsky > Cc: Juergen Gross > Cc: xen-de...@lists.xenproject.org > Signed-off-by: Ming Lei > --- > drivers/block/xen-blkfront.c | 22 -- >

Re: [Xen-devel] [PATCH v1 3/3] xen/livepatch/ARM32: Don't crash on livepatches loaded with wrong alignment.

2017-07-11 Thread Konrad Rzeszutek Wilk
On Tue, Jul 11, 2017 at 02:06:09PM -0600, Jan Beulich wrote: > >>> Konrad Rzeszutek Wilk 07/11/17 6:53 PM >>> > >This issue was observed on ARM32 with a cross compiler for the > >livepatches. Mainly the livepatches .data section size was not > >aligned

Re: [Xen-devel] [PATCH v9 6/7] tools/libxc: add support of injecting MC# to specified CPUs

2017-07-12 Thread Konrad Rzeszutek Wilk
On Wed, Jul 12, 2017 at 10:04:39AM +0800, Haozhong Zhang wrote: > Though XEN_MC_inject_v2 allows injecting MC# to specified CPUs, the > current xc_mca_op() does not use this feature and not provide an > interface to callers. This commit add a new xc_mca_op_inject_v2() that > receives a cpumap provi

Re: [Xen-devel] [PATCH v9 7/7] tools/xen-mceinj: add support of injecting LMCE

2017-07-12 Thread Konrad Rzeszutek Wilk
On Wed, Jul 12, 2017 at 10:04:40AM +0800, Haozhong Zhang wrote: > If option '-l' or '--lmce' is specified and the host supports LMCE, > xen-mceinj will inject LMCE to CPU specified by '-c' (or CPU0 if '-c' > is not present). > > Signed-off-by: Haozhong Zhang > Acked-by: Wei Liu > --- > Cc: Ian J

Re: [Xen-devel] [edk2] OVMF Secure Boot variable storage issue

2017-07-12 Thread Konrad Rzeszutek Wilk
On Thu, Jul 06, 2017 at 02:55:27PM -0400, Jason Dickens wrote: > Thanks for the response Bill. If I should recognize your name, I'm sorry, > I'm bad with names, but I have been doing a lot of work with Wind River > recently (and in the past) so its possible I should. > > Actually, I should have me

[Xen-devel] CONFIG_SCRUB_DEBUG=y + arm64 + livepatch = Xen BUG at page_alloc.c:738

2017-09-11 Thread Konrad Rzeszutek Wilk
Hey, I've only been able to reproduce this on ARM64 (trying right now ARM32 as well), and not on x86. If I compile Xen without CONFIG_SCRUB_DEBUG it works great. But if enable it and try to load a livepatch it blows up in page_alloc.c:738 This is with origin/staging (d0291f3391) The test-case (

Re: [Xen-devel] [PATCH v2 3/5] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong alignment.

2017-09-11 Thread Konrad Rzeszutek Wilk
Jan Beulich wrote: > >> >> >>> Konrad Rzeszutek Wilk 07/31/17 6:04 PM >>> > >> >> >On Mon, Jul 31, 2017 at 07:55:34AM -0600, Jan Beulich wrote: > >> >> >> >>> Konrad Rzeszutek Wilk 07/26/17 9:50 PM >>> >

[Xen-devel] [PATCH v3 16/17] livepatch: Add local and global symbol resolution.

2017-09-11 Thread Konrad Rzeszutek Wilk
27;static' on functions and data variables is the right one. Signed-off-by: Konrad Rzeszutek Wilk --- v1: New version v2: No changes --- xen/common/livepatch.c | 21 ++--- xen/include/xen/livepatch.h | 3 ++- xen/include/xen/livepatch_elf.h | 7 +++ 3 fil

[Xen-devel] [PATCH v3 15/17] livepatch/x86/arm: Utilize the arch_livepatch_lookup_mfn

2017-09-11 Thread Konrad Rzeszutek Wilk
00 .. causing a double fault. Using the arch_livepatch_lookup_mfn solves the problem and the applying/reverting works on all platforms properly. Signed-off-by: Konrad Rzeszutek Wilk --- xen/common/livepatch.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git

[Xen-devel] [PATCH v3 14/17] livepatch/x86/arm: arch/x86/mm: generalize do_page_walk() and implement arch_livepatch_lookup_mfn

2017-09-11 Thread Konrad Rzeszutek Wilk
onrad Rzeszutek Wilk --- xen/arch/arm/livepatch.c| 7 --- xen/arch/x86/livepatch.c| 10 ++ xen/arch/x86/x86_64/mm.c| 33 - xen/include/asm-x86/mm.h| 1 + xen/include/xen/livepatch.h | 3 +++ 5 files changed, 42 insertions(+), 12 dele

[Xen-devel] [PATCH v3 08/17] livepatch/tests: Make sure all .livepatch.funcs sections are read-only

2017-09-11 Thread Konrad Rzeszutek Wilk
Instead of being writable (.data). This mimics the behavior of what livepatch-build-tools do. Other approaches such as 'struct const livepatch_funcs' still result in the WA section attributes. Signed-off-by: Konrad Rzeszutek Wilk --- xen/test/livepatch/Makefile | 4 1 file

[Xen-devel] [PATCH v3 06/17] xen/livepatch/x86/arm32: Force .livepatch.depends section to be uint32_t aligned.

2017-09-11 Thread Konrad Rzeszutek Wilk
0036 OBJECT GLOBAL HIDDEN 3 note_depends 21: 36 OBJECT GLOBAL HIDDEN 6 note_depends See patch titled: "livepatch/arm/x86: Strip note_depends symbol from test-cases." which fixes this. Signed-off-by: Konrad Rzeszutek Wilk --- v2: First version -

[Xen-devel] [PATCH v3 05/17] alternative/x86/arm32: Align altinstructions (and altinstr_replacement) sections.

2017-09-11 Thread Konrad Rzeszutek Wilk
/0 grow/shrink: 0/0 up/down: 0/0 (0) function old new delta Total: Before=822563, After=822563, chg +0.00% Also since the macros have the alignment coded in them there is no need to do that for the xen.lds.S anymore. Signed-off-by: Konrad Rzeszutek Wilk --- v2: -

[Xen-devel] [PATCH v3 13/17] livepatch: Expand spin_debug_disable in [apply|revert]_payload

2017-09-11 Thread Konrad Rzeszutek Wilk
0x102 [] check_for_livepatch_work+0x1f3/0x390 [] domain.c#continue_idle_domain+0x1b/0x22 But are definitly the case on x86 - so we expand the scope of the spin_debug_disable. Signed-off-by: Konrad Rzeszutek Wilk --- xen/common/livepatch.c | 30 -- 1 file changed, 16 insertions(+), 14 dele

[Xen-devel] [PATCH v3 11/17] livepatch/x86/arm[32, 64]: Use common vmap code for applying.

2017-09-11 Thread Konrad Rzeszutek Wilk
tingly the arch_livepatch_revert looks almost the same on x86 and ARM. See 'livepatch/x86/arm[32,64]: Unify arch_livepatch_revert' Signed-off-by: Konrad Rzeszutek Wilk --- xen/arch/arm/livepatch.c| 64 xen/arch/x86/livepatch.c| 32

[Xen-devel] [PATCH v3 07/17] livepatch/arm/x86: Strip note_depends symbol from test-cases.

2017-09-11 Thread Konrad Rzeszutek Wilk
local and global symbol resolution." but that patch is stuck in limbo). Signed-off-by: Konrad Rzeszutek Wilk --- v3: First version --- xen/test/livepatch/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/xen/test/livepatch/Makefile b/xen/test/livepatch/Makefile index 89ad89dfd

[Xen-devel] [PATCH v3] Livepatching patch set for 4.10

2017-09-11 Thread Konrad Rzeszutek Wilk
+ xen/test/livepatch/xen_local_symbols.c | 53 xen/test/livepatch/xen_nop.c | 1 + xen/test/livepatch/xen_replace_world.c | 1 + 25 files changed, 521 insertions(+), 173 deletions(-) Konrad Rzeszutek Wilk (16): livepatch: Expand check for safe_for_reapply if livepatch has

[Xen-devel] [PATCH v3 12/17] livepatch/x86/arm[32, 64]: Unify arch_livepatch_revert

2017-09-11 Thread Konrad Rzeszutek Wilk
The arch_livepatch_revert is very similar between the platforms. Lets unify it as much as possible. Signed-off-by: Konrad Rzeszutek Wilk --- xen/arch/arm/livepatch.c| 10 +- xen/arch/x86/livepatch.c| 10 ++ xen/common/livepatch.c | 14 +- xen/include/xen

[Xen-devel] [PATCH v3 03/17] livepatch: Include sizes when an mismatch occurs

2017-09-11 Thread Konrad Rzeszutek Wilk
ail if the size of the .ex_table was being zero - but that is OK. Signed-off-by: Konrad Rzeszutek Wilk --- v1: Initial version v2: - Changed to 'Multiple' per Jan's recommendation. - Folded the checks in 'check_size' function and removed all the other part

[Xen-devel] [PATCH v3 09/17] livepatch/arm[32, 64]: Modify livepatch_funcs

2017-09-11 Thread Konrad Rzeszutek Wilk
An alternative is to add the 'W' flag during loading of the .livepatch_funcs which would result the section being in writeable region from the gecko. Note that this vmap solution could be extended to x86 as well. Signed-off-by: Konrad Rzeszutek Wilk --- xen/arch/arm/arm32/livepatch.c

[Xen-devel] [PATCH v3 01/17] livepatch: Expand check for safe_for_reapply if livepatch has only .rodata.

2017-09-11 Thread Konrad Rzeszutek Wilk
by: Konrad Rzeszutek Wilk --- v3: New patch --- xen/common/livepatch.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/xen/common/livepatch.c b/xen/common/livepatch.c index 66d532db14..a1f54c42d3 100644 --- a/xen/common/livepatch.c +++ b/xen/common/livepatch.c @@ -417

[Xen-devel] [PATCH v3 04/17] xen/livepatch/ARM32: Don't load and crash on livepatches loaded with wrong text alignment.

2017-09-11 Thread Konrad Rzeszutek Wilk
for all as we only implement a small subset of them - as such we only check for data types that are implemented - and if the type is anything else and not aligned to 32-bit, then we error out. Signed-off-by: Konrad Rzeszutek Wilk --- v1: Initial patch v2: Redo the commit to include the commits whic

<    3   4   5   6   7   8   9   10   11   12   >