Re: [Xen-devel] [PATCH v4 12/34] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op

2016-03-19 Thread Konrad Rzeszutek Wilk
On Wed, Mar 16, 2016 at 12:12:00PM +, Julien Grall wrote: > Hi Konrad, > > On 15/03/2016 17:56, Konrad Rzeszutek Wilk wrote: > >diff --git a/xen/common/Kconfig b/xen/common/Kconfig > >index 8fbc46d..dbe9ccc 100644 > >--- a/xen/common/Kconfig > >+++ b/xen/co

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-19 Thread Konrad Rzeszutek Wilk
s BUGFRAME_NR properly un-parenthesized - > why here? I know I copied and pasted it and I must have done something uncanny. Anyhow this is what the change looks like now (I've retained the Reviewed and Ack as I think this change is mostly cosmetical in nature?) From 123ad665b283f8c59688bd86be0bbe79ce5723bb Mon Sep 17 0

Re: [Xen-devel] [RFC Design Doc] Add vNVDIMM support for Xen

2016-03-19 Thread Konrad Rzeszutek Wilk
> Then there is another problem (which also exists in the current > design): does Xen need to emulate NVDIMM _DSM for dom0? Take the _DSM > that access label storage area (for namespace) for example: No. And it really can't as each vendors _DSM is different - and there is no ACPI AML interpreter i

Re: [Xen-devel] [PATCH v4 01/34] compat/x86: Remove unncessary #define.

2016-03-19 Thread Konrad Rzeszutek Wilk
geset_info, etc are all unused too. Otoh > xennmi_callback is used, but xennmi_callback_t isn't. Which to me > suggests that we should leave this alone. Oddly enough taking an cleaver to it was OK. From 7e3ed6faed6e083f27ad6be947ac528c3eaba9a1 Mon Sep 17 00:00:00 2001 From: Konrad Rzesz

Re: [Xen-devel] [PATCH v4 03/34] xsm/xen_version: Add XSM for the xen_version hypercall

2016-03-19 Thread Konrad Rzeszutek Wilk
oth the same type > and hence size? Perhaps, if you feel unsure about that, simply add > a respective BUILD_BUG_ON()? Yes they are. Used a BUILD_BUG_ON just in case somebody mucks around. > > > --- a/xen/include/xen/version.h > > +++ b/xen/include/xen/version.h > > @@ -12,5 +12,5

Re: [Xen-devel] [PATCH v4 08/14] hvmloader: Locate the BIOS blob

2016-03-20 Thread Konrad Rzeszutek Wilk
> I'll do that. I'm using to many BUG_ON in this code. > > > > +{ > > > +BUG_ON(!modlist[i].paddr || modlist[i].paddr > UINT_MAX || > > > + modlist[i].size > UINT_MAX); > > > > To be fair all of those values are in spec..Perhaps you should mention > > that th

Re: [Xen-devel] [PATCH v3 07/28] xen/x86: Annotate special features

2016-03-20 Thread Konrad Rzeszutek Wilk
cannot influence what the > guest sees in the dependent leaves. > > Signed-off-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

2016-03-22 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 01:41:43PM +, David Vrabel wrote: > On 22/03/16 12:55, Bob Liu wrote: > > > > On 03/17/2016 07:12 PM, Ian Jackson wrote: > >> David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document > >> scsi/0x12/0x83 node"): > >>> On 16/03/16 13:59, Bob Liu wrote: >

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

2016-03-22 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 03:12:02PM +, Ian Jackson wrote: > David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document > scsi/0x12/0x83 node"): > > On 22/03/16 14:10, Konrad Rzeszutek Wilk wrote: > > > Just think of it as a black box. > > > &

Re: [Xen-devel] [PATCH v4 06/34] x86/arm: Add BUGFRAME_NR define and BUILD checks.

2016-03-22 Thread Konrad Rzeszutek Wilk
t; ARM case you then may consider removing the preceding blank > line too; in any event the ARM and x86 ones should look similar > in the end.) > Here it is. Last call :-) From f97548200461b9eb4d8187eb9e1f021c74160759 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Thu, 10

Re: [Xen-devel] [PATCH v4 04/34] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-22 Thread Konrad Rzeszutek Wilk
On Mon, Mar 21, 2016 at 06:45:28AM -0600, Jan Beulich wrote: > >>> On 18.03.16 at 20:22, wrote: > >> > + * return the number of bytes requested for the operation. Or an > >> > + * negative value if an error is encountered. > >> > + */ > >> > + > >> > +typedef uint64_t xen_version_op_val_t; > >> >

Re: [Xen-devel] [PATCH v4 03/34] xsm/xen_version: Add XSM for the xen_version hypercall

2016-03-22 Thread Konrad Rzeszutek Wilk
gt; > #endif /* CONFIG_X86 */ > > + > > +#include > > +static XSM_INLINE int xsm_xen_version (XSM_DEFAULT_ARG uint32_t op) > > +{ > > +XSM_ASSERT_ACTION(XSM_OTHER); > > +switch ( op ) > > +{ > > +case XENVER_version: > > +case X

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

2016-03-22 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 04:14:40PM +, Ian Jackson wrote: > Paul Durrant writes ("RE: [Xen-devel] [RFC PATCH] blkif.h: document > scsi/0x12/0x83 node"): > > It's getting hard to parse the thread at this point but, as I've > > mentioned in a previous response in the thread, Windows basically > >

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

2016-03-22 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 04:11:35PM +, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document > scsi/0x12/0x83 node"): > > > I don't think this is a sterile academic conversation which would (if > > > satisfactor

Re: [Xen-devel] [PATCH v4 16/34] xsplice: Implement payload loading

2016-03-22 Thread Konrad Rzeszutek Wilk
.. snip.. > +static void* xsplice_map_rx(const mfn_t *mfn, unsigned int pages) > +{ > +unsigned long cur; > +unsigned long start, end; > + > +start = (unsigned long)avail_virt_start; > +end = start + pages * PAGE_SIZE; > + > +ASSERT(find_space_fnc); > + > +if ( (find_space_f

Re: [Xen-devel] [PATCH v4 04/34] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-22 Thread Konrad Rzeszutek Wilk
> >> > --- a/xen/include/xsm/dummy.h > >> > +++ b/xen/include/xsm/dummy.h > >> > @@ -751,3 +751,22 @@ static XSM_INLINE int xsm_xen_version > >> > (XSM_DEFAULT_ARG uint32_t op) > >> > return xsm_default_action(XSM_PRIV, current->domain, NULL); > >> > } > >> > } > >> > + > >> > +stat

Re: [Xen-devel] [PATCH v4 07/34] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables

2016-03-22 Thread Konrad Rzeszutek Wilk
s > > + * ignored). > > + */ > > +symbols_lookup_t symbols_lookup; > > + > > +struct { > > +struct bug_frame *bugs; /* The pointer to array of bug frames. */ > > +ssize_t n_bugs; /* The number of them. */ > > +} fr

Re: [Xen-devel] [PATCH v4 04/34] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-22 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 07:28:57PM +, Andrew Cooper wrote: > On 22/03/16 18:57, Konrad Rzeszutek Wilk wrote: > >>>>> --- a/xen/include/xsm/dummy.h > >>>>> +++ b/xen/include/xsm/dummy.h > >>>>> @@ -751,3 +751,22 @@ static XSM_INLINE

Re: [Xen-devel] [PATCH] xenconsole: update help message

2016-03-22 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 07:36:58PM +, Wei Liu wrote: > On Tue, Mar 22, 2016 at 12:00:24PM -0500, Doug Goldstein wrote: > > The help message did not include information about the --type parameter. > > > > Signed-off-by: Doug Goldstein > > --- > > CC: Ian Jackson > > CC: Stefano Stabellini >

Re: [Xen-devel] [PATCH v2] docs: update FLASK cmd line instructions

2016-03-22 Thread Konrad Rzeszutek Wilk
On Fri, Mar 18, 2016 at 11:46:03AM -0500, Doug Goldstein wrote: > The command line instructions for FLASK include a note on how to compile > Xen with FLASK but the note was out of date after the change to Kconfig. > > Signed-off-by: Doug Goldstein Reviewed-by: Konrad Rzeszutek Wilk

Re: [Xen-devel] ARMv8: New board bring up hangs in kernel start?

2016-03-23 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 06:24:40PM +0100, Dirk Behme wrote: > Hi, Hey, CC-ing the ARM MAINTAINERs. > > trying to bring up Xen on a new ARMv8 64-bit Cortex A57 eval board, I get > [1] and then its hanging there. > > I'd guess that it hangs due to missing timer interrupt, maybe missing > interru

Re: [Xen-devel] [PATCH] tools/python/xc: fix tmem_control parameter parsing

2016-03-23 Thread Konrad Rzeszutek Wilk
#x27;. > > Signed-off-by: Zhigang Wang Acked-by: Konrad Rzeszutek Wilk > --- > tools/python/xen/lowlevel/xc/xc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/python/xen/lowlevel/xc/xc.c > b/tools/python/xen/lowlevel/xc/xc.c >

Re: [Xen-devel] [PATCH v4 11/34] xsplice: Design document

2016-03-23 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 05:18:39AM -0600, Jan Beulich wrote: > >>> On 15.03.16 at 18:56, wrote: > > +### XEN_SYSCTL_XSPLICE_LIST (2) > > + > > +Retrieve an array of abbreviated status and names of payloads that are > > loaded in the > > +hypervisor. > > + > > +The caller provides: > > + > > + * `

Re: [Xen-devel] [PATCH v4 11/34] xsplice: Design document

2016-03-23 Thread Konrad Rzeszutek Wilk
> diff --git a/docs/misc/xsplice.markdown b/docs/misc/xsplice.markdown > index 6aa5a27..8252e6c 100644 > --- a/docs/misc/xsplice.markdown > +++ b/docs/misc/xsplice.markdown > @@ -487,7 +487,9 @@ hypervisor. > The caller provides: > > * `version`. Initially (on first hypercall) *MUST* be zero.

Re: [Xen-devel] [PATCH v4 04/34] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-23 Thread Konrad Rzeszutek Wilk
ther patch of course.) Here is the updated patch: From 10ecad7469a5ba12895418aa2d035def852654e7 Mon Sep 17 00:00:00 2001 From: Konrad Rzeszutek Wilk Date: Tue, 22 Mar 2016 16:53:19 -0400 Subject: [PATCH] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane. This hypercall mirrors

Re: [Xen-devel] [PATCH v4 07/34] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables

2016-03-23 Thread Konrad Rzeszutek Wilk
s (to guard against somebody else calling > > + * unregister_virtual_region) and list_deletion spiced with an memory > > + * barrier - which will flush out the cache lines in other CPUs. > > I don't think barriers do any kind of cache flushing on remote CPUs > (not eve

Re: [Xen-devel] [PATCH v4 12/34] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op

2016-03-23 Thread Konrad Rzeszutek Wilk
t(list->name, idx * > > XEN_XSPLICE_NAME_SIZE, > > +data->name, len) || > > + __copy_to_guest_offset(list->len, idx, &len, 1) || > > You're not coping the NUL terminator here, which makes the result > mo

Re: [Xen-devel] [PATCH v4 11/34] xsplice: Design document

2016-03-23 Thread Konrad Rzeszutek Wilk
; > +uint32_t nr;/* IN: How many status, names, > > and len > > + should fill out. > > + OUT: How many payloads > > left. */ > > I th

Re: [Xen-devel] [PATCH v4 04/34] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-24 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 03:15:25AM -0600, Jan Beulich wrote: > >>> On 24.03.16 at 03:37, wrote: > >> > --- a/xen/xsm/flask/hooks.c > >> > +++ b/xen/xsm/flask/hooks.c > >> > @@ -1658,6 +1658,40 @@ static int flask_xen_version (uint32_t op) > >> > } > >> > } > >> > > >> > +static int flask_v

Re: [Xen-devel] [PATCH v4 03/34] xsm/xen_version: Add XSM for the xen_version hypercall

2016-03-24 Thread Konrad Rzeszutek Wilk
> >diff --git a/xen/xsm/flask/policy/security_classes > >b/xen/xsm/flask/policy/security_classes > >index ca191db..cde4e1a 100644 > >--- a/xen/xsm/flask/policy/security_classes > >+++ b/xen/xsm/flask/policy/security_classes > >@@ -18,5 +18,6 @@ class shadow > > class event > > class grant > > c

[Xen-devel] [PATCH v5 09/28] xsplice: Add helper elf routines

2016-03-24 Thread Konrad Rzeszutek Wilk
Rzeszutek Wilk --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan v2: - With the #define ELFSIZE in the ARM file we can use the common #defines instead of using #ifdef CONFIG_ARM_32. Moved to another patch. - Add checks for ELF file. - Add name to be printed

[Xen-devel] [PATCH v5 03/28] arm/x86: Use struct virtual_region to do bug, symbol, and (x86) exception tables lookup.

2016-03-24 Thread Konrad Rzeszutek Wilk
search has to only use two public APIs: - register_virtual_region - unregister_virtual_region to let the core code know. If the ->lookup_symbol is not then the default internal symbol lookup mechanism is used. Suggested-by: Andrew Cooper Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Stefano

[Xen-devel] [PATCH v5 18/28] xsplice: Add support for alternatives

2016-03-24 Thread Konrad Rzeszutek Wilk
. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper v2: Make a new alternative function that does not ASSERT on IRQs and don't disable IRQs in the code when loading payload. v4: Include test-case Include check for

[Xen-devel] [PATCH v5 21/28] libxl: info: Display build_id of the hypervisor using XEN_VERSION_build_id

2016-03-24 Thread Konrad Rzeszutek Wilk
If the hypervisor is built with we will display it. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu v2: Include HAVE_*, use libxl_zalloc, s/rc/ret/ v3: Retry with different size if 1020 is not enough. v4: Use VERSION_OP subops

[Xen-devel] [PATCH v5 12/28] x86/xen_hello_world.xsplice: Test payload for patching 'xen_extra_version'.

2016-03-24 Thread Konrad Rzeszutek Wilk
tra xen_extra : Hello World $xen-xsplice revert xen_hello_world Performing revert: completed $xen-xsplice unload xen_hello_world Performing unload: completed $xl info | grep extra xen_extra : -unstable Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Stefano Stabellini Cc

[Xen-devel] [PATCH v5 25/28] xsplice: Print dependency and payloads build_id in the keyhandler.

2016-03-24 Thread Konrad Rzeszutek Wilk
Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- --- xen/common/xsplice.c | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c index d7a65fe..d5d4b3c 100644 --- a/xen/common/xsplice.c

[Xen-devel] [PATCH v5 23/28] xsplice: Stacking build-id dependency checking.

2016-03-24 Thread Konrad Rzeszutek Wilk
. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper v3: First time included. v4: Andrew fix against the build_id.o mutilations. Andrew fix to not include extra symbols in binary.id v5: s/ssize_t/unsigned int/ --- .gitignore

[Xen-devel] [PATCH v5 10/28] xsplice: Implement payload loading

2016-03-24 Thread Konrad Rzeszutek Wilk
or the code. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Stefano Stabellini Cc: Julien Grall Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper v2: - Change the 'xsplice_patch_func' structure layout/size. - Add more error checking. Fix memory le

[Xen-devel] [PATCH v5 17/28] xsplice: Add support for exception tables.

2016-03-24 Thread Konrad Rzeszutek Wilk
ve an exception that is handled. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper v3: - s/module/payload/ - sanity checks. - Move code around. - s/module/payload/ v4: Use 'struct virtual_region' v5: - Expand test

[Xen-devel] [PATCH v5 16/28] xsplice: Add support for bug frames.

2016-03-24 Thread Konrad Rzeszutek Wilk
ed to make sure it has the right value. And will only be triggered if something has gone horribly wrong. P.S. If one really wants to test, insert an WARN_ON(1) at the end of the revert_hook. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Keir Fraser Cc: Jan Beulic

[Xen-devel] [PATCH v5 05/28] xsplice: Design document

2016-03-24 Thread Konrad Rzeszutek Wilk
: Martin Pohlack Jan Beulich Thank you! Input-from: Martin Pohlack Input-from: Jan Beulich Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Ross Lagerwall --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan v1-2: review v3: Split document in v1 and v2 (todo) to

[Xen-devel] [PATCH v5 19/28] build_id: Provide ld-embedded build-ids

2016-03-24 Thread Konrad Rzeszutek Wilk
s the final one). Without this change, the symbol table embedded in Xen are incorrect - some of the values it contains are offset by the size of the included build id. This obviously causes problems when resolving symbols. Suggested-by: Andrew Cooper Signed-off-by: Martin Pohlack Signed-off-

[Xen-devel] [PATCH v5 07/28] libxc: Implementation of XEN_XSPLICE_op in libxc

2016-03-24 Thread Konrad Rzeszutek Wilk
The underlaying toolstack code to do the basic operations when using the XEN_XSPLICE_op syscalls: - upload the payload, - get status of an payload, - list all the payloads, - apply, check, replace, and revert the payload. Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Ross Lagerwall

[Xen-devel] [PATCH v5 06/28] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op

2016-03-24 Thread Konrad Rzeszutek Wilk
'non-lock' variant. Acked-by: Daniel De Graaf Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Ross Lagerwall --- Cc: Daniel De Graaf Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu v2: Rebased on keyhandler: rework keyhandler infrastructure v3: Fixed XSM. - Removed REVERTED sta

[Xen-devel] [PATCH v5 13/28] xsplice, symbols: Implement symbol name resolution on address.

2016-03-24 Thread Konrad Rzeszutek Wilk
which simply overrides a symbol because you could end up with a chain of jumps which is inefficient and may result in the expected function not being executed. Also we include a local definition block in the symbols.c file. Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Ross Lagerwall

[Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-24 Thread Konrad Rzeszutek Wilk
n value as guests cannot survive without them. While we combine some of the common code between XENVER_ and VERSION_ take the liberty of moving pae_extended_cr3 in x86 area. Suggested-by: Andrew Cooper Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Daniel De Graaf [XSM bits] --- Cc: Daniel De Graa

[Xen-devel] [PATCH v5] xSplice v1 design and implementation.

2016-03-24 Thread Konrad Rzeszutek Wilk
xen/include/xsm/xsm.h|6 + xen/xsm/dummy.c |1 + xen/xsm/flask/hooks.c| 44 + xen/xsm/flask/policy/access_vectors | 25 +- 86 files changed, 6547 insertions(+), 284 deletions(-) Konrad Rze

[Xen-devel] [PATCH v5 15/28] xsplice: Add .xsplice.hooks functions and test-case

2016-03-24 Thread Konrad Rzeszutek Wilk
. Furthermore include a test-case for it. Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper v2: Style guide changes v3: Include the test-case - and also re-order this patch --- docs/misc/xsplice.markdown | 21

[Xen-devel] [PATCH v5 20/28] HYPERCALL_version_op: Add VERSION_build_id to retrieve build-id.

2016-03-24 Thread Konrad Rzeszutek Wilk
The VERSION hypercall provides the flexibility to expose the size of the build-id (so the callers can allocate the proper size before trying to retrieve it). It also allows in one nice swoop to retrieve the hypervisor build-id in the provided buffer. Signed-off-by: Konrad Rzeszutek Wilk --- Cc

[Xen-devel] [PATCH v5 02/28] libxc/libxl/python/xenstat/ocaml: Use new XEN_VERSION hypercall

2016-03-24 Thread Konrad Rzeszutek Wilk
), but it also returns an positive value on success (unlike the old one). The positive value is the number of bytes copied in. Note that both Ocaml and xenstat use tabs instead of four spaces so they look quite odd. Signed-off-by: Konrad Rzeszutek Wilk Reviewed-by: Andrew Cooper Tested-by: Andrew

[Xen-devel] [PATCH v5 27/28] xsplice: Add support for shadow variables.

2016-03-24 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Shadow variables are a piece of infrastructure to be used by xsplice modules. They are used to attach a new piece of data to an existing structure in memory. Martin Pohlack also mentions that using the SHADOW_SLOTS of small prime numbers has the advantage of having a simple

[Xen-devel] [PATCH v5 26/28] xsplice: Prevent duplicate payloads from being loaded.

2016-03-24 Thread Konrad Rzeszutek Wilk
From: Ross Lagerwall Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan --- --- xen/common/xsplice.c | 21 + 1 file changed, 21 insertions(+) diff --git a/xen/common/xsplice.c b/xen

[Xen-devel] [PATCH v5 22/28] xsplice: Print build_id in keyhandler and on bootup.

2016-03-24 Thread Konrad Rzeszutek Wilk
As it should be an useful debug mechanism. Signed-off-by: Konrad Rzeszutek Wilk -- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan v2: s/char */const void * v5: s/ssize_t/unsigned int/ --- xen/common/xsplice.c | 12 1 file changed, 12 insertions(+) diff --git a

[Xen-devel] [PATCH v5 11/28] xsplice: Implement support for applying/reverting/replacing patches.

2016-03-24 Thread Konrad Rzeszutek Wilk
e also add BUILD_BUG for the structure - and to make sure that the offsets are correct on both 32 and 64-bit hypervisors (ARM32 and ARM64). Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk -- Cc: Stefano Stabellini Cc: Julien Grall Cc: Keir Fraser Cc: Jan Beulich Cc: And

[Xen-devel] [PATCH v5 04/28] vmap: Add vmalloc_cb and vfree_cb

2016-03-24 Thread Konrad Rzeszutek Wilk
to modify the virtual addresses easily. We also provide the free-ing code path - to use the vunmap_cb to take care of tearing down the virtual addresses. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan v4: New patch. v5: Update per Jan&

[Xen-devel] [PATCH v5 24/28] xsplice/xen_replace_world: Test-case for XSPLICE_ACTION_REPLACE

2016-03-24 Thread Konrad Rzeszutek Wilk
as .xsplice.depends. Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Keir Fraser Cc: Jan Beulich Cc: Andrew Cooper v4: New. Make the objcopy use -S to strip the name. --- --- .gitignore | 1 + xen/arch/x86/test/Makefile | 8 +++ xen/arch/x86

[Xen-devel] [PATCH v5 28/28] MAINTAINERS/xsplice: Add myself and Ross as the maintainers.

2016-03-24 Thread Konrad Rzeszutek Wilk
If you have a patch for xSplice send it our way! Signed-off-by: Ross Lagerwall Signed-off-by: Konrad Rzeszutek Wilk --- Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan v5: Sort them F: fields (Jan) --- --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff

[Xen-devel] [PATCH v5 14/28] x86, xsplice: Print payload's symbol name and payload name in backtraces

2016-03-24 Thread Konrad Rzeszutek Wilk
Xen call trace: [] revert_hook+0x31/0x35 [xen_hello_world] [] xsplice.c#revert_payload+0x86/0xc6 [] check_for_xsplice_work+0x233/0x3cd [] domain.c#continue_idle_domain+0x9/0x1f Which is great if payloads have similar or same symbol names. Signed-off-by: Ross Lagerwall Signed-off-by: Ko

[Xen-devel] [PATCH v5 08/28] xen-xsplice: Tool to manipulate xsplice payloads

2016-03-24 Thread Konrad Rzeszutek Wilk
(load). Also will use the name of the file as the Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Ross Lagerwall Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Stefano Stabellini Cc: Wei Liu v2: - Removed REVERTED state. - Fixed bugs handling XSPLICE_STATUS_PROGRESS. - Split status

Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-24 Thread Konrad Rzeszutek Wilk
On March 24, 2016 4:22:29 PM EDT, Andrew Cooper wrote: >On 24/03/16 20:00, Konrad Rzeszutek Wilk wrote: >> This hypercall mirrors the XENVER_ in that it has similar >functionality. >> However it is designed differently: >> - No compat layer. The data structures are the

Re: [Xen-devel] [PATCH v5 01/28] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-24 Thread Konrad Rzeszutek Wilk
> Thanks! > > And Argh! > > I neglected to change the name of kernel_cache_init as Jan requested. Jan, here is an updated patch. I changed the name to capabilities_cache_init. Sorry about that! From e766ddb37acda16c3adbd65179d532b9381bda8e Mon Sep 17 00:00:00 2001 From: Konrad

Re: [Xen-devel] [PATCH v5 02/28] libxc/libxl/python/xenstat/ocaml: Use new XEN_VERSION hypercall

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 09:24:01PM +, Wei Liu wrote: > On Thu, Mar 24, 2016 at 04:00:14PM -0400, Konrad Rzeszutek Wilk wrote: > [...] > > + > > +static int libxl__xc_version_wrapper(libxl__gc *gc, unsigned int cmd, char > > *buf, ssize_t len, char **dst) > &

Re: [Xen-devel] [PATCH v5 21/28] libxl: info: Display build_id of the hypervisor using XEN_VERSION_build_id

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 04:00:33PM -0400, Konrad Rzeszutek Wilk wrote: > If the hypervisor is built with we will display it. > > Signed-off-by: Konrad Rzeszutek Wilk > Acked-by: Wei Liu Hey Wei, It has you Ack, but I think when I carried over the change (it used to be its own f

Re: [Xen-devel] [PATCH 1/3] xenalyze: handle DOM0 operaions events

2016-03-25 Thread Konrad Rzeszutek Wilk
the SoB and the title fixed) > > Acked-by: George Dunlap > > Sorry it took so long to get to this. > > > > Cc: George Dunlap > > Cc: Ian Jackson > > Cc: Wei Liu > > Cc: Konrad Rzeszutek Wilk > > --- > > Changes from v1: > > *

Re: [Xen-devel] [PATCH 1/2] xen/apic: Provide Xen-specific version of cpu_present_to_apicid APIC op

2016-03-25 Thread Konrad Rzeszutek Wilk
ty, Xen's > cpu_present_to_apicid op should still provide value consistent with its > own xen_apic_read(APIC_ID). > > Signed-off-by: Boris Ostrovsky Reviewed-by: Konrad Rzeszutek Wilk > --- > arch/x86/xen/apic.c | 12 ++-- > 1 files changed, 10 insertions(+),

Re: [Xen-devel] [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead()

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 17, 2016 at 09:03:25AM -0400, Boris Ostrovsky wrote: > This call has always been missing from xen_play dead() but until > recently this was rather benign. With new cpu hotplug framework > however this call is required, otherwise a hot-plugged CPU will not Could you include the commit i

Re: [Xen-devel] [PATCH 1/2] xen/x86: Move irq allocation from Xen smp_op.cpu_up()

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 17, 2016 at 09:33:32AM -0400, Boris Ostrovsky wrote: > Commit ce0d3c0a6fb1 ("genirq: Revert sparse irq locking around > __cpu_up() and move it to x86 for now") reverted irq locking > introduced by commit a89941816726 ("hotplug: Prevent alloc/free > of irq descriptors during cpu up/down"

Re: [Xen-devel] [PATCH v2 1/2] xsm: only define XSM_MAGIC in xsm.h

2016-03-25 Thread Konrad Rzeszutek Wilk
On Fri, Mar 25, 2016 at 11:07:19AM -0400, Daniel De Graaf wrote: > On 03/16/2016 03:18 PM, Doug Goldstein wrote: > >Rather than have XSM_MAGIC set in the global xen/config.h and set in > >xsm.h if it's unset, just set it once in xsm.h since its only used in > >files that already include xsm.h > > >

Re: [Xen-devel] [PATCH 2/2] xen/x86: Call cpu_startup_entry(CPUHP_AP_ONLINE_IDLE) from xen_play_dead()

2016-03-25 Thread Konrad Rzeszutek Wilk
On Fri, Mar 25, 2016 at 11:08:32AM -0400, Boris Ostrovsky wrote: > On 03/25/2016 10:53 AM, Konrad Rzeszutek Wilk wrote: > >On Thu, Mar 17, 2016 at 09:03:25AM -0400, Boris Ostrovsky wrote: > >>This call has always been missing from xen_play dead() but until > >>recently t

Re: [Xen-devel] [GRUB2 PATCH v5 1/4] i386/relocator: Add grub_relocator64_efi relocator

2016-03-25 Thread Konrad Rzeszutek Wilk
boot services without any issues. > > Signed-off-by: Daniel Kiper Reviewed-by: Konrad Rzeszutek Wilk .. with one modification: .. snip.. > diff --git a/grub-core/lib/x86_64/efi/relocator.c > b/grub-core/lib/x86_64/efi/relocator.c > new file mode 100644 > index 000..c93d06

Re: [Xen-devel] [GRUB2 PATCH v5 4/4] multiboot2: Add support for relocatable images

2016-03-25 Thread Konrad Rzeszutek Wilk
gt; This patch does not provide functionality which could do relocations using > ELF relocation data. However, I was asked by Konrad Rzeszutek Wilk and > Vladimir > 'phcoder' Serbinenko to investigate that thing. It looks that relevant > machinery > could be added to existin

Re: [Xen-devel] [PATCH v3 2/4] x86: suppress SMEP and SMAP while running 32-bit PV guest code

2016-03-25 Thread Konrad Rzeszutek Wilk
> @@ -174,10 +174,61 @@ compat_bad_hypercall: > /* %rbx: struct vcpu, interrupts disabled */ > ENTRY(compat_restore_all_guest) > ASSERT_INTERRUPTS_DISABLED > +.Lcr4_orig: > +ASM_NOP8 /* testb $3,UREGS_cs(%rsp) */ > +ASM_NOP2 /* jpe .Lcr4_alt_end */ > +ASM_NOP8 /

Re: [Xen-devel] [PATCH v3 4/4] x86: use 32-bit loads for 32-bit PV guest state reload

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 17, 2016 at 02:04:25AM -0600, Jan Beulich wrote: > This is slightly more efficient than loading 64-bit quantities. > > Signed-off-by: Jan Beulich > Reviewed-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel

Re: [Xen-devel] [PATCH v3 5/4] x86: reduce code size of struct cpu_info member accesses

2016-03-25 Thread Konrad Rzeszutek Wilk
%r##reg Not subq? The GET_STACK_END gets us ..[ edit: missed first time the change to STACK_CPUINFO_FIELD]. Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] pv-grub guest booting fail with recent qemu-xen

2016-03-25 Thread Konrad Rzeszutek Wilk
On Wed, Mar 02, 2016 at 07:16:40AM +, Hao, Xudong wrote: > Hi, > For Xen upstream master branch with commit 1949868d, After updating qemu-xen > version from fcf6ac57 to 2ce1d30e, booting a pv-grub guest will fail. > Attach the guest config file and Xen log. Is this still an issue? I saw an Mi

Re: [Xen-devel] [PATCH 1/6] Flask: Support for ARM xentrace

2016-03-25 Thread Konrad Rzeszutek Wilk
On Wed, Mar 16, 2016 at 01:51:34PM -0700, Benjamin Sanda wrote: > From: bensanda > > Modified to provide support for xentrace on the ARM platform. Added flask > credential to allow dom0 dom_xen mapping and write access for trace buffers. So .. what does that mean? Is that something xentrace re

Re: [Xen-devel] [PATCH 6/6] xentrace: ARM platform timestamp support

2016-03-25 Thread Konrad Rzeszutek Wilk
On Wed, Mar 16, 2016 at 01:51:39PM -0700, Benjamin Sanda wrote: > From: bensanda > > Modified to provide support for xentrace on the ARM platform. Changed > get_cycles() to return the core timestamp tick count for use by the trace > buffer timestamping routines in xentrace. > > Signed-off-by:

Re: [Xen-devel] [RFC PATCH 1/2] build: add debug menu to Kconfig

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 11:48:18AM -0500, Doug Goldstein wrote: > There are a number of debugging options for Xen so the idea is to have a > menu to group them all together. > > Signed-off-by: Doug Goldstein > --- > This is more of an RFC than a merge request. If this seems reasonable I'll > add

Re: [Xen-devel] [RFC PATCH 2/2] build: convert crash_debug to Kconfig

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 11:48:19AM -0500, Doug Goldstein wrote: > Convert the crash_debug option to Kconfig as CONFIG_CRASH_DEBUG. This > was previously togglable on the command line so this adds a message for > users enabling it from the command line to tell them to enable it from > make menuconfi

Re: [Xen-devel] [PATCH v5 0/3] tools: Return failure when the command failed for more xl commands

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 05:17:21PM +, George Dunlap wrote: > Return failure when the command failed for more xl commands: > - mem-set > - cd-insert > > This makes xl more useful for scripting. > > In the case of mem-set, it means first cleaning up > libxl_set_memory_target() to return useful

Re: [Xen-devel] [PATCH v8 1/3] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 01:57:58PM +0800, Quan Xu wrote: Hey! Thanks for the patch! I see that you have __must_check.. But if you check the callchain: iommu_flush_iec_[index|global] -> __iommu_flush_iec->invalidate_sync-> queue_invalidate_wait you will see that the callers of iommu_flush

Re: [Xen-devel] [PATCH v8 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 01:57:59PM +0800, Quan Xu wrote: > If Device-TLB flush timed out, we would hide the target ATS > device and crash the domain owning this ATS device. If impacted > domain is hardware domain, just throw out a warning. > > The hidden device should be disallowed to be further a

Re: [Xen-devel] [PATCH v8 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue

2016-03-25 Thread Konrad Rzeszutek Wilk
On Thu, Mar 24, 2016 at 04:38:05PM +0100, Dario Faggioli wrote: > On Thu, 2016-03-24 at 13:57 +0800, Quan Xu wrote: > > If Device-TLB flush timed out, we would hide the target ATS > > device and crash the domain owning this ATS device. If impacted > > domain is hardware domain, just throw out a war

Re: [Xen-devel] pv-grub guest booting fail with recent qemu-xen

2016-03-28 Thread Konrad Rzeszutek Wilk
On Mon, Mar 28, 2016 at 02:03:35AM +, Hao, Xudong wrote: > > -Original Message- > > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Konrad > > Rzeszutek Wilk > > Sent: Saturday, March 26, 2016 2:58 AM > > To: Hao, Xudong > >

Re: [Xen-devel] [PATCH v8 1/3] VT-d: Reduce spin timeout to 1ms, which can be boot-time changed

2016-03-28 Thread Konrad Rzeszutek Wilk
On Mon, Mar 28, 2016 at 06:27:21AM +, Xu, Quan wrote: > On March 26, 2016 4:07am, Konrad Rzeszutek Wilk > wrote: > > On Thu, Mar 24, 2016 at 01:57:58PM +0800, Quan Xu wrote: > > > > Hey! > > > > Thanks for the patch! > > > > I see that you h

Re: [Xen-devel] [PATCH v8 3/3] VT-d: Fix vt-d Device-TLB flush timeout issue

2016-03-28 Thread Konrad Rzeszutek Wilk
> > > > +list_del(&pdev->domain_list); > > > +pdev->domain = NULL; > > > +pci_hide_existing_device(pdev); > > > +break; > > > +} > > > +} > > > + > > > +pcidevs_unlock(); > > > + > > > +if ( !is_hardware_domain(d) ) > > > +

Re: [Xen-devel] [PATCH v2 2/4] ns16550: enable Pericom controller support

2016-03-28 Thread Konrad Rzeszutek Wilk
use BAR0, and whether to expect a port-I/O or MMIO resource. As > a result pci_uart_config() now gets handed a port index, which it then > maps into a BAR index or an offset into BAR0 depending on the bar0 > flag. > > Signed-off-by: Jan Beulich > Tested-by: Konrad Rzeszutek W

Re: [Xen-devel] [PATCH v2 3/3] libxl: add domain config parameter to force start of qemu

2016-03-28 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 08:29:23AM +0100, Juergen Gross wrote: > Today the device model (qemu) is started for a pv domain only in case > a device requiring qemu is specified in the domain configuration > (qdisk, vfb, channel). If there is no such device the device model > isn't started and hence it

Re: [Xen-devel] [PATCH v2 2/3] libxl: add new pvusb backend "qusb" provided by qemu

2016-03-28 Thread Konrad Rzeszutek Wilk
On Tue, Mar 22, 2016 at 08:29:22AM +0100, Juergen Gross wrote: > Add a new pvusb backend type "qusb" which is provided by qemu. It can > be selected either by specifying the type directly in the configuration > or it is selected automatically by libxl in case there is no "usbback" > driver loaded.

Re: [Xen-devel] [PATCH v3 11/28] xen/x86: Clear dependent features when clearing a cpu cap

2016-03-28 Thread Konrad Rzeszutek Wilk
On Thu, Mar 17, 2016 at 07:56:32PM +, Andrew Cooper wrote: > On 17/03/16 19:51, Konrad Rzeszutek Wilk wrote: > > On Tue, Mar 15, 2016 at 03:35:07PM +, Andrew Cooper wrote: > >> When clearing a cpu cap, clear all dependent features. This avoids having > >

Re: [Xen-devel] [PATCH v4 10/26] xen/x86: Improve disabling of features which have dependencies

2016-03-28 Thread Konrad Rzeszutek Wilk
; > Signed-off-by: Andrew Cooper > Reviewed-by: Jan Beulich Reviewed-by: Konrad Rzeszutek Wilk > --- > v2: Move boolean_param() adjacent to use_xsave in xstate_init() > --- > xen/arch/x86/apic.c | 2 +- > xen/arch/x86/cpu/common.c | 12 +++- > xen/arch/x86/x

Re: [Xen-devel] [PATCH v4 11/26] xen/x86: Improvements to in-hypervisor cpuid sanity checks

2016-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 04:36:14PM +, Andrew Cooper wrote: > Currently, {pv,hvm}_cpuid() has a large quantity of essentially-static logic > for modifying the features visible to a guest. A lot of this can be subsumed > by {pv,hvm}_featuremask, which identify the features available on this > ha

Re: [Xen-devel] [PATCH v4 12/26] x86/cpu: Move set_cpumask() calls into c_early_init()

2016-03-28 Thread Konrad Rzeszutek Wilk
ent changes .. what are those changes? Could you mention the title of the patch perhaps? > will cause the mask MSRs to be context switched per-domain, removing the need > to use the command line parameters for heterogeneous levelling purposes. > > Signed-off-by: Andrew Cooper Besides th

Re: [Xen-devel] [PATCH v4 13/26] x86/cpu: Sysctl and common infrastructure for levelling context switching

2016-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 04:36:16PM +, Andrew Cooper wrote: > A toolstack needs to know how much control Xen has over the visible cpuid > values in PV guests. Provide an explicit mechanism to query what Xen is > capable of. > > This interface will currently report no capabilities. This change

Re: [Xen-devel] [PATCH v4 13/26] x86/cpu: Sysctl and common infrastructure for levelling context switching

2016-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 04:36:16PM +, Andrew Cooper wrote: > A toolstack needs to know how much control Xen has over the visible cpuid > values in PV guests. Provide an explicit mechanism to query what Xen is > capable of. If it is only for PV, why don't you add that subops with that name? >

Re: [Xen-devel] [PATCH v4 14/26] x86/cpu: Rework AMD masking MSR setup

2016-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 04:36:17PM +, Andrew Cooper wrote: > This patch is best reviewed as its end result rather than as a diff, as it > rewrites almost all of the setup. > > On the BSP, cpuid information is used to evaluate the potential available set > of masking MSRs, and they are uncondit

Re: [Xen-devel] [PATCH v4 15/26] x86/cpu: Rework Intel masking/faulting setup

2016-03-28 Thread Konrad Rzeszutek Wilk
> + * Context switch levelling state to the next domain. A parameter of NULL is > + * used to context switch to the default host state, and is used by the > BSP/AP > + * startup code. > + */ > +static void intel_ctxt_switch_levelling(const struct domain *nextd) > +{ > + struct cpuidmasks *the

Re: [Xen-devel] [PATCH v4 16/26] x86/cpu: Context switch cpuid masks and faulting state in context_switch()

2016-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 04:36:19PM +, Andrew Cooper wrote: > A single ctxt_switch_levelling() function pointer is provided > (defaulting to an empty nop), which is overridden in the appropriate > $VENDOR_init_levelling(). > > set_cpuid_faulting() is made private and included within > intel_ctx

Re: [Xen-devel] [PATCH v4 17/26] x86/pv: Provide custom cpumasks for PV domains

2016-03-28 Thread Konrad Rzeszutek Wilk
On Wed, Mar 23, 2016 at 04:36:20PM +, Andrew Cooper wrote: > And use them in preference to cpumask_defaults on context switch. HVM domains Extra space before HVM > must not be masked (to avoid interfering with cpuid calls within the guest), > so always lazily context switch to the host defaul

Re: [Xen-devel] [PATCH v4 18/26] x86/domctl: Update PV domain cpumasks when setting cpuid policy

2016-03-28 Thread Konrad Rzeszutek Wilk
ests, > even though they could be hidden. These flags affect how to interpret other > cpuid leaves which are not maskable. > > Signed-off-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel mailing list Xen-devel@lists.xen.org

  1   2   3   4   5   6   7   8   9   10   >