Re: [Xen-devel] [PATCH 1/3] xen/blkback: fix disconnect while I/Os in flight

2017-05-16 Thread Dietmar Hahn
Am Dienstag, 16. Mai 2017, 08:23:18 schrieb Juergen Gross: > Today disconnecting xen-blkback is broken in case there are still > I/Os in flight: xen_blkif_disconnect() will bail out early without > releasing all resources in the hope it will be called again when > the last request has terminated. T

[Xen-devel] Help with: Xen BUG at timer.c:189

2017-05-19 Thread Dietmar Hahn
Hi list, I'am struggling with a hypervisor panic. The hypervisor version is 4.4.3, yes I know - very old ;-), but the affected code hasn't much changed. The panic was never seen before and occured while booting the system, only dom0 was running. (XEN) Xen BUG at timer.c:189 (XEN) [ Xen-4.4.3_

Re: [Xen-devel] Schedule is live for the Xen Project’s Annual Conference - Discounted Registration closes by end of May

2017-05-30 Thread Dietmar Hahn
Hi Lars, ich habe eine Frage bzgl. der Online-Registrierung. Damit meine Firma die Kosten übernimmt, muss auf der Rechnung letztendlich die Firmenadresse stehen. Gibt es am Ende der Registrierung eine Rechnung die auf die Firma lautet? Danke! Dietmar. Am Donnerstag, 25. Mai 2017, 16:09:40 schri

Re: [Xen-devel] Help with: Xen BUG at timer.c:189

2017-06-07 Thread Dietmar Hahn
Am Freitag, 19. Mai 2017, 06:41:36 schrieb Jan Beulich: > >>> On 19.05.17 at 11:52, wrote: > > I'am struggling with a hypervisor panic. The hypervisor version is 4.4.3, > > yes I know - very old ;-), but the affected code hasn't much changed. > > Well, at the very least I'd expect you to base you

Re: [Xen-devel] Help with: Xen BUG at timer.c:189

2017-06-09 Thread Dietmar Hahn
Am Mittwoch, 7. Juni 2017, 04:28:33 schrieb Jan Beulich: > >>> On 07.06.17 at 11:28, wrote: > > Am Freitag, 19. Mai 2017, 06:41:36 schrieb Jan Beulich: > >> >>> On 19.05.17 at 11:52, wrote: > >> > I'am struggling with a hypervisor panic. The hypervisor version is 4.4.3, > >> > yes I know - very o

Re: [Xen-devel] null domains after xl destroy

2017-04-11 Thread Dietmar Hahn
Am Dienstag, 11. April 2017, 20:03:14 schrieb Glenn Enright: > On 11/04/17 17:59, Juergen Gross wrote: > > On 11/04/17 07:25, Glenn Enright wrote: > >> Hi all > >> > >> We are seeing an odd issue with domu domains from xl destroy, under > >> recent 4.9 kernels a (null) domain is left behind. > > >

Re: [Xen-devel] [PATCH v2 1/2] x86/VPMU: return correct fixed PMC count

2015-11-25 Thread Dietmar Hahn
Am Dienstag 24 November 2015, 15:53:11 schrieb Brendan Gregg: > Fixes a register typo. > > Signed-off-by: Brendan Gregg > --- > xen/arch/x86/cpu/vpmu_intel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Dietmar Hahn > > diff

Re: [Xen-devel] [PATCH v2 2/2] x86/VPMU: implement ipc and arch filter flags

2015-11-26 Thread Dietmar Hahn
Am Dienstag 24 November 2015, 15:53:12 schrieb Brendan Gregg: > This introduces a way to have a restricted VPMU, by specifying one of two > predefined groups of PMCs to make available. For secure environments, this > allows the VPMU to be used without needing to enable all PMCs. > > Signed-off-by:

Re: [Xen-devel] [PATCH v25 04/15] x86/VPMU: Interface for setting PMU mode and flags

2015-07-07 Thread Dietmar Hahn
ned-off-by: Boris Ostrovsky > Acked-by: Daniel De Graaf > > --- > Changes in v25: > * Added (vpmu_features == pmu_params.val) check in > do_xenpmu_op:XENPMU_mode_get You mean in do_xenpmu_op:XENPMU_feature_set I think? Reviewed-by: Dietmar Hahn Dietmar. -- Company details

Re: [Xen-devel] [PATCH v25 07/15] x86/VPMU: Save VPMU state for PV guests during context switch

2015-07-07 Thread Dietmar Hahn
ere) > > Signed-off-by: Boris Ostrovsky > > --- > Changes in v25: > * Replaced is_hvm_vcpu with is_hvm_domain to be consistent with recent changes > to context_switch() Reviewed-by: Dietmar Hahn > > xen/arch/x86/domain.c | 22 ++ > 1 file cha

Re: [Xen-devel] [PATCH v25 08/15] x86/VPMU: When handling MSR accesses, leave fault injection to callers

2015-07-07 Thread Dietmar Hahn
e which register is being written, as opposed to postponing > this > until later. > > Signed-off-by: Boris Ostrovsky > Acked-by: Kevin Tian > --- > Changes in v25: > * Updated commit message to mention reason for changing vpmu_do_msr return > values Reviewed-by:

Re: [Xen-devel] [PATCH v25 10/15] x86/VPMU: Use pre-computed masks when checking validity of MSRs

2015-07-07 Thread Dietmar Hahn
Kevin Tian Reviewed-by: Dietmar Hahn > --- > xen/arch/x86/hvm/vmx/vpmu_core2.c | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c > b/xen/arch/x86/hvm/vmx/vpmu_core2.c > index 089154e..1

Re: [Xen-devel] [PATCH v25 05/15] x86/VPMU: Initialize VPMUs with __initcall

2015-07-08 Thread Dietmar Hahn
Am Freitag 19 Juni 2015, 14:44:36 schrieb Boris Ostrovsky: > Move some VPMU initilization operations into __initcalls to avoid performing > same tests and calculations for each vcpu. > > Signed-off-by: Boris Ostrovsky > Acked-by: Jan Beulich For the Intel/VMX part: Reviewed-b

Re: [Xen-devel] [PATCH v25 06/15] x86/VPMU: Initialize PMU for PV(H) guests

2015-07-08 Thread Dietmar Hahn
Am Freitag 19 Juni 2015, 14:44:37 schrieb Boris Ostrovsky: > Code for initializing/tearing down PMU for PV guests > > Signed-off-by: Boris Ostrovsky > Acked-by: Daniel De Graaf > Acked-by: Jan Beulich > Acked-by: Kevin Tian Reviewed-by: Dietmar Hahn > --- > t

Re: [Xen-devel] [PATCH v25 12/15] x86/VPMU: Handle PMU interrupts for PV(H) guests

2015-07-09 Thread Dietmar Hahn
stored comment in amd_vpmu_save() > * Replaced sizeof(*ctxt) with offsetof() svm_vpmu_initialise()'s memcpy > * Replaced a couple of returns with 'ret=-E...' in do_xenpmu_op() Reviewed-by: Dietmar Hahn > > > xen/arch/x86/hvm/svm/vpmu.c | 92 ++-

Re: [Xen-devel] [PATCH v25 14/15] x86/VPMU: Add privileged PMU mode

2015-07-09 Thread Dietmar Hahn
d-off-by: Boris Ostrovsky > Acked-by: Jan Beulich Reviewed-by: Dietmar Hahn > --- > xen/arch/x86/hvm/vpmu.c | 40 +--- > xen/arch/x86/traps.c | 13 + > xen/include/public/pmu.h | 3 +++ > 3 files changed, 45 insertions(+),

Re: [Xen-devel] [PATCH v25 00/15] x86/PMU: Xen PMU PV(H) support

2015-07-10 Thread Dietmar Hahn
t; (I left AMD multi-counter problem unfixed since what I thought would > be sufficient to fix it did not quite work and I don't want to do > a partial fix) I did some tests with HVM guests on Intel processors so for the vmx part: Tested-by: Dietmar Hahn Many Thanks! Dietmar. --

Re: [Xen-devel] [PATCH v21 11/14] x86/VPMU: Handle PMU interrupts for PV(H) guests

2015-05-18 Thread Dietmar Hahn
Am Freitag 08 Mai 2015, 17:06:11 schrieb Boris Ostrovsky: > Add support for handling PMU interrupts for PV(H) guests. I have only some minor nits below. Reviewed-by: Dietmar Hahn > > VPMU for the interrupted VCPU is unloaded until the guest issues XENPMU_flush > hypercall. Thi

[Xen-devel] [PATCH] VPMU: add lost Intel processor

2015-06-03 Thread Dietmar Hahn
Hi, it seems somewhere the Intel processor cpu family : 6 model : 47 model name : Intel(R) Xeon(R) CPU E7- 8837 @ 2.67GHz got lost. Dietmar. Signed-off-by: Dietmar Hahn diff --git a/xen/arch/x86/hvm/vmx/vpmu_core2.c b/xen/arch/x86/hvm/vmx/vpmu_core2.c index 8ad522a

Re: [Xen-devel] [PATCH 1/2] x86/VPMU: Support only versions 2 and 3 of architectural performance monitoring

2015-12-01 Thread Dietmar Hahn
Am Montag 30 November 2015, 13:38:40 schrieb Boris Ostrovsky: > We need to have at least version 2 since it's the first version to > support various control and status registers (such as > MSR_CORE_PERF_GLOBAL_CTRL) that VPMU relies on always having. > > With explicit testing for PMU version we ca

Re: [Xen-devel] [PATCH v2 0/3] VPMU fixes

2015-12-02 Thread Dietmar Hahn
Am Mittwoch 02 Dezember 2015, 02:20:49 schrieb Tian, Kevin: > > From: Boris Ostrovsky [mailto:boris.ostrov...@oracle.com] > > Sent: Wednesday, December 02, 2015 12:50 AM > > > > * Limit VPMU support to PMU versions 2, 3 and 4 (emulated at version 3 > > level) > > * Always implement family 6 VPMU

Re: [Xen-devel] [PATCH v19 01/14] x86/VPMU: VPMU should not exist when vpmu_initialise() is called

2015-03-19 Thread Dietmar Hahn
Am Dienstag 17 März 2015, 10:53:58 schrieb Boris Ostrovsky: > We don't need to try to destroy it since it can't be already allocated at the > time we try to initialize it. > > Signed-off-by: Boris Ostrovsky > Suggested-by: Andrew Cooper Seems to be already commited. Dietmar. > --- > > Chang

Re: [Xen-devel] [PATCH v19 05/14] x86/VPMU: Interface for setting PMU mode and flags

2015-03-19 Thread Dietmar Hahn
nt to > XENPMU_MODE_OFF. > Any other value, on the other hand, will cause VPMU mode to be set to > XENPMU_MODE_SELF during boot. > > For feature flags only Intel's BTS is currently supported. > > Mode and flags are set via HYPERVISOR_xenpmu_op hypercall. > > Sign

Re: [Xen-devel] [PATCH v19 05/14] x86/VPMU: Interface for setting PMU mode and flags

2015-03-19 Thread Dietmar Hahn
Am Donnerstag 19 März 2015, 13:28:56 schrieb Jan Beulich: > >>> On 19.03.15 at 14:12, wrote: > > Am Dienstag 17 März 2015, 10:54:02 schrieb Boris Ostrovsky: > >> +case XENPMU_feature_get: > > > > memset(&pmu_params, 0, sizeof(pmu_params)); ? > > > >> +pmu_params.val = vpmu_features;

Re: [Xen-devel] [PATCH v19 00/14] x86/PMU: Xen PMU PV(H) support

2015-03-19 Thread Dietmar Hahn
Am Dienstag 17 März 2015, 10:53:57 schrieb Boris Ostrovsky: > > Changes in v19: > > * Do not allow changing mode to/from OFF/ALL while guests are > running. This significantly simplifies code due > to large number of corner cases that I had to deal with. Most of the > changes are in patch#5

Re: [Xen-devel] [PATCH v19 12/14] x86/VPMU: Merge vpmu_rdmsr and vpmu_wrmsr

2015-03-25 Thread Dietmar Hahn
uint64_t supported, bool_t is_write) > { > -struct vcpu *curr = current; > +struct vcpu *curr; > struct vpmu_struct *vpmu; > +const struct arch_vpmu_ops *ops; What is this const useful for in this small function? Reviewed-by: Dietmar Ha

Re: [Xen-devel] [PATCH v19 12/14] x86/VPMU: Merge vpmu_rdmsr and vpmu_wrmsr

2015-03-25 Thread Dietmar Hahn
Am Mittwoch 25 März 2015, 09:29:14 schrieb Dietmar Hahn: > Am Dienstag 17 März 2015, 10:54:09 schrieb Boris Ostrovsky: > > The two routines share most of their logic. > > > > Signed-off-by: Boris Ostrovsky > > --- > > Changes in v19: > > * const-ified a

Re: [Xen-devel] [PATCH v19 13/14] x86/VPMU: Add privileged PMU mode

2015-03-25 Thread Dietmar Hahn
d-off-by: Boris Ostrovsky Reviewed-by: Dietmar Hahn Dietmar. > --- > Changes in v19: > * Slightly different mode changing logic in xenpmu_op() since we no longer > allow mode changes while VPMUs are active > > xen/arch/x86/hvm/vpmu.c | 34 +-

Re: [Xen-devel] [PATCH v18 05/16] x86/VPMU: Interface for setting PMU mode and flags

2015-02-18 Thread Dietmar Hahn
Am Montag 16 Februar 2015, 17:26:48 schrieb Boris Ostrovsky: > Add runtime interface for setting PMU mode and flags. Three main modes are > provided: > * XENPMU_MODE_OFF: PMU is not virtualized > * XENPMU_MODE_SELF: Guests can access PMU MSRs and receive PMU interrupts. > * XENPMU_MODE_HV: Same as

Re: [Xen-devel] Branch Trace Storage for guests and VPMUinitialization

2015-02-26 Thread Dietmar Hahn
Am Mittwoch 25 Februar 2015, 11:31:31 schrieb Boris Ostrovsky: > On 02/25/2015 10:12 AM, kevin.ma...@gdata.de wrote: > >> -Ursprüngliche Nachricht- > >> Von: Boris Ostrovsky [mailto:boris.ostrov...@oracle.com] > >> Gesendet: Dienstag, 24. Februar 2015 18:13 > >> An: Mayer, Kevin; xen-devel@

Re: [Xen-devel] [PATCH for 4.6] x86/VPMU: Set VPMU context pointer to NULL when freeing it

2015-09-09 Thread Dietmar Hahn
Am Dienstag 08 September 2015, 22:55:52 schrieb Boris Ostrovsky: > Otherwise we may hit assertion in vpmu_initialise() if vcpu is offlined > and then onlined again. > > For tidyness, set priv_context to NULL as well. Reviewed-by: Dietmar Hahn > > Signed-off-by: Boris Ostro

Re: [Xen-devel] [PATCH v16 00/23] x86/PMU: Xen PMU PV(H) support

2014-12-18 Thread Dietmar Hahn
Am Mittwoch 17 Dezember 2014, 10:38:31 schrieb Boris Ostrovsky: > Version 16 of PV(H) PMU patches. Hi Boris, I did a fast and simple test on a small Intel machine and all went fine. I'll do some more after my vacation in 2015. After adapting your sent linux kernel patches I'am interestet in traci

[Xen-devel] Wrong cpupool handling

2014-11-11 Thread Dietmar Hahn
Hi list, When creating a cpupool, starting and destroying a guest within this pool, then removing this pool doesn't work because of EBUSY. It seems the cause of this behavior is the commit bac6334b51d9bcfe57ecf4a4cb5288348fcf044a. In domain_kill() the function sched_move_domain() gets called cha

Re: [Xen-devel] Wrong cpupool handling

2014-11-12 Thread Dietmar Hahn
Am Dienstag 11 November 2014, 15:21:01 schrieb Juergen Gross: > Hi again, > > On 11/11/2014 01:18 PM, Dietmar Hahn wrote: > > Hi list, > > > > When creating a cpupool, starting and destroying a guest within this pool, > > then removing this pool doesn't work

Re: [Xen-devel] Wrong cpupool handling

2014-11-12 Thread Dietmar Hahn
Am Mittwoch 12 November 2014, 11:25:14 schrieb Juergen Gross: > On 11/12/2014 10:53 AM, Dietmar Hahn wrote: > > Am Dienstag 11 November 2014, 15:21:01 schrieb Juergen Gross: > >> Hi again, > >> > >> On 11/11/2014 01:18 PM, Dietmar Hahn wrote: > >>&