Re: [Xen-devel] [PATCH] xen/events: Mask a moving irq

2016-03-20 Thread David Vrabel
On 17/03/16 16:53, Boris Ostrovsky wrote: > On 03/17/2016 12:03 PM, David Vrabel wrote: >> On 17/03/16 12:45, Boris Ostrovsky wrote: >>> Moving an unmasked irq may result in irq handler being invoked on both >>> source and target CPUs. >>> >>> With 2

Re: [Xen-devel] [PATCH v2 5/6] virt, sched: add cpu pinning to smp_call_sync_on_phys_cpu()

2016-03-21 Thread David Vrabel
On 21/03/16 13:42, Jan Beulich wrote: > > Also don't you need to call smp_processor_id() after preempt_disable()? I suggest using get_cpu()/put_cpu() here. David ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 0/5] xen: avoid module usage in non-modular code

2016-03-21 Thread David Vrabel
On 20/03/16 00:23, Paul Gortmaker wrote: > [[PATCH v2 0/5] xen: avoid module usage in non-modular code] On 21/02/2016 > (Sun 19:06) Paul Gortmaker wrote: > >> This series of commits is a part of a larger project to ensure >> people don't reference modular support functions in non-modular >> code.

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

2016-03-22 Thread David Vrabel
On 22/03/16 12:55, Bob Liu wrote: > > On 03/17/2016 07:12 PM, Ian Jackson wrote: >> David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document >> scsi/0x12/0x83 node"): >>> On 16/03/16 13:59, Bob Liu wrote: >>>> But we'd like t

Re: [Xen-devel] [RFC PATCH] blkif.h: document scsi/0x12/0x83 node

2016-03-22 Thread David Vrabel
On 22/03/16 14:10, Konrad Rzeszutek Wilk wrote: > On Tue, Mar 22, 2016 at 01:41:43PM +0000, David Vrabel wrote: >> On 22/03/16 12:55, Bob Liu wrote: >>> >>> On 03/17/2016 07:12 PM, Ian Jackson wrote: >>>> David Vrabel writes ("Re: [Xen-devel] [RFC PATCH]

[Xen-devel] [GIT PULL] xen: features and fixes for 4.6-rc0

2016-03-22 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.6-rc0-tag xen: features and fixes for 4.6-rc0 - - Make earlyprintk=xen work for HVM guests. - - Remove module support for things neve

Re: [Xen-devel] [PATCH] tools: fix xen-detect to correctly identify domU type

2016-03-23 Thread David Vrabel
On 23/03/16 10:25, Jan Beulich wrote: On 23.03.16 at 11:14, wrote: >> 7. Report type according to features found (this is a little bit >>ugly: we have to rely on the current hypervisor implementation >>regarding the bits set for the different guest types). > > Well, in some of the ca

Re: [Xen-devel] [PATCH] tools: fix xen-detect to correctly identify domU type

2016-03-23 Thread David Vrabel
On 23/03/16 10:55, Andrew Cooper wrote: > On 23/03/16 10:52, Juergen Gross wrote: >> On 23/03/16 11:32, David Vrabel wrote: >>> On 23/03/16 10:25, Jan Beulich wrote: >>>>>>> On 23.03.16 at 11:14, wrote: >>>>> 7. Report type according to featu

Re: [Xen-devel] [PATCH] tools: fix xen-detect to correctly identify domU type

2016-03-23 Thread David Vrabel
On 23/03/16 11:12, Andrew Cooper wrote: > On 23/03/16 10:59, David Vrabel wrote: >> On 23/03/16 10:55, Andrew Cooper wrote: >>> On 23/03/16 10:52, Juergen Gross wrote: >>>> On 23/03/16 11:32, David Vrabel wrote: >>>>> On 23/03/16 10:25, Jan Beulich

Re: [Xen-devel] [PATCH] tools: fix xen-detect to correctly identify domU type

2016-03-24 Thread David Vrabel
On 23/03/16 19:03, Juergen Gross wrote: > On 23/03/16 12:25, Andrew Cooper wrote: >> On 23/03/16 11:18, David Vrabel wrote: >>> On 23/03/16 11:12, Andrew Cooper wrote: >>>> On 23/03/16 10:59, David Vrabel wrote: >>>>> On 23/03/16 10:55, Andrew Cooper w

Re: [Xen-devel] [PATCH] spinlock: improve spin_is_locked() for recursive locks

2016-03-24 Thread David Vrabel
On 24/03/16 11:30, Jan Beulich wrote: > Recursive locks know their current owner, and since we use the function > solely to determine whether a particular lock is being held by the > current CPU (which so far has been an imprecise check), make actually > check the owner for recusrively acquired loc

[Xen-devel] [GIT PULL] xen: regression and bug fixes for 4.6-rc2

2016-04-04 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.6-rc2-tag xen: regression and bug fixes for 4.6-rc2 - - Safely migrate event channels between CPUs. - - Fix CPU hotplug. - - Maintain

Re: [Xen-devel] [PATCH] xen: write information about supported backends

2016-04-04 Thread David Vrabel
On 30/03/16 15:10, Juergen Gross wrote: > Add a Xenstore directory for each supported pv backend. This will allow > Xen tools to decide which backend type to use in case there are > multiple possibilities. > > The information is added under > /local/domain//device-model//backends > before the "run

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-04 Thread David Vrabel
On 04/04/16 17:21, Julien Grall wrote: > (CC Stefano new e-mail address) > > Hello Anna-Maria, > > On 04/04/2016 13:32, Anna-Maria Gleixner wrote: >> Xen guests do not offline/online CPUs during suspend/resume and >> therefore FROZEN notifier transitions are not required. Add this >> explanation

Re: [Xen-devel] [PATCH v5 7/9] x86/paravirt: Add paravirt_{read, write}_msr

2016-04-04 Thread David Vrabel
dmsrl, wrmsrl, etc. > > I intentionally didn't make them warn on #GP on Xen. I think that > should be done separately by the Xen maintainers. ... > --- a/arch/x86/xen/enlighten.c > +++ b/arch/x86/xen/enlighten.c Reviewed-by: David Vrabel > @@ -1092,6 +1092,26 @@ stati

Re: [Xen-devel] [PATCH v4 1/6] xen: sync xen header

2016-04-05 Thread David Vrabel
On 05/04/16 06:10, Juergen Gross wrote: > Import the actual version of include/xen/interface/sched.h from Xen. Acked-by: David Vrabel David ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu

2016-04-05 Thread David Vrabel
On 05/04/16 06:10, Juergen Gross wrote: > Some hardware models (e.g. Dell Studio 1555 laptops) require calls to > the firmware to be issued on cpu 0 only. As Dom0 might have to use > these calls, add xen_pin_vcpu() to achieve this functionality. > > In case either the domain doesn't have the privi

Re: [Xen-devel] [PATCH v4 4/6] xen: add xen_pin_vcpu() to support calling functions on a dedicated pcpu

2016-04-05 Thread David Vrabel
On 05/04/16 11:01, Juergen Gross wrote: > > No, I don't think this is a good idea. In the EINVAL or EBUSY case a > simple Xen admin command might be enough to make the next call succeed. > I don't want to disable pinning in this case. Ok. Acked-by

Re: [Xen-devel] HVMLite / PVHv2 - using x86 EFI boot entry

2016-04-06 Thread David Vrabel
On 06/04/16 03:40, Luis R. Rodriguez wrote: > > * You don't need full EFI emulation I think needing any EFI emulation inside Xen (which is where it would need to be for dom0) is not suitable because of the increase in hypervisor ABI. I also still do not understand your objection to the curre

Re: [Xen-devel] [PATCH 2/2] xen/balloon: Fix crash when ballooning on x86 32 bit PAE

2016-04-06 Thread David Vrabel
These two have been applied to for-linus-4.6, thanks. I tagged them for stable since they are regression in 4.4. On 17/03/16 16:52, Ross Lagerwall wrote: > When ballooning on an x86 32 bit PAE system with close to 64 GiB of memory, > the > address returned by allocate_resource may be above 64 Gi

Re: [Xen-devel] [PATCH] xen: Add comment for missing FROZEN notifier transitions

2016-04-06 Thread David Vrabel
t considered. > > Cc: David Vrabel > Cc: Stefano Stabellini > Cc: xen-de...@lists.xenproject.org > Signed-off-by: Anna-Maria Gleixner > --- > arch/arm/xen/enlighten.c |6 ++ > arch/x86/xen/enlighten.c |7 +++ > drivers/xen/events

Re: [Xen-devel] [PATCH v4 02/14] x86/xen: use X86_SUBARCH_XEN for PV guest boots

2016-04-07 Thread David Vrabel
On 07/04/16 01:06, Luis R. Rodriguez wrote: > The use of subarch should have no current effect on Xen > PV guests, as such this should have no current functional > effects. Reviewed-by: David Vrabel David ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v4 04/14] x86/rtc: replace paravirt rtc check with platform legacy quirk

2016-04-07 Thread David Vrabel
of these into a platform specific legacy > quirk set early in boot through i386_start_kernel() and through > x86_64_start_reservations(). This deals with the RTC quirks which > we can rely on through the hardware subarch, the ACPI check can > be dealt with separately. Xen parts

Re: [Xen-devel] [PATCH v4 06/14] x86/init: use a platform legacy quirk for ebda

2016-04-07 Thread David Vrabel
On 07/04/16 01:06, Luis R. Rodriguez wrote: > > --- a/arch/x86/kernel/platform-quirks.c > +++ b/arch/x86/kernel/platform-quirks.c > @@ -7,8 +7,12 @@ > void __init x86_early_init_platform_quirks(void) > { > x86_platform.legacy.rtc = 1; > + x86_platform.legacy.ebda_search = 0; You shoul

Re: [Xen-devel] [PATCH v4 11/14] pnpbios: replace paravirt_enabled() check with legacy device check

2016-04-07 Thread David Vrabel
On 07/04/16 01:06, Luis R. Rodriguez wrote: > Since we are removing paravirt_enabled() replace it with a > logical equivalent. Even though PNPBIOS is x86 specific we > add an arch-specific type call, which can be implemented by > any architecture to show how other legacy attribute devices > can lat

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

2016-04-08 Thread David Vrabel
On 07/04/16 11:00, Bob Liu wrote: > * What's data integrity extension and why? > Modern filesystems feature checksumming of data and metadata to protect > against > data corruption. However, the detection of the corruption is done at read > time > which could potentially be months after the data

Re: [Xen-devel] [RFC PATCH] Data integrity extension support for xen-block

2016-04-08 Thread David Vrabel
On 08/04/16 15:20, Ian Jackson wrote: > David Vrabel writes ("Re: [RFC PATCH] Data integrity extension support for > xen-block"): >> You need to read the relevant SCSI specification and find out what >> interfaces and behaviour the hardware has so you can specify compa

Re: [Xen-devel] [PATCH] x86/mm/pat: Fix BUG_ON in mmap_mem on QEMU/i386

2016-04-08 Thread David Vrabel
On 08/04/16 17:34, Toshi Kani wrote: > On Tue, 2016-04-05 at 09:24 -0600, Toshi Kani wrote: >> +xen-devl >> >> On Tue, 2016-04-05 at 13:09 +0200, Borislav Petkov wrote: >>> On Fri, Apr 01, 2016 at 04:19:45PM -0600, Toshi Kani wrote: > : When the system does not have much memory, 'hi

Re: [Xen-devel] [PATCH v2 2/3] xenfb: move xen_rmb to the correct location

2016-04-12 Thread David Vrabel
On 12/04/16 11:43, Wei Liu wrote: > It should be placed before first time producer and consumer are used. This change isn't necessary and is confusing as this is not what this barrier is for. The barrier needs to be between the load of prod and the load of the ring contents (there's even a commen

Re: [Xen-devel] [PATCHv7] x86/ept: defer the invalidation until the p2m lock is released

2016-04-12 Thread David Vrabel
On 03/02/16 03:44, Tian, Kevin wrote: >> From: David Vrabel [mailto:david.vra...@citrix.com] >> Sent: Tuesday, February 02, 2016 12:27 AM Looks like I forgot about this patch. >> It is safe to defer the invalidate until the p2m lock is released >> except for two cases:

[Xen-devel] [PATCHv8 0/1] x86/ept: reduce translation invalidation impact

2016-04-12 Thread David Vrabel
This series improves the performance of EPT by further reducing the impact of the translation invalidations (ept_sync_domain()). By: a) Deferring invalidations until the p2m write lock is released. Prior to this change a 16 VCPU guest could not be successfully migrated on an (admittedly slow) 160

[Xen-devel] [PATCHv8] x86/ept: defer the invalidation until the p2m lock is released

2016-04-12 Thread David Vrabel
freeing a page table page (since partial translations may be cached). 2. When reclaiming a zero page as part of PoD. For these cases, add p2m_tlb_flush_sync() calls which will immediately perform the invalidate before the page is freed or reclaimed. Signed-off-by: David Vrabel --- v8

Re: [Xen-devel] [for-4.7] x86/emulate: synchronize LOCKed instruction emulation

2016-04-14 Thread David Vrabel
On 13/04/16 13:26, Razvan Cojocaru wrote: > LOCK-prefixed instructions are currenly allowed to run in parallel > in x86_emulate(), which can lead the guest into an undefined state. > This patch fixes the issue. Is this sufficient? What if another VCPU is running on another PCPU and doing an unemu

Re: [Xen-devel] [PATCHv8] x86/ept: defer the invalidation until the p2m lock is released

2016-04-19 Thread David Vrabel
operations, including plenty of uses of PoD. Thanks. David On 12/04/2016 17:19, David Vrabel wrote: > Holding the p2m lock while calling ept_sync_domain() is very expensive > since it does an on_selected_cpus() call. IPIs on many socket > machines can be very slow and on_selected_cpus() is ser

[Xen-devel] [Hackathon] Restartable driver domains and restartable dom0 notes

2016-04-19 Thread David Vrabel
Restartable driver domains and dom0 --- Jeurgen: See XenSummit presentation. - Xenstore Domain (bits missing in libxl) - Looking at driver domains next. One domain per backend or several backends in one domain. Drivers crash -> restart driver domains while guests

Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread David Vrabel
On 20/04/16 08:26, Bob Liu wrote: > > /* > + * Recognized only if "feature-data-integrity" is present in backend xenbus > info. > + * A request with BLKIF_OP_DIX_FLAG indicates the following request is a > special > + * request which only contains integrity-metadata segments of current > reque

Re: [Xen-devel] [RFC PATCH v2] Data integrity extension(DIX) support for xen-block

2016-04-20 Thread David Vrabel
On 20/04/16 13:08, Bob Liu wrote: > > > The "feature-data-integrity" could be extended to "unsigned int" instead of > "bool", > so as to report all DIX formats backend supports. I think it would be preferable to have something string based. I think Linux reports the formats using a string enco

Re: [Xen-devel] [tip:x86/asm] x86/mm/xen: Suppress hugetlbfs in PV guests

2016-04-25 Thread David Vrabel
On 25/04/16 08:52, Thomas Gleixner wrote: > On Mon, 25 Apr 2016, Jan Beulich wrote: > On 22.04.16 at 20:03, wrote: +#define hugepages_supported() cpu_has_pse >>> >>> Please don't use the cpu_has_* macros anymore, they are going away soon. >>> >>> In this case it should be static_cp

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread David Vrabel
On 24/04/16 21:23, Borislav Petkov wrote: > On Mon, Feb 01, 2016 at 10:38:48AM -0500, Boris Ostrovsky wrote: >> Start HVMlite guest at XEN_ELFNOTE_PHYS32_ENTRY address. Setup hypercall >> page, initialize boot_params, enable early page tables. >> >> Since this stub is executed before kernel entry p

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 06:02, Juergen Gross wrote: > On 21/04/16 11:30, Stefano Stabellini wrote: >> On Thu, 21 Apr 2016, Juergen Gross wrote: >>> On 20/04/16 15:15, Stefano Stabellini wrote: b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number of legacy interrupts when actually

Re: [Xen-devel] [PATCH] xen/x86: actually allocate legacy interrupts on PV guests

2016-04-27 Thread David Vrabel
On 27/04/16 14:38, Boris Ostrovsky wrote: > > int xen_nr_legacy_irqs() > { > if (xen_hvm_domain()) > return nr_legacy_irqs(); > if (xen_initial_domain()) > return NR_IRQS_LEGACY; > return 0; > } Yeah, if that does the right thing... David

Re: [Xen-devel] pvops xen_blkfront does not enforce device names

2016-04-29 Thread David Vrabel
On 29/04/16 08:29, Jan Beulich wrote: On 29.04.16 at 08:45, wrote: >> On Tue, Apr 26, 2016 at 03:28:45PM +0200, Olaf Hering wrote: >>> Why does xen_blkfront not enforce kernel device names from domU.cfg? >>> In my PV domU.cfg I still have something like this: >>> disk=[ 'file:/path,hda,w' ] >

Re: [Xen-devel] Returning errno values inside of hypercall structs (was: Re: [PATCH for-4.7 3/4] tools/xsplice: fix mixing system)

2016-05-03 Thread David Vrabel
On 29/04/16 17:16, Roger Pau Monne wrote: > > It has also been suggested that the privcmd driver simply doesn't translate > error codes at all, and then let the applications figure out if the error > code comes from Xen or from the OS. IMHO, this is impossible to achieve, > because the ioctl sy

[Xen-devel] [PATCHv1 for-4.7] x86: show correct code in CPU state

2016-05-03 Thread David Vrabel
e0 04 <48> 03 04 f1 8b ... When coping the bytes before RIP, the destination was off-by-one. Signed-off-by: David Vrabel --- xen/arch/x86/traps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index 8384158..0895441 100644 --

Re: [Xen-devel] evtchn_resize_ring() serialization

2016-05-04 Thread David Vrabel
On 04/05/16 14:08, Jan Beulich wrote: > David, > > in the course of putting together the fix just sent I got puzzled by the > apparent raciness of the initial part of evtchn_resize_ring(). Is it > intentional that the function relies on being implicitly serialized via the > bind mutex? Yes. Alth

Re: [Xen-devel] [PATCH] xen: fix ring resize of /dev/evtchn

2016-05-04 Thread David Vrabel
On 04/05/16 14:02, Jan Beulich wrote: > The copying of ring data was wrong for two cases: For a full ring > nothing got copied at all (as in that case the canonicalized producer > and consumer indexes are identical). And in case one or both of the > canonicalized (after the resize) indexes would po

Re: [Xen-devel] evtchn_resize_ring() serialization

2016-05-04 Thread David Vrabel
On 04/05/16 14:38, Jan Beulich wrote: On 04.05.16 at 15:14, wrote: >> On 04/05/16 14:08, Jan Beulich wrote: >>> David, >>> >>> in the course of putting together the fix just sent I got puzzled by the >>> apparent raciness of the initial part of evtchn_resize_ring(). Is it >>> intentional that

Re: [Xen-devel] [PATCH] xen: fix ring resize of /dev/evtchn

2016-05-04 Thread David Vrabel
On 04/05/16 14:30, David Vrabel wrote: > On 04/05/16 14:02, Jan Beulich wrote: >> The copying of ring data was wrong for two cases: For a full ring >> nothing got copied at all (as in that case the canonicalized producer >> and consumer indexes are identical). And in ca

[Xen-devel] [GIT PULL] xen: regression fixes for 4.6-rc6

2016-05-04 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.6-rc6-tag xen: regression fixes for 4.6-rc6 - - Fix two regressions causing crashes in 32-bit PV guests. - - Fix a regression in the

Re: [Xen-devel] Debugging Xen early boot

2016-05-06 Thread David Vrabel
On 06/05/16 13:31, Zytaruk, Kelly wrote: > > As for the other question I am still curious as to how to debug > early Xen. How was __start_xen written and tested, what sort of tools were > used to debug it and get it working right? What do I do in situations > where I absolutely can't get serial wo

Re: [Xen-devel] [PATCH 1/1] xen/gntdev: kmalloc structure gntdev_copy_batch

2016-05-09 Thread David Vrabel
bytes. This should have minimal impact on performance. Signed-off-by: David Vrabel --- drivers/xen/gntdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index dc49538..6793957 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntde

Re: [Xen-devel] [PATCH for-4.7 2/4] x86/hvm: Raise #SS faults for %ss-based segmentation violations

2016-05-09 Thread David Vrabel
On 09/05/16 14:15, Andrew Cooper wrote: > Raising #GP under such circumstances is architecturally wrong. You should include a reference to the relevant Intel and AMD manuals here. David > --- > CC: Jan Beulich > CC: Tim Deegan > CC: Paul Durrant > CC: Wei Liu > --- > xen/arch/x86/hvm/emulat

Re: [Xen-devel] crash on boot with 4.6.1 on fedora 24

2016-05-11 Thread David Vrabel
On 11/05/16 08:00, Juergen Gross wrote: > On 11/05/16 08:35, Jan Beulich wrote: > On 11.05.16 at 07:49, wrote: >>> On 10/05/16 18:35, Boris Ostrovsky wrote: On 05/10/2016 11:43 AM, Juergen Gross wrote: > On 10/05/16 17:35, Jan Beulich wrote: > On 10.05.16 at 17:19, wrote: >>>

Re: [Xen-devel] crash on boot with 4.6.1 on fedora 24

2016-05-11 Thread David Vrabel
On 11/05/16 13:21, Jan Beulich wrote: On 11.05.16 at 12:16, wrote: >> On 11/05/16 08:00, Juergen Gross wrote: >>> Adding David as he removed _PAGE_IOMAP in kernel 3.18. >> >> Why don't we get the RW bits correct when making the pteval when we >> already have the pfn, instead trying to fix it

[Xen-devel] [PATCHv1 1/2] libfs: allow simple_fill_super() to add symlinks

2016-05-16 Thread David Vrabel
simple_fill_super() will add symlinks if an entry has mode & S_IFLNK. The target is provided in the new "link" field. Signed-off-by: David Vrabel --- fs/libfs.c | 23 --- include/linux/fs.h | 2 +- 2 files changed, 21 insertions(+), 4 deletions(-) d

[Xen-devel] [PATCHv1 0/2] xen/xenfs: fix /proc/xen/xenbus

2016-05-16 Thread David Vrabel
"Fix" /proc/xen/xenbus by making it a symlink to the working /dev/xen/xenbus. Do the same for /proc/xen/privcmd so it matches. If there's agreement on this approach I'll resend to Cc the fs maintainers. David ___ Xen-devel mailing list Xen-devel@list

[Xen-devel] [PATCHv1 2/2] xen/xenfs: replace xenbus and privcmd with symlinks

2016-05-16 Thread David Vrabel
devices /dev/xen/xenbus and /dev/xen/privcmd so replace the files with symlinks. Signed-off-by: David Vrabel --- drivers/xen/xenfs/super.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/xen/xenfs/super.c b/drivers/xen/xenfs/super.c index 8559a71..09c239e 100644

[Xen-devel] [PATCHv1 2/2] xenfs: replace xenbus and privcmd with symlinks

2016-05-17 Thread David Vrabel
identical to the character device /dev/xen/xenbus so replace the file with a symlink. Similarly, replace /proc/xen/privcmd with a symlink since it should be the same as /dev/xen/privcmd. Signed-off-by: David Vrabel --- v2: - remove unneeded includes --- drivers/xen/xenfs/super.c | 10 -- 1

[Xen-devel] [PATCHv1 1/2] libfs: allow simple_fill_super() to add symlinks

2016-05-17 Thread David Vrabel
simple_fill_super() will add symlinks if an entry has mode & S_IFLNK. The target is provided in the new "link" field. Signed-off-by: David Vrabel --- v2: - simplified. --- fs/libfs.c | 15 +-- include/linux/fs.h | 2 +- 2 files changed, 14 insertions(+

[Xen-devel] libfs,xenfs: replace /proc/xen/xenbus with a symlink

2016-05-17 Thread David Vrabel
Using /proc/xen/xenbus can cause deadlocks on the atomic file position mutex since this file should behave like a character device and not a regular file. This is easiest to achive by making it a symlink to the existing /dev/xen/xenbus device. This requires extending simple_fill_super() to add sy

Re: [Xen-devel] [GIT PULL] EFI ARM Xen support

2016-05-17 Thread David Vrabel
On 17/05/16 11:12, Stefano Stabellini wrote: > On Sat, 14 May 2016, Matt Fleming wrote: >> Folks, >> >> Please pull the following branch which contains support for Xen on ARM >> EFI platforms. >> >> This merge includes a merge of Stefano's xen/linux-next branch to pull >> in the prerequisites requi

Re: [Xen-devel] crash on boot with 4.6.1 on fedora 24

2016-05-17 Thread David Vrabel
On 11/05/16 11:16, David Vrabel wrote: > > Why don't we get the RW bits correct when making the pteval when we > already have the pfn, instead trying to fix it up afterwards. Kevin, can you try this patch. David 8<- x86/xen: avoid m2p lookup when setting

Re: [Xen-devel] [PATCH] xen: add steal_clock support on x86

2016-05-18 Thread David Vrabel
On 18/05/16 16:42, Juergen Gross wrote: > On 18/05/16 17:25, Boris Ostrovsky wrote: >> On 05/18/2016 10:53 AM, Juergen Gross wrote: >>> On 18/05/16 16:46, Boris Ostrovsky wrote: On 05/18/2016 08:15 AM, Juergen Gross wrote: > } > > +void __init xen_time_setup_guest(void) > +{

Re: [Xen-devel] [PATCH] xen: add steal_clock support on x86

2016-05-18 Thread David Vrabel
On 18/05/16 16:51, Juergen Gross wrote: > On 18/05/16 17:45, David Vrabel wrote: >> On 18/05/16 16:42, Juergen Gross wrote: >>> On 18/05/16 17:25, Boris Ostrovsky wrote: >>>> On 05/18/2016 10:53 AM, Juergen Gross wrote: >>>>> On 18/05/16 16:46, Boris O

Re: [Xen-devel] [PATCH] x86, locking: Remove ticket (spin)lock implementation

2016-05-19 Thread David Vrabel
On 18/05/16 19:43, Peter Zijlstra wrote: > > We've unconditionally used the queued spinlock for many releases now. > > Its time to remove the old ticket lock code. Xen parts: Acked-by: David Vrabel David ___ Xen-devel maili

Re: [Xen-devel] [PATCH] xen/grant-table: Use kmalloc_array() in arch_gnttab_valloc()

2016-08-26 Thread David Vrabel
On 25/08/16 12:30, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 25 Aug 2016 13:23:06 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus reuse the corresponding function "kmalloc_ar

Re: [Xen-devel] find_next{,_zero}_bit() inconsistencies

2016-08-30 Thread David Vrabel
On 29/08/16 12:59, Jan Beulich wrote: > Hello, > > in the context of > https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg03068.html > I once again came across the different behavior our various > implementations of the $subject functions, in particular their varying > handling of the

Re: [Xen-devel] [PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread David Vrabel
tpoints in proc but is currently > proc-internal. Export this interface to modules, then use it in > xenbus when creating /proc/xen. Acked-by: David Vrabel This either needs to be acked by the fs maintainer or go via their tree but you don't appear to have Cc'

Re: [Xen-devel] [PATCH] xenbus: Use proc_create_mount_point() to create /proc/xen

2016-08-30 Thread David Vrabel
On 30/08/16 16:10, Seth Forshee wrote: > On Tue, Aug 30, 2016 at 04:00:03PM +0100, David Vrabel wrote: >> On 29/08/16 16:03, Seth Forshee wrote: >>> Mounting proc in user namespace containers fails if the xenbus >>> filesystem is mounted on /proc/xen because t

Re: [Xen-devel] [PATCH v2 1/1] xen: move TLB-flush filtering out into populate_physmap

2016-09-06 Thread David Vrabel
On 06/09/16 09:42, Dongli Zhang wrote: > This patch implemented parts of TODO left in commit id > a902c12ee45fc9389eb8fe54eeddaf267a555c58. It moved TLB-flush filtering out > into populate_physmap. > > Because of TLB-flush in alloc_heap_pages, it's very slow to create a guest > with memory size of

Re: [Xen-devel] [PATCH v2 1/1] xen: move TLB-flush filtering out into populate_physmap

2016-09-06 Thread David Vrabel
On 06/09/16 10:52, George Dunlap wrote: > On 06/09/16 10:39, David Vrabel wrote: >> On 06/09/16 09:42, Dongli Zhang wrote: >>> This patch implemented parts of TODO left in commit id >>> a902c12ee45fc9389eb8fe54eeddaf267a555c58. It moved TLB-flush filtering ou

Re: [Xen-devel] [PATCH linux v3 3/9] xen: introduce xen_vcpu_id mapping

2016-09-07 Thread David Vrabel
pu xen_vcpu_id mapping. ARM and PV guests get direct >>>>>>> mapping >>>>>>> for now. Boot CPU for PVHVM guest gets its id from CPUID. With secondary >>>>>>> CPUs it is a bit more trickier. Currently, we initialize IPI ve

Re: [Xen-devel] [PATCH net-next] xen-netfront: avoid packet loss when ethernet header crosses page boundary

2016-09-09 Thread David Vrabel
at's what > this patch is trying to achieve with skb_copy(). > > Signed-off-by: Vitaly Kuznetsov We should probably fix the backend to handle this (by grant copying a minimum amount in the linear area, but since netfront needs to work with older netback. Acked-by: David Vrabel David ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] xen/pciback: support driver_override

2016-09-09 Thread David Vrabel
On 09/09/16 07:14, Juergen Gross wrote: > On 08/09/16 16:10, Boris Ostrovsky wrote: >> On 09/02/2016 08:30 AM, Juergen Gross wrote: >>> Support the driver_override scheme introduced with commit 782a985d7af2 >>> ("PCI: Introduce new device binding path using pci_dev.driver_override") >>> >>> As pcis

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-09-09 Thread David Vrabel
On 09/09/16 16:16, Jennifer Herbert wrote: > On 01/08/16 12:32, Ian Jackson wrote: >> I think we need to introduce a new hypercall (which I will call DMOP >> for now) which may augment or replace some of HVMCTL. Let me explain: >> > > I believe the new 'DMOP' hypercall is a good idea, but follow

Re: [Xen-devel] Device model operation hypercall (DMOP, re qemu depriv)

2016-09-13 Thread David Vrabel
On 12/09/16 15:32, Jan Beulich wrote: On 09.09.16 at 17:16, wrote: >> The following code illustrates this idea: >> >> typedef struct dm_op_buffer { >> XEN_GUEST_HANDLE(void) h; >> size_t len; >> } dm_op_buffer_t; > > This implies that we'll lose all type safety on the handles passe

[Xen-devel] [GIT PULL] xen: regression fix for 4.8-rc6

2016-09-14 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.8b-rc6-tag xen: regression fix for 4.8-rc6 - - Fix SMP boot in arm guests. Thanks. David arch/arm/xen/enlighten.c | 7 +++ 1

Re: [Xen-devel] [PATCH v2 2/3] x86 Test and expose CPUID faulting capabilities in /proc/cpuinfo

2016-09-15 Thread David Vrabel
break; > + case MSR_PLATFORM_INFO: > + val &= ~CPUID_FAULTING_SUPPORT; > + break; > } > return val; > } Acked-by: David Vrabel David ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 2/3] x86 Test and expose CPUID faulting capabilities in /proc/cpuinfo

2016-09-15 Thread David Vrabel
On 14/09/16 22:35, Dave Hansen wrote: > On 09/14/2016 02:01 PM, Kyle Huey wrote: >> Xen advertises the underlying support for CPUID faulting but not does pass >> through writes to the relevant MSR, nor does it virtualize it, so it does >> not actually work. For now mask off the relevant bit on MSR_

Re: [Xen-devel] [PATCH net-next RESEND] xen-netfront: avoid packet loss when ethernet header crosses page boundary

2016-09-19 Thread David Vrabel
On 19/09/16 11:22, Vitaly Kuznetsov wrote: > David Miller writes: > >> From: Vitaly Kuznetsov >> Date: Fri, 16 Sep 2016 12:59:14 +0200 >> >>> @@ -595,6 +596,19 @@ static int xennet_start_xmit(struct sk_buff *skb, >>> struct net_device *dev) >>> offset = offset_in_page(skb->data); >>> le

Re: [Xen-devel] [PATCH v3 2/3] xen/pciback: avoid multiple entries in slot list

2016-09-23 Thread David Vrabel
On 22/09/16 22:02, Boris Ostrovsky wrote: > On 09/22/2016 04:45 AM, Juergen Gross wrote: >> The Xen pciback driver has a list of all pci devices it is ready to >> seize. There is no check whether a to be added entry already exists. >> While this might be no problem in the common case it might confu

Re: [Xen-devel] PVHv2 vs HVMlite

2016-09-27 Thread David Vrabel
On 27/09/16 15:08, Boris Ostrovsky wrote: > I will be dusting off Linux domU PVHv2 patches now that ACPI changes are > getting close to being accepted. > > Last version of that patch referred to these guests as 'hvmlite', > including in names of variables, routines etc. I was hesitant to remove >

Re: [Xen-devel] [PATCH RESEND] xen/gntdev: Grant maps should not be subject to NUMA balancing

2016-11-10 Thread David Vrabel
On 10/11/16 17:47, Olaf Hering wrote: > On Thu, Nov 10, Boris Ostrovsky wrote: > >> Are you sure it's this patch that causes the failure? >> >> I commented out '| VM_IO' and still unable to boot with this option. > > Yes, this works for me, sles12sp2 dom0+domU, which is linux-4.4 based: > > +++

[Xen-devel] [PATCHv5 1/2] xenbus: fix deadlock on writes to /proc/xen/xenbus

2016-11-14 Thread David Vrabel
this device to always get character device like sematics. Signed-off-by: David Vrabel --- drivers/xen/xenbus/xenbus_dev_frontend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c index 1e8be12..ce389b4 100644

[Xen-devel] [PATCHv5 2/2] xenfs: Use proc_create_mount_point() to create /proc/xen

2016-11-14 Thread David Vrabel
al. Export this interface to modules, then use it in xenbus when creating /proc/xen. Signed-off-by: Seth Forshee Signed-off-by: David Vrabel --- drivers/xen/xenbus/xenbus_probe.c | 2 +- fs/proc/generic.c | 1 + fs/proc/internal.h| 1 - include/linux/proc_fs.h

[Xen-devel] [PATCH v5 0/2] xenfs: xenbus and container related bug fixes

2016-11-14 Thread David Vrabel
Using /proc/xen/xenbus can cause deadlocks on the atomic file position mutex since this file should behave like a character device and not a regular file. This is easiest to achive by clearing FMODE_ATOMIC_POS. David Changes in v5: - Clear FMODE_ATOMIC_POS instead of using symlinks. Changes in

Re: [Xen-devel] [RFC PATCH KERNEL 0/4] x86/xen: untangle PV and PVHVM guest support code

2016-11-14 Thread David Vrabel
On 14/11/16 17:17, Vitaly Kuznetsov wrote: > Hi, > > I have a long-standing idea to separate PV and PVHVM code in kernel and > introduce Kconfig options to make it possible to enable the required > parts only breaking the current 'all or nothing' approach. > > Motivation: > - Xen related x86 cod

Re: [Xen-devel] [PATCH v1 1/2] xen/kexec: Find out whether an kexec type is loaded.

2016-11-15 Thread David Vrabel
On 14/11/16 22:12, Konrad Rzeszutek Wilk wrote: > The tools that use kexec are asynchronous in nature and do > not keep state changes. As such provide an hypercall to find > out whether an image has been loaded for either type. > > Note: No need to modify XSM as it has one size fits all > check an

Re: [Xen-devel] [RFC PATCH KERNEL 1/4] x86/xen: start untangling PV and PVHVM guest support code

2016-11-15 Thread David Vrabel
On 14/11/16 17:17, Vitaly Kuznetsov wrote: > Introduce CONFIG_XEN_PV config option and split enlighten.c into > 3 files. Temporary add #ifdef CONFIG_XEN_PV to smp.c and mmu.c to > not break the build and not make the patch even bigger. > > xen_cpu_up_prepare*/xen_cpu_die hooks require separation t

Re: [Xen-devel] [PATCH v8] This is ABI for the two halves of a Para-virtual sound driver to communicate with each to other.

2016-11-16 Thread David Vrabel
Sound is not my area of expertise but I have a few points that you may like to consider. 1. You can only say how many channels a stream has, not what the channels correspond to (e.g., "left", "right" for a 2 channel stereo stream; or "left-front", "rear-right", etc. for a 6 channel 5.1 surround s

Re: [Xen-devel] [PATCH v8] This is ABI for the two halves of a Para-virtual sound driver to communicate with each to other.

2016-11-16 Thread David Vrabel
On 16/11/16 13:12, Volodymyr Babchuk wrote: > Hello David, > > I helped Oleksandr with parts of this protocol, so I want to address > some questions you asked. > > On 16 November 2016 at 12:38, David Vrabel wrote: >> >> Sound is not my area of expertise but I

Re: [Xen-devel] [PATCH] xen/gntdev: Use mempolicy instead of VM_IO flag to avoid NUMA balancing

2016-11-16 Thread David Vrabel
t; > To avoid this, instead of setting VM_IO use mempolicy that prohibits page > migration (i.e. clear policy's MPOL_F_MOF|MPOL_F_MORON) Reviewed-by: David Vrabel With the corrected commit message. David ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCHv1] MAINTAINERS: update XEN HYPERVISOR INTERFACE

2016-11-17 Thread David Vrabel
I am no longer in a postion to be a maintainer of the Xen subsystem. Signed-off-by: David Vrabel --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2a58eea..32a36da 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -13196,7 +13196,6 @@ F: drivers

[Xen-devel] [PATCHv1] MAINTAINERS: update EVENT CHANNEL and KEXEC maintainer

2016-11-17 Thread David Vrabel
I am no longer in a position to be a Xen maintainer. Andrew has kindly volunteered to continue maintainance of the KEXEC subsystem. EVENT CHANNELS (FIFO-BASED ABI) will be maintained by the "Other" hypervisor maintainers. Signed-off-by: David Vrabel Cc: Andrew Cooper --- MAINT

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread David Vrabel
On 29/11/16 11:19, Juergen Gross wrote: > On 29/11/16 12:14, Jan Beulich wrote: > On 29.11.16 at 11:50, wrote: >>> --- a/drivers/scsi/xen-scsifront.c >>> +++ b/drivers/scsi/xen-scsifront.c >>> @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct >>> vscsifrnt_info *info

Re: [Xen-devel] [DOC v1] Xen transport for 9pfs

2016-11-30 Thread David Vrabel
On 29/11/16 23:34, Stefano Stabellini wrote: > > The producer (the backend for **in**, the frontend for **out**) writes to the > array in the following way: > - read memory barrier > - read *cons*, *prod* from shared memory > - write to array at position *prod* up to *cons*, wrapping around the c

Re: [Xen-devel] [DOC v1] Xen transport for 9pfs

2016-12-02 Thread David Vrabel
On 02/12/16 00:29, Stefano Stabellini wrote: > On Wed, 30 Nov 2016, David Vrabel wrote: >> On 29/11/16 23:34, Stefano Stabellini wrote: >>> >>> The producer (the backend for **in**, the frontend for **out**) writes to >>> the >>> array in the following

Re: [Xen-devel] [PATCH 4/4] xen/x86: Correct mandatory and SMP barrier definitions

2016-12-05 Thread David Vrabel
On 05/12/16 10:05, Andrew Cooper wrote: > > + * Loads may be reordered ahead of an unaliasing store. It might be useful to summarize what an "unaliasing store" is. David ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-dev

[Xen-devel] [PATCHv6] xenbus: fix deadlock on writes to /proc/xen/xenbus

2016-12-09 Thread David Vrabel
this device to always get character device like sematics. Signed-off-by: David Vrabel --- v6: - clear flag after calling nonseekable_open(). --- drivers/xen/xenbus/xenbus_dev_frontend.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen

Re: [Xen-devel] [PATCH 1/4] docs: Clarify the expected behaviour of zero length records

2016-07-25 Thread David Vrabel
On 21/07/16 18:17, Andrew Cooper wrote: > The sending side shouldn't send any variable sized records which end up having > zero content, but the receiving side will need to tolerate such records for > compatibility purposes. > > Signed-off-by: Andrew Cooper > --- > CC: Ian Jackson > CC: Wei Liu

  1   2   3   4   5   6   7   8   9   10   >