Re: [Xen-devel] [PATCHv1 net] xen-netfront: use napi_complete() correctly to prevent Rx stalling

2014-12-16 Thread David Miller
From: David Vrabel Date: Tue, 16 Dec 2014 18:59:46 + > After d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less interrupt > masking in NAPI) the napi instance is removed from the per-cpu list > prior to calling the n->poll(), and is only requeued if all of the > budget was used. This inadve

Re: [Xen-devel] [PATCHv1 net] xen-netback: support frontends without feature-rx-notify again

2014-12-18 Thread David Miller
From: David Vrabel Date: Thu, 18 Dec 2014 11:13:06 + > Commit bc96f648df1bbc2729abbb84513cf4f64273a1f1 (xen-netback: make > feature-rx-notify mandatory) incorrectly assumed that there were no > frontends in use that did not support this feature. But the frontend > driver in MiniOS does not a

Re: [Xen-devel] net: Detect drivers that reschedule NAPI and exhaust budget

2014-12-19 Thread David Miller
From: Eric Dumazet Date: Fri, 19 Dec 2014 17:34:48 -0800 >> @@ -4620,7 +4620,11 @@ static void net_rx_action(struct softirq_action *h) >> */ >> napi_gro_flush(n, HZ >= 1000); >> } >> -

Re: [Xen-devel] virtio_net: Fix napi poll list corruption

2014-12-22 Thread David Miller
From: Herbert Xu Date: Sat, 20 Dec 2014 11:23:27 +1100 > The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less > interrupt masking in NAPI) breaks virtio_net in an insidious way. > > It is now required that if the entire budget is consumed when poll > returns, the napi poll_list must re

Re: [Xen-devel] caif: Fix napi poll list corruption

2014-12-22 Thread David Miller
From: Herbert Xu Date: Mon, 22 Dec 2014 20:35:25 +1100 > The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less > interrupt masking in NAPI) breaks caif. > > It is now required that if the entire budget is consumed when poll > returns, the napi poll_list must remain empty. However, like

Re: [Xen-devel] [PATCH 3/4] net: Always poll at least one device in net_rx_action

2014-12-23 Thread David Miller
From: Herbert Xu Date: Sun, 21 Dec 2014 07:16:24 +1100 > We should only perform the softnet_break check after we have polled > at least one device in net_rx_action. Otherwise a zero or negative > setting of netdev_budget can lock up the whole system. > > Signed-off-by: Herbert Xu Applied. __

Re: [Xen-devel] [PATCH 4/4] net: Rearrange loop in net_rx_action

2014-12-23 Thread David Miller
From: Herbert Xu Date: Sun, 21 Dec 2014 07:16:25 +1100 > This patch rearranges the loop in net_rx_action to reduce the > amount of jumping back and forth when reading the code. > > Signed-off-by: Herbert Xu Applied. ___ Xen-devel mailing list Xen-de

Re: [Xen-devel] [PATCH 1/4] net: Move napi polling code out of net_rx_action

2014-12-23 Thread David Miller
From: Herbert Xu Date: Sun, 21 Dec 2014 07:16:21 +1100 > This patch creates a new function napi_poll and moves the napi > polling code from net_rx_action into it. > > Signed-off-by: Herbert Xu Applied. ___ Xen-devel mailing list Xen-devel@lists.xen.

Re: [Xen-devel] [PATCH 2/4] net: Detect drivers that reschedule NAPI and exhaust budget

2014-12-23 Thread David Miller
From: Herbert Xu Date: Sun, 21 Dec 2014 07:16:22 +1100 > The commit d75b1ade567ffab085e8adbbdacf0092d10cd09c (net: less > interrupt masking in NAPI) required drivers to leave poll_list > empty if the entire budget is consumed. > > We have already had two broken drivers so let's add a check for >

Re: [Xen-devel] [PATCH] xen-netback: fixing the propagation of the transmit shaper timeout

2015-01-06 Thread David Miller
From: Ian Campbell Date: Tue, 6 Jan 2015 15:54:07 + > On Tue, 2015-01-06 at 16:44 +0100, Imre Palik wrote: >> From: "Palik, Imre" >> >> Since e9ce7cb6b107 ("xen-netback: Factor queue-specific data into queue >> struct"), >> the transimt shaper timeout is always set to 0. The value the use

Re: [Xen-devel] [PATCH net] drivers: net: xen-netfront: remove residual dead code

2015-01-12 Thread David Miller
From: Vincenzo Maffione Date: Sat, 10 Jan 2015 10:20:25 +0100 > This patch removes some unused arrays from the netfront private > data structures. These arrays were used in "flip" receive mode. > > Signed-off-by: Vincenzo Maffione Applied to net-next. _

Re: [Xen-devel] [PATCH 08/14] xen-netback: use foreign page information from the pages themselves

2015-01-13 Thread David Miller
From: David Vrabel Date: Tue, 13 Jan 2015 14:43:39 + > On 12/01/15 15:43, David Vrabel wrote: >> From: Jenny Herbert >> >> Use the foreign page flag in netback to get the domid and grant ref >> needed for the grant copy. This signficiantly simplifies the netback >> code and makes netback w

Re: [Xen-devel] [PATCHv2 net] xen-netfront: use different locks for Rx and Tx stats

2015-01-13 Thread David Miller
From: David Vrabel Date: Tue, 13 Jan 2015 16:42:42 + > In netfront the Rx and Tx path are independent and use different > locks. The Tx lock is held with hard irqs disabled, but Rx lock is > held with only BH disabled. Since both sides use the same stats lock, > a deadlock may occur. > >

Re: [Xen-devel] [PATCHv1 0/3 net-next] xen-netfront: refactor making Tx requests

2015-01-13 Thread David Miller
From: David Vrabel Date: Tue, 13 Jan 2015 17:16:41 + > As netfront as evolved to handle different sorts of skbs the code to > fill a Tx requests has been copy and pasted several times. The series > refactors this and a few other areas. > > The first patch is to a Xen header but this can be

Re: [Xen-devel] [PATCH] xen-netback: corretly check failed allocation

2015-10-15 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 12:26:16 -0400 > Since vzalloc can be failed in memory pressure, > return value should be checked and return ENOMEM. > > Signed-off-by: Insu Yun > --- > drivers/net/xen-netback/xenbus.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers

Re: [Xen-devel] [PATCH] xen-netback: correctly check failed allocation

2015-10-18 Thread David Miller
From: Insu Yun Date: Thu, 15 Oct 2015 18:02:28 + > Since vzalloc can be failed in memory pressure, > writes -ENOMEM to xenstore to indicate error. > > Signed-off-by: Insu Yun Applied. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lis

Re: [Xen-devel] [PATCH v2 1/1] xen-netfront: update num_queues to real created

2015-10-21 Thread David Miller
From: Joe Jin Date: Mon, 19 Oct 2015 13:37:17 +0800 > Sometimes xennet_create_queues() may failed to created all requested > queues, we need to update num_queues to real created to avoid NULL > pointer dereference. > > Signed-off-by: Joe Jin Applied. __

Re: [Xen-devel] [PATCH net-next 0/8] xen-netback/core: packet hashing

2015-10-22 Thread David Miller
From: Paul Durrant Date: Wed, 21 Oct 2015 11:36:17 +0100 > This series adds xen-netback support for hash negotiation with a frontend > driver, and an implementation of toeplitz hashing as the initial negotiable > algorithm. I'd definitely like to see some XEN networking experts review this befor

Re: [Xen-devel] [PATCH net-next 0/8] xen-netback/core: packet hashing

2015-10-24 Thread David Miller
From: Paul Durrant Date: Wed, 21 Oct 2015 11:36:17 +0100 > This series adds xen-netback support for hash negotiation with a frontend > driver, and an implementation of toeplitz hashing as the initial negotiable > algorithm. Ping, I want to see some review from some other xen networking folks. T

Re: [Xen-devel] [PATCH net-next 0/8] xen-netback/core: packet hashing

2015-10-26 Thread David Miller
From: David Vrabel Date: Mon, 26 Oct 2015 10:38:50 + > On 24/10/15 12:55, David Miller wrote: >> From: Paul Durrant >> Date: Wed, 21 Oct 2015 11:36:17 +0100 >> >>> This series adds xen-netback support for hash negotiation with a frontend >>> dr

Re: [Xen-devel] [patch] net/xen-netback: off by one in BUG_ON() condition

2015-07-14 Thread David Miller
From: Dan Carpenter Date: Sun, 12 Jul 2015 01:20:55 +0300 > The > should be >=. I also added spaces around the '-' operations so > the code is a little more consistent and matches the condition better. > > Fixes: f53c3fe8dad7 ('xen-netback: Introduce TX grant mapping') > Signed-off-by: Dan Carp

Re: [Xen-devel] [PATCHv2 net-next] xen-netback: always fully coalesce guest Rx packets

2015-01-23 Thread David Miller
From: David Vrabel Date: Tue, 20 Jan 2015 14:49:52 + > Always fully coalesce guest Rx packets into the minimum number of ring > slots. Reducing the number of slots per packet has significant > performance benefits when receiving off-host traffic. > > Results from XenServer's performance ben

Re: [Xen-devel] [PATCHv1 net] xen-netback: stop the guest rx thread after a fatal error

2015-02-02 Thread David Miller
From: David Vrabel Date: Mon, 2 Feb 2015 16:57:51 + > After commit e9d8b2c2968499c1f96563e6522c56958d5a1d0d (xen-netback: > disable rogue vif in kthread context), a fatal (protocol) error would > leave the guest Rx thread spinning, wasting CPU time. Commit > ecf08d2dbb96d5a4b4bcc53a39e8d29cc

Re: [Xen-devel] [PATCH] xen-netfront: Use static attribute groups for sysfs entries

2015-02-05 Thread David Miller
From: Takashi Iwai Date: Wed, 4 Feb 2015 14:38:55 +0100 > Instead of manual calls of device_create_file() and > device_remove_files(), assign the static attribute groups to netdev > groups array. This simplifies the code and avoids the possible > races. > > Signed-off-by: Takashi Iwai Applie

Re: [Xen-devel] [PATCH] xen-netback: fix sparse warning

2015-02-05 Thread David Miller
From: Lad Prabhakar Date: Thu, 5 Feb 2015 13:38:07 + > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > interface.c:83:5: warning: symbol 'xenvif_poll' was not declared. Should it > be static? > > Signed-off-by: Lad, Prabhakar Applied. ___

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-16 Thread David Miller
From: Michael Chan Date: Thu, 16 Apr 2015 09:39:13 -0700 > On Thu, 2015-04-16 at 09:24 -0300, casca...@linux.vnet.ibm.com wrote: >> Yes, this looks like the driver is not syncing the DMA buffers. Unmap is >> supposed to synchronize as well. >> > > For small rx packets (< 256 bytes), we sync th

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread David Miller
From: Ian Jackson Date: Fri, 17 Apr 2015 17:29:28 +0100 > Prashant Sreedharan writes ("Re: tg3 NIC driver bug in 3.14.x under Xen [and > 3 more messages]"): >> Ok this is what is causing the problem, the driver uses >> DEFINE_DMA_UNMAP_ADDR(), dma_unmap_addr_set() to keep a copy of the dma >> "m

Re: [Xen-devel] tg3 NIC driver bug in 3.14.x under Xen [and 3 more messages]

2015-04-17 Thread David Miller
From: Konrad Rzeszutek Wilk Date: Fri, 17 Apr 2015 15:04:48 -0400 > From 9e417af099e3cee2b219ab28ffc1e96b0564b213 Mon Sep 17 00:00:00 2001 > From: Konrad Rzeszutek Wilk > Date: Fri, 17 Apr 2015 14:55:47 -0400 > Subject: [PATCH] config: Enable NEED_DMA_MAP_STATE when SWIOTLB is selected > > A hu

Re: [Xen-devel] [PATCH] xen-netback: do not report success if backend_create_xenvif() fails

2014-11-24 Thread David Miller
From: Alexey Khoroshilov Date: Mon, 24 Nov 2014 13:58:00 +0300 > If xenvif_alloc() or xenbus_scanf() fail in backend_create_xenvif(), > xenbus is left in offline mode but netback_probe() reports success. > > The patch implements propagation of error code for backend_create_xenvif(). > > Found b

Re: [Xen-devel] [PATCH] xen-netfront: Remove BUGs on paged skb data which crosses a page boundary

2014-11-26 Thread David Miller
From: Seth Forshee Date: Tue, 25 Nov 2014 20:28:24 -0600 > These BUGs can be erroneously triggered by frags which refer to > tail pages within a compound page. The data in these pages may > overrun the hardware page while still being contained within the > compound page, but since compound_order(

Re: [Xen-devel] [PATCH] xen-netfront: Remove BUGs on paged skb data which crosses a page boundary

2014-11-29 Thread David Miller
From: Seth Forshee Date: Wed, 26 Nov 2014 21:53:50 -0600 > On Wed, Nov 26, 2014 at 12:28:12PM -0500, David Miller wrote: >> From: Seth Forshee >> Date: Tue, 25 Nov 2014 20:28:24 -0600 >> >> > These BUGs can be erroneously triggered by frags which refer to >>

Re: [Xen-devel] [PATCH] xen-netfront: Remove BUGs on paged skb data which crosses a page boundary

2014-12-02 Thread David Miller
From: Seth Forshee Date: Tue, 25 Nov 2014 20:28:24 -0600 > These BUGs can be erroneously triggered by frags which refer to > tail pages within a compound page. The data in these pages may > overrun the hardware page while still being contained within the > compound page, but since compound_order(

<    1   2