Re: [Xen-devel] [PATCH v4 03/34] xsm/xen_version: Add XSM for the xen_version hypercall

2016-03-22 Thread Daniel De Graaf
k. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 04/34] HYPERCALL_version_op. New hypercall mirroring XENVER_ but sane.

2016-03-22 Thread Daniel De Graaf
Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 03/34] xsm/xen_version: Add XSM for the xen_version hypercall

2016-03-22 Thread Daniel De Graaf
d a local variable block. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Jan Beulich Replied to the wrong email before; this one is actually: Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 1/2] xsm: only define XSM_MAGIC in xsm.h

2016-03-25 Thread Daniel De Graaf
On 03/16/2016 03:18 PM, Doug Goldstein wrote: Rather than have XSM_MAGIC set in the global xen/config.h and set in xsm.h if it's unset, just set it once in xsm.h since its only used in files that already include xsm.h Signed-off-by: Doug Goldstein Acked-by: Daniel De

Re: [Xen-devel] [PATCH v5 20/28] HYPERCALL_version_op: Add VERSION_build_id to retrieve build-id.

2016-03-25 Thread Daniel De Graaf
buffer. Signed-off-by: Konrad Rzeszutek Wilk Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xen/arm64: check XSM Magic and Signature from the second unknown module.

2016-03-25 Thread Daniel De Graaf
done that for a while, and the original reason (older versions of checkpolicy didn't support creating xen-type policy) is no longer an issue. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] xen/arm64: check XSM Magic and Signature from the second unknown module.

2016-03-28 Thread Daniel De Graaf
) || +strncmp(buff + sizeof(u32), (char *) &target_len, sizeof(u32)) || +strncmp(buff + sizeof(u32) * 2, "XenFlask", target_len)) +return 0; + memcmp() is more correct than strncmp() here, especially since target_len will have embedded NULLs. It also assumes little

[Xen-devel] [PATCH v2] flask: change default state to enforcing

2016-04-06 Thread Daniel De Graaf
n superseded by the flask= parameter. Signed-off-by: Daniel De Graaf --- Changes from v1: move the setting of flask_enforcing to flask_init instead of needing to set and reset it in parse_flask_param. docs/misc/xen-command-line.markdown | 2 +- docs/misc/xsm-flask.txt | 12 ++--

Re: [Xen-devel] [PATCH v5 08/21] x86/cpu: Sysctl and common infrastructure for levelling context switching

2016-04-07 Thread Daniel De Graaf
future patches, which will introduce detection and switching logic, after which the interface will report hardware capabilities correctly. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v5 14/21] xen+tools: Export maximum host and guest cpu featuresets via SYSCTL

2016-04-07 Thread Daniel De Graaf
On 04/07/2016 07:57 AM, Andrew Cooper wrote: And provide stubs for toolstack use. Signed-off-by: Andrew Cooper Acked-by: Wei Liu Acked-by: David Scott Acked-by: Jan Beulich Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v5] xen/arm64: check XSM Magic from the second unknown module.

2016-04-08 Thread Daniel De Graaf
nown. We also detect the XSM Magic for the following unknowns, then set its kind according to the return value of has_xsm_magic. By this way, arm64 behavior can be compatible to x86 and can simplify multi-arch bootloader such as GRUB. Signed-off-by: Fu Wei Acked

Re: [Xen-devel] [PATCH v8.1 22/27] XENVER_build_id/libxc: Provide ld-embedded build-id

2016-04-14 Thread Daniel De Graaf
-off-by: Konrad Rzeszutek Wilk Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] docs: update FLASK cmd line instructions

2016-04-25 Thread Daniel De Graaf
: Keir Fraser CC: Tim Deegan CC: Konrad Rzeszutek Wilk CC: Daniel De Graaf Daniel, any chance we could get your ack (or otherwise) on this? Thanks, Jan Sure, I didn't realize you were waiting on it. The patch looks good. Acked-by: Daniel De

Re: [Xen-devel] [Hackathon 16] Notes from Security Session

2016-04-25 Thread Daniel De Graaf
er modules that would be available to turn on/off. The process of assembling the modules into a single XSM policy is done in userspace, not the hypervisor, so "xl loadpolicy" would not change. -- Daniel De Graaf National Security Agency ___ Xen-de

Re: [Xen-devel] XSM denials with 4.7.0 RC1

2016-05-04 Thread Daniel De Graaf
nd I think using "xl devd" probably qualifies for that), then they probably need dontaudit rules. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH for-4.7] flask/policy: don't audit version queries

2016-05-04 Thread Daniel De Graaf
Reported-by: Doug Goldstein Signed-off-by: Daniel De Graaf --- tools/flask/policy/policy/modules/xen/xen.te | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/flask/policy/policy/modules/xen/xen.te b/tools/flask/policy/policy/modules/xen/xen.te index bef33b0..fed09a9 100644

Re: [Xen-devel] [PATCH v3 1/2] x86/mem-sharing: Bulk mem-sharing entire domains

2016-05-13 Thread Daniel De Graaf
On 05/13/2016 11:09 AM, Jan Beulich wrote: On 13.05.16 at 16:50, wrote: [...] @@ -1468,6 +1505,69 @@ int mem_sharing_memop(XEN_GUEST_HANDLE_PARAM(xen_mem_sharing_op_t) arg) } break; +case XENMEM_sharing_op_bulk_share: +{ +unsigned long max_sgfn

Re: [Xen-devel] [PATCH v3] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics

2017-08-16 Thread Daniel De Graaf
particular domain. Drop XSM's test_assign_{,dt}device hooks as no longer being individually useful. Signed-off-by: Jan Beulich Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xsm: policy hooks to require an IOMMU and interrupt remapping

2017-08-18 Thread Daniel De Graaf
interrupt remapping is ok * Active but interrupt remapping is not available * Not active This patch also updates the reference XSM policy to use the new primitives, with policy entries that do not require an active IOMMU. Signed-off-by: Christopher Clark Acked-by: Daniel De Graaf One additiona

Re: [Xen-devel] [PATCH] xsm: policy hooks to require an IOMMU and interrupt remapping

2017-08-23 Thread Daniel De Graaf
Signed-off-by: Christopher Clark Acked-by: Daniel De Graaf To be honest, for this kind of a change I would have hoped for a Reviewed-by (by you or someone else), not just an Acked-by. Hence I'm hesitant to put the patch in right away. Jan I'll keep that in mind for the future. I

Re: [Xen-devel] [PATCH 4/6] xsm: flask: change the interface and default policy for xsm_map_gmfn_foregin

2017-08-23 Thread Daniel De Graaf
lists.xenproject.org/archives/html/xen-devel/2017-07/msg03047.html Signed-off-by: Zhongze Liu Cc: Stefano Stabellini Cc: Julien Grall Cc: George Dunlap Cc: Jan Beulich Cc: Andrew Cooper Cc: Daniel De Graaf Cc: xen-devel@lists.xen.org --- xen/arch/arm/mm.c | 2 +- xen/arch/x86/mm/

Re: [Xen-devel] [PATCH 4/6] xsm: flask: change the interface and default policy for xsm_map_gmfn_foregin

2017-08-24 Thread Daniel De Graaf
On 08/24/2017 08:39 AM, Jan Beulich wrote: On 24.08.17 at 13:33, wrote: Hi Jan, 2017-08-24 14:37 GMT+08:00 Jan Beulich : On 24.08.17 at 02:51, wrote: 2017-08-23 17:55 GMT+08:00 Jan Beulich : On 22.08.17 at 20:08, wrote: --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -525,

Re: [Xen-devel] [PATCH v4 6/8] xen: add new domctl hypercall to set grant table resource limits

2017-09-07 Thread Daniel De Graaf
iewed-by: Paul Durrant Reviewed-by: Wei Liu Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 6/8] xen: add new domctl hypercall to set grant table resource limits

2017-09-07 Thread Daniel De Graaf
On 09/07/2017 09:47 AM, Juergen Gross wrote: Add a domctl hypercall to set the domain's resource limits regarding grant tables. It is accepted only as long as neither gnttab_setup_table() has been called for the domain, nor the domain has started to run. Signed-off-by: Juergen Gross Reviewed-by

Re: [Xen-devel] [PATCH v7 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

2017-10-13 Thread Daniel De Graaf
T_L3_CBM 5. XEN_SYSCTL_PSR_CAT_get_l3_info -> XEN_SYSCTL_PSR_get_l3_info Signed-off-by: Yi Sun Reviewed-by: Wei Liu Reviewed-by: Roger Pau Monné Acked-by: Jan Beulich Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v12 05/11] x86/mm: add HYPERVISOR_memory_op to acquire guest resources

2017-10-17 Thread Daniel De Graaf
new op is not intrinsicly specific to the x86 architecture, I have no means to test it on an ARM platform and so cannot verify that it functions correctly. Signed-off-by: Paul Durrant Acked-by: Daniel De Graaf ___ Xen-devel mailing

Re: [Xen-devel] [PATCH v3 2/7] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-10-19 Thread Daniel De Graaf
for normal domains that allow grant mapping/event channels. This is for the proposal "Allow setting up shared memory areas between VMs from xl config file" (see [1]). [1] https://lists.xen.org/archives/html/xen-devel/2017-08/msg03242.html Signed-off-by: Zhongze Liu Cc: Daniel De Graaf

Re: [Xen-devel] [PATCH v3 2/7] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-10-19 Thread Daniel De Graaf
On 10/19/2017 07:58 AM, Jan Beulich wrote: On 19.10.17 at 04:36, wrote: --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -516,7 +516,8 @@ static XSM_INLINE int xsm_remove_from_physmap(XSM_DEFAULT_ARG struct domain *d1, static XSM_INLINE int xsm_map_gmfn_foreign(XSM_DEFAULT_ARG

Re: [Xen-devel] [PATCH v3 2/7] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-10-20 Thread Daniel De Graaf
On 10/19/2017 08:55 PM, Zhongze Liu wrote: 2017-10-20 8:34 GMT+08:00 Zhongze Liu : Hi Daniel, 2017-10-20 1:36 GMT+08:00 Daniel De Graaf : On 10/18/2017 10:36 PM, Zhongze Liu wrote: The original dummy xsm_map_gmfn_foregin checks if source domain has the proper privileges over the target

Re: [Xen-devel] [PATCH v3 2/7] xsm: flask: change the dummy xsm policy and flask hook for map_gmfn_foregin

2017-10-20 Thread Daniel De Graaf
On 10/20/2017 02:14 AM, Jan Beulich wrote: On 19.10.17 at 19:36, wrote: On 10/19/2017 07:58 AM, Jan Beulich wrote: On 19.10.17 at 04:36, wrote: --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -516,7 +516,8 @@ static XSM_INLINE int xsm_remove_from_physmap(XSM_DEFAULT_ARG struc

Re: [Xen-devel] [PATCH for-next 8/9] xsm: add bodge when compiling with llvm coverage support

2017-10-26 Thread Daniel De Graaf
production, introduce __xsm_action_mismatch_detected for llvm coverage builds. Signed-off-by: Roger Pau Monné Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v9.1 02/16] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

2017-10-30 Thread Daniel De Graaf
T_L3_CBM 5. XEN_SYSCTL_PSR_CAT_get_l3_info -> XEN_SYSCTL_PSR_get_l3_info Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 38/52] xen/xsm/flask/flask_op.c: let custom parameter parsing routines return errno

2017-08-09 Thread Daniel De Graaf
On 08/09/2017 03:06 AM, Juergen Gross wrote: Modify the custom parameter parsing routines in: xen/xsm/flask/flask_op.c to indicate whether the parameter value was parsed successfully. Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH 48/52] xen: add hypercall for setting parameters at runtime

2017-08-09 Thread Daniel De Graaf
On 08/09/2017 03:07 AM, Juergen Gross wrote: Add a sysctl hypercall to support setting parameters similar to command line parameters, but at runtime. The parameters to set are specified as a string, just like the boot parameters. Looks good, except for one thing: +case XEN_SYSCTL_set_para

[Xen-devel] [PATCH] xsm: correct AVC lookups for two sysctls

2017-08-09 Thread Daniel De Graaf
x27;t result in a security issue there. Signed-off-by: Daniel De Graaf --- xen/xsm/flask/hooks.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 819e25d3af..57be18d6d4 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/

Re: [Xen-devel] [PATCH] xsm/flask: Fix build following "xsm: correct AVC lookups for two sysctls"

2017-08-10 Thread Daniel De Graaf
: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 2/4] xen/flask: Switch to using bool

2017-08-10 Thread Daniel De Graaf
On 06/28/2017 07:16 AM, Andrew Cooper wrote: Signed-off-by: Andrew Cooper Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2 38/52] xen/xsm/flask/flask_op.c: let custom parameter parsing routines return errno

2017-08-14 Thread Daniel De Graaf
On 08/14/2017 03:08 AM, Juergen Gross wrote: Modify the custom parameter parsing routines in: xen/xsm/flask/flask_op.c to indicate whether the parameter value was parsed successfully. Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v2 48/52] xen: add hypercall for setting parameters at runtime

2017-08-14 Thread Daniel De Graaf
On 08/14/2017 03:08 AM, Juergen Gross wrote: Add a sysctl hypercall to support setting parameters similar to command line parameters, but at runtime. The parameters to set are specified as a string, just like the boot parameters. Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH v1 02/13] Rename PSR sysctl/domctl interfaces and xsm policy to make them be general

2017-08-15 Thread Daniel De Graaf
to 'alloc'. E.g.: 1. psr_cat_op -> psr_alloc_op 2. XEN_DOMCTL_psr_cat_op -> XEN_DOMCTL_psr_alloc_op 3. XEN_SYSCTL_psr_cat_op -> XEN_SYSCTL_psr_alloc_op The sysctl/domctl version numbers are bumped. Signed-off-by: Yi Sun Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics

2017-06-22 Thread Daniel De Graaf
heck the XSM permissions for them, which would require adding test_io{port,mem,q}_permission functions too. Alternatively, you could assume that the PCI device and its associated resources all have the same label (which will be almost always be true in a properly configured system) and just use this as an early bail out to avoid user mistakes. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] passthrough: give XEN_DOMCTL_test_assign_device more sane semantics

2017-06-23 Thread Daniel De Graaf
On 06/23/2017 11:00 AM, Jan Beulich wrote: So far callers of the libxc interface passed in a domain ID which was then ignored in the hypervisor. Instead, make the hypervisor honor it (accepting DOMID_INVALID to obtain original behavior), allowing to query whether a device can be assigned to a par

Re: [Xen-devel] [PATCH v6 04/12] xen: add new domctl hypercall to set grant table resource limits

2017-09-13 Thread Daniel De Graaf
ed-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5] altp2m: Allow specifying external-only use-case

2017-03-28 Thread Daniel De Graaf
to "mixed", and "limited" is impossible to use with XSM. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v6] altp2m: Introduce external-only and limited use-cases

2017-04-04 Thread Daniel De Graaf
: Tamas K Lengyel Signed-off-by: Sergej Proskurin Acked-by: Wei Liu Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.9 v3 1/3] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Daniel De Graaf
same functionality. Signed-off-by: Roger Pau Monné Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.9] xsm: fix clang 3.5 build after c47d1d

2017-04-10 Thread Daniel De Graaf
d as long as it's done on occasional builds. Alternatively, it could be done by a static analysis tool, but I've not looked into how to do that with Coverity. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 01/10] x86/domctl: Add XEN_DOMCTL_set_avail_vcpus

2016-11-08 Thread Daniel De Graaf
Ostrovsky Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] Fix misleading indentation warnings

2016-11-10 Thread Daniel De Graaf
On 11/10/2016 04:23 AM, Cédric Bosdonnat wrote: Gcc6 build reports misleading indentation as warnings. Fix a few warnings in stubdom. Signed-off-by: Cédric Bosdonnat Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH] xsm: don't require configuring tools to build xen xsm blob

2016-07-25 Thread Daniel De Graaf
Hypervisor Makefile will use Makefile.common to build xsm policy. Signed-off-by: Wei Liu Acked-by: Daniel De Graaf Thanks for fixing this; I intended the build to remain separate but never actually de-configured a build tree to test. Using git-send-email -C would make the

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-16 Thread Daniel De Graaf
o determine what to do, especially in this case where it changes what permissions are actually being enforced (in the non-FLASK case). -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-16 Thread Daniel De Graaf
t once avoids a for_each_domain() loop when the ID of an existing domain gets passed in. Reported-by: Marek Marczykowski-Górecki Signed-off-by: Jan Beulich Acked-by: Daniel De Graaf [...] I know there had been an alternative patch suggestion, but that one doesn't seem have seen a formal submission s

Re: [Xen-devel] [PATCH v3 36/38] altp2m: Allow specifying external-only use-case

2016-08-17 Thread Daniel De Graaf
all ops. Signed-off-by: Tamas K Lengyel Signed-off-by: Sergej Proskurin Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] XSM: drop pointless uses of __FUNCTION__

2016-08-24 Thread Daniel De Graaf
On 08/24/2016 04:06 AM, Jan Beulich wrote: Non-debugging message text should be (and is in the cases here) distinguishable without also logging function names. Signed-off-by: Jan Beulich Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen

Re: [Xen-devel] [PATCH v4 1/8] public / x86: Introduce __HYPERCALL_dm_op...

2017-01-18 Thread Daniel De Graaf
efore likely already compromised)." See that file for further information. This patch simply adds the boilerplate for the hypercall. Signed-off-by: Paul Durrant Suggested-by: Ian Jackson Suggested-by: Jennifer Herbert Acked-by: Daniel De Graaf _

Re: [Xen-devel] [PATCH v4 2/8] dm_op: convert HVMOP_*ioreq_server*

2017-01-18 Thread Daniel De Graaf
On 01/17/2017 12:29 PM, Paul Durrant wrote: The definitions of HVM_IOREQSRV_BUFIOREQ_* have to persist as they are already in use by callers of the libxc interface. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH v4 4/8] dm_op: convert HVMOP_set_pci_intx_level, HVMOP_set_isa_irq_level, and...

2017-01-18 Thread Daniel De Graaf
__XEN_INTERFACE_VERSION__ less than that value. NOTE: This patch also widens the 'domain' parameter of xc_hvm_set_pci_intx_level() from a uint8_t to a uint16_t. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant --- Reviewed-by: Jan Beulich Cc: Daniel De Graaf Cc: Ian Jackson

Re: [Xen-devel] [PATCH v4 5/8] dm_op: convert HVMOP_modified_memory

2017-01-18 Thread Daniel De Graaf
to 32 bits. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 7/8] dm_op: convert HVMOP_inject_trap and HVMOP_inject_msi

2017-01-18 Thread Daniel De Graaf
ts. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 6/8] dm_op: convert HVMOP_set_mem_type

2017-01-18 Thread Daniel De Graaf
passed was always truncated to 32 bits. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v4 3/8] dm_op: convert HVMOP_track_dirty_vram

2017-01-18 Thread Daniel De Graaf
o uint32_t. In practice the value passed was always truncated to 32 bits. Suggested-by: Jan Beulich Signed-off-by: Paul Durrant Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] [incremental] xsm/build: Further build fixes following the DMop series

2017-01-26 Thread Daniel De Graaf
On 01/25/2017 09:24 AM, Andrew Cooper wrote: Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Daniel De Graaf CC: Paul Durrant CC: Ian Jackson Might be better to merge into one single patch when committed? Either way (combined with prior patch, original series, or alone): Acked-by

Re: [Xen-devel] [PATCH] flask: fix build after the introduction of DMOP

2017-01-26 Thread Daniel De Graaf
On 01/25/2017 05:43 AM, Wei Liu wrote: In 58cbc034 send_irq permission was removed but there was still reference to it in policy file. Remove the stale reference. And now we also need dm permission. Add that. Signed-off-by: Wei Liu Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH 07/11] docs: move vtpm from misc to man

2016-12-14 Thread Daniel De Graaf
have not compiled & looked at the resulting manpages. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] xsm: allow relevant permission during migrate and gpu-passthrough.

2016-12-14 Thread Daniel De Graaf
=system_u:system_r:domU_t tclass=domain GPU passthrough for hvm guest: avc: denied { send_irq } for domid=0 target=10 scontext=system_u:system_r:dom0_t tcontext=system_u:system_r:domU_t tclass=hvm Signed-off-by: Anshul Makkar Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH v6 01/12] domctl: Add XEN_DOMCTL_acpi_access

2017-01-03 Thread Daniel De Graaf
On 01/03/2017 09:04 AM, Boris Ostrovsky wrote: This domctl will allow toolstack to read and write some ACPI registers. It will be available to both x86 and ARM but will be implemented first only for x86 Signed-off-by: Boris Ostrovsky Acked-by: Daniel De Graaf -- Daniel De Graaf National

Re: [Xen-devel] [PATCH] xsm: allow relevant permission during migrate and gpu-passthrough.

2017-01-03 Thread Daniel De Graaf
On 12/19/2016 11:03 PM, Doug Goldstein wrote: On 12/19/16 10:02 AM, Doug Goldstein wrote: On 12/14/16 3:09 PM, Daniel De Graaf wrote: On 12/12/2016 09:00 AM, Anshul Makkar wrote: During guest migrate allow permission to prevent spurious page faults. Prevents these errors: d73: Non-privileged

Re: [Xen-devel] [PATCH] flask: add gcov_op check

2016-10-13 Thread Daniel De Graaf
On 10/13/2016 10:37 AM, Wei Liu wrote: Signed-off-by: Wei Liu Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH for-4.8] flask: build policy in different locations

2016-11-03 Thread Daniel De Graaf
output file names with FLASK_BUILD_DIR. Hypervisor and tools build will set that variable to different directories, so that we can be safe from races. Adjust other bits of the build system as needed. Signed-off-by: Wei Liu Acked-by: Daniel De Graaf Pulling the definition of POLICY_FILENAME

[Xen-devel] [PATCH] xsm: add missing permissions discovered in testing

2016-11-04 Thread Daniel De Graaf
(which results in an XSM check with the source xen_t). It does not make sense to deny these permissions; no domain should be using xen_t, and forbidding the hypervisor from performing cleanup is not useful. Signed-off-by: Daniel De Graaf Cc: Andrew Cooper --- tools/flask/policy/modules/xen.if | 2

Re: [Xen-devel] [PATCH 2/2] build/clang: fix XSM dummy policy when using clang 4.0

2017-03-10 Thread Daniel De Graaf
RIV check into the default case in xsm_pmu_op. This also fixes the behavior of do_xenpmu_op, which will now return -EINVAL for unknown XENPMU_* operations, instead of -EPERM when called by a privileged domain. Signed-off-by: Roger Pau Monné Acked-by: Daniel De Graaf This also looks like a good

Re: [Xen-devel] [PATCH v2 2/2] arm: export platform_op XENPF_settime64

2015-11-10 Thread Daniel De Graaf
On 09/11/15 12:32, sstabell...@kernel.org wrote: From: Stefano Stabellini Call update_domain_wallclock_time at domain initialization, specifically in arch_set_info_guest for vcpu0, like we do on x86. Set time_offset_seconds to the number of seconds between phisical boot and domain initializatio

Re: [Xen-devel] [PATCH v2 1/3] xsm/xen_version: Add XSM for the xen_version hypercall.

2015-11-10 Thread Daniel De Graaf
version_use in domain2. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCHv2] 03/27] build: convert HAS_PASSTHROUGH use to Kconfig

2015-11-12 Thread Daniel De Graaf
On 11/11/15 11:49, Doug Goldstein wrote: Use the Kconfig generated HAS_PASSTHROUGH defines for the code base. Signed-off-by: Doug Goldstein CC: Ian Campbell CC: Stefano Stabellini CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Daniel De Graaf Signed-off-by: Doug Goldstein

Re: [Xen-devel] [PATCHv2] 22/27] build: convert HAS_MEM_ACCESS use to Kconfig

2015-11-12 Thread Daniel De Graaf
De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCHv2] 23/27] build: convert HAS_MEM_PAGING use to Kconfig

2015-11-12 Thread Daniel De Graaf
On 11/11/15 11:50, Doug Goldstein wrote: Use the Kconfig generated CONFIG_HAS_MEM_PAGING defines in the code base. Signed-off-by: Doug Goldstein CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein

Re: [Xen-devel] [PATCHv2] 24/27] build: convert HAS_MEM_SHARING use to Kconfig

2015-11-12 Thread Daniel De Graaf
On 11/11/15 11:50, Doug Goldstein wrote: Use the Kconfig generated CONFIG_HAS_MEM_SHARING defines in the code base. Signed-off-by: Doug Goldstein CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Daniel De Graaf Signed-off-by: Doug Goldstein

Re: [Xen-devel] [PATCHv2] 04/27] build: convert HAS_DEVICE_TREE use to Kconfig

2015-11-12 Thread Daniel De Graaf
On 11/11/15 11:49, Doug Goldstein wrote: Use the Kconfig generated CONFIG_HAS_DEVICE_TREE defines in the code base. Signed-off-by: Doug Goldstein CC: Ian Campbell CC: Stefano Stabellini CC: Jan Beulich CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCHv2] 05/27] build: convert HAS_PCI use to Kconfig

2015-11-12 Thread Daniel De Graaf
On 11/11/15 11:49, Doug Goldstein wrote: Use the Kconfig generated CONFIG_HAS_PCI defines in the code base. Signed-off-by: Doug Goldstein CC: Keir Fraser CC: Jan Beulich CC: Andrew Cooper CC: Daniel De Graaf Signed-off-by: Doug Goldstein Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH v4 2/3] arm: export platform_op XENPF_settime64

2015-11-12 Thread Daniel De Graaf
when before calling do_settime, so that system_time actually accounts for all the time in nsec between machine boot and when the wallclock was set. Expose xsm_platform_op to ARM. Signed-off-by: Stefano Stabellini CC: dgde...@tycho.nsa.gov Acked-by: Daniel De Graaf

Re: [Xen-devel] [PATCH XEN v5 07/23] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

2015-11-13 Thread Daniel De Graaf
start_address, uint32_t count); What effect does this have on the peer ? Daniel? If this removes the (final copy of the) mapping and a notify offset/port is set, that processing happens. Otherwise, the peer cannot tell when this is called. -- Daniel De Graaf National Security Agency __

Re: [Xen-devel] [PATCH v1 02/11] xen/xsplice: Hypervisor implementation of XEN_XSPLICE_op

2015-11-13 Thread Daniel De Graaf
payloads, - check*1, apply*1, replace*1, and unload payloads. *1: Which of course in this patch are nops. Signed-off-by: Konrad Rzeszutek Wilk Signed-off-by: Ross Lagerwall Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org

Re: [Xen-devel] [PATCH XEN v5 07/23] tools: Refactor /dev/xen/gnt{dev, shr} wrappers into libxengnttab.

2015-11-24 Thread Daniel De Graaf
On 16/11/15 07:30, Ian Campbell wrote: On Fri, 2015-11-13 at 15:38 -0500, Daniel De Graaf wrote: On 13/11/15 10:02, Ian Campbell wrote: On Wed, 2015-11-11 at 15:03 +, Ian Jackson wrote: Ian Campbell writes ("[PATCH XEN v5 07/23] tools: Refactor /dev/xen/gnt{dev,shr} wrappers

Re: [Xen-devel] [PATCH] x86/PCI: make all config space writes subject to XSM checking

2015-11-24 Thread Daniel De Graaf
On 24/11/15 09:42, Jan Beulich wrote: Now that we intercept them all, there's no reason not to also uniformly hand them to XSM. Reads (which are expected to be of less interest) get handled as before (MMCFG accesses un-audited). Signed-off-by: Jan Beulich Acked-by: Daniel De

Re: [Xen-devel] [PATCH v4 2/3] arm: export platform_op XENPF_settime64

2015-11-24 Thread Daniel De Graaf
itched? The #ifdef is there mostly as a failsafe reminder to ensure that the implementation for other architectures actually calls the same XSM hooks that the x86 version does. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing l

Re: [Xen-devel] race condition in xen-gntdev

2015-06-22 Thread Daniel De Graaf
On 06/22/2015 02:37 PM, Konrad Rzeszutek Wilk wrote: On Mon, Jun 22, 2015 at 08:13:35PM +0200, Marek Marczykowski-Górecki wrote: On Mon, Jun 22, 2015 at 01:46:27PM -0400, Konrad Rzeszutek Wilk wrote: On Wed, Jun 17, 2015 at 09:42:11PM +0200, Marek Marczykowski-Górecki wrote: On Thu, May 28, 20

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-08 Thread Daniel De Graaf
have not tested) speed up the security server by avoiding the __get_cpu_var call and increment. The corresponding SELinux knob is a Kconfig option in Linux. Acked-by: Daniel De Graaf ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.or

Re: [Xen-devel] [PATCH 1/2] xsm: move the XSM_MAGIC value to Kconfig

2016-03-08 Thread Daniel De Graaf
On 03/07/2016 01:42 PM, Doug Goldstein wrote: Let Kconfig set the XSM_MAGIC value for us. Signed-off-by: Doug Goldstein This is not the best place to define this constant: it doesn't make sense for it to be user-configurable. If you want to move it out of config.h, I think the best solution

Re: [Xen-devel] [PATCH 2/2] xsm: move FLASK_AVC_STATS to Kconfig

2016-03-08 Thread Daniel De Graaf
hat: I saw the --help-- line and assumed it was the prompt. Either way, this #define is a configuration-like knob that doesn't need to be hard-coded in a header as it currently is. The corresponding SELinux knob is a Kconfig option in Linux. Acked-by: Daniel De Graaf ... if you're

Re: [Xen-devel] XSM permissive by default.

2016-03-09 Thread Daniel De Graaf
-NULL. The same would be true for event channels, but inlining the field to save space makes that a non-issue. Or whether one can FLASK_LOAD if the ops are dummy_ops instead of flask_ops. Right, the flask_op hypercall is also disconnected in the dummy module. I w

[Xen-devel] [PATCH] flask: change default state to enforcing

2016-03-10 Thread Daniel De Graaf
d by the flask= parameter. Signed-off-by: Daniel De Graaf --- docs/misc/xen-command-line.markdown | 2 +- docs/misc/xsm-flask.txt | 12 ++-- xen/xsm/flask/flask_op.c| 8 +--- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/docs/misc/xen-comm

Re: [Xen-devel] [PATCH] flask: change default state to enforcing

2016-03-10 Thread Daniel De Graaf
On 03/10/2016 02:12 PM, Konrad Rzeszutek Wilk wrote: On Thu, Mar 10, 2016 at 01:30:29PM -0500, Daniel De Graaf wrote: I've added Ian and Jan on the email as scripts/get_maintainer.pl spits out their names (Oddly not yours?) The previous default of "permissive" is meant fo

Re: [Xen-devel] [PATCH] flask: change default state to enforcing

2016-03-11 Thread Daniel De Graaf
only takes effect then. With flask=late, userspace code can also adjust the value (xl setenforce) before loading the policy. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH] flask: change default state to enforcing

2016-03-11 Thread Daniel De Graaf
g the creation of domains without a policy loaded to avoid making this mistake, but since this is no longer the default, I don't think that type of guard isnecessary. -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xe

Re: [Xen-devel] [Hackathon 16] Notes from Security Session

2016-05-23 Thread Daniel De Graaf
licy is done in userspace, not the hypervisor, so "xl loadpolicy" would not change. /me nods Thank you! -- Daniel De Graaf National Security Agency ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH] [RFC] xsm: add a default policy to .init.data

2016-05-23 Thread Daniel De Graaf
This includes the policy in tools/flask/policy in the hypervisor so that the bootloader does not need to load a policy to get sane behavior from an XSM-enabled hypervisor. RFC because this adds a binding between xen's build and the tools build. The inclusion of policy.o could be made conditional o

[Xen-devel] [PATCH 2/5] flask/policy: move user definitions and constraints into modules

2016-05-23 Thread Daniel De Graaf
This also renames the example users created by vm_role. Signed-off-by: Daniel De Graaf --- docs/misc/xsm-flask.txt| 34 +++--- tools/flask/policy/Makefile| 9 -- tools/flask/policy/modules/default_role.te | 5

[Xen-devel] [PATCH 3/5] flask/policy: Remove unused support for binary modules

2016-05-23 Thread Daniel De Graaf
Signed-off-by: Daniel De Graaf --- .../policy/policy/support/loadable_module.spt | 166 - tools/flask/policy/policy/support/misc_macros.spt | 2 + 2 files changed, 2 insertions(+), 166 deletions(-) delete mode 100644 tools/flask/policy/policy/support

[Xen-devel] [PATCH 4/5] flask/policy: xenstore stubdom policy

2016-05-23 Thread Daniel De Graaf
This adds the xenstore_t type to the example policy for use by a xenstore stub domain. Signed-off-by: Daniel De Graaf --- tools/flask/policy/modules/modules.conf | 3 +++ tools/flask/policy/modules/xenstore.te | 21 + 2 files changed, 24 insertions(+) create mode 100644

[Xen-devel] [PATCH 5/5] flask/policy: comment out unused xenstore example

2016-05-23 Thread Daniel De Graaf
Signed-off-by: Daniel De Graaf --- tools/flask/policy/policy/access_vectors | 32 +++--- tools/flask/policy/policy/security_classes | 2 +- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/tools/flask/policy/policy/access_vectors b/tools/flask/policy

  1   2   3   4   >