g to test?
363 gnttab_batch_copy(©_op, 1);
364
365 if (copy_op.status != GNTST_okay)
366 return XEN_NETIF_CTRL_STATUS_INVALID_PARAMETER;
367 }
368
369 return XEN_NETIF
ut_mutex.
That means you the next times you call mutex_trylock() in_mutex is going
to fail. So it's an endless loop.
But it could also be that I haven't slept well recently and my eyes are
cross eyed.
1054
1055 pvcalls_front
We accidentally dereference "map" when it's NULL.
Fixes: b535e2b9b78a ("xen/pvcalls: implement connect command")
Signed-off-by: Dan Carpenter
diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c
index d6c4c4aecb41..01b690e1e555 100644
--- a/drivers
rate. What's going on with
that?
Could you send your follow on patch as a reply to the thread?
regards,
dan carpenter
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
This issue was found with Hector.
> >
> > Signed-off-by: Quentin Lambert
>
> Nice catch. I think this will need some more work, I'll do a
> follow-on patch.
>
The error handling is really weird. Could you send your follow on to
this thread?
regards,
dan carpenter
Oops. Sorry for the noise.
regards,
dan carpenter
___
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
The original code is fine.
regards,
dan carpenter
___
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
DOWN(addr &
~PAGE_MASK);
^^^
This is zero most of the time. Did you intend the bitwise negate?
776 *gfn = pfn_to_gfn(xen_pfn);
777
778 return 0;
779
original
code. Let's preserve the error codes as well.
Signed-off-by: Dan Carpenter
diff --git a/drivers/xen/mcelog.c b/drivers/xen/mcelog.c
index 6ab6a79..a493c7315 100644
--- a/drivers/xen/mcelog.c
+++ b/drivers/xen/mcelog.c
@@ -393,14 +393,25 @@ static int bind_virq_for_mce(void)
stati
On Mon, Jul 20, 2015 at 01:03:52PM +0300, Dan Carpenter wrote:
> Hello Konrad Rzeszutek Wilk,
>
> The patch 7f9140626c75: "xen/mmu: Copy and revector the P2M tree."
> from Jul 26, 2012, leads to the following static checker warning:
>
> arch/x86/xen
The > should be >=. I also added spaces around the '-' operations so
the code is a little more consistent and matches the condition better.
Fixes: f53c3fe8dad7 ('xen-netback: Introduce TX grant mapping')
Signed-off-by: Dan Carpenter
diff --git a/drivers/net/xen-netbac
set_pmd(pmd, __pmd(0));
}
1112 /* In case we did something silly, we should crash in this
function
1113 * instead of somewhere later and be confusing. */
1114 xen_mc_flush();
1115 }
regards,
dan carpenter
_
12 matches
Mail list logo
