On 03/16/2016 10:32 PM, David Vrabel wrote:
> On 16/03/16 13:59, Bob Liu wrote:
>>
>> But we'd like to get the VPD information(of underlying storage device) also
>> in Linux blkfront, even blkfront is not a SCSI device.
>
> Why does blkback/blkfront need to i
On 03/17/2016 07:12 PM, Ian Jackson wrote:
> David Vrabel writes ("Re: [Xen-devel] [RFC PATCH] blkif.h: document
> scsi/0x12/0x83 node"):
>> On 16/03/16 13:59, Bob Liu wrote:
>>> But we'd like to get the VPD information(of underlying storage device) also
>
easiest way to get this VPD information from
the backend into guest where XENVBD Windows PV driver can get INQUIRY VPD data
from this node and return to OEM software.
Signed-off-by: Bob Liu
---
xen/include/public/io/blkif.h | 24
1 file changed, 24 insertions(+)
diff
On 03/23/2016 08:33 PM, Roger Pau Monné wrote:
> On Wed, 23 Mar 2016, Bob Liu wrote:
>
>> This patch documents a xenstore node which is used by XENVBD Windows PV
>> driver.
>>
>> The use case is that XenServer may have OEM specific storage backends and
>> ther
!
[1] http://lwn.net/Articles/280023/
[2] https://www.kernel.org/doc/Documentation/block/data-integrity.txt
Signed-off-by: Bob Liu
---
xen/include/public/io/blkif.h | 50 +
1 file changed, 50 insertions(+)
diff --git a/xen/include/public/io/blkif.h
On 04/07/2016 11:55 PM, Juergen Gross wrote:
> On 07/04/16 12:00, Bob Liu wrote:
>> * What's data integrity extension and why?
>> Modern filesystems feature checksumming of data and metadata to protect
>> against
>> data corruption. However, the detection o
On 04/08/2016 05:44 PM, Roger Pau Monné wrote:
> On Fri, 8 Apr 2016, Bob Liu wrote:
>>
>> On 04/07/2016 11:55 PM, Juergen Gross wrote:
>>> On 07/04/16 12:00, Bob Liu wrote:
>>>> * What's data integrity extension and why?
>>>> Modern filesystems
On 04/08/2016 10:32 PM, David Vrabel wrote:
> On 08/04/16 15:20, Ian Jackson wrote:
>> David Vrabel writes ("Re: [RFC PATCH] Data integrity extension support for
>> xen-block"):
>>> You need to read the relevant SCSI specification and find out what
>>> interfaces and behaviour the hardware has so
On 04/07/2016 06:00 PM, Bob Liu wrote:
> * What's data integrity extension and why?
> Modern filesystems feature checksumming of data and metadata to protect
> against
> data corruption. However, the detection of the corruption is done at read
> time
> which could pote
nored.
* Proposal for transmitting integrity-metadata-segment scatterlist.
Adding an extra request following the normal data request, this extra request
contains integrity-metadata segments only.
The xen-blkback will reconstruct the new bio with recevied data and integrity
segments.
Signed-off-by: Bo
On 04/20/2016 04:59 PM, David Vrabel wrote:
> On 20/04/16 08:26, Bob Liu wrote:
>>
>> /*
>> + * Recognized only if "feature-data-integrity" is present in backend xenbus
>> info.
>> + * A request with BLKIF_OP_DIX_FLAG indicates the following request
call xen_blkif_deferred_free() to free resources anymore.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/xenbus.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/block/xen-blkback/xenbus.c
b/drivers/block/xen-blkback/xenbus.c
index 3cc6d1d..2e1bb6d 100644
--- a/drivers/bloc
On 07/25/2016 05:20 PM, Roger Pau Monné wrote:
> On Sat, Jul 23, 2016 at 06:18:23AM +0800, Bob Liu wrote:
>>
>> On 07/22/2016 07:45 PM, Roger Pau Monné wrote:
>>> On Fri, Jul 22, 2016 at 05:43:32PM +0800, Bob Liu wrote:
>>>>
>>>> On 07/22/2016 05:34
On 07/25/2016 06:53 PM, Roger Pau Monné wrote:
..[snip..]
* We get the device lock and blk_mq_freeze_queue() in
dynamic_reconfig_device(),
and then have to release in blkif_recover() asynchronously which makes
the code more difficult to readable.
>>>
>>> I'm not sure I'm
On 07/25/2016 08:11 PM, Roger Pau Monné wrote:
> On Mon, Jul 25, 2016 at 07:08:36PM +0800, Bob Liu wrote:
>>
>> On 07/25/2016 06:53 PM, Roger Pau Monné wrote:
>> ..[snip..]
>>>>>> * We get the device lock and blk_mq_freeze_queue() in
>>>>>&
sys/devices/vbd-xxx/max_queues
Signed-off-by: Bob Liu
--
v2: Rename to max_ring_page_order and rm the waiting code suggested by Roger.
---
drivers/block/xen-blkfront.c | 275 +-
1 file changed, 269 insertions(+), 6 deletions(-)
diff --git a/drivers/block/xen-b
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not
as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits
with initial correct values.
Signed-off-by: Bob Liu
---
v2: Move blkif_set_queue_limits() after blkfront_gather_backend_fea
Two places didn't get updated when 64KB page granularity was introduced, this
patch fix them.
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/dr
On 07/26/2016 04:44 PM, Roger Pau Monné wrote:
> On Tue, Jul 26, 2016 at 01:19:37PM +0800, Bob Liu wrote:
>> The current VBD layer reserves buffer space for each attached device based on
>> three statically configured settings which are read at boot time.
>> * max_indirect
sys/devices/vbd-xxx/max_queues
Signed-off-by: Bob Liu
--
v3:
* Remove new_max_indirect_segments.
* Fix BUG_ON().
v2:
* Rename to max_ring_page_order.
* Remove the waiting code suggested by Roger.
---
drivers/block/xen-blkfront.c | 277 --
1 file changed, 2
On 07/27/2016 04:07 PM, Roger Pau Monné wrote:
..[snip]..
>> @@ -2443,6 +2674,22 @@ static void blkfront_connect(struct blkfront_info
>> *info)
>> return;
>> }
>>
>> +err = device_create_file(&info->xbdev->dev,
>> &dev_attr_max_ring_page_order);
>> +if (err)
>> +
On 07/27/2016 06:59 PM, Roger Pau Monné wrote:
> On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote:
> [...]
>> +static ssize_t dynamic_reconfig_device(struct blkfront_info *info, ssize_t
>> count)
>> +{
>> +/*
>> + * Prevent new req
On 07/27/2016 10:24 PM, Roger Pau Monné wrote:
> On Wed, Jul 27, 2016 at 07:21:05PM +0800, Bob Liu wrote:
>>
>> On 07/27/2016 06:59 PM, Roger Pau Monné wrote:
>>> On Wed, Jul 27, 2016 at 11:21:25AM +0800, Bob Liu wrote:
>>> [...]
>>>> +static ssize_t
Two places didn't get updated when 64KB page granularity was introduced,
this patch fix them.
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/dr
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's
not as xen-blkfront expected, introducing blkif_set_queue_limits() to reset
limits with initial correct values.
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c |
Current code forgets to free resources in the failure path of
xlvbd_alloc_gendisk(), this patch fix it.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen
On 07/28/2016 09:19 AM, Konrad Rzeszutek Wilk wrote:
> On Tue, Jul 26, 2016 at 01:19:35PM +0800, Bob Liu wrote:
>> Two places didn't get updated when 64KB page granularity was introduced, this
>> patch fix them.
>>
>> Signed-off-by: Bob Liu
>> Acked-by:
When specifying a serial list in domain config, users of
libxl_console_get_tty cannot get the tty path of a second specified pty serial,
since right now it always returns the tty path of serial 0.
Signed-off-by: Bob Liu
---
tools/libxl/libxl.c |2 +-
1 file changed, 1 insertion(+), 1
When specifying a serial list in domain config, users of
libxl_console_get_tty cannot get the tty path of a second specified pty serial,
since right now it always returns the tty path of serial 0.
Signed-off-by: Bob Liu
---
v2: Rename the patch title.
---
tools/libxl/libxl.c |2 +-
1 file
On 08/10/2016 08:33 PM, Evgenii Shatokhin wrote:
> On 14.07.2016 15:04, Bob Liu wrote:
>>
>> On 07/14/2016 07:49 PM, Evgenii Shatokhin wrote:
>>> On 11.07.2016 15:04, Bob Liu wrote:
>>>>
>>>>
>>>> On 07/11/2016 04:50 PM, Evgenii Shat
On 08/10/2016 10:54 PM, Evgenii Shatokhin wrote:
> On 10.08.2016 15:49, Bob Liu wrote:
>>
>> On 08/10/2016 08:33 PM, Evgenii Shatokhin wrote:
>>> On 14.07.2016 15:04, Bob Liu wrote:
>>>>
>>>> On 07/14/2016 07:49 PM, Evgenii Shatokhin
On 11/05/2015 10:43 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Nov 02, 2015 at 12:21:46PM +0800, Bob Liu wrote:
>> Make pool of persistent grants and free pages per-queue/ring instead of
>> per-device to get better scalability.
>
> How much better scalability do we get?
>
On 11/05/2015 10:30 AM, Konrad Rzeszutek Wilk wrote:
> On Mon, Nov 02, 2015 at 12:21:43PM +0800, Bob Liu wrote:
>> Preparatory patch for multiple hardware queues (rings). The number of
>> rings is unconditionally set to 1, larger number will be enabled in next
>> patch so as
On 11/07/2015 06:17 PM, Christoph Hellwig wrote:
> A little offtopic for this patch, but can some explain this whole
> mess about bios in Xen blkfront? We can happily do partial completions
> at the request later.
>
> Also since the blk-mq conversion the call to blk_end_request_all is
This will
w.dropbox.com/s/agrcy2pbzbsvmwv/iops.png?dl=0
---
v5:
* Rebase to xen/tip.git tags/for-linus-4.4-rc0-tag.
* Comments from Konrad.
v4:
* Rebase to v4.3-rc7.
* Comments from Roger.
v3:
* Rebased to v4.2-rc8.
Bob Liu (10):
xen/blkif: document blkif multi-queue/ring extension
xen/blkfront: sep
Document the multi-queue/ring feature in terms of XenStore keys to be written by
the backend and by the frontend.
Signed-off-by: Bob Liu
---
v2:
Add descriptions together with multi-page ring buffer.
---
include/xen/interface/io/blkif.h | 48 ++
1 file
back to xenstore
as "multi-queue-num-queues", blkback needs to read this negotiated number.
Signed-off-by: Bob Liu
---
v2:
* Make 'i' be an unsigned int.
* Other comments from Konrad.
---
drivers/block/xen-blkfront.c | 160 +++---
1 file
't drop if incresing queue numbers.
Please find the respective chart in this link:
https://www.dropbox.com/s/agrcy2pbzbsvmwv/iops.png?dl=0
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/blkback.c | 202 ---
drivers/block/xen-blkback/common.h | 32
Preparatory patch for multiple hardware queues (rings). The number of
rings is unconditionally set to 1, larger number will be enabled in next
patch("xen/blkfront: negotiate number of queues/rings to be used with backend")
so as to make every single patch small and readable.
Signed-o
is renamed to 'dev_lock' which protects the ->grants list and
persistent_gnts_c shared by all rings.
Signed-off-by: Bob Liu
---
v2:
* Introduce kick_pending_request_queues_locked().
* Add comment for 'ring_lock'.
* Move locks t
y: Arianna Avanzini
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/common.h |3 +-
drivers/block/xen-blkback/xenbus.c | 277 ++--
2 files changed, 175 insertions(+), 105 deletions(-)
diff --git a/drivers/block/xen-blkback/common.h
b/drivers/block/x
810 1230(~20%) 1024(~20%) 850(~20%)
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 110 +-
1 file changed, 43 insertions(+), 67 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 84496be..451f852
i hardware queues/rings.
Signed-off-by: Arianna Avanzini
Signed-off-by: Bob Liu
---
v2: Fix build error.
---
drivers/block/xen-blkfront.c | 359 +++---
1 file changed, 197 insertions(+), 162 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers
Backend advertises "multi-queue-max-queues" to front, also get the negotiated
number from "multi-queue-num-queues" written by blkfront.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/blkback.c | 12
drivers/block/xen-blkback/common.h |1 +
drive
is a preparation for supporting multi hardware queues/rings.
Signed-off-by: Arianna Avanzini
Signed-off-by: Bob Liu
---
v2:
* Have an BUG_ON on the holding of the pers_gnts_lock.
---
drivers/block/xen-blkback/blkback.c | 235 ---
drivers/block/xen-blkback/common.h |
On 11/17/2015 05:27 AM, Konrad Rzeszutek Wilk wrote:
>> /* Common code used when first setting up, and when resuming. */
>> static int talk_to_blkback(struct xenbus_device *dev,
>> @@ -1527,10 +1582,9 @@ static int talk_to_blkback(struct xenbus_device *dev,
>> {
>> const char *message = NU
On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote:
>> On Wed, Nov 25, 2015 at 02:25:07PM -0500, Konrad Rzeszutek Wilk wrote:
xen/blkback: separate ring information out of struct xen_blkif
xen/blkback: pseudo s
On 11/26/2015 10:57 AM, Konrad Rzeszutek Wilk wrote:
> On Thu, Nov 26, 2015 at 10:28:10AM +0800, Bob Liu wrote:
>>
>> On 11/26/2015 06:12 AM, Konrad Rzeszutek Wilk wrote:
>>> On Wed, Nov 25, 2015 at 03:56:03PM -0500, Konrad Rzeszutek Wilk wrote:
>>>> On W
On 06/03/2015 01:40 PM, Bob Liu wrote:
> Extend xen/block to support multi-page ring, so that more requests can be
> issued by using more than one pages as the request ring between blkfront
> and backend.
> As a result, the performance can get improved significantly.
>
> We g
On 06/09/2015 09:39 PM, Konrad Rzeszutek Wilk wrote:
> On Tue, Jun 09, 2015 at 08:52:53AM +, Paul Durrant wrote:
>>> -Original Message-
>>> From: Bob Liu [mailto:bob@oracle.com]
>>> Sent: 09 June 2015 09:50
>>> To: Bob Liu
>>>
On 06/09/2015 10:07 PM, Roger Pau Monné wrote:
> El 09/06/15 a les 15.39, Konrad Rzeszutek Wilk ha escrit:
...
>> Roger, I put them (patches) on devel/for-jens-4.2 on
>>
>> git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git
>>
>> I think these two patches:
>> drivers: xen-blkback: delay
nt -> blkback ->
* xen-block has been existed for many years, widely used and more stable.
Welcome any input, thank you!
Signed-off-by: Bob Liu
---
xen/include/public/io/blkif.h | 73 +
1 file changed, 73 insertions(+)
diff --git a/xen/include/p
On 03/01/2016 12:29 AM, Ian Jackson wrote:
> Ian Jackson writes ("Re: [RFC PATCH] xen-block: introduces extra request to
> pass-through SCSI commands"):
>> [stuff suggesting use of PVSCSI instead]
>
> For the avoidance of doubt:
>
> 1. Thanks very much for bringing this proposal to us at the co
On 03/01/2016 12:29 AM, Ian Jackson wrote:
> Ian Jackson writes ("Re: [RFC PATCH] xen-block: introduces extra request to
> pass-through SCSI commands"):
>> [stuff suggesting use of PVSCSI instead]
>
> For the avoidance of doubt:
>
> 1. Thanks very much for bringing this proposal to us at the co
Hi Juergen,
On 03/02/2016 03:39 PM, Juergen Gross wrote:
> On 01/03/16 19:08, Ian Jackson wrote:
>> Bob Liu writes ("Re: [RFC PATCH] xen-block: introduces extra request to
>> pass-through SCSI commands"):
>>> One thing I'm still not sure about PVSCSI is
On 03/02/2016 07:40 PM, Ian Jackson wrote:
> Bob Liu writes ("Re: [RFC PATCH] xen-block: introduces extra request to
> pass-through SCSI commands"):
>> Do you know whether pvscsi can work on top of multipath(the device-mapper
>> framework) or LVMs?
>
> No,
Linux and
other frontends can use the same mechanism.
Signed-off-by: Bob Liu
---
xen/include/public/io/blkif.h |8
1 file changed, 8 insertions(+)
diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
index 99f0326..30a6e46 100644
--- a/xen/include/public/io/
On 03/16/2016 08:36 PM, Ian Jackson wrote:
> Bob Liu writes ("[RFC PATCH] blkif.h: document scsi/0x12/0x83 node"):
>> Sometimes, we need to query VPD page=0x83 data from underlying
>> storage so that vendor supplied software can run inside the VM and
>> believe i
On 03/16/2016 10:07 PM, Paul Durrant wrote:
>> -Original Message-
>> From: Bob Liu [mailto:bob@oracle.com]
..snip..
>>>
>>
>> But we'd like to get the VPD information(of underlying storage device) also
>> in
>> Linux blkfront, even b
x27;t store rinfo pointer to hctx->driver_data, because rinfo may be
* reallocated so using hctx->queue_num to get the rinfo structure instead.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
diff --git a/dr
Sometimes blkfont may receive twice blkback_changed() notification after
migration, then talk_to_blkback() will be called twice too and confused
xen-blkback.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers
On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote:
> On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote:
>> Sometimes blkfont may receive twice blkback_changed() notification after
>> migration, then talk_to_blkback() will be called twice too and confused
>> xen-bl
On 06/07/2016 11:25 PM, Konrad Rzeszutek Wilk wrote:
> On Wed, Jun 01, 2016 at 01:49:23PM +0800, Bob Liu wrote:
>>
>> On 06/01/2016 04:33 AM, Konrad Rzeszutek Wilk wrote:
>>> On Tue, May 31, 2016 at 04:59:16PM +0800, Bob Liu wrote:
>>>> Sometimes blkfo
On 06/30/2015 10:21 PM, Marcus Granado wrote:
> On 13/05/15 11:29, Bob Liu wrote:
>>
>> On 04/28/2015 03:46 PM, Arianna Avanzini wrote:
>>> Hello Christoph,
>>>
>>> Il 28/04/2015 09:36, Christoph Hellwig ha scritto:
>>>> What happened to t
Hi,
I tried to run the latest kernel v4.2-rc1, but often got below panic during
system boot.
[ 42.118983] BUG: unable to handle kernel paging request at 003f
[ 42.119008] IP: [] __netdev_pick_tx+0x70/0x120
[ 42.119023] PGD 0
[ 42.119026] Oops: [#1] PREEMPT SMP
[ 42.1
unnecessary holding of info->io_lock when calling into blk-mq APIs.
Signed-off-by: Arianna Avanzini
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 173 ++
1 file changed, 73 insertions(+), 100 deletions(-)
diff --git a/drivers/block/
t; Signed-off-by: Julien Grall
Also hit the same issue, thank you for the fix.
Tested-by: Bob Liu
> Cc: Bernhard Thaler
> Cc: Pablo Neira Ayuso
> Cc: f...@strlen.de
> Cc: ian.campb...@citrix.com
> Cc: wei.l...@citrix.com
>
> ---
> Note that it's impossible to
On 07/06/2015 06:41 PM, Eric Dumazet wrote:
> On Mon, 2015-07-06 at 16:26 +0800, Bob Liu wrote:
>> Hi,
>>
>> I tried to run the latest kernel v4.2-rc1, but often got below panic during
>> system boot.
>>
>> [ 42.118983] BUG: unable to handle kernel
increased
about 15 times for the throughput testing.
The Linux implementation reuses two 'DEPRECATED' nodes('max-ring-pages' and
'num-ring-pages), so that nothing would be broken.
Also removed the power of 2 limit and updated the default/max value accordingly.
Signed-off-b
|
V
XenbusStateConnected
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 14 ++
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 2c61cf8..88e23fd 100644
--- a/drivers/block/
,
32 was really not enough to keep them busy.
Changes in v2:
- Rebased to 4.0-rc6
- Added description on how this protocol works into io/blkif.h
Changes in v3:
- Follow the protocol defined in io/blkif.h on XEN tree
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/blkback.c | 14
On 04/28/2015 03:46 PM, Arianna Avanzini wrote:
> Hello Christoph,
>
> Il 28/04/2015 09:36, Christoph Hellwig ha scritto:
>> What happened to this patchset?
>>
>
> It was passed on to Bob Liu, who published a follow-up patchset here:
> https://lkml.org/lkml/2015
On 05/15/2015 05:51 PM, David Vrabel wrote:
> On 12/05/15 11:58, Bob Liu wrote:
>> After commit 1b1586eeeb8c ("xenbus_client: Extend interface to
>> support multi-page ring"), Linux xenbus driver can support multi-page ring.
>>
>> Based on this interface, w
On 05/15/2015 06:01 PM, Roger Pau Monné wrote:
> El 12/05/15 a les 13.01, Bob Liu ha escrit:
>> The right place for talk_to_blkback() to query backend features and transport
>> parameters is after backend entered XenbusStateInitWait. There is no problem
>
> talk_to_blkba
On 05/15/2015 07:14 PM, Roger Pau Monné wrote:
> El 15/05/15 a les 13.03, Bob Liu ha escrit:
>>
>> On 05/15/2015 06:01 PM, Roger Pau Monné wrote:
>>> El 12/05/15 a les 13.01, Bob Liu ha escrit:
>>>> The right place for talk_to_blkback() to query
On 05/15/2015 07:13 PM, Roger Pau Monné wrote:
> El 12/05/15 a les 13.01, Bob Liu ha escrit:
>> Extend xen/block to support multi-page ring, so that more requests can be
>> issued
>> by using more than one pages as the request ring between blkfront and
>> b
Changes in v4:
- Turn to use 'ring-page-order' and 'max-ring-page-order'.
- A few comments from Roger.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/blkback.c | 12
drivers/block/xen-blkback/common.h | 3 +-
drivers/block/xen-blk
urthermore it would not allow frontend/backend to negotiate 'multi-page' and
'multi-queue' features.
Changes in v2:
- Re-write the commit message to be more clear.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 14 ++
1 file changed, 6 insertions(+)
On 05/20/2015 11:00 PM, Julien Grall wrote:
> On 20/05/15 15:56, Roger Pau Monné wrote:
>> El 20/05/15 a les 15.21, Julien Grall ha escrit:
>>> Hi,
>>>
>>> On 20/05/15 14:10, Bob Liu wrote:
>>>> ---
>>>> drivers/block/xen-blkback/b
On 05/21/2015 07:22 PM, Roger Pau Monné wrote:
> El 20/05/15 a les 15.10, Bob Liu ha escrit:
...
>> +} else {
>> +unsigned int i;
>> +
>> +if (ring_page_order > xen_blkif_max_ring_order) {
>> +err = -EINVAL;
>
design and
furthermore it would not allow frontend/backend to negotiate 'multi-page'
and 'multi-queue' features.
Changes in v2:
- Re-write the commit message to be more clear.
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c | 14 ++
1 fi
in v4:
- Turn to use 'ring-page-order' and 'max-ring-page-order'.
- A few comments from Roger.
Changes in v5:
- Clarify 4k granularity to comment.
- Address more comments from Roger.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/blkback.c | 13
drive
On 05/22/2015 04:31 PM, Paul Durrant wrote:
>> -Original Message-
>> From: Bob Liu [mailto:bob@oracle.com]
>> Sent: 22 May 2015 01:00
>> To: xen-devel@lists.xen.org
>> Cc: David Vrabel; just...@spectralogic.com; konrad.w...@oracle.com; Roger
>> P
In connect_ring, we can know exactly how many pages are used for the shared
ring and also whether feature-persistent is enabled, delay pending_req
allocation here so that we won't waste too much memory.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/common.h | 3 +-
drivers/bloc
s not unmapped grant: 839
We should recheck whether the new backend support feature-persistent during
blkif_recover().
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/bloc
On 06/01/2015 03:50 PM, Roger Pau Monné wrote:
> El 26/05/15 a les 2.11, Bob Liu ha escrit:
>> When migrate from !feature-persistent host to feature-persistent host, domU
>> still think new host/backend don't support persistent.
>> Dmesg like:
>> backed has not u
On 06/01/2015 04:36 PM, Roger Pau Monné wrote:
> El 26/05/15 a les 2.06, Bob Liu ha escrit:
>> In connect_ring, we can know exactly how many pages are used for the shared
>> ring and also whether feature-persistent is enabled, delay pending_req
>> allocation here so that we
in v4:
- Turn to use 'ring-page-order' and 'max-ring-page-order'.
- A few comments from Roger.
Changes in v5:
- Clarify with 4k granularity to comment
- Address more comments from Roger
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/blkback.c | 13
drive
This is a pre-patch for multi-page ring feature.
In connect_ring, we can know exactly how many pages are used for the shared
ring, delay pending_req allocation here so that we won't waste too much memory.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkback/common.h |2 +-
drivers/bloc
design and
furthermore it would not allow frontend/backend to negotiate 'multi-page'
and 'multi-queue' features.
Changes in v2:
- Re-write the commit message to be more clear.
Signed-off-by: Bob Liu
Acked-by: Roger Pau Monné
---
drivers/block/xen-blkfront.c | 14 ++
1 fi
cover() to earlier place:blkfront_resume().
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 91 +++-
1 file changed, 40 insertions(+), 51 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 2e6d1e9..fcc5b4e 100644
On 06/27/2016 04:33 PM, Bob Liu wrote:
> Uncompleted reqs used to be 'saved and resubmitted' in blkfront_recover()
> during
> migration, but that's too later after multi-queue introduced.
>
> After a migrate to another host (which may not have multiqueue support)
On 07/11/2016 04:50 PM, Evgenii Shatokhin wrote:
> On 06.06.2016 11:42, Dario Faggioli wrote:
>> Just Cc-ing some Linux, block, and Xen on CentOS people...
>>
>
> Ping.
>
> Any suggestions how to debug this or what might cause the problem?
>
> Obviously, we cannot control Xen on the Amazon's s
On 07/14/2016 07:49 PM, Evgenii Shatokhin wrote:
> On 11.07.2016 15:04, Bob Liu wrote:
>>
>>
>> On 07/11/2016 04:50 PM, Evgenii Shatokhin wrote:
>>> On 06.06.2016 11:42, Dario Faggioli wrote:
>>>> Just Cc-ing some Linux, block, and Xen on CentO
Two places didn't get updated when 64KB page granularity was introduced, this
patch fix them.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index fc
sys/devices/vbd-xxx/max_queues
Signed-off-by: Bob Liu
--
v2: Add device lock and other comments from Konrad.
---
drivers/block/xen-blkfront.c | 285 ++-
1 file changed, 283 insertions(+), 2 deletions(-)
diff --git a/drivers/block/xen-blkfront.c b/drivers/block/x
blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not
as xen-blkfront expected, introducing blkif_set_queue_limits() to reset limits
with initial correct values.
Signed-off-by: Bob Liu
---
drivers/block/xen-blkfront.c | 91 --
Hey Haozhong,
On 07/18/2016 08:29 AM, Haozhong Zhang wrote:
> Hi,
>
> Following is version 2 of the design doc for supporting vNVDIMM in
This version is really good, very clear and included almost everything I'd like
to know.
> Xen. It's basically the summary of discussion on previous v1 desig
On 07/21/2016 04:29 PM, Roger Pau Monné wrote:
> On Fri, Jul 15, 2016 at 05:31:48PM +0800, Bob Liu wrote:
>> blk_mq_update_nr_hw_queues() reset all queue limits to default which it's not
>> as xen-blkfront expected, introducing blkif_set_queue_limits() to reset
>> limi
On 07/21/2016 04:57 PM, Roger Pau Monné wrote:
> On Fri, Jul 15, 2016 at 05:31:49PM +0800, Bob Liu wrote:
>> The current VBD layer reserves buffer space for each attached device based on
>> three statically configured settings which are read at boot time.
>> * max_indirect
1 - 100 of 237 matches
Mail list logo
