Re: [Xen-devel] [PATCH v3 10/18] xen/pvcalls: implement listen command

On 02/06/17 21:31, Stefano Stabellini wrote: > Call inet_listen to implement the listen command. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > --- > drivers/xen/pvcalls-back.c | 21 - > 1 file changed, 20 insertions(+), 1 delet

Re: [Xen-devel] [PATCH v3 09/18] xen/pvcalls: implement bind command

On 02/06/17 21:31, Stefano Stabellini wrote: > Allocate a socket. Track the allocated passive sockets with a new data > structure named sockpass_mapping. It contains an unbound workqueue to > schedule delayed work for the accept and poll commands. It also has a > reqcopy field to be used to store a

[Xen-devel] [qemu-mainline test] 110376: regressions - FAIL

flight 110376 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/110376/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow210 guest-start fail REGR. vs. 109975 test-arm64-arm64-

Re: [Xen-devel] [PATCH v3 11/18] xen/pvcalls: implement accept command

On 02/06/17 21:31, Stefano Stabellini wrote: > Implement the accept command by calling inet_accept. To avoid blocking > in the kernel, call inet_accept(O_NONBLOCK) from a workqueue, which get > scheduled on sk_data_ready (for a passive socket, it means that there > are connections to accept). > >

Re: [Xen-devel] [PATCH v3 12/18] xen/pvcalls: implement poll command

On 02/06/17 21:31, Stefano Stabellini wrote: > Implement poll on passive sockets by requesting a delayed response with > mappass->reqcopy, and reply back when there is data on the passive > socket. > > Poll on active socket is unimplemented as by the spec, as the frontend > should just wait for ev

Re: [Xen-devel] tags in backport commits

>>> On 13.06.17 at 00:19, wrote: > I think we should discuss and agree on a set of tags to use in our > backports to stable trees. > > Specifically, I would like to see a tag that specifies the id of the > original commit, like "master commit" that Jan is using today. I would > prefer if the tag

Re: [Xen-devel] [PATCH v3 13/18] xen/pvcalls: implement release command

On 02/06/17 21:31, Stefano Stabellini wrote: > Release both active and passive sockets. For active sockets, make sure > to avoid possible conflicts with the ioworker reading/writing to those > sockets concurrently. Set map->release to let the ioworker know > atomically that the socket will be relea

Re: [Xen-devel] [PATCH v3 14/18] xen/pvcalls: disconnect and module_exit

On 02/06/17 21:31, Stefano Stabellini wrote: > Implement backend_disconnect. Call pvcalls_back_release_active on active > sockets and pvcalls_back_release_passive on passive sockets. > > Implement module_exit by calling backend_disconnect on frontend > connections. > > Signed-off-by: Stefano Stab

Re: [Xen-devel] [PATCH v3 15/18] xen/pvcalls: implement the ioworker functions

On 02/06/17 21:31, Stefano Stabellini wrote: > We have one ioworker per socket. Each ioworker goes through the list of > outstanding read/write requests. Once all requests have been dealt with, > it returns. > > We use one atomic counter per socket for "read" operations and one > for "write" opera

Re: [Xen-devel] [PATCH v3 16/18] xen/pvcalls: implement read

On 02/06/17 21:31, Stefano Stabellini wrote: > When an active socket has data available, increment the io and read > counters, and schedule the ioworker. > > Implement the read function by reading from the socket, writing the data > to the data ring. > > Set in_error on error. > > Signed-off-by:

Re: [Xen-devel] [PATCH v3 17/18] xen/pvcalls: implement write

On 02/06/17 21:31, Stefano Stabellini wrote: > When the other end notifies us that there is data to be written > (pvcalls_back_conn_event), increment the io and write counters, and > schedule the ioworker. > > Implement the write function called by ioworker by reading the data from > the data ring

Re: [Xen-devel] [PATCH v4 4/8] mm: Scrub memory from idle loop

>>> On 12.06.17 at 19:01, wrote: > On 06/12/2017 04:08 AM, Jan Beulich wrote: > On 19.05.17 at 17:50, wrote: >>> Instead of scrubbing pages during guest destruction (from >>> free_heap_pages()) do this opportunistically, from the idle loop. >> This is too brief for my taste. In particular the

Re: [Xen-devel] [PATCH v4 4/8] mm: Scrub memory from idle loop

>>> On 12.06.17 at 23:28, wrote: > On Mon, 2017-06-12 at 13:01 -0400, Boris Ostrovsky wrote: >> On 06/12/2017 04:08 AM, Jan Beulich wrote: >> > > > > On 19.05.17 at 17:50, wrote: >> > > >> > > Instead of scrubbing pages during guest destruction (from >> > > free_heap_pages()) do this opportunist

[Xen-devel] [PATCH v4] VT-d PI: disable VT-d PI when CPU-side PI isn't enabled

From the context calling pi_desc_init(), we can conclude the current implementation of VT-d PI depends on CPU-side PI. If we enable VT-d PI and disable CPU-side PI by disabling APICv explicitly in xen boot command line, we would get an assertion failure. This patch clears iommu_intpost once findin

Re: [Xen-devel] [Resend][PATCH 04/17] rbtree: empty nodes have no color

>>> On 12.06.17 at 18:42, wrote: > On Thu, 2017-06-01 at 02:50 +0530, Praveen Kumar wrote: >> Empty nodes have no color. We can make use of this property to >> simplify the >> code emitted by the RB_EMPTY_NODE and RB_CLEAR_NODE macros. >> > Mmm... you have significantly cut the changelog. I appr

Re: [Xen-devel] [PATCH v4] VT-d PI: disable VT-d PI when CPU-side PI isn't enabled

>>> On 13.06.17 at 10:20, wrote: > From the context calling pi_desc_init(), we can conclude the current > implementation of VT-d PI depends on CPU-side PI. If we enable VT-d PI > and disable CPU-side PI by disabling APICv explicitly in xen boot > command line, we would get an assertion failure. >

[Xen-devel] [PATCH] rombios/ata: Wait for BSY to clear after write

After rombios transfers the data for a write, it checks the status and fails if BSY is set. qemu-trad doesn't set BSY for PIO writes, but QEMU upstream does, and this causes rombios to fail writes because they are marked as BSY. Instead, wait for BSY to clear after a write. INT 13 writes are proba

Re: [Xen-devel] [PATCH] rombios/ata: Wait for BSY to clear after write

On 13/06/17 09:34, Ross Lagerwall wrote: > After rombios transfers the data for a write, it checks the status and > fails if BSY is set. qemu-trad doesn't set BSY for PIO writes, but QEMU > upstream does, and this causes rombios to fail writes because they are > marked as BSY. Instead, wait for BSY

Re: [Xen-devel] [PATCH 03/14 v4] xen/arm: vpl011: Add pl011 uart emulation in Xen

Hi Julien, >>> +static uint8_t vpl011_read_data(struct domain *d) >>> +{ >>> +unsigned long flags; >>> +uint8_t data = 0; >>> +struct vpl011 *vpl011 = &d->arch.vpl011; >>> +struct xencons_interface *intf = vpl011->ring_buf; >>> +XENCONS_RING_IDX in_cons = intf->in_cons; >>> +

Re: [Xen-devel] [PATCH v11 01/34] ARM: vGIC: avoid rank lock when reading priority

On 12/06/2017 23:34, Stefano Stabellini wrote: On Mon, 12 Jun 2017, Julien Grall wrote: Hi Andre, On 09/06/17 18:41, Andre Przywara wrote: When reading the priority value of a virtual interrupt, we were taking the respective rank lock so far. However for forwarded interrupts (Dom0 only so fa

Re: [Xen-devel] [PATCH 03/14 v4] xen/arm: vpl011: Add pl011 uart emulation in Xen

On 13/06/2017 09:58, Bhupinder Thakur wrote: Hi Julien, Hi Bhupinder, +static uint8_t vpl011_read_data(struct domain *d) +{ +unsigned long flags; +uint8_t data = 0; +struct vpl011 *vpl011 = &d->arch.vpl011; +struct xencons_interface *intf = vpl011->ring_buf; +XENCONS_RING_

Re: [Xen-devel] [PATCH] x86/mm: Split read_cr3() into read_cr3_pa() and __read_cr3()

On Mon, Jun 12, 2017 at 10:26:14AM -0700, Andy Lutomirski wrote: > The kernel has several code paths that read CR3. Most of them assume that > CR3 contains the PGD's physical address, whereas some of them awkwardly > use PHYSICAL_PAGE_MASK to mask off low bits. > > Add explicit mask macros for CR

Re: [Xen-devel] [xen-unstable test] 110009: regressions - FAIL

Hi Jan, On 12/06/2017 15:57, Jan Beulich wrote: On 12.06.17 at 16:30, wrote: On 09/06/17 09:19, Jan Beulich wrote: On 07.06.17 at 10:12, wrote: On 06.06.17 at 21:19, wrote: On Tue, 6 Jun 2017, Jan Beulich wrote: On 06.06.17 at 16:00, wrote: Looking at the serial logs for that and compa

Re: [Xen-devel] read_atomic, write_atomic, add_sized

On 12/06/2017 16:38, Jan Beulich wrote: On 12.06.17 at 17:19, wrote: On 12/06/17 11:55, Jan Beulich wrote: On 12.06.17 at 12:24, wrote: I am trying to understand why we decided to implement the helpers read_atomic, write_atomic, add_sized in assembly rather than directly in C. AFAICT impl

[Xen-devel] [xen-4.7-testing test] 110382: regressions - FAIL

flight 110382 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/110382/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i3865 xen-buildfail REGR. vs. 109620 build-i386-xsm

Re: [Xen-devel] [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7

On Tue, Jun 13, 2017 at 01:51:17AM +0800, Zhongze Liu wrote: > GCC 7.1.1 complains that several buffers passed to snprintf() in xenpmd > and tools/ocmal/xc are too small to hold the largest possible resulting > string. > > enlarge the size of these buffers to fix the warnings. > > Signed-off-by:

[Xen-devel] [tip:x86/mm] x86/mm: Split read_cr3() into read_cr3_pa() and __read_cr3()

Commit-ID: 6c690ee1039b251e583fc65b28da30e97d6a7385 Gitweb: http://git.kernel.org/tip/6c690ee1039b251e583fc65b28da30e97d6a7385 Author: Andy Lutomirski AuthorDate: Mon, 12 Jun 2017 10:26:14 -0700 Committer: Ingo Molnar CommitDate: Tue, 13 Jun 2017 08:48:09 +0200 x86/mm: Split read_cr3()

Re: [Xen-devel] [PATCH] rombios/ata: Wait for BSY to clear after write

On Tue, Jun 13, 2017 at 09:56:32AM +0100, Andrew Cooper wrote: > On 13/06/17 09:34, Ross Lagerwall wrote: > > After rombios transfers the data for a write, it checks the status and > > fails if BSY is set. qemu-trad doesn't set BSY for PIO writes, but QEMU > > upstream does, and this causes rombios

Re: [Xen-devel] tags in backport commits

Stefano Stabellini writes ("tags in backport commits"): > Specifically, I would like to see a tag that specifies the id of the > original commit, like "master commit" that Jan is using today. I would > prefer if the tag didn't have any spaces, thus, I suggest > master-commit-id or upstream-commit-i

Re: [Xen-devel] [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7

Zhongze Liu writes ("[PATCH v2] tools: fix several "format-truncation" warnings with GCC 7"): > GCC 7.1.1 complains that several buffers passed to snprintf() in > xenpmd and tools/ocmal/xc are too small to hold the largest possible > resulting string. > > enlarge the size of these buffers to fix

[Xen-devel] [seabios baseline-only test] 71557: regressions - FAIL

This run is configured for baseline tests only. flight 71557 seabios real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71557/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 5 libvirt-build

Re: [Xen-devel] [linux-4.9 test] 110371: regressions - FAIL

On Tue, 2017-06-13 at 03:58 +, osstest service owner wrote: > flight 110371 linux-4.9 real [real] > http://logs.test-lab.xenproject.org/osstest/logs/110371/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: >  test-armhf-armhf-xl-c

[Xen-devel] [PATCH] MAINTAINERS: Move rombios and vgabios under x86 maintainership

alongside hvmloader. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Ian Jackson CC: Wei Liu --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cb0f9f9..5b9e123 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -435,6 +435,8 @@ L: xen-devel

Re: [Xen-devel] [PATCH v2] x86/boot: Fix the boot time relocation calculations

On Mon, Jun 12, 2017 at 11:45:43AM +0100, Andrew Cooper wrote: > c/s b28044226e1 "x86: make Xen early boot code relocatable" introduces > > mov $sym_offs(__image_base__),%esi > > to the legacy boot path. However, this is by definition 0, which means the > boot code only functions correctly whe

Re: [Xen-devel] [PATCH] MAINTAINERS: Move rombios and vgabios under x86 maintainership

On Tue, Jun 13, 2017 at 11:37:55AM +0100, Andrew Cooper wrote: > alongside hvmloader. > > Signed-off-by: Andrew Cooper Acked-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7

On Tue, Jun 13, 2017 at 11:19:58AM +0100, Ian Jackson wrote: > Zhongze Liu writes ("[PATCH v2] tools: fix several "format-truncation" > warnings with GCC 7"): > > GCC 7.1.1 complains that several buffers passed to snprintf() in > > xenpmd and tools/ocmal/xc are too small to hold the largest possib

Re: [Xen-devel] [PATCH 03/14 v4] xen/arm: vpl011: Add pl011 uart emulation in Xen

Hi Julien, >> >> tools/console/daemon/io.c| 2 +- >> xen/arch/arm/Kconfig | 5 + >> xen/arch/arm/Makefile| 1 + >> xen/arch/arm/vpl011.c| 418 >> +++ >> xen/include/asm-arm/domain.h | 6 + >> xen/include/

Re: [Xen-devel] [PATCH 0/2] Fix python bindings for libxenstat

On Tue, Jun 13, 2017 at 01:05:19AM +0200, Peter Große wrote: > Hello. > > I tried to build and use the python bindings for libxenstat. > > Building worked, after I changed the hardcoded PYTHON_VERSION variable in the > tools/xenstat/libxenstat/Makefile. Maybe the version detected by configure > c

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

Hi julien, On 6/9/2017 2:09 PM, Julien Grall wrote: On 09/06/2017 07:48, Manish Jaggi wrote: On 6/8/2017 7:28 PM, Julien Grall wrote: Hi, Hello Julien, Hello, +list_for_each_entry(its_data, &host_its_list, entry) +{ Pointless { +size += sizeof(struct acpi_madt_gener

Re: [Xen-devel] tags in backport commits

On 13/06/17 08:28, Jan Beulich wrote: >> Moreover, I think we should start using tags in our staging commits >> which specify to which trees a given commit should be backported to as >> soon as it passes the push gate. > > But that's already a possibly controversial aspect: Some backports > better

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

On 13/06/17 12:02, Manish Jaggi wrote: Will the below code be ok? If you noticed, I didn't say this code is wrong. Instead I asked why you use the same ID. Meaning, is there anything in the DSDT requiring this value? + int tras_id = 0; unsigned. + list_for_each_entry(its_data, &host_its_l

[Xen-devel] [xen-unstable-smoke test] 110402: regressions - trouble: broken/fail/pass

flight 110402 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/110402/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 18 leak-check/check fail REGR. vs. 110375 Tests which

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

On 6/13/2017 4:58 PM, Julien Grall wrote: On 13/06/17 12:02, Manish Jaggi wrote: Will the below code be ok? If you noticed, I didn't say this code is wrong. Instead I asked why you use the same ID. Meaning, is there anything in the DSDT requiring this value? + int tras_id = 0; unsigned.

Re: [Xen-devel] [RFC v2][PATCH] arm-acpi: Add ITS Support for Dom0

On 13/06/17 12:44, Manish Jaggi wrote: On 6/13/2017 4:58 PM, Julien Grall wrote: On 13/06/17 12:02, Manish Jaggi wrote: Will the below code be ok? If you noticed, I didn't say this code is wrong. Instead I asked why you use the same ID. Meaning, is there anything in the DSDT requiring this va

[Xen-devel] [xen-unstable test] 110384: regressions - FAIL

flight 110384 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/110384/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt 5 xen-install fail REGR. vs. 110362 test-amd64-i386-xl

Re: [Xen-devel] [linux-4.9 test] 110371: regressions - FAIL

Dario Faggioli writes ("Re: [Xen-devel] [linux-4.9 test] 110371: regressions - FAIL"): > So, this appears to be something related to linux-4.9 and that > particular board, I guess? Yes, indeed. This has been broken for some time. > (If this was known and being looked up already, sorry for the n

Re: [Xen-devel] [PATCH 01/44] firmware/ivc: use dma_mapping_error

On Thu, Jun 08, 2017 at 03:25:26PM +0200, Christoph Hellwig wrote: > DMA_ERROR_CODE is not supposed to be used by drivers. > > Signed-off-by: Christoph Hellwig > --- > drivers/firmware/tegra/ivc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Thierry Reding signature.

Re: [Xen-devel] [PATCH 03/14 v4] xen/arm: vpl011: Add pl011 uart emulation in Xen

On 13/06/17 11:57, Bhupinder Thakur wrote: Hi Julien, Hi Bhupinder, tools/console/daemon/io.c| 2 +- xen/arch/arm/Kconfig | 5 + xen/arch/arm/Makefile| 1 + xen/arch/arm/vpl011.c| 418 +++ xen/include/

Re: [Xen-devel] read_atomic, write_atomic, add_sized

>>> On 13.06.17 at 11:42, wrote: > On 12/06/2017 16:38, Jan Beulich wrote: > On 12.06.17 at 17:19, wrote: >>> On 12/06/17 11:55, Jan Beulich wrote: >>> On 12.06.17 at 12:24, wrote: > I am trying to understand why we decided to implement the helpers > read_atomic, write_atomic, ad

[Xen-devel] [PATCH] xen/mce: don't issue error message for failed /dev/mcelog registration

When running under Xen as dom0 /dev/mcelog is being registered by Xen instead of the normal mcelog driver. Avoid an error message being issued by the mcelog driver in this case. Instead issue an informative message that Xen has registered the device. Signed-off-by: Juergen Gross --- arch/x86/ker

Re: [Xen-devel] [PATCH] xen/mce: don't issue error message for failed /dev/mcelog registration

On Tue, Jun 13, 2017 at 02:49:21PM +0200, Juergen Gross wrote: > When running under Xen as dom0 /dev/mcelog is being registered by Xen > instead of the normal mcelog driver. Avoid an error message being > issued by the mcelog driver in this case. Instead issue an informative > message that Xen has

Re: [Xen-devel] read_atomic, write_atomic, add_sized

Hi Jan, On 13/06/17 13:48, Jan Beulich wrote: On 13.06.17 at 11:42, wrote: On 12/06/2017 16:38, Jan Beulich wrote: On 12.06.17 at 17:19, wrote: On 12/06/17 11:55, Jan Beulich wrote: On 12.06.17 at 12:24, wrote: I am trying to understand why we decided to implement the helpers read_atomic

Re: [Xen-devel] [PATCH] MAINTAINERS: Move rombios and vgabios under x86 maintainership

On Tue, Jun 13, 2017 at 11:46:11AM +0100, Wei Liu wrote: > On Tue, Jun 13, 2017 at 11:37:55AM +0100, Andrew Cooper wrote: > > alongside hvmloader. > > > > Signed-off-by: Andrew Cooper > > Acked-by: Wei Liu Reviewed-by: Konrad Rzeszutek Wilk [Or Acked-by - whichever you would like] > > _

Re: [Xen-devel] read_atomic, write_atomic, add_sized

>>> On 13.06.17 at 15:02, wrote: > On 13/06/17 13:48, Jan Beulich wrote: > On 13.06.17 at 11:42, wrote: >>> Looking at the usage on Linux, many places is using >>> ACCESS_ONCE/WRITE_ONCE/READ_ONCE assume this will be done in a single >>> instructions (see atomic_read/atomic_write on both x86

Re: [Xen-devel] [PATCH] xen/mce: don't issue error message for failed /dev/mcelog registration

On 13/06/17 15:02, Borislav Petkov wrote: > On Tue, Jun 13, 2017 at 02:49:21PM +0200, Juergen Gross wrote: >> When running under Xen as dom0 /dev/mcelog is being registered by Xen >> instead of the normal mcelog driver. Avoid an error message being >> issued by the mcelog driver in this case. Inste

Re: [Xen-devel] [PATCH v2 1/1] xl.cfg man page cleanup and fixes

Armando Vega writes ("[PATCH v2 1/1] xl.cfg man page cleanup and fixes"): > - fixed some minor numbering and syntax issues in the CPU allocation > examples for the 'cpus' option > - semantic fixes to make explanations more clear throughout > - fixed all the typo's I could see > - general styling

Re: [Xen-devel] [PATCH] xen/mce: don't issue error message for failed /dev/mcelog registration

On Tue, Jun 13, 2017 at 03:14:53PM +0200, Juergen Gross wrote: > I'd rather avoid the pr_err() in the -EBUSY case. What about: > > if (err) { > if (err == -EBUSY) > pr_info("Unable to init device /dev/mcelog, already > registered"); > else > pr_err("Unable

Re: [Xen-devel] [PATCH v2 1/2] HVM: sanitize DOMCTL_gethvmcontext_partial handling

On 07/06/17 14:55, Jan Beulich wrote: > Have the caller indicate its buffer size, provide a means to query the > needed size, don't ignore the upper halves of type code and instance, > and don't copy partial data. > > Signed-off-by: Jan Beulich > Acked-by: Wei Liu Reviewed-by: Andrew Cooper __

Re: [Xen-devel] [PATCH v2] public: there's no MMUEXT_SET_FOREIGNDOM

On 09/06/17 15:01, Jan Beulich wrote: > Correct respective comments. > > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v2] xen/mce: don't issue error message for failed /dev/mcelog registration

When running under Xen as dom0 /dev/mcelog is being registered by Xen instead of the normal mcelog driver. Avoid an error message being issued by the mcelog driver in this case. Instead issue an informative message that Xen has registered the device. Signed-off-by: Juergen Gross --- arch/x86/ker

[Xen-devel] [xen-4.6-testing test] 110386: tolerable FAIL - PUSHED

flight 110386 xen-4.6-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/110386/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-xtf-amd64-amd64-5 45 xtf/test-hvm64-lbr-tsx-vmentry fail like 110183 test-xtf-amd64-amd64-1 45 xt

Re: [Xen-devel] [PATCH v2 1/1] xl.cfg man page cleanup and fixes

On Tue, Jun 13, 2017 at 02:17:06PM +0100, Ian Jackson wrote: > Armando Vega writes ("[PATCH v2 1/1] xl.cfg man page cleanup and fixes"): > > - fixed some minor numbering and syntax issues in the CPU allocation > > examples for the 'cpus' option > > - semantic fixes to make explanations more clear

Re: [Xen-devel] [PATCH] firmware/vgabios: Port PCI based VBE LFB discovery method from QEMU fork

On 10/05/17 15:31, Igor Druzhinin wrote: > QEMU-traditional implements non-standard VBE registers for getting LFB > physical address from inside of VGA BIOS code. QEMU doesn't have > those registers implemented and returns 0 when an HVM guest is trying to > access them from the existing ROMBIOS cod

Re: [Xen-devel] [PATCH V3] xen-evtchn: Bind dyn evtchn:qemu-dm interrupt to next online VCPU

On 07/06/17 13:46, Anoob Soman wrote: > A HVM domian booting generates around 200K (evtchn:qemu-dm xen-dyn) > interrupts,in a short period of time. All these evtchn:qemu-dm are bound > to VCPU 0, until irqbalance sees these IRQ and moves it to a different VCPU. > In one configuration, irqbalance ru

Re: [Xen-devel] [PATCH 0/5] xen/pvh*: Support > 32 VCPUs at restore

On 03/06/17 02:05, Ankur Arora wrote: > This patch series fixes a bunch of issues in the xen_vcpu setup > logic. > > Simplify xen_vcpu related code: code refactoring in advance of the > rest of the patch series. > > Support > 32 VCPUs at restore: unify all vcpu restore logic in > xen_vcpu_restore

[Xen-devel] [xen-unstable-smoke test] 110406: tolerable trouble: broken/pass - PUSHED

flight 110406 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/110406/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12 mig

Re: [Xen-devel] [PATCH] kbdif.h: Introduce feature-vkbd-standalone

Hi Oleksandr, The reason I’m proposing the additional feature flag is to differentiate between older, broken, backends that will not connect without the vfb device (qemu-upstream’s implementation in hw/display/xenfb.c) and fixed backends (like patches I’ve posted to fix the qemu backend). Wit

Re: [Xen-devel] read_atomic, write_atomic, add_sized

Hi, On 13/06/17 14:11, Jan Beulich wrote: On 13.06.17 at 15:02, wrote: >> On 13/06/17 13:48, Jan Beulich wrote: >> On 13.06.17 at 11:42, wrote: Looking at the usage on Linux, many places is using ACCESS_ONCE/WRITE_ONCE/READ_ONCE assume this will be done in a single instru

Re: [Xen-devel] [PATCH 3/4] ui/input: Add activate/remove for keyboard handlers

Noted, I have had a look at porting the xenfb input handlers to the qemu_input_handler_*() functions, and will post an update that combines patch 3 and 4 of this series. From: Gerd Hoffmann Sent: 08 June 2017 14:39 To: Owen Smith; qemu-d

Re: [Xen-devel] [PATCH v2] xen/mce: don't issue error message for failed /dev/mcelog registration

* Juergen Gross wrote: > When running under Xen as dom0 /dev/mcelog is being registered by Xen > instead of the normal mcelog driver. Avoid an error message being > issued by the mcelog driver in this case. Instead issue an informative > message that Xen has registered the device. > > Signed-of

[Xen-devel] [RFC PATCH] docs: add README.atomic

Recently there were some discussions about the nature and guarantees of the atomic primitives that Xen provides. This README.atomic file tries to document our expectations in those functions and macros. Signed-off-by: Andre Przywara --- Hi, as mentioned in my previous mail, I consider this more

[Xen-devel] [xen-4.8-testing test] 110387: regressions - FAIL

flight 110387 xen-4.8-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/110387/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-credit2 16 guest-start.2fail REGR. vs. 110242 Tests which did

Re: [Xen-devel] [PATCH] firmware/vgabios: Port PCI based VBE LFB discovery method from QEMU fork

On 13/06/17 15:04, Andrew Cooper wrote: > On 10/05/17 15:31, Igor Druzhinin wrote: >> QEMU-traditional implements non-standard VBE registers for getting LFB >> physical address from inside of VGA BIOS code. QEMU doesn't have >> those registers implemented and returns 0 when an HVM guest is trying t

[Xen-devel] Incorrect Comment in xen/include/asm-x86/hvm/svm/vmcb.h

Hi Everyone, I was looking at the SVM setup code in Xen when I noticed that some comments describing the VMEXIT codes look wrong. The processor exception exitcodes listed from VMEXIT_EXCEPTION_PF to VM_EXCEPTION_XF seem to describe the hexadecimal exit code different than the expected value. This

Re: [Xen-devel] [PATCH 07/15] tools: tracing: handle IRQs on/off events in xentrace and xenalyze

On 01/06/17 18:34, Dario Faggioli wrote: > so the trace will show properly decoded info, > rather than just a bunch of hex codes. > > Signed-off-by: Dario Faggioli Acked-by: George Dunlap ___ Xen-devel mailing list Xen-devel@lists.xen.org https://li

Re: [Xen-devel] [PATCH] x86/mm: Split read_cr3() into read_cr3_pa() and __read_cr3()

On Tue, Jun 13, 2017 at 2:26 AM, Borislav Petkov wrote: > On Mon, Jun 12, 2017 at 10:26:14AM -0700, Andy Lutomirski wrote: >> The kernel has several code paths that read CR3. Most of them assume that >> CR3 contains the PGD's physical address, whereas some of them awkwardly >> use PHYSICAL_PAGE_M

Re: [Xen-devel] [PATCH v2] tools: fix several "format-truncation" warnings with GCC 7

Hi Wei & Ian, 2017-06-13 18:52 GMT+08:00 Wei Liu : > On Tue, Jun 13, 2017 at 11:19:58AM +0100, Ian Jackson wrote: >> Zhongze Liu writes ("[PATCH v2] tools: fix several "format-truncation" >> warnings with GCC 7"): >> > GCC 7.1.1 complains that several buffers passed to snprintf() in >> > xenpmd a

Re: [Xen-devel] [PATCH 08/15] xen: trace RCU behavior

On 01/06/17 18:34, Dario Faggioli wrote: > Making it possible generate events showing the > activity and the behavior of the RCU subsystem. > > Gate this with its specific Kconfig option (under > CONFIG_TRACING), and keep it in disabled state by > default. > --- > Cc: George Dunlap > Cc: Andrew C

Re: [Xen-devel] [PATCH 1/4] xen: credit2: implement utilization cap

On 12/06/2017 14:19, Dario Faggioli wrote: Hey, Budget is burned by the domain's vCPUs, in a similar way to how credits are. When a domain runs out of budget, its vCPUs can't run any longer. if the vcpus of a domain have credit and if budget has run out, will the vcpus won't be scheduled.

Re: [Xen-devel] [PATCH 09/15] tools: tracing: handle RCU events in xentrace and xenalyze

On 01/06/17 18:34, Dario Faggioli wrote: > Signed-off-by: Dario Faggioli Looks good; you'll just have to adjust the START_BATCH code if you make that a variable-sized record. If that doesn't end up happening: Reviewed-by: George Dunlap -George __

[Xen-devel] [PATCH 00/24] xen/arm: Extend the usage of typesafe MFN

Hello all, This patch series extend the usage of typesafe MFN in the ARM code. _mfn(...) and mfn_x(...) are pushed further down in the call stack. Cheers, Julien Grall (24): xen/mm: Don't use _{g,m}fn for defining INVALID_{G,M}FN xen/arm: gic-v2: Fix indentation in gicv2_map_hwdom_extra_mapp

Re: [Xen-devel] [PATCH v2] xen/mce: don't issue error message for failed /dev/mcelog registration

On 13/06/17 17:20, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> When running under Xen as dom0 /dev/mcelog is being registered by Xen >> instead of the normal mcelog driver. Avoid an error message being >> issued by the mcelog driver in this case. Instead issue an informative >> message th

[Xen-devel] [PATCH 05/24] xen/arm: mm: Move mfn_to_xen_entry from page.h to mm.c

The file mm.c is the only user of mfn_to_xen_entry. This will also help to use the typesafe MFN. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 65 ++ xen/include/asm-arm/page.h | 65 -- 2 files

[Xen-devel] [PATCH 11/24] xen/arm: mm: Replace __va(pfn_to_paddr(...)) by mfn_to_virt

__va(pfn_to_paddr(...)) and mfn_to_virt are equivalent. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 08116679ec..f5df669d92 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c

[Xen-devel] [PATCH 14/24] xen/arm: Introduce wrappers for MFN <-> MADDR and GFN <-> GADDR

The new wrappers will add more safety when converting an address to a frame number (either machine or guest). A follow-up patch will use them to simplify the code. Signed-off-by: Julien Grall --- xen/include/asm-arm/mm.h | 4 1 file changed, 4 insertions(+) diff --git a/xen/include/asm-arm

[Xen-devel] [PATCH 09/24] xen/arm: Define mfn_to_page/page_to_mfn in term of __mfn_to_page/__page_to_mfn

This is matching the x86 side where the __* version is used if you need to override the helpers in source files. At the same time, move the non-underscore version at the end of the defintion and add a comment to explain them. Signed-off-by: Julien Grall --- xen/include/asm-arm/mm.h | 13 +++

[Xen-devel] [PATCH 07/24] xen/arm: mm: Clean-up mfn_to_xen_entry

The physical address is computed from the machine frame number, so checking if the physical address is page aligned is pointless. Furthermore, directly assigned the MFN to the corresponding field in the entry rather than converting to a physical address and orring the value. It will avoid to rely

[Xen-devel] [PATCH 13/24] xen/arm: traps: Replace p2m_lookup(..., ..., NULL) by gfn_to_mfn(..., ...)

gfn_to_mfn is a wrapper of p2m_lookup which does not return the p2m_type. Signed-off-by: Julien Grall --- xen/arch/arm/traps.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 6cf9ee7244..ce19021f01 100644 --- a/xen/arc

[Xen-devel] [PATCH 08/24] xen/arm: mm: Use typesafe MFN in mfn_to_xen_entry

Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 33 + 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index d164ed2eda..08116679ec 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -259,7 +259,7 @@ v

[Xen-devel] [PATCH 06/24] xen/arm: mm: Fix coding style of mfn_to_xen_entry

Fix the comment coding style and add a newline before the return. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 587a6b3975..6f63e4315a 100644 --- a/xen/arch/arm

[Xen-devel] [PATCH 18/24] xen/arm: mm: Use typesafe MFN in dump_pt_walk

Signed-off-by: Julien Grall --- xen/arch/arm/mm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 8573192e3a..452c1e26c3 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -181,7 +181,7 @@ void dump_pt_walk(paddr_t ttbr, p

[Xen-devel] [PATCH 10/24] xen/arm: domain_build: Replace paddr_to_pfn(virt_to_maddr(.)) by virt_to_mfn(.)

paddr_to_pfn(virt_to_maddr(.)) and virt_to_mfn(.) are equivalent. Signed-off-by: Julien Grall --- xen/arch/arm/domain_build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3abacc0d80..a04c8862db 100644 --- a/xe

[Xen-devel] [PATCH 16/24] xen/arm: mm: Use typesafe mfn for xenheap_mfn_*

Add more safety when using xenheap_mfn_*. Signed-off-by: Julien Grall --- xen/arch/arm/mm.c| 16 xen/arch/arm/setup.c | 18 +- xen/include/asm-arm/mm.h | 11 ++- 3 files changed, 23 insertions(+), 22 deletions(-) diff --git a/xen/arch/arm/mm.

[Xen-devel] [PATCH 12/24] xen/arm: Replace DIV_ROUND_UP(..., PAGE_SIZE) by PFN_UP(...)

DIV_ROUND_UP(..., PAGE_SIZE) and PFN_UP(...) are equivalent. Signed-off-by: Julien Grall --- xen/arch/arm/domain_build.c | 4 ++-- xen/arch/arm/gic-v2.c | 2 +- xen/arch/arm/gic-v3.c | 8 xen/arch/arm/kernel.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) d

[Xen-devel] [PATCH 19/24] xen/arm: p2m: Redefine mfn_to_page and page_to_mfn to use typesafe

The file xen/arch/arm/p2m.c is using typesafe MFN in most of the place. This requires caller to mfn_to_page and page_to_mfn to use _mfn/mfn_x. To avoid extra _mfn/mfn_x, re-define mfn_to_page and page_to_mfn within xen/arch/arm/p2m.c to handle typesafe MFN. Signed-off-by: Julien Grall --- xen/a

[Xen-devel] [PATCH 23/24] xen/arm: livepatch: Redefine virt_to_mfn to support typesafe

The file xen/arch/arm/livepatch.c is using typesafe MFN in most of the place. The only caller to virt_to_mfn is using with _mfn(...). To avoid extra _mfn(...), re-define virt_to_mfn within xen/arch/arm/livepatch.c to handle typesafe MFN. Signed-off-by: Julien Grall Cc: Ross Lagerwall Cc: Konrad

[Xen-devel] [PATCH 03/24] xen/arm: setup: Remove bogus xenheap_mfn_end in setup_mm for arm64

xenheap_mfn_end is storing an MFN and not a physical address. Thankfully xenheap_mfn_end is not used in the arm64 code. So drop it. Signed-off-by: Julien Grall --- xen/arch/arm/setup.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index f00f29a4

[Xen-devel] [PATCH 02/24] xen/arm: gic-v2: Fix indentation in gicv2_map_hwdom_extra_mappings

Signed-off-by: Julien Grall --- xen/arch/arm/gic-v2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/gic-v2.c b/xen/arch/arm/gic-v2.c index 270a1362ec..f8124e5e54 100644 --- a/xen/arch/arm/gic-v2.c +++ b/xen/arch/arm/gic-v2.c @@ -598,8 +598,8 @@ static int gi

[Xen-devel] [PATCH 01/24] xen/mm: Don't use _{g, m}fn for defining INVALID_{G, M}FN

INVALID_{G,M}FN are defined using static inline helpers _{g,m}fn. This means, they cannot be used to initialize a build time static variable: In file included from mm.c:24:0: xen/xen/include/xen/mm.h:59:26: error: initializer element is not constant #define INVALID_MFN _mfn(~0UL) Signed-off

[Xen-devel] [PATCH 17/24] xen/arm: mm: Use typesafe MFN in set_fixmap

Signed-off-by: Julien Grall --- xen/arch/arm/acpi/lib.c | 4 ++-- xen/arch/arm/kernel.c | 4 +--- xen/arch/arm/mm.c | 4 ++-- xen/arch/arm/platforms/vexpress.c | 2 +- xen/drivers/video/arm_hdlcd.c | 2 +- xen/include/asm-arm/mm.h | 2 +- 6 files

  1   2   >