[Xen-devel] [distros-debian-sid test] 71108: trouble: blocked/broken

2017-03-28 Thread Platform Team regression test user
flight 71108 distros-debian-sid real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71108/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf-pvops 3 host-install(3) broken REGR.

Re: [Xen-devel] [PATCH v2 1/7] x86/vioapic: introduce a internal vIO APIC structure

2017-03-28 Thread Jan Beulich
>>> On 27.03.17 at 18:49, wrote: > Yes, I think the unnamed structure is way better, here's what I've done: > > save.h: > > union vioapic_redir_entry > { > uint64_t bits; > struct { > uint8_t vector; > uint8_t delivery_mode:3; > uint8_t dest_mode:1; > uint

[Xen-devel] [PATCH v2] xen/arm32: Introduce alternative runtime patching

2017-03-28 Thread Wei Chen
This patch is based on the implementation of ARM64, it introduces alternative runtime patching to ARM32. This allows to patch assembly instruction at runtime to either fix hardware bugs or optimize for certain hardware features on ARM32 platform. Xen hypervisor is using ARM execution state only on

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Jan Beulich
>>> On 27.03.17 at 19:28, wrote: > On Mon, Mar 27, 2017 at 09:59:42AM -0600, Jan Beulich wrote: >> >>> On 27.03.17 at 12:18, wrote: >> > @@ -122,7 +124,7 @@ void hvm_isa_irq_assert( >> > struct hvm_irq *hvm_irq = hvm_domain_irq(d); >> > unsigned int gsi = hvm_isa_irq_to_gsi(isa_irq); >>

Re: [Xen-devel] [PATCH v1 1/9] mm: Separate free page chunk merging into its own routine

2017-03-28 Thread Jan Beulich
>>> On 27.03.17 at 18:28, wrote: > On 03/27/2017 12:03 PM, Jan Beulich wrote: > On 27.03.17 at 17:16, wrote: >>> On Fri, Mar 24, 2017 at 01:04:56PM -0400, Boris Ostrovsky wrote: --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -924,11 +924,61 @@ static int reserve

[Xen-devel] [ovmf test] 106954: all pass - PUSHED

2017-03-28 Thread osstest service owner
flight 106954 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106954/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 844b2d072d6405806398f096acc904e478d7299d baseline version: ovmf 98eb009563691bd940f3d

Re: [Xen-devel] [PATCH 07/11] xen/arm: vpl011: Add two new vpl011 parameters to xenstore

2017-03-28 Thread Bhupinder Thakur
Hi Konrad, >> Add two new parameters to the xen store: >> - newly allocated PFN to be used as IN/OUT ring buffer by xenconsoled >> - a new event channel read from Xen using a hvm call to be used by >> xenconsoled >> for eventing > > This should have a correspoinding change in the i

Re: [Xen-devel] [PATCH v4] displif: add ABI for para-virtual display

2017-03-28 Thread Oleksandr Andrushchenko
ping On 03/20/2017 10:56 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko This is the ABI for the two halves of a para-virtualized display driver. This protocol aims to provide a unified protocol which fits more sophisticated use-cases than a framebuffer device can handle. At

Re: [Xen-devel] [PATCH v18] xen/sndif: Add sound-device ABI

2017-03-28 Thread Oleksandr Andrushchenko
ping On 03/20/2017 09:03 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Add ABI for the two halves of a para-virtualized sound driver to communicate with each other. The ABI allows implementing audio playback and capture as well as volume control and possibility to mute/unm

Re: [Xen-devel] [PATCH v2 09/27] ARM: GICv3: introduce separate pending_irq structs for LPIs

2017-03-28 Thread Jan Beulich
>>> On 27.03.17 at 20:39, wrote: > CC'ing Andrew, Jan and George to get more feedback on the security > impact of this patch. > > I'll make a quick summary for you: we need to allocate a 56 bytes struct > (called pending_irq) for each potential interrupt injected to guests > (dom0 and domUs). Wit

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Yi Sun
On 17-03-28 11:12:43, Yi Sun wrote: > On 17-03-27 04:17:28, Jan Beulich wrote: > > >>> On 16.03.17 at 12:08, wrote: > > > --- a/xen/arch/x86/psr.c > > > +++ b/xen/arch/x86/psr.c [...] > > > static int gather_val_array(uint32_t val[], > > > @@ -589,7 +672,34 @@ static int gather_val_array(uint32_

Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 03:57, wrote: > I think there is indeed a disconnect between target memory (provided by > the toolstack) and current memory (i.e actual pages available to the guest). > > For example > > [0.00] BIOS-e820: [mem 0x0009e000-0x0009] > reserved > [

[Xen-devel] [libvirt test] 106952: regressions - FAIL

2017-03-28 Thread osstest service owner
flight 106952 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/106952/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-libvirt5 libvirt-buildfail REGR. vs. 106829 build-armhf-libvirt

Re: [Xen-devel] [PATCH v9 08/25] x86: refactor psr: L3 CAT: implement get value flow.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 04:13, wrote: > On 17-03-27 07:34:43, Jan Beulich wrote: >> >>> On 27.03.17 at 14:59, wrote: >> > On 17-03-27 03:23:08, Jan Beulich wrote: >> >> >>> On 16.03.17 at 12:07, wrote: >> >> > @@ -504,21 +515,30 @@ static struct psr_socket_info >> >> > *get_socket_info(unsigned int

Re: [Xen-devel] [PATCH v2 1/7] x86/vioapic: introduce a internal vIO APIC structure

2017-03-28 Thread Roger Pau Monne
On Tue, Mar 28, 2017 at 01:17:27AM -0600, Jan Beulich wrote: > >>> On 27.03.17 at 18:49, wrote: > > Yes, I think the unnamed structure is way better, here's what I've done: > > > > save.h: > > > > union vioapic_redir_entry > > { > > uint64_t bits; > > struct { > > uint8_t vector;

Re: [Xen-devel] [PATCH v9 09/25] x86: refactor psr: L3 CAT: set value: implement framework.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 03:21, wrote: > On 17-03-27 03:59:32, Jan Beulich wrote: >> >>> On 16.03.17 at 12:07, wrote: >> > --- a/xen/arch/x86/domctl.c >> > +++ b/xen/arch/x86/domctl.c >> > @@ -1437,21 +1437,21 @@ long arch_do_domctl( >> > switch ( domctl->u.psr_cat_op.cmd ) >> > { >>

Re: [Xen-devel] [PATCH] xen: additionally restrict xenforeignmemory operations

2017-03-28 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 27 March 2017 18:46 > To: Paul Durrant > Cc: 'Stefano Stabellini' ; qemu-de...@nongnu.org; > xen-de...@lists.xenproject.org; Anthony Perard > > Subject: RE: [PATCH] xen: additionally restrict xenforeig

Re: [Xen-devel] [PATCH 1/2] x86/io: rename misleading dpci_ prefixed functions to hvm_

2017-03-28 Thread Paul Durrant
> -Original Message- > From: Roger Pau Monne > Sent: 27 March 2017 16:35 > To: xen-de...@lists.xenproject.org > Cc: Roger Pau Monne ; Jan Beulich > ; Andrew Cooper ; Paul > Durrant > Subject: [PATCH 1/2] x86/io: rename misleading dpci_ prefixed functions to > hvm_ > > The dpci_ prefix use

Re: [Xen-devel] [PATCH v4] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-28 Thread Paul Durrant
> -Original Message- > From: Wei Liu [mailto:wei.l...@citrix.com] > Sent: 27 March 2017 16:12 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; Owen Smith ; > Ian Jackson ; Wei Liu ; Jan > Beulich ; Andrew Cooper > > Subject: Re: [PATCH v4] tools/firmware: add ACPI device for Windo

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 05:12, wrote: > On 17-03-27 04:17:28, Jan Beulich wrote: >> >>> On 16.03.17 at 12:08, wrote: >> > --- a/xen/arch/x86/psr.c >> > +++ b/xen/arch/x86/psr.c >> > @@ -101,6 +101,28 @@ struct feat_node { >> > /* get_val is used to get feature COS register value. */ >> >

[Xen-devel] [xen-unstable test] 106944: regressions - FAIL

2017-03-28 Thread osstest service owner
flight 106944 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/106944/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemut-debianhvm-amd64 9 debian-hvm-install fail REGR. vs. 106928 Regressions

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 10:05, wrote: > On 17-03-28 11:12:43, Yi Sun wrote: >> On 17-03-27 04:17:28, Jan Beulich wrote: >> > >>> On 16.03.17 at 12:08, wrote: >> > > --- a/xen/arch/x86/psr.c >> > > +++ b/xen/arch/x86/psr.c > [...] > >> > > static int gather_val_array(uint32_t val[], >> > > @@ -589,7

Re: [Xen-devel] [PATCH v9 11/25] x86: refactor psr: L3 CAT: set value: implement cos finding flow.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 05:26, wrote: > On 17-03-27 04:28:23, Jan Beulich wrote: >> >>> On 16.03.17 at 12:08, wrote: >> > --- a/xen/arch/x86/psr.c >> > +++ b/xen/arch/x86/psr.c > [...] > >> > +static int cat_compare_val(const uint32_t val[], >> > + const struct feat_node *f

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Roger Pau Monne
On Tue, Mar 28, 2017 at 01:25:44AM -0600, Jan Beulich wrote: > >>> On 27.03.17 at 19:28, wrote: > > On Mon, Mar 27, 2017 at 09:59:42AM -0600, Jan Beulich wrote: > >> >>> On 27.03.17 at 12:18, wrote: > >> > @@ -122,7 +124,7 @@ void hvm_isa_irq_assert( > >> > struct hvm_irq *hvm_irq = hvm_doma

Re: [Xen-devel] [PATCH 1/2] x86/io: rename misleading dpci_ prefixed functions to hvm_

2017-03-28 Thread Roger Pau Monne
On Tue, Mar 28, 2017 at 09:31:47AM +0100, Paul Durrant wrote: > > -Original Message- > > From: Roger Pau Monne > > Sent: 27 March 2017 16:35 > > To: xen-de...@lists.xenproject.org > > Cc: Roger Pau Monne ; Jan Beulich > > ; Andrew Cooper ; Paul > > Durrant > > Subject: [PATCH 1/2] x86/io:

[Xen-devel] [PATCH v5] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-28 Thread Paul Durrant
Microsoft have defined an ACPI device to support switching Windows 10 between laptop/desktop mode and slate/tablet mode [1]. This patch adds an SSDT containing such a device. The presence of the device is controlled by a new 'acpi_laptop_slate' boolean in xl.cfg. The new device will not be present

Re: [Xen-devel] [PATCH v9 12/25] x86: refactor psr: L3 CAT: set value: implement cos id picking flow.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 06:58, wrote: > On 17-03-27 04:37:37, Jan Beulich wrote: >> >>> On 16.03.17 at 12:08, wrote: >> > +static bool cat_fits_cos_max(const uint32_t val[], >> > + const struct feat_node *feat, >> > + unsigned int cos) >> > +{ >>

Re: [Xen-devel] [PATCH v9 13/25] x86: refactor psr: L3 CAT: set value: implement write msr flow.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 07:06, wrote: > On 17-03-27 04:46:01, Jan Beulich wrote: >> >>> On 16.03.17 at 12:08, wrote: >> > @@ -421,6 +425,18 @@ static bool cat_fits_cos_max(const uint32_t val[], >> > } >> > >> > /* L3 CAT ops */ >> > +static void l3_cat_write_msr(unsigned int cos, uint32_t val, >>

[Xen-devel] [xen-4.7-testing baseline-only test] 71101: trouble: blocked/broken

2017-03-28 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 71101 xen-4.7-testing real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71101/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386

Re: [Xen-devel] [PATCH v2 1/7] x86/vioapic: introduce a internal vIO APIC structure

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 10:15, wrote: > On Tue, Mar 28, 2017 at 01:17:27AM -0600, Jan Beulich wrote: >> >>> On 27.03.17 at 18:49, wrote: >> > Yes, I think the unnamed structure is way better, here's what I've done: >> > >> > save.h: >> > >> > union vioapic_redir_entry >> > { >> > uint64_t bits;

Re: [Xen-devel] [PATCH v3 00/21] x86/xen: untangle PV and PVHVM guest support code

2017-03-28 Thread Juergen Gross
On 14/03/17 18:35, Vitaly Kuznetsov wrote: > Changes since v2: > - Rebase to 4.11.0-rc1+ > - XEN_HAVE_PVMMU moved to config XEN_PV [Juergen Gross] > - .pin_vcpu kept for x86_hyper_xen_hvm to support PVH Dom0 in future >[Juergen Gross] > - 'extern' qualifiers dropped from newly introduced functi

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 10:40, wrote: > On Tue, Mar 28, 2017 at 01:25:44AM -0600, Jan Beulich wrote: >> >>> On 27.03.17 at 19:28, wrote: >> > On Mon, Mar 27, 2017 at 09:59:42AM -0600, Jan Beulich wrote: >> >> >>> On 27.03.17 at 12:18, wrote: >> >> > @@ -122,7 +124,7 @@ void hvm_isa_irq_assert( >> >>

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Yi Sun
On 17-03-28 02:36:05, Jan Beulich wrote: > >>> On 28.03.17 at 10:05, wrote: > > On 17-03-28 11:12:43, Yi Sun wrote: > >> On 17-03-27 04:17:28, Jan Beulich wrote: > >> > >>> On 16.03.17 at 12:08, wrote: > >> > > --- a/xen/arch/x86/psr.c > >> > > +++ b/xen/arch/x86/psr.c > > [...] > > > >> > > st

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Razvan Cojocaru
The real CMPXCHG hvmemul_cmpxchg() implementation works as expected as far the race conditions go, and returning RETRY for failed writebacks seems to work without issue for regular Xen emulation. However, when the patch is used with introspection, I've had a BCCode: 101 BSOD and rare (but several)

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 11:11, wrote: > On 17-03-28 02:36:05, Jan Beulich wrote: >> >>> On 28.03.17 at 10:05, wrote: >> > On 17-03-28 11:12:43, Yi Sun wrote: >> >> On 17-03-27 04:17:28, Jan Beulich wrote: >> >> > >>> On 16.03.17 at 12:08, wrote: >> >> > > --- a/xen/arch/x86/psr.c >> >> > > +++ b/xen/

Re: [Xen-devel] [GSoC] GSoC Introduction : Fuzzing Xen hypercall interface

2017-03-28 Thread Lars Kurth
Hi all, I wanted to add a few thoughts here, as this is clearly one of the harder tasks. > On 27 Mar 2017, at 14:07, Felix Schmoll wrote: > > 2017-03-26 15:04 GMT+02:00 Wei Liu >: > On Sun, Mar 26, 2017 at 01:33:08PM +0200, Felix Schmoll wrote: > [...] > > > So just

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Roger Pau Monne
On Tue, Mar 28, 2017 at 03:10:27AM -0600, Jan Beulich wrote: > >>> On 28.03.17 at 10:40, wrote: > > On Tue, Mar 28, 2017 at 01:25:44AM -0600, Jan Beulich wrote: > >> >>> On 27.03.17 at 19:28, wrote: > > ARRAY_SIZE(((struct hvm_hw_vioapic *)0)->redirtbl) > > > > Which is kind of cumbersome? I can

Re: [Xen-devel] [PATCH 03/11] xen/arm: vpl011: Refactor evtchn_send in Xen to allow sending events from a xen bound channel

2017-03-28 Thread Bhupinder Thakur
Hi, Now I am using notify_via_xen_event_channel() to send the vpl011 events to dom0. So no changes are required in evtchn_send() and this patch can be dropped. Regards, Bhupinder On 6 March 2017 at 16:42, Bhupinder Thakur wrote: > Hi, > > On 6 March 2017 at 16:24, Jan Beulich wrote: > On 0

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 11:34, wrote: > On Tue, Mar 28, 2017 at 03:10:27AM -0600, Jan Beulich wrote: >> >>> On 28.03.17 at 10:40, wrote: >> > On Tue, Mar 28, 2017 at 01:25:44AM -0600, Jan Beulich wrote: >> >> >>> On 27.03.17 at 19:28, wrote: >> > ARRAY_SIZE(((struct hvm_hw_vioapic *)0)->redirtbl) >>

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Roger Pau Monne
On Tue, Mar 28, 2017 at 03:49:23AM -0600, Jan Beulich wrote: > >>> On 28.03.17 at 11:34, wrote: > > On Tue, Mar 28, 2017 at 03:10:27AM -0600, Jan Beulich wrote: > >> >>> On 28.03.17 at 10:40, wrote: > >> > On Tue, Mar 28, 2017 at 01:25:44AM -0600, Jan Beulich wrote: > >> For our DomU model there

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 11:14, wrote: > I'm not sure that the RETRY model is what the guest OS expects. AFAIK, a > failed CMPXCHG should happen just once, with the proper registers and ZF > set. The guest surely expects neither that the instruction resume until > it succeeds, nor that some hidden loop

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Yi Sun
On 17-03-28 02:34:51, Jan Beulich wrote: > >>> On 28.03.17 at 05:12, wrote: > > On 17-03-27 04:17:28, Jan Beulich wrote: > >> >>> On 16.03.17 at 12:08, wrote: > >> > --- a/xen/arch/x86/psr.c > >> > +++ b/xen/arch/x86/psr.c > >> > @@ -101,6 +101,28 @@ struct feat_node { > >> > /* get_val

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Yi Sun
On 17-03-28 03:20:05, Jan Beulich wrote: > >>> On 28.03.17 at 11:11, wrote: > > On 17-03-28 02:36:05, Jan Beulich wrote: > >> >>> On 28.03.17 at 10:05, wrote: > >> > On 17-03-28 11:12:43, Yi Sun wrote: > >> >> On 17-03-27 04:17:28, Jan Beulich wrote: > >> >> > >>> On 16.03.17 at 12:08, wrote: >

Re: [Xen-devel] [PATCH v9 13/25] x86: refactor psr: L3 CAT: set value: implement write msr flow.

2017-03-28 Thread Yi Sun
On 17-03-28 02:48:53, Jan Beulich wrote: > >>> On 28.03.17 at 07:06, wrote: > > On 17-03-27 04:46:01, Jan Beulich wrote: > >> >>> On 16.03.17 at 12:08, wrote: > >> > @@ -421,6 +425,18 @@ static bool cat_fits_cos_max(const uint32_t val[], > >> > } > >> > > >> > /* L3 CAT ops */ > >> > +static

[Xen-devel] [ovmf baseline-only test] 71111: tolerable trouble: blocked/broken

2017-03-28 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 7 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/7/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-amd64-xsm 3 host-install(3) broken bas

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Andrew Cooper
On 28/03/17 11:03, Jan Beulich wrote: On 28.03.17 at 11:14, wrote: >> I'm not sure that the RETRY model is what the guest OS expects. AFAIK, a >> failed CMPXCHG should happen just once, with the proper registers and ZF >> set. The guest surely expects neither that the instruction resume until

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Razvan Cojocaru
On 03/28/2017 01:03 PM, Jan Beulich wrote: On 28.03.17 at 11:14, wrote: >> I'm not sure that the RETRY model is what the guest OS expects. AFAIK, a >> failed CMPXCHG should happen just once, with the proper registers and ZF >> set. The guest surely expects neither that the instruction resume

Re: [Xen-devel] [PATCH v9 12/25] x86: refactor psr: L3 CAT: set value: implement cos id picking flow.

2017-03-28 Thread Yi Sun
On 17-03-28 02:45:13, Jan Beulich wrote: > >>> On 28.03.17 at 06:58, wrote: > > On 17-03-27 04:37:37, Jan Beulich wrote: > >> >>> On 16.03.17 at 12:08, wrote: > >> > +static bool cat_fits_cos_max(const uint32_t val[], > >> > + const struct feat_node *feat, > >> > +

Re: [Xen-devel] [PATCH v2 5/7] x86/vioapic: introduce support for multiple vIO APICS

2017-03-28 Thread Jan Beulich
>>> On 27.03.17 at 12:18, wrote: > Changes since v1: > - Constify some parameters. Considering this I'm surprised the first thing I have to ask is ... > --- a/xen/arch/x86/hvm/vioapic.c > +++ b/xen/arch/x86/hvm/vioapic.c > @@ -44,6 +44,54 @@ > > static void vioapic_deliver(struct hvm_vioapic

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 11:59, wrote: > On Tue, Mar 28, 2017 at 03:49:23AM -0600, Jan Beulich wrote: >> >>> On 28.03.17 at 11:34, wrote: >> > On Tue, Mar 28, 2017 at 03:10:27AM -0600, Jan Beulich wrote: >> >> >>> On 28.03.17 at 10:40, wrote: >> >> > On Tue, Mar 28, 2017 at 01:25:44AM -0600, Jan Beuli

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 12:12, wrote: > On 17-03-28 02:34:51, Jan Beulich wrote: >> >>> On 28.03.17 at 05:12, wrote: >> > On 17-03-27 04:17:28, Jan Beulich wrote: >> >> >>> On 16.03.17 at 12:08, wrote: >> >> > --- a/xen/arch/x86/psr.c >> >> > +++ b/xen/arch/x86/psr.c >> >> > @@ -101,6 +101,28 @@ stru

Re: [Xen-devel] [PATCH v9 10/25] x86: refactor psr: L3 CAT: set value: assemble features value array.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 12:18, wrote: > On 17-03-28 03:20:05, Jan Beulich wrote: >> >>> On 28.03.17 at 11:11, wrote: >> > On 17-03-28 02:36:05, Jan Beulich wrote: >> >> >>> On 28.03.17 at 10:05, wrote: >> >> > On 17-03-28 11:12:43, Yi Sun wrote: >> >> >> On 17-03-27 04:17:28, Jan Beulich wrote: >> >>

Re: [Xen-devel] [PATCH v9 12/25] x86: refactor psr: L3 CAT: set value: implement cos id picking flow.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 12:31, wrote: > On 17-03-28 02:45:13, Jan Beulich wrote: >> >>> On 28.03.17 at 06:58, wrote: >> > On 17-03-27 04:37:37, Jan Beulich wrote: >> >> >>> On 16.03.17 at 12:08, wrote: >> >> > +static bool cat_fits_cos_max(const uint32_t val[], >> >> > + c

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 12:25, wrote: > On 28/03/17 11:03, Jan Beulich wrote: > On 28.03.17 at 11:14, wrote: >>> I'm not sure that the RETRY model is what the guest OS expects. AFAIK, a >>> failed CMPXCHG should happen just once, with the proper registers and ZF >>> set. The guest surely expects n

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 12:27, wrote: > On 03/28/2017 01:03 PM, Jan Beulich wrote: > On 28.03.17 at 11:14, wrote: >>> I'm not sure that the RETRY model is what the guest OS expects. AFAIK, a >>> failed CMPXCHG should happen just once, with the proper registers and ZF >>> set. The guest surely expe

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Razvan Cojocaru
On 03/28/2017 01:47 PM, Jan Beulich wrote: On 28.03.17 at 12:27, wrote: >> On 03/28/2017 01:03 PM, Jan Beulich wrote: >> On 28.03.17 at 11:14, wrote: I'm not sure that the RETRY model is what the guest OS expects. AFAIK, a failed CMPXCHG should happen just once, with the proper

Re: [Xen-devel] [PATCH v2 3/7] x86/hvm: convert gsi_assert_count into a variable size array

2017-03-28 Thread Roger Pau Monne
On Tue, Mar 28, 2017 at 04:33:49AM -0600, Jan Beulich wrote: > >>> On 28.03.17 at 11:59, wrote: > > On Tue, Mar 28, 2017 at 03:49:23AM -0600, Jan Beulich wrote: > >> >>> On 28.03.17 at 11:34, wrote: > >> > On Tue, Mar 28, 2017 at 03:10:27AM -0600, Jan Beulich wrote: > >> >> >>> On 28.03.17 at 10:

[Xen-devel] [linux-linus test] 106946: regressions - FAIL

2017-03-28 Thread osstest service owner
flight 106946 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/106946/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 11 guest-start fail REGR. vs. 59254 test-armhf-armhf-xl

Re: [Xen-devel] [PATCH v3 00/21] x86/xen: untangle PV and PVHVM guest support code

2017-03-28 Thread Vitaly Kuznetsov
Juergen Gross writes: > On 14/03/17 18:35, Vitaly Kuznetsov wrote: >> Changes since v2: ... > > Series pushed to kernel/git/xen/tip.git for-linus-4.12 with one fixup > patch added: smp_pv.c had a duplicate xen_call_function_interrupt() > defined but not used. I removed it again. Thanks! -- V

Re: [Xen-devel] [PATCH RFC] x86/emulate: implement hvmemul_cmpxchg() with an actual CMPXCHG

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 12:50, wrote: > On 03/28/2017 01:47 PM, Jan Beulich wrote: > On 28.03.17 at 12:27, wrote: >>> On 03/28/2017 01:03 PM, Jan Beulich wrote: >>> On 28.03.17 at 11:14, wrote: > I'm not sure that the RETRY model is what the guest OS expects. AFAIK, a > failed CMPXCHG

Re: [Xen-devel] [PATCH v2 6/7] x86/ioapic: add prototype for apic_gsi_base to io_apic.h

2017-03-28 Thread Jan Beulich
>>> On 27.03.17 at 12:18, wrote: > So that the function can be called from other files without adding prototypes > to each of them. > > Signed-off-by: Roger Pau Monné Acked-by: Jan Beulich albeit perhaps ... > Changes since v1: > - Add io_ prefix to avoid confusion. ... this should be carri

Re: [Xen-devel] [PATCH v2 5/7] x86/vioapic: introduce support for multiple vIO APICS

2017-03-28 Thread Roger Pau Monne
On Tue, Mar 28, 2017 at 04:32:05AM -0600, Jan Beulich wrote: > >>> On 27.03.17 at 12:18, wrote: > > Changes since v1: > > - Constify some parameters. > > Considering this I'm surprised the first thing I have to ask is ... > > > --- a/xen/arch/x86/hvm/vioapic.c > > +++ b/xen/arch/x86/hvm/vioapic

Re: [Xen-devel] [PATCH v2 7/7] x86/vioapic: allow PVHv2 Dom0 to have more than one IO APIC

2017-03-28 Thread Jan Beulich
>>> On 27.03.17 at 12:18, wrote: > The base address, id and number of pins of the vIO APICs exposed to PVHv2 Dom0 > is the same as the values found on bare metal. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich with ... > --- a/xen/arch/x86/hvm/vioapic.c > +++ b/xen/arch/x86/hvm/v

Re: [Xen-devel] [PATCH v2 5/7] x86/vioapic: introduce support for multiple vIO APICS

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 13:40, wrote: > On Tue, Mar 28, 2017 at 04:32:05AM -0600, Jan Beulich wrote: >> >>> On 27.03.17 at 12:18, wrote: >> > @@ -454,33 +517,70 @@ HVM_REGISTER_SAVE_RESTORE(IOAPIC, ioapic_save, >> > ioapic_load, 1, HVMSR_PER_DOM); >> > >> > void vioapic_reset(struct domain *d) >>

Re: [Xen-devel] [Xen-users] "Hello Xen Project" Book.

2017-03-28 Thread Lars Kurth
> On 16 Mar 2017, at 05:00, Juergen Gross wrote: > > On 15/03/17 19:05, Mohsen wrote: >> Thank you so much Lars. >> I used LibreOffice and I will test HTML format and inform you. > > You are aware of the MediaWiki export function of LibreOffice? Yes, but I have not been able to find the extens

Re: [Xen-devel] [GSoC] GSoC Introduction : Fuzzing Xen hypercall interface

2017-03-28 Thread Wei Liu
On Tue, Mar 28, 2017 at 10:21:14AM +0100, Lars Kurth wrote: > Hi all, > > I wanted to add a few thoughts here, as this is clearly one of the harder > tasks. It's really hard. I don't even expect an experienced Xen developer to be able to finish all three goals in three months. Felix, don't feel

Re: [Xen-devel] [Xen-users] "Hello Xen Project" Book.

2017-03-28 Thread Juergen Gross
On 28/03/17 13:51, Lars Kurth wrote: > >> On 16 Mar 2017, at 05:00, Juergen Gross wrote: >> >> On 15/03/17 19:05, Mohsen wrote: >>> Thank you so much Lars. >>> I used LibreOffice and I will test HTML format and inform you. >> >> You are aware of the MediaWiki export function of LibreOffice? > >

Re: [Xen-devel] [PATCH v5] tools/firmware: add ACPI device for Windows laptop/slate mode switch

2017-03-28 Thread Wei Liu
On Tue, Mar 28, 2017 at 09:42:26AM +0100, Paul Durrant wrote: > Microsoft have defined an ACPI device to support switching Windows 10 > between laptop/desktop mode and slate/tablet mode [1]. > > This patch adds an SSDT containing such a device. The presence of the > device is controlled by a new '

Re: [Xen-devel] [PATCH v9 12/25] x86: refactor psr: L3 CAT: set value: implement cos id picking flow.

2017-03-28 Thread Yi Sun
On 17-03-28 04:40:41, Jan Beulich wrote: > >>> On 28.03.17 at 12:31, wrote: > > On 17-03-28 02:45:13, Jan Beulich wrote: > >> >>> On 28.03.17 at 06:58, wrote: > >> > On 17-03-27 04:37:37, Jan Beulich wrote: > >> >> >>> On 16.03.17 at 12:08, wrote: > >> >> > +static bool cat_fits_cos_max(const ui

[Xen-devel] [qemu-mainline test] 106949: trouble: blocked/broken/fail/pass

2017-03-28 Thread osstest service owner
flight 106949 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/106949/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 3 host-install(3) broken REGR. vs. 1069

Re: [Xen-devel] [PATCH v2] libxl/xl: add support for Xen 9pfs

2017-03-28 Thread Wei Liu
On Mon, Mar 27, 2017 at 03:19:41PM -0700, Stefano Stabellini wrote: > Add functions to libxl to setup a Xen 9pfs frontend/backend connection. > Add support to xl to parse a 9pfs option in the VM config file, in the > following format: > > p9=["tag=share_dir,security_model=none,path=/root/share_dir

Re: [Xen-devel] [PATCH v9 12/25] x86: refactor psr: L3 CAT: set value: implement cos id picking flow.

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 13:59, wrote: > I think we at least need a 'get_val()' hook. Of course. > I try to implement CAT/CDP hook. > Please help to check if this is what you thought. One remark below, but other than that - yes. > static void cat_get_val(const struct feat_node *feat, unsigned int co

Re: [Xen-devel] [PATCH] x86/monitor: add support for descriptor access events

2017-03-28 Thread Vlad-Ioan TOPAN
On Tue, 21 Mar 2017 12:04:02 + Andrew Cooper wrote: > On 10/03/17 15:50, Vlad Ioan Topan wrote: > > Adds monitor support for descriptor access events (reads & writes of > > IDTR/GDTR/LDTR/TR) for the x86 architecture (VMX and SVM). > > > > Signed-off-by: Vlad Ioan Topan > > How much extra o

[Xen-devel] [PATCH v4] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP

2017-03-28 Thread vijay . kilari
From: Vijaya Kumar K On ARM64, virt_to_mfn uses the hardware for address translation. So if the virtual address is not mapped translation fault is raised. On ARM64, DIRECTMAP_VIRT region is direct mapped. On ARM platforms with NUMA, While initializing second memory node, panic is triggered from

[Xen-devel] [ovmf test] 106955: all pass - PUSHED

2017-03-28 Thread osstest service owner
flight 106955 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/106955/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3efa3f3d05ea3fef964e59aea9b5792cfec348ed baseline version: ovmf 844b2d072d6405806398f

Re: [Xen-devel] [PATCH v4] boot allocator: Use arch helper for virt_to_mfn on DIRECTMAP

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 14:35, wrote: > From: Vijaya Kumar K > > On ARM64, virt_to_mfn uses the hardware for address > translation. So if the virtual address is not mapped translation > fault is raised. On ARM64, DIRECTMAP_VIRT region is direct mapped. > > On ARM platforms with NUMA, While initializ

Re: [Xen-devel] [Xen-users] "Hello Xen Project" Book.

2017-03-28 Thread M A Young
On Tue, 28 Mar 2017, Juergen Gross wrote: > On 28/03/17 13:51, Lars Kurth wrote: > > > >> On 16 Mar 2017, at 05:00, Juergen Gross wrote: > >> > >> On 15/03/17 19:05, Mohsen wrote: > >>> Thank you so much Lars. > >>> I used LibreOffice and I will test HTML format and inform you. > >> > >> You are

Re: [Xen-devel] arm64: dma_to_phys/phys_to_dma need to be properly implemented

2017-03-28 Thread Andrii Anisov
Hello, I guess Oleksandr stepped into the issue described here https://lists.xenproject.org/archives/html/xen-devel/2017-01/msg03454.html . He uses an old version of the patch but effectively calls __generic_dma_ops(dev)->get_sgtable() with foreign pages so faced troubles. Sincerely, Andrii A

Re: [Xen-devel] arm64: dma_to_phys/phys_to_dma need to be properly implemented

2017-03-28 Thread Oleksandr Andrushchenko
indeed, this seems to be the case So, in that mail thread we have the following statement: "However, if that's not the case in any of the drivers, it would lead to memory corruptions." with respect to get_sgtable and pfn != mfn. So, do you guys think I'll have to patch the offending driver? An

Re: [Xen-devel] [PATCH v2 09/27] ARM: GICv3: introduce separate pending_irq structs for LPIs

2017-03-28 Thread Julien Grall
Hi Jan, On 28/03/17 08:58, Jan Beulich wrote: On 27.03.17 at 20:39, wrote: CC'ing Andrew, Jan and George to get more feedback on the security impact of this patch. I'll make a quick summary for you: we need to allocate a 56 bytes struct (called pending_irq) for each potential interrupt inject

[Xen-devel] [PATCH v2 1/2] x86/io: rename misleading dpci_ prefixed functions to g2m_

2017-03-28 Thread Roger Pau Monne
The dpci_ prefix used on those IO handlers is misleading, there's nothing PCI specific in them, they simply map a guest IO port into a machine (physical) IO port. They don't specifically trap the PCI IO port range in any way (0xcf8/0xcfc). Rename them to use the g2m_ prefix in order to avoid this

[Xen-devel] [PATCH v2 2/2] x86/io: move the list of guest to machine IO ports out of domain_iommu

2017-03-28 Thread Roger Pau Monne
There's no reason to store that list inside of the domain_iommu struct, the forwarding of guest IO ports into machine IO ports is not tied to the presence of an IOMMU. Move it inside of the hvm_domain struct instead. Signed-off-by: Roger Pau Monné --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Paul

[Xen-devel] [PATCH v2 0/2] x86/io: rename dpci_ IO port handlers

2017-03-28 Thread Roger Pau Monne
Hello, The following series contain two cosmetic fixes for the g2m IO port handlers. The first one renames them to use the g2m_ prefix instead of the dpci_ one, since those handlers are not trapping the PCI config space in any way. The second fix moves the list of ports from the domain_iommu struc

[Xen-devel] [PATCH v3] dm_op: Add xendevicemodel_modified_memory_bulk.

2017-03-28 Thread Jennifer Herbert
From: Jennifer Herbert This new lib devicemodel call allows multiple extents of pages to be marked as modified in a single call. This is something needed for a usecase I'm working on. The xen side of the modified_memory call has been modified to accept an array of extents. The devicemodle libr

Re: [Xen-devel] [Qemu-devel] [RFC QEMU PATCH v2 00/10] Implement vNVDIMM for Xen HVM guest

2017-03-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC QEMU PATCH v2 00/10] Implement vNVDIMM for Xen HVM guest Message-id: 20170320001249.25521-1-haozhong.zh...@intel.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BA

[Xen-devel] [distros-debian-snapshot test] 71112: trouble: blocked/broken

2017-03-28 Thread Platform Team regression test user
flight 71112 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/71112/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 3 host-install(3) broken R

Re: [Xen-devel] [PATCH v2 09/27] ARM: GICv3: introduce separate pending_irq structs for LPIs

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 15:12, wrote: > Hi Jan, > > On 28/03/17 08:58, Jan Beulich wrote: > On 27.03.17 at 20:39, wrote: >>> CC'ing Andrew, Jan and George to get more feedback on the security >>> impact of this patch. >>> >>> I'll make a quick summary for you: we need to allocate a 56 bytes struc

Re: [Xen-devel] [PATCH v3] x86/time: Don't use virtual TSC if host and guest frequencies are equal

2017-03-28 Thread Olaf Hering
Am Fri, 17 Mar 2017 14:15:26 -0400 schrieb Boris Ostrovsky : > Commit 82713ec8d2 ("x86: use native RDTSC(P) execution when guest and > host frequencies are the same") left out optimization for PV guests > when host and guest run at the same frequency. > > For such a case we should be able not to

Re: [Xen-devel] [PATCH v2 11/12] tools/libxc: add support of injecting MC# to specified CPUs

2017-03-28 Thread Wei Liu
On Fri, Mar 17, 2017 at 02:46:13PM +0800, Haozhong Zhang wrote: > Though XEN_MC_inject_v2 allows injecting MC# to specified CPUs, the > current xc_mca_op() does not use this feature and not provide an > interface to callers. This commit add a new xc_mca_op_inject_v2() that > receives a cpumap provi

Re: [Xen-devel] [PATCH v2 12/12] tools/xen-mceinj: add support of injecting LMCE

2017-03-28 Thread Wei Liu
On Fri, Mar 17, 2017 at 02:46:14PM +0800, Haozhong Zhang wrote: > If option '-l' or '--lmce' is specified and the host supports LMCE, > xen-mceinj will inject LMCE to CPU specified by '-c' (or CPU0 if '-c' > is not present). > > Signed-off-by: Haozhong Zhang Acked-by: Wei Liu

Re: [Xen-devel] [PATCH v9 24/25] tools: L2 CAT: support set cbm for L2 CAT.

2017-03-28 Thread Wei Liu
On Thu, Mar 16, 2017 at 07:08:14PM +0800, Yi Sun wrote: > This patch implements the xl/xc changes to support set CBM > for L2 CAT. > > The new level option is introduced to original CAT setting > command in order to set CBM for specified level CAT. > - 'xl psr-cat-set' is updated to set cache capa

[Xen-devel] Xen 4.9 Development Update

2017-03-28 Thread Julien Grall
This email only tracks big items for xen.git tree. Please reply for items you woulk like to see in 4.9 so that people have an idea what is going on and prioritise accordingly. You're welcome to provide description and use cases of the feature you're working on. = Timeline = We now adopt a fixed

Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-28 Thread Boris Ostrovsky
On 03/28/2017 04:08 AM, Jan Beulich wrote: On 28.03.17 at 03:57, wrote: >> I think there is indeed a disconnect between target memory (provided by >> the toolstack) and current memory (i.e actual pages available to the guest). >> >> For example >> >> [0.00] BIOS-e820: [mem 0x

Re: [Xen-devel] [PATCH RFC 00/20] Add postcopy live migration support

2017-03-28 Thread Wei Liu
Hi Harley, Chester and Joshua This is really nice work. I took a brief look at all the patches, they look really high quality. We're currently approaching freeze for a Xen release. We've got a lot on our plate. I think maintainers will get to this series at some point. From the look of things so

Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-28 Thread Jan Beulich
>>> On 28.03.17 at 16:27, wrote: > Which leaves hvmloader's special pages (and possibly memory under > 0xA which may get reserved). Can we pass this info to guests via > xenstore? I'm perhaps the wrong one to ask regarding xenstore, but for in-guest communication this seems an at least strang

[Xen-devel] Xen ARM community call - meeting minutes and date for the next one

2017-03-28 Thread Julien Grall
Hi all, Apologies for the late sending, you will find at the end of the e-mail a summary of the discussion from the previous call. Feel free to reply if I missed some parts. I suggest to have the next call on the 5th April at 5PM UTC. Any opinions? Also do you have any specific topic you would l

[Xen-devel] IMPORTANT INFO FOR MENTORS: Outreachy and GSoc deadlines (Outreachy March 30, GSoC April 4) + Next Steps

2017-03-28 Thread Lars Kurth
Hi everyone, on the TO list: mailing lists where people have submitted queries and/or have projects and program coordinators on the CC list: possible mentors I have seen engaging with applicants (for the Hypervisor I also added committers@) @Mindy: could you please look at the Mirage OS section

Re: [Xen-devel] maybe revert commit c275a57f5ec3 "xen/balloon: Set balloon's initial state to number of existing RAM pages"

2017-03-28 Thread Juergen Gross
On 28/03/17 16:27, Boris Ostrovsky wrote: > On 03/28/2017 04:08 AM, Jan Beulich wrote: > On 28.03.17 at 03:57, wrote: >>> I think there is indeed a disconnect between target memory (provided by >>> the toolstack) and current memory (i.e actual pages available to the guest). >>> >>> For exampl

Re: [Xen-devel] IMPORTANT INFO FOR MENTORS: Outreachy and GSoc deadlines (Outreachy March 30, GSoC April 4) + Next Steps

2017-03-28 Thread Mindy
On 03/28/2017 10:29 AM, Lars Kurth wrote: Hi everyone, on the TO list: mailing lists where people have submitted queries and/or have projects and program coordinators on the CC list: possible mentors I have seen engaging with applicants (for the Hypervisor I also added committers@) @Mindy:

Re: [Xen-devel] IMPORTANT INFO FOR MENTORS: Outreachy and GSoc deadlines (Outreachy March 30, GSoC April 4) + Next Steps

2017-03-28 Thread Lars Kurth
Added Thomas to the CC list Lars > On 28 Mar 2017, at 16:31, Mindy wrote: > > On 03/28/2017 10:29 AM, Lars Kurth wrote: >> Hi everyone, >> >> on the TO list: mailing lists where people have submitted queries and/or >> have projects and program coordinators >> on the CC list: possible mentors

  1   2   3   >