Re: [Xen-devel] [PATCH] x86/p2m: Stop other vcpus using a nested p2m before clearing it

2017-02-08 Thread Jan Beulich
>>> On 07.02.17 at 19:48, wrote: > Until the IPI has completed, other processors might be running on this nested > p2m object. clear_domain_page() does not guarantee to make 8-byte atomic > updates, which means that a pagewalk on a remote processor might encounter a > partial update. > > This is

[Xen-devel] [PATCH 3/9] libxl: carve out scheduler specific functions from libxl.c

2017-02-08 Thread Juergen Gross
libxl.c has grown to an uncomfortable size. Carve out the scheduler related functions to libxl_sched.c. Signed-off-by: Juergen Gross --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.c | 891 tools/libxl/libxl_sched.c | 915 +

[Xen-devel] [PATCH 9/9] libxl: carve out domain specific functions from libxl.c

2017-02-08 Thread Juergen Gross
libxl.c has grown to an uncomfortable size. Carve out the domain related functions to libxl_domain.c. Signed-off-by: Juergen Gross --- tools/libxl/Makefile |1 + tools/libxl/libxl.c| 1724 --- tools/libxl/libxl_domain.c | 1744 +++

[Xen-devel] [PATCH 7/9] libxl: move device specific functions out of libxl.c

2017-02-08 Thread Juergen Gross
Move the few generic device specific functions left in libxl.c to libxl_device.c. Signed-off-by: Juergen Gross --- tools/libxl/libxl.c | 416 - tools/libxl/libxl_device.c | 435 +-- tools/libxl/libxl_inter

[Xen-devel] [PATCH 8/9] libxl: carve out tmem specific functions from libxl.c

2017-02-08 Thread Juergen Gross
libxl.c has grown to an uncomfortable size. Carve out the tmem related functions to libxl_tmem.c. Signed-off-by: Juergen Gross --- tools/libxl/Makefile | 2 +- tools/libxl/libxl.c | 142 tools/libxl/libxl_tmem.c | 167 ++

Re: [Xen-devel] [PATCH] x86/p2m: Stop other vcpus using a nested p2m before clearing it

2017-02-08 Thread Andrew Cooper
On 08/02/17 13:13, Jan Beulich wrote: On 07.02.17 at 19:48, wrote: >> Until the IPI has completed, other processors might be running on this nested >> p2m object. clear_domain_page() does not guarantee to make 8-byte atomic >> updates, which means that a pagewalk on a remote processor might

Re: [Xen-devel] [PATCH v2 1/2] x86/vmx: Introduce a bitfield structure for EPT_VIOLATION EXIT_QUALIFICATIONs

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 14:03, wrote: > On 08/02/17 12:30, Jan Beulich wrote: > On 08.02.17 at 12:56, wrote: >>> On 08/02/17 11:53, Jan Beulich wrote: >>> On 08.02.17 at 11:44, wrote: > On 08/02/17 10:42, Andrew Cooper wrote: >> This results in rather more readable code. No functiona

Re: [Xen-devel] [PATCH] x86/p2m: Reposition p2m_teardown_nestedp2m() to avoid its forward declaration

2017-02-08 Thread Jan Beulich
>>> On 07.02.17 at 19:43, wrote: > While adjusting these functions, use unsigned int rather than uint8_t for the > loop variable, and fix the whitespace style. > > No functional change. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich __

Re: [Xen-devel] [PATCH v3 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 11:09, wrote: > Any fail during the original __vmwrite() leads to BUG() which can be > easily exploited from a guest in the nested vmx mode. > > The new function returns error code depending on the outcome: > > VMsucceed: 0 > VMfailValid: VM Instruction Error

[Xen-devel] [PATCH v3] libxl: don't segfault when creating domain with invalid pvusb device

2017-02-08 Thread Juergen Gross
Creating a domain with an invalid controller specification for a pvusb device will currently segfault. Avoid this by bailing out early in case of a mandatory xenstore path not existing. Signed-of-by: Juergen Gross --- This patch is a backport candidate for 4.8 V2: introduce libxl__xs_read_manda

Re: [Xen-devel] [PATCH v3 2/4] x86/vmx: improve vmread_safe()

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 11:09, wrote: > The original function doesn't distinguish between Valid and Invalid > VMfails. Improved function returns error code depending on the outcome: > > VMsucceed: 0 > VMfailValid: VM Instruction Error Number > VMfailInvalid: VMX_INSN_FAIL_INVALID (~

Re: [Xen-devel] [libvirt] [PATCH 2/2] libxl: fix dom0 maximum memory setting

2017-02-08 Thread Joao Martins
On 02/02/2017 10:31 PM, Jim Fehlig wrote: > When the libxl driver is initialized, it creates a virDomainDef > object for dom0 and adds it to the list of domains. Total memory > for dom0 was being set from the max_memkb field of libxl_dominfo > struct retrieved from libxl, but this field can be set

Re: [Xen-devel] [PATCH v6] x86/hvm: add vcpu parameter to guest memory copy function

2017-02-08 Thread Jan Beulich
>>> On 07.02.17 at 18:35, wrote: > Current __hvm_copy assumes that the destination memory belongs to the current > vcpu, but this is not always the case since for PVHv2 Dom0 build hvm copy > functions are used with current being the idle vcpu. Add a new vcpu > parameter > to hvm copy in order to

Re: [Xen-devel] [PATCH v3 3/4] x86/vvmx: correctly emulate VMWRITE

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 11:09, wrote: > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -305,6 +305,19 @@ void set_vvmcs_real(const struct vcpu *v, u32 encoding, > u64 val) > virtual_vmcs_vmwrite(v, encoding, val); > } > > +enum vmx_insn_errno set_vvmcs_virtual_safe(

Re: [Xen-devel] [PATCH v14 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-02-08 Thread Daniel Kiper
On Mon, Feb 06, 2017 at 03:18:53AM -0700, Jan Beulich wrote: > >>> On 02.02.17 at 23:01, wrote: > > This way Xen can be loaded on EFI platforms using GRUB2 and > > other boot loaders which support multiboot2 protocol. > > > > Signed-off-by: Daniel Kiper > > --- > > v14 - suggestions/fixes: > >

[Xen-devel] [xen-unstable test] 105629: tolerable FAIL

2017-02-08 Thread osstest service owner
flight 105629 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/105629/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt-xsm 13 saverestore-support-checkfail like 105619 test-amd64-i386-xl-qemuu-wi

Re: [Xen-devel] [PATCH v14 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 14:44, wrote: > On Mon, Feb 06, 2017 at 03:18:53AM -0700, Jan Beulich wrote: >> >>> On 02.02.17 at 23:01, wrote: >> > bad_cpu: >> > mov $(sym_phys(.Lbad_cpu_msg)),%esi # Error message >> > -jmp print_err >> > +jmp .Lget_vtb >> > not_multib

[Xen-devel] [qemu-mainline test] 105630: regressions - FAIL

2017-02-08 Thread osstest service owner
flight 105630 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/105630/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm5 xen-buildfail REGR. vs. 105279 build-amd64

Re: [Xen-devel] [PATCH] x86/shadow: Correct the behaviour of a guests view of maxphysaddr

2017-02-08 Thread Tim Deegan
Hi, At 12:36 + on 08 Feb (1486557378), Andrew Cooper wrote: > XSA-173 (c/s 8b1764833) introduces gfn_bits, and an upper limit which might be > lower than the real maxphysaddr, to avoid overflowing the superpage shadow > backpointer. > > However, plenty of hardware has a physical address width

[Xen-devel] [linux-linus test] 105625: regressions - FAIL

2017-02-08 Thread osstest service owner
flight 105625 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/105625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 16 guest-saverestore.2 fail REGR. vs. 59254 test-amd64-amd64-xl

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-08 Thread Julien Grall
Hi, On 07/02/17 15:59, Vijay Kilari wrote: > On Tue, Feb 7, 2017 at 6:57 PM, Julien Grall wrote: >> >> >> On 07/02/2017 13:25, Vijay Kilari wrote: >>> >>> On Tue, Feb 7, 2017 at 6:30 PM, Julien Grall wrote: One more thing, if Xen 4.7 was able to go up to booting Dom0 without any >

Re: [Xen-devel] IOMMU fault with IGD passthrough setup on XEN 4.8.0

2017-02-08 Thread G.R.
On Wed, Feb 8, 2017 at 8:44 PM, Jan Beulich wrote: On 07.02.17 at 16:44, wrote: >> On Mon, Feb 6, 2017 at 8:40 PM, Jan Beulich wrote: >> On 05.02.17 at 06:51, wrote: I finally get some spare time to collect the debug info. >>> >>> As I continue to be puzzled, best I could come up

Re: [Xen-devel] [RFC XEN PATCH 06/16] tools: reserve guest memory for ACPI from device model

2017-02-08 Thread Konrad Rzeszutek Wilk
On Wed, Feb 08, 2017 at 09:39:09AM +0800, Haozhong Zhang wrote: > On 01/27/17 15:44 -0500, Konrad Rzeszutek Wilk wrote: > > On Mon, Oct 10, 2016 at 08:32:25AM +0800, Haozhong Zhang wrote: > > > One guest page is reserved for the device model to place guest ACPI. The > > > > guest ACPI what? ACPI S

Re: [Xen-devel] [PATCH v3] xen-netfront: Improve error handling during initialization

2017-02-08 Thread Boris Ostrovsky
On 02/08/2017 05:57 AM, Ross Lagerwall wrote: > This fixes a crash when running out of grant refs when creating many > queues across many netdevs. > > * If creating queues fails (i.e. there are no grant refs available), > call xenbus_dev_fatal() to ensure that the xenbus device is set to the > clos

Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c

2017-02-08 Thread Ian Jackson
Juergen Gross writes ("[PATCH 0/9] libxl: spolit up libxl.c"): > Code movement only. No functional change intended. This statement is not true because > Juergen Gross (9): > libxl: adjust copyright comment of libxl.c ... that patch is not just code motion. Can you please double-check, and exp

Re: [Xen-devel] [RFC XEN PATCH 11/16] tools/libacpi: load ACPI built by the device model

2017-02-08 Thread Konrad Rzeszutek Wilk
.giant snip.. > > > + * - "type": > > > + * * DM_ACPI_BLOB_TYPE_TABLE > > > + * The data blob specified by this directory is an ACPI table. > > > + * * DM_ACPI_BLOB_TYPE_NSDEV > > > + * The data blob specified by this directory is an ACPI namespace > > > device. > > > + * Its name

Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c

2017-02-08 Thread Wei Liu
Cc Yi Sun as well. Haozhong and Yi: This is just a heads-up -- Juergen from SuSE took the time to split libxl.c so things are better organised. It's likely this series will go in before yours, so you will then need to rebase your series. I don't expect there to be much breakage because it is all m

Re: [Xen-devel] [PATCH v3] libxl: don't segfault when creating domain with invalid pvusb device

2017-02-08 Thread Ian Jackson
Juergen Gross writes ("[PATCH v3] libxl: don't segfault when creating domain with invalid pvusb device"): > Creating a domain with an invalid controller specification for a pvusb > device will currently segfault. Acked-by: Ian Jackson Good choice of function name, thanks. Ian. ___

Re: [Xen-devel] [RFC XEN PATCH 13/16] tools/libxl: add support to map host pmem device to guests

2017-02-08 Thread Konrad Rzeszutek Wilk
. snip.. > After consulting the driver developers, I'm going to remove the file > support in the version, because there is current no stable way to fix > the mapping between file extents and their physical locations (some of > my previous understanding about file mapping was wrong). Could you exp

[Xen-devel] [distros-debian-squeeze test] 68536: tolerable trouble: broken/fail/pass

2017-02-08 Thread Platform Team regression test user
flight 68536 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68536/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-i386-squeeze-netboot-pygrub 9 debian-di-install fail blocked in 68503 test-am

Re: [Xen-devel] [PATCH v3 2/2] xen/kbdif: add multi-touch support

2017-02-08 Thread Konrad Rzeszutek Wilk
On Wed, Feb 08, 2017 at 09:38:18AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Multi-touch fields re-use the page that is used by the other features > which means that you can interleave multi-touch, motion, and key > events. > > Reviewed-by: Stefano Stabellini Re

[Xen-devel] [PATCH 1/2] tools/libxc: Introduce XC_CPUPOOL_POOLID_ANY

2017-02-08 Thread George Dunlap
Callers to xc_cpupool_create() can either request a specific pool id, or request that Xen do it for them. But at the moment, the "automatic" selection is indicated by using a magic value, 0. This is undesirable both because it doesn't obviously have meaning, but also because '0' is a valid cpupoo

[Xen-devel] [PATCH 2/2] tools/libxl: Introduce LIBXL_CPUPOOL_POOLID_ANY

2017-02-08 Thread George Dunlap
Callers to libxl_cpupool_create() can either request a specific pool id, or request that Xen do it for them. But at the moment, the "automatic" selection is indicated by using a magic value, 0. This is undesirable both because it doesn't obviously have meaning, but also because '0' is a valid cpu

[Xen-devel] [xen-unstable-smoke test] 105637: tolerable trouble: broken/fail/pass - PUSHED

2017-02-08 Thread osstest service owner
flight 105637 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/105637/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a build-arm64 5 xen

Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c

2017-02-08 Thread Juergen Gross
On 08/02/17 15:33, Ian Jackson wrote: > Juergen Gross writes ("[PATCH 0/9] libxl: spolit up libxl.c"): >> Code movement only. No functional change intended. > > This statement is not true because > >> Juergen Gross (9): >> libxl: adjust copyright comment of libxl.c > > ... that patch is not ju

Re: [Xen-devel] IOMMU fault with IGD passthrough setup on XEN 4.8.0

2017-02-08 Thread G.R.
On Wed, Feb 8, 2017 at 10:29 PM, G.R. wrote: > On Wed, Feb 8, 2017 at 8:44 PM, Jan Beulich wrote: > On 07.02.17 at 16:44, wrote: >>> On Mon, Feb 6, 2017 at 8:40 PM, Jan Beulich wrote: >>> On 05.02.17 at 06:51, wrote: > I finally get some spare time to collect the debug info. >

Re: [Xen-devel] PML causing race condition during guest bootstorm and host crash on Broadwell cpu.

2017-02-08 Thread anshul makkar
Hi, Code is trying to destroy multiple vcpus held by the domain: complete_domain_destroy->hvm_vcpu_destroy() for each vcpu. In vmx_vcpu_destroy, we have a call for vmx_vcpu_disable_pml which leads to a race while destroying foreign vcpu's with other domains rebooting on the same vcpus . Wi

[Xen-devel] [ovmf baseline-only test] 68535: all pass

2017-02-08 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68535 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68535/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d03c056b2946cc2f83b6d206297915dadc08f230 baseline v

[Xen-devel] [linux-3.18 test] 105632: tolerable FAIL - PUSHED

2017-02-08 Thread osstest service owner
flight 105632 linux-3.18 real [real] http://logs.test-lab.xenproject.org/osstest/logs/105632/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt-raw 12 saverestore-support-checkfail like 104271 test-armhf-armhf-libvirt

Re: [Xen-devel] [PATCH] xen-netfront: Rework the fix for Rx stall during OOM and network stress

2017-02-08 Thread Boris Ostrovsky
On 02/07/2017 01:59 PM, Vineeth Remanan Pillai wrote: > The commit 90c311b0eeea ("xen-netfront: Fix Rx stall during network > stress and OOM") caused the refill timer to be triggerred almost on > all invocations of xennet_alloc_rx_buffers for certain workloads. > This reworks the fix by reverting t

Re: [Xen-devel] [PATCH v2 1/2] x86/vmx: Introduce a bitfield structure for EPT_VIOLATION EXIT_QUALIFICATIONs

2017-02-08 Thread Andrew Cooper
On 08/02/17 13:28, Jan Beulich wrote: On 08.02.17 at 14:03, wrote: >> On 08/02/17 12:30, Jan Beulich wrote: >> On 08.02.17 at 12:56, wrote: On 08/02/17 11:53, Jan Beulich wrote: On 08.02.17 at 11:44, wrote: >> On 08/02/17 10:42, Andrew Cooper wrote: >>> This result

Re: [Xen-devel] [PATCH v5 9/9] xen/x86: setup PVHv2 Dom0 ACPI tables

2017-02-08 Thread Roger Pau Monne
On Thu, Jan 26, 2017 at 07:16:32AM -0700, Jan Beulich wrote: > >>> On 19.01.17 at 18:29, wrote: > > +static int __init pvh_setup_acpi_madt(struct domain *d, paddr_t *addr) > > +{ > > +struct acpi_table_madt *madt; > > +struct acpi_table_header *table; > > +struct acpi_madt_io_apic *io_

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Konrad Rzeszutek Wilk
On Wed, Feb 08, 2017 at 10:48:45AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Add ABI for the two halves of a para-virtualized > sound driver to communicate with each other. > > The ABI allows implementing audio playback and capture as > well as volume control and

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Oleksandr Andrushchenko
On 02/08/2017 05:16 PM, Konrad Rzeszutek Wilk wrote: On Wed, Feb 08, 2017 at 10:48:45AM +0200, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Add ABI for the two halves of a para-virtualized sound driver to communicate with each other. The ABI allows implementing audio playbac

Re: [Xen-devel] [xen-unstable test] 104131: regressions - FAIL

2017-02-08 Thread Chao Gao
On Wed, Feb 08, 2017 at 10:15:28AM +, Xuquan (Quan Xu) wrote: >On February 08, 2017 4:52 PM, Jan Beulich wrote: > On 08.02.17 at 09:27, wrote: >>> Assumed vCPU is in guest_mode.. >>> When apicv is enabled, hypervisor calls vmx_deliver_posted_intr(), >>> then >>> __vmx_deliver_posted_interr

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Konrad Rzeszutek Wilk
. snip.. > > Reviewed-by: Konrad Rzeszutek Wilk > Do you want me to send v18 with the changes requested? Please wait a week for other folks to get a chance to look at this patch. > May I put your "Reviewed-by: Konrad Rzeszutek Wilk" in v18? Of course! Do please put my Reviewed-by on the patch a

Re: [Xen-devel] [PATCH] x86/shadow: Correct the behaviour of a guests view of maxphysaddr

2017-02-08 Thread Andrew Cooper
On 08/02/17 14:12, Tim Deegan wrote: > Hi, > > At 12:36 + on 08 Feb (1486557378), Andrew Cooper wrote: >> XSA-173 (c/s 8b1764833) introduces gfn_bits, and an upper limit which might >> be >> lower than the real maxphysaddr, to avoid overflowing the superpage shadow >> backpointer. >> >> Howeve

Re: [Xen-devel] [PATCH RESEND v17] xen/sndif: Add sound-device ABI

2017-02-08 Thread Oleksandr Andrushchenko
On 02/08/2017 05:29 PM, Konrad Rzeszutek Wilk wrote: . snip.. Reviewed-by: Konrad Rzeszutek Wilk Do you want me to send v18 with the changes requested? Please wait a week for other folks to get a chance to look at this patch. May I put your "Reviewed-by: Konrad Rzeszutek Wilk" in v18? Of c

Re: [Xen-devel] [PATCH] xenbus: Neaten xenbus_va_dev_error

2017-02-08 Thread Boris Ostrovsky
On 02/08/2017 06:33 AM, Joe Perches wrote: > This function error patch can be simplified, so do so. > > Remove fail: label and somewhat obfuscating, used once "error_path" > function. > > Signed-off-by: Joe Perches Applied to for-linus-4.11. -boris __

Re: [Xen-devel] PML causing race condition during guest bootstorm and host crash on Broadwell cpu.

2017-02-08 Thread Jan Beulich
>>> On 07.02.17 at 18:26, wrote: > Facing a issue where bootstorm of guests leads to host crash. I debugged > and found that that enabling PML introduces a race condition during > guest teardown stage while disabling PML on a vcpu and context switch > happening for another vcpu. > > Crash h

Re: [Xen-devel] PML causing race condition during guest bootstorm and host crash on Broadwell cpu.

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 15:58, wrote: > Code is trying to destroy multiple vcpus held by the domain: > complete_domain_destroy->hvm_vcpu_destroy() for each vcpu. > > In vmx_vcpu_destroy, we have a call for vmx_vcpu_disable_pml which leads > to a race while destroying foreign vcpu's with other domain

Re: [Xen-devel] [PATCH v3] libxl: don't segfault when creating domain with invalid pvusb device

2017-02-08 Thread Wei Liu
On Wed, Feb 08, 2017 at 02:35:53PM +, Ian Jackson wrote: > Juergen Gross writes ("[PATCH v3] libxl: don't segfault when creating domain > with invalid pvusb device"): > > Creating a domain with an invalid controller specification for a pvusb > > device will currently segfault. > > Acked-by: I

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-08 Thread Julien Grall
On 08/02/17 14:18, Julien Grall wrote: > Hi, > > On 07/02/17 15:59, Vijay Kilari wrote: >> On Tue, Feb 7, 2017 at 6:57 PM, Julien Grall wrote: >>> >>> >>> On 07/02/2017 13:25, Vijay Kilari wrote: On Tue, Feb 7, 2017 at 6:30 PM, Julien Grall wrote: > > > One more thing, if

Re: [Xen-devel] [PATCH v2 1/2] x86/vmx: Introduce a bitfield structure for EPT_VIOLATION EXIT_QUALIFICATIONs

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 16:04, wrote: > On 08/02/17 13:28, Jan Beulich wrote: > On 08.02.17 at 14:03, wrote: >>> On 08/02/17 12:30, Jan Beulich wrote: >>> On 08.02.17 at 12:56, wrote: > On 08/02/17 11:53, Jan Beulich wrote: > On 08.02.17 at 11:44, wrote: >>> On 08/02/17 10:42

Re: [Xen-devel] PML causing race condition during guest bootstorm and host crash on Broadwell cpu.

2017-02-08 Thread anshul makkar
May be "causes". But not sure, as disabling this feature solves the issue (no hypervisor crash) and we have reports that the same code base works fine on Haswell (again no hardware support for PML in Haswell, but code base is same. But inherently it leads to non-execution of PML code path, so n

Re: [Xen-devel] [PATCH v5 9/9] xen/x86: setup PVHv2 Dom0 ACPI tables

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 16:10, wrote: > On Thu, Jan 26, 2017 at 07:16:32AM -0700, Jan Beulich wrote: >> >>> On 19.01.17 at 18:29, wrote: >> > +/* >> > + * The APIC ID field of the local APIC struct is only 1byte, so we >> > need >> > + * to limit the number of local APIC entries to 128 be

Re: [Xen-devel] [PATCH v5 9/9] xen/x86: setup PVHv2 Dom0 ACPI tables

2017-02-08 Thread Roger Pau Monne
On Wed, Feb 08, 2017 at 08:50:54AM -0700, Jan Beulich wrote: > >>> On 08.02.17 at 16:10, wrote: > > On Thu, Jan 26, 2017 at 07:16:32AM -0700, Jan Beulich wrote: > >> >>> On 19.01.17 at 18:29, wrote: > >> > +/* > >> > + * The APIC ID field of the local APIC struct is only 1byte, so we > >

[Xen-devel] Update: Developer Summit and Hackathon this year

2017-02-08 Thread Lars Kurth
Hi everyone, a quick note to let you know about the status of this year's Hackathon and Developer Summit. We are running a little bit late in terms of planning, because the board asked me in November to investigate co-location with OSCON, OpenStack and a few other industry events instead of app

Re: [Xen-devel] IOMMU fault with IGD passthrough setup on XEN 4.8.0

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 15:56, wrote: > On Wed, Feb 8, 2017 at 10:29 PM, G.R. > wrote: >> On Wed, Feb 8, 2017 at 8:44 PM, Jan Beulich wrote: >> On 07.02.17 at 16:44, wrote: On Mon, Feb 6, 2017 at 8:40 PM, Jan Beulich wrote: On 05.02.17 at 06:51, wrote: >> I finally get some

Re: [Xen-devel] [PATCH v6 01/24] docs: create Cache Allocation Technology (CAT) and Code and Data Prioritization (CDP) feature document

2017-02-08 Thread Konrad Rzeszutek Wilk
On Wed, Feb 08, 2017 at 04:15:53PM +0800, Yi Sun wrote: > This patch creates CAT and CDP feature document in doc/features/. It describes > key points to implement L3 CAT/CDP and L2 CAT which is described in details in > Intel SDM "INTEL® RESOURCE DIRECTOR TECHNOLOGY (INTEL® RDT) ALLOCATION > FEATU

Re: [Xen-devel] [PATCH] x86/shadow: Correct the behaviour of a guests view of maxphysaddr

2017-02-08 Thread Tim Deegan
At 15:29 + on 08 Feb (1486567798), Andrew Cooper wrote: > On Intel, a guest can get an PTE shadowed which should have faulted and > didn't (because the smfn is actually within 39 bits) Yes. , while on AMD, a > guest can try to create a PTE which shouldn't fault (because CPUID says > anything

Re: [Xen-devel] [PATCH v6 03/24] x86: refactor psr: implement main data structures.

2017-02-08 Thread Konrad Rzeszutek Wilk
> Signed-off-by: Yi Sun Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v5 9/9] xen/x86: setup PVHv2 Dom0 ACPI tables

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 16:58, wrote: > On Wed, Feb 08, 2017 at 08:50:54AM -0700, Jan Beulich wrote: >> >>> On 08.02.17 at 16:10, wrote: >> > On Thu, Jan 26, 2017 at 07:16:32AM -0700, Jan Beulich wrote: >> >> >>> On 19.01.17 at 18:29, wrote: >> >> > +/* >> >> > + * The APIC ID field of the lo

Re: [Xen-devel] [PATCH 1/2] tools/libxc: Introduce XC_CPUPOOL_POOLID_ANY

2017-02-08 Thread Dario Faggioli
On Wed, 2017-02-08 at 14:51 +, George Dunlap wrote: > Callers to xc_cpupool_create() can either request a specific pool id, > or request that Xen do it for them.  But at the moment, the > "automatic" selection is indicated by using a magic value, 0.  This > is > undesirable both because it does

Re: [Xen-devel] [PATCH v3] x86/ept: Allow write-combining on !mfn_valid() MMIO mappings again

2017-02-08 Thread David Woodhouse
On Thu, 2017-01-26 at 14:50 +, David Woodhouse wrote: > > Finally, add a comment clarifying how that 'return -1' works — it isn't > returning an error and causing the mapping to fail; it relies on… Btw, something odd happened when committing this. That U+2014 emdash in the first (cited) line

Re: [Xen-devel] [PATCH] xenbus: Neaten xenbus_va_dev_error

2017-02-08 Thread Joe Perches
On Wed, 2017-02-08 at 10:33 -0500, Boris Ostrovsky wrote: > On 02/08/2017 06:33 AM, Joe Perches wrote: > > This function error patch can be simplified, so do so. > > > > Remove fail: label and somewhat obfuscating, used once "error_path" > > function. btw: I left it alone, but likely #define PRI

Re: [Xen-devel] [libvirt] [PATCH 2/2] libxl: fix dom0 maximum memory setting

2017-02-08 Thread Jim Fehlig
Joao Martins wrote: > On 02/02/2017 10:31 PM, Jim Fehlig wrote: >> When the libxl driver is initialized, it creates a virDomainDef >> object for dom0 and adds it to the list of domains. Total memory >> for dom0 was being set from the max_memkb field of libxl_dominfo >> struct retrieved from libxl,

Re: [Xen-devel] [PATCH 2/2] tools/libxl: Introduce LIBXL_CPUPOOL_POOLID_ANY

2017-02-08 Thread Dario Faggioli
On Wed, 2017-02-08 at 14:51 +, George Dunlap wrote: > Callers to libxl_cpupool_create() can either request a specific pool > id, or request that Xen do it for them.  But at the moment, the > "automatic" selection is indicated by using a magic value, 0.  This > is > undesirable both because it d

Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c

2017-02-08 Thread Ian Jackson
Juergen Gross writes ("Re: [PATCH 0/9] libxl: spolit up libxl.c"): > Okay, more precise wording: Thanks. > Changes are: > - moving functions into new or existing sources > - modification of Copyright comment > - made two functions non-static: libxl__get_memory_target(), > xcinfo2xlinfo() > - m

Re: [Xen-devel] [PATCH 2/2] tools/libxl: Introduce LIBXL_CPUPOOL_POOLID_ANY

2017-02-08 Thread George Dunlap
On 08/02/17 16:11, Dario Faggioli wrote: > On Wed, 2017-02-08 at 14:51 +, George Dunlap wrote: >> Callers to libxl_cpupool_create() can either request a specific pool >> id, or request that Xen do it for them. But at the moment, the >> "automatic" selection is indicated by using a magic value,

Re: [Xen-devel] Enabling vm_event for a guest with more VCPUs than available ring buffer slots freezes the virtual machine

2017-02-08 Thread Tamas K Lengyel
On Tue, Feb 7, 2017 at 11:48 PM, Razvan Cojocaru wrote: > On 02/08/2017 01:23 AM, Tamas K Lengyel wrote: > > > > > > On Tue, Feb 7, 2017 at 1:41 PM, Razvan Cojocaru > > mailto:rcojoc...@bitdefender.com>> wrote: > > > > On 02/07/2017 10:20 PM, Tamas K Lengyel wrote: > > > > > > > >

Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c

2017-02-08 Thread Juergen Gross
On 08/02/17 17:12, Ian Jackson wrote: > Juergen Gross writes ("Re: [PATCH 0/9] libxl: spolit up libxl.c"): >> Okay, more precise wording: > > Thanks. > >> Changes are: >> - moving functions into new or existing sources >> - modification of Copyright comment > >> - made two functions non-static:

[Xen-devel] [ovmf test] 105636: all pass - PUSHED

2017-02-08 Thread osstest service owner
flight 105636 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/105636/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 9fe9cf9acb475af9317dcdaf32a93f1cb77d95ac baseline version: ovmf cc20411062137e5d820a3

Re: [Xen-devel] [PATCH v6 04/24] x86: refactor psr: implement CPU init and free flow.

2017-02-08 Thread Konrad Rzeszutek Wilk
.snip.. > +static void free_feature(struct psr_socket_info *info) > +{ > +struct feat_node *feat, *next; > + > +if ( !info ) > +return; > + > +/* > + * Free resources of features. But we do not free global feature list > + * entry, like feat_l3_cat. Although it may cause

[Xen-devel] [xen-unstable baseline-only test] 68534: regressions - trouble: blocked/broken/fail/pass

2017-02-08 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68534 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68534/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt-raw 9 debian-di-insta

Re: [Xen-devel] [PATCH] xen/p2m: Remove np2m-specific filter from generic p2m_flush_table

2017-02-08 Thread George Dunlap
On 08/02/17 10:02, Tim Deegan wrote: > At 03:44 -0700 on 31 Jan (1485834259), Jan Beulich wrote: > On 30.01.17 at 16:17, wrote: >>> Commit 71bb7304e7a7a35ea6df4b0cedebc35028e4c159 added flushing of >>> nested p2m tables whenever the host p2m table changed. Unfortunately >>> in the process, it

Re: [Xen-devel] [PATCH] common/vm_event: Prevent guest locking with large max_vcpus

2017-02-08 Thread Tamas K Lengyel
On Wed, Feb 8, 2017 at 2:00 AM, Razvan Cojocaru wrote: > It is currently possible for the guest to lock when subscribing > to synchronous vm_events if max_vcpus is larger than the > number of available ring buffer slots. This patch no longer > blocks already paused VCPUs, fixing the issue for thi

[Xen-devel] unmodified drivers

2017-02-08 Thread Juergen Gross
Is it still appropriate to have the unmodified_drivers subdirectory in Xen's git repository? I think it should be either moved to a separate repository or just deleted. Having Linux kernel sources in the Xen repository seems to be wrong. Thoughts? Juergen __

Re: [Xen-devel] [RFC v2 3/6] xen/arm: Allow platform_hvc to handle guest SMC calls

2017-02-08 Thread Tamas K Lengyel
On Wed, Feb 8, 2017 at 1:31 AM, Edgar E. Iglesias wrote: > On Tue, Feb 07, 2017 at 05:24:03PM -0700, Tamas K Lengyel wrote: > > On Tue, Feb 7, 2017 at 1:51 PM, Julien Grall > wrote: > > > > > Hi Tamas, > > > > > > On 07/02/2017 20:38, Tamas K Lengyel wrote: > > > > > >> > > >> > > >> On Tue, Feb

Re: [Xen-devel] unmodified drivers

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 17:32, wrote: > Is it still appropriate to have the unmodified_drivers subdirectory in > Xen's git repository? > > I think it should be either moved to a separate repository or just > deleted. Having a separate repo for these few files would seem overkill to me. As to deleting

Re: [Xen-devel] [PATCH v6 05/24] x86: refactor psr: implement Domain init/free and schedule flows.

2017-02-08 Thread Konrad Rzeszutek Wilk
On Wed, Feb 08, 2017 at 04:15:57PM +0800, Yi Sun wrote: > This patch implements the Domain init/free and schedule flows. > > Signed-off-by: Yi Sun Reviewed-by: Konrad Rzeszutek Wilk ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen

Re: [Xen-devel] [PATCH 2/5] xen: credit2: never consider CPUs outside of our cpupool.

2017-02-08 Thread Dario Faggioli
On Fri, 2017-02-03 at 08:40 -0700, Jan Beulich wrote: > > > > > > On 17.01.17 at 18:26, wrote: > > > While I did manage to backport "xen: credit2: use the correct > > > scratch > > > cpumask" and "xen: credit2: fix shutdown/suspend when playing > > > with > > > cpupools" also to 4.7, this one is e

Re: [Xen-devel] [RFC v2 3/6] xen/arm: Allow platform_hvc to handle guest SMC calls

2017-02-08 Thread Julien Grall
Hi Tamas, On 08/02/17 16:40, Tamas K Lengyel wrote: On Wed, Feb 8, 2017 at 1:31 AM, Edgar E. Iglesias mailto:edgar.igles...@xilinx.com>> wrote: On Tue, Feb 07, 2017 at 05:24:03PM -0700, Tamas K Lengyel wrote: > On Tue, Feb 7, 2017 at 1:51 PM, Julien Grall mailto:julien.gr...@arm.com>> wr

Re: [Xen-devel] unmodified drivers

2017-02-08 Thread Juergen Gross
On 08/02/17 17:41, Jan Beulich wrote: On 08.02.17 at 17:32, wrote: >> Is it still appropriate to have the unmodified_drivers subdirectory in >> Xen's git repository? >> >> I think it should be either moved to a separate repository or just >> deleted. > > Having a separate repo for these few

Re: [Xen-devel] [PATCH 0/9] libxl: spolit up libxl.c

2017-02-08 Thread Wei Liu
And CC Zhangchen On Wed, Feb 08, 2017 at 02:35:27PM +, Wei Liu wrote: > Cc Yi Sun as well. > > Haozhong and Yi: This is just a heads-up -- Juergen from SuSE took the > time to split libxl.c so things are better organised. It's likely this > series will go in before yours, so you will then nee

Re: [Xen-devel] [PATCH 2/5] xen: credit2: never consider CPUs outside of our cpupool.

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 17:48, wrote: > On Fri, 2017-02-03 at 08:40 -0700, Jan Beulich wrote: >> > > > > > On 17.01.17 at 18:26, wrote: >> > > While I did manage to backport "xen: credit2: use the correct >> > > scratch >> > > cpumask" and "xen: credit2: fix shutdown/suspend when playing >> > > with >

[Xen-devel] [linux-next test] 105633: regressions - FAIL

2017-02-08 Thread osstest service owner
flight 105633 linux-next real [real] http://logs.test-lab.xenproject.org/osstest/logs/105633/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-xsm 17 guest-localmigrate/x10 fail REGR. vs. 105625 test-amd64-amd64-xl-

Re: [Xen-devel] [libvirt] [PATCH 2/2] libxl: fix dom0 maximum memory setting

2017-02-08 Thread Joao Martins
On 02/08/2017 04:06 PM, Jim Fehlig wrote: > Joao Martins wrote: >> On 02/02/2017 10:31 PM, Jim Fehlig wrote: >>> When the libxl driver is initialized, it creates a virDomainDef >>> object for dom0 and adds it to the list of domains. Total memory >>> for dom0 was being set from the max_memkb field o

Re: [Xen-devel] [PATCH] xen/mm: Alter is_iomem_page() to use mfn_t

2017-02-08 Thread Jan Beulich
>>> On 08.02.17 at 08:31, wrote: >> From: Jan Beulich [mailto:jbeul...@suse.com] >> Sent: Monday, February 06, 2017 11:38 PM >> >> >>> On 06.02.17 at 15:48, wrote: >> > On Mon, 2017-02-06 at 07:26 -0700, Jan Beulich wrote: >> >> > >> >> > > >> >> > > > >> >> > > > On 06.02.17 at 14:55, wrote:

Re: [Xen-devel] [PATCH v6] x86/iommu: add IOMMU entries for p2m_mmio_direct pages

2017-02-08 Thread George Dunlap
On 07/02/17 17:28, Roger Pau Monne wrote: > There's nothing wrong with allowing the domain to perform DMA transfers to > MMIO areas that it already can access from the CPU, and this allows us to > remove the hack in set_identity_p2m_entry for PVH Dom0. > > Signed-off-by: Roger Pau Monné > Reviewe

Re: [Xen-devel] [PATCH] common/vm_event: Prevent guest locking with large max_vcpus

2017-02-08 Thread Razvan Cojocaru
On 02/08/2017 06:25 PM, Tamas K Lengyel wrote: > > > On Wed, Feb 8, 2017 at 2:00 AM, Razvan Cojocaru > mailto:rcojoc...@bitdefender.com>> wrote: > > It is currently possible for the guest to lock when subscribing > to synchronous vm_events if max_vcpus is larger than the > number of

Re: [Xen-devel] [PATCH] xenbus: Neaten xenbus_va_dev_error

2017-02-08 Thread Boris Ostrovsky
On 02/08/2017 11:05 AM, Joe Perches wrote: > On Wed, 2017-02-08 at 10:33 -0500, Boris Ostrovsky wrote: >> On 02/08/2017 06:33 AM, Joe Perches wrote: >>> This function error patch can be simplified, so do so. >>> >>> Remove fail: label and somewhat obfuscating, used once "error_path" >>> function. >

Re: [Xen-devel] [PATCH] x86/mm: Alter is_xen_fixed_mfn() to use mfn_t

2017-02-08 Thread George Dunlap
On 08/02/17 13:07, Jan Beulich wrote: On 07.02.17 at 19:57, wrote: >> --- a/xen/include/xen/mm.h >> +++ b/xen/include/xen/mm.h >> @@ -599,4 +599,10 @@ static inline void filtered_flush_tlb_mask(uint32_t >> tlbflush_timestamp) >> } >> } >> >> +static inline bool is_xen_fixed_mfn(mfn_t

Re: [Xen-devel] [RFC v2 3/6] xen/arm: Allow platform_hvc to handle guest SMC calls

2017-02-08 Thread Tamas K Lengyel
On Wed, Feb 8, 2017 at 9:58 AM, Julien Grall wrote: > Hi Tamas, > > On 08/02/17 16:40, Tamas K Lengyel wrote: > >> On Wed, Feb 8, 2017 at 1:31 AM, Edgar E. Iglesias >> mailto:edgar.igles...@xilinx.com>> wrote: >> On Tue, Feb 07, 2017 at 05:24:03PM -0700, Tamas K Lengyel wrote: >> > On Tue

Re: [Xen-devel] [PATCH] common/vm_event: Prevent guest locking with large max_vcpus

2017-02-08 Thread Andrew Cooper
On 08/02/17 17:08, Razvan Cojocaru wrote: > On 02/08/2017 06:25 PM, Tamas K Lengyel wrote: >> >> On Wed, Feb 8, 2017 at 2:00 AM, Razvan Cojocaru >> mailto:rcojoc...@bitdefender.com>> wrote: >> >> It is currently possible for the guest to lock when subscribing >> to synchronous vm_events if

[Xen-devel] [PATCH v2] xen/p2m: Fix p2m_flush_table for non-nested cases

2017-02-08 Thread George Dunlap
Commit 71bb7304e7a7a35ea6df4b0cedebc35028e4c159 added flushing of nested p2m tables whenever the host p2m table changed. Unfortunately in the process, it added a filter to p2m_flush_table() function so that the p2m would only be flushed if it was being used as a nested p2m. This meant that the p2

[Xen-devel] [xen-unstable-smoke test] 105642: tolerable trouble: broken/fail/pass - PUSHED

2017-02-08 Thread osstest service owner
flight 105642 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/105642/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a build-arm64 5 xen

Re: [Xen-devel] [RFC v2 3/6] xen/arm: Allow platform_hvc to handle guest SMC calls

2017-02-08 Thread Edgar E. Iglesias
On Wed, Feb 08, 2017 at 04:58:44PM +, Julien Grall wrote: > Hi Tamas, > > On 08/02/17 16:40, Tamas K Lengyel wrote: > >On Wed, Feb 8, 2017 at 1:31 AM, Edgar E. Iglesias > >mailto:edgar.igles...@xilinx.com>> wrote: > >On Tue, Feb 07, 2017 at 05:24:03PM -0700, Tamas K Lengyel wrote: > >>

Re: [Xen-devel] [PATCH v2] xen/p2m: Fix p2m_flush_table for non-nested cases

2017-02-08 Thread Tim Deegan
At 17:22 + on 08 Feb (1486574546), George Dunlap wrote: > Commit 71bb7304e7a7a35ea6df4b0cedebc35028e4c159 added flushing of > nested p2m tables whenever the host p2m table changed. Unfortunately > in the process, it added a filter to p2m_flush_table() function so > that the p2m would only be f

[Xen-devel] [qemu-mainline test] 105639: regressions - FAIL

2017-02-08 Thread osstest service owner
flight 105639 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/105639/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm5 xen-buildfail REGR. vs. 105279 build-amd64

  1   2   3   >