[Xen-devel] [qemu-mainline test] 105593: regressions - FAIL

2017-02-07 Thread osstest service owner
flight 105593 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/105593/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm5 xen-buildfail REGR. vs. 105279 build-amd64-xsm

[Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Vijay Kilari
Hi, I am seeing below panic with NUMA during DT mappings in alloc_heap_pages() BUG_ON(pg[i].count_info != PGC_state_free); However, this issue is not there with 4.7 version. The same NUMA board boots fine. With 4.8 or staging I see below panic. I have add print in alloc_heap_pages to print pag

Re: [Xen-devel] [PATCH v3] xenstore: remove XS_RESTRICT support

2017-02-07 Thread David Scott
> On 1 Feb 2017, at 14:49, Juergen Gross wrote: > > On 27/01/17 12:47, Juergen Gross wrote: >> XS_RESTRICT and the xenstore library function xs_restrict() have never >> been usable in all configurations and there are no known users. >> >> This functionality was thought to limit access rights of

[Xen-devel] [PATCH] libxl: correct xenstore entry for empty cdrom

2017-02-07 Thread Juergen Gross
Specifying an empty cdrom device will result in a Xenstore entry params = aio:(null) as the physical device path isn't existing. This lets a domain booted via OVMF hang as OVMF is checking for "aio:" only in order to detect the empty cdrom case. Use an empty string for the physical device path i

[Xen-devel] [xen-unstable test] 105589: regressions - trouble: blocked/broken/fail/pass

2017-02-07 Thread osstest service owner
flight 105589 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/105589/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-raw3 host-install(3)broken REGR. vs. 105576 test-amd64-i386-qe

Re: [Xen-devel] IOMMU fault with IGD passthrough setup on XEN 4.8.0

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 03:12, wrote: > On Mon, Feb 6, 2017 at 7:43 PM, Jan Beulich wrote: > On 05.02.17 at 06:51, wrote: >>> Please find the full log in the attachment. >> >> Sadly that one is only a partial log again. I'd really need to see the >> boot messages too, in particular to (hopefully)

[Xen-devel] [qemu-mainline test] 105597: regressions - FAIL

2017-02-07 Thread osstest service owner
flight 105597 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/105597/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm5 xen-buildfail REGR. vs. 105279 build-amd64-xsm

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 00:32, wrote: > Commit c7bdecae42 ("x86/apicv: fix RTC periodic timer and apicv issue") has > added a assertion that intack.vector is the highest priority vector. But > according to the osstest, the assertion failed sometimes. More discussion can > be found in the thread > (http

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 07:48, wrote: > Some comment from QEMU/KVM code, in /arch/x86/kvm/lapic.c, > > int kvm_lapic_find_highest_irr(struct kvm_vcpu *vcpu) > { > /* This may race with setting of irr in __apic_accept_irq() and >* value returned may be wrong, but kvm_vcpu_kick() in __apic

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

2017-02-07 Thread Wei Liu
On Tue, Feb 07, 2017 at 02:51:54AM -0700, Jan Beulich wrote: > >>> On 07.02.17 at 00:32, wrote: > > Commit c7bdecae42 ("x86/apicv: fix RTC periodic timer and apicv issue") has > > added a assertion that intack.vector is the highest priority vector. But > > according to the osstest, the assertion f

Re: [Xen-devel] [PATCH v3 4/9] xen/pvh: Bootstrap PVH guest

2017-02-07 Thread Juergen Gross
s applied to the wrong git tree, please drop us a note to >> help improve the system] >> >> url: >> https://github.com/0day-ci/linux/commits/Boris-Ostrovsky/x86-boot-32-Convert-the-32-bit-pgtable-setup-code-from-assembly-to-C/20170207-014642 >> base: https://git.ker

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Julien Grall
On 07/02/2017 08:18, Vijay Kilari wrote: Hi, Hello, I am seeing below panic with NUMA during DT mappings in alloc_heap_pages() BUG_ON(pg[i].count_info != PGC_state_free); However, this issue is not there with 4.7 version. The same NUMA board boots fine. I am a bit confused by what you ar

[Xen-devel] [xen-unstable baseline-only test] 68528: tolerable trouble: blocked/broken/fail/pass

2017-02-07 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68528 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68528/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-libvirt 13 saverestore-support-chec

Re: [Xen-devel] [PATCH v3 5/9] xen/pvh: Make sure we don't use ACPI_IRQ_MODEL_PIC for SCI

2017-02-07 Thread Juergen Gross
On 06/02/17 18:00, Boris Ostrovsky wrote: > Since we are not using PIC and (at least currently) don't have IOAPIC > we want to make sure that acpi_irq_model doesn't stay set to > ACPI_IRQ_MODEL_PIC (which is the default value). If we allowed it to > stay then acpi_os_install_interrupt_handler() wou

Re: [Xen-devel] [PATCH] x86/vvmx: Improvements to INVEPT instruction handling

2017-02-07 Thread Jan Beulich
>>> On 06.02.17 at 17:55, wrote: > * Latch current once at the start. > * Avoid the memory operand read for INVEPT_ALL_CONTEXT. Experimentally, this >is how hardware behaves, and avoids an unnecessary pagewalk. Hmm, so you say #GP is being raised for all possible reasons, but #PF can't res

Re: [Xen-devel] [PATCH v3] x86/time: correctly honor late clearing of TSC related feature flags

2017-02-07 Thread Andrew Cooper
On 06/02/17 08:39, Jan Beulich wrote: > As such clearing of flags may have an impact on the selected rendezvous > function, defer the establishing of a rendezvous function other than > the initial default one (std) until after all APs have been brought up. > > But don't allow such feature flags to

Re: [Xen-devel] [PATCH] x86/vvmx: Improvements to INVEPT instruction handling

2017-02-07 Thread Andrew Cooper
On 07/02/17 10:19, Jan Beulich wrote: > >>> On 06.02.17 at 17:55, wrote: >> * Latch current once at the start. >> * Avoid the memory operand read for INVEPT_ALL_CONTEXT. Experimentally, >> this >>is how hardware behaves, and avoids an unnecessary pagewalk. > Hmm, so you say #GP is being ra

Re: [Xen-devel] [PATCH v3] x86/time: correctly honor late clearing of TSC related feature flags

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 11:27, wrote: > On 06/02/17 08:39, Jan Beulich wrote: >> As such clearing of flags may have an impact on the selected rendezvous >> function, defer the establishing of a rendezvous function other than >> the initial default one (std) until after all APs have been brought up. >>

Re: [Xen-devel] [PATCH] x86/vvmx: Improvements to INVEPT instruction handling

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 11:39, wrote: > On 07/02/17 10:19, Jan Beulich wrote: >> >>> On 06.02.17 at 17:55, wrote: >>> * Latch current once at the start. >>> * Avoid the memory operand read for INVEPT_ALL_CONTEXT. Experimentally, >>> this >>>is how hardware behaves, and avoids an unnecessary pa

[Xen-devel] [PATCH] fuzz/x86emul: remove bogus check against fuzzer msr index

2017-02-07 Thread Wei Liu
The "reg" variable in fuzz_read_msr stores the real MSR index, not an index within the fuzzer. The rest of that function already handles things correctly. We just need to remove the bogus check. Signed-off-by: Wei Liu --- tools/fuzz/x86_instruction_emulator/x86-insn-emulator-fuzzer.c | 3 --- 1

Re: [Xen-devel] [PATCH] fuzz/x86emul: remove bogus check against fuzzer msr index

2017-02-07 Thread Andrew Cooper
On 07/02/17 11:02, Wei Liu wrote: > The "reg" variable in fuzz_read_msr stores the real MSR index, not an > index within the fuzzer. > > The rest of that function already handles things correctly. We just need > to remove the bogus check. "Spotted by Coverity." > Signed-off-by: Wei Liu Reviewed

[Xen-devel] [ovmf test] 105599: all pass - PUSHED

2017-02-07 Thread osstest service owner
flight 105599 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/105599/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7c609a144b6636577dd60fbaa5fc64efeecd7baf baseline version: ovmf 8a399fab0af391945f0ea

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Jan Beulich
>>> On 06.02.17 at 15:57, wrote: > Any fail during the original __vmwrite() leads to BUG() which can be > easily exploited from a guest in the nested vmx mode. > > The new function returns error code depending on the outcome: > > VMsucceed: 0 > VMfailValid: VM Instruction Error

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Vijay Kilari
On Tue, Feb 7, 2017 at 3:37 PM, Julien Grall wrote: > On 07/02/2017 08:18, Vijay Kilari wrote: >> >> Hi, > > > Hello, > >>I am seeing below panic with NUMA during DT mappings in >> alloc_heap_pages() >> BUG_ON(pg[i].count_info != PGC_state_free); >> However, this issue is not there with 4.7 ve

Re: [Xen-devel] [PATCH v3] xenstore: remove XS_RESTRICT support

2017-02-07 Thread Wei Liu
On Tue, Feb 07, 2017 at 09:06:55AM +, David Scott wrote: > > > On 1 Feb 2017, at 14:49, Juergen Gross wrote: > > > > On 27/01/17 12:47, Juergen Gross wrote: > >> XS_RESTRICT and the xenstore library function xs_restrict() have never > >> been usable in all configurations and there are no kno

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Julien Grall
On 07/02/2017 11:10, Vijay Kilari wrote: On Tue, Feb 7, 2017 at 3:37 PM, Julien Grall wrote: On 07/02/2017 08:18, Vijay Kilari wrote: I am seeing below panic with NUMA during DT mappings in alloc_heap_pages() BUG_ON(pg[i].count_info != PGC_state_free); However, this issue is not there with

Re: [Xen-devel] [PATCH] page_alloc: clear nr_bootmem_regions in end_boot_allocator()

2017-02-07 Thread Andrew Cooper
On 02/02/17 16:20, Jan Beulich wrote: On 02.02.17 at 16:41, wrote: >> On 02/02/17 15:25, Jan Beulich wrote: >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -329,13 +329,16 @@ unsigned long __init alloc_boot_pages( >>> unsigned long nr_pfns, unsigned long pfn_al

Re: [Xen-devel] [PATCH v3] x86/time: correctly honor late clearing of TSC related feature flags

2017-02-07 Thread Joao Martins
On 02/07/2017 10:47 AM, Jan Beulich wrote: On 07.02.17 at 11:27, wrote: >> On 06/02/17 08:39, Jan Beulich wrote: >>> As such clearing of flags may have an impact on the selected rendezvous >>> function, defer the establishing of a rendezvous function other than >>> the initial default one (st

Re: [Xen-devel] [PATCH 06/28] ARM: GICv3 ITS: introduce ITS command handling

2017-02-07 Thread Julien Grall
Hi Andre, On 06/02/2017 19:16, Julien Grall wrote: On 30/01/17 18:31, Andre Przywara wrote: +/* Wait for an ITS to become quiescient (all ITS operations completed). */ s/quiescient/quiescent/ +static int gicv3_its_wait_quiescient(struct host_its *hw_its) s/quiescient/quiescent/ +{ +

[Xen-devel] [PATCH] libxl: don't segfault when creating domain with invalid pvusb device

2017-02-07 Thread Juergen Gross
Creating a domain with an invalid controller specification for a pvusb device will currently segfault. Avoid this by bailing out early in case of a mandatory xenstore path not existing. Signed-of-by: Juergen Gross --- This patch is a backport candidate for 4.8 --- tools/libxl/libxl_usb.c | 13 +

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Andrew Cooper
On 07/02/17 11:09, Jan Beulich wrote: > >> @@ -423,6 +429,29 @@ static inline bool_t __vmread_safe(unsigned long field, >> unsigned long *value) >> return okay; >> } >> >> +static always_inline unsigned long vmwrite_safe(unsigned long field, >> +

Re: [Xen-devel] [PATCH 06/28] ARM: GICv3 ITS: introduce ITS command handling

2017-02-07 Thread Julien Grall
Hi Andre, Continuing the review where I left it yesterday. On 30/01/2017 18:31, Andre Przywara wrote: [...] +/* Wait for an ITS to become quiescient (all ITS operations completed). */ +static int gicv3_its_wait_quiescient(struct host_its *hw_its) +{ +uint32_t reg; +s_time_t deadline =

Re: [Xen-devel] [DRAFT C] PVH CPU hotplug design document

2017-02-07 Thread Roger Pau Monné
Hello Al, Thanks for your comments, please see below. On Mon, Feb 06, 2017 at 04:06:45PM -0700, Al Stone wrote: > On 01/24/2017 07:20 AM, Boris Ostrovsky wrote: > > > >> Yes, the only remaining risk is some vendor using _SB.XEN0, and AFAICT > >> there's > >> no way to reserve anything in there

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Vijay Kilari
On Tue, Feb 7, 2017 at 4:58 PM, Julien Grall wrote: > On 07/02/2017 11:10, Vijay Kilari wrote: >> >> On Tue, Feb 7, 2017 at 3:37 PM, Julien Grall wrote: >>> >>> On 07/02/2017 08:18, Vijay Kilari wrote: I am seeing below panic with NUMA during DT mappings in alloc_heap_pages() >>

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Julien Grall
On 07/02/2017 12:41, Vijay Kilari wrote: On Tue, Feb 7, 2017 at 4:58 PM, Julien Grall wrote: On 07/02/2017 11:10, Vijay Kilari wrote: On Tue, Feb 7, 2017 at 3:37 PM, Julien Grall wrote: On 07/02/2017 08:18, Vijay Kilari wrote: I am seeing below panic with NUMA during DT mappings in

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Julien Grall
On 07/02/2017 12:47, Julien Grall wrote: On 07/02/2017 12:41, Vijay Kilari wrote: On Tue, Feb 7, 2017 at 4:58 PM, Julien Grall wrote: On 07/02/2017 11:10, Vijay Kilari wrote: On Tue, Feb 7, 2017 at 3:37 PM, Julien Grall wrote: On 07/02/2017 08:18, Vijay Kilari wrote: I am seeing

Re: [Xen-devel] dom0pvh issue with XEN 4.8.0

2017-02-07 Thread Roger Pau Monné
On Mon, Feb 06, 2017 at 06:25:57PM +0800, G.R. wrote: > On Mon, Feb 6, 2017 at 5:33 PM, Pasi Kärkkäinen wrote: > > Hi, > > > > On Sun, Feb 05, 2017 at 04:05:32PM +0800, G.R. wrote: > >> Hi all, > >> dom0pvh=1 is not working well for me with XEN 4.8.0 + linux kernel 4.9.2. > >> > >> The system boot

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 12:59, wrote: > On 07/02/17 11:09, Jan Beulich wrote: >> >>> @@ -423,6 +429,29 @@ static inline bool_t __vmread_safe(unsigned long >>> field, > unsigned long *value) >>> return okay; >>> } >>> >>> +static always_inline unsigned long vmwrite_safe(unsigned long field, >>

[Xen-devel] [ovmf test] 105604: all pass - PUSHED

2017-02-07 Thread osstest service owner
flight 105604 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/105604/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a316d7ac91d302085b5c35d76db703f2208ec026 baseline version: ovmf 7c609a144b6636577dd60

Re: [Xen-devel] [PATCH] page_alloc: clear nr_bootmem_regions in end_boot_allocator()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 12:38, wrote: > On 02/02/17 16:20, Jan Beulich wrote: > On 02.02.17 at 16:41, wrote: >>> On 02/02/17 15:25, Jan Beulich wrote: --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -329,13 +329,16 @@ unsigned long __init alloc_boot_pages( u

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Vijay Kilari
On Tue, Feb 7, 2017 at 6:30 PM, Julien Grall wrote: > > > On 07/02/2017 12:47, Julien Grall wrote: >> >> >> >> On 07/02/2017 12:41, Vijay Kilari wrote: >>> >>> On Tue, Feb 7, 2017 at 4:58 PM, Julien Grall >>> wrote: On 07/02/2017 11:10, Vijay Kilari wrote: > > > On Tue, Feb

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Julien Grall
On 07/02/2017 13:25, Vijay Kilari wrote: On Tue, Feb 7, 2017 at 6:30 PM, Julien Grall wrote: One more thing, if Xen 4.7 was able to go up to booting Dom0 without any patches on a NUMA board. I would recommend to try to bisect and see if you can find an offending commit. Yes, with plain 4

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

2017-02-07 Thread Chao Gao
On Tue, Feb 07, 2017 at 03:04:32AM -0700, Jan Beulich wrote: On 07.02.17 at 07:48, wrote: >> Some comment from QEMU/KVM code, in /arch/x86/kvm/lapic.c, >> >> int kvm_lapic_find_highest_irr(struct kvm_vcpu *vcpu) >> { >> /* This may race with setting of irr in __apic_accept_irq() and >>

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 07:32, wrote: > On Tue, Feb 07, 2017 at 03:04:32AM -0700, Jan Beulich wrote: > On 07.02.17 at 07:48, wrote: >>> Some comment from QEMU/KVM code, in /arch/x86/kvm/lapic.c, >>> >>> int kvm_lapic_find_highest_irr(struct kvm_vcpu *vcpu) >>> { >>> /* This may race with sett

Re: [Xen-devel] [PATCH RESEND v5 07/24] x86: refactor psr: implement get value flow.

2017-02-07 Thread Konrad Rzeszutek Wilk
On Tue, Feb 07, 2017 at 10:47:01AM +0800, Yi Sun wrote: > Hi, > > Thanks for reviewing! I agree with your comments except below one. Could you > please check my response? > > On 17-01-31 15:29:34, Konrad Rzeszutek Wilk wrote: > > On Thu, Jan 19, 2017 at 02:01:09PM +0800, Yi Sun wrote: > > > +int

Re: [Xen-devel] [PATCH RESEND v5 09/24] x86: refactor psr: set value: assemble features value array.

2017-02-07 Thread Konrad Rzeszutek Wilk
On Tue, Feb 07, 2017 at 10:51:27AM +0800, Yi Sun wrote: > On 17-01-31 15:57:26, Konrad Rzeszutek Wilk wrote: > > > static int assemble_val_array(uint64_t *val, > > > @@ -550,7 +641,25 @@ static int assemble_val_array(uint64_t *val, > > >const struct psr_socket_info

Re: [Xen-devel] blkfront resource use

2017-02-07 Thread Roger Pau Monne
On Mon, Feb 06, 2017 at 03:53:58AM -0700, Jan Beulich wrote: > Konrad, Roger, > > we've recently had a report of stuck I/O (with slightly over a hundred > frontend instances in a single guest), which turned out to be a simple > lack of configured grants on the system. This raises two questions: >

Re: [Xen-devel] [PATCH 07/28] ARM: GICv3 ITS: introduce device mapping

2017-02-07 Thread Julien Grall
Hi Andre, On 30/01/2017 18:31, Andre Przywara wrote: The ITS uses device IDs to map LPIs to a device. Dom0 will later use those IDs, which we directly pass on to the host. For this we have to map each device that Dom0 may request to a host ITS device with the same identifier. Allocate the respec

Re: [Xen-devel] blkfront resource use

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 14:59, wrote: > On Mon, Feb 06, 2017 at 03:53:58AM -0700, Jan Beulich wrote: >> Interestingly I've found >> https://groups.google.com/forum/#!topic/linux.kernel/N6Q171xkIkM >> when looking around - is there a reason this or something similar >> never made it into the driver? W

[Xen-devel] [linux-linus test] 105594: regressions - FAIL

2017-02-07 Thread osstest service owner
flight 105594 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/105594/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit2 14 guest-saverestore fail REGR. vs. 59254 test-amd64-amd64-xl

[Xen-devel] [xen-unstable-smoke test] 105605: tolerable trouble: broken/fail/pass - PUSHED

2017-02-07 Thread osstest service owner
flight 105605 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/105605/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12 mig

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

2017-02-07 Thread Chao Gao
On Tue, Feb 07, 2017 at 06:46:16AM -0700, Jan Beulich wrote: On 07.02.17 at 07:32, wrote: >> On Tue, Feb 07, 2017 at 03:04:32AM -0700, Jan Beulich wrote: >> On 07.02.17 at 07:48, wrote: Some comment from QEMU/KVM code, in /arch/x86/kvm/lapic.c, int kvm_lapic_find_highest_

[Xen-devel] [qemu-mainline test] 105602: regressions - FAIL

2017-02-07 Thread osstest service owner
flight 105602 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/105602/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm5 xen-buildfail REGR. vs. 105279 build-amd64-xsm

[Xen-devel] [PATCH v2] xen-netfront: Improve error handling during initialization

2017-02-07 Thread Ross Lagerwall
This fixes a crash when running out of grant refs when creating many queues across many netdevs. * If creating queues fails (i.e. there are no grant refs available), call xenbus_dev_fatal() to ensure that the xenbus device is set to the closed state. * If no queues are created, don't call xennet_d

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Sergey Dyasli
On Tue, 2017-02-07 at 04:09 -0700, Jan Beulich wrote: > > > > On 06.02.17 at 15:57, wrote: > > > > Any fail during the original __vmwrite() leads to BUG() which can be > > easily exploited from a guest in the nested vmx mode. > > > > The new function returns error code depending on the outcome:

[Xen-devel] [ovmf baseline-only test] 68531: all pass

2017-02-07 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68531 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68531/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7c609a144b6636577dd60fbaa5fc64efeecd7baf baseline v

[Xen-devel] [PATCH v2] MAINTAINERS: Add myself as the public API "Czar"

2017-02-07 Thread Konrad Rzeszutek Wilk
That way we have one person who can: a) poke other maintainers or pull them in with new drivers are introduced, b) we have one maintainer who can shepherd the patches along instead of depending on the REST maintainers which may be busy with other responsibilities. Acked-by: Stefano Stabellini Ack

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Andrew Cooper
On 07/02/17 15:06, Sergey Dyasli wrote: > On Tue, 2017-02-07 at 04:09 -0700, Jan Beulich wrote: > On 06.02.17 at 15:57, wrote: >>> Any fail during the original __vmwrite() leads to BUG() which can be >>> easily exploited from a guest in the nested vmx mode. >>> >>> The new function returns err

Re: [Xen-devel] blkfront resource use

2017-02-07 Thread Roger Pau Monne
On Tue, Feb 07, 2017 at 07:13:57AM -0700, Jan Beulich wrote: > >>> On 07.02.17 at 14:59, wrote: > > On Mon, Feb 06, 2017 at 03:53:58AM -0700, Jan Beulich wrote: > >> Interestingly I've found > >> https://groups.google.com/forum/#!topic/linux.kernel/N6Q171xkIkM > >> when looking around - is there

Re: [Xen-devel] IOMMU fault with IGD passthrough setup on XEN 4.8.0

2017-02-07 Thread G.R.
On Mon, Feb 6, 2017 at 8:40 PM, Jan Beulich wrote: On 05.02.17 at 06:51, wrote: >> I finally get some spare time to collect the debug info. > > As I continue to be puzzled, best I could come up with is an > extension to the debug patch. Please use the attached one > in place of the earlier o

Re: [Xen-devel] [PATCH v2 4/4] x86/vvmx: correctly emulate VMREAD

2017-02-07 Thread Sergey Dyasli
On Tue, 2017-02-07 at 06:52 +, Tian, Kevin wrote: > > From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > > Sent: Monday, February 06, 2017 10:58 PM > > > > There is an issue with the original __vmread() in nested vmx mode: > > emulation of a guest's VMREAD with invalid arguments leads to

Re: [Xen-devel] arm: alloc_heap_pages allocates already allocated page

2017-02-07 Thread Vijay Kilari
On Tue, Feb 7, 2017 at 6:57 PM, Julien Grall wrote: > > > On 07/02/2017 13:25, Vijay Kilari wrote: >> >> On Tue, Feb 7, 2017 at 6:30 PM, Julien Grall wrote: >>> >>> >>> One more thing, if Xen 4.7 was able to go up to booting Dom0 without any >>> patches on a NUMA board. I would recommend to try t

Re: [Xen-devel] [PATCH] X86/vmx: Dump PIR and vIRR before ASSERT()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 08:28, wrote: > On Tue, Feb 07, 2017 at 06:46:16AM -0700, Jan Beulich wrote: > On 07.02.17 at 07:32, wrote: >>> On Tue, Feb 07, 2017 at 03:04:32AM -0700, Jan Beulich wrote: >>> On 07.02.17 at 07:48, wrote: > Some comment from QEMU/KVM code, in /arch/x86/kvm/lapic.c

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 16:06, wrote: > If I understood correctly, you are suggesting the following change: Mostly. > --- a/xen/include/asm-x86/hvm/vmx/vmx.h > +++ b/xen/include/asm-x86/hvm/vmx/vmx.h > @@ -424,8 +424,8 @@ static inline unsigned long vmread_safe(unsigned long > field, > return r

[Xen-devel] [xen-unstable test] 105600: tolerable FAIL - PUSHED

2017-02-07 Thread osstest service owner
flight 105600 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/105600/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-raw 3 host-install(3) broken in 105589 pass in 105600 test-amd64-i386-qemut-rhel6hvm-a

Re: [Xen-devel] blkfront resource use

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 16:24, wrote: > Or maybe we should just disable persistent grants by default, by setting > xen_blkif_max_pgrants = 0. This feature doesn't scale well, and interacts > badly > with other things (like indirect descriptors). The amount of code required to > maintain this feature i

Re: [Xen-devel] [PATCH v2] MAINTAINERS: Add myself as the public API "Czar"

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 16:28, wrote: > v2: - Added Acks > - changed description in MAINTAINERS > - changed file directory in MAINTAINERS Are you sure? I can't see a difference to v1, so my earlier comment still holds. Jan ___ Xen-devel mailing li

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Andrew Cooper
On 07/02/17 16:22, Jan Beulich wrote: On 07.02.17 at 16:06, wrote: >> If I understood correctly, you are suggesting the following change: > Mostly. > >> --- a/xen/include/asm-x86/hvm/vmx/vmx.h >> +++ b/xen/include/asm-x86/hvm/vmx/vmx.h >> @@ -424,8 +424,8 @@ static inline unsigned long vmread

Re: [Xen-devel] [PATCH v2] MAINTAINERS: Add myself as the public API "Czar"

2017-02-07 Thread Konrad Rzeszutek Wilk
On Tue, Feb 07, 2017 at 09:31:29AM -0700, Jan Beulich wrote: > >>> On 07.02.17 at 16:28, wrote: > > v2: - Added Acks > > - changed description in MAINTAINERS > > - changed file directory in MAINTAINERS > > Are you sure? I can't see a difference to v1, so my earlier comment > still holds.

Re: [Xen-devel] IOMMU fault with IGD passthrough setup on XEN 4.8.0

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 16:44, wrote: > On Mon, Feb 6, 2017 at 8:40 PM, Jan Beulich wrote: > On 05.02.17 at 06:51, wrote: >>> I finally get some spare time to collect the debug info. >> >> As I continue to be puzzled, best I could come up with is an >> extension to the debug patch. Please use the

Re: [Xen-devel] [PATCH v2] MAINTAINERS: Add myself as the public API "Czar"

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 17:38, wrote: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -304,6 +304,11 @@ X: xen/arch/x86/acpi/lib.c > F: xen/drivers/cpufreq/ > F: xen/include/acpi/cpufreq/ > > +PUBLIC INTERFACES AND PV DRIVERS DESIGNS > +M: Konrad Rzeszutek Wilk > +S: Supported > +F: xen/

Re: [Xen-devel] [PATCH v2 1/4] x86/vmx: introduce vmwrite_safe()

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 17:34, wrote: > On 07/02/17 16:22, Jan Beulich wrote: > On 07.02.17 at 16:06, wrote: >>> If I understood correctly, you are suggesting the following change: >> Mostly. >> >>> --- a/xen/include/asm-x86/hvm/vmx/vmx.h >>> +++ b/xen/include/asm-x86/hvm/vmx/vmx.h >>> @@ -424,8 +

[Xen-devel] Enabling vm_event for a guest with more VCPUs than available ring buffer slots freezes the virtual machine

2017-02-07 Thread Razvan Cojocaru
Hello, Setting, e.g. 16 VCPUs for a HVM guest, ends up blocking the guest completely when subscribing to vm_events, apparently because of this code in xen/common/vm_event.c: 315 /* Give this vCPU a black eye if necessary, on the way out. 316 * See the comments above wake_blocked() for mo

Re: [Xen-devel] IOMMU fault with IGD passthrough setup on XEN 4.8.0

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 16:44, wrote: > On Mon, Feb 6, 2017 at 8:40 PM, Jan Beulich wrote: > On 05.02.17 at 06:51, wrote: >>> I finally get some spare time to collect the debug info. >> >> As I continue to be puzzled, best I could come up with is an >> extension to the debug patch. Please use the

[Xen-devel] [xen-unstable-smoke test] 105609: tolerable trouble: broken/fail/pass - PUSHED

2017-02-07 Thread osstest service owner
flight 105609 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/105609/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 12 mig

Re: [Xen-devel] [PATCH v2] MAINTAINERS: Add myself as the public API "Czar"

2017-02-07 Thread Konrad Rzeszutek Wilk
On Tue, Feb 07, 2017 at 09:47:09AM -0700, Jan Beulich wrote: > >>> On 07.02.17 at 17:38, wrote: > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -304,6 +304,11 @@ X: xen/arch/x86/acpi/lib.c > > F: xen/drivers/cpufreq/ > > F: xen/include/acpi/cpufreq/ > > > > +PUBLIC INTERFACES AND PV DRI

Re: [Xen-devel] [PATCH v2] MAINTAINERS: Add myself as the public API "Czar"

2017-02-07 Thread Jan Beulich
>>> On 07.02.17 at 18:02, wrote: > On Tue, Feb 07, 2017 at 09:47:09AM -0700, Jan Beulich wrote: >> >>> On 07.02.17 at 17:38, wrote: >> > --- a/MAINTAINERS >> > +++ b/MAINTAINERS >> > @@ -304,6 +304,11 @@ X:xen/arch/x86/acpi/lib.c >> > F:xen/drivers/cpufreq/ >> > F:xen/includ

[Xen-devel] [qemu-mainline test] 105610: regressions - FAIL

2017-02-07 Thread osstest service owner
flight 105610 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/105610/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-xsm5 xen-buildfail REGR. vs. 105279 build-amd64-xsm

[Xen-devel] PML causing race condition during guest bootstorm and host crash on Broadwell cpu.

2017-02-07 Thread anshul makkar
Hi, Facing a issue where bootstorm of guests leads to host crash. I debugged and found that that enabling PML introduces a race condition during guest teardown stage while disabling PML on a vcpu and context switch happening for another vcpu. Crash happens only on Broadwell processors as

[Xen-devel] [PATCH v6] x86/iommu: add IOMMU entries for p2m_mmio_direct pages

2017-02-07 Thread Roger Pau Monne
There's nothing wrong with allowing the domain to perform DMA transfers to MMIO areas that it already can access from the CPU, and this allows us to remove the hack in set_identity_p2m_entry for PVH Dom0. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper Reviewed-by: Kevin Tian --- Cc:

[Xen-devel] [PATCH v6] x86/hvm: add vcpu parameter to guest memory copy function

2017-02-07 Thread Roger Pau Monne
Current __hvm_copy assumes that the destination memory belongs to the current vcpu, but this is not always the case since for PVHv2 Dom0 build hvm copy functions are used with current being the idle vcpu. Add a new vcpu parameter to hvm copy in order to solve that. Note that only hvm_copy_to_guest_

Re: [Xen-devel] [PATCH v2 1/2] xen/kbdif: update protocol documentation

2017-02-07 Thread Konrad Rzeszutek Wilk
On Thu, Jan 26, 2017 at 09:46:46AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > > Reviewed-by: Stefano Stabellini Reviewed-by: Konrad Rzeszutek Wilk Thank you for documenting this! ___ Xen-devel mailing list Xen-devel@lis

[Xen-devel] [ovmf baseline-only test] 68532: all pass

2017-02-07 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 68532 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68532/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a316d7ac91d302085b5c35d76db703f2208ec026 baseline v

Re: [Xen-devel] [PATCH v3 0/9] PVH v2 support (domU)

2017-02-07 Thread Boris Ostrovsky
On 02/06/2017 12:00 PM, Boris Ostrovsky wrote: > PVHv2 support for unprivileged guests. > > Changes in v3: > * See patches 4 and 5 > Applied to for-linus-4.11 -boris ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

[Xen-devel] [PATCH v4 0/2] XEN SWIOTLB dma operations extension

2017-02-07 Thread Andrii Anisov
From: Andrii Anisov Some drivers need additional dma ops to be provided by xen swiotlb. Because common operations implementation came from x86 world and does not suite ARM needs we have to provide needed XEN SWIOTLB for ARM callbacks. dma_mmap patch is a port of an antique and lost patch discuss

[Xen-devel] [PATCH v4 1/2] swiotlb-xen: implement xen_swiotlb_dma_mmap callback

2017-02-07 Thread Andrii Anisov
From: Stefano Stabellini This function creates userspace mapping for the DMA-coherent memory. Signed-off-by: Stefano Stabellini Signed-off-by: Oleksandr Dmytryshyn Signed-off-by: Andrii Anisov --- arch/arm/xen/mm.c | 1 + drivers/xen/swiotlb-xen.c | 19 +++ include/x

[Xen-devel] [PATCH v4 2/2] swiotlb-xen: implement xen_swiotlb_get_sgtable callback

2017-02-07 Thread Andrii Anisov
From: Andrii Anisov Signed-off-by: Andrii Anisov Signed-off-by: Stefano Stabellini --- arch/arm/xen/mm.c | 1 + drivers/xen/swiotlb-xen.c | 28 include/xen/swiotlb-xen.h | 6 ++ 3 files changed, 35 insertions(+) diff --git a/arch/arm/xen/mm.c b/arch/

Re: [Xen-devel] [PATCH 08/28] ARM: GICv3 ITS: introduce host LPI array

2017-02-07 Thread Julien Grall
Hi Andre, On 30/01/2017 18:31, Andre Przywara wrote: The number of LPIs on a host can be potentially huge (millions), although in practise will be mostly reasonable. So prematurely allocating an array of struct irq_desc's for each LPI is not an option. However Xen itself does not care about LPIs

[Xen-devel] [distros-debian-snapshot test] 68530: tolerable trouble: blocked/broken/fail/pass

2017-02-07 Thread Platform Team regression test user
flight 68530 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/68530/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-i386-i386-daily-netboot-pvgrub 10 guest-start fail blocked in 68502 test-amd64-i38

Re: [Xen-devel] [PATCH v3 3/3] xen: optimize xenbus driver for multiple concurrent xenstore accesses

2017-02-07 Thread Boris Ostrovsky
On 01/24/2017 11:23 AM, Juergen Gross wrote: > On 24/01/17 14:47, Boris Ostrovsky wrote: >> On 01/23/2017 01:59 PM, Boris Ostrovsky wrote: >>> On 01/23/2017 05:09 AM, Juergen Gross wrote: Handling of multiple concurrent Xenstore accesses through xenbus driver either from the kernel or use

Re: [Xen-devel] Enabling vm_event for a guest with more VCPUs than available ring buffer slots freezes the virtual machine

2017-02-07 Thread Tamas K Lengyel
On Tue, Feb 7, 2017 at 9:53 AM, Razvan Cojocaru wrote: > Hello, > > Setting, e.g. 16 VCPUs for a HVM guest, ends up blocking the guest > completely when subscribing to vm_events, apparently because of this > code in xen/common/vm_event.c: > > 315 /* Give this vCPU a black eye if necessary, on

Re: [Xen-devel] [PATCH v4 0/2] XEN SWIOTLB dma operations extension

2017-02-07 Thread Stefano Stabellini
Both patches are fine by me. On Tue, 7 Feb 2017, Andrii Anisov wrote: > From: Andrii Anisov > > Some drivers need additional dma ops to be provided by xen swiotlb. Because > common operations implementation came from x86 world and does not suite ARM > needs we have to provide needed XEN SWIOTLB

Re: [Xen-devel] [PATCH v2] MAINTAINERS: Add myself as the public API "Czar"

2017-02-07 Thread Ian Jackson
Jan Beulich writes ("Re: [PATCH v2] MAINTAINERS: Add myself as the public API "Czar""): > On 07.02.17 at 18:02, wrote: > > Changed it locally to be that. > > With that > Acked-by: Jan Beulich Likewise. Ian. ___ Xen-devel mailing list Xen-devel@lis

Re: [Xen-devel] Enabling vm_event for a guest with more VCPUs than available ring buffer slots freezes the virtual machine

2017-02-07 Thread Razvan Cojocaru
On 02/07/2017 08:15 PM, Tamas K Lengyel wrote: > > > On Tue, Feb 7, 2017 at 9:53 AM, Razvan Cojocaru > mailto:rcojoc...@bitdefender.com>> wrote: > > Hello, > > Setting, e.g. 16 VCPUs for a HVM guest, ends up blocking the guest > completely when subscribing to vm_events, apparently b

Re: [Xen-devel] [PATCH] libxl: don't segfault when creating domain with invalid pvusb device

2017-02-07 Thread Ian Jackson
Juergen Gross writes ("[PATCH] libxl: don't segfault when creating domain with invalid pvusb device"): > Creating a domain with an invalid controller specification for a pvusb > device will currently segfault. > > Avoid this by bailing out early in case of a mandatory xenstore path > not existing

Re: [Xen-devel] Enabling vm_event for a guest with more VCPUs than available ring buffer slots freezes the virtual machine

2017-02-07 Thread Andrew Cooper
On 07/02/17 18:31, Razvan Cojocaru wrote: > On 02/07/2017 08:15 PM, Tamas K Lengyel wrote: >> >> On Tue, Feb 7, 2017 at 9:53 AM, Razvan Cojocaru >> mailto:rcojoc...@bitdefender.com>> wrote: >> >> Hello, >> >> Setting, e.g. 16 VCPUs for a HVM guest, ends up blocking the guest >> complete

[Xen-devel] [PATCH] x86/p2m: Reposition p2m_teardown_nestedp2m() to avoid its forward declaration

2017-02-07 Thread Andrew Cooper
While adjusting these functions, use unsigned int rather than uint8_t for the loop variable, and fix the whitespace style. No functional change. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Tim Deegan CC: George Dunlap --- xen/arch/x86/mm/p2m.c | 36 +-

[Xen-devel] [PATCH] x86/p2m: Stop other vcpus using a nested p2m before clearing it

2017-02-07 Thread Andrew Cooper
Until the IPI has completed, other processors might be running on this nested p2m object. clear_domain_page() does not guarantee to make 8-byte atomic updates, which means that a pagewalk on a remote processor might encounter a partial update. This is currently safe as other issues prevents a nes

Re: [Xen-devel] [PATCH v2 2/2] xen/kbdif: add multi-touch support

2017-02-07 Thread Konrad Rzeszutek Wilk
On Thu, Jan 26, 2017 at 09:46:47AM +0200, Oleksandr Andrushchenko wrote: > From: Oleksandr Andrushchenko > Usually you say a bit in the description of what it does and what's its usage is. Like: "Multi-touch fields re-use the page that is used by the other features which means that you can int

[Xen-devel] [PATCH v2] x86/time: Adjust init-time handling of pit0_ticks

2017-02-07 Thread Andrew Cooper
There is no need for the volatile cast in the timer interrupt; the compiler may not elide the update. This reduces the generated assembly from a read, local modify, write to a single add instruction. Drop the memory barriers from timer_irq_works(), as they are not needed. pit0_ticks is only modif

  1   2   >