Re: [Xen-devel] [PATCH v2 14/23] acpi: Move ACPI code to tools/libacpi

2016-08-16 Thread Shannon Zhao
Hi, On 2016/8/5 5:06, Boris Ostrovsky wrote: > Signed-off-by: Boris Ostrovsky > Acked-by: Jan Beulich > --- > v2: > * Minor cleanup of hvmloader's Makefile > > tools/firmware/hvmloader/Makefile | 14 > -- > tools/firmware/hvmloader/ovmf.c

Re: [Xen-devel] [PATCH v2] Remove ambiguities in the COPYING file; add CONTRIBUTING file

2016-08-16 Thread George Dunlap
On Mon, Aug 15, 2016 at 11:24 AM, Andrew Cooper wrote: > On 12/08/16 10:37, Lars Kurth wrote: >> COPYING file: >> The motivation of this change is to make it easier for new >> contributors to conduct a license and patent review, WITHOUT >> changing any licenses. >> - Remove references to BSD-style

Re: [Xen-devel] [PATCH v2 14/23] acpi: Move ACPI code to tools/libacpi

2016-08-16 Thread Wei Liu
On Tue, Aug 16, 2016 at 04:13:06PM +0800, Shannon Zhao wrote: [...] > Not sure if I do something wrong, but I got bellow errors when compiling > this series on x86 just using "./autogen.sh;./configure;make tools". > > In file included from tcgbios.c:26:0: > ../util.h:4:39: fatal error: ../hvmloade

[Xen-devel] [qemu-mainline test] 100497: regressions - FAIL

2016-08-16 Thread osstest service owner
flight 100497 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/100497/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-arndale 15 guest-start/debian.repeat fail REGR. vs. 100454 Regressions which

[Xen-devel] [xen-unstable baseline-only test] 67536: tolerable FAIL

2016-08-16 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 67536 xen-unstable real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67536/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-i386-rumpuserxen6 xen-build

[Xen-devel] [PATCH 0/3] x86emul: further misc small adjustments

2016-08-16 Thread Jan Beulich
Along the lines of and on top of https://lists.xenproject.org/archives/html/xen-devel/2016-08/msg01852.html here are three more. 1: use DstEax also for {,I}{MUL,DIV} 2: don't open code EFLAGS handling for 2-operand IMUL 3: re-order main 2-byte opcode switch() statement Signed-off-by: Jan Beulich

[Xen-devel] [PATCH 2/3] x86emul: don't open code EFLAGS handling for 2-operand IMUL

2016-08-16 Thread Jan Beulich
Slightly extending the emulate_2op*() macro machinery makes it usable for IMUL r,r/m too, which has the benefit of smaller source code and the EFLAGS output being guaranteed to match actual hardware behavior. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/

[Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

2016-08-16 Thread Jan Beulich
Just like said in commit c0bc0adf24 ("x86emul: use DstEax where possible"): While it avoids just a few instructions, we should nevertheless make use of generic code as much as possible. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emu

[Xen-devel] [PATCH 3/3] x86emul: re-order main 2-byte opcode switch() statement

2016-08-16 Thread Jan Beulich
This was meant to be numerically sorted (with reasonable exceptions), but we've manage to diverge from that. No functional change, only code movement. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -4488,33 +4488,6 @@ x86_

Re: [Xen-devel] [PATCH v2 14/23] acpi: Move ACPI code to tools/libacpi

2016-08-16 Thread Shannon Zhao
On 2016/8/16 16:29, Wei Liu wrote: > On Tue, Aug 16, 2016 at 04:13:06PM +0800, Shannon Zhao wrote: > [...] >> > Not sure if I do something wrong, but I got bellow errors when compiling >> > this series on x86 just using "./autogen.sh;./configure;make tools". >> > >> > In file included from tcgbi

Re: [Xen-devel] [PATCH 2/4] x86emul: drop RIP-relative special case for TEST

2016-08-16 Thread Jan Beulich
>>> On 15.08.16 at 16:25, wrote: > On 15/08/16 09:34, Jan Beulich wrote: >> @@ -1851,11 +1911,6 @@ x86_emulate( >> ((op_bytes == 8) ? 4 : op_bytes); >> else if ( (d & SrcMask) == SrcImmByte ) >> ea.mem.off += 1; >> -els

Re: [Xen-devel] [PATCH 2/4] x86emul: drop RIP-relative special case for TEST

2016-08-16 Thread Andrew Cooper
On 15/08/16 16:08, Jan Beulich wrote: On 15.08.16 at 16:25, wrote: >> On 15/08/16 09:34, Jan Beulich wrote: >>> @@ -1851,11 +1911,6 @@ x86_emulate( >>> ((op_bytes == 8) ? 4 : op_bytes); >>> else if ( (d & SrcMask) == SrcImmByte ) >>>

Re: [Xen-devel] [PATCH v2 14/23] acpi: Move ACPI code to tools/libacpi

2016-08-16 Thread Wei Liu
On Tue, Aug 16, 2016 at 05:36:03PM +0800, Shannon Zhao wrote: > > > On 2016/8/16 16:29, Wei Liu wrote: > > On Tue, Aug 16, 2016 at 04:13:06PM +0800, Shannon Zhao wrote: > > [...] > >> > Not sure if I do something wrong, but I got bellow errors when compiling > >> > this series on x86 just using "

[Xen-devel] [ovmf baseline-only test] 67538: all pass

2016-08-16 Thread Platform Team regression test user
This run is configured for baseline tests only. flight 67538 ovmf real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67538/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf de74668f5ea713b7e91e01318f0d15d2bf0effce baseline v

Re: [Xen-devel] [PATCH 2/2] x86/NUMA: cleanup

2016-08-16 Thread Dario Faggioli
On Wed, 2016-08-10 at 05:47 -0600, Jan Beulich wrote: > > On 10.08.16 at 12:35, wrote: > > I observe that CONFIG_NUMA_EMU is also unconditionally true, which > > offers further cleanup opportunities (albeit it probably a separate > > patch). > So I thought, but then wasn't sure eliminating just th

Re: [Xen-devel] [PATCH] xenbus: don't look up transaction IDs for ordinary writes

2016-08-16 Thread Juergen Gross
On 15/08/16 17:02, Jan Beulich wrote: > This should really only be done for XS_TRANSACTION_END messages, or > else at least some of the xenstore-* tools don't work anymore. > > Fixes: 0beef634b8 ("xenbus: don't BUG() on user mode induced condition") > Reported-by: Richard Schütz > Cc: > Signed-o

[Xen-devel] [PATCH v5 0/2] qemu-qdisk: Implementation of grant copy operation.

2016-08-16 Thread Paulina Szubarczyk
Hi, It is a proposition for implementation of grant copy operation in qemu-qdisk and interface in libxc/libs. I am sorry for the previous cover letter send today belonging to the previous version. Changes since v4: Interface: - changed the subject line - changed the comment in libs/gnttab/inc

Re: [Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

2016-08-16 Thread Andrew Cooper
On 15/08/16 09:35, Jan Beulich wrote: > As of commit a800e4f611 ("x86emul: drop pointless and add useful > default cases") we no longer need the early bailing when "d == 0" (the > default cases in the main switch() statements take care of that), > removal of which renders internal_error() wrong and

Re: [Xen-devel] dependences for backporting to 4.6 [was: Re: [PATCH 2/3] xen: Have schedulers revise initial placement]

2016-08-16 Thread Dario Faggioli
On Fri, 2016-08-12 at 07:53 -0600, Jan Beulich wrote: > > > > On 12.08.16 at 03:59, wrote: > > So, I'm not sure whether the best route here is: > >  - fully backport 6b53bb4ab3c9b; > >  - backport only the last hunk of 6b53bb4ab3c9b as its own patch; > >  - fold the last hunk of 6b53bb4ab3c9b in t

[Xen-devel] [PATCH v4 08/16] libxl/arm: Factor MPIDR computing codes out as a helper

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Factor MPIDR computing codes out as a helper, so it could be shared between DT and ACPI. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 8 +--- tools/libxl/libxl_arm.h | 11 +++ 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/tools/lib

[Xen-devel] [PATCH v4 02/16] libxl/arm: prepare for constructing ACPI tables

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao It only constructs the ACPI tables for 64-bit ARM DomU when user enables acpi because 32-bit DomU doesn't support ACPI. Signed-off-by: Shannon Zhao --- tools/libxl/Makefile | 4 +++ tools/libxl/libxl_arm.c | 23 +++- tools/libxl/libxl_arm.h

[Xen-devel] [PATCH v4 11/16] libxl/arm: Construct ACPI DSDT table

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Copy the static DSDT table into ACPI blob. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index cb1c9df..3154e0c 100644 --- a/tools/libxl

[Xen-devel] [PATCH v4 12/16] libxl/arm: Factor finalise_one_memory_node as a gerneric function

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Rename finalise_one_memory_node to finalise_one_node and pass the node name via function parameter. This is useful for adding ACPI module which will be added by a later patch. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 8 1 file changed, 4 insertions

[Xen-devel] [PATCH v4 04/16] libxl/arm: Estimate the size of ACPI tables

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Estimate the size of ACPI tables and reserve a memory map space for ACPI tables. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 85 1 file changed, 85 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tool

[Xen-devel] [PATCH v4 05/16] libxl/arm: Construct ACPI RSDP table

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Construct ACPI RSDP table and add a helper to calculate the ACPI table checksum. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libx

[Xen-devel] [PATCH v4 07/16] libxl/arm: Construct ACPI GTDT table

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Construct GTDT table with the interrupt information of timers. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 8c

[Xen-devel] [PATCH v4 09/16] libxl/arm: Construct ACPI MADT table

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao According to the GIC version, construct the MADT table. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 84 1 file changed, 84 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c

[Xen-devel] [PATCH v4 10/16] libxl/arm: Construct ACPI FADT table

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 75dfcc2..cb1c9df 100644 --- a/tools/libxl/libxl_arm_acpi.c +++ b/tools/l

[Xen-devel] [PATCH v4 06/16] libxl/arm: Construct ACPI XSDT table

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm_acpi.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/tools/libxl/libxl_arm_acpi.c b/tools/libxl/libxl_arm_acpi.c index 9432e44..8cd1d9b 100644 --- a/tools/libxl/libxl_arm_acpi.c +++ b/

[Xen-devel] [PATCH v4 13/16] libxl/arm: Add ACPI module

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Add the ARM Multiboot module for ACPI, so UEFI or DomU can get the base address of ACPI tables from it. Signed-off-by: Shannon Zhao --- docs/misc/arm/device-tree/acpi.txt | 24 tools/libxl/libxl_arm.c| 24 2 files

[Xen-devel] [PATCH v4 16/16] libxl/arm: Add the size of ACPI tables to maxmem

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao While it defines the maximum size of guest ACPI tables in guest memory layout, here it adds the size to set the target maxmem to avoid providing less available memory for guest. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 11 +++ 1 file changed, 11 inse

[Xen-devel] [PATCH v4 01/16] tools/libxl: Add an unified configuration option for ACPI

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Since the existing configuration option "u.hvm.acpi" is x86 specific and we want to reuse it on ARM as well, add a unified option "acpi" for x86 and ARM, and for ARM it's disabled by default. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_create.c | 9 - tools/li

Re: [Xen-devel] [V4 PATCH 2/2] mips/panic: Replace smp_send_stop() with kdump friendly version in panic path

2016-08-16 Thread 河合英宏 / KAWAI,HIDEHIRO
> From: Corey Minyard [mailto:cminy...@mvista.com] > Sent: Tuesday, August 16, 2016 3:02 AM > On 08/15/2016 12:06 PM, Corey Minyard wrote: > > On 08/15/2016 06:35 AM, 河合英宏 / KAWAI,HIDEHIRO wrote: > >> Hi Corey, > >> > >>> From: Corey Minyard [mailto:cminy...@mvista.com] > >>> Sent: Friday, August 1

[Xen-devel] [PATCH v4 03/16] libxl/arm: Generate static ACPI DSDT table

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao It uses static DSDT table like the way x86 uses. Currently the DSDT table only contains processor device objects and it generates the maximal objects which so far is 128. Also only check iasl for aarch64 in configure since ACPI on ARM32 is not supported. Signed-off-by: Shanno

[Xen-devel] [PATCH v4 15/16] libxl/arm: Initialize domain param HVM_PARAM_CALLBACK_IRQ

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao The guest kernel will get the event channel interrupt information via domain param HVM_PARAM_CALLBACK_IRQ. Initialize it here. Signed-off-by: Shannon Zhao --- tools/libxl/libxl_arm.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tools/libxl/libxl_arm.c b

[Xen-devel] [PATCH v4 14/16] public/hvm/params.h: Add macros for HVM_PARAM_CALLBACK_TYPE_PPI

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao Add macros for HVM_PARAM_CALLBACK_TYPE_PPI operation values and update them in evtchn_fixup(). Signed-off-by: Shannon Zhao --- xen/arch/arm/domain_build.c | 8 +--- xen/include/public/hvm/params.h | 4 2 files changed, 9 insertions(+), 3 deletions(-) diff --git

[Xen-devel] [PATCH v4 00/16] Xen ARM DomU ACPI support

2016-08-16 Thread Shannon Zhao
From: Shannon Zhao The design of this feature is described as below. Firstly, the toolstack (libxl) generates the ACPI tables according the number of vcpus and gic controller. Then, it copies these ACPI tables to DomU non-RAM memory map space and passes them to UEFI firmware through the "ARM mul

[Xen-devel] [xen-4.7-testing test] 100499: tolerable FAIL - PUSHED

2016-08-16 Thread osstest service owner
flight 100499 xen-4.7-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/100499/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit2 19 guest-start/debian.repeat fail in 100491 pass in 100499 test-armhf-armhf-xl-

Re: [Xen-devel] [PATCH 4/4] x86emul: use DstEax also for XCHG

2016-08-16 Thread Andrew Cooper
On 15/08/16 09:35, Jan Beulich wrote: > Just like said in commit c0bc0adf24 ("x86emul: use DstEax where > possible"): While it avoids just a few instructions, we should > nevertheless make use of generic code as much as possible. Here we can > arrange for that by simply swapping source and destinat

Re: [Xen-devel] dependences for backporting to 4.6 [was: Re: [PATCH 2/3] xen: Have schedulers revise initial placement]

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 12:21, wrote: > On Fri, 2016-08-12 at 07:53 -0600, Jan Beulich wrote: >> Same >> for 4.5 then, were the backport adjusted for 4.6 then applied >> cleanly. >> > So, you've done the backports yourself, and you don't want/need me to > do them right? Indeed. > I'm asking because

Re: [Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 12:12, wrote: > On 15/08/16 09:35, Jan Beulich wrote: >> As of commit a800e4f611 ("x86emul: drop pointless and add useful >> default cases") we no longer need the early bailing when "d == 0" (the >> default cases in the main switch() statements take care of that), >> removal of

Re: [Xen-devel] [PATCH 4/4] x86emul: use DstEax also for XCHG

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 12:59, wrote: > On 15/08/16 09:35, Jan Beulich wrote: >> Just like said in commit c0bc0adf24 ("x86emul: use DstEax where >> possible"): While it avoids just a few instructions, we should >> nevertheless make use of generic code as much as possible. Here we can >> arrange for tha

Re: [Xen-devel] [PATCH 4/4] x86emul: use DstEax also for XCHG

2016-08-16 Thread Andrew Cooper
On 16/08/16 12:31, Jan Beulich wrote: On 16.08.16 at 12:59, wrote: >> On 15/08/16 09:35, Jan Beulich wrote: >>> Just like said in commit c0bc0adf24 ("x86emul: use DstEax where >>> possible"): While it avoids just a few instructions, we should >>> nevertheless make use of generic code as much

Re: [Xen-devel] [RFC PATCH] tools: remove blktap2 related code and documentation

2016-08-16 Thread Yang Hongyang
On Mon, Aug 15, 2016 at 6:50 PM, Wei Liu wrote: > Blktap2 is effectively dead code for a few years. > > Notable changes in this patch: > > 0. Unhook blktap2 from build system > 1. Now libxl no longer supports TAP ask backend, appropriate assertions > s/ask/disk/ are added and some code paths

Re: [Xen-devel] [PATCH 4/4] x86emul: use DstEax also for XCHG

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 14:46, wrote: > On 16/08/16 12:31, Jan Beulich wrote: > On 16.08.16 at 12:59, wrote: >>> On 15/08/16 09:35, Jan Beulich wrote: Just like said in commit c0bc0adf24 ("x86emul: use DstEax where possible"): While it avoids just a few instructions, we should never

Re: [Xen-devel] [PATCH v5 4/4] x86/ioreq server: Reset outstanding p2m_ioreq_server entries when an ioreq server unmaps.

2016-08-16 Thread George Dunlap
On 12/07/16 10:02, Yu Zhang wrote: > This patch resets p2m_ioreq_server entries back to p2m_ram_rw, > after an ioreq server has unmapped. The resync is done both > asynchronously with the current p2m_change_entry_type_global() > interface, and synchronously by iterating the p2m table. The > synchro

Re: [Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

2016-08-16 Thread Andrew Cooper
On 16/08/16 12:27, Jan Beulich wrote: On 16.08.16 at 12:12, wrote: >> On 15/08/16 09:35, Jan Beulich wrote: >>> As of commit a800e4f611 ("x86emul: drop pointless and add useful >>> default cases") we no longer need the early bailing when "d == 0" (the >>> default cases in the main switch() st

[Xen-devel] [PATCH] x86emul: improve LOCK handling

2016-08-16 Thread Jan Beulich
Certain opcodes would so far not have got #UD when a LOCK prefix was present. Adjust this by - moving the too early generic check into destination operand decoding, where DstNone and DstReg already have respective handling - switching source and destination of TEST r,r/m, for it to be taken car

Re: [Xen-devel] [PATCH v5 4/4] x86/ioreq server: Reset outstanding p2m_ioreq_server entries when an ioreq server unmaps.

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 15:35, wrote: > Although really, it seems like having a "p2m_finish_type_change()" > function which looked for misconfigured entries and reset them would be > a step closer to the right direction, in that it could be re-used in > other situations where the type change may not ha

[Xen-devel] [PATCH] x86emul: introduce SrcEax for XCHG

2016-08-16 Thread Jan Beulich
Just like said in commit c0bc0adf24 ("x86emul: use DstEax where possible"): While it avoids just a few instructions, we should nevertheless make use of generic code as much as possible. Here we can arrange for that by simply introducing SrcEax (which requires no other code adjustments). Signed-off

Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

2016-08-16 Thread Andrew Cooper
On 16/08/16 10:32, Jan Beulich wrote: > Just like said in commit c0bc0adf24 ("x86emul: use DstEax where > possible"): While it avoids just a few instructions, we should > nevertheless make use of generic code as much as possible. > > Signed-off-by: Jan Beulich This does reduce the amount of code,

Re: [Xen-devel] [PATCH 2/3] x86emul: don't open code EFLAGS handling for 2-operand IMUL

2016-08-16 Thread Andrew Cooper
On 16/08/16 10:33, Jan Beulich wrote: > Slightly extending the emulate_2op*() macro machinery makes it usable > for IMUL r,r/m too, which has the benefit of smaller source code and > the EFLAGS output being guaranteed to match actual hardware behavior. > > Signed-off-by: Jan Beulich Reviewed-by:

Re: [Xen-devel] [PATCH 3/3] x86emul: re-order main 2-byte opcode switch() statement

2016-08-16 Thread Andrew Cooper
On 16/08/16 10:34, Jan Beulich wrote: > This was meant to be numerically sorted (with reasonable exceptions), > but we've manage to diverge from that. > > No functional change, only code movement. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper _

Re: [Xen-devel] [PATCH] x86emul: introduce SrcEax for XCHG

2016-08-16 Thread Andrew Cooper
On 16/08/16 14:51, Jan Beulich wrote: > Just like said in commit c0bc0adf24 ("x86emul: use DstEax where > possible"): While it avoids just a few instructions, we should > nevertheless make use of generic code as much as possible. Here we can > arrange for that by simply introducing SrcEax (which re

Re: [Xen-devel] [PATCH] x86emul: introduce SrcEax for XCHG

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 16:32, wrote: > On 16/08/16 14:51, Jan Beulich wrote: >> Just like said in commit c0bc0adf24 ("x86emul: use DstEax where >> possible"): While it avoids just a few instructions, we should >> nevertheless make use of generic code as much as possible. Here we can >> arrange for tha

Re: [Xen-devel] [PATCH] x86emul: introduce SrcEax for XCHG

2016-08-16 Thread Andrew Cooper
On 16/08/16 15:50, Jan Beulich wrote: On 16.08.16 at 16:32, wrote: >> On 16/08/16 14:51, Jan Beulich wrote: >>> Just like said in commit c0bc0adf24 ("x86emul: use DstEax where >>> possible"): While it avoids just a few instructions, we should >>> nevertheless make use of generic code as much

Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 16:08, wrote: > On 16/08/16 10:32, Jan Beulich wrote: >> Just like said in commit c0bc0adf24 ("x86emul: use DstEax where >> possible"): While it avoids just a few instructions, we should >> nevertheless make use of generic code as much as possible. >> >> Signed-off-by: Jan Beuli

Re: [Xen-devel] [PATCH] x86emul: improve LOCK handling

2016-08-16 Thread Andrew Cooper
On 16/08/16 14:51, Jan Beulich wrote: > Certain opcodes would so far not have got #UD when a LOCK prefix was > present. Adjust this by > - moving the too early generic check into destination operand decoding, > where DstNone and DstReg already have respective handling > - switching source and des

Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

2016-08-16 Thread Andrew Cooper
On 16/08/16 15:57, Jan Beulich wrote: On 16.08.16 at 16:08, wrote: >> On 16/08/16 10:32, Jan Beulich wrote: >>> Just like said in commit c0bc0adf24 ("x86emul: use DstEax where >>> possible"): While it avoids just a few instructions, we should >>> nevertheless make use of generic code as much

[Xen-devel] [PATCH] x86/PV: don't hide CPUID.OSXSAVE from user mode

2016-08-16 Thread Jan Beulich
User mode code generally cannot be expected to invoke the PV-enabled CPUID Xen supports, and prior to the CPUID levelling changes for 4.7 (as well as even nowadays on levelling incapable hardware) such CPUID invocations actually saw the host CR4.OSXSAVE value. Fold in the guest view of CR4.OSXSAVE

[Xen-devel] Remus memcpy dirty pages if local host

2016-08-16 Thread Sunny Raj
Hi, I'm Sunny Raj, and this is the first time I'm posting to xen-devel. I'm a research student currently working on some aspects of virtual machine introspection. Specifically, instead of introspecting the VM directly, I use remus to checkpoint the VM to a backup on to the localhost, and run intro

Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 17:11, wrote: > On 16/08/16 15:57, Jan Beulich wrote: > On 16.08.16 at 16:08, wrote: >>> On 16/08/16 10:32, Jan Beulich wrote: Just like said in commit c0bc0adf24 ("x86emul: use DstEax where possible"): While it avoids just a few instructions, we should never

Re: [Xen-devel] [PATCH] x86/PV: don't hide CPUID.OSXSAVE from user mode

2016-08-16 Thread Andrew Cooper
On 16/08/16 16:20, Jan Beulich wrote: > User mode code generally cannot be expected to invoke the PV-enabled > CPUID Xen supports, and prior to the CPUID levelling changes for 4.7 > (as well as even nowadays on levelling incapable hardware) such CPUID > invocations actually saw the host CR4.OSXSAVE

Re: [Xen-devel] [PATCH] x86/PV: don't hide CPUID.OSXSAVE from user mode

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 17:41, wrote: > On 16/08/16 16:20, Jan Beulich wrote: >> User mode code generally cannot be expected to invoke the PV-enabled >> CPUID Xen supports, and prior to the CPUID levelling changes for 4.7 >> (as well as even nowadays on levelling incapable hardware) such CPUID >> invoc

[Xen-devel] [xen-unstable-smoke test] 100515: tolerable all pass - PUSHED

2016-08-16 Thread osstest service owner
flight 100515 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/100515/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 1

Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

2016-08-16 Thread Jan Beulich
>>> On 16.08.16 at 17:23, wrote: On 16.08.16 at 17:11, wrote: >> On 16/08/16 15:57, Jan Beulich wrote: >> On 16.08.16 at 16:08, wrote: On 16/08/16 10:32, Jan Beulich wrote: > Just like said in commit c0bc0adf24 ("x86emul: use DstEax where > possible"): While it avoids just

Re: [Xen-devel] [PATCH] x86/PV: don't hide CPUID.OSXSAVE from user mode

2016-08-16 Thread Andrew Cooper
On 16/08/16 17:00, Jan Beulich wrote: On 16.08.16 at 17:41, wrote: >> On 16/08/16 16:20, Jan Beulich wrote: >>> User mode code generally cannot be expected to invoke the PV-enabled >>> CPUID Xen supports, and prior to the CPUID levelling changes for 4.7 >>> (as well as even nowadays on levell

Re: [Xen-devel] [PATCH 1/3] x86emul: use DstEax also for {, I}{MUL, DIV}

2016-08-16 Thread Andrew Cooper
On 16/08/16 17:07, Jan Beulich wrote: On 16.08.16 at 17:23, wrote: > On 16.08.16 at 17:11, wrote: >>> On 16/08/16 15:57, Jan Beulich wrote: >>> On 16.08.16 at 16:08, wrote: > On 16/08/16 10:32, Jan Beulich wrote: >> Just like said in commit c0bc0adf24 ("x86emul: use DstEax w

[Xen-devel] [distros-debian-snapshot test] 67540: regressions - FAIL

2016-08-16 Thread Platform Team regression test user
flight 67540 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/67540/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-i386-current-netinst-pygrub 10 guest-start fail REGR. vs. 66946 Regr

Re: [Xen-devel] [RFC 01/22] xen/arm: do_trap_instr_abort_guest: Move the IPA computation out of the switch

2016-08-16 Thread Julien Grall
Hi Stefano, On 16/08/2016 01:21, Stefano Stabellini wrote: On Thu, 28 Jul 2016, Julien Grall wrote: A follow-up patch will add more case to the switch that will require the IPA. So move the computation out of the switch. Signed-off-by: Julien Grall --- xen/arch/arm/traps.c | 36 +

Re: [Xen-devel] [PATCH 0/4] boot-wrapper: arm64: Xen support

2016-08-16 Thread Julien Grall
Hi Andre, Do you plan to send a new version of this series? Cheers, On 20/06/2016 16:09, Andre Przywara wrote: These patches allow to include a Xen hypervisor binary into a boot-wrapper ELF file, so that a Foundation Platform or a Fast Model can boot a Xen system (including a Dom0 kernel). Thi

[Xen-devel] [xen-unstable test] 100501: regressions - FAIL

2016-08-16 Thread osstest service owner
flight 100501 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/100501/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl 6 xen-boot fail REGR. vs. 100488 test-amd64-i386-xl

[Xen-devel] [ovmf test] 100505: all pass - PUSHED

2016-08-16 Thread osstest service owner
flight 100505 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/100505/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d35ec1e0507dc612ed6485410f12e683a726a3bf baseline version: ovmf de74668f5ea713b7e91e0

Re: [Xen-devel] [PATCH v2 2/2] x86/altp2m: allow specifying external-only use-case

2016-08-16 Thread Daniel De Graaf
On 08/11/2016 10:51 AM, Jan Beulich wrote: On 11.08.16 at 16:37, wrote: On Aug 11, 2016 06:02, "Jan Beulich" wrote: On 10.08.16 at 17:00, wrote: @@ -5238,18 +5238,19 @@ static int do_altp2m_op( goto out; } -if ( (rc = xsm_hvm_altp2mhvm_op(XSM_TARGET, d)) ) +if ( !d-

Re: [Xen-devel] [PATCH v2] domctl: relax getdomaininfo permissions

2016-08-16 Thread Daniel De Graaf
On 08/11/2016 07:33 AM, Jan Beulich wrote: On 05.08.16 at 13:20, wrote: Daniel, I've only now realized that I forgot to Cc you on this v2. Jan Qemu needs access to this for the domain it controls, both due to it being used by xc_domain_memory_mapping() (which qemu calls) and the explicit u

[Xen-devel] [PATCH v3 18/38] arm/p2m: Add HVMOP_altp2m_destroy_p2m

2016-08-16 Thread Sergej Proskurin
Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v2: Substituted the call to tlb_flush for p2m_flush_table. Added comments. Cosmetic fixes. v3: Changed the locking mechanism to "p2m_write_lock" inside the function "altp2m_destroy_by_id". Do not fl

[Xen-devel] [PATCH v3 35/38] arm/p2m: Adjust debug information to altp2m

2016-08-16 Thread Sergej Proskurin
Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v2: Dump p2m information of the hostp2m and all altp2m views. --- xen/arch/arm/p2m.c | 20 1 file changed, 20 insertions(+) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index dea3038..8

[Xen-devel] [PATCH v3 16/38] arm/p2m: Add HVMOP_altp2m_set_domain_state

2016-08-16 Thread Sergej Proskurin
The HVMOP_altp2m_set_domain_state allows to activate altp2m on a specific domain. This commit adopts the x86 HVMOP_altp2m_set_domain_state implementation. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v2: Dynamically allocate memory for altp2m views only when n

[Xen-devel] [PATCH v3 19/38] arm/p2m: Add HVMOP_altp2m_switch_p2m

2016-08-16 Thread Sergej Proskurin
Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v3: Extended the function "altp2m_switch_domain_altp2m_by_id" so that if the guest domain indirectly calles this function, the current vcpu also changes the altp2m view without performing an explicit context

[Xen-devel] [PATCH v3 34/38] arm/p2m: Add HVMOP_altp2m_change_gfn

2016-08-16 Thread Sergej Proskurin
This commit adds the functionality to change mfn mappings for specified gfn's in altp2m views. This mechanism can be used within the context of VMI, e.g., to establish stealthy debugging. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v3: Moved the altp2m_lock t

[Xen-devel] [PATCH v3 14/38] arm/p2m: Add altp2m init/teardown routines

2016-08-16 Thread Sergej Proskurin
The p2m initialization now invokes initialization routines responsible for the allocation and initialization of altp2m structures. The same applies to teardown routines. The functionality has been adopted from the x86 altp2m implementation. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabelli

[Xen-devel] [PATCH v3 38/38] arm/p2m: Add test of xc_altp2m_change_gfn

2016-08-16 Thread Sergej Proskurin
This commit extends xen-access by a simple test of the functionality provided by "xc_altp2m_change_gfn". The idea is to dynamically remap a trapping gfn to another mfn, which holds the same content as the original mfn. On success, the guest will continue to run. Subsequent altp2m access violations

[Xen-devel] [PATCH v3 09/38] arm/p2m: Add backpointer to the domain in p2m_domain

2016-08-16 Thread Sergej Proskurin
With the introduction of altp2m, many functions have been adapted to receive an argument of type "struct p2m_domain*" instead of "struct domain*". A backpointer to the associated domain within the "struct p2m_domain*" reduces the number of function parameters without losing the accessibility of the

[Xen-devel] [PATCH v3 32/38] arm/p2m: Code movement in instr/data abort handlers

2016-08-16 Thread Sergej Proskurin
This commit moves code in the functions "do_trap_data_(instr|abort)_guest" without changing the original functionality. The code movement is limited to moving the struct npfec out of the switch statements in both functions. This commit acts as a basis for the following commit implementing the altp2

[Xen-devel] [PATCH v3 20/38] arm/p2m: Add p2m_get_active_p2m macro

2016-08-16 Thread Sergej Proskurin
This commit introduces the macro "p2m_get_active_p2m" returning the currently active (alt)p2m. The need for this macro will be shown in the following commits. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/p2m.c | 3 +++ 1 file changed, 3 insertion

[Xen-devel] [PATCH v3 08/38] arm/p2m: Free p2m entries only in the hostp2m

2016-08-16 Thread Sergej Proskurin
Freeing p2m entries of arbitrary p2m's (in particular in alternate p2m's) will lead to unpredicted behavior as the entries might still be used within the host's p2m. The host's p2m should, however, free the entries, as it is the main instance responsible for their management. If entries were freed

[Xen-devel] [PATCH v3 22/38] arm/p2m: Make get_page_from_gva ready for altp2m

2016-08-16 Thread Sergej Proskurin
The function get_page_from_gva uses ARM's hardware support to translate gva's to machine addresses. This function is used, among others, for memory regulation purposes, e.g, within the context of memory ballooning. To ensure correct behavior while altp2m is in use, we use the host's p2m table for t

[Xen-devel] [PATCH v3 21/38] arm/p2m: Make p2m_restore_state ready for altp2m

2016-08-16 Thread Sergej Proskurin
This commit adapts the function "p2m_restore_state" in a way that the currently active altp2m table is considered during state restoration. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v3: Moved declaration of "altp2m_switch_domain_altp2m_by_id" out of this

[Xen-devel] [PATCH v3 36/38] altp2m: Allow specifying external-only use-case

2016-08-16 Thread Sergej Proskurin
From: Tamas K Lengyel Currently setting altp2mhvm=1 in the domain configuration allows access to the altp2m interface for both in-guest and external privileged tools. This poses a problem for use-cases where only external access should be allowed, requiring the user to compile Xen with XSM enable

[Xen-devel] [PATCH v3 13/38] arm/p2m: Change func prototype and impl of p2m_(alloc|free)_vmid

2016-08-16 Thread Sergej Proskurin
This commit changes the prototype and implementation of the functions "p2m_alloc_vmid" and "p2m_free_vmid". The function "p2m_alloc_vmid" does not expect the struct domain as argument anymore and returns an allocated vmid. The function "p2m_free_vmid" takes only the vmid that is to be freed as argu

[Xen-devel] [PATCH v3 11/38] arm/p2m: Cosmetic fix - function prototype of p2m_alloc_table

2016-08-16 Thread Sergej Proskurin
The function "p2m_alloc_table" should be able to allocate 2nd stage translation tables not only for the host's p2m but also for alternate p2m's. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v2: Removed altp2m table initialization from "p2m_table_init". v3: Re

[Xen-devel] [PATCH v3 07/38] arm/p2m: Introduce p2m_is_(hostp2m|altp2m)

2016-08-16 Thread Sergej Proskurin
This commit adds a p2m class to the struct p2m_domain to distinguish between the host's original p2m and alternate p2m's. The need for this functionality will be shown in the following commits. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- xen/include/asm-arm/

[Xen-devel] [PATCH v3 28/38] arm/p2m: Modify reference count only if hostp2m active

2016-08-16 Thread Sergej Proskurin
This commit makes sure that the page reference count is updated through the function "p2m_put_l3_page" only the entries have been freed from the hosts's p2m. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/p2m.c | 2 +- 1 file changed, 1 insertion(+

[Xen-devel] [PATCH v3 26/38] arm/p2m: Introduce helpers managing altp2m entries

2016-08-16 Thread Sergej Proskurin
This commit introduces the following functions: * remove_altp2m_entry * modify_altp2m_entry These functions are responsible to manage an altp2m view's entries and their attributes. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- v3: Changed the function prototyp

[Xen-devel] [PATCH v3 30/38] arm/p2m: Add altp2m_propagate_change

2016-08-16 Thread Sergej Proskurin
This commit introduces the function "altp2m_propagate_change" that is responsible to propagate changes applied to the host's p2m to a specific or even all altp2m views. In this way, Xen can in-/decrease the guest's physmem at run-time without leaving the altp2m views with stalled/invalid entries.

[Xen-devel] [PATCH v3 12/38] arm/p2m: Rename parameter in p2m_alloc_vmid

2016-08-16 Thread Sergej Proskurin
This commit does not change or introduce any additional functionality but rather is a part of the following commit that alters the functionality of the function "p2m_alloc_vmid". Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc: Julien Grall --- xen/arch/arm/p2m.c | 12 ++-

[Xen-devel] [PATCH v3 01/38] arm/p2m: Cosmetic fixes - apply p2m_get_hostp2m

2016-08-16 Thread Sergej Proskurin
This commit substitutes the direct access of the host's p2m (&d->arch.p2m) for the macro "p2m_get_hostp2m". This macro simplifies the differentiation between the host's p2m and introduced alternative p2m's, in the following commits. Signed-off-by: Sergej Proskurin --- Cc: Stefano Stabellini Cc:

[Xen-devel] [PATCH v3 10/38] arm/p2m: Move hostp2m init/teardown to individual functions

2016-08-16 Thread Sergej Proskurin
This commit pulls out generic init/teardown functionality out of "p2m_init" and "p2m_teardown" into "p2m_init_one", "p2m_teardown_one", and "p2m_flush_table" functions. This allows our future implementation to reuse existing code for the initialization/teardown of altp2m views. Signed-off-by: Ser

[Xen-devel] [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id

2016-08-16 Thread Sergej Proskurin
This commit adds the function "altp2m_switch_vcpu_altp2m_by_id" that is executed after checking whether the vcpu should be switched to a different altp2m within the function "altp2m_check". Please note that in this commit, the function "p2m_altp2m_check" is renamed to "altp2m_check" and moved from

[Xen-devel] [PATCH v3 03/38] arm/p2m: Introduce p2m_(switch|restore)_vttbr_and_(g|s)et_flags

2016-08-16 Thread Sergej Proskurin
This commit introduces macros for switching and restoring the vttbr considering the currently set irq flags. We define these macros, as the following commits will use the associated functionality multiple times throughout the file ./xen/arch/arm/p2m.c. Signed-off-by: Sergej Proskurin --- Cc: Stef

  1   2   >