Re: [Xen-devel] [PATCH 1/2] tools: remove systemd xenstore socket definitions

2016-07-13 Thread Juergen Gross
On 29/06/16 15:44, Juergen Gross wrote: > On 29/06/16 15:31, Ross Lagerwall wrote: >> On 06/29/2016 02:00 PM, Juergen Gross wrote: >>> On 29/06/16 14:52, Andrew Cooper wrote: On 29/06/16 13:44, Juergen Gross wrote: > @@ -2068,13 +1964,6 @@ int main(int argc, char *argv[]) > /* Tel

[Xen-devel] [distros-debian-squeeze test] 66561: tolerable trouble: blocked/broken

2016-07-13 Thread Platform Team regression test user
flight 66561 distros-debian-squeeze real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66561/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-armhf-pvops 3 host-install(3) broken like 66523 build-armhf

Re: [Xen-devel] [PATCH] xen/apic: Update the comment for apic_id_mask

2016-07-13 Thread Wei, Jiangang
On Thu, 2016-07-07 at 11:37 -0400, Boris Ostrovsky wrote: > On 07/07/2016 11:25 AM, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 07, 2016 at 11:28:18AM +0800, Wei Jiangang wrote: > >> verify_local_APIC() had been removed by > >> commit 4399c03c6780 ("x86/apic: Remove verify_local_APIC()"), > >> so

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-13 Thread Shannon Zhao
On 2016/7/12 19:33, Wei Liu wrote: > On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: > [...] Yeah, we can deprecate that field. But we need to take care to not break users of the old field. >>> Ok, what name would you suggest? >> >> I would suggest b_info->u.acpi >> > > b

Re: [Xen-devel] How to find out how much cpu time each domain used?

2016-07-13 Thread Dario Faggioli
On Mon, 2016-07-04 at 20:09 +, Amin Fallahi wrote: > Dear all > > I am modifying credit scheduler and I want to give credit to each > vcpu based on cpu time which its domain has consumed. > Suppose: > credit_fair =((credit_total*sdom->weight)+(weight_total- > 1))/weight_total > Mind describin

Re: [Xen-devel] [PATCH v7 03/14] xen: Use a typesafe to define INVALID_MFN

2016-07-13 Thread Tim Deegan
At 18:04 +0100 on 12 Jul (1468346680), George Dunlap wrote: > On Tue, Jul 12, 2016 at 2:59 PM, Julien Grall wrote: > > Also take the opportunity to convert arch/x86/debug.c to the typesafe > > mfn and use proper printf format for MFN/GFN when the code around is > > modified. > > > > Signed-off-by:

Re: [Xen-devel] [PATCH v2] vmx/monitor: CPUID events

2016-07-13 Thread Wei Liu
On Tue, Jul 12, 2016 at 12:13:18PM -0600, Tamas K Lengyel wrote: > This patch implements sending notification to a monitor subscriber when an > x86/vmx guest executes the CPUID instruction. > > Signed-off-by: Tamas K Lengyel > --- > Cc: Ian Jackson > Cc: Wei Liu > Cc: Razvan Cojocaru > Cc: Jan

Re: [Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-13 Thread Dirk Behme
On 13.07.2016 00:26, Michael Turquette wrote: Quoting Dirk Behme (2016-07-12 00:46:45) Clocks described by this property are reserved for use by Xen, and the OS must not alter their state any way, such as disabling or gating a clock, or modifying its rate. Ensuring this may impose constraints on

[Xen-devel] [PATCH v6 00/46] dma-mapping: Use unsigned long for dma_attrs

2016-07-13 Thread Krzysztof Kozlowski
Hi, The fifth version of this patchset was merged by Andrew Morton few days ago. It was rebased on v4.7-rc5 so it missed some ongoing changes. This is just rebase on next-20160713. For easier testing the patchset is available here: repo: https://github.com/krzk/linux branch: for-next/dma

[Xen-devel] [PATCH v6 05/46] ARM: dma-mapping: Use unsigned long for dma_attrs

2016-07-13 Thread Krzysztof Kozlowski
Split out subsystem specific changes for easier reviews. This will be squashed with main commit. Signed-off-by: Krzysztof Kozlowski --- arch/arm/common/dmabounce.c | 4 +- arch/arm/include/asm/dma-mapping.h | 13 +++-- arch/arm/include/asm/xen/page-coherent.h | 16 +++ ar

[Xen-devel] [PATCH v6 20/46] xen: dma-mapping: Use unsigned long for dma_attrs

2016-07-13 Thread Krzysztof Kozlowski
Split out subsystem specific changes for easier reviews. This will be squashed with main commit. Signed-off-by: Krzysztof Kozlowski [for xen] Acked-by: David Vrabel [for xen swiotlb] Acked-by: Konrad Rzeszutek Wilk --- drivers/xen/swiotlb-xen.c | 14 +++--- include/xen/swiotlb-xen.h |

[Xen-devel] [PATCH v6 45/46] dma-mapping: Remove dma_get_attr

2016-07-13 Thread Krzysztof Kozlowski
After switching DMA attributes to unsigned long it is easier to just compare the bits. Signed-off-by: Krzysztof Kozlowski [for avr32] Acked-by: Hans-Christian Noren Egtvedt [for arc] Acked-by: Vineet Gupta [for arm64 and dma-iommu] Acked-by: Robin Murphy --- Documentation/DMA-API.txt

[Xen-devel] [PATCH v6 24/46] x86: dma-mapping: Use unsigned long for dma_attrs

2016-07-13 Thread Krzysztof Kozlowski
Split out subsystem specific changes for easier reviews. This will be squashed with main commit. Signed-off-by: Krzysztof Kozlowski --- arch/x86/include/asm/dma-mapping.h | 5 ++--- arch/x86/include/asm/swiotlb.h | 4 ++-- arch/x86/include/asm/xen/page-coherent.h | 9 -

Re: [Xen-devel] [PATCH] credi2-ratelimit: Implement rate limit for credit2 scheduler

2016-07-13 Thread Dario Faggioli
On Tue, 2016-07-12 at 17:16 +0100, George Dunlap wrote: > On Wed, Jul 6, 2016 at 6:33 PM, Makkar anshul.mak...@citrix.com > wrote: > >  > > --- a/xen/common/sched_credit2.c > > +++ b/xen/common/sched_credit2.c > > @@ -171,6 +171,11 @@ integer_param("sched_credit2_migrate_resist", > > opt_migrate_r

[Xen-devel] [PATCH] xl: add option to leave domain paused afer migration

2016-07-13 Thread Roger Pau Monne
This is useful for debugging domains that crash on resume from migration. Signed-off-by: Roger Pau Monné --- Cc: ian.jack...@eu.citrix.com Cc: wei.l...@citrix.com --- tools/libxl/xl_cmdimpl.c | 29 +++-- tools/libxl/xl_cmdtable.c | 3 ++- 2 files changed, 21 insertions(

Re: [Xen-devel] [PATCH v3 1/2] Interface for grant copy operation in libs.

2016-07-13 Thread Wei Liu
On Fri, Jul 08, 2016 at 02:18:46PM +0100, Wei Liu wrote: > To unblock Paulina on her series, I would be ok with the cast provided > there is compile-time check to ensure the user-space structure is > identical to the ioctl structure. > > That would involve: > 1. Introducing BUILD_BUG_ON, offsetof,

[Xen-devel] [PATCH] Add optional ACPI device for Windows Continuum

2016-07-13 Thread Owen Smith
Windows 10 supports a specific ACPI device for handling the switch between tablet mode and desktop mode. The meer existance of this device is the mimimum to allow tablet/desktop mode to be switched. Tablet mode referes to the "undocked" state where all applications are forced full screen and additi

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-13 Thread Julien Grall
Hi Shannon, On 13/07/2016 08:54, Shannon Zhao wrote: On 2016/7/12 19:33, Wei Liu wrote: On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: [...] Yeah, we can deprecate that field. But we need to take care to not break users of the old field. Ok, what name would you suggest? I wou

[Xen-devel] [PATCH] libs/gnttab: introduce BUILD_BUG_ON

2016-07-13 Thread Wei Liu
The implementation is taken from libxc. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Paulina Szubarczyk I could have put it in a header file accessible to all libraries under libs but this construct is only relevant to xengnttab library at the moment so it's put under gnttab/private.h. It ca

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-13 Thread Shannon Zhao
On 2016/7/13 17:20, Julien Grall wrote: > On 13/07/2016 08:54, Shannon Zhao wrote: >> On 2016/7/12 19:33, Wei Liu wrote: >>> On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: >>> [...] >> Yeah, we can deprecate that field. But we need to take care to not >> break >> users

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-13 Thread Julien Grall
On 13/07/2016 10:48, Shannon Zhao wrote: On 2016/7/13 17:20, Julien Grall wrote: On 13/07/2016 08:54, Shannon Zhao wrote: On 2016/7/12 19:33, Wei Liu wrote: On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: [...] Yeah, we can deprecate that field. But we need to take care to n

Re: [Xen-devel] [DRAFT 1] XenSock protocol design document

2016-07-13 Thread Stefano Stabellini
On Mon, 11 Jul 2016, Joao Martins wrote: > On 07/08/2016 12:23 PM, Stefano Stabellini wrote: > > Hi all, > > > Hey! > > [...] > > > > > ## Design > > > > ### Xenstore > > > > The frontend and the backend connect to each other exchanging information > > via > > xenstore. The toolstack creates

Re: [Xen-devel] [PATCH] credi2-ratelimit: Implement rate limit for credit2 scheduler

2016-07-13 Thread George Dunlap
On 13/07/16 09:53, Dario Faggioli wrote: >> @@ -1675,9 +1711,19 @@ csched2_runtime(const struct scheduler *ops, >> int cpu, struct csched2_vcpu *snext >> * 1) Run until snext's credit will be 0 >> * 2) But if someone is waiting, run until snext's credit is >> equal >> * to his >>

[Xen-devel] [PATCH 0/2] adjustments

2016-07-13 Thread Corneliu ZUZU
Corneliu ZUZU (2): asm/atomic.h: common prototyping (add xen/atomic.h) fix: make atomic_read() param const xen/include/asm-arm/arm32/atomic.h | 11 --- xen/include/asm-arm/arm64/atomic.h | 11 --- xen/include/asm-arm/atomic.h | 91 +++--- xen/include/asm-x86/atomic.h

[Xen-devel] [PATCH 1/2] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Corneliu ZUZU
Following Andrew Cooper's suggestion, create a common-side to establish, among others, prototypes of atomic functions called from common-code. Done to avoid introducing inconsistencies between arch-side headers when we make subtle changes to one of them. Some arm-side macros had to be turned int

[Xen-devel] [PATCH 2/2] fix: make atomic_read() param const

2016-07-13 Thread Corneliu ZUZU
This wouldn't let me make a param of a function that used atomic_read() const. Signed-off-by: Corneliu ZUZU --- xen/include/asm-arm/atomic.h | 2 +- xen/include/asm-x86/atomic.h | 2 +- xen/include/xen/atomic.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/includ

Re: [Xen-devel] [PATCH] libs/gnttab: introduce BUILD_BUG_ON

2016-07-13 Thread Paulina Szubarczyk
On 07/13/2016 11:25 AM, Wei Liu wrote: The implementation is taken from libxc. Signed-off-by: Wei Liu --- Cc: Ian Jackson Cc: Paulina Szubarczyk I could have put it in a header file accessible to all libraries under libs but this construct is only relevant to xengnttab library at the momen

Re: [Xen-devel] [PATCH] libs/gnttab: introduce BUILD_BUG_ON

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 01:32:10PM +0200, Paulina Szubarczyk wrote: > > > On 07/13/2016 11:25 AM, Wei Liu wrote: > >The implementation is taken from libxc. > > > >Signed-off-by: Wei Liu > >--- > >Cc: Ian Jackson > >Cc: Paulina Szubarczyk > > > >I could have put it in a header file accessible t

Re: [Xen-devel] [PATCH 1/2] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Andrew Cooper
On 13/07/16 12:23, Corneliu ZUZU wrote: > Following Andrew Cooper's suggestion, create a common-side to > establish, among others, prototypes of atomic functions called from > common-code. > Done to avoid introducing inconsistencies between arch-side > headers when we make subtle changes to one

Re: [Xen-devel] [PATCH 2/2] fix: make atomic_read() param const

2016-07-13 Thread Andrew Cooper
On 13/07/16 12:23, Corneliu ZUZU wrote: > This wouldn't let me make a param of a function that used atomic_read() const. > > Signed-off-by: Corneliu ZUZU Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.or

Re: [Xen-devel] [PATCH 1/2] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Julien Grall
Hi Corneliu, On 13/07/2016 12:23, Corneliu ZUZU wrote: Following Andrew Cooper's suggestion, create a common-side to establish, among others, prototypes of atomic functions called from common-code. Done to avoid introducing inconsistencies between arch-side headers when we make subtle changes

Re: [Xen-devel] [PATCH] libs/gnttab: introduce BUILD_BUG_ON

2016-07-13 Thread Andrew Cooper
On 13/07/16 13:07, Wei Liu wrote: > On Wed, Jul 13, 2016 at 01:32:10PM +0200, Paulina Szubarczyk wrote: >> >> On 07/13/2016 11:25 AM, Wei Liu wrote: >>> The implementation is taken from libxc. >>> >>> Signed-off-by: Wei Liu >>> --- >>> Cc: Ian Jackson >>> Cc: Paulina Szubarczyk >>> >>> I could h

Re: [Xen-devel] [PATCH] libs/gnttab: introduce BUILD_BUG_ON

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 01:16:51PM +0100, Andrew Cooper wrote: > On 13/07/16 13:07, Wei Liu wrote: > > On Wed, Jul 13, 2016 at 01:32:10PM +0200, Paulina Szubarczyk wrote: > >> > >> On 07/13/2016 11:25 AM, Wei Liu wrote: > >>> The implementation is taken from libxc. > >>> > >>> Signed-off-by: Wei Li

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Juergen Gross
On 06/07/16 09:31, Juergen Gross wrote: > While testing some patches for support of ballooning in Mini-OS by using > the xenstore domain I realized that each xl create/destroy pair would > increase memory consumption in Mini-OS by about 5kB. Wondering whether > this is a xenstore domain only effect

[Xen-devel] [PATCH 0/2] Allow crash dumps with crash_kexec_post_notifiers

2016-07-13 Thread Petr Tesarik
Hello all, this patch series makes it possible to save a kernel crash dump when the kernel command line includes "crash_kexec_post_notifiers". There might be other approaches, but mine has the advantage that no new sysctl is required, and the behaviour is the same whether panic notifiers are run o

[Xen-devel] [PATCH 2/2] Allow kdump with crash_kexec_post_notifiers

2016-07-13 Thread Petr Tesarik
If a crash kernel is loaded, do not crash the running domain. This is needed if the kernel is loaded with crash_kexec_post_notifiers, because panic notifiers are run before __crash_kexec() in that case, and this Xen hook prevents its being called later. Signed-off-by: Petr Tesarik --- arch/x86/x

Re: [Xen-devel] [PATCH 1/2] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Corneliu ZUZU
On 7/13/2016 3:12 PM, Andrew Cooper wrote: On 13/07/16 12:23, Corneliu ZUZU wrote: Following Andrew Cooper's suggestion, create a common-side to establish, among others, prototypes of atomic functions called from common-code. Done to avoid introducing inconsistencies between arch-side headers

[Xen-devel] [PATCH 1/2] Add a kexec_crash_loaded() function

2016-07-13 Thread Petr Tesarik
Provide a wrapper function to be used by kernel code to check whether a crash kernel is loaded. It returns the same value that can be seen in /sys/kernel/kexec_crash_loaded by userspace programs. I'm exporting the function, because it will be used by Xen, and it is possible to compile Xen modules

Re: [Xen-devel] [PATCH 1/2] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Corneliu ZUZU
Hi Julien, On 7/13/2016 3:14 PM, Julien Grall wrote: Hi Corneliu, On 13/07/2016 12:23, Corneliu ZUZU wrote: Following Andrew Cooper's suggestion, create a common-side to establish, among others, prototypes of atomic functions called from common-code. Done to avoid introducing inconsistencies

Re: [Xen-devel] [PATCH 0/2] Allow crash dumps with crash_kexec_post_notifiers

2016-07-13 Thread Petr Tesarik
On Wed, 13 Jul 2016 14:19:50 +0200 Petr Tesarik wrote: > Hello all, > > this patch series makes it possible to save a kernel crash dump when the > kernel command line includes "crash_kexec_post_notifiers". Oh ... I forgot to add: This only applies to running Linux under Xen. If you run on bare

[Xen-devel] [PATCH] xen: remove xenstore watches of backends when terminating qemu

2016-07-13 Thread Juergen Gross
Xenstore watches of the /local/domain//backend/ directories are never removed. This can lead to a memory leak in xenstored, especially when xenstored is running in another domain (this will be the case either for a system with xenstore-stubdom, or with driver domains running qemu-based backends).

Re: [Xen-devel] [PATCH v3 2/2] qdisk - hw/block/xen_disk: grant copy implementation

2016-07-13 Thread Paulina Szubarczyk
On 06/22/2016 10:38 AM, Paulina Szubarczyk wrote: Copy data operated on during request from/to local buffers to/from the grant references. Before grant copy operation local buffers must be allocated what is done by calling ioreq_init_copy_buffers. For the 'read' operation, first, the qemu devic

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Andrew Cooper
On 13/07/16 13:21, Juergen Gross wrote: > On 06/07/16 09:31, Juergen Gross wrote: >> While testing some patches for support of ballooning in Mini-OS by using >> the xenstore domain I realized that each xl create/destroy pair would >> increase memory consumption in Mini-OS by about 5kB. Wondering wh

[Xen-devel] [xen-unstable-smoke test] 97261: regressions - FAIL

2016-07-13 Thread osstest service owner
flight 97261 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/97261/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 11 guest-start fail REGR. vs. 96794 test-amd64-amd

Re: [Xen-devel] [PATCH 1/2] Add a kexec_crash_loaded() function

2016-07-13 Thread Josh Triplett
On Wed, Jul 13, 2016 at 02:19:55PM +0200, Petr Tesarik wrote: > --- a/kernel/kexec_core.c > +++ b/kernel/kexec_core.c > @@ -95,6 +95,12 @@ int kexec_should_crash(struct task_struct *p) > return 0; > } > > +int kexec_crash_loaded(void) > +{ > + return !!kexec_crash_image; > +} Nit: thi

Re: [Xen-devel] [PATCH 2/2] Allow kdump with crash_kexec_post_notifiers

2016-07-13 Thread David Vrabel
On 13/07/16 13:20, Petr Tesarik wrote: > If a crash kernel is loaded, do not crash the running domain. This is > needed if the kernel is loaded with crash_kexec_post_notifiers, because > panic notifiers are run before __crash_kexec() in that case, and this > Xen hook prevents its being called later

Re: [Xen-devel] [xen-unstable-smoke test] 97261: regressions - FAIL

2016-07-13 Thread Ian Jackson
osstest service owner writes ("[xen-unstable-smoke test] 97261: regressions - FAIL"): > flight 97261 xen-unstable-smoke real [real] > http://logs.test-lab.xenproject.org/osstest/logs/97261/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be

[Xen-devel] [PATCH] XSM-Policy: allow source domain access to setpodtarget for ballooning.

2016-07-13 Thread Anshul Makkar
Access to setpodtarget is required by dom0 to set the balloon targets for domU. The patch gives source domain (dom0) access to set this target for domU and resolve the following permission denied error message during ballooning : avc: denied { setpodtarget } for domid=0 target=9 scontext=system_u

Re: [Xen-devel] [PATCH 1/2] Add a kexec_crash_loaded() function

2016-07-13 Thread Petr Tesarik
On Wed, 13 Jul 2016 05:52:33 -0700 Josh Triplett wrote: > On Wed, Jul 13, 2016 at 02:19:55PM +0200, Petr Tesarik wrote: > > --- a/kernel/kexec_core.c > > +++ b/kernel/kexec_core.c > > @@ -95,6 +95,12 @@ int kexec_should_crash(struct task_struct *p) > > return 0; > > } > > > > +int kexec_cr

[Xen-devel] [qemu-mainline test] 97264: trouble: pass/preparing/queued/running

2016-07-13 Thread osstest service owner
flight 97264 qemu-mainline running [real] http://logs.test-lab.xenproject.org/osstest/logs/97264/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt queued test-armhf-armhf-libv

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 02:21:38PM +0200, Juergen Gross wrote: > On 06/07/16 09:31, Juergen Gross wrote: > > While testing some patches for support of ballooning in Mini-OS by using > > the xenstore domain I realized that each xl create/destroy pair would > > increase memory consumption in Mini-OS

Re: [Xen-devel] [xen-unstable-smoke test] 97261: regressions - FAIL

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 01:55:26PM +0100, Ian Jackson wrote: > osstest service owner writes ("[xen-unstable-smoke test] 97261: regressions - > FAIL"): > > flight 97261 xen-unstable-smoke real [real] > > http://logs.test-lab.xenproject.org/osstest/logs/97261/ > > > > Regressions :-( > > > > Tests

[Xen-devel] [seabios test] 97265: trouble: pass/preparing

2016-07-13 Thread osstest service owner
flight 97265 seabios running [real] http://logs.test-lab.xenproject.org/osstest/logs/97265/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 2 hosts-allocate running t

Re: [Xen-devel] [PATCH v7 00/14] xen/arm: Use the typesafes gfn and mfn

2016-07-13 Thread Andrew Cooper
On 12/07/16 14:59, Julien Grall wrote: > Hello all, > > Some of the ARM functions are mixing gfn vs mfn and even physical vs frame. > > To avoid more confusion, this patch series makes use of the terminology > described in xen/include/xen/mm.h and the associated typesafe. > > I pushed a branch with

[Xen-devel] [ovmf test] 97263: trouble: pass/preparing

2016-07-13 Thread osstest service owner
flight 97263 ovmf running [real] http://logs.test-lab.xenproject.org/osstest/logs/97263/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-ovmf-amd64 2 hosts-allocate running test-a

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread David Vrabel
On 13/07/16 14:07, Wei Liu wrote: > > My gut feeling is that xenstored shouldn't have the knowledge to > associate a watch with a "process". The concept of a process is only > meaningful to OS, which wouldn't work on cross-domain xenstored setup. > Maybe the OS xenbus driver should reap all watche

Re: [Xen-devel] [PATCH 1/2] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Corneliu ZUZU
On 7/13/2016 3:12 PM, Andrew Cooper wrote: On 13/07/16 12:23, Corneliu ZUZU wrote: +typedef struct { int counter; } atomic_t; + +#define ATOMIC_INIT(i) { (i) } + +/** + * atomic_read - read atomic variable + * @v: pointer of type atomic_t + * + * Atomically reads the value of @v. + */ +static in

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] xenstored memory leak"): > On Wed, Jul 13, 2016 at 02:21:38PM +0200, Juergen Gross wrote: > > qemu as the device model is setting up a xenstore watch for each backend > > type it is supporting. Unfortunately those watches are never removed > > again. This sums up to

[Xen-devel] [PATCH] libxl: constify src parameter of libxl_nocpuid.c:libxl_cpuid_policy_list_copy

2016-07-13 Thread Wei Liu
In 11316d31 ("libxl: constify copy and length calculation functions") I forgot to take care of libxl_nocpuid.c which also contains an implementation of libxl_cpuid_policy_list_copy. That broke ARM build. Fix it by constifying the src parameter. Signed-off-by: Wei Liu --- Cc: Ian Jackson I've c

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Juergen Gross
On 13/07/16 14:40, Andrew Cooper wrote: > On 13/07/16 13:21, Juergen Gross wrote: >> On 06/07/16 09:31, Juergen Gross wrote: >>> While testing some patches for support of ballooning in Mini-OS by using >>> the xenstore domain I realized that each xl create/destroy pair would >>> increase memory con

Re: [Xen-devel] [PATCH 1/2] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Andrew Cooper
On 13/07/16 14:20, Corneliu ZUZU wrote: > On 7/13/2016 3:12 PM, Andrew Cooper wrote: >> On 13/07/16 12:23, Corneliu ZUZU wrote: >>> +typedef struct { int counter; } atomic_t; >>> + >>> +#define ATOMIC_INIT(i) { (i) } >>> + >>> +/** >>> + * atomic_read - read atomic variable >>> + * @v: pointer of t

Re: [Xen-devel] ACPI builder re-licensing

2016-07-13 Thread Lars Kurth
Boris, I can't remember how we managed this process the last time round (see for https://patchwork.kernel.org/patch/9172431/), but in that case we already had a patch. As far as I can see, we don't have the complete patch yet. Thus, the question I would have to you is whether you want to prepar

Re: [Xen-devel] [PATCH] libxl: constify src parameter of libxl_nocpuid.c:libxl_cpuid_policy_list_copy

2016-07-13 Thread Ian Jackson
Wei Liu writes ("[PATCH] libxl: constify src parameter of libxl_nocpuid.c:libxl_cpuid_policy_list_copy"): > In 11316d31 ("libxl: constify copy and length calculation functions") I > forgot to take care of libxl_nocpuid.c which also contains an > implementation of libxl_cpuid_policy_list_copy. That

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Juergen Gross
On 13/07/16 15:07, Wei Liu wrote: > On Wed, Jul 13, 2016 at 02:21:38PM +0200, Juergen Gross wrote: >> On 06/07/16 09:31, Juergen Gross wrote: >>> While testing some patches for support of ballooning in Mini-OS by using >>> the xenstore domain I realized that each xl create/destroy pair would >>> in

Re: [Xen-devel] [PATCH v2] vmx/monitor: CPUID events

2016-07-13 Thread Andrew Cooper
On 12/07/16 19:13, Tamas K Lengyel wrote: > This patch implements sending notification to a monitor subscriber when an > x86/vmx guest executes the CPUID instruction. > > Signed-off-by: Tamas K Lengyel > --- > Cc: Ian Jackson > Cc: Wei Liu > Cc: Razvan Cojocaru > Cc: Jan Beulich > Cc: Andrew C

Re: [Xen-devel] [PATCH] x86, hvm: document the de facto policy for vCPU ids

2016-07-13 Thread Andrew Cooper
On 12/07/16 17:28, Konrad Rzeszutek Wilk wrote: > On Tue, Jul 12, 2016 at 7:44 AM, Vitaly Kuznetsov wrote: >> PVHVM guests may need to know Xen's idea of vCPU ids they have and the >> only way they can figure them out is to use ACPI ids from MADT table. >> Document the de facto policy. >> >> Signe

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Ian Jackson
Juergen Gross writes ("Re: [Xen-devel] xenstored memory leak"): > On 13/07/16 14:40, Andrew Cooper wrote: > > On 13/07/16 13:21, Juergen Gross wrote: > >> I'll post a qemu patch to remove those watches on exit soon. I don't think this is right. qemu should not explictly remove watches when it is

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread David Vrabel
On 13/07/16 14:32, Juergen Gross wrote: > On 13/07/16 15:17, David Vrabel wrote: >> On 13/07/16 14:07, Wei Liu wrote: >>> >>> My gut feeling is that xenstored shouldn't have the knowledge to >>> associate a watch with a "process". The concept of a process is only >>> meaningful to OS, which wouldn'

Re: [Xen-devel] [PATCH 1/6] xen/build: Allow the use of C freestanding headers

2016-07-13 Thread Andrew Cooper
On 22/06/16 14:12, Tim Deegan wrote: > At 12:24 +0100 on 22 Jun (1466598248), Andrew Cooper wrote: >> The C standard defines two types of conforming implementation; hosted and >> freestanding. A subset of the standard headers are the freestanding headers, >> requiring no library support at all to

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 02:20:28PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] xenstored memory leak"): > > On Wed, Jul 13, 2016 at 02:21:38PM +0200, Juergen Gross wrote: > > > qemu as the device model is setting up a xenstore watch for each backend > > > type it is supporting. Unf

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Juergen Gross
On 13/07/16 15:17, David Vrabel wrote: > On 13/07/16 14:07, Wei Liu wrote: >> >> My gut feeling is that xenstored shouldn't have the knowledge to >> associate a watch with a "process". The concept of a process is only >> meaningful to OS, which wouldn't work on cross-domain xenstored setup. >> Mayb

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 03:25:45PM +0200, Juergen Gross wrote: > On 13/07/16 15:07, Wei Liu wrote: > > On Wed, Jul 13, 2016 at 02:21:38PM +0200, Juergen Gross wrote: > >> On 06/07/16 09:31, Juergen Gross wrote: > >>> While testing some patches for support of ballooning in Mini-OS by using > >>> the

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Juergen Gross
On 13/07/16 15:52, Wei Liu wrote: > On Wed, Jul 13, 2016 at 03:25:45PM +0200, Juergen Gross wrote: >> On 13/07/16 15:07, Wei Liu wrote: >>> On Wed, Jul 13, 2016 at 02:21:38PM +0200, Juergen Gross wrote: On 06/07/16 09:31, Juergen Gross wrote: > While testing some patches for support of bal

Re: [Xen-devel] [PATCH v2 0/7] Remove hard-coded /var/run in tools

2016-07-13 Thread Wei Liu
On Tue, Jul 12, 2016 at 04:21:00PM +, Rusty Bird wrote: > Hello Wei, > > For systemd/xendriverdomain.service.in, the hardcoded PID file could be > removed altogether -- systemd has no trouble figuring out the PID with > only one process. But I wasn't sure if maybe something outside of the > xe

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 04:09:26PM +0200, Juergen Gross wrote: > On 13/07/16 15:52, Wei Liu wrote: > > On Wed, Jul 13, 2016 at 03:25:45PM +0200, Juergen Gross wrote: > >> On 13/07/16 15:07, Wei Liu wrote: > >>> On Wed, Jul 13, 2016 at 02:21:38PM +0200, Juergen Gross wrote: > On 06/07/16 09:31,

[Xen-devel] [PATCH v2 0/5] adjustments

2016-07-13 Thread Corneliu ZUZU
Corneliu ZUZU (5): asm-arm/atomic.h: fix arm32|arm64 macros duplication asm-x86/atomic.h: minor: proper atomic_inc_and_test() placement asm-arm/atomic.h: reorder macros to match x86-side asm/atomic.h: common prototyping (add xen/atomic.h) fix: make atomic_read() param const xen/include/

[Xen-devel] [PATCH v2 1/5] asm-arm/atomic.h: fix arm32|arm64 macros duplication

2016-07-13 Thread Corneliu ZUZU
Move duplicate macros between asm-arm/arm32/atomic.h and asm-arm/arm64/atomic.h to asm-arm/atomic.h. Signed-off-by: Corneliu ZUZU --- xen/include/asm-arm/arm32/atomic.h | 11 --- xen/include/asm-arm/arm64/atomic.h | 11 --- xen/include/asm-arm/atomic.h | 11 +++ 3 f

[Xen-devel] [PATCH v2 2/5] asm-x86/atomic.h: minor: proper atomic_inc_and_test() placement

2016-07-13 Thread Corneliu ZUZU
Place atomic_inc_and_test() implementation after atomic_inc(). Also remove unneeded empty line and add a needed one. Signed-off-by: Corneliu ZUZU --- xen/include/asm-arm/atomic.h | 1 + xen/include/asm-x86/atomic.h | 39 +++ 2 files changed, 20 insertions(+),

[Xen-devel] [PATCH v2 3/5] asm-arm/atomic.h: reorder macros to match x86-side

2016-07-13 Thread Corneliu ZUZU
Reorder macro definitions to match x86-side. Signed-off-by: Corneliu ZUZU --- xen/include/asm-arm/atomic.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/xen/include/asm-arm/atomic.h b/xen/include/asm-arm/atomic.h index 19a87a5..e8f7340 100644 --- a/xen/

Re: [Xen-devel] ACPI builder re-licensing

2016-07-13 Thread Boris Ostrovsky
On 07/13/2016 09:21 AM, Lars Kurth wrote: > Boris, > > I can't remember how we managed this process the last time round (see for > https://patchwork.kernel.org/patch/9172431/), but in that case we already had > a patch. As far as I can see, we don't have the complete patch yet. > > Thus, the ques

[Xen-devel] [PATCH v2 5/5] fix: make atomic_read() param const

2016-07-13 Thread Corneliu ZUZU
This wouldn't let me make a param of a function that used atomic_read() const. Signed-off-by: Corneliu ZUZU Reviewed-by: Andrew Cooper --- Changed since v1: --- xen/include/asm-arm/atomic.h | 2 +- xen/include/asm-x86/atomic.h | 2 +- xen/include/xen/atomic.h | 2 +- 3 files changed, 3 in

[Xen-devel] [PATCH v2 4/5] asm/atomic.h: common prototyping (add xen/atomic.h)

2016-07-13 Thread Corneliu ZUZU
Create a common-side to establish, among others, prototypes of atomic functions called from common-code. Done to avoid introducing inconsistencies between arch-side headers when we make subtle changes to one of them. Some arm-side macros had to be turned into inline functions in the process. Rem

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Ian Jackson
David Vrabel writes ("Re: [Xen-devel] xenstored memory leak"): > On 13/07/16 14:32, Juergen Gross wrote: > > On 13/07/16 15:17, David Vrabel wrote: > >> The Linux driver already cleans up open transactions and removes watches > >> when the file handle is released. > > > > Hmm, does this work relia

Re: [Xen-devel] ACPI builder re-licensing

2016-07-13 Thread Lars Kurth
On 13/07/2016 15:22, "Boris Ostrovsky" wrote: >On 07/13/2016 09:21 AM, Lars Kurth wrote: >> Boris, >> >> I can't remember how we managed this process the last time round (see >>for https://patchwork.kernel.org/patch/9172431/), but in that case we >>already had a patch. As far as I can see, we d

[Xen-devel] [xen-unstable-smoke test] 97269: regressions - FAIL

2016-07-13 Thread osstest service owner
flight 97269 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/97269/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 5 xen-build fail REGR. vs. 96794 Tests which di

Re: [Xen-devel] xenstored memory leak

2016-07-13 Thread Juergen Gross
On 13/07/16 16:28, Ian Jackson wrote: > David Vrabel writes ("Re: [Xen-devel] xenstored memory leak"): >> On 13/07/16 14:32, Juergen Gross wrote: >>> On 13/07/16 15:17, David Vrabel wrote: The Linux driver already cleans up open transactions and removes watches when the file handle is rel

Re: [Xen-devel] [PATCH] xl: add option to leave domain paused afer migration

2016-07-13 Thread Wei Liu
On Wed, Jul 13, 2016 at 10:53:13AM +0200, Roger Pau Monne wrote: > This is useful for debugging domains that crash on resume from migration. > > Signed-off-by: Roger Pau Monné This sounds like a useful thing to have and the patch looks good. But you forgot to patch xl(1) manpage. Wei. ___

Re: [Xen-devel] [PATCH 1/6] xen/build: Allow the use of C freestanding headers

2016-07-13 Thread Tim Deegan
At 14:46 +0100 on 13 Jul (1468421211), Andrew Cooper wrote: > On 22/06/16 14:12, Tim Deegan wrote: > > At 12:24 +0100 on 22 Jun (1466598248), Andrew Cooper wrote: > >> The C standard defines two types of conforming implementation; hosted and > >> freestanding. A subset of the standard headers are

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-13 Thread Julien Grall
Hello, On 12/07/2016 17:58, Boris Ostrovsky wrote: On 07/12/2016 12:10 PM, Julien Grall wrote: On 12/07/2016 16:08, Boris Ostrovsky wrote: On 07/12/2016 10:57 AM, Shannon Zhao wrote: On 2016年07月12日 22:50, Wei Liu wrote: On Tue, Jul 12, 2016 at 10:42:07PM +0800, Shannon Zhao wrote: Does it m

Re: [Xen-devel] No graphics with xen pv and Fedora qemu

2016-07-13 Thread Andrew Cooper
On 10/07/16 16:44, Michael Young wrote: > On Wed, 29 Jun 2016, Michael Young wrote: > >> I have been trying to trace a problem when using Fedora's qemu with a >> pv guest which is that no graphics are available. I get the errors >> >> xen be core: xen be: watching backend path (backend/console/2) f

[Xen-devel] [DRAFT v2] XenSock protocol design document

2016-07-13 Thread Stefano Stabellini
Hi all, This is the design document of the XenSock protocol. You can find prototypes of the Linux frontend and backend drivers here: git://git.kernel.org/pub/scm/linux/kernel/git/sstabellini/xen.git xensock-2 To use them, make sure to enable CONFIG_XENSOCK in your kernel config and add "xensock=

Re: [Xen-devel] [DRAFT v2] XenSock protocol design document

2016-07-13 Thread Andrew Cooper
On 13/07/16 16:47, Stefano Stabellini wrote: > Hi all, > > This is the design document of the XenSock protocol. You can find > prototypes of the Linux frontend and backend drivers here: > > git://git.kernel.org/pub/scm/linux/kernel/git/sstabellini/xen.git xensock-2 > > To use them, make sure to ena

[Xen-devel] [xen-unstable-smoke test] 97274: tolerable all pass - PUSHED

2016-07-13 Thread osstest service owner
flight 97274 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/97274/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 12 migrate-support-checkfail never pass test-armhf-armhf-xl 12

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-13 Thread Boris Ostrovsky
On 07/13/2016 11:22 AM, Julien Grall wrote: > Hello, > > On 12/07/2016 17:58, Boris Ostrovsky wrote: >> On 07/12/2016 12:10 PM, Julien Grall wrote: >>> On 12/07/2016 16:08, Boris Ostrovsky wrote: On 07/12/2016 10:57 AM, Shannon Zhao wrote: > On 2016年07月12日 22:50, Wei Liu wrote: >> On T

[Xen-devel] [patch V2 49/67] arm/xen: Convert to hotplug state machine

2016-07-13 Thread Anna-Maria Gleixner
From: Richard Cochran Install the callbacks via the state machine and let the core invoke the callbacks on the already online CPUs. The get_cpu() in xen_starting_cpu() boils down to preempt_disable() since we already know the CPU we run on. Disabling preemption shouldn't be required here from wh

Re: [Xen-devel] [DRAFT v2] XenSock protocol design document

2016-07-13 Thread Stefano Stabellini
On Wed, 13 Jul 2016, Andrew Cooper wrote: > On 13/07/16 16:47, Stefano Stabellini wrote: > > Hi all, > > > > This is the design document of the XenSock protocol. You can find > > prototypes of the Linux frontend and backend drivers here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/sstabel

Re: [Xen-devel] [PATCH] XSM-Policy: allow source domain access to setpodtarget for ballooning.

2016-07-13 Thread Daniel De Graaf
On 07/13/2016 08:59 AM, Anshul Makkar wrote: Access to setpodtarget is required by dom0 to set the balloon targets for domU. The patch gives source domain (dom0) access to set this target for domU and resolve the following permission denied error message during ballooning : avc: denied { setpod

Re: [Xen-devel] [PATCH v7 07/14] xen/arm: map_regions_rw_cache: Map the region with p2m->default_access

2016-07-13 Thread Stefano Stabellini
On Tue, 12 Jul 2016, Julien Grall wrote: > The parameter 'access' is used by memaccess to restrict temporarily the > permission. This parameter should not be used for other purpose (such > as restricting permanently the permission). > > Instead, we should use the default access requested by memace

Re: [Xen-devel] [PATCH v7 10/14] xen/arm: Use the typesafes mfn and gfn in map_dev_mmio_region...

2016-07-13 Thread Stefano Stabellini
On Tue, 12 Jul 2016, Julien Grall wrote: > to avoid mixing machine frame with guest frame. Also drop the prefix start_. > > Signed-off-by: Julien Grall Acked-by: Stefano Stabellini > --- > Changes in v6: > - Qualify what is being mapped > - Use PRI_mfn > > Changes in

Re: [Xen-devel] [PATCH v7 14/14] xen/arm: p2m: Rework the interface of apply_p2m_changes and use typesafe

2016-07-13 Thread Stefano Stabellini
On Tue, 12 Jul 2016, Julien Grall wrote: > Most of the callers of apply_p2m_changes have a GFN, a MFN and the > number of frame to change in hand. > > Rather than asking each caller to convert the frame to an address, > rework the interfaces to pass the GFN, MFN and the number of frame. > > Note

  1   2   >