[Xen-devel] [distros-debian-snapshot test] 66558: tolerable trouble: blocked/broken

2016-07-12 Thread Platform Team regression test user
flight 66558 distros-debian-snapshot real [real] http://osstest.xs.citrite.net/~osstest/testlogs/logs/66558/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): build-armhf-pvops 3 host-install(3) broken like 66519 build-armhf

Re: [Xen-devel] [PATCH v3 04/17] libxl/arm: prepare for constructing ACPI tables

2016-07-12 Thread Shannon Zhao
On 2016/7/7 23:50, Wei Liu wrote: > On Tue, Jul 05, 2016 at 11:12:34AM +0800, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > It only constructs the ACPI tables for 64-bit ARM DomU when user enables >> > acpi because 32-bit DomU doesn't support ACPI. >> > >> > Signed-off-by: Shannon Zhao

Re: [Xen-devel] [PATCH v6] x86/mem-sharing: mem-sharing a range of memory

2016-07-12 Thread Wei Liu
On Mon, Jul 11, 2016 at 01:57:50PM -0600, Tamas K Lengyel wrote: > Currently mem-sharing can be performed on a page-by-page basis from the > control > domain. However, this process is quite wasteful when a range of pages have to > be deduplicated. > > This patch introduces a new mem_sharing memop

[Xen-devel] [PATCH v4] xen/arm: Add a clock property

2016-07-12 Thread Dirk Behme
Clocks described by this property are reserved for use by Xen, and the OS must not alter their state any way, such as disabling or gating a clock, or modifying its rate. Ensuring this may impose constraints on parent clocks or other resources used by the clock tree. This property is used to proxy

Re: [Xen-devel] [PATCH 00/16] x86/vm-event: numerous adjustments & fixes

2016-07-12 Thread Tian, Kevin
Thanks for explanation. It makes sense then. From: Corneliu ZUZU [mailto:cz...@bitdefender.com] Sent: Monday, July 11, 2016 1:32 PM To: Tian, Kevin; xen-devel@lists.xen.org Cc: Andrew Cooper; George Dunlap; Jan Beulich; Julien Grall; Nakajima, Jun; Paul Durrant; Razvan Cojocaru; Stefano Stabellin

Re: [Xen-devel] [PATCH 05/16] x86/monitor: relocate code more appropriately

2016-07-12 Thread Tian, Kevin
> From: Corneliu ZUZU [mailto:cz...@bitdefender.com] > Sent: Monday, July 11, 2016 2:19 PM > > > > +static inline > > +void monitor_ctrlreg_adjust_traps(struct domain *d, unsigned int index) > > +{ > > +/* For now, VMX only. */ > > +ASSERT(cpu_has_vmx); > > + > > +/* Other CRs than CR3

Re: [Xen-devel] [Minios-devel] [PATCH] mini-os: make cscope repair

2016-07-12 Thread Wei Liu
On Fri, Jul 01, 2016 at 11:33:11AM +0200, Juergen Gross wrote: > "make cscope" doesn't like symbolic link include/mini-os->. as it > leads to a file system recursion. Repair that by not following links > when searching the sources. > > Signed-off-by: Juergen Gross Queued. Juergen, please CC me

Re: [Xen-devel] [Minios-devel] [PATCH] mini-os: replace lib/printf.c with a version not under GPL

2016-07-12 Thread Wei Liu
On Mon, Jul 04, 2016 at 09:26:20PM +0200, Samuel Thibault wrote: > Hello, > > Juergen Gross, on Mon 04 Jul 2016 07:29:46 +0200, wrote: > > > Did you check the boot output e.g. of a trivial mini-os application? > > > Notably, iirc there were perhaps odd formating with %x, %p or such. > > > Moving t

Re: [Xen-devel] [PATCH v2] xen_pvscsi: reclaim the ring request when the prepairing failed

2016-07-12 Thread Juergen Gross
On 12/07/16 02:36, Bin Wu wrote: > During scsi command queueing or exception handling, if prepairing > fails, we need to reclaim the failed request. Otherwise, the garbage > request will be pushed into the ring for the backend to work. > > Signed-off-by: Bin Wu Reviewed-by: Juergen Gross > ---

Re: [Xen-devel] [Minios-devel] [PATCH] mini-os: make cscope repair

2016-07-12 Thread Juergen Gross
On 12/07/16 09:59, Wei Liu wrote: > On Fri, Jul 01, 2016 at 11:33:11AM +0200, Juergen Gross wrote: >> "make cscope" doesn't like symbolic link include/mini-os->. as it >> leads to a file system recursion. Repair that by not following links >> when searching the sources. >> >> Signed-off-by: Juergen

Re: [Xen-devel] [PATCH 05/16] x86/monitor: relocate code more appropriately

2016-07-12 Thread Corneliu ZUZU
On 7/12/2016 10:45 AM, Tian, Kevin wrote: From: Corneliu ZUZU [mailto:cz...@bitdefender.com] Sent: Monday, July 11, 2016 2:19 PM +static inline +void monitor_ctrlreg_adjust_traps(struct domain *d, unsigned int index) +{ +/* For now, VMX only. */ +ASSERT(cpu_has_vmx); + +/* Other CRs

Re: [Xen-devel] [PATCH v2] mini-os: replace lib/printf.c with a version not under GPL

2016-07-12 Thread Samuel Thibault
Juergen Gross, on Mon 04 Jul 2016 11:16:59 +0200, wrote: > Instead of a Linux kernel based implementation use one from freeBSD. > > As a result some of the printings will change due to more posix like > behavior of %p format (omitting leading zeroes, prepending "0x"). > > Signed-off-by: Juergen G

[Xen-devel] [PATCH v5 2/4] x86/ioreq server: Add new functions to get/set memory types.

2016-07-12 Thread Yu Zhang
For clarity this patch breaks the code to set/get memory types out of do_hvm_op() into dedicated functions: hvmop_set/get_mem_type(). Also, for clarity, checks for whether a memory type change is allowed are broken out into a separate function called by hvmop_set_mem_type(). There is no intentiona

[Xen-devel] [PATCH v5 3/4] x86/ioreq server: Add HVMOP to map guest ram with p2m_ioreq_server to an ioreq server.

2016-07-12 Thread Yu Zhang
A new HVMOP - HVMOP_map_mem_type_to_ioreq_server, is added to let one ioreq server claim/disclaim its responsibility for the handling of guest pages with p2m type p2m_ioreq_server. Users of this HVMOP can specify which kind of operation is supposed to be emulated in a parameter named flags. Current

[Xen-devel] [PATCH v5 0/4] x86/ioreq server: Introduce HVMMEM_ioreq_server mem type.

2016-07-12 Thread Yu Zhang
XenGT leverages ioreq server to track and forward the accesses to GPU I/O resources, e.g. the PPGTT(per-process graphic translation tables). Currently, ioreq server uses rangeset to track the BDF/ PIO/MMIO ranges to be emulated. To select an ioreq server, the rangeset is searched to see if the I/O

[Xen-devel] [PATCH v5 1/4] x86/ioreq server: Rename p2m_mmio_write_dm to p2m_ioreq_server.

2016-07-12 Thread Yu Zhang
Previously p2m type p2m_mmio_write_dm was introduced for write- protected memory pages whose write operations are supposed to be forwarded to and emulated by an ioreq server. Yet limitations of rangeset restrict the number of guest pages to be write-protected. This patch replaces the p2m type p2m_

[Xen-devel] [PATCH v5 4/4] x86/ioreq server: Reset outstanding p2m_ioreq_server entries when an ioreq server unmaps.

2016-07-12 Thread Yu Zhang
This patch resets p2m_ioreq_server entries back to p2m_ram_rw, after an ioreq server has unmapped. The resync is done both asynchronously with the current p2m_change_entry_type_global() interface, and synchronously by iterating the p2m table. The synchronous resetting is necessary because we need t

Re: [Xen-devel] [Minios-devel] [PATCH v2] mini-os: replace lib/printf.c with a version not under GPL

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 10:48:50AM +0200, Samuel Thibault wrote: > Juergen Gross, on Mon 04 Jul 2016 11:16:59 +0200, wrote: > > Instead of a Linux kernel based implementation use one from freeBSD. > > > > As a result some of the printings will change due to more posix like > > behavior of %p forma

Re: [Xen-devel] [PATCH v3] xen/arm: enable clocks used by the hypervisor

2016-07-12 Thread Julien Grall
Hi Mike, On 08/07/16 18:06, Michael Turquette wrote: Quoting Julien Grall (2016-07-08 02:34:43) Hi Dirk, On 08/07/16 08:44, Dirk Behme wrote: Xen hypervisor drivers might replace native OS drivers. The result is that some important clocks that are enabled by the OS in the non-Xen case are not

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-12 Thread Julien Grall
Hi Shannon, On 12/07/16 04:40, Shannon Zhao wrote: On 2016/7/7 23:30, Wei Liu wrote: On Mon, Jun 27, 2016 at 11:40:32AM +0100, Julien Grall wrote: On 23/06/16 15:34, Shannon Zhao wrote: On 2016年06月23日 21:39, Stefano Stabellini wrote: On Thu, 23 Jun 2016, Shannon Zhao wrote: From: Shannon

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Julien Grall
Hi Shannon, On 12/07/16 04:47, Shannon Zhao wrote: On 2016/7/6 18:12, Stefano Stabellini wrote: On Wed, 6 Jul 2016, Julien Grall wrote: On 05/07/16 18:13, Stefano Stabellini wrote: On Thu, 23 Jun 2016, Julien Grall wrote: On 23/06/2016 04:17, Shannon Zhao wrote: From: Shannon Zhao +static

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-12 Thread Andrew Cooper
On 12/07/16 06:11, Corneliu ZUZU wrote: > Hi Andrew, > > On 7/11/2016 6:18 PM, Andrew Cooper wrote: >> On 09/07/16 05:12, Corneliu ZUZU wrote: >>> This wouldn't let me make a param of a function that used >>> atomic_read() const. >>> >>> Signed-off-by: Corneliu ZUZU >> This is a good improvement,

Re: [Xen-devel] [Minios-devel] [PATCH v2] mini-os: replace lib/printf.c with a version not under GPL

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 10:19:41AM +0100, Wei Liu wrote: > On Tue, Jul 12, 2016 at 10:48:50AM +0200, Samuel Thibault wrote: > > Juergen Gross, on Mon 04 Jul 2016 11:16:59 +0200, wrote: > > > Instead of a Linux kernel based implementation use one from freeBSD. Roger has asked me on IRC to s/freeBSD

Re: [Xen-devel] Data Abort while in booting when using latest version on arm32 fastmodels

2016-07-12 Thread Julien Grall
On 12/07/16 06:20, Wonseok Ko wrote: Hi, All Hello, I founded the previous post to solve the problem as the same as mine, the patch was applied in latest version, but I've got the data abort. previous post: https://lists.xen.org/archives/html/xen-devel/2013-09/msg00606.html and I referred

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-12 Thread Corneliu ZUZU
On 7/12/2016 12:42 PM, Andrew Cooper wrote: On 12/07/16 06:11, Corneliu ZUZU wrote: Hi Andrew, On 7/11/2016 6:18 PM, Andrew Cooper wrote: On 09/07/16 05:12, Corneliu ZUZU wrote: This wouldn't let me make a param of a function that used atomic_read() const. Signed-off-by: Corneliu ZUZU This

Re: [Xen-devel] [PATCH v5 4/4] arm64: update the introduction of xen boot commands in docs/grub.texi

2016-07-12 Thread Julien Grall
Hi Fu Wei, On 06/07/16 18:53, fu@linaro.org wrote: From: Fu Wei delete: xen_linux, xen_initrd, xen_xsm add: xen_module This update bases on commit 0edd750e50698854068358ea53528100a9192902 Author: Vladimir Serbinenko Date: Fri Jan 22 10:18:47 2016 +0100 xen_boot

Re: [Xen-devel] [PATCH v5 3/4] * util/grub.d/20_linux_xen.in: Add xen_boot command support

2016-07-12 Thread Julien Grall
Hi Fu Wei, On 06/07/16 18:53, fu@linaro.org wrote: From: Fu Wei This patch adds the support of xen_boot command: xen_hypervisor xen_module Also add a new "feature_xen_boot" to indicate this grub support xen_boot command. Signed-off-by: Fu Wei --- grub-core/normal/main.c

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-12 Thread Andrew Cooper
On 12/07/16 11:11, Corneliu ZUZU wrote: > >> If you are really feeling up to it, having a common xen/atomic.h with typedef struct { int counter; } atomic_t; #define ATOMIC_INIT(i) { (i) } and some prototypes such as: static inline int atomic_read(const atomic

Re: [Xen-devel] [PATCH 0/4] boot-wrapper: arm64: Xen support

2016-07-12 Thread Julien Grall
Hi Andre, On 20/06/16 16:09, Andre Przywara wrote: These patches allow to include a Xen hypervisor binary into a boot-wrapper ELF file, so that a Foundation Platform or a Fast Model can boot a Xen system (including a Dom0 kernel). This has been floating around for a while, I just updated the pat

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-12 Thread Corneliu ZUZU
On 7/12/2016 1:22 PM, Andrew Cooper wrote: On 12/07/16 11:11, Corneliu ZUZU wrote: If you are really feeling up to it, having a common xen/atomic.h with typedef struct { int counter; } atomic_t; #define ATOMIC_INIT(i) { (i) } and some prototypes such as: static inline int atomic_read(const at

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-12 Thread Corneliu ZUZU
On 7/12/2016 1:22 PM, Andrew Cooper wrote: On 12/07/16 11:11, Corneliu ZUZU wrote: If you are really feeling up to it, having a common xen/atomic.h with typedef struct { int counter; } atomic_t; #define ATOMIC_INIT(i) { (i) } and some prototypes such as: static inline int atomic_read(const at

Re: [Xen-devel] [PATCH 1/4] Support for building in a Xen binary

2016-07-12 Thread Julien Grall
Hi Andre, On 20/06/16 16:09, Andre Przywara wrote: diff --git a/Makefile.am b/Makefile.am index 692d2cc..1a801c0 100644 --- a/Makefile.am +++ b/Makefile.am @@ -85,7 +85,6 @@ TEXT_LIMIT:= 0x8008 endif LD_SCRIPT := model.lds.S -IMAGE := linux-system.axf FS_OFFSET :

Re: [Xen-devel] [PATCH 2/4] Xen: Support adding DT nodes

2016-07-12 Thread Julien Grall
Hi Andre, On 20/06/16 16:09, Andre Przywara wrote: From: Christoffer Dall Support adding xen,xen-bootargs node via --with-xen-bootargs to the configure script and automatically add the Dom0 node to the DT as well. Signed-off-by: Christoffer Dall Signed-off-by: Andre Przywara --- Makefile.

Re: [Xen-devel] [PATCH 3/4] Xen: Select correct dom0 console

2016-07-12 Thread Julien Grall
Hi Andrew, On 20/06/16 16:09, Andre Przywara wrote: From: Ian Campbell If Xen is enabled, tell Dom0 to use the 'hvc0' console, and fall back to the usual ttyAMA0 otherwise. Signed-off-by: Ian Campbell Signed-off-by: Christoffer Dall Signed-off-by: Andre Przywara Reviewed-by: Julien Grall

Re: [Xen-devel] [PATCH 4/4] Explicitly clean linux-system.axf and xen-system.axf

2016-07-12 Thread Julien Grall
Hi Andre, On 20/06/16 16:09, Andre Przywara wrote: From: Christoffer Dall When doing a make clean, only the output image currently configured to build is being removed. However, one would expect all build artifacts to be removed when doing a 'make clean' and when switching between Xen and Lin

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: [...] > >>Yeah, we can deprecate that field. But we need to take care to not break > >>users of the old field. > >Ok, what name would you suggest? > > I would suggest b_info->u.acpi > b_info->acpi would be more appropriate. diff --gi

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 11:47:04AM +0800, Shannon Zhao wrote: > > > On 2016/7/6 18:12, Stefano Stabellini wrote: > > On Wed, 6 Jul 2016, Julien Grall wrote: > >> > Hi Stefano, > >> > > >> > On 05/07/16 18:13, Stefano Stabellini wrote: > >>> > > On Thu, 23 Jun 2016, Julien Grall wrote: > > >

Re: [Xen-devel] [PATCH v3 05/17] libxl/arm: Generate static ACPI DSDT table

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 11:50:32AM +0800, Shannon Zhao wrote: > > > On 2016/7/7 23:52, Wei Liu wrote: > > On Tue, Jul 05, 2016 at 11:12:35AM +0800, Shannon Zhao wrote: > >> > From: Shannon Zhao > >> > > >> > It uses static DSDT table like the way x86 uses. Currently the DSDT > >> > table only c

[Xen-devel] [PATCH] x86, hvm: document the de facto policy for vCPU ids

2016-07-12 Thread Vitaly Kuznetsov
PVHVM guests may need to know Xen's idea of vCPU ids they have and the only way they can figure them out is to use ACPI ids from MADT table. Document the de facto policy. Signed-off-by: Vitaly Kuznetsov --- xen/include/public/hvm/hvm_info_table.h | 8 1 file changed, 8 insertions(+) di

Re: [Xen-devel] Data Abort while in booting when using latest version on arm32 fastmodels

2016-07-12 Thread Wonseok Ko
Thank you for your help, Julien I found the memory overlapping problem between Kernel and Device Tree in bootwrapper. The problem came from INITRD_OFFSET and PHYS_OFFSET macro(0x00d0) I fixed these offsets from 0x00d0 to 0x00e0 and then I avoided the memory overlapping problem: (XEN)

Re: [Xen-devel] linux-next: manual merge of the xen-tip tree with the pm tree

2016-07-12 Thread Rafael J. Wysocki
On Tuesday, July 12, 2016 02:09:26 PM Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the xen-tip tree got a conflict in: > > drivers/acpi/scan.c > > between commit: > > 68bdb6773289 ("ACPI: add support for ACPI reconfiguration notifiers") > > from the pm tree and commit:

Re: [Xen-devel] [PATCH v5 00/44] dma-mapping: Use unsigned long for dma_attrs

2016-07-12 Thread Daniel Vetter
On Thu, Jun 30, 2016 at 10:23:39AM +0200, Krzysztof Kozlowski wrote: > Hi, > > > This is fifth approach for replacing struct dma_attrs with unsigned > long. > > The main patch (1/44) doing the change is split into many subpatches > for easier review (2-42). They should be squashed together when

Re: [Xen-devel] [PATCH v5 00/44] dma-mapping: Use unsigned long for dma_attrs

2016-07-12 Thread Krzysztof Kozlowski
On 07/12/2016 02:16 PM, Daniel Vetter wrote: > On Thu, Jun 30, 2016 at 10:23:39AM +0200, Krzysztof Kozlowski wrote: >> Hi, >> >> >> This is fifth approach for replacing struct dma_attrs with unsigned >> long. >> >> The main patch (1/44) doing the change is split into many subpatches >> for easier r

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-12 Thread Andrew Cooper
On 12/07/16 11:38, Corneliu ZUZU wrote: > On 7/12/2016 1:22 PM, Andrew Cooper wrote: >> On 12/07/16 11:11, Corneliu ZUZU wrote: >> If you are really feeling up to it, having a common xen/atomic.h >> with >> >> typedef struct { int counter; } atomic_t; >> #define ATOMIC_INIT(i) {

Re: [Xen-devel] [PATCH v2 0/4] libxl: add framework for device types

2016-07-12 Thread Wei Liu
On Fri, Jul 08, 2016 at 06:54:54PM +0100, Ian Jackson wrote: > Juergen Gross writes ("[PATCH v2 0/4] libxl: add framework for device types"): > > Instead of duplicate coding for each device type (vtpms, usbctrls, ...) > > especially on domain creation introduce a framework for that purpose. > > >

Re: [Xen-devel] [PATCH 18/19] xen: credit2: implement SMT support independent runq arrangement

2016-07-12 Thread George Dunlap
On Sat, Jun 18, 2016 at 12:13 AM, Dario Faggioli wrote: > In fact, right now, we recommend keepeing runqueues > arranged per-core, so that it is the inter-runqueue load > balancing code that automatically spreads the work in an > SMT friendly way. This means that any other runq > arrangement one m

Re: [Xen-devel] [PATCH v4 0/5] libxl: update available vcpus map in retrieved configuration

2016-07-12 Thread Wei Liu
On Mon, Jul 11, 2016 at 04:49:32PM +0100, Wei Liu wrote: > See individual patch for detailed changelog. Series pushed. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH 02/16] x86: fix: make atomic_read() param const

2016-07-12 Thread Corneliu ZUZU
On 7/12/2016 3:49 PM, Andrew Cooper wrote: On 12/07/16 11:38, Corneliu ZUZU wrote: On 7/12/2016 1:22 PM, Andrew Cooper wrote: On 12/07/16 11:11, Corneliu ZUZU wrote: If you are really feeling up to it, having a common xen/atomic.h with typedef struct { int counter; } atomic_t; #define ATOMIC_

[Xen-devel] [PATCH v7 10/14] xen/arm: Use the typesafes mfn and gfn in map_dev_mmio_region...

2016-07-12 Thread Julien Grall
to avoid mixing machine frame with guest frame. Also drop the prefix start_. Signed-off-by: Julien Grall --- Changes in v6: - Qualify what is being mapped - Use PRI_mfn Changes in v4: - Patch added --- xen/arch/arm/mm.c | 2 +- xen/arch/arm/p2m.c

[Xen-devel] [PATCH v7 08/14] xen/arm: dom0_build: Remove dead code in allocate_memory

2016-07-12 Thread Julien Grall
The code to allocate memory when dom0 does not use direct mapping is relying on the presence of memory node in the DT. However, they are not present when booting using UEFI or when using ACPI. Rather than fixing the code, remove it because dom0 is always direct memory mapped and therefore the cod

[Xen-devel] [PATCH v7 03/14] xen: Use a typesafe to define INVALID_MFN

2016-07-12 Thread Julien Grall
Also take the opportunity to convert arch/x86/debug.c to the typesafe mfn and use proper printf format for MFN/GFN when the code around is modified. Signed-off-by: Julien Grall Reviewed-by: Andrew Cooper Acked-by: Stefano Stabellini --- Cc: Christoph Egger Cc: Liu Jinsong Cc: Jan Beulich Cc

[Xen-devel] [PATCH v7 07/14] xen/arm: map_regions_rw_cache: Map the region with p2m->default_access

2016-07-12 Thread Julien Grall
The parameter 'access' is used by memaccess to restrict temporarily the permission. This parameter should not be used for other purpose (such as restricting permanently the permission). Instead, we should use the default access requested by memacess. When it is not enabled, the access will be p2m_

[Xen-devel] [PATCH v7 01/14] xen: Use the typesafe mfn and gfn in map_mmio_regions...

2016-07-12 Thread Julien Grall
to avoid mixing machine frame with guest frame. Signed-off-by: Julien Grall Acked-by: Jan Beulich Acked-by: Stefano Stabellini --- Cc: Stefano Stabellini Cc: Jan Beulich Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Konrad Rzeszutek Wilk Cc: Tim Deegan Cc: Wei Liu Change

[Xen-devel] [PATCH v7 06/14] xen/arm: Rework the interface of p2m_cache_flush and use typesafe gfn

2016-07-12 Thread Julien Grall
p2m_cache_flush is expecting GFNs in parameter and not MFNs. Rename the variable to *gfn* and use typesafe to avoid possible misusage. Also, modify the prototype of the function to describe the range using the start and the number of GFNs. This will avoid to wonder whether the end if inclusive or

[Xen-devel] [PATCH v7 00/14] xen/arm: Use the typesafes gfn and mfn

2016-07-12 Thread Julien Grall
Hello all, Some of the ARM functions are mixing gfn vs mfn and even physical vs frame. To avoid more confusion, this patch series makes use of the terminology described in xen/include/xen/mm.h and the associated typesafe. I pushed a branch with this series applied on top of staging: git://xenbit

[Xen-devel] [PATCH v7 09/14] xen/arm: p2m: Remove unused operation ALLOCATE

2016-07-12 Thread Julien Grall
The operation ALLOCATE is unused. If we ever need it, it could be reimplemented with INSERT. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v6: - Add Stefano's acked-by Changes in v4: - Patch added --- xen/arch/arm/p2m.c| 67 ++-

[Xen-devel] [PATCH v7 11/14] xen/arm: Use the typesafes mfn and gfn in map_regions_rw_cache ...

2016-07-12 Thread Julien Grall
to avoid mixing machine frame with guest frame. Also rename the parameters of the function and drop pointless PAGE_MASK in the caller. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v6: - Add Stefano's acked-by Changes in v4: - Patch added ---

[Xen-devel] [PATCH v7 12/14] xen/arm: p2m: Introduce helpers to insert and remove mapping

2016-07-12 Thread Julien Grall
More the half of the arguments of INSERT and REMOVE are the same for each callers. Simplify the callers of apply_p2m_changes by adding new helpers which will fill common arguments with default values. Signed-off-by: Julien Grall --- Changes in v7: - MATTR_DEV should be used in map_mm

[Xen-devel] [PATCH v7 13/14] xen/arm: p2m: Use typesafe gfn for {max, lowest}_mapped_gfn

2016-07-12 Thread Julien Grall
Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v6: - Add Stefano's acked-by Changes in v4: - Patch added --- xen/arch/arm/mm.c | 2 +- xen/arch/arm/p2m.c| 18 +- xen/include/asm-arm/p2m.h | 4 ++-- 3 files chang

[Xen-devel] [PATCH v7 05/14] xen/arm: Rework the interface of p2m_lookup and use typesafe gfn and mfn

2016-07-12 Thread Julien Grall
The prototype and the declaration of p2m_lookup disagree on how the function should be used. One expect a frame number whilst the other an address. Thankfully, everyone is using with an address today. However, most of the callers have to convert a guest frame to an address. Modify the interface to

[Xen-devel] [PATCH v7 14/14] xen/arm: p2m: Rework the interface of apply_p2m_changes and use typesafe

2016-07-12 Thread Julien Grall
Most of the callers of apply_p2m_changes have a GFN, a MFN and the number of frame to change in hand. Rather than asking each caller to convert the frame to an address, rework the interfaces to pass the GFN, MFN and the number of frame. Note that it would be possible to do more clean-up in apply_

[Xen-devel] [PATCH v7 02/14] xen/passthrough: x86: Use INVALID_GFN rather than INVALID_MFN

2016-07-12 Thread Julien Grall
A variable containing a guest frame should be compared to INVALID_GFN and not INVALID_MFN. Signed-off-by: Julien Grall Reviewed-by: Jan Beulich Reviewed-by: Andrew Cooper --- Cc: Suravee Suthikulpanit Changes in v6: - Fix typo in the commit message - Add Andrew's and Jan'

[Xen-devel] [PATCH v7 04/14] xen: Use a typesafe to define INVALID_GFN

2016-07-12 Thread Julien Grall
Also take the opportunity to convert arch/x86/debug.c to the typesafe gfn. Signed-off-by: Julien Grall Reviewed-by: Andrew Cooper Acked-by: Stefano Stabellini Acked-by: Elena Ufimtseva --- Cc: Jan Beulich Cc: Paul Durrant Cc: Boris Ostrovsky Cc: Suravee Suthikulpanit Cc: Jun Nakajima Cc:

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-12 Thread Shannon Zhao
On 2016年07月12日 19:33, Wei Liu wrote: > On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: > [...] > >>Yeah, we can deprecate that field. But we need to take care to not > >>break > >>users of the old field. >>> > >Ok, what name would you suggest? >> > >> > I would sugges

Re: [Xen-devel] [PATCH v1 20/20] libxl/acpi: Build ACPI tables for HVMlite guests

2016-07-12 Thread Wei Liu
On Mon, Jul 11, 2016 at 10:40:17AM -0400, Boris Ostrovsky wrote: > On 07/11/2016 09:41 AM, Wei Liu wrote: > > On Mon, Jul 11, 2016 at 09:33:21AM -0400, Boris Ostrovsky wrote: > >> On 07/11/2016 06:47 AM, Wei Liu wrote: > >>> On Fri, Jul 08, 2016 at 01:20:46PM -0400, Boris Ostrovsky wrote: > On

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 10:17:20PM +0800, Shannon Zhao wrote: > On 2016年07月12日 19:33, Wei Liu wrote: > > On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: > > [...] > > >>Yeah, we can deprecate that field. But we need to take care to not > > >>break > > >>users of the ol

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Shannon Zhao
On 2016年07月12日 19:35, Wei Liu wrote: > On Tue, Jul 12, 2016 at 11:47:04AM +0800, Shannon Zhao wrote: >> > >> > >> > On 2016/7/6 18:12, Stefano Stabellini wrote: >>> > > On Wed, 6 Jul 2016, Julien Grall wrote: > > >> > Hi Stefano, > > >> > > > >> > On 05/07/16 18:13, Stefano Stabellin

[Xen-devel] [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h

2016-07-12 Thread Anthony PERARD
Instead of having several representation of hvm_start_info in C, define it in public/xen.h so both libxc and hvmloader can use it. Signed-off-by: Anthony PERARD --- Changes in V6: - move C representation to public/arch-x86/hvm/start_info.h instead of public/xen.h Change in V5: - remove packed

[Xen-devel] [PATCH v6 09/14] hvmloader: Check modules whereabouts in perform_tests

2016-07-12 Thread Anthony PERARD
As perform_tests() is going to clear memory past 4MB, we check that the memory can be use or we skip the tests. Signed-off-by: Anthony PERARD --- Changes in V6: - define and use TEST_START and PT_END. - cast addresses to uintptr_t instead of uint32_t. - use UINTPTR_MAX for upper limit checks, in

[Xen-devel] [PATCH v6 02/14] libxc: Prepare a start info structure for hvmloader

2016-07-12 Thread Anthony PERARD
... and load BIOS/UEFI firmware into guest memory. This adds a new firmware module, system_firmware_module. It is loaded in the guest memory and final location is provided to hvmloader via the hvm_start_info struct. This patch create the hvm_start_info struct for HVM guest that have a device mode

Re: [Xen-devel] [PATCH v2 03/17] libxl/arm: Add a configuration option for ARM DomU ACPI

2016-07-12 Thread Shannon Zhao
On 2016年07月12日 22:33, Wei Liu wrote: > On Tue, Jul 12, 2016 at 10:17:20PM +0800, Shannon Zhao wrote: >> > On 2016年07月12日 19:33, Wei Liu wrote: >>> > > On Tue, Jul 12, 2016 at 10:22:39AM +0100, Julien Grall wrote: >>> > > [...] > > > >>Yeah, we can deprecate that field. But we need to t

[Xen-devel] [PATCH v6 08/14] hvmloader: Locate the BIOS blob

2016-07-12 Thread Anthony PERARD
The BIOS blob can be found an entry called "firmware" of the modlist of the hvm_start_info struct. The found BIOS blob is not loaded by this patch, but only passed as argument to bios_load() function. Signed-off-by: Anthony PERARD --- Changes in V6: - cast addresses to uintptr_t instead of uint

[Xen-devel] [PATCH v6 07/14] hvmloader: Grab the hvm_start_info pointer

2016-07-12 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Jan Beulich --- Changes in V6: - include xen/arch-x86/hvm/start_info.h Change in V4: - remove struct hvm_info_start redefinition, as it's moved to public/xen.h in a previous patch. Change in V3: - remove cmdline pars

[Xen-devel] [PATCH v6 00/14] Load BIOS via toolstack instead of been embedded in hvmloader.

2016-07-12 Thread Anthony PERARD
Hi all, V6: few changes detailed in patches. Missing acks on the following patches: 1 libxc: Rework extra module initialisation 2 libxc: Prepare a start info structure for hvmloader 5 libxl: Load guest BIOS from file 6 xen: Move the hvm_start_info C representation from libxc t

[Xen-devel] [PATCH v6 04/14] firmware/makefile: install BIOS blob ...

2016-07-12 Thread Anthony PERARD
... into the firmware directory, along with hvmloader. Signed-off-by: Anthony PERARD Acked-by: Wei Liu --- No change in V6. - acked Change in V5: - remove use of "variable" for SEABIOS_ROM and OVMF_ROM location there are static location - install seabios as bios.bin instead of seabios.bin Ch

[Xen-devel] [PATCH v6 12/14] hvmloader: bios->bios_load() now needs to be defined

2016-07-12 Thread Anthony PERARD
All BIOSes but ROMBIOS needs to be loaded via modules. ROMBIOS is handled as a special case. Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- Change in V5: - rename patch, was: "hvmloader: Specific bios_load function required" No change in V4. Change in V3: - reprint Main BIOS in bi

[Xen-devel] [PATCH v6 10/14] hvmloader: Load SeaBIOS from hvm_start_info modules

2016-07-12 Thread Anthony PERARD
... and do not include the SeaBIOS ROM into hvmloader anymore. This also fix the dependency on roms.inc, hvmloader.o does not include it. Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- Change in V6: acked Change in V5: - update BUG_ON in seabios_setup_e820(). Change in V4: - check

[Xen-devel] [PATCH v6 01/14] libxc: Rework extra module initialisation

2016-07-12 Thread Anthony PERARD
This patch use xc_dom_alloc_segment() to allocate the memory space for the ACPI modules and the SMBIOS modules. This is to replace the arbitrary placement of 1MB (+ extra for MB alignement) after the hvmloader image. This patch can help if one add extra ACPI table and hvmloader contain OVMF (OVMF

[Xen-devel] [PATCH v6 05/14] libxl: Load guest BIOS from file

2016-07-12 Thread Anthony PERARD
The path to the BIOS blob can be overriden by the xl's bios_path_override option, or provided by u.hvm.bios_firmware in the domain_build_info struct by other libxl user. Signed-off-by: Anthony PERARD --- Changes in V6: - use goto for error handling of libxl__load_hvm_firmware_module() Changes i

[Xen-devel] [PATCH v6 03/14] configure: #define SEABIOS_PATH and OVMF_PATH

2016-07-12 Thread Anthony PERARD
Those paths are to be used by libxl, in order to load the firmware in memory. If a system path is not defined via --with-system-seabios or --with-system-ovmf, then default to the Xen firmware directory. Signed-off-by: Anthony PERARD Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu --- Plea

[Xen-devel] [PATCH v6 11/14] hvmloader: Load OVMF from modules

2016-07-12 Thread Anthony PERARD
... and do not include the OVMF ROM into hvmloader anymore. Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- Change in V5: - define OVMF_END macro - fix some cast coding style Change in V4: - check if source and dest of ovmf binary does not overlaps Change in V3: - change makefile to n

[Xen-devel] [PATCH v6 13/14] hvmloader: Always build-in SeaBIOS and OVMF loader

2016-07-12 Thread Anthony PERARD
Signed-off-by: Anthony PERARD Acked-by: Jan Beulich --- tools/firmware/hvmloader/Makefile| 11 +-- tools/firmware/hvmloader/hvmloader.c | 4 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile ind

[Xen-devel] [PATCH v6 14/14] configure: do not depend on SEABIOS_PATH or OVMF_PATH ...

2016-07-12 Thread Anthony PERARD
... to compile SeaBIOS and OVMF. Only depend on CONFIG_*. If --with-system-* configure option is used, then set *_CONFIG=n to not compile SEABIOS and OVMF. Signed-off-by: Anthony PERARD Reviewed-by: Konrad Rzeszutek Wilk Acked-by: Wei Liu --- Please, run ./autogen.sh on this patch. No change

Re: [Xen-devel] [PATCH v3 05/17] libxl/arm: Generate static ACPI DSDT table

2016-07-12 Thread Shannon Zhao
On 2016年07月12日 19:38, Wei Liu wrote: > On Tue, Jul 12, 2016 at 11:50:32AM +0800, Shannon Zhao wrote: >> > >> > >> > On 2016/7/7 23:52, Wei Liu wrote: >>> > > On Tue, Jul 05, 2016 at 11:12:35AM +0800, Shannon Zhao wrote: > > >> > From: Shannon Zhao > > >> > > > >> > It uses static DS

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 10:42:07PM +0800, Shannon Zhao wrote: > > > >> > > > > >> > Does it mean we would need to update the slack to take into > > > >> > account the ACPI > > > >> > blob? > >>> > > Yes, we need to take into account the ACPI blob. Probably not in the > >>> > > sla

[Xen-devel] ACPI builder re-licensing

2016-07-12 Thread Boris Ostrovsky
Starting a new thread on ACPI code re-licensing, continuing from https://lists.xenproject.org/archives/html/xen-devel/2016-07/msg01245.html Summary == While working on refactoring ACPI builder code from tools/firmware/hvmloader/acpi/ and making it available to both hvmloader and libxl/libxc (

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Shannon Zhao
On 2016年07月12日 22:50, Wei Liu wrote: > On Tue, Jul 12, 2016 at 10:42:07PM +0800, Shannon Zhao wrote: >>> > > > >> > >>> > > > >> > Does it mean we would need to update the slack to >>> > > > >> > take into account the ACPI >>> > > > >> > blob? >

Re: [Xen-devel] [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 03:42:43PM +0100, Anthony PERARD wrote: > Instead of having several representation of hvm_start_info in C, define > it in public/xen.h so both libxc and hvmloader can use it. > Commit message is wrong. I think this can be easily handled during committing though. Now we ne

Re: [Xen-devel] [PATCH v6 02/14] libxc: Prepare a start info structure for hvmloader

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 03:42:39PM +0100, Anthony PERARD wrote: > ... and load BIOS/UEFI firmware into guest memory. > > This adds a new firmware module, system_firmware_module. It is loaded in > the guest memory and final location is provided to hvmloader via the > hvm_start_info struct. > > Thi

Re: [Xen-devel] [PATCH v6 05/14] libxl: Load guest BIOS from file

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 03:42:42PM +0100, Anthony PERARD wrote: > The path to the BIOS blob can be overriden by the xl's > bios_path_override option, or provided by u.hvm.bios_firmware in the > domain_build_info struct by other libxl user. > > Signed-off-by: Anthony PERARD > Acked-by: Wei Liu

Re: [Xen-devel] [PATCH v6 00/14] Load BIOS via toolstack instead of been embedded in hvmloader.

2016-07-12 Thread Wei Liu
I believe we only need a mechanical ack from Andrew and Jan for patch 6. I'm happy to take care of this series once everything is ready. Wei. ___ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel

Re: [Xen-devel] [PATCH v6 00/14] Load BIOS via toolstack instead of been embedded in hvmloader.

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 04:03:21PM +0100, Wei Liu wrote: > I believe we only need a mechanical ack from Andrew and Jan for patch 6. Spoke too soon. Patch 8 and 9 would also need acks. > I'm happy to take care of this series once everything is ready. > This stays the same. :-) Wei. ___

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Boris Ostrovsky
On 07/12/2016 10:57 AM, Shannon Zhao wrote: > On 2016年07月12日 22:50, Wei Liu wrote: >> On Tue, Jul 12, 2016 at 10:42:07PM +0800, Shannon Zhao wrote: >> Does it mean we would need to update the slack to take >> into account the ACPI >> blob

Re: [Xen-devel] [PATCH v6 01/14] libxc: Rework extra module initialisation

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 03:42:38PM +0100, Anthony PERARD wrote: > This patch use xc_dom_alloc_segment() to allocate the memory space for the > ACPI modules and the SMBIOS modules. This is to replace the arbitrary > placement of 1MB (+ extra for MB alignement) after the hvmloader image. > > This pa

Re: [Xen-devel] [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h

2016-07-12 Thread Andrew Cooper
On 12/07/16 15:42, Anthony PERARD wrote: > +#ifndef __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__ > +#define __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__ > + > +/* > + * C representation of the x86/HVM start info layout. > + * > + * The canonical definition of this layout resides in public/xen.h, this You

Re: [Xen-devel] xenbits "official" repo for XTF (was Re: [PATCH 0/2] xtf: add launcher (+1 bugfix)

2016-07-12 Thread George Dunlap
On Fri, Jul 8, 2016 at 2:06 PM, Andrew Cooper wrote: > However, OSSTest has always been known as OSSTest (including all > references in the automated emails), and not as a xen test framework. > Taking any steps to make OSSTest retroactively searchable as a xen test > framework is a dumb move, whic

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Wei Liu
On Tue, Jul 12, 2016 at 11:08:47AM -0400, Boris Ostrovsky wrote: > On 07/12/2016 10:57 AM, Shannon Zhao wrote: > > On 2016年07月12日 22:50, Wei Liu wrote: > >> On Tue, Jul 12, 2016 at 10:42:07PM +0800, Shannon Zhao wrote: > >> Does it mean we would need to update the slack to take

Re: [Xen-devel] [PATCH v2 16/17] libxc/xc_dom_arm: Copy ACPI tables to guest space

2016-07-12 Thread Boris Ostrovsky
On 07/12/2016 11:13 AM, Wei Liu wrote: > On Tue, Jul 12, 2016 at 11:08:47AM -0400, Boris Ostrovsky wrote: >> On 07/12/2016 10:57 AM, Shannon Zhao wrote: >>> On 2016年07月12日 22:50, Wei Liu wrote: On Tue, Jul 12, 2016 at 10:42:07PM +0800, Shannon Zhao wrote: Does it mean

[Xen-devel] [PATCH 1/6] libxl: add "merge" function to generic device type support

2016-07-12 Thread Juergen Gross
Instead of using a macro generating the code to merge xenstore and json configuration data, use the generic device type support for this purpose. This requires to add some accessor functions to the framework and a structure for disks (as disks are added separately they didn't need such a structure

[Xen-devel] [PATCH 4/6] libxl: split libxl vtpm code into one source

2016-07-12 Thread Juergen Gross
Put all vtpm related stuff of libxl into a dedicated source file. Signed-off-by: Juergen Gross --- tools/libxl/Makefile | 1 + tools/libxl/libxl.c | 302 --- tools/libxl/libxl_internal.h | 1 - tools/libxl/libxl_utils.c| 43 - tools/l

  1   2   >